⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 19, 2007:

6:39 PM Changeset in webkit [27914] by alp@webkit.org
  • 3 edits in trunk/WebCore

2007-11-19 Doug Turner <​dougt@meer.net>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16054
Crash when GlyphPage::fill is called with more than 256 bytes of data

​http://bugs.webkit.org/show_bug.cgi?id=14446
[GDK] Crash on ​http://www.wikipedia.org/

setGlyphDataForIndex() uses a fixed array of size 256 which we can't
exceed. We need to return failure if the buffer has Unicode
supplementary characters for now.

This strategy matches the Win port, which also doesn't support this
case yet.

Add an assertion so nobody makes this mistake again.

  • platform/GlyphPageTreeNode.h: (WebCore::GlyphPage::setGlyphDataForIndex):
  • platform/gtk/GlyphPageTreeNodeGtk.cpp: (WebCore::GlyphPage::fill):
4:24 PM Changeset in webkit [27913] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

wx port build fix (wx headers include ctype functions).

2:53 PM Changeset in webkit [27912] by Antti Koivisto
  • 5 edits in trunk/LayoutTests

Rubber-stamped by bdash.


Improve coverage of these tests.

  • media/video-muted-expected.txt:
  • media/video-muted.html:
  • media/video-volume-expected.txt:
  • media/video-volume.html:
11:39 AM BuildingGtk edited by alp@atoker.com
Note the targets supported by the GTK+ port (diff)
11:00 AM Changeset in webkit [27911] by kevino@webkit.org
  • 1 edit
    2 deletes in trunk/JavaScriptCore

Remove outdated and unused Windows port files.

Reviewed by Adam Roben.

10:01 AM Changeset in webkit [27910] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-11-19 Doug Turner <​dougt@meer.net>

Reviewed by Timothy Hatcher.

​http://bugs.webkit.org/show_bug.cgi?id=16050
sqlite3_prepare16_v2 build bustage.

Using the correct SQLITE_VERSION_NUMBER around sqlite_prepare16_v2
to fix build bustage.

  • platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::prepare):
9:56 AM Changeset in webkit [27909] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-19 Mark Rowe <​mrowe@apple.com>

Build fix. Don't over-qualify the constructor name.

  • storage/DatabaseDetails.h:
9:51 AM Changeset in webkit [27908] by beidson@apple.com
  • 11 edits
    1 add in trunk

WebCore:

Reviewed by Maciej

Stub out the WebCore parts of the WebKit API

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/DatabaseDetails.h: Added. Simple container for vitals on a specific database (WebCore::DatabaseDetails::DatabaseDetails::DatabaseDetails): (WebCore::DatabaseDetails::DatabaseDetails): (WebCore::DatabaseDetails::isValid): (WebCore::DatabaseDetails::name): (WebCore::DatabaseDetails::version): (WebCore::DatabaseDetails::displayName): (WebCore::DatabaseDetails::expectedUsage): (WebCore::DatabaseDetails::currentUsage):
  • storage/DatabaseTracker.cpp: Added various methods for API usage (WebCore::DatabaseTracker::detailsForNameAndOrigin): (WebCore::DatabaseTracker::usageForOrigin): (WebCore::DatabaseTracker::quotaForOrigin): (WebCore::DatabaseTracker::setQuota):
  • storage/DatabaseTracker.h:

WebKit:

Reviewed by Maciej

  • WebKit.xcodeproj/project.pbxproj: Sorted!

WebKit/mac:

Reviewed by Maciej

Finished hooking up the WebKit API for database management.
Most of the API is actually implemented in WebCore and some of those methods might
only be stubs for now.

  • Storage/WebDatabaseManager.mm: (-[WebDatabaseManager origins]): Call through to the WebCore tracker and construct an API result (-[WebDatabaseManager databasesWithOrigin:]): Ditto (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Ditto
  • Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin usage]): Call through to WebCore (-[WebSecurityOrigin quota]): Ditto (-[WebSecurityOrigin setQuota:]): Ditto (-[WebSecurityOrigin _core]): Get WebCore version of this object
  • Storage/WebSecurityOriginInternal.h:
9:28 AM Changeset in webkit [27907] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx port build fix for !USE(WXGC).

7:59 AM Changeset in webkit [27906] by alp@webkit.org
  • 2 edits
    1 add
    1 delete in trunk/WebKitTools

2007-11-19 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16040
[GTK] GtkLauncher should be written in C

Port GtkLauncher to plain C.

Use a more conventional GTK+ coding style.

Use a toolbar instead of menus.

Various signature fixes and cleanups.

Add a license header. Assume all previous modifications were copyright
assigned to Apple Inc. by default.

  • GtkLauncher/GtkLauncher.pro:
  • GtkLauncher/main.c: Added. (activate_url_entry_cb): (update_title): (link_hover_cb): (title_change_cb): (progress_change_cb): (destroy_cb): (go_back_cb): (go_forward_cb): (create_browser): (create_statusbar): (create_toolbar): (create_window): (main):
  • GtkLauncher/main.cpp: Removed.
7:53 AM Changeset in webkit [27905] by alp@webkit.org
  • 3 edits in trunk/WebCore

2007-11-19 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

GTK+ drawing fixes.

Add a check to avoid crashing when the GraphicsContext is not
associated with a GdkDrawable. This was noticed when adding printing
support but might be triggered in other situations too.

Do not render themes when painting is disabled. This is an
optimisation for cases where GraphicsContext is used to calculate page
dimensions etc. without actually rendering.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::gdkDrawable):
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozWidget):
7:33 AM Changeset in webkit [27904] by treat@webkit.org
  • 2 edits in trunk/WebKit/qt
  • Don't segfault when event pos is outside of the widget.
5:43 AM Changeset in webkit [27903] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-13 Rahul Abrol <​ra5ul@comcast.net>

Reviewed by Tim Hatcher.

​http://bugs.webkit.org/show_bug.cgi?id=15977
Resizing images preference now toggles default image state.

  • loader/ImageDocument.cpp: (WebCore::ImageDocument::ImageDocument): (WebCore::ImageDocument::createDocumentStructure): (WebCore::ImageDocument::imageChanged):
5:02 AM Changeset in webkit [27902] by mrowe@apple.com
  • 6 edits in trunk/WebCore

Roll out r27896 as it caused lots of build breakages.

4:51 AM Changeset in webkit [27901] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-19 Mark Rowe <​mrowe@apple.com>

Build fix.

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::initFrameBuffer):
4:47 AM Changeset in webkit [27900] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-19 Mark Rowe <​mrowe@apple.com>

Build fix.

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::initFrameBuffer): Remove reference to SkBitmap type that doesn't belong.
4:37 AM Changeset in webkit [27899] by mrowe@apple.com
  • 14 edits in trunk

2007-11-19 Kevin Ollivier <​kevino@theolliviers.com>

Build script fixes to ensure they do the right thing for the
wx port, and update build-wxwebkit to reflect the way the
build scripts now work.

Reviewed by Adam.

  • Scripts/build-testkjs:
  • Scripts/build-webkit:
  • Scripts/run-javascriptcore-tests:
  • Scripts/webkitdirs.pm:
  • wx/build-wxwebkit:

2007-11-19 Kevin Ollivier <​kevino@theolliviers.com>

Add pcre directory to JSCore includes, and update the wx port
to reflect the Shared -> RefCounted name change. Also, fix
WebFrame.cpp to re-enable code that should never have been
committed disabled.

Reviewed by Adam.

2007-11-19 Kevin Ollivier <​kevino@theolliviers.com>

Update wx port build sources with recent changes, update
wx FontPlatformData to be a class (MSVC7 gets confused
otherwise...) and implement its hash() method.

Reviewed by Adam.

  • WebCoreSources.bkl:
  • platform/wx/FontPlatformData.h: (WebCore::FontPlatformData::hash):
4:30 AM Changeset in webkit [27898] by mrowe@apple.com
  • 8 edits
    4 adds in trunk

2007-11-19 Julien Chaffraix <​julien.chaffraix@gmail.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12194
Bug 12194: Trying to access XMLHttpRequest.responseText or responseXML when they
are not available should raise an exception

Tests: http/tests/xmlhttprequest/xmlhttprequest-responseText-exception.html

http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception.html

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseText): (WebCore::XMLHttpRequest::getResponseXML):
  • xml/XMLHttpRequest.h:

2007-11-19 Julien Chaffraix <​julien.chaffraix@gmail.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12194
Bug 12194: Trying to access XMLHttpRequest.responseText or responseXML when they are not
available should raise an exception

  • http/tests/xmlhttprequest/xmlhttprequest-responseText-exception-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-responseText-exception.html: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception.html: Added.
  • http/tests/xmlhttprequest/zero-length-response-expected.txt: Updated result
  • http/tests/xmlhttprequest/zero-length-response-sync-expected.txt: Updated result
  • http/tests/xmlhttprequest/zero-length-response-sync.html: Corrected URL & added exception handling to test case
4:22 AM Changeset in webkit [27897] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-19 Peter Kasting <​zerodpx@gmail.com>

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=15971
The GIF decoder should not fail decoding if the caller asks it to
decode again when no new data has arrived since the last call.

  • platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read):
4:22 AM Changeset in webkit [27896] by mrowe@apple.com
  • 6 edits in trunk/WebCore

2007-11-19 Peter Kasting <​zerodpx@gmail.com>

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=15974
GIF decoding should respect frames' specified disposal methods.

  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::setDisposalMethod):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameBufferAtIndex): (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::GIFImageDecoder::prepEmptyFrameBuffer): (WebCore::GIFImageDecoder::haveDecodedRow): (WebCore::GIFImageDecoder::frameComplete):
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read):
  • platform/image-decoders/gif/GIFImageReader.h: (GIFFrameReader::GIFFrameReader):

Nov 18, 2007:

11:14 PM Changeset in webkit [27895] by beidson@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Eric

Fix a crash hashing a default SecurityOriginData object

  • storage/DatabaseTracker.cpp: (WebCore::SecurityOriginDataHash::hash): The default object has some default strings with NULL StringImpls - don't try to hash those!
4:40 PM Changeset in webkit [27894] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2007-11-18 Eric Seidel <​eric@webkit.org>

Reviewed by Oliver.

  • tests/mozilla/jsDriver.pl: exit non-0 when user aborts test run
3:04 PM Changeset in webkit [27893] by timothy@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Sam Weinig.

Bug 16043: Remove InspectorController.log now that console.log works
​http://bugs.webkit.org/show_bug.cgi?id=16043

Remove the last uses of InspectorController.log. Once use was no longer needed,
checking an erro case that can't happen anymore. The other case now uses console.error.

  • page/InspectorController.cpp: Remove the log function. (WebCore::InspectorController::windowScriptObjectAvailable): Remove the log function from InspectorController script class.
  • page/inspector/DocumentPanel.js: Remove a use of InspectorController.log that isn't needed.
  • page/inspector/Panel.js: Change InspectorController.log to console.log and early return.
3:01 PM Changeset in webkit [27892] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Bug 16041: REGRESSION: the Database panel in the Inspector stopped showing errors
​http://bugs.webkit.org/show_bug.cgi?id=16041

  • page/inspector/DatabasePanel.js: Implement error callbacks to pass to executeSql() and transaction(). Refactored some code for the success and error callbacks to use.
2:18 PM Changeset in webkit [27891] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2007-11-18 Eric Seidel <​eric@webkit.org>

Reviewed by Anders.

Make run-javascriptcore-tests report failures on exit (to support git bisect)

  • Scripts/run-javascriptcore-tests:
9:54 AM Changeset in webkit [27890] by ap@webkit.org
  • 3 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Make run-webkit-tests work with Windows debug build.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
  • DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT, as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically, and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
9:15 AM Changeset in webkit [27889] by kevino@webkit.org
  • 3 edits
    5 adds in trunk/WebKitTools

Add wxWebKit sample and build script, and integrate it with build-webkit. Also make build-webkit --clean work for all ports.

Reviewed by Darin Adler.

7:44 AM QtWebKitTodo edited by treat@kde.org
Updates (diff)
3:31 AM Changeset in webkit [27888] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-11-18 Christian Dywan <​christian@twotoasts.de>

Reviewed by Alp.

​http://bugs.webkit.org/show_bug.cgi?id=15891
[GTK] Javascript console and dialogs are not implemented

Correct script-prompt to return NULL when cancelled.

Small changes to avoid compiler warnings.

  • Api/webkitgtkpage.cpp:
1:49 AM Changeset in webkit [27887] by ap@webkit.org
  • 1 edit in trunk/LayoutTests/fast/parser/html-whitespace.html

Restoring a binary svn:mime-type on the test.

1:46 AM Changeset in webkit [27886] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Maciej.

<rdar://problem/5546393> Whitespace handling doesn't match HTML5.

HTML5 definition is the same as MSIE's, with the exception that the latter strips null
characters. Firefox also treats U+0008 as whitespace, but not U+000B or U+000C.

Test: fast/parser/html-whitespace.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseTag): Use isASCIISpace, which matches HTML5 definition of whitespace, and also what we use to check for whitespace almost everywhere.
1:09 AM Changeset in webkit [27885] by mrowe@apple.com
  • 20 edits in trunk

Fix: <rdar://problem/5607032> (REGRESSION: testapi exits with assertion failure in debug build) and <rdar://problem/5440659> (JSGlobalContextCreate throws away globalObjectClass's prototype)

Split Interpreter's initialization into two distinct steps: the creation of the global prototypes
and constructors, and storing them on the global object. This allows JSClassRef's passed to
JSGlobalContextCreate to be instantiated with the correct prototype.

Reviewed by Darin Adler.

Note: See TracTimeline for information about the timeline view.