⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 25, 2007:

11:29 PM Changeset in webkit [28038] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix a leak pointed out by Alexey

  • WebView.cpp: (getUpdateRects): Use a Vector<unsigned char>, since OwnPtr doesn't know to call delete[].
11:06 PM Changeset in webkit [28037] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Bug 16052: prepare-ChangeLog doesn't report deleted files
<​http://bugs.webkit.org/show_bug.cgi?id=16052>

Reviewed by Sam.

  • Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
11:02 PM Changeset in webkit [28036] by Adam Roben
  • 3 edits in trunk/WebKit/win

Fix Bug 16138: Reduce code duplication in WebView.cpp

​http://bugs.webkit.org/show_bug.cgi?id=16138

Reviewed by Sam.

  • WebView.cpp: (getUpdateRects): Factored code out of updateBackingStore and paint into this new helper function. (WebView::updateBackingStore): Use getUpdateRects. (WebView::paint): Ditto. (WebView::paintIntoBackingStore): Changed to take a const IntRect&. (WebView::paintIntoWindow): Ditto.
  • WebView.h:
10:00 PM Changeset in webkit [28035] by ddkilzer@apple.com
  • 2 edits
    1 delete in trunk/WebKitTools

Bug 15864: Replace merge-changelog with resolve-ChangeLogs
<​http://bugs.webkit.org/show_bug.cgi?id=15864>

Reviewed by Adam.

Roll functionality of merge-changelog into resolve-ChangeLogs
script. The script now checks for ChangeLog.rej and
ChangeLog.orig files first. If it finds them, it uses the
ChangeLog.rej file as a patch (in old contextual diff format) to
apply with --fuzz=3.

  • Scripts/merge-changelog: Removed.
  • Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
9:26 PM Changeset in webkit [28034] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Add a known failure.
9:25 PM Changeset in webkit [28033] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Remove an unnecessary entry.
8:16 PM Changeset in webkit [28032] by weinig@apple.com
  • 4 edits
    2 adds in trunk/WebKitTools

Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.

Reviewed by Mark Rowe.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
  • DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
  • DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
7:52 PM Changeset in webkit [28031] by weinig@apple.com
  • 2 edits
    4 adds in trunk/WebKitTools

Convert DumpRenderTree to ues .xcconfig files.

Reviewed by Mark Rowe.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/Configurations: Added.
  • DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
6:54 PM Changeset in webkit [28030] by weinig@apple.com
  • 12 edits
    8 adds in trunk/WebKitTools

Add ForwardingHeaders to wtf for DumpRenderTree.

Reviewed by Mark Rowe.

  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/ForwardingHeaders: Added.
  • DumpRenderTree/ForwardingHeaders/wtf: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
  • DumpRenderTree/LayoutTestController.cpp:
  • DumpRenderTree/WorkQueue.cpp:
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/FrameLoadDelegate.mm:
  • DumpRenderTree/mac/JavaScriptThreading.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/mac/ObjCController.m:
  • DumpRenderTree/mac/UIDelegate.mm:
  • DumpRenderTree/mac/WorkQueueItemMac.mm:
6:37 PM Changeset in webkit [28029] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-25 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Maciej Stachowiak.

Remove the unneeded CFNETWORK #ifdefs.

  • loader/NetscapePlugInStreamLoader.h:
6:12 PM Changeset in webkit [28028] by mrowe@apple.com
  • 5 edits in trunk/WebCore

2007-11-24 Laszlo Gombos <​laszlo.gombos@gmail.com>

Reviewed by Sam Weinig.

Add printf format attribute to several functions. Use the the new WTF_ATTRIBUTE_PRINTF define.

  • dom/XMLTokenizer.cpp:
  • dom/XMLTokenizer.h:
  • platform/DeprecatedString.h:
  • platform/PlatformString.h:
6:12 PM Changeset in webkit [28027] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2007-11-24 Laszlo Gombos <​laszlo.gombos@gmail.com>

Reviewed by Maciej Stachowiak.

Fix minor compiler warning (GCC 4.1.3)

  • pcre/pcre_internal.h:
  • pcre/pcre_ucp_searchfuncs.cpp: (_pcre_ucp_othercase):
5:53 PM Changeset in webkit [28026] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix some test failures caused by r28019

Now that stdout is in binary mode, we need to always use printf
instead of wprintf. Otherwise we'll end up with UTF-16 characters in
the output.

Reviewed by Sam.

  • DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with printf. (UIDelegate::runJavaScriptAlertPanelWithMessage): (UIDelegate::runJavaScriptConfirmPanelWithMessage): (UIDelegate::runJavaScriptTextInputPanelWithPrompt): (UIDelegate::webViewAddMessageToConsole):
5:06 PM Changeset in webkit [28025] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

  • fix off-center error images

Covered by many pixel tests with missing images

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint): Account for the 1 pixel outline when positioning the error image.
4:13 PM Changeset in webkit [28024] by Adam Roben
  • 2 edits in trunk/WebKitTools

Set the font smoothing preference in DRT

This makes the pixel results on Windows closer to the Mac results.

Reviewed by Mitz.

  • DumpRenderTree/win/DumpRenderTree.cpp: (initializePreferences):
4:03 PM Changeset in webkit [28023] by Adam Roben
  • 4 edits
    2 adds in trunk

Fix Bug 16133: Implement pixel test support on Windows

WebKit/win:

Add ImageDiff.vcproj to WebKit.sln

Reviewed by Sam.

  • WebKit.vcproj/WebKit.sln:

WebKitTools:

Port ImageDiff to CG and C++

Final part of ​http://bugs.webkit.org/show_bug.cgi?id=16133
<rdar://5071708>

Reviewed by Sam.

  • DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
  • DumpRenderTree/cg/ImageDiffCG.cpp: Added. (main): (createImageFromStdin): (compareImages): (getDifferenceBitmap): (computePercentageDifferent):
  • DumpRenderTree/win/ImageDiff.vcproj: Added.
4:03 PM Changeset in webkit [28022] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix image diff link generation on Windows

Reviewed by Sam.

  • Scripts/run-webkit-tests: Removed unnecessary and incorrect calls to toURL.
4:02 PM Changeset in webkit [28021] by Adam Roben
  • 3 edits
    7 adds in trunk/WebKitTools

Implement pixel dumping in Windows DRT

Part of ​http://bugs.webkit.org/show_bug.cgi?id=16133
<rdar://5071708>

Reviewed by Sam.

  • DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added. (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a Content-Length header. (getMD5HashStringForBitmap): (dumpWebViewAsPixelsAndCompareWithExpected):
  • DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
  • DumpRenderTree/win/DumpRenderTree.cpp: (dump): Do a pixel dump if requested. (main): Parse pixel test options.
  • DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added the cg/ subdirectory to the include path.
  • DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't available in a header or import library, so we have to go through this LoadLibrary/GetProcAddress dance to use them. (cryptDLL): (init): (update): (final): (MD5_Init): (MD5_Update): (MD5_Final):
  • DumpRenderTree/win/MD5.h: Added.
  • DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be moved up to the top level to share it with Mac eventually.
  • DumpRenderTree/win/PixelDumpSupportWin.cpp: Added. (getBitmapContextFromWebView): Forces the WebView to paint using a WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
4:02 PM Changeset in webkit [28020] by Adam Roben
  • 2 edits in trunk/WebKitTools

Clean up Windows DRT's option parsing a little bit

Reviewed by Sam.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main): Put non-option arguments into a Vector.
4:01 PM Changeset in webkit [28019] by Adam Roben
  • 3 edits in trunk/WebKitTools

Make Windows DRT stop changing LF into CRLF

Reviewed by Sam.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main): Put stdout in binary mode.
  • Scripts/run-webkit-tests: Remove the CRLF hack.
2:14 PM Changeset in webkit [28018] by mrowe@apple.com
  • 3 edits
    3 adds in trunk

Fix bug 16129: REGRESSION (r27761-r27811): malloc error while visiting ​http://mysit.es (crashes release build)

  • pcre/pcre_compile.cpp: Change errorcode to be passed by reference so that any error code is propagated

to our caller like they expect.

Reviewed by Dan Bernstein.

1:16 PM Changeset in webkit [28017] by kevino@webkit.org
  • 4 edits in trunk

wx build fixes for Linux/GTK+ port.

5:06 AM Changeset in webkit [28016] by Nikolas Zimmermann
  • 1 edit in trunk/WebCore/ChangeLog

Fix wrong bug number in ChangeLog. Not reviewed.

5:04 AM Changeset in webkit [28015] by Nikolas Zimmermann
  • 14 edits
    4 adds in trunk

Reviewed by Adam Roben.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=15393

Fix problems with hidden glyphs. They were taken into account for quite
some operations (hit testing, length calulcations etc..) except painting.
Especially fixes boundaries of <textPath> (see using Web Inspector) if
text-anchor isn't equal to 'start'.

Added testcase:
svg/text/textPathBoundsBug.svg

Fixed testcase: (all showed text selection problems on text paths)
svg/batik/text/textGlyphOrientationHorizontal.svg
svg/batik/text/textOnPath.svg
svg/batik/text/textOnPath3.svg
svg/batik/text/verticalTextOnPath.svg
svg/text/text-align-04-b.svg
svg/W3C-SVG-1.1/text-align-04-b.svg

1:45 AM Changeset in webkit [28014] by ap@webkit.org
  • 9 edits
    2 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=15919
XSLTProcessor.transformToFragment creates an extra not defined TEXT_NODE at the end

Test: fast/xsl/extra-lf-at-end.html

  • xml/XSLTProcessor.cpp: (WebCore::writeToVector): Changed to use Vector to avoid slow String::apend(). (WebCore::saveResultToString): Remove trailing line feed if present.
12:48 AM Changeset in webkit [28013] by alp@webkit.org
  • 7 edits in trunk/WebKit/gtk

2007-11-24 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=15691
[GTK] Public API does not follow GTK+ conventions

Public API enhancements:

Implement webkit_page_get_editable() and webkit_page_set_editable().

Implement webkit_frame_get_name().

Remove definitions for functions that are unusable or not implemented.
This has caused much confusion for application developers.

Improve documentation.

Correct/constify some return types.

Add parameter checks.

Make the default fixed font "Courier New" to match the other Web
font names.

  • Api/webkitgtkframe.cpp:
  • Api/webkitgtkframe.h:
  • Api/webkitgtkpage.cpp:
  • Api/webkitgtkpage.h:
  • Api/webkitgtkprivate.h:
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::isEditable):

Nov 24, 2007:

11:15 PM Changeset in webkit [28012] by ddkilzer@apple.com
  • 3 edits in trunk/LayoutTests

Added tests for select.options.remove(boolean).

Reviewed by Maciej.

  • fast/js/resources/select-options-add.js: Added two tests.
  • fast/js/select-options-add-expected.txt: Updated results.
7:39 PM Changeset in webkit [28011] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-11-24 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16125
[GTK] Up key doesn't work properly when content is editable

Add a missing 'break' to avoid falling through to the next case when
handling VK_UP keystrokes. This was noticed when working on editing
support in the GTK+ port.

I've checked the other cases for similar typos and they seem fine.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeypress):
7:13 PM Changeset in webkit [28010] by ddkilzer@apple.com
  • 1 edit
    1 delete in trunk/WebKitTools

2007-11-24 David Kilzer <​ddkilzer@webkit.org>

Removed empty directory.

  • Scripts/resources: Removed.
6:53 PM Changeset in webkit [28009] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-11-24 Xan Lopez <​xan@gnome.org>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=15745
[GTK] Arrow keys do not Scroll


  • Api/webkitgtkpage.cpp:

Support Up/Down/Right/Left keys to scroll. Slight hack, see FIXME for
details.

5:23 PM Changeset in webkit [28008] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-11-24 Christian Dywan <​christian@twotoasts.de>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=15891
[GTK] Javascript console and dialogs are not implemented

Fix call to gtk_message_dialog_new() which expects a format string.

  • Api/webkitgtkpage.cpp:
4:23 PM HackingGtk edited by alp@atoker.com
Mention the build bots (diff)
3:56 PM Changeset in webkit [28007] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Tiger build fix.

Use WebCFAutorelease in place of NSMakeCollectable then autorelease as this also works on Tiger.

3:48 PM Changeset in webkit [28006] by mrowe@apple.com
  • 7 edits in trunk

Fix <rdar://problem/5432686> 333MB RPRVT seems to leak @ www.43folders.com (1hr plug-in stream).
​http://bugs.webkit.org/show_bug.cgi?id=13705

Reviewed by Tim Hatcher.

Have NP_ASFILE and NP_ASFILEONLY streams write the data to disk as they receive it rather than
dumping the data to disk in a single go when the stream has completed loading. On a test case
involving a 150MB Flash movie being streamed from a local web server this reduces memory consumption
on page load from around 400MB to 22MB.

The only plugin I have found that uses NP_ASFILE or NP_ASFILEONLY on the Mac is our NetscapeMoviePlugin
example code so the NP_ASFILE portion of this change has not had any testing with a real-world plugin.

3:43 PM Changeset in webkit [28005] by Adam Roben
  • 8 edits
    2 deletes in trunk

Get rid of WebCoreSystemInterface on Windows

WebCore:

Get rid of WebCoreSystemInterface on Windows

The one function defined in that file is now in WebKitSystemInterface.

Reviewed by Tim.

  • WebCore.vcproj/WebCore.vcproj: Removed WebCoreSystemInterface.{cpp,h}.
  • platform/graphics/cg/ImageCG.cpp: Made #include of WebCoreSystemInterface.h Mac-only.
  • platform/win/GraphicsContextWin.cpp: Ditto.
  • platform/win/WebCoreSystemInterface.cpp: Removed.
  • platform/win/WebCoreSystemInterface.h: Removed.

WebKitLibraries:

Add wkSetPatternPhaseInUserSpace to WebKitSystemInterface on Windows

Reviewed by Tim.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h: Added declaration.
  • win/lib/WebKitSystemInterface.lib: Updated.
  • win/lib/WebKitSystemInterface_debug.lib: Updated.
3:33 PM Changeset in webkit [28004] by Adam Roben
  • 6 edits in trunk/WebCore

Replace uses of %@ with %s in the inspector

Rubberstamped by Tim.

  • English.lproj/InspectorLocalizedStrings.js: Changed %@ to %s.
  • page/inspector/DatabasePanel.js: Ditto.
  • page/inspector/StylesSidebarPane.js: Ditto.
  • page/inspector/inspector.js: Ditto.
  • page/inspector/utilities.js: (String.vsprintf): Removed @ as a format specifier.
3:32 PM Changeset in webkit [28003] by Adam Roben
  • 3 edits in trunk/WebCore

Windows build fix

Turn off the change made in r27984 on Windows for now.

  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::transformToString):
  • xml/XSLTUnicodeSort.cpp:
2:35 PM Changeset in webkit [28002] by timothy@apple.com
  • 12 edits in trunk/WebCore

Reviewed by Adam Roben.

Bug 16121: Web Inspector needs helper functions that pass a 'this' object to
addEventListener and setTimeout
​http://bugs.webkit.org/show_bug.cgi?id=16121

Add Function.prototype.bind. This helper will return a wrapper function
that will call the original function with the supplied arguments
and using the supplied 'this' object.

  • page/inspector/Database.js: Remove a use of setTimeout by inheriting some common functions from Resource.
  • page/inspector/DatabasePanel.js: Use the new bind function.
  • page/inspector/ConsolePanel.js: Ditto.
  • page/inspector/DocumentPanel.js: Ditto.
  • page/inspector/NetworkPanel.js: Ditto.
  • page/inspector/PropertiesSection.js: Ditto.
  • page/inspector/Resource.js: Ditto.
  • page/inspector/SidebarPane.js: Ditto.
  • page/inspector/inspector.html: Moved Database.js after Resource.js, now that Database.js uses it.
  • page/inspector/inspector.js: Use the new bind function. Also removed a setTimeout used for the localized strings code. There is now a load event listener added to the localized strings script element that will call WebInspector.loaded.
  • page/inspector/utilities.js: Add Function.prototype.bind.
2:20 PM Changeset in webkit [28001] by timothy@apple.com
  • 1 edit in trunk/WebCore/English.lproj/InspectorLocalizedStrings.js

Add missing strings.

1:52 PM Changeset in webkit [28000] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-11-24 Christian Dywan <​christian@twotoasts.de>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=15793
[GTK] Webkit doesn't show title attribute tooltip when hovering over an image

Implement tooltip support using the new Tooltip API.

Support for older versions of GTK+ is still lacking.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::setToolTip):
11:18 AM Changeset in webkit [27999] by timothy@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Adam Roben.

Bug 16112: Some Web Inspector UI elements use offsetWidth and offsetHeight before the stylesheet loads
​http://bugs.webkit.org/show_bug.cgi?id=16112

In the places where we use offsetWidth and offsetHeight before
the stylesheet loads there is now a check. If the body's
offsetWidth is not greater than zero, then set a timeout
to do the updates requiring the stylesheet later.

The three places this happened:

  • DOM tree selection highlight would show up at the wrong height when using Inspect Element to open the inspector.
  • DOM tree breadcrumbs would not collapse when using Inspect Element to open the inspector.
  • Network Timeline divider lines would not show when opening directly into the timeline.
  • page/inspector/DocumentPanel.js: Check if the stylesheet loaded.
  • page/inspector/NetworkPanel.js: Ditto.
  • page/inspector/inspector.html: Include the stylesheet before any scripts, this will help get it loaded sooner.
10:18 AM Changeset in webkit [27998] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Add wx implementation for pathGetFilename

Reviewed by David D. Kilzer.

Note: See TracTimeline for information about the timeline view.