⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 26, 2007:

7:28 PM Changeset in webkit [28069] by beidson@apple.com
  • 13 edits in trunk

WebCore:

Reviewed by Mark Rowe

Allow setting the default storage quota per database origin

  • WebCore.base.exp:
  • page/Settings.cpp: (WebCore::Settings::setDefaultDatabaseOriginQuota): (WebCore::Settings::defaultDatabaseOriginQuota):
  • page/Settings.h:
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker): (WebCore::DatabaseTracker::setDefaultOriginQuota): (WebCore::DatabaseTracker::defaultOriginQuota):
  • storage/DatabaseTracker.h:

WebKit/mac:

Reviewed by Mark Rowe

Provide API for setting the default storage quota per database origin

  • Misc/WebNSDictionaryExtras.h:
  • Misc/WebNSDictionaryExtras.m: (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Helper for UINT64 preferences
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.m: (-[WebPreferences _unsignedLongLongValueForKey:]): Helper for UINT64 prefs (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto (-[WebPreferences defaultDatabaseQuota]): (-[WebPreferences setDefaultDatabaseQuota:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Set the WebCore Settings version of the default storage pref
7:01 PM Changeset in webkit [28068] by alp@webkit.org
  • 6 edits in trunk/WebCore

2007-11-26 Peter Kasting <​zerodpx@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=15974
GIF decoding should respect frames' specified disposal methods.

  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::setDisposalMethod):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameBufferAtIndex): (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::GIFImageDecoder::prepEmptyFrameBuffer): (WebCore::GIFImageDecoder::haveDecodedRow): (WebCore::GIFImageDecoder::frameComplete):
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read):
  • platform/image-decoders/gif/GIFImageReader.h: (GIFFrameReader::GIFFrameReader):
6:20 PM Changeset in webkit [28067] by Adam Roben
  • 5 edits in trunk

Make WebKitGraphics able to handle grayscale colors

WebCore:

Add a Color(CGColorRef) constructor

Reviewed by Darin.

  • platform/graphics/Color.h:
  • platform/graphics/cg/ColorCG.cpp: (WebCore::Color::Color): Added.

WebKit/win:

Take advantage of the new Color constructor that takes a CGColorRef

This lets us handle grayscale colors (which only have 2 components).

Reviewed by Darin.

  • WebKitGraphics.cpp: (DrawTextAtPoint):
6:15 PM Changeset in webkit [28066] by adele@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Update to last change. Moved addPendingSheet call to within nil check for m_cachedSheet.

  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
6:08 PM Changeset in webkit [28065] by alp@webkit.org
  • 7 edits in trunk/WebKit/gtk

2007-11-26 Alp Toker <​alp@atoker.com>

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=16149
Implement the window-object-cleared signal

This implementation provides the JSGlobalContextRef and JSObjectRef
directly rather than using an intermediate JS wrapper object, similar
to the approach taken by the Win port.

  • Api/webkitgtk-marshal.list:
  • Api/webkitgtkframe.h:
  • Api/webkitgtkpage.cpp:
  • Api/webkitgtkpage.h:
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::windowObjectCleared):
6:07 PM Changeset in webkit [28064] by adele@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5591583> CrashTracer: [USER] 157 in Mail crashes at -[WebCoreFrameBridge reapplyStylesForDeviceType:]

  • page/Frame.cpp: Add nil checks since every other caller of requestCSSStyleSheet checks for nil. (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader):
6:05 PM Changeset in webkit [28063] by mrowe@apple.com
  • 2 edits in trunk/WebCore

GCC 4.2 build fix.

  • xml/XSLTUnicodeSort.cpp: Add another WTF_ATTRIBUTE_PRINTF.
5:52 PM Changeset in webkit [28062] by weinig@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

Reviewed and touched up by Sam Weinig.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16073

Test: http/tests/security/xss-DENIED-invalid-domain-change.html

  • dom/Document.cpp: (WebCore::Document::setDomain): Don't set the securityOrigin policy unless the set succeeds. Adds some early returns as well.

LayoutTests:

Reviewed by Sam Weinig.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=16073

  • http/tests/security/resources/iframe-invalid-domain-change.html: Added.
  • http/tests/security/xss-DENIED-invalid-domain-change-expected.txt: Added.
  • http/tests/security/xss-DENIED-invalid-domain-change.html: Added.
5:35 PM Changeset in webkit [28061] by Darin Adler
  • 3 edits in trunk/WebKit/mac

Reviewed by Adele.

  • some middle-mouse-button-related fixes

These don't affect Safari since it maps the middle mouse button to the command key,
but that might not always be the case for future versions.

  • WebView/WebHTMLView.mm: (-[WebHTMLView otherMouseDown:]): Pass through middle mouse down events to WebCore. (-[WebHTMLView otherMouseDragged:]): Ditto, for drag events. (-[WebHTMLView otherMouseUp:]): Ditto, for up events.
  • WebView/WebPolicyDelegate.h: Fixed inaccurate documentation of WebActionButtonKey.
5:25 PM Changeset in webkit [28060] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Build fix.

  • WebKit.vcproj/WebKit.make:
5:08 PM Changeset in webkit [28059] by sfalken@apple.com
  • 5 edits in trunk

WebCore:

Build fix.

  • WebCore.vcproj/WebCore.make:
  • WebCore.vcproj/migrate-idls.sh:

WebKit/win:

Build fix.

  • WebKit.vcproj/build-generated-files.sh:
4:50 PM Changeset in webkit [28058] by Darin Adler
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Mitz.

Test: fast/js/regexp-overflow.html

  • pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags): Removed a stray "ptr++" that I added by accident when merging the changes between PCRE 6.4 and 6.5.

LayoutTests:

Reviewed by Mitz.

  • fast/js/regexp-overflow-expected.txt: Added.
  • fast/js/regexp-overflow.html: Added.
  • fast/js/resources/regexp-overflow.js: Added.
4:28 PM Changeset in webkit [28057] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix potential null-dereference.

Reviewed by Adam Roben.

  • page/FrameTree.cpp: (WebCore::FrameTree::isDescendantOf):
4:15 PM Changeset in webkit [28056] by weinig@apple.com
  • 7 edits
    9 adds in trunk

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5592988>

  • Enforce tighter restrictions on what frames in other domains can be navigated.

Tests: http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html

http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html

  • bindings/js/kjs_window.cpp: (KJS::Window::put): (KJS::Location::put): (KJS::LocationProtoFuncReplace::callAsFunction): (KJS::LocationProtoFuncAssign::callAsFunction):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::load): (WebCore::FrameLoader::shouldAllowNavigation): Move and update logic from canTarget().
  • loader/FrameLoader.h:
  • page/FrameTree.cpp: (WebCore::FrameTree::isDescendantOf): Make this O(1) in the case when both frames are not in the same page.

LayoutTests:

Reviewed by Darin.

Tests for <rdar://problem/5592988>

  • Update and add tests for new tighter restrictions on what frames in other domains can be navigated.
  • http/tests/security/cross-frame-access-location-expected.txt:
  • http/tests/security/frameNavigation: Added.
  • http/tests/security/frameNavigation/resources: Added.
  • http/tests/security/frameNavigation/resources/iframe-that-performs-parent-navigation.html: Added.
  • http/tests/security/frameNavigation/resources/iframe-with-inner-frame-on-foreign-domain.html: Added.
  • http/tests/security/frameNavigation/resources/navigation-changed-iframe.html: Added.
  • http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change-expected.txt: Added.
  • http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html: Added.
  • http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change-expected.txt: Added.
  • http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html: Added.
3:53 PM Changeset in webkit [28055] by sfalken@apple.com
  • 4 edits in trunk

WebCore:

Build fix.

  • WebCore.vcproj/migrate-idls.sh:

WebKit/win:

Build fix.

  • WebKit.vcproj/build-generated-files.sh:
3:50 PM Changeset in webkit [28054] by ggaren@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fixed typo

3:48 PM Changeset in webkit [28053] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by Kevin McCullough.


Fixed <rdar://problem/5597937> REGRESSION (r27126): Drosera does not
show variables (can't enumerate ActivationImp properties)


Implemented a custome ActivationImp::getPropertyNames, since
ActivationImp now uses a custom property storage mechanism for local
variables.

  • kjs/function.cpp: (KJS::ActivationImp::getPropertyNames):
  • kjs/function.h:
3:45 PM Changeset in webkit [28052] by andersca@apple.com
  • 8 edits
    2 adds in trunk/WebKit/win

Reviewed by Adam.

Add an implementation of IWebSecurityOrigin and a partially stubbed out
implementation of IWebDatabaseManager.


  • ForEachCoClass.h:
  • Interfaces/IWebDatabaseManager.idl:
  • Interfaces/WebKit.idl:
  • WebDatabaseManager.cpp: (WebDatabaseManager::createInstance): (WebDatabaseManager::WebDatabaseManager): (WebDatabaseManager::~WebDatabaseManager): (WebDatabaseManager::QueryInterface): (WebDatabaseManager::AddRef): (WebDatabaseManager::Release): (WebDatabaseManager::sharedWebDatabaseManager): (WebDatabaseManager::origins): (WebDatabaseManager::databasesWithOrigin): (WebDatabaseManager::detailsForDatabaseWithOrigin): (WebDatabaseManager::deleteAllDatabases): (WebDatabaseManager::deleteDatabasesWithOrigin): (WebDatabaseManager::deleteDatabaseWithOrigin):
  • WebDatabaseManager.h:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKitClassFactory.cpp:
  • WebSecurityOrigin.cpp: Added. (WebSecurityOrigin::createInstance): (WebSecurityOrigin::WebSecurityOrigin): (WebSecurityOrigin::~WebSecurityOrigin): (WebSecurityOrigin::QueryInterface): (WebSecurityOrigin::AddRef): (WebSecurityOrigin::Release): (WebSecurityOrigin::protocol): (WebSecurityOrigin::domain): (WebSecurityOrigin::port): (WebSecurityOrigin::usage): (WebSecurityOrigin::quota): (WebSecurityOrigin::setQuota):
  • WebSecurityOrigin.h: Added.
3:34 PM Changeset in webkit [28051] by mitz@apple.com
  • 2 edits in trunk/WebKitTools
  • Tiger build fix.
  • DumpRenderTree/mac/Configurations/Base.xcconfig:
3:03 PM Changeset in webkit [28050] by kmccullough@apple.com
  • 11 edits in trunk

WebKit/win:

Reviewed by Maciej.

  • Implemented displaying variables for Drosera on Win.
  • Interfaces/IWebScriptCallFrame.idl: Added a local function to be able to access the WebScriptCallFrame.
  • Interfaces/IWebScriptScope.idl: Implemented.
  • Interfaces/WebKit.idl: Added WebScriptScope to the tlb.
  • WebKit.vcproj/Interfaces.vcproj:
  • WebScriptCallFrame.cpp: Implemented the helper and accessor methods. (EnumScopes::Next): Fixed a bug where we did not release correctly and would accidentally destroy scopes. (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString): Implemented. (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString): Implemented
  • WebScriptCallFrame.h: Implemented the helper and accessor methods. (WebScriptCallFrame::impl): (WebScriptCallFrame::state):
  • WebScriptScope.cpp: Implmented. (EnumVariables::EnumVariables): Created an IEnumVariant over the variables to be able to pass a DCOM acceptable structure back to Drosera. (EnumVariables::createInstance): (EnumVariables::QueryInterface): (EnumVariables::AddRef): (EnumVariables::Release): (EnumVariables::Next): (EnumVariables::Skip): (EnumVariables::Reset): (EnumVariables::Clone): (WebScriptScope::WebScriptScope): (WebScriptScope::createInstance): Implemented. (WebScriptScope::variableNames): Implemented. (WebScriptScope::valueForVariable):
  • WebScriptScope.h: Implmeneted.

WebKitTools:

Reviewed by Maciej.

  • Implemented displaying variables for Drosera on Win.
  • Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions that retrieve variables to not hold onto the return value since it's not returned. Also changed to use the new signatures of the retrieval functions. (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed):
  • Drosera/win/Drosera.cpp: Removed a needless TODO. (droseraWndProc):
2:15 PM Changeset in webkit [28049] by andersca@apple.com
  • 3 edits
    2 adds in trunk/WebKit/win

Reviewed by Brady.

Add IWebDatabaseManager and IWebSecurityOrigin interfaces.


  • Interfaces/IWebDatabaseManager.idl: Added.
  • Interfaces/IWebSecurityOrigin.idl: Added.
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
1:19 PM Changeset in webkit [28048] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/5609337> Making a float shorter does not remove it from the floating object list of a nested block it intruded into

Test: fast/dynamic/float-withdrawal-2.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): When a float may have been withdrawn from a child, mark all descendants if necessary and not just the child.

LayoutTests:

Reviewed by Dave Hyatt.

  • test for <rdar://problem/5609337> Making a float shorter does not remove it from the floating object list of a nested block it intruded into
  • fast/dynamic/float-withdrawal-2.html: Added.
  • platform/mac/fast/dynamic/float-withdrawal-2-expected.checksum: Added.
  • platform/mac/fast/dynamic/float-withdrawal-2-expected.png: Added.
  • platform/mac/fast/dynamic/float-withdrawal-2-expected.txt: Added.
1:16 PM Changeset in webkit [28047] by weinig@apple.com
  • 4 edits in trunk/WebKitTools

Cleanup names of painting and repainting functions.

Reviewed by Adam Roben.

  • DumpRenderTree/cg/PixelDumpSupportCG.cpp: (drawSelectionRect): was drawSelectionRectIntoContext. (dumpWebViewAsPixelsAndCompareWithExpected):
  • DumpRenderTree/cg/PixelDumpSupportCG.h:
  • DumpRenderTree/mac/PixelDumpSupportMac.mm: (paintWebView): was drawWebViewIntoContext. (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
11:51 AM Changeset in webkit [28046] by alice.liu@apple.com
  • 2 edits in trunk/WebKit/win

Reviewed by Jon Honeycutt.

Fall back to the default Policy Delegate in these functions,
as is already done in dispatchDecidePolicyForNavigationAction

  • WebFrame.cpp: (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchUnableToImplementPolicy):
11:47 AM Changeset in webkit [28045] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Dan Bernstein.

  • Leopard build fix
  • DumpRenderTree/mac/Configurations/Base.xcconfig:
11:35 AM Changeset in webkit [28044] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Brady.

Get rid of the WebSecurityOriginPrivate object and store
the WebCore::SecurityOriginData pointer in the _private field of
the WebSecurityOrigin object instead.


  • Storage/WebDatabaseManager.mm: (-[WebDatabaseManager databasesWithOrigin:]): (-[WebDatabaseManager detailsForDatabase:withOrigin:]): (-[WebDatabaseManager deleteDatabasesWithOrigin:]): (-[WebDatabaseManager deleteDatabase:withOrigin:]):
  • Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin initWithProtocol:domain:port:]): (-[WebSecurityOrigin protocol]): (-[WebSecurityOrigin domain]): (-[WebSecurityOrigin port]): (-[WebSecurityOrigin usage]): (-[WebSecurityOrigin quota]): (-[WebSecurityOrigin setQuota:]): (-[WebSecurityOrigin dealloc]): (-[WebSecurityOrigin finalize]): (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]): (-[WebSecurityOrigin _core]):
  • Storage/WebSecurityOriginInternal.h:
11:34 AM Changeset in webkit [28043] by sfalken@apple.com
  • 2 edits
    1 move in trunk/WebCore

Build fix.

  • WebCore.vcproj/MigrateIDLAndScripts: Copied from WebCore.vcproj/MigrateIDLAndScripts.make.
  • WebCore.vcproj/MigrateIDLAndScripts.make: Removed.
  • WebCore.vcproj/migrate-idls.sh:
11:19 AM Changeset in webkit [28042] by weinig@apple.com
  • 7 edits
    2 moves
    2 deletes in trunk/WebKitTools

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16136
Use shared PixelDumpSupport for Mac DRT

Reviewed by Adam Roben.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
  • DumpRenderTree/cg/ImageDiffCG.cpp:
  • DumpRenderTree/cg/PixelDumpSupportCG.cpp: (drawSelectionRectIntoContext): (dumpWebViewAsPixelsAndCompareWithExpected):
  • DumpRenderTree/cg/PixelDumpSupportCG.h:
  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/DumpRenderTree.mm: (dump):
  • DumpRenderTree/mac/ImageDiff.m: Removed.
  • DumpRenderTree/mac/PixelDumpSupport.h: Removed.
  • DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
  • DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm. (setDefaultColorProfileToRGB): (getBitmapContextFromWebView): (drawWebViewIntoContext): (repaintWithVerticalSweep): (repaintWithHorizontalSweep): (getSelectionRect):
  • DumpRenderTree/win/PixelDumpSupport.h: Removed.
11:17 AM Changeset in webkit [28041] by beidson@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Anders (and typo lovingly found by Adam)

Change Databases to be stored in a per-origin directory hierarchy - this will make
storage quotas much easier to enforce

  • platform/SecurityOriginData.cpp: (WebCore::SecurityOriginData::SecurityOriginData): Parse string based on '_' instead of ':' (WebCore::SecurityOriginData::stringIdentifier): Change to use '_' as a separator instead of ':'. '_' still works due to not being allowed in domain names, but also is a valid filename character ' on all filesystems we care about
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): Create a per-origin directory hierarchy to categorize databases by origin
10:40 AM Changeset in webkit [28040] by alp@webkit.org
  • 1 edit
    1 add in trunk/JavaScriptCore

2007-11-26 Alp Toker <​alp@atoker.com>

GTK+/Qt/Wx build fix for breakage introduced in r28039.

  • ForwardingHeaders/JavaScriptCore/JSRetainPtr.h: Added.
9:17 AM Changeset in webkit [28039] by timothy@apple.com
  • 12 edits in trunk

WebCore:

Reviewed by Adam Roben.

Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title
​http://bugs.webkit.org/show_bug.cgi?id=16137

On Leopard the toolbar background will be transparent, to allow the
window background to show through the transparent WebView. The
search results divs needed to move inside the "main" div, so they
would be clipped and not show where the toolbar is.

  • page/InspectorController.cpp: (WebCore::platform): Return a string for which platform we are. (WebCore::InspectorController::windowScriptObjectAvailable): Define the platform function on the JavaScript class.
  • page/inspector/Panel.js: Add panels to the panels div.
  • page/inspector/inspector.css: On the Leopard platform make the toolbar background transparent so the window background shows.
  • page/inspector/inspector.html: Add a panels div and move search result divs inside the main div.
  • page/inspector/inspector.js: Tweak the resize code to acount for the search results divs moving inside the main div.

WebKit/mac:

Reviewed by Adam Roben.

Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title
​http://bugs.webkit.org/show_bug.cgi?id=16137

Create the Web Inspector window with the textured style. Set the content border
thickness for the top of the window or the height of the toolbar. Also make the
window's bottom corners square, since a normal textured window normally has
rounded bottom corners.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController window]):

WebKitLibraries:

Reviewed by Adam Roben.

Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title
​http://bugs.webkit.org/show_bug.cgi?id=16137

Add a new function to make bottom window corners square for textured windows.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceTiger.a:
  • libWebKitSystemInterfaceLeopard.a:

Nov 25, 2007:

11:29 PM Changeset in webkit [28038] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix a leak pointed out by Alexey

  • WebView.cpp: (getUpdateRects): Use a Vector<unsigned char>, since OwnPtr doesn't know to call delete[].
11:06 PM Changeset in webkit [28037] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Bug 16052: prepare-ChangeLog doesn't report deleted files
<​http://bugs.webkit.org/show_bug.cgi?id=16052>

Reviewed by Sam.

  • Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
11:02 PM Changeset in webkit [28036] by Adam Roben
  • 3 edits in trunk/WebKit/win

Fix Bug 16138: Reduce code duplication in WebView.cpp

​http://bugs.webkit.org/show_bug.cgi?id=16138

Reviewed by Sam.

  • WebView.cpp: (getUpdateRects): Factored code out of updateBackingStore and paint into this new helper function. (WebView::updateBackingStore): Use getUpdateRects. (WebView::paint): Ditto. (WebView::paintIntoBackingStore): Changed to take a const IntRect&. (WebView::paintIntoWindow): Ditto.
  • WebView.h:
10:00 PM Changeset in webkit [28035] by ddkilzer@apple.com
  • 2 edits
    1 delete in trunk/WebKitTools

Bug 15864: Replace merge-changelog with resolve-ChangeLogs
<​http://bugs.webkit.org/show_bug.cgi?id=15864>

Reviewed by Adam.

Roll functionality of merge-changelog into resolve-ChangeLogs
script. The script now checks for ChangeLog.rej and
ChangeLog.orig files first. If it finds them, it uses the
ChangeLog.rej file as a patch (in old contextual diff format) to
apply with --fuzz=3.

  • Scripts/merge-changelog: Removed.
  • Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
9:26 PM Changeset in webkit [28034] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Add a known failure.
9:25 PM Changeset in webkit [28033] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Remove an unnecessary entry.
8:16 PM Changeset in webkit [28032] by weinig@apple.com
  • 4 edits
    2 adds in trunk/WebKitTools

Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.

Reviewed by Mark Rowe.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
  • DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
  • DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
7:52 PM Changeset in webkit [28031] by weinig@apple.com
  • 2 edits
    4 adds in trunk/WebKitTools

Convert DumpRenderTree to ues .xcconfig files.

Reviewed by Mark Rowe.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/Configurations: Added.
  • DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
6:54 PM Changeset in webkit [28030] by weinig@apple.com
  • 12 edits
    8 adds in trunk/WebKitTools

Add ForwardingHeaders to wtf for DumpRenderTree.

Reviewed by Mark Rowe.

  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/ForwardingHeaders: Added.
  • DumpRenderTree/ForwardingHeaders/wtf: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
  • DumpRenderTree/LayoutTestController.cpp:
  • DumpRenderTree/WorkQueue.cpp:
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/FrameLoadDelegate.mm:
  • DumpRenderTree/mac/JavaScriptThreading.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/mac/ObjCController.m:
  • DumpRenderTree/mac/UIDelegate.mm:
  • DumpRenderTree/mac/WorkQueueItemMac.mm:
6:37 PM Changeset in webkit [28029] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-25 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Maciej Stachowiak.

Remove the unneeded CFNETWORK #ifdefs.

  • loader/NetscapePlugInStreamLoader.h:
6:12 PM Changeset in webkit [28028] by mrowe@apple.com
  • 5 edits in trunk/WebCore

2007-11-24 Laszlo Gombos <​laszlo.gombos@gmail.com>

Reviewed by Sam Weinig.

Add printf format attribute to several functions. Use the the new WTF_ATTRIBUTE_PRINTF define.

  • dom/XMLTokenizer.cpp:
  • dom/XMLTokenizer.h:
  • platform/DeprecatedString.h:
  • platform/PlatformString.h:
6:12 PM Changeset in webkit [28027] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2007-11-24 Laszlo Gombos <​laszlo.gombos@gmail.com>

Reviewed by Maciej Stachowiak.

Fix minor compiler warning (GCC 4.1.3)

  • pcre/pcre_internal.h:
  • pcre/pcre_ucp_searchfuncs.cpp: (_pcre_ucp_othercase):
5:53 PM Changeset in webkit [28026] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix some test failures caused by r28019

Now that stdout is in binary mode, we need to always use printf
instead of wprintf. Otherwise we'll end up with UTF-16 characters in
the output.

Reviewed by Sam.

  • DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with printf. (UIDelegate::runJavaScriptAlertPanelWithMessage): (UIDelegate::runJavaScriptConfirmPanelWithMessage): (UIDelegate::runJavaScriptTextInputPanelWithPrompt): (UIDelegate::webViewAddMessageToConsole):
5:06 PM Changeset in webkit [28025] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

  • fix off-center error images

Covered by many pixel tests with missing images

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint): Account for the 1 pixel outline when positioning the error image.
4:13 PM Changeset in webkit [28024] by Adam Roben
  • 2 edits in trunk/WebKitTools

Set the font smoothing preference in DRT

This makes the pixel results on Windows closer to the Mac results.

Reviewed by Mitz.

  • DumpRenderTree/win/DumpRenderTree.cpp: (initializePreferences):
4:03 PM Changeset in webkit [28023] by Adam Roben
  • 4 edits
    2 adds in trunk

Fix Bug 16133: Implement pixel test support on Windows

WebKit/win:

Add ImageDiff.vcproj to WebKit.sln

Reviewed by Sam.

  • WebKit.vcproj/WebKit.sln:

WebKitTools:

Port ImageDiff to CG and C++

Final part of ​http://bugs.webkit.org/show_bug.cgi?id=16133
<rdar://5071708>

Reviewed by Sam.

  • DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
  • DumpRenderTree/cg/ImageDiffCG.cpp: Added. (main): (createImageFromStdin): (compareImages): (getDifferenceBitmap): (computePercentageDifferent):
  • DumpRenderTree/win/ImageDiff.vcproj: Added.
4:03 PM Changeset in webkit [28022] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix image diff link generation on Windows

Reviewed by Sam.

  • Scripts/run-webkit-tests: Removed unnecessary and incorrect calls to toURL.
4:02 PM Changeset in webkit [28021] by Adam Roben
  • 3 edits
    7 adds in trunk/WebKitTools

Implement pixel dumping in Windows DRT

Part of ​http://bugs.webkit.org/show_bug.cgi?id=16133
<rdar://5071708>

Reviewed by Sam.

  • DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added. (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a Content-Length header. (getMD5HashStringForBitmap): (dumpWebViewAsPixelsAndCompareWithExpected):
  • DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
  • DumpRenderTree/win/DumpRenderTree.cpp: (dump): Do a pixel dump if requested. (main): Parse pixel test options.
  • DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added the cg/ subdirectory to the include path.
  • DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't available in a header or import library, so we have to go through this LoadLibrary/GetProcAddress dance to use them. (cryptDLL): (init): (update): (final): (MD5_Init): (MD5_Update): (MD5_Final):
  • DumpRenderTree/win/MD5.h: Added.
  • DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be moved up to the top level to share it with Mac eventually.
  • DumpRenderTree/win/PixelDumpSupportWin.cpp: Added. (getBitmapContextFromWebView): Forces the WebView to paint using a WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
4:02 PM Changeset in webkit [28020] by Adam Roben
  • 2 edits in trunk/WebKitTools

Clean up Windows DRT's option parsing a little bit

Reviewed by Sam.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main): Put non-option arguments into a Vector.
4:01 PM Changeset in webkit [28019] by Adam Roben
  • 3 edits in trunk/WebKitTools

Make Windows DRT stop changing LF into CRLF

Reviewed by Sam.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main): Put stdout in binary mode.
  • Scripts/run-webkit-tests: Remove the CRLF hack.
2:14 PM Changeset in webkit [28018] by mrowe@apple.com
  • 3 edits
    3 adds in trunk

Fix bug 16129: REGRESSION (r27761-r27811): malloc error while visiting ​http://mysit.es (crashes release build)

  • pcre/pcre_compile.cpp: Change errorcode to be passed by reference so that any error code is propagated

to our caller like they expect.

Reviewed by Dan Bernstein.

1:16 PM Changeset in webkit [28017] by kevino@webkit.org
  • 4 edits in trunk

wx build fixes for Linux/GTK+ port.

5:06 AM Changeset in webkit [28016] by Nikolas Zimmermann
  • 1 edit in trunk/WebCore/ChangeLog

Fix wrong bug number in ChangeLog. Not reviewed.

5:04 AM Changeset in webkit [28015] by Nikolas Zimmermann
  • 14 edits
    4 adds in trunk

Reviewed by Adam Roben.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=15393

Fix problems with hidden glyphs. They were taken into account for quite
some operations (hit testing, length calulcations etc..) except painting.
Especially fixes boundaries of <textPath> (see using Web Inspector) if
text-anchor isn't equal to 'start'.

Added testcase:
svg/text/textPathBoundsBug.svg

Fixed testcase: (all showed text selection problems on text paths)
svg/batik/text/textGlyphOrientationHorizontal.svg
svg/batik/text/textOnPath.svg
svg/batik/text/textOnPath3.svg
svg/batik/text/verticalTextOnPath.svg
svg/text/text-align-04-b.svg
svg/W3C-SVG-1.1/text-align-04-b.svg

1:45 AM Changeset in webkit [28014] by ap@webkit.org
  • 9 edits
    2 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=15919
XSLTProcessor.transformToFragment creates an extra not defined TEXT_NODE at the end

Test: fast/xsl/extra-lf-at-end.html

  • xml/XSLTProcessor.cpp: (WebCore::writeToVector): Changed to use Vector to avoid slow String::apend(). (WebCore::saveResultToString): Remove trailing line feed if present.
12:48 AM Changeset in webkit [28013] by alp@webkit.org
  • 7 edits in trunk/WebKit/gtk

2007-11-24 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=15691
[GTK] Public API does not follow GTK+ conventions

Public API enhancements:

Implement webkit_page_get_editable() and webkit_page_set_editable().

Implement webkit_frame_get_name().

Remove definitions for functions that are unusable or not implemented.
This has caused much confusion for application developers.

Improve documentation.

Correct/constify some return types.

Add parameter checks.

Make the default fixed font "Courier New" to match the other Web
font names.

  • Api/webkitgtkframe.cpp:
  • Api/webkitgtkframe.h:
  • Api/webkitgtkpage.cpp:
  • Api/webkitgtkpage.h:
  • Api/webkitgtkprivate.h:
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::isEditable):
Note: See TracTimeline for information about the timeline view.