⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 27, 2007:

10:31 PM Changeset in webkit [28102] by Beth Dakin
  • 3 edits
    5 adds in trunk

WebCore:

Reviewed by Oliver.

Fix for <rdar://problem/5616052> SVGs with width or height of 100%
hang when used as a background-image (16164)

  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::size): Use valueAsPercentage() for percents instead of valueInSpecifiedUnits(). valueInSpecifiedUnits() returns, for example, 50 for 50%, so multiplying percentages by the default size of 300 x 150 led to ridiculously huge dimensions for SVG images, and the subsequent hang.

LayoutTests:

Reviewed by Oliver.

Test for <rdar://problem/5616052> SVGs with width or height of 100%
hang when used as a background-image (16164)

  • fast/images/resources/width-100-percent.svg: Added.
  • fast/images/svg-width-100p-as-background.html: Added.
  • platform/mac/fast/images/svg-width-100p-as-background-expected.checksum: Added.
  • platform/mac/fast/images/svg-width-100p-as-background-expected.png: Added.
  • platform/mac/fast/images/svg-width-100p-as-background-expected.txt: Added.
9:54 PM Changeset in webkit [28101] by mjs@apple.com
  • 2 edits in trunk/WebKitTools

Not reviewed.

Fix DumpRenderTree ObjC bug comparing strings.

  • DumpRenderTree/mac/ObjCController.m: (-[ObjCController identityIsEqual::]): Compare strings with string equality instead of identiy equality.
9:48 PM Changeset in webkit [28100] by alp@webkit.org
  • 2 edits in trunk/JavaScriptCore

2007-11-27 Alp Toker <​alp@atoker.com>

Prospective MSVC build fix.

Roll back dllexport/dllimport support for now.

  • API/JSBase.h:
8:50 PM Changeset in webkit [28099] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

2007-11-27 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Adam.

Return bool from registerWebViewWindowClass, as nothing uses the ATOM.
Set haveRegisteredWindowClass to true

  • WebView.cpp: (registerWebViewWindowClass):
8:47 PM Changeset in webkit [28098] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2007-11-27 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Adam.

Set haveRegisteredWindowClass when we register the window class.

  • plugins/win/PluginViewWin.cpp: (WebCore::registerPluginView):
8:31 PM Changeset in webkit [28097] by alp@webkit.org
  • 8 edits in trunk/JavaScriptCore

2007-11-27 Alp Toker <​alp@atoker.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=15569
[gtk] GTK JavaScriptCore needs to export symbols for JSC API and WTF

Introduce JS_EXPORT to mark symbols to be exported as public API.

Export all public symbols in the JavaScriptCore C API.

This matches conventions for exporting symbols set by the CF and CG
frameworks.

  • API/JSBase.h:
  • API/JSContextRef.h:
  • API/JSObjectRef.h:
  • API/JSStringRef.h:
  • API/JSStringRefBSTR.h:
  • API/JSStringRefCF.h:
  • API/JSValueRef.h:
6:47 PM Changeset in webkit [28096] by andersca@apple.com
  • 2 edits in trunk/WebKit/win

Speculative fix to get Drosera working.


  • COMEnumVariant.h: (::Next): Update the number of elements fetched correctly.
5:34 PM Changeset in webkit [28095] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

Reviewed by Brady.

  • Storage/WebDatabaseManager.mm:
  • Storage/WebDatabaseManagerPrivate.h:
  • Storage/WebDatabaseTrackerClient.mm: (WebDatabaseTrackerClient::dispatchDidModifyOrigin): (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
  • Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
  • Storage/WebSecurityOriginInternal.h:
5:22 PM Changeset in webkit [28094] by timothy@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Sam.

Reset the authorAndUserStylesEnabled preference
back to YES for each test. Fixes the broken tests.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
5:12 PM Changeset in webkit [28093] by timothy@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Sam Weinig.

Bug 16165: Dragging the inspector toolbar should move the window
​http://bugs.webkit.org/show_bug.cgi?id=16165

  • page/inspector/DocumentPanel.js: Call the new drag functions, and cleanup code.
  • page/inspector/inspector.css: Only make the toolbar transparent in detached mode.
  • page/inspector/inspector.js: Call the new drag functions, and cleanup code. Add toolbar drag functions that move the window.
5:12 PM Changeset in webkit [28092] by andersca@apple.com
  • 13 edits in trunk/WebKit/win

Reviewed by Adam.

Some COM cleanup.


  • CFDictionaryPropertyBag.cpp: (CFDictionaryPropertyBag::QueryInterface):
  • CFDictionaryPropertyBag.h:
  • WebBackForwardList.cpp: (WebBackForwardList::addItem): (WebBackForwardList::removeItem):
  • WebDownload.cpp: (WebDownload::initWithRequest):
  • WebFrame.cpp: (WebFrame::loadRequest): (WebFrame::initWithWebFrameView): (WebFrame::webHistory): (WebFrame::dispatchWillSendRequest):
  • WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::QueryInterface): (WebURLAuthenticationChallenge::initWithProtectionSpace):
  • WebURLAuthenticationChallenge.h:
  • WebURLAuthenticationChallengeSender.cpp: (WebURLAuthenticationChallengeSender::QueryInterface):
  • WebURLAuthenticationChallengeSender.h:
  • WebURLResponse.cpp: (WebURLResponse::QueryInterface):
  • WebURLResponse.h:
  • WebView.cpp: (WebView::notifyDidAddIcon): (WebView::goToBackForwardItem): (WebView::canHandleRequest): (WebView::loadBackForwardListFromOtherView): (core):
4:35 PM Changeset in webkit [28091] by kmccullough@apple.com
  • 4 edits in trunk/WebKitTools

Reviewed by Adam.

  • Drosera now displays the console window, although it cannot currently process JavaScript.
  • Drosera/win/DebuggerClient.cpp: Shows the console window. (registerConsoleClass): Implemented. (consoleWndProc): Implemented. (DebuggerClient::onSize): Implemented. (DebuggerClient::createWebViewWithRequest): Implemented, now creates a new window.
  • Drosera/win/DebuggerClient.h: Added needed method and members for creating and maintaining a new window.
  • Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of lines of code to more appropriate places. (Drosera::handleCommand): (Drosera::initUI): (Drosera::onSize): (Drosera::attach):
4:12 PM Changeset in webkit [28090] by andersca@apple.com
  • 2 edits in trunk/WebKit/win

Add COMEnumVariant.h to the project.


  • WebKit.vcproj/WebKit.vcproj:
4:11 PM Changeset in webkit [28089] by andersca@apple.com
  • 2 edits in trunk/WebKit/win

Reviewed by Adam.

Return E_INVALIDARG if the databaseName BSTR is null;


  • WebDatabaseManager.cpp: (WebDatabaseManager::detailsForDatabaseWithOrigin): (WebDatabaseManager::deleteDatabaseWithOrigin):
3:57 PM Changeset in webkit [28088] by andersca@apple.com
  • 5 edits in trunk/WebKit/win

Reviewed by Adam.

Implement the rest of the WebDatabaseManager API.

  • COMEnumVariant.h:
  • Interfaces/IWebDatabaseManager.idl:
  • WebDatabaseManager.cpp: (isEqual): (DatabaseDetailsPropertyBag::DatabaseDetailsPropertyBag): (DatabaseDetailsPropertyBag::~DatabaseDetailsPropertyBag): (DatabaseDetailsPropertyBag::createInstance): (DatabaseDetailsPropertyBag::AddRef): (DatabaseDetailsPropertyBag::Release): (DatabaseDetailsPropertyBag::QueryInterface): (DatabaseDetailsPropertyBag::Read): (DatabaseDetailsPropertyBag::Write): (WebDatabaseManager::detailsForDatabaseWithOrigin): (WebDatabaseManager::deleteAllDatabases): (WebDatabaseManager::deleteDatabasesWithOrigin): (WebDatabaseManager::deleteDatabaseWithOrigin):
  • WebDatabaseManager.h:
3:34 PM Changeset in webkit [28087] by timothy@apple.com
  • 2 edits in trunk/LayoutTests

Land results for my last test change,

3:32 PM Changeset in webkit [28086] by adachan@apple.com
  • 3 edits in trunk/WebKit/win

<rdar://problem/5616098> The BSTR returned by WebHistoryItem::alternateTitle
was not allocated correctly.

Reviewed by Anders.

  • WebHistoryItem.cpp: (WebHistoryItem::setAlternateTitle): (WebHistoryItem::alternateTitle):
  • WebHistoryItem.h:
3:30 PM Changeset in webkit [28085] by Antti Koivisto
  • 4 edits in trunk/WebCore

Reviewed by Mitz.

Small changes to make RenderSlider a bit more generic so it can be used in video controls.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Fix coordinates with forwarded events.
  • rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): Fix coordinates with forwarded events. (WebCore::RenderSlider::setStyle): (WebCore::RenderSlider::createThumbStyle): Copy thumb left and top from the orginal style so position does not reset. (WebCore::RenderSlider::mouseEventIsInThumb): Make this work with forwarded events.
  • rendering/RenderSlider.h:
3:27 PM Changeset in webkit [28084] by Antti Koivisto
  • 7 edits in trunk/WebCore

Reviewed by Darin.

  • Don't use hasPseudoId() optimization for pseudo styles used in shadow trees. These styles generally exist when asked for so the optimization does not do much. This reverses the continuing growth of the _pseudoBits bitfield in RenderStyle.
  • Add some pseudo elements for media controls
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::checkOneSelector):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle):
  • rendering/RenderStyle.cpp: (WebCore::pseudoBit): (WebCore::RenderStyle::hasPseudoStyle): (WebCore::RenderStyle::setHasPseudoStyle):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::):
3:05 PM Changeset in webkit [28083] by timothy@apple.com
  • 4 edits in trunk

WebCore:

Reviewed by Kevin McCullough.

Bug 16161: window.moveBy(0, 0) moves the window by -22px vertically
​http://bugs.webkit.org/show_bug.cgi?id=16161

Removed the "Adjust the window rect to be in the coordinate space of
the screen rect" step which was always adding (0,22) to the window
position (on the main screen). Instead, account for screen X and Y
in the bottom and right constrain step.

Added more test cases to: fast/dom/Window/window-resize.html

  • bindings/js/kjs_window.cpp: (KJS::adjustWindowRect):

LayoutTests:

Reviewed by Kevin McCullough.

Bug 16161: window.moveBy(0, 0) moves the window by -22px vertically
​http://bugs.webkit.org/show_bug.cgi?id=16161

Added test cases for moveBy(0, 0), moveBy(0, 1) and moveBy(1, 0).

  • fast/dom/Window/window-resize.html:
3:00 PM Changeset in webkit [28082] by andersca@apple.com
  • 3 edits in trunk/JavaScriptGlue

Build fix.


  • JSUtils.cpp: (KJSValueToCFTypeInternal):
  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames):
2:30 PM Changeset in webkit [28081] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Darin, landed by Anders.

Fixed: <rdar://problem/4610818> CrashTracer: 1533 crashes in Safari at com.macromedia.Flash Player.plugin: native_ShockwaveFlash_TCallLabel + 271131

The problem was that some Leopard users were still inadvertently using the old Flash 8 plug-in, even though Leopard
shipped with Flash 9. To avoid loading an older version of a plug-in when a newer version is installed, the plug-in
database will compare bundle versions and always load the latest version.

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage versionNumber]): New method. CFBundleGetVersionNumber doesn't work with all possible versioning schemes, but we think for now it's good enough for us.
  • Plugins/WebPluginDatabase.m: (considerCandidate): Added a C utility function which compares the current plug-in against a candidate plug-in's version number. If both plug-ins have the same bundle ID and the candiate is newer, the current plug-in becomes the candidate. (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): Calls the new considerCandidate() function.
2:27 PM Changeset in webkit [28080] by andersca@apple.com
  • 3 edits in trunk/WebKit/win

Reviewed by Adam.

Use COMEnumVariant in WebScriptCallFrame and WebScriptScope.


  • WebScriptCallFrame.cpp: (WebScriptCallFrame::scopeChain):
  • WebScriptScope.cpp: (WebScriptScope::variableNames):
2:21 PM Changeset in webkit [28079] by andersca@apple.com
  • 6 edits in trunk/JavaScriptCore

Reviewed by Adam.

Make PropertyNameArray and ScopeChain COMEnumVariant friendly.


  • kjs/PropertyNameArray.cpp: (KJS::PropertyNameArray::swap): Implement PropertyNameArray::swap.


  • kjs/PropertyNameArray.h: Add ValueType typedef. Replace PropertyNameArrayIterator with PropertyNameArray::const_iterator.


  • kjs/nodes.cpp: (KJS::ForInNode::execute):
  • kjs/scope_chain.cpp: (KJS::ScopeChain::print): Update for changes to PropertyNameArray.


  • kjs/scope_chain.h: Add const_iterator and ValueType typedef.
1:48 PM Changeset in webkit [28078] by andersca@apple.com
  • 2 edits in trunk/WebKit/win

Reviewed by Adam.

Use the correct include paths.


  • COMEnumVariant.h:
1:43 PM Changeset in webkit [28077] by andersca@apple.com
  • 4 edits
    1 add in trunk/WebKit/win

Reviewed by Darin.


Add COMEnumVariant, a templatized class with implements IEnumVARIANT and lets
you enumerate over a C++ container, be it WTF or STL.


  • COMEnumVariant.h: Added.


  • WebDatabaseManager.cpp: (WebDatabaseManager::origins): (WebDatabaseManager::databasesWithOrigin): Implement these using COMEnumVariant.


  • WebSecurityOrigin.cpp: (WebSecurityOrigin::QueryInterface):
  • WebSecurityOrigin.h: Add a UUID for the implementation so that other parts of WebKit can access the WebCore::SecurityOriginData object.
1:27 PM Changeset in webkit [28076] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Add a ValueType typedef.


  • wtf/Vector.h:
1:23 PM Changeset in webkit [28075] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

  • page/inspector/inspector.css: Make the text in the Network panel legend more readable.
12:51 PM Changeset in webkit [28074] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Don't call setNeedsReapplyStylesInAllFrames if the
authorAndUserStylesEnabled setting didn't change.

  • page/Settings.cpp: (WebCore::Settings::setAuthorAndUserStylesEnabled):
10:53 AM Changeset in webkit [28073] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-11-27 Alp Toker <​alp@atoker.com>

Fix potential broken build due to a missing DEPENDPATH.

  • WebCore.pro:
10:48 AM Changeset in webkit [28072] by sullivan@apple.com
  • 3 edits in trunk/WebKitLibraries

Fixed 5614525, caused by a recent bug in WKGetExtensionsForMIMEType
that affects Safari.


reviewed by Kevin Decker

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
9:15 AM Changeset in webkit [28071] by timothy@apple.com
  • 22 edits
    2 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

<rdar://problem/5569233> Add the ability to disable author and user CSS styles

  • WebCore.base.exp: Add the Settings::setAuthorAndUserStylesEnabled symbol.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Add a new matchAuthorAndUserStyles parameter. (WebCore::CSSStyleSelector::styleForElement): Check m_matchAuthorAndUserStyles before matching user and author rules. (WebCore::CSSStyleSelector::pseudoStyleForElement): Ditto. (WebCore::CSSStyleSelector::styleRulesForElement): Ditto.
  • css/CSSStyleSelector.h: Add m_matchAuthorAndUserStyles and new constructor parameter.
  • dom/Document.cpp: (WebCore::Document::Document): Pass Settings::authorAndUserStylesEnabled to the CSSStyleSelector. (WebCore::Document::recalcStyleSelector): Skip collecting the author stylesheets if Settings::authorAndUserStylesEnabled is false, and pass that to the CSSStyleSelector.
  • page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_authorAndUserStylesEnabled to true. (WebCore::Settings::setAuthorAndUserStylesEnabled): Recalc style in all the frames when the setting changes.
  • page/Settings.h: Add m_authorAndUserStylesEnabled. (WebCore::Settings::authorAndUserStylesEnabled): Return m_authorAndUserStylesEnabled.

WebKit/mac:

Reviewed by Dave Hyatt.

<rdar://problem/5569233> Add the ability to disable author and user CSS styles

  • WebView/WebPreferenceKeysPrivate.h: Define WebKitRespectStandardStyleKeyEquivalentsPreferenceKey.
  • WebView/WebPreferences.m: (+[WebPreferences initialize]): Default WebKitRespectStandardStyleKeyEquivalentsPreferenceKey to YES. (-[WebPreferences authorAndUserStylesEnabled]): Return the setting's BOOL value. (-[WebPreferences setAuthorAndUserStylesEnabled:]): Set the setting's BOOL value.
  • WebView/WebPreferencesPrivate.h: Add authorAndUserStylesEnabled and setAuthorAndUserStylesEnabled:.
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings::authorAndUserStylesEnabled.

WebKitTools:

Reviewed by Dave Hyatt.

<rdar://problem/5569233> Add the ability to disable author and user CSS styles


Add support for disabling author and user styles for testing.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/LayoutTestController.cpp: (setAuthorAndUserStylesEnabledCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAuthorAndUserStylesEnabled):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAuthorAndUserStylesEnabled):

LayoutTests:

Reviewed by Dave Hyatt.

Test for: <rdar://problem/5569233> Add the ability to disable author and user CSS styles

  • fast/css/disabled-author-styles.html: Added.
  • platform/mac/fast/css/disabled-author-styles-expected.txt: Added.
7:06 AM QtWebKitGitInstructions edited by Simon Hausmann
(diff)
1:48 AM HackingGtk edited by alp@atoker.com
Link to OptimizingGtk (diff)
12:15 AM Changeset in webkit [28070] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-11-27 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Based on changes by Mike Emmel.

CURL HTTP backend local file fixes:

Set a MIME type for local files based on the file extension.

Remove any HTTP query part sent to a local file.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startJob):

Nov 26, 2007:

7:28 PM Changeset in webkit [28069] by beidson@apple.com
  • 13 edits in trunk

WebCore:

Reviewed by Mark Rowe

Allow setting the default storage quota per database origin

  • WebCore.base.exp:
  • page/Settings.cpp: (WebCore::Settings::setDefaultDatabaseOriginQuota): (WebCore::Settings::defaultDatabaseOriginQuota):
  • page/Settings.h:
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker): (WebCore::DatabaseTracker::setDefaultOriginQuota): (WebCore::DatabaseTracker::defaultOriginQuota):
  • storage/DatabaseTracker.h:

WebKit/mac:

Reviewed by Mark Rowe

Provide API for setting the default storage quota per database origin

  • Misc/WebNSDictionaryExtras.h:
  • Misc/WebNSDictionaryExtras.m: (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Helper for UINT64 preferences
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.m: (-[WebPreferences _unsignedLongLongValueForKey:]): Helper for UINT64 prefs (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto (-[WebPreferences defaultDatabaseQuota]): (-[WebPreferences setDefaultDatabaseQuota:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Set the WebCore Settings version of the default storage pref
7:01 PM Changeset in webkit [28068] by alp@webkit.org
  • 6 edits in trunk/WebCore

2007-11-26 Peter Kasting <​zerodpx@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=15974
GIF decoding should respect frames' specified disposal methods.

  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::setDisposalMethod):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameBufferAtIndex): (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::GIFImageDecoder::prepEmptyFrameBuffer): (WebCore::GIFImageDecoder::haveDecodedRow): (WebCore::GIFImageDecoder::frameComplete):
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read):
  • platform/image-decoders/gif/GIFImageReader.h: (GIFFrameReader::GIFFrameReader):
6:20 PM Changeset in webkit [28067] by Adam Roben
  • 5 edits in trunk

Make WebKitGraphics able to handle grayscale colors

WebCore:

Add a Color(CGColorRef) constructor

Reviewed by Darin.

  • platform/graphics/Color.h:
  • platform/graphics/cg/ColorCG.cpp: (WebCore::Color::Color): Added.

WebKit/win:

Take advantage of the new Color constructor that takes a CGColorRef

This lets us handle grayscale colors (which only have 2 components).

Reviewed by Darin.

  • WebKitGraphics.cpp: (DrawTextAtPoint):
6:15 PM Changeset in webkit [28066] by adele@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Update to last change. Moved addPendingSheet call to within nil check for m_cachedSheet.

  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
6:08 PM Changeset in webkit [28065] by alp@webkit.org
  • 7 edits in trunk/WebKit/gtk

2007-11-26 Alp Toker <​alp@atoker.com>

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=16149
Implement the window-object-cleared signal

This implementation provides the JSGlobalContextRef and JSObjectRef
directly rather than using an intermediate JS wrapper object, similar
to the approach taken by the Win port.

  • Api/webkitgtk-marshal.list:
  • Api/webkitgtkframe.h:
  • Api/webkitgtkpage.cpp:
  • Api/webkitgtkpage.h:
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::windowObjectCleared):
6:07 PM Changeset in webkit [28064] by adele@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5591583> CrashTracer: [USER] 157 in Mail crashes at -[WebCoreFrameBridge reapplyStylesForDeviceType:]

  • page/Frame.cpp: Add nil checks since every other caller of requestCSSStyleSheet checks for nil. (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader):
6:05 PM Changeset in webkit [28063] by mrowe@apple.com
  • 2 edits in trunk/WebCore

GCC 4.2 build fix.

  • xml/XSLTUnicodeSort.cpp: Add another WTF_ATTRIBUTE_PRINTF.
5:52 PM Changeset in webkit [28062] by weinig@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

Reviewed and touched up by Sam Weinig.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16073

Test: http/tests/security/xss-DENIED-invalid-domain-change.html

  • dom/Document.cpp: (WebCore::Document::setDomain): Don't set the securityOrigin policy unless the set succeeds. Adds some early returns as well.

LayoutTests:

Reviewed by Sam Weinig.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=16073

  • http/tests/security/resources/iframe-invalid-domain-change.html: Added.
  • http/tests/security/xss-DENIED-invalid-domain-change-expected.txt: Added.
  • http/tests/security/xss-DENIED-invalid-domain-change.html: Added.
5:35 PM Changeset in webkit [28061] by Darin Adler
  • 3 edits in trunk/WebKit/mac

Reviewed by Adele.

  • some middle-mouse-button-related fixes

These don't affect Safari since it maps the middle mouse button to the command key,
but that might not always be the case for future versions.

  • WebView/WebHTMLView.mm: (-[WebHTMLView otherMouseDown:]): Pass through middle mouse down events to WebCore. (-[WebHTMLView otherMouseDragged:]): Ditto, for drag events. (-[WebHTMLView otherMouseUp:]): Ditto, for up events.
  • WebView/WebPolicyDelegate.h: Fixed inaccurate documentation of WebActionButtonKey.
5:25 PM Changeset in webkit [28060] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Build fix.

  • WebKit.vcproj/WebKit.make:
5:08 PM Changeset in webkit [28059] by sfalken@apple.com
  • 5 edits in trunk

WebCore:

Build fix.

  • WebCore.vcproj/WebCore.make:
  • WebCore.vcproj/migrate-idls.sh:

WebKit/win:

Build fix.

  • WebKit.vcproj/build-generated-files.sh:
4:50 PM Changeset in webkit [28058] by Darin Adler
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Mitz.

Test: fast/js/regexp-overflow.html

  • pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags): Removed a stray "ptr++" that I added by accident when merging the changes between PCRE 6.4 and 6.5.

LayoutTests:

Reviewed by Mitz.

  • fast/js/regexp-overflow-expected.txt: Added.
  • fast/js/regexp-overflow.html: Added.
  • fast/js/resources/regexp-overflow.js: Added.
4:28 PM Changeset in webkit [28057] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix potential null-dereference.

Reviewed by Adam Roben.

  • page/FrameTree.cpp: (WebCore::FrameTree::isDescendantOf):
4:15 PM Changeset in webkit [28056] by weinig@apple.com
  • 7 edits
    9 adds in trunk

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5592988>

  • Enforce tighter restrictions on what frames in other domains can be navigated.

Tests: http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html

http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html

  • bindings/js/kjs_window.cpp: (KJS::Window::put): (KJS::Location::put): (KJS::LocationProtoFuncReplace::callAsFunction): (KJS::LocationProtoFuncAssign::callAsFunction):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::load): (WebCore::FrameLoader::shouldAllowNavigation): Move and update logic from canTarget().
  • loader/FrameLoader.h:
  • page/FrameTree.cpp: (WebCore::FrameTree::isDescendantOf): Make this O(1) in the case when both frames are not in the same page.

LayoutTests:

Reviewed by Darin.

Tests for <rdar://problem/5592988>

  • Update and add tests for new tighter restrictions on what frames in other domains can be navigated.
  • http/tests/security/cross-frame-access-location-expected.txt:
  • http/tests/security/frameNavigation: Added.
  • http/tests/security/frameNavigation/resources: Added.
  • http/tests/security/frameNavigation/resources/iframe-that-performs-parent-navigation.html: Added.
  • http/tests/security/frameNavigation/resources/iframe-with-inner-frame-on-foreign-domain.html: Added.
  • http/tests/security/frameNavigation/resources/navigation-changed-iframe.html: Added.
  • http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change-expected.txt: Added.
  • http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html: Added.
  • http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change-expected.txt: Added.
  • http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html: Added.
3:53 PM Changeset in webkit [28055] by sfalken@apple.com
  • 4 edits in trunk

WebCore:

Build fix.

  • WebCore.vcproj/migrate-idls.sh:

WebKit/win:

Build fix.

  • WebKit.vcproj/build-generated-files.sh:
3:50 PM Changeset in webkit [28054] by ggaren@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fixed typo

3:48 PM Changeset in webkit [28053] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by Kevin McCullough.


Fixed <rdar://problem/5597937> REGRESSION (r27126): Drosera does not
show variables (can't enumerate ActivationImp properties)


Implemented a custome ActivationImp::getPropertyNames, since
ActivationImp now uses a custom property storage mechanism for local
variables.

  • kjs/function.cpp: (KJS::ActivationImp::getPropertyNames):
  • kjs/function.h:
3:45 PM Changeset in webkit [28052] by andersca@apple.com
  • 8 edits
    2 adds in trunk/WebKit/win

Reviewed by Adam.

Add an implementation of IWebSecurityOrigin and a partially stubbed out
implementation of IWebDatabaseManager.


  • ForEachCoClass.h:
  • Interfaces/IWebDatabaseManager.idl:
  • Interfaces/WebKit.idl:
  • WebDatabaseManager.cpp: (WebDatabaseManager::createInstance): (WebDatabaseManager::WebDatabaseManager): (WebDatabaseManager::~WebDatabaseManager): (WebDatabaseManager::QueryInterface): (WebDatabaseManager::AddRef): (WebDatabaseManager::Release): (WebDatabaseManager::sharedWebDatabaseManager): (WebDatabaseManager::origins): (WebDatabaseManager::databasesWithOrigin): (WebDatabaseManager::detailsForDatabaseWithOrigin): (WebDatabaseManager::deleteAllDatabases): (WebDatabaseManager::deleteDatabasesWithOrigin): (WebDatabaseManager::deleteDatabaseWithOrigin):
  • WebDatabaseManager.h:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKitClassFactory.cpp:
  • WebSecurityOrigin.cpp: Added. (WebSecurityOrigin::createInstance): (WebSecurityOrigin::WebSecurityOrigin): (WebSecurityOrigin::~WebSecurityOrigin): (WebSecurityOrigin::QueryInterface): (WebSecurityOrigin::AddRef): (WebSecurityOrigin::Release): (WebSecurityOrigin::protocol): (WebSecurityOrigin::domain): (WebSecurityOrigin::port): (WebSecurityOrigin::usage): (WebSecurityOrigin::quota): (WebSecurityOrigin::setQuota):
  • WebSecurityOrigin.h: Added.
3:34 PM Changeset in webkit [28051] by mitz@apple.com
  • 2 edits in trunk/WebKitTools
  • Tiger build fix.
  • DumpRenderTree/mac/Configurations/Base.xcconfig:
3:03 PM Changeset in webkit [28050] by kmccullough@apple.com
  • 11 edits in trunk

WebKit/win:

Reviewed by Maciej.

  • Implemented displaying variables for Drosera on Win.
  • Interfaces/IWebScriptCallFrame.idl: Added a local function to be able to access the WebScriptCallFrame.
  • Interfaces/IWebScriptScope.idl: Implemented.
  • Interfaces/WebKit.idl: Added WebScriptScope to the tlb.
  • WebKit.vcproj/Interfaces.vcproj:
  • WebScriptCallFrame.cpp: Implemented the helper and accessor methods. (EnumScopes::Next): Fixed a bug where we did not release correctly and would accidentally destroy scopes. (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString): Implemented. (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString): Implemented
  • WebScriptCallFrame.h: Implemented the helper and accessor methods. (WebScriptCallFrame::impl): (WebScriptCallFrame::state):
  • WebScriptScope.cpp: Implmented. (EnumVariables::EnumVariables): Created an IEnumVariant over the variables to be able to pass a DCOM acceptable structure back to Drosera. (EnumVariables::createInstance): (EnumVariables::QueryInterface): (EnumVariables::AddRef): (EnumVariables::Release): (EnumVariables::Next): (EnumVariables::Skip): (EnumVariables::Reset): (EnumVariables::Clone): (WebScriptScope::WebScriptScope): (WebScriptScope::createInstance): Implemented. (WebScriptScope::variableNames): Implemented. (WebScriptScope::valueForVariable):
  • WebScriptScope.h: Implmeneted.

WebKitTools:

Reviewed by Maciej.

  • Implemented displaying variables for Drosera on Win.
  • Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions that retrieve variables to not hold onto the return value since it's not returned. Also changed to use the new signatures of the retrieval functions. (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed):
  • Drosera/win/Drosera.cpp: Removed a needless TODO. (droseraWndProc):
2:15 PM Changeset in webkit [28049] by andersca@apple.com
  • 3 edits
    2 adds in trunk/WebKit/win

Reviewed by Brady.

Add IWebDatabaseManager and IWebSecurityOrigin interfaces.


  • Interfaces/IWebDatabaseManager.idl: Added.
  • Interfaces/IWebSecurityOrigin.idl: Added.
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
1:19 PM Changeset in webkit [28048] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/5609337> Making a float shorter does not remove it from the floating object list of a nested block it intruded into

Test: fast/dynamic/float-withdrawal-2.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): When a float may have been withdrawn from a child, mark all descendants if necessary and not just the child.

LayoutTests:

Reviewed by Dave Hyatt.

  • test for <rdar://problem/5609337> Making a float shorter does not remove it from the floating object list of a nested block it intruded into
  • fast/dynamic/float-withdrawal-2.html: Added.
  • platform/mac/fast/dynamic/float-withdrawal-2-expected.checksum: Added.
  • platform/mac/fast/dynamic/float-withdrawal-2-expected.png: Added.
  • platform/mac/fast/dynamic/float-withdrawal-2-expected.txt: Added.
1:16 PM Changeset in webkit [28047] by weinig@apple.com
  • 4 edits in trunk/WebKitTools

Cleanup names of painting and repainting functions.

Reviewed by Adam Roben.

  • DumpRenderTree/cg/PixelDumpSupportCG.cpp: (drawSelectionRect): was drawSelectionRectIntoContext. (dumpWebViewAsPixelsAndCompareWithExpected):
  • DumpRenderTree/cg/PixelDumpSupportCG.h:
  • DumpRenderTree/mac/PixelDumpSupportMac.mm: (paintWebView): was drawWebViewIntoContext. (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
11:51 AM Changeset in webkit [28046] by alice.liu@apple.com
  • 2 edits in trunk/WebKit/win

Reviewed by Jon Honeycutt.

Fall back to the default Policy Delegate in these functions,
as is already done in dispatchDecidePolicyForNavigationAction

  • WebFrame.cpp: (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchUnableToImplementPolicy):
11:47 AM Changeset in webkit [28045] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Dan Bernstein.

  • Leopard build fix
  • DumpRenderTree/mac/Configurations/Base.xcconfig:
11:35 AM Changeset in webkit [28044] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Brady.

Get rid of the WebSecurityOriginPrivate object and store
the WebCore::SecurityOriginData pointer in the _private field of
the WebSecurityOrigin object instead.


  • Storage/WebDatabaseManager.mm: (-[WebDatabaseManager databasesWithOrigin:]): (-[WebDatabaseManager detailsForDatabase:withOrigin:]): (-[WebDatabaseManager deleteDatabasesWithOrigin:]): (-[WebDatabaseManager deleteDatabase:withOrigin:]):
  • Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin initWithProtocol:domain:port:]): (-[WebSecurityOrigin protocol]): (-[WebSecurityOrigin domain]): (-[WebSecurityOrigin port]): (-[WebSecurityOrigin usage]): (-[WebSecurityOrigin quota]): (-[WebSecurityOrigin setQuota:]): (-[WebSecurityOrigin dealloc]): (-[WebSecurityOrigin finalize]): (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]): (-[WebSecurityOrigin _core]):
  • Storage/WebSecurityOriginInternal.h:
11:34 AM Changeset in webkit [28043] by sfalken@apple.com
  • 2 edits
    1 move in trunk/WebCore

Build fix.

  • WebCore.vcproj/MigrateIDLAndScripts: Copied from WebCore.vcproj/MigrateIDLAndScripts.make.
  • WebCore.vcproj/MigrateIDLAndScripts.make: Removed.
  • WebCore.vcproj/migrate-idls.sh:
11:19 AM Changeset in webkit [28042] by weinig@apple.com
  • 7 edits
    2 moves
    2 deletes in trunk/WebKitTools

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16136
Use shared PixelDumpSupport for Mac DRT

Reviewed by Adam Roben.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
  • DumpRenderTree/cg/ImageDiffCG.cpp:
  • DumpRenderTree/cg/PixelDumpSupportCG.cpp: (drawSelectionRectIntoContext): (dumpWebViewAsPixelsAndCompareWithExpected):
  • DumpRenderTree/cg/PixelDumpSupportCG.h:
  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/DumpRenderTree.mm: (dump):
  • DumpRenderTree/mac/ImageDiff.m: Removed.
  • DumpRenderTree/mac/PixelDumpSupport.h: Removed.
  • DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
  • DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm. (setDefaultColorProfileToRGB): (getBitmapContextFromWebView): (drawWebViewIntoContext): (repaintWithVerticalSweep): (repaintWithHorizontalSweep): (getSelectionRect):
  • DumpRenderTree/win/PixelDumpSupport.h: Removed.
11:17 AM Changeset in webkit [28041] by beidson@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Anders (and typo lovingly found by Adam)

Change Databases to be stored in a per-origin directory hierarchy - this will make
storage quotas much easier to enforce

  • platform/SecurityOriginData.cpp: (WebCore::SecurityOriginData::SecurityOriginData): Parse string based on '_' instead of ':' (WebCore::SecurityOriginData::stringIdentifier): Change to use '_' as a separator instead of ':'. '_' still works due to not being allowed in domain names, but also is a valid filename character ' on all filesystems we care about
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): Create a per-origin directory hierarchy to categorize databases by origin
10:40 AM Changeset in webkit [28040] by alp@webkit.org
  • 1 edit
    1 add in trunk/JavaScriptCore

2007-11-26 Alp Toker <​alp@atoker.com>

GTK+/Qt/Wx build fix for breakage introduced in r28039.

  • ForwardingHeaders/JavaScriptCore/JSRetainPtr.h: Added.
9:17 AM Changeset in webkit [28039] by timothy@apple.com
  • 12 edits in trunk

WebCore:

Reviewed by Adam Roben.

Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title
​http://bugs.webkit.org/show_bug.cgi?id=16137

On Leopard the toolbar background will be transparent, to allow the
window background to show through the transparent WebView. The
search results divs needed to move inside the "main" div, so they
would be clipped and not show where the toolbar is.

  • page/InspectorController.cpp: (WebCore::platform): Return a string for which platform we are. (WebCore::InspectorController::windowScriptObjectAvailable): Define the platform function on the JavaScript class.
  • page/inspector/Panel.js: Add panels to the panels div.
  • page/inspector/inspector.css: On the Leopard platform make the toolbar background transparent so the window background shows.
  • page/inspector/inspector.html: Add a panels div and move search result divs inside the main div.
  • page/inspector/inspector.js: Tweak the resize code to acount for the search results divs moving inside the main div.

WebKit/mac:

Reviewed by Adam Roben.

Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title
​http://bugs.webkit.org/show_bug.cgi?id=16137

Create the Web Inspector window with the textured style. Set the content border
thickness for the top of the window or the height of the toolbar. Also make the
window's bottom corners square, since a normal textured window normally has
rounded bottom corners.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController window]):

WebKitLibraries:

Reviewed by Adam Roben.

Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title
​http://bugs.webkit.org/show_bug.cgi?id=16137

Add a new function to make bottom window corners square for textured windows.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceTiger.a:
  • libWebKitSystemInterfaceLeopard.a:
Note: See TracTimeline for information about the timeline view.