Timeline
Nov 28, 2007:
- 11:57 PM IconContestIdeas edited by
- (diff)
- 11:40 PM IconContestIdeas edited by
- (diff)
- 11:39 PM IconContestIdeas edited by
- Stole a judging criterion from the SVG logo contest (diff)
- 11:32 PM IconContestIdeas edited by
- Change start of submissions to be the same as the announcement (diff)
- 10:20 PM Changeset in webkit [28134] by
-
- 1 edit4 moves in trunk/LayoutTests
Unreviewed layout test fix. Fix typos in the name of four files used by HTTP layout tests.
- 10:07 PM Changeset in webkit [28133] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Geoff.
Fallback content inside media elements should not be rendered.
Test: media/fallback.html
- rendering/RenderMedia.h: (WebCore::RenderMedia::canHaveChildren):
LayoutTests:
Reviewed by Geoff.
Test that fallback content inside media elements is not be rendered.
- media/fallback-expected.txt: Added.
- media/fallback.html: Added.
- 10:04 PM Changeset in webkit [28132] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Geoff
Add copyKeysToVector utility, mirroring copyValuesToVector
Also change the copyValuesToVector implementation to be a little more attractive
- wtf/HashMap.h: (WTF::copyKeysToVector): (WTF::copyValuesToVector):
- 9:33 PM Changeset in webkit [28131] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- 9:29 PM Changeset in webkit [28130] by
-
- 2 edits in trunk/WebCore
Gtk build fix.
- 8:50 PM Changeset in webkit [28129] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver.
Make QTMovieView fill color transparent. This behavior matches the specification
(and allows nice alpha blended video).
- platform/graphics/mac/MoviePrivateQTKit.mm: (WebCore::MoviePrivate::createQTMovieView):
- 6:54 PM IconContestIdeas edited by
- (diff)
- 6:48 PM IconContestIdeas edited by
- (diff)
- 6:48 PM IconContestIdeas edited by
- (diff)
- 6:25 PM Changeset in webkit [28128] by
-
- 17 edits in trunk/LayoutTests
just some more typo fixes
- http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level-expected.txt:
- http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level.html:
- http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-from-javscript-url-expected.txt:
- http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-from-javscript-url.html:
- http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level-expected.txt:
- http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html:
- http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-expected.txt:
- http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame.html:
- http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe-expected.txt:
- http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe.html:
- http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open-expected.txt:
- http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open.html:
- http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe-expected.txt:
- http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe.html:
- http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open-expected.txt:
- http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open.html:
- 6:02 PM Changeset in webkit [28127] by
-
- 54 edits4 adds in trunk
WebCore:
Reviewed by Darin.
Test: media/video-controls.html
<rdar://problem/5605668>
Implement controls attribute for video element
- Add RenderMedia and make RenderVideo its subclass. Controls code goes to RenderMedia while video specific (painting etc) code stays in RenderVideo. For example audio controls can be implemented later by just instantiating RenderMedia as renderer.
- Make media renderer hierarchy inherit from RenderBlock instead of RenderReplaced so it can have child nodes (for controls).
- Controls are implemented as a shadow DOM.
- Current look is a placeholder. It is defined purely in CSS.
- Some things like volume controls are not yet implemented.
- Fade-in/out is done manually, CSS animations don't work well in shadow trees.
- WebCore.xcodeproj/project.pbxproj:
- css/html4.css:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): (WebCore::HTMLMediaElement::updateMovie): (WebCore::HTMLMediaElement::defaultEventHandler):
- html/HTMLMediaElement.h:
- rendering/RenderMedia.cpp: Added. (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): (WebCore::MediaControlShadowRootElement::isShadowNode): (WebCore::MediaControlShadowRootElement::shadowParentNode): (WebCore::MediaControlInputElement::MediaControlInputElement): (WebCore::MediaControlInputElement::attachToParent): (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): (WebCore::MediaControlPlayButtonElement::inPausedState): (WebCore::MediaControlPlayButtonElement::defaultEventHandler): (WebCore::MediaControlPlayButtonElement::update): (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): (WebCore::MediaControlTimelineElement::defaultEventHandler): (WebCore::MediaControlTimelineElement::update): (WebCore::RenderMedia::RenderMedia): (WebCore::RenderMedia::~RenderMedia): (WebCore::RenderMedia::mediaElement): (WebCore::RenderMedia::movie): (WebCore::RenderMedia::setStyle): (WebCore::RenderMedia::createControlsShadowRoot): (WebCore::RenderMedia::createPanel): (WebCore::RenderMedia::createPlayButton): (WebCore::RenderMedia::createTimeline): (WebCore::RenderMedia::createTimeDisplay): (WebCore::RenderMedia::updateFromElement): (WebCore::RenderMedia::updateControls): (WebCore::RenderMedia::timeUpdateTimerFired): (WebCore::RenderMedia::updateTimeDisplay): (WebCore::RenderMedia::updateControlVisibility): (WebCore::RenderMedia::changeOpacity): (WebCore::RenderMedia::opacityAnimationTimerFired): (WebCore::RenderMedia::forwardEvent):
- rendering/RenderMedia.h: Added. (WebCore::RenderMedia::renderName): (WebCore::RenderMedia::isMedia): (WebCore::RenderMedia::intrinsicSize):
- rendering/RenderObject.h: (WebCore::RenderObject::isMedia):
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo): (WebCore::RenderVideo::videoSizeChanged): (WebCore::RenderVideo::paintObject): (WebCore::RenderVideo::layout): (WebCore::RenderVideo::updateFromElement): (WebCore::RenderVideo::calcAspectRatioWidth): (WebCore::RenderVideo::calcAspectRatioHeight):
- rendering/RenderVideo.h:
LayoutTests:
Reviewed by Darin.
<rdar://problem/5605668>
Implement controls attribute for video element
- A new test for the controls attribute.
- Add the controls attibute to all existing video tests. This will give the code some additional exercise without affecting test results.
- media/progress-event.html:
- media/video-append-source.html:
- media/video-autoplay.html:
- media/video-buffered.html:
- media/video-controls-expected.txt: Added.
- media/video-controls.html: Added.
- media/video-currentTime-set.html:
- media/video-currentTime-set2.html:
- media/video-currentTime.html:
- media/video-dom-autoplay.html:
- media/video-dom-end.html:
- media/video-dom-loopcount.html:
- media/video-dom-loopend.html:
- media/video-dom-loopstart.html:
- media/video-dom-src.html:
- media/video-dom-start.html:
- media/video-end.html:
- media/video-error-abort.html:
- media/video-error-does-not-exist.html:
- media/video-load-networkState.html:
- media/video-load-readyState.html:
- media/video-loopcount.html:
- media/video-loopend.html:
- media/video-loopstart.html:
- media/video-muted.html:
- media/video-no-autoplay.html:
- media/video-pause-empty-events.html:
- media/video-play-empty-events.html:
- media/video-play-pause-events.html:
- media/video-play-pause-exception.html:
- media/video-poster.html:
- media/video-seek-past-end-paused.html:
- media/video-seek-past-end-playing.html:
- media/video-seekable.html:
- media/video-seeking.html:
- media/video-size.html:
- media/video-source-media.html:
- media/video-source-type.html:
- media/video-source.html:
- media/video-src-change.html:
- media/video-src-remove.html:
- media/video-src-set.html:
- media/video-src-source.html:
- media/video-src.html:
- media/video-start.html:
- media/video-volume.html:
- media/video-width-height.html:
- 5:33 PM Changeset in webkit [28126] by
-
- 15 edits6 adds in trunk
WebCore:
Reviewed by Darin Adler.
<rdar://problem/5573879> GMail Beta: Crash in when undoing Remove Formating
In the new beta, Google has added some custom code on top of our RemoveFormat
to work around a bug where fully selected lists aren't removed. This code corrupts
the undo stack and causes crashes. This change fixes two problems with RemoveFormat
so that Google doesn't have to have any custom code. After checking this in I'll
work on bulletproofing the undo stack
- WebCore.xcodeproj/project.pbxproj:
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertLineBreak): Added this convenience method. (WebCore::CompositeEditCommand::inputText): Added code to select all inserted text, not just the last paragraph. Added code to support an input string with '\n's.
- editing/CompositeEditCommand.h:
- editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): Moved code to its own EditCommand.
- editing/RemoveFormatCommand.cpp: Added. Moved code from removeFormattingAndStyle here. (WebCore::RemoveFormatCommand::RemoveFormatCommand): (WebCore::RemoveFormatCommand::doApply): Added code to remove fully selected lists.
- editing/RemoveFormatCommand.h: Added. (WebCore::RemoveFormatCommand::editingAction):
LayoutTests:
Reviewed by Darin Adler.
<rdar://problem/5573879> GMail Beta: Crash in when undoing Remove Formating
Added to demonstrate fixes:
- editing/execCommand/5573879.html: Added.
- platform/mac/editing/execCommand/5573879-expected.checksum: Added.
- platform/mac/editing/execCommand/5573879-expected.png: Added.
- platform/mac/editing/execCommand/5573879-expected.txt: Added.
Fixes (RemoveFormat now preserves the selection correctly):
- platform/mac/editing/execCommand/4920742-1-expected.checksum:
- platform/mac/editing/execCommand/4920742-1-expected.png:
- platform/mac/editing/execCommand/4920742-1-expected.txt:
- platform/mac/editing/execCommand/remove-formatting-2-expected.checksum:
- platform/mac/editing/execCommand/remove-formatting-2-expected.png:
- platform/mac/editing/execCommand/remove-formatting-2-expected.txt:
- platform/mac/editing/execCommand/remove-formatting-expected.checksum:
- platform/mac/editing/execCommand/remove-formatting-expected.png:
- platform/mac/editing/execCommand/remove-formatting-expected.txt:
- 5:17 PM IconContestIdeas edited by
- Little re-organziation (diff)
- 5:16 PM IconContestIdeas edited by
- Added a submissions section (diff)
- 5:13 PM WebKit Team edited by
- (diff)
- 5:06 PM IconContestIdeas edited by
- (diff)
- 5:05 PM Changeset in webkit [28125] by
-
- 3 edits in trunk/LayoutTests
Make this test not depend on the screen size.
- fast/dom/Window/window-resize-expected.txt:
- fast/dom/Window/window-resize.html:
- 5:04 PM IconContestIdeas edited by
- (diff)
- 5:02 PM IconContestIdeas edited by
- Added a disclaimer (diff)
- 4:59 PM IconContestIdeas edited by
- Added a preliminary schedule (diff)
- 4:44 PM IconContestIdeas edited by
- Added voting section (diff)
- 4:43 PM Changeset in webkit [28124] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Adam Roben.
- DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:]): Send capital letters through as lowercase letters with the shift key down rather than sending them as if they were highly unusual "capital letter keys".
- Scripts/update-javascriptcore-test-results: Add a "--force" option for cases where you need to update results and more tests are failing than before.
- 4:33 PM Changeset in webkit [28123] by
-
- 6 edits in trunk
WebKitTools:
Reviewed by Darin.
<rdar://problem/5132001>
contextClick is not implemented in DRT on Windows.
- DumpRenderTree/win/EventSender.cpp: (contextClickCallback): Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed by a WM_RBUTTONUP message.
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::hasCustomMenuImplementation): (UIDelegate::trackCustomPopupMenu):
- DumpRenderTree/win/UIDelegate.h: Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup menu from being shown (and causing the DRT to hang).
LayoutTests:
Reviewed by Darin.
<rdar://problem/5132001>
contextClick is not implemented in DRT on Windows.
Remove tests that pass now that we have contextClick.
- platform/win/Skipped:
- 3:05 PM Changeset in webkit [28122] by
-
- 2 edits in trunk/LayoutTests
Removing some tests tracked by <rdar://5130762> because they don't fail.
- platform/win/Skipped:
- 3:01 PM IconContestIdeas edited by
- Rename resolution to size. (diff)
- 2:54 PM HackingGtk edited by
- Add an API rationale (diff)
- 2:51 PM IconContestIdeas edited by
- (diff)
- 2:45 PM Changeset in webkit [28121] by
-
- 2 edits in trunk/LayoutTests
Removing fixed tests tracked by <rdar://5128229>
- platform/win/Skipped:
- 2:41 PM IconContestIdeas edited by
- (diff)
- 2:29 PM IconContestIdeas edited by
- (diff)
- 2:29 PM IconContestIdeas edited by
- (diff)
- 2:27 PM Changeset in webkit [28120] by
-
- 2 edits8 moves in trunk/LayoutTests
Rubberstamped by Sam.
Fixing a typo in some filenames
- http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe-expected.txt: Removed.
- http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe.html: Removed.
- http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open-expected.txt: Removed.
- http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open.html: Removed.
- http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe-expected.txt.
- http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe.html: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe.html.
- http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open-expected.txt.
- http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open.html: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open.html.
- http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe-expected.txt: Removed.
- http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe.html: Removed.
- http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open-expected.txt: Removed.
- http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open.html: Removed.
- http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe-expected.txt.
- http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe.html: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe.html.
- http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open-expected.txt.
- http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open.html: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open.html.
- platform/win/Skipped:
- 2:25 PM IconContestIdeas created by
- Initial ideas for a WebKit icon contest
- 2:24 PM Changeset in webkit [28119] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Tim.
- Added guards to the wait loop so execution would not hang and now the console window can process JavaScript.
- WebScriptDebugServer.cpp: (WebScriptDebugServer::suspendProcessIfPaused):
- 2:04 PM Changeset in webkit [28118] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/5612459> CrashTracer: [REGRESSION] 61 crashes in Safari at com.apple.WebCore: WebCore::AutoTableLayout::layout + 2046
Test: fast/table/empty-auto-column-zero-divide.html
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout): When distributing the remaining width among columns, skip those whose effective (rather than specified) width is auto and contain only empty cells.
LayoutTests:
Reviewed by Dave Hyatt.
- test for <rdar://problem/5612459> CrashTracer: [REGRESSION] 61 crashes in Safari at com.apple.WebCore: WebCore::AutoTableLayout::layout + 2046
- fast/table/empty-auto-column-zero-divide-expected.txt: Added.
- fast/table/empty-auto-column-zero-divide.html: Added.
- 2:03 PM Changeset in webkit [28117] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin.
Fix for <rdar://problem/5524216> CrashTracer: [USER] 496 crashes in Safari at com.apple.WebCore: WebCore::Frame::eventHandler const + 6
The CrashTracer shows a variety of crashes in different methods (including keyDown and keyUp). This change adds nil checks for the frame in
WebHTMLView to prevent future problems in other methods as well.
- WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView keyDown:]): (-[WebHTMLView keyUp:]): (-[WebHTMLView flagsChanged:]): (-[WebHTMLView _selectionStartFontAttributesAsRTF]): (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]): (-[WebHTMLView checkSpelling:]): (-[WebHTMLView showGuessPanel:]): (-[WebHTMLView indent:]): (-[WebHTMLView outdent:]): (-[WebHTMLView paste:]): (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[WebHTMLView insertText:]): (-[WebHTMLView selectionTextRects]):
- 1:17 PM Changeset in webkit [28116] by
-
- 4 edits in trunk/WebKit/win
Reviewed by Adam.
Implement the last bits of the WebDatabaseManager API.
- Interfaces/IWebDatabaseManager.idl:
- WebDatabaseManager.cpp: (isEqual): (WebDatabaseManager::sharedWebDatabaseManager): (WebDatabaseManager::dispatchDidModifyOrigin): (WebDatabaseManager::dispatchDidModifyDatabase):
- WebDatabaseManager.h:
- 12:55 PM WebKit Team edited by
- (diff)
- 12:12 PM Changeset in webkit [28115] by
-
- 2 edits in trunk/WebKit/win
Get Drosera working again for real.
- COMEnumVariant.h: (::Next):
- 11:57 AM Changeset in webkit [28114] by
-
- 3 edits in trunk/WebCore
2007-11-28 Peter Kasting <zerodpx@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16169
GIF decoder needs to set hasAlpha() correctly on subsequent frames.
This also removes the workaround for this problem in
ImageSourceCairo.cpp.
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameHasAlphaAtIndex):
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::initFrameBuffer):
- 11:37 AM Changeset in webkit [28113] by
-
- 2 edits in trunk/LayoutTests
2007-11-28 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Dan.
<rdar://problem/5507360> plugins/return-error-from-new-stream-callback-
in-full-frame-plugin.html is crashing
Alice fixed this in r28046
- platform/win/Skipped:
- 10:08 AM HackingGtk edited by
- Codify URL vs. URI public API policy (diff)
- 9:46 AM Changeset in webkit [28112] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Maciej and Adam.
- Added Drosera to the WebKit project.
- WebKit.vcproj/WebKit.sln:
- 8:47 AM Changeset in webkit [28111] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler and Adam Roben.
- <rdar://problem/5057218> Reenable "recent searches" search field menu when menu is fully implemented
- platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenu::enabled): Changed to return true. (WebCore::autosaveKey): Added. Returns a preferences key for the autosave name by prefixing it with "com.apple.WebKit.searchField:". (WebCore::SearchPopupMenu::saveRecentSearches): Implemented. (WebCore::SearchPopupMenu::loadRecentSearches): Implemented.
- 5:12 AM Changeset in webkit [28110] by
-
- 59 edits10 deletes in trunk
Roll out r28106 and r28108. These introduced a frequent assertion failure on page load and broke all non-Mac builds.
- 4:47 AM Changeset in webkit [28109] by
-
- 2 edits in trunk/WebCore
2007-11-28 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=15689
[GTK] Background of loading images is always black
frameHasAlphaAtIndex() exists only to allow optimization for cases we
are certain the image can be blitted rather than composited.
Thus we need to be conservative, returning false only when we are
absolutely certain there is no need for composited copying, and true
otherwise.
CG doesn't even bother with this optimization at all and always
returns true.
Patch includes a workaround for
http://bugs.webkit.org/show_bug.cgi?id=16169
GIF ImageDecoder hasAlpha() return value incorrect
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameHasAlphaAtIndex):
- 3:03 AM Changeset in webkit [28108] by
-
- 2 edits10 adds in trunk
Add files missing from previous commit.
- kjs/MarkStack.h: Added.
LayoutTests:
add files missing from previous commit.
- fast/js/gc-breadth-2-expected.txt: Added.
- fast/js/gc-breadth-2.html: Added.
- fast/js/gc-breadth-expected.txt: Added.
- fast/js/gc-breadth.html: Added.
- fast/js/gc-depth-expected.txt: Added.
- fast/js/gc-depth.html: Added.
- fast/js/resources/gc-breadth-2.js: Added.
- fast/js/resources/gc-breadth.js: Added.
- fast/js/resources/gc-depth.js: Added.
- 2:42 AM Changeset in webkit [28107] by
-
- 2 edits in trunk
2007-11-26 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Mark Rowe.
Set CONFIG option for the window system GTK+ is using
- WebKit.pri:
- 2:08 AM Changeset in webkit [28106] by
-
- 59 edits in trunk
Reviewed by Darin and Geoff.
- Fixed "Stack overflow crash in JavaScript garbage collector mark pass" http://bugs.webkit.org/show_bug.cgi?id=12216
Implement mark stack. This version is not suitable for prime time because it makes a
huge allocation on every collect, and potentially makes marking of detached subtrees
slow. But it is an 0.4% SunSpider speedup even without much tweaking.
The basic approach is to replace mark() methods with
markChildren(MarkStack&) methods. Reachable references are pushed
onto a mark stack (which encapsulates ignoring already-marked
references).
Objects are no longer responsible for actually setting their own
mark bits, the collector does that. This means that for objects on
the number heap we don't have to call markChildren() at all since
we know there aren't any.
The mark phase of collect pushes roots onto the mark stack
and drains it as often as possible.
To make this approach viable requires a constant-size mark stack
and a slow fallback approach for when the stack size is exceeded,
plus optimizations to make the required stack small in common
cases. This should be doable.
- JavaScriptCore.exp: Export new symbols.
- JavaScriptCore.xcodeproj/project.pbxproj: Add new file.
- kjs/collector.cpp: (KJS::Collector::heapAllocate): (KJS::drainMarkStack): Helper for all of the below. (KJS::Collector::markStackObjectsConservatively): Use mark stack. (KJS::Collector::markCurrentThreadConservatively): ditto (KJS::Collector::markOtherThreadConservatively): ditto (KJS::Collector::markProtectedObjects): ditto (KJS::Collector::markMainThreadOnlyObjects): ditto (KJS::Collector::collect): ditto
- kjs/collector.h: (KJS::Collector::cellMayHaveRefs): Helper for MarkStack.
- kjs/MarkStack.h: Added. The actual mark stack implementation. (KJS::MarkStack::push): (KJS::MarkStack::pushAtom): (KJS::MarkStack::pop): (KJS::MarkStack::isEmpty): (KJS::MarkStack::reserveCapacity):
Changed mark() methods to markChildren() methods:
- kjs/ExecState.cpp: (KJS::ExecState::markChildren):
- kjs/ExecState.h:
- kjs/JSWrapperObject.cpp: (KJS::JSWrapperObject::markChildren):
- kjs/JSWrapperObject.h:
- kjs/array_instance.cpp: (KJS::ArrayInstance::markChildren):
- kjs/array_instance.h:
- kjs/bool_object.cpp: (BooleanInstance::markChildren):
- kjs/bool_object.h:
- kjs/error_object.cpp:
- kjs/error_object.h:
- kjs/function.cpp: (KJS::FunctionImp::markChildren): (KJS::Arguments::Arguments): (KJS::Arguments::markChildren): (KJS::ActivationImp::markChildren):
- kjs/function.h:
- kjs/internal.cpp: (KJS::GetterSetterImp::markChildren):
- kjs/interpreter.cpp: (KJS::Interpreter::markRoots):
- kjs/interpreter.h:
- kjs/list.cpp: (KJS::List::markProtectedListsSlowCase):
- kjs/list.h: (KJS::List::markProtectedLists):
- kjs/object.cpp: (KJS::JSObject::markChildren):
- kjs/object.h: (KJS::ScopeChain::markChildren):
- kjs/property_map.cpp: (KJS::PropertyMap::markChildren):
- kjs/property_map.h:
- kjs/scope_chain.h:
- kjs/string_object.cpp: (KJS::StringInstance::markChildren):
- kjs/string_object.h:
JavaScriptGlue:
Reviewed by Darin and Geoff.
Fixups for JavaScriptCore mark stack.
- JSObject.cpp: (JSUserObject::Mark):
- JSObject.h:
- JSValueWrapper.cpp: (JSValueWrapper::JSObjectMark):
- JSValueWrapper.h:
- UserObjectImp.cpp:
- UserObjectImp.h:
WebCore:
Reviewed by Darin and Geoff.
Implement mark stack. This version is not suitable for prime time because it makes a
huge allocation on every collect, and potentially makes marking of detached subtrees
slow. But it is a .2% - .4% speedup even without much tweaking.
I replaced mark() methods with markChildren() as usual. One
optimization that is lost is avoiding walking detached DOM
subtrees more than once to mark them; since marking is not
recursive there's no obvious way to bracket operation on the tree
any more.
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::markChildren):
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren):
- bindings/js/JSNodeFilterCondition.cpp:
- bindings/js/JSNodeFilterCondition.h:
- bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::markChildren):
- bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::markChildren):
- bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::markChildren):
- bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::markChildren):
- bindings/js/JSXMLHttpRequest.h:
- bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::markDOMNodesForDocument):
- bindings/js/kjs_binding.h:
- bindings/js/kjs_events.cpp: (WebCore::JSUnprotectedEventListener::markChildren):
- bindings/js/kjs_events.h:
- bindings/js/kjs_window.cpp: (KJS::Window::markChildren):
- bindings/js/kjs_window.h:
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Node.cpp: (WebCore::Node::Node):
- dom/Node.h:
- dom/NodeFilter.h:
- dom/NodeFilterCondition.h:
LayoutTests:
Not reviewed.
- Test cases for "Stack overflow crash in JavaScript garbage collector mark pass" http://bugs.webkit.org/show_bug.cgi?id=12216
I have fixed this with the mark stack work.
- fast/js/gc-breadth-2-expected.txt: Added.
- fast/js/gc-breadth-2.html: Added.
- fast/js/gc-breadth-expected.txt: Added.
- fast/js/gc-breadth.html: Added.
- fast/js/gc-depth-expected.txt: Added.
- fast/js/gc-depth.html: Added.
- fast/js/resources/gc-breadth-2.js: Added.
- fast/js/resources/gc-breadth.js: Added.
- fast/js/resources/gc-depth.js: Added.
- 1:24 AM Changeset in webkit [28105] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Not reviewer for this patch.
- 1:04 AM Changeset in webkit [28104] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Maciej Stachowiak.
- fix <rdar://problem/5596160> fast/events/objc-event-api.html fails when run alone (or first)
- WebView/WebHTMLView.mm: (-[WebHTMLView setDataSource:]): This method calls addMouseMovedObserver because addMouseMovedObserver returns early if the dataSource is not nil. But if the dataSource is already set (which happens when a WebHTMLView is being reused) then addMouseMovedObserver must not be called again.
- 12:27 AM Changeset in webkit [28103] by
-
- 3 edits1 add in trunk
2007-11-27 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Install the JavaScriptCore headers as part of the GTK+ port.
Nov 27, 2007:
- 10:31 PM Changeset in webkit [28102] by
-
- 3 edits5 adds in trunk
WebCore:
Reviewed by Oliver.
Fix for <rdar://problem/5616052> SVGs with width or height of 100%
hang when used as a background-image (16164)
- platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::size): Use valueAsPercentage() for percents instead of valueInSpecifiedUnits(). valueInSpecifiedUnits() returns, for example, 50 for 50%, so multiplying percentages by the default size of 300 x 150 led to ridiculously huge dimensions for SVG images, and the subsequent hang.
LayoutTests:
Reviewed by Oliver.
Test for <rdar://problem/5616052> SVGs with width or height of 100%
hang when used as a background-image (16164)
- fast/images/resources/width-100-percent.svg: Added.
- fast/images/svg-width-100p-as-background.html: Added.
- platform/mac/fast/images/svg-width-100p-as-background-expected.checksum: Added.
- platform/mac/fast/images/svg-width-100p-as-background-expected.png: Added.
- platform/mac/fast/images/svg-width-100p-as-background-expected.txt: Added.
- 9:54 PM Changeset in webkit [28101] by
-
- 2 edits in trunk/WebKitTools
Not reviewed.
Fix DumpRenderTree ObjC bug comparing strings.
- DumpRenderTree/mac/ObjCController.m: (-[ObjCController identityIsEqual::]): Compare strings with string equality instead of identiy equality.
- 9:48 PM Changeset in webkit [28100] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-27 Alp Toker <alp@atoker.com>
Prospective MSVC build fix.
Roll back dllexport/dllimport support for now.
- API/JSBase.h:
- 8:50 PM Changeset in webkit [28099] by
-
- 2 edits in trunk/WebKit/win
2007-11-27 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Adam.
Return bool from registerWebViewWindowClass, as nothing uses the ATOM.
Set haveRegisteredWindowClass to true
- WebView.cpp: (registerWebViewWindowClass):
- 8:47 PM Changeset in webkit [28098] by
-
- 2 edits in trunk/WebCore
2007-11-27 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Adam.
Set haveRegisteredWindowClass when we register the window class.
- plugins/win/PluginViewWin.cpp: (WebCore::registerPluginView):
- 8:31 PM Changeset in webkit [28097] by
-
- 8 edits in trunk/JavaScriptCore
2007-11-27 Alp Toker <alp@atoker.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=15569
[gtk] GTK JavaScriptCore needs to export symbols for JSC API and WTF
Introduce JS_EXPORT to mark symbols to be exported as public API.
Export all public symbols in the JavaScriptCore C API.
This matches conventions for exporting symbols set by the CF and CG
frameworks.
- API/JSBase.h:
- API/JSContextRef.h:
- API/JSObjectRef.h:
- API/JSStringRef.h:
- API/JSStringRefBSTR.h:
- API/JSStringRefCF.h:
- API/JSValueRef.h:
- 6:47 PM Changeset in webkit [28096] by
-
- 2 edits in trunk/WebKit/win
Speculative fix to get Drosera working.
- COMEnumVariant.h: (::Next): Update the number of elements fetched correctly.
- 5:34 PM Changeset in webkit [28095] by
-
- 6 edits in trunk/WebKit/mac
Reviewed by Brady.
- Storage/WebDatabaseManager.mm:
- Storage/WebDatabaseManagerPrivate.h:
- Storage/WebDatabaseTrackerClient.mm: (WebDatabaseTrackerClient::dispatchDidModifyOrigin): (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
- Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
- Storage/WebSecurityOriginInternal.h:
- 5:22 PM Changeset in webkit [28094] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Sam.
Reset the authorAndUserStylesEnabled preference
back to YES for each test. Fixes the broken tests.
- DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
- 5:12 PM Changeset in webkit [28093] by
-
- 4 edits in trunk/WebCore
Reviewed by Sam Weinig.
Bug 16165: Dragging the inspector toolbar should move the window
http://bugs.webkit.org/show_bug.cgi?id=16165
- page/inspector/DocumentPanel.js: Call the new drag functions, and cleanup code.
- page/inspector/inspector.css: Only make the toolbar transparent in detached mode.
- page/inspector/inspector.js: Call the new drag functions, and cleanup code. Add toolbar drag functions that move the window.
- 5:12 PM Changeset in webkit [28092] by
-
- 13 edits in trunk/WebKit/win
Reviewed by Adam.
Some COM cleanup.
- CFDictionaryPropertyBag.cpp: (CFDictionaryPropertyBag::QueryInterface):
- CFDictionaryPropertyBag.h:
- WebBackForwardList.cpp: (WebBackForwardList::addItem): (WebBackForwardList::removeItem):
- WebDownload.cpp: (WebDownload::initWithRequest):
- WebFrame.cpp: (WebFrame::loadRequest): (WebFrame::initWithWebFrameView): (WebFrame::webHistory): (WebFrame::dispatchWillSendRequest):
- WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::QueryInterface): (WebURLAuthenticationChallenge::initWithProtectionSpace):
- WebURLAuthenticationChallenge.h:
- WebURLAuthenticationChallengeSender.cpp: (WebURLAuthenticationChallengeSender::QueryInterface):
- WebURLAuthenticationChallengeSender.h:
- WebURLResponse.cpp: (WebURLResponse::QueryInterface):
- WebURLResponse.h:
- WebView.cpp: (WebView::notifyDidAddIcon): (WebView::goToBackForwardItem): (WebView::canHandleRequest): (WebView::loadBackForwardListFromOtherView): (core):
- 4:35 PM Changeset in webkit [28091] by
-
- 4 edits in trunk/WebKitTools
Reviewed by Adam.
- Drosera now displays the console window, although it cannot currently process JavaScript.
- Drosera/win/DebuggerClient.cpp: Shows the console window. (registerConsoleClass): Implemented. (consoleWndProc): Implemented. (DebuggerClient::onSize): Implemented. (DebuggerClient::createWebViewWithRequest): Implemented, now creates a new window.
- Drosera/win/DebuggerClient.h: Added needed method and members for creating and maintaining a new window.
- Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of lines of code to more appropriate places. (Drosera::handleCommand): (Drosera::initUI): (Drosera::onSize): (Drosera::attach):
- 4:12 PM Changeset in webkit [28090] by
-
- 2 edits in trunk/WebKit/win
Add COMEnumVariant.h to the project.
- WebKit.vcproj/WebKit.vcproj:
- 4:11 PM Changeset in webkit [28089] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Adam.
Return E_INVALIDARG if the databaseName BSTR is null;
- WebDatabaseManager.cpp: (WebDatabaseManager::detailsForDatabaseWithOrigin): (WebDatabaseManager::deleteDatabaseWithOrigin):
- 3:57 PM Changeset in webkit [28088] by
-
- 5 edits in trunk/WebKit/win
Reviewed by Adam.
Implement the rest of the WebDatabaseManager API.
- COMEnumVariant.h:
- Interfaces/IWebDatabaseManager.idl:
- WebDatabaseManager.cpp: (isEqual): (DatabaseDetailsPropertyBag::DatabaseDetailsPropertyBag): (DatabaseDetailsPropertyBag::~DatabaseDetailsPropertyBag): (DatabaseDetailsPropertyBag::createInstance): (DatabaseDetailsPropertyBag::AddRef): (DatabaseDetailsPropertyBag::Release): (DatabaseDetailsPropertyBag::QueryInterface): (DatabaseDetailsPropertyBag::Read): (DatabaseDetailsPropertyBag::Write): (WebDatabaseManager::detailsForDatabaseWithOrigin): (WebDatabaseManager::deleteAllDatabases): (WebDatabaseManager::deleteDatabasesWithOrigin): (WebDatabaseManager::deleteDatabaseWithOrigin):
- WebDatabaseManager.h:
- 3:34 PM Changeset in webkit [28087] by
-
- 2 edits in trunk/LayoutTests
Land results for my last test change,
- 3:32 PM Changeset in webkit [28086] by
-
- 3 edits in trunk/WebKit/win
<rdar://problem/5616098> The BSTR returned by WebHistoryItem::alternateTitle
was not allocated correctly.
Reviewed by Anders.
- WebHistoryItem.cpp: (WebHistoryItem::setAlternateTitle): (WebHistoryItem::alternateTitle):
- WebHistoryItem.h:
- 3:30 PM Changeset in webkit [28085] by
-
- 4 edits in trunk/WebCore
Reviewed by Mitz.
Small changes to make RenderSlider a bit more generic so it can be used in video controls.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Fix coordinates with forwarded events.
- rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): Fix coordinates with forwarded events. (WebCore::RenderSlider::setStyle): (WebCore::RenderSlider::createThumbStyle): Copy thumb left and top from the orginal style so position does not reset. (WebCore::RenderSlider::mouseEventIsInThumb): Make this work with forwarded events.
- rendering/RenderSlider.h:
- 3:27 PM Changeset in webkit [28084] by
-
- 7 edits in trunk/WebCore
Reviewed by Darin.
- Don't use hasPseudoId() optimization for pseudo styles used in shadow trees. These styles generally exist when asked for so the optimization does not do much. This reverses the continuing growth of the _pseudoBits bitfield in RenderStyle.
- Add some pseudo elements for media controls
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
- css/CSSSelector.h: (WebCore::CSSSelector::):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::checkOneSelector):
- rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle):
- rendering/RenderStyle.cpp: (WebCore::pseudoBit): (WebCore::RenderStyle::hasPseudoStyle): (WebCore::RenderStyle::setHasPseudoStyle):
- rendering/RenderStyle.h: (WebCore::RenderStyle::):
- 3:05 PM Changeset in webkit [28083] by
-
- 4 edits in trunk
WebCore:
Reviewed by Kevin McCullough.
Bug 16161: window.moveBy(0, 0) moves the window by -22px vertically
http://bugs.webkit.org/show_bug.cgi?id=16161
Removed the "Adjust the window rect to be in the coordinate space of
the screen rect" step which was always adding (0,22) to the window
position (on the main screen). Instead, account for screen X and Y
in the bottom and right constrain step.
Added more test cases to: fast/dom/Window/window-resize.html
- bindings/js/kjs_window.cpp: (KJS::adjustWindowRect):
LayoutTests:
Reviewed by Kevin McCullough.
Bug 16161: window.moveBy(0, 0) moves the window by -22px vertically
http://bugs.webkit.org/show_bug.cgi?id=16161
Added test cases for moveBy(0, 0), moveBy(0, 1) and moveBy(1, 0).
- fast/dom/Window/window-resize.html:
- 3:00 PM Changeset in webkit [28082] by
-
- 3 edits in trunk/JavaScriptGlue
Build fix.
- JSUtils.cpp: (KJSValueToCFTypeInternal):
- JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames):
- 2:30 PM Changeset in webkit [28081] by
-
- 4 edits in trunk/WebKit/mac
Reviewed by Darin, landed by Anders.
Fixed: <rdar://problem/4610818> CrashTracer: 1533 crashes in Safari at com.macromedia.Flash Player.plugin: native_ShockwaveFlash_TCallLabel + 271131
The problem was that some Leopard users were still inadvertently using the old Flash 8 plug-in, even though Leopard
shipped with Flash 9. To avoid loading an older version of a plug-in when a newer version is installed, the plug-in
database will compare bundle versions and always load the latest version.
- Plugins/WebBasePluginPackage.h:
- Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage versionNumber]): New method. CFBundleGetVersionNumber doesn't work with all possible versioning schemes, but we think for now it's good enough for us.
- Plugins/WebPluginDatabase.m: (considerCandidate): Added a C utility function which compares the current plug-in against a candidate plug-in's version number. If both plug-ins have the same bundle ID and the candiate is newer, the current plug-in becomes the candidate. (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): Calls the new considerCandidate() function.
- 2:27 PM Changeset in webkit [28080] by
-
- 3 edits in trunk/WebKit/win
Reviewed by Adam.
Use COMEnumVariant in WebScriptCallFrame and WebScriptScope.
- WebScriptCallFrame.cpp: (WebScriptCallFrame::scopeChain):
- WebScriptScope.cpp: (WebScriptScope::variableNames):
- 2:21 PM Changeset in webkit [28079] by
-
- 6 edits in trunk/JavaScriptCore
Reviewed by Adam.
Make PropertyNameArray and ScopeChain COMEnumVariant friendly.
- kjs/PropertyNameArray.cpp: (KJS::PropertyNameArray::swap): Implement PropertyNameArray::swap.
- kjs/PropertyNameArray.h: Add ValueType typedef. Replace PropertyNameArrayIterator with PropertyNameArray::const_iterator.
- kjs/nodes.cpp: (KJS::ForInNode::execute):
- kjs/scope_chain.cpp: (KJS::ScopeChain::print): Update for changes to PropertyNameArray.
- kjs/scope_chain.h: Add const_iterator and ValueType typedef.
- 1:48 PM Changeset in webkit [28078] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Adam.
Use the correct include paths.
- COMEnumVariant.h:
- 1:43 PM Changeset in webkit [28077] by
-
- 4 edits1 add in trunk/WebKit/win
Reviewed by Darin.
Add COMEnumVariant, a templatized class with implements IEnumVARIANT and lets
you enumerate over a C++ container, be it WTF or STL.
- COMEnumVariant.h: Added.
- WebDatabaseManager.cpp: (WebDatabaseManager::origins): (WebDatabaseManager::databasesWithOrigin): Implement these using COMEnumVariant.
- WebSecurityOrigin.cpp: (WebSecurityOrigin::QueryInterface):
- WebSecurityOrigin.h: Add a UUID for the implementation so that other parts of WebKit can access the WebCore::SecurityOriginData object.
- 1:27 PM Changeset in webkit [28076] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin.
Add a ValueType typedef.
- wtf/Vector.h:
- 1:23 PM Changeset in webkit [28075] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
- page/inspector/inspector.css: Make the text in the Network panel legend more readable.
- 12:51 PM Changeset in webkit [28074] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
Don't call setNeedsReapplyStylesInAllFrames if the
authorAndUserStylesEnabled setting didn't change.
- page/Settings.cpp: (WebCore::Settings::setAuthorAndUserStylesEnabled):
- 10:53 AM Changeset in webkit [28073] by
-
- 2 edits in trunk/WebCore
2007-11-27 Alp Toker <alp@atoker.com>
Fix potential broken build due to a missing DEPENDPATH.
- WebCore.pro:
- 10:48 AM Changeset in webkit [28072] by
-
- 3 edits in trunk/WebKitLibraries
Fixed 5614525, caused by a recent bug in WKGetExtensionsForMIMEType
that affects Safari.
reviewed by Kevin Decker
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 9:15 AM Changeset in webkit [28071] by
-
- 22 edits2 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
<rdar://problem/5569233> Add the ability to disable author and user CSS styles
- WebCore.base.exp: Add the Settings::setAuthorAndUserStylesEnabled symbol.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Add a new matchAuthorAndUserStyles parameter. (WebCore::CSSStyleSelector::styleForElement): Check m_matchAuthorAndUserStyles before matching user and author rules. (WebCore::CSSStyleSelector::pseudoStyleForElement): Ditto. (WebCore::CSSStyleSelector::styleRulesForElement): Ditto.
- css/CSSStyleSelector.h: Add m_matchAuthorAndUserStyles and new constructor parameter.
- dom/Document.cpp: (WebCore::Document::Document): Pass Settings::authorAndUserStylesEnabled to the CSSStyleSelector. (WebCore::Document::recalcStyleSelector): Skip collecting the author stylesheets if Settings::authorAndUserStylesEnabled is false, and pass that to the CSSStyleSelector.
- page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_authorAndUserStylesEnabled to true. (WebCore::Settings::setAuthorAndUserStylesEnabled): Recalc style in all the frames when the setting changes.
- page/Settings.h: Add m_authorAndUserStylesEnabled. (WebCore::Settings::authorAndUserStylesEnabled): Return m_authorAndUserStylesEnabled.
WebKit/mac:
Reviewed by Dave Hyatt.
<rdar://problem/5569233> Add the ability to disable author and user CSS styles
- WebView/WebPreferenceKeysPrivate.h: Define WebKitRespectStandardStyleKeyEquivalentsPreferenceKey.
- WebView/WebPreferences.m: (+[WebPreferences initialize]): Default WebKitRespectStandardStyleKeyEquivalentsPreferenceKey to YES. (-[WebPreferences authorAndUserStylesEnabled]): Return the setting's BOOL value. (-[WebPreferences setAuthorAndUserStylesEnabled:]): Set the setting's BOOL value.
- WebView/WebPreferencesPrivate.h: Add authorAndUserStylesEnabled and setAuthorAndUserStylesEnabled:.
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings::authorAndUserStylesEnabled.
WebKitTools:
Reviewed by Dave Hyatt.
<rdar://problem/5569233> Add the ability to disable author and user CSS styles
Add support for disabling author and user styles for testing.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/LayoutTestController.cpp: (setAuthorAndUserStylesEnabledCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAuthorAndUserStylesEnabled):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAuthorAndUserStylesEnabled):
LayoutTests:
Reviewed by Dave Hyatt.
Test for: <rdar://problem/5569233> Add the ability to disable author and user CSS styles
- fast/css/disabled-author-styles.html: Added.
- platform/mac/fast/css/disabled-author-styles-expected.txt: Added.
- 7:06 AM QtWebKitGitInstructions edited by
- (diff)
- 1:48 AM HackingGtk edited by
- Link to OptimizingGtk (diff)
- 12:15 AM Changeset in webkit [28070] by
-
- 2 edits in trunk/WebCore
2007-11-27 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Based on changes by Mike Emmel.
CURL HTTP backend local file fixes:
Set a MIME type for local files based on the file extension.
Remove any HTTP query part sent to a local file.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startJob):