Context Navigation

PCRE crashes under GuardMalloc
http://bugs.webkit.org/show_bug.cgi?id=16127
check against patternEnd to make sure we don't walk off the end of the string

pcre/pcre_compile.cpp: (compile_branch): (calculateCompiledPatternLengthAndFlags):

3:25 PM Changeset in webkit [28259] by Nikolas Zimmermann

2 edits in trunk/WebCore

Not reviewed. Try to fix qt/gtk build.

3:19 PM Changeset in webkit [28258] by Nikolas Zimmermann

5 edits
27 moves in trunk/WebCore

Rubber stamped by Eric.

Final integration of ksvg2 in WebKit. Moving ksvg2/ to svg/ and killing all it's subdirectories,
by moving the files into approriate locations (css, rendering, ...) - as dicsussed on the
mailing list and on IRC with David/Darin & Eric.

Updated all build files - though I can't guarantee it builds on non-mac. Need buildbot to verify.

2:22 PM Changeset in webkit [28257] by kevino@webkit.org

4 edits in trunk

wx build fix. Add WebCore/platform/graphics/wx to includes.

2:08 PM Changeset in webkit [28256] by beidson@apple.com

7 edits in trunk/WebCore

Reviewed by Geoff

Further hookup of Database API
With this change, any database operation that writes to the database (UPDATE, INSERT, CREATE, etc) will
result in a didModifyDatabase notification when the transaction is successfully committed

storage/DatabaseAuthorizer.cpp: Global rename of "m_lastActionIncreasedSize" to "m_lastActionChangedDatabase" (WebCore::DatabaseAuthorizer::reset): (WebCore::DatabaseAuthorizer::createTable): (WebCore::DatabaseAuthorizer::allowAlterTable): (WebCore::DatabaseAuthorizer::createIndex): (WebCore::DatabaseAuthorizer::createTrigger): (WebCore::DatabaseAuthorizer::createVTable): (WebCore::DatabaseAuthorizer::allowInsert): (WebCore::DatabaseAuthorizer::allowUpdate):
storage/DatabaseAuthorizer.h: (WebCore::DatabaseAuthorizer::lastActionChangedDatabase):

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::notifyDatabaseChanged): Added. Allow external entities (SQLTransaction) to be able to request a didModifyDatabase notification to the delegate
storage/DatabaseTracker.h:

storage/SQLTransaction.cpp: Added m_modifiedDatabase flag which tracks if any statement over the course of a transaction resulted in a change to the database. (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::runCurrentStatement): Set m_modifiedDatabase to true if the authorizer reports a mutation statement occurred (WebCore::SQLTransaction::postflightAndCommit): If the transaction successfully commits, call DatabaseTracker::notifyDatabaseChanged (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): Ditto
storage/SQLTransaction.h:

2:04 PM Changeset in webkit [28255] by beidson@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Geoff

Add isEqual operator to WebSecurityOrigin

Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin isEqual:]):

1:55 PM Changeset in webkit [28254] by Adam Roben

2 edits in trunk/WebKitTools

Hopefully the final build fix

Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to pull in WTF's assertion/logging functions.

1:44 PM Changeset in webkit [28253] by Adam Roben

2 edits in trunk/WebKitTools

Another build fix

Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for WebKit.lib.

1:27 PM Changeset in webkit [28252] by Adam Roben

4 edits
1 copy in trunk/WebKitTools

Debug build fix

Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal configuration.
Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other projects.
Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from WebKitTools/DumpRenderTree/win/debug_internal.vsprops.

12:35 PM Changeset in webkit [28251] by Nikolas Zimmermann

6 edits
60 moves
6 adds in trunk/WebCore

Rubber stamped by David.

Next round of moves - platform reorganization.
Move text/font/glyph related files from the individual port directories
into platform/text/<port> or platform/graphics/<port>.

12:15 PM Changeset in webkit [28250] by kevino@webkit.org

4 edits in trunk

Other wx port fixes needed to restore the build bot.

12:11 PM Changeset in webkit [28249] by weinig@apple.com

2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Fix drawSelectionRect to actually draw the selection rect.

DumpRenderTree/cg/PixelDumpSupportCG.cpp: (drawSelectionRect):

11:33 AM Changeset in webkit [28248] by Simon Hausmann

2 edits in trunk/WebCore

Fix the build with DATABASE=0.

11:32 AM Changeset in webkit [28247] by Adam Roben

1 edit
2 adds in trunk/LayoutTests

Copy some cross-platform results into platform/win to avoid picking up the platform/mac versions

platform/win/fast/dom/Window/window-resize-expected.txt: Copied from LayoutTests/fast/dom/Window/window-resize-expected.txt.
platform/win/fast/dom/wrapper-classes-expected.txt: Copied from LayoutTests/fast/dom/wrapper-classes-expected.txt.

11:21 AM Changeset in webkit [28246] by Nikolas Zimmermann

2 edits
1 move in trunk/WebCore

Rubber stamped by Darin.

Fix misplaced file. The name "FontStyle" is not correct though - it probably
needs yet another move - but this time inside platform/graphics - as soon
as we agree on a better name.

11:04 AM Changeset in webkit [28245] by sullivan@apple.com

4 edits in trunk/WebKit/mac

Reviewed by Darin

Tweaks to newly-declared NSString * constants to make them usable from clients

Storage/WebDatabaseManagerPrivate.h:
Storage/WebDatabaseManager.mm: removed "const" from new NSNotification names and userInfo keys; these generate compiler warnings when used

WebKit.exp: export new NSNotification names and userInfo keys so clients can use them

11:02 AM QtWebKitTodo edited by Simon Hausmann

(diff)

10:56 AM Changeset in webkit [28244] by Adam Roben

2 edits in branches/Safari-3-branch/WebKitTools

Merge r26734

10:54 AM Changeset in webkit [28243] by Darin Adler

5 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Adam Roben.

fix http://bugs.webkit.org/show_bug.cgi?id=16207 JavaScript regular expressions should match UTF-16 code units rather than characters

SunSpider says this is 5.5% faster on the regexp test, 0.4% faste overall.

Test: fast/js/regexp-non-bmp.html

Renamed ANY_CHAR to NOT_NEWLINE to more-accurately reflect its meaning.

pcre/pcre_compile.cpp: (compile_branch): Removed calls to the UTF-16 character accessor functions, replacing them with simple pointer dereferences in some cases, and no code at all in others. (calculateCompiledPatternLengthAndFlags): Ditto.

pcre/pcre_exec.cpp: (match): Fixed indentation of some case labels (including all the BEGIN_OPCODE). Removed calls to the UTF-16 character accessor functions, replacing them with simple pointer dereferences in some cases, and no code at all in others. Also removed some explicit UTF-16 support code in a few cases. Removed the unneeded "UTF-8" code path in the ANY_CHAR repeat code, and in another case, eliminated the code to check against end_subject in because it is already done outside the loop. (jsRegExpExecute):

pcre/pcre_internal.h: Removed all the UTF-16 helper functions.

LayoutTests:

Reviewed by Adam Roben.

test for http://bugs.webkit.org/show_bug.cgi?id=16207 JavaScript regular expressions should match UTF-16 code units rather than characters

fast/js/regexp-non-bmp-expected.txt: Added.
fast/js/regexp-non-bmp.html: Added.
fast/js/resources/regexp-non-bmp.js: Added.

10:47 AM Changeset in webkit [28242] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.

10:44 AM Changeset in webkit [28241] by kevino@webkit.org

2 edits in trunk/WebKit/wx

Build fix after platform/text changes.

10:43 AM Changeset in webkit [28240] by Nikolas Zimmermann

8 edits in trunk/WebCore

Reviewed by Sam.

Rename "FontStyle FontStyle(...)" to "FontStyle fontStyle(...)".
I scripted a bit too much while doing the TextStyle -> FontStyle change.

10:38 AM Changeset in webkit [28239] by alp@webkit.org

2 edits in trunk/WebCore

2007-11-30 Alp Toker <alp@atoker.com>

GTK+ build fix following the recent text reorganization.

WebCore.pro:

10:30 AM QtWebKitContrib edited by Simon Hausmann

(diff)

10:08 AM Changeset in webkit [28238] by jhoneycutt@apple.com

2 edits in trunk/WebCore

2007-11-29 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Adam.

Part of <rdar://problem/5506522> Seed: cannot type into text box in
Facebook, don't see plugin content (Adobe Flash)

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent): Focus the plugin's parent frame

10:06 AM Changeset in webkit [28237] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: Get ready for some future renaming.

10:03 AM Changeset in webkit [28236] by kmccullough@apple.com

4 edits in trunk/WebKitTools

Reviewed by Adam.

Removed some unnecessary functions and changed an unused return type.

Drosera/win/DebuggerClient.cpp: (registerConsoleClass):
Drosera/win/DebuggerClient.h:
Drosera/win/Drosera.cpp: (registerDroseraClass):

9:54 AM Changeset in webkit [28235] by Nikolas Zimmermann

3 edits in trunk/WebCore

Not reviewed. Trying to fix gtk/qt/wx build. (I expected problems because of the moves)

9:41 AM Changeset in webkit [28234] by Nikolas Zimmermann

32 edits
67 moves
2 adds in trunk/WebCore

Rubber stamped by Brady.

Started platform reorganization (platform/text addition).
Moving string/text/font related classes into new places - as discussed on webkit-dev.

In a follow-up commit I'll move classes out of platform/{mac,win,...} into
platform/text/{mac,win,...}, and also do the ksvg2/ -> svg/ move.

9:02 AM Changeset in webkit [28233] by adele@apple.com

3 edits
2 adds in trunk

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=16072
<rdar://problem/5463821> REGRESSION: Mousemove event isn't fired when mouse moves over scrollbar with pressed button (16072)

Test: fast/events/mousemove-after-drag-over-scrollbar.html

page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): If the mouse is pressed, and we've moved over a new scrollbar, then we can clear m_lastScrollbarUnderMouse. We should only need to show the hover effect when the mouse isn't pressed.

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=16072
<rdar://problem/5463821> REGRESSION: Mousemove event isn't fired when mouse moves over scrollbar with pressed button

fast/events/mousemove-after-drag-over-scrollbar-expected.txt: Added.
fast/events/mousemove-after-drag-over-scrollbar.html: Added.

6:12 AM Changeset in webkit [28232] by ap@webkit.org

2 edits in trunk/LayoutTests

platform/win/Skipped: Added editing/selection/5241148.html, which crashes for me.

4:40 AM Changeset in webkit [28231] by alp@webkit.org

10 edits in trunk

2007-11-28 Alp Toker <alp@atoker.com>

Reviewed by Timothy Hatcher.

http://bugs.webkit.org/show_bug.cgi?id=16174
[GTK] Use "URI" not "URL" in public API

Replace use of the term "URL" with "URI" in public headers,
documentation and some internal code to match GLib/GTK+ convention.

This is now mentioned in the API guidelines:

http://trac.webkit.org/projects/webkit/wiki/HackingGtk

API/ABI-breaking change.

1:34 AM Changeset in webkit [28230] by zecke@webkit.org

6 edits in trunk/WebKit/qt

Self destruct the clients like the ohter ports do

Signed-off-by: Simon

12:49 AM Changeset in webkit [28229] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-30 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Fix layout test regressions caused by r28186
http://bugs.webkit.org/show_bug.cgi?id=16195
change first_byte and req_byte back to shorts instead of chars
(I think PCRE stuffs information in the high bits)

pcre/pcre_internal.h:

12:44 AM QtWebKit edited by Simon Hausmann

(diff)

Nov 29, 2007:

11:01 PM Changeset in webkit [28228] by beidson@apple.com

3 edits in trunk/WebCore

Reviewed by Tim

Part of <rdar://problem/5556377> - Need to accurately track and enforce database quota

SQLite has the ability to enforce the page usage for databases. This gives us bulletproof
enforcement of the database size limit with reasonable granularity (within 1023 bytes by
default on OS X with SQLite 3.4.0)

This also involved enhancing the ability to install/remove the authorizer to run the PRAGMA
statements involved

Note this patch does not actually use the new maximumSize() functionality of the
SQLiteDatabase class - that can be reviewed/landed seperately

platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::SQLiteDatabase): (WebCore::SQLiteDatabase::maximumSize): Return the current maximum size in bytes (WebCore::SQLiteDatabase::setMaximumSize): Based on m_pageSize, set the maximum page count to enforce the maximum size in bytes (WebCore::SQLiteDatabase::pageSize): Fetch m_pageSize if it hasn't been fetched, or return the cached value (WebCore::SQLiteDatabase::setAuthorizer): Use enableAuthorizer for the sqlite_* level authorizer setup (WebCore::SQLiteDatabase::enableAuthorizer): Install or remove the sqlite authorizer handler
platform/sql/SQLiteDatabase.h: Add the m_pageSize member so we only have to fetch it once

9:50 PM Changeset in webkit [28227] by zecke@webkit.org

4 edits in trunk

Fix fast/events/mousedown_in_scrollbar.html
This test used to crash in PlatformScrollbarQt::mouse*Event due parent() returning 0.
Extend the current check that the scrollbar in the mev can be go away. This happens if we destroy a RenderLayer as the result of a click. In the case of Qt we can have this scrollbar in m_lastScrollbarUnderMouse. The RenderLayer is the ScrollbarClient, m_lastScrollbarUnderMouse is a RefPtr and keeps the last reference. When calling into this scrollbar the m_client pointer is a dangling pointer. We extend the check to set m_lastScrollbarUnderMouse back to zero when it was the scrollbar in the old mev and is gone in the new one.
This happens only on the Qt port because we send more/different move events.

9:25 PM Changeset in webkit [28226] by Antti Koivisto

5 edits
5 adds in trunk

WebCore:

Reviewed by Mitz.

Fix aspect ratio calculation of video.

Video should always be treated as a replaced element in size calculation.

Test: media/video-aspect-ratio.html

rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcHeight):
rendering/RenderBox.h: (WebCore::RenderBox::shouldCalculateSizeAsReplaced):
rendering/RenderMedia.h: (WebCore::RenderMedia::shouldCalculateSizeAsReplaced):

LayoutTests:

Reviewed by Mitz.

Test for video aspect ratio calculation.

media/video-aspect-ratio.html: Added.
platform/mac/media: Added.
platform/mac/media/video-aspect-ratio-expected.checksum: Added.
platform/mac/media/video-aspect-ratio-expected.png: Added.
platform/mac/media/video-aspect-ratio-expected.txt: Added.

9:20 PM Changeset in webkit [28225] by weinig@apple.com

5 edits in trunk/WebCore

Reviewed by Oliver.

Additional fix for <rdar://problem/5592988> / http://bugs.webkit.org/show_bug.cgi?id=15936

More closely match IE's policy for frame navigation.

bindings/js/kjs_window.cpp: (KJS::WindowProtoFuncOpen::callAsFunction):
loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldAllowNavigation):
page/FrameTree.cpp: (WebCore::FrameTree::top):
page/FrameTree.h:

8:34 PM Changeset in webkit [28224] by mitz@apple.com

7 edits in trunk/WebCore

Reviewed by Adam Roben and John Sullivan.

make the recent searches popup extend only along the straight part of the search field (unless it needs to be wider).

platform/PopupMenuClient.h: Added clientInsetLeft() and clientInsetRight() for clients to specify desired horizontal insets for the menu.
platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize): (WebCore::PopupMenu::paint):
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::clientInsetLeft): Added. Returns 0. (WebCore::RenderMenuList::clientInsetRight): Ditto.
rendering/RenderMenuList.h:
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::clientInsetLeft): Added. Returns half the control's height, which is the radius of the cap on the left. (WebCore::RenderTextControl::clientInsetRight): Added.
rendering/RenderTextControl.h:

7:02 PM Changeset in webkit [28223] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Make the JS collector work with multiple threads

Reviewed by Maciej and Darin.

Under heavy contention it was possible the GC to suspend other
threads inside the pthread spinlock, which could lead to the GC
thread blocking on the pthread spinlock itself.

We now determine and store each thread's stack base when it is
registered, thus removing the need for any calls to pthread_get_stackaddr_np
that needed the pthread spinlock.

6:42 PM Changeset in webkit [28222] by andersca@apple.com

6 edits in trunk

WebKitTools:

Reviewed by Sam.

<rdar://problem/5230478>
FrameLoadDelegate callbacks are not dumped in DRT.

DumpRenderTree/win/DumpRenderTree.cpp: (shouldLogFrameLoadDelegates): (runTest): (main):
DumpRenderTree/win/FrameLoaderDelegate.cpp: (BSTRtoString): (descriptionSuitableForTestResult): (FrameLoadDelegate::QueryInterface): (FrameLoadDelegate::didStartProvisionalLoadForFrame): (FrameLoadDelegate::didFailProvisionalLoadWithError): (FrameLoadDelegate::didCommitLoadForFrame): (FrameLoadDelegate::didFinishLoadForFrame): (FrameLoadDelegate::willCloseFrame): (FrameLoadDelegate::didClearWindowObject): (FrameLoadDelegate::didFinishDocumentLoadForFrame): (FrameLoadDelegate::didHandleOnloadEventsForFrame):
DumpRenderTree/win/FrameLoaderDelegate.h: (FrameLoadDelegate::windowScriptObjectAvailable): (FrameLoadDelegate::didFirstLayoutInFrame):

LayoutTests:

Reviewed by Sam.

<rdar://problem/5230478>
FrameLoadDelegate callbacks are not dumped in DRT.

Remove now passing tests.

platform/win/Skipped:

6:38 PM Changeset in webkit [28221] by andersca@apple.com

3 edits in trunk/WebKit/win

Reviewed by Sam.

Add an IWebFrameLoadDelegate2 interface with a didClearWindowObject method
that passes in the frame whose window has been cleared. This matches a newly
added delegate method on the Mac.

Interfaces/IWebFrameLoadDelegate.idl:
WebFrame.cpp: (WebFrame::windowObjectCleared):

6:26 PM Changeset in webkit [28220] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Reviewed by Adam.

platform/win/Skipped: Removed two Mac-specific tests.

6:21 PM Changeset in webkit [28219] by alice.liu@apple.com

2 edits
1 copy
1 add in trunk/LayoutTests

Move incorrect, Mac-specific results of fast/dom/Window/window-resize.html into platform/mac and replace them with non-Mac results

The incorrect results are tracked by <rdar://5563578>.

Reviewed by Adam.

fast/dom/Window/window-resize-expected.txt: Replaced.
platform/mac/fast/dom/Window/window-resize-expected.txt: Copied from fast/dom/Window/window-resize-expected.txt.
platform/win/Skipped: Removed window-resize tests.

6:19 PM Changeset in webkit [28218] by weinig@apple.com

4 edits in trunk

WebKitTools:

Reviewed by Anders.

Add database quota UIDelegates methods to DRT UIDelegate.

DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]): (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):

LayoutTests:

Reviewed by Anders.

Revert r28213 which added an error callback that was not needed and changed
the results.

storage/transaction_callback_exception_crash.html:

6:07 PM Changeset in webkit [28217] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Reviewed by Adam.

platform/win/Skipped: Removed a passing test.

6:01 PM Changeset in webkit [28216] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Group failures related to dumpResourceLoadCallbacks being unimplemented

Reviewed by Adam.

platform/win/Skipped:

6:00 PM Changeset in webkit [28215] by alp@webkit.org

16 edits in trunk/WebCore

2007-11-30 Alp Toker <alp@atoker.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=16173
Licensing change

Change license from BSD to LGPL.

This is being done to encourage vendors to contribute their fixes back
upstream.

5:44 PM Changeset in webkit [28214] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Group failures related to using Cygwin paths

Reviewed by Adam.

platform/win/Skipped:

5:02 PM Changeset in webkit [28213] by beidson@apple.com

2 edits in trunk/LayoutTests

Not reviewed.

Fixed a hang in the layout tests.
My checkin earlier today broke things such that the transaction call errors out instead of succeeds.
Therefore LayoutTestController is never notified that the test is done.

This changes modifies the test such that the controller is notified of completion even if
there's a transaction error.

The net effect of this fix is to transform the hang to a single layout test failure, so people
and the bots don't have their run-webkit-tests hang while I try to fix the real regression.

storage/transaction_callback_exception_crash.html:

4:53 PM Changeset in webkit [28212] by Darin Adler

4 edits
2 adds in trunk

WebCore:

Reviewed by Adele.

fix http://bugs.webkit.org/show_bug.cgi?id=16191 REGRESSION: cannot tab to radio input after setting checked to false

Test: fast/forms/input-radio-checked-tab.html

html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::CheckedRadioButtons::addButton): Fix this code so that it doesn't call setChecked(false) until after the map has been updated. Otherwise, we can end up deallocating the map before manipulating it. As long as I was changing the function, I decided to make it do only a single hash table lookup.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): Remove the button from the radio buttons set before changing the checked state. This matches the idiom used elsewhere and fixes the problem where setting checked to false would not remove it from the set.

LayoutTests:

Reviewed by Adele.

test for http://bugs.webkit.org/show_bug.cgi?id=16191 REGRESSION: cannot tab to radio input after setting checked to false

fast/forms/input-radio-checked-tab-expected.txt: Added.
fast/forms/input-radio-checked-tab.html: Added.

4:50 PM Changeset in webkit [28211] by alice.liu@apple.com

1 edit
1 copy
1 add in trunk/LayoutTests

Move Mac-specific results of fast/dom/wrapper-classes.html into platform/mac and replace them with non-Mac results

Reviewed by Adam.

fast/dom/wrapper-classes-expected.txt: Replaced.
platform/mac/fast/dom/wrapper-classes-expected.txt: Copied from fast/dom/wrapper-classes-expected.txt.

4:43 PM Changeset in webkit [28210] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Group drag-n-drop related failures under one bug

We don't know the specific causes of these failures, but we believe
they're due to bugs in DRT's drag-n-drop implementation.

Reviewed by Adam.

platform/win/Skipped:

4:36 PM Changeset in webkit [28209] by kmccullough@apple.com

11 edits in trunk

WebKit/win:

Reviewed by Sam.

<rdar://5618976> Drosera: should listen for the WebScriptDebugServer dying and vice versa.

Interfaces/IWebScriptDebugListener.idl: Added the new function to the interface.
WebKit.vcproj/WebKit.def: Added the new function to the def file so Safari can tell WebKit when the server is dying.
WebKit.vcproj/WebKit_debug.def: Ditto.
WebKitDLL.cpp: Added the new function for Safari to call. (RunAsLocalServer): (LocalServerDidDie):
WebScriptDebugServer.cpp: (WebScriptDebugServer::WebScriptDebugServer): Removed unused member. (WebScriptDebugServer::sharedWebScriptDebugServer): Ditto, and added new member to prevent adding or removing listeners when the server is dying. (WebScriptDebugServer::addListener): Don't let new listeners be added when the server is dying. (WebScriptDebugServer::removeListener): Don't let listeners remove themselves when the server is dying. The server will remove them all anyways. (WebScriptDebugServer::serverDidDie): Notify all listeners that the server is dying and remove all listeners.
WebScriptDebugServer.h: Added the new method and removed an unused member.

WebKitTools:

Reviewed by Sam.

<rdar://5618976> Drosera: should listen for the WebScriptDebugServer dying and vice versa.
This fix will allow Drosera and Safari to reconnect if either of them closes correctly, but does not fix the case where one of them dies silently.

Drosera/win/ServerConnection.cpp: (ServerConnection::attemptToCreateServerConnection): Added a safety check, because it's possilbe to try to connect to a server that's dying. (ServerConnection::serverDidDie): Implemented. This resets Drosera when the server has died.
Drosera/win/ServerConnection.h: Added the new function and removed an unnecessary member.

4:29 PM Changeset in webkit [28208] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Reviewed by Adam.

platform/win/Skipped: Removed another passing test.

4:26 PM Changeset in webkit [28207] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Reviewed by Adam.

platform/win/Skipped: Recategorized one failing test and removed a passing test.

4:26 PM Changeset in webkit [28206] by justin.garcia@apple.com

2 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5620093> Brief hang when Safari caches page text of XML document

editing/TextIterator.cpp: (WebCore::TextIterator::representNodeOffsetZero): When we haven't been emitting any characters, shouldRepresentNodeOffsetZero() can create VisiblePositions, which is expensive. So, we perform the inexpensive checks on m_node to see if it necessitates emitting a character first and will early return before encountering shouldRepresentNodeOffsetZero()s worse case behavior.

4:23 PM Changeset in webkit [28205] by andersca@apple.com

2 edits in trunk/WebKitTools

DumpRenderTree/win/DumpRenderTree.vcproj: Add shlwapi.lib to all configurations.

3:30 PM Changeset in webkit [28204] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Removing <rdar://5507350> from skipped list because it's not failing.

platform/win/Skipped:

2:15 PM Changeset in webkit [28203] by andersca@apple.com

1 edit
4 moves in trunk/LayoutTests

Reviewed by Alexey.

Move Mac-specific tests to platform/mac.

fast/events/objc-event-api-expected.txt: Removed.
fast/events/objc-event-api.html: Removed.
fast/events/objc-keyboard-event-creation-expected.txt: Removed.
fast/events/objc-keyboard-event-creation.html: Removed.
platform/mac/fast/events/objc-event-api-expected.txt: Copied from fast/events/objc-event-api-expected.txt.
platform/mac/fast/events/objc-event-api.html: Copied from fast/events/objc-event-api.html.
platform/mac/fast/events/objc-keyboard-event-creation-expected.txt: Copied from fast/events/objc-keyboard-event-creation-expected.txt.
platform/mac/fast/events/objc-keyboard-event-creation.html: Copied from fast/events/objc-keyboard-event-creation.html.

2:10 PM Changeset in webkit [28202] by andersca@apple.com

3 edits in trunk/WebKit/mac

Reviewed by John.

Rename WebKitShrinksStandaloneImagesToFitKey to WebKitShrinksStandaloneImagesToFit.

This is safe to do because the preference is off by default and Safari 3, which is the only client that turns it on,
is using the setter and not messing around with NSUserDefaults.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences shrinksStandaloneImagesToFit]): (-[WebPreferences setShrinksStandaloneImagesToFit:]):

1:57 PM Changeset in webkit [28201] by Adam Roben

3 edits in trunk/JavaScriptCore

Windows build fix

Removed some unreachable code (ironically, the code was some
ASSERT_NOT_REACHED()s).

pcre/pcre_compile.cpp: (compile_branch):
pcre/pcre_exec.cpp: (match):

1:53 PM Changeset in webkit [28200] by andersca@apple.com

2 edits in trunk/WebCore

Reviewed by Sam.

Don't install event handlers or set the zoom cursor if auto-shrink has been disabled.

loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure): (WebCore::ImageDocument::imageChanged):

1:51 PM Changeset in webkit [28199] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Removing some fixed tests

platform/win/Skipped:

1:49 PM Changeset in webkit [28198] by beidson@apple.com

2 edits in trunk/WebKit/win

Build fix that works...?

WebChromeClient.h:

1:26 PM Changeset in webkit [28197] by kmccullough@apple.com

2 edits in trunk/WebKitTools

Build fix. Added additional includes for VS Express to the Release project.

Drosera/win/Drosera.vcproj/Drosera.vcproj:

1:13 PM Changeset in webkit [28196] by beidson@apple.com

2 edits in trunk/WebKit/gtk

Better build fix for Gtk

WebCoreSupport/ChromeClientGtk.h:

1:09 PM Changeset in webkit [28195] by beidson@apple.com

2 edits in trunk/WebKit/win

Build fix

WebChromeClient.cpp: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):

11:53 AM Changeset in webkit [28194] by andersca@apple.com

5 edits in trunk

WebKitTools:

Reviewed by Adam.

<rdar://problem/5132005>
setUserStyleSheetEnabled is not fully implemented in Windows DRT.

DumpRenderTree/win/DumpRenderTree.vcproj: Add shlwapi.lib

DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setUserStyleSheetEnabled): Implement this.

(appendComponentToPath):
New method which wraps the Win32 API PathAppend.

(followShortcuts):
New method which checks if a file points to a shortcut and
follows the shortcut.

(resolveCygwinPath):
New method that takes a cygwin unix-style path and returns the Win32 path.

(cfStringRefToWString):

(LayoutTestController::setUserStyleSheetLocation):
Implement this.

LayoutTests:

Reviewed by Adam.

<rdar://problem/5132005>
setUserStyleSheetEnabled is not fully implemented in Windows DRT.

platform/win/Skipped:

11:38 AM Changeset in webkit [28193] by Beth Dakin

2 edits in trunk/WebCore

Reviewed by Geoff.

Fix for <rdar://problem/5620151> Disable JavaScript for SVG as
image for <img> and CSS images

platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::dataChanged): When we create the empty clients, explicitly disable JavaScript in the settings.

11:29 AM Changeset in webkit [28192] by beidson@apple.com

31 edits in trunk

WebCore:

Reviewed by Anders

Support for <rdar://problem/5556381> and <rdar://problem/5556379>

The Database feature in the engine needs to support delegate calls for policy decisions and
also provide notifications when origins and databases change their state.

This patch also polishes off the missing features of the management API

page/Chrome.cpp: Implement the two UIDelegate methods (WebCore::Chrome::requestQuotaIncreaseForNewDatabase): Ask for more space to create a new database if it won't fit (WebCore::Chrome::requestQuotaIncreaseForDatabaseOperation): Ask for more space to complete an in-progress operation
page/Chrome.h:
page/ChromeClient.h:
platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::requestQuotaIncreaseForNewDatabase): (WebCore::SVGEmptyChromeClient::requestQuotaIncreaseForDatabaseOperation):

storage/Database.cpp: (WebCore::Database::openDatabase): Check to see if this database can be opened - the quota must be high enough and if it isn't, the UIDelegate should have a change to bump the quota. Also update the UI-relevant details (display name and estimated size) upon successful opening of the database

storage/DatabaseDetails.h: Remove the version parameter as it is a programatic detail of a site database and is not important to API clients (WebCore::DatabaseDetails::DatabaseDetails): (WebCore::DatabaseDetails::isValid): (WebCore::DatabaseDetails::name):

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::openTrackerDatabase): Tweaked the schema here - there was a horrible bug with the old schema that would prevent you from having two databases of the same name from two different origins. Also simplify the origin-management schema (WebCore::DatabaseTracker::canEstablishDatabase): Added. Does some estimated size vs quota checks, and asks the UI delegate for more space if necessary (WebCore::DatabaseTracker::hasEntryForOrigin): (WebCore::DatabaseTracker::establishEntryForOrigin): Establishes a tracker entry for the given origin with the current default quota Also notifies the client of the new origin (WebCore::DatabaseTracker::setDatabaseDetails): Update the display name and estimated size for the given database (WebCore::DatabaseTracker::fullPathForDatabase): Tweak to add the ability to get the path without creating it - for management purposes (WebCore::DatabaseTracker::populateOrigins): Populate origins from the Origins table instead of the Databases table (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::detailsForNameAndOrigin): For API management (WebCore::DatabaseTracker::usageForDatabase): (WebCore::DatabaseTracker::usageForOrigin): (WebCore::DatabaseTracker::quotaForOrigin): (WebCore::DatabaseTracker::setQuota): Notify the client (WebCore::DatabaseTracker::addDatabase): Notify the client (WebCore::DatabaseTracker::deleteAllDatabases): (WebCore::DatabaseTracker::deleteDatabasesWithOrigin): (WebCore::DatabaseTracker::deleteDatabase): (WebCore::DatabaseTracker::deleteDatabaseFile):
storage/DatabaseTracker.h:

WebKit/gtk:

Keep it building with new client method

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::requestQuotaIncreaseForNewDatabase): (WebKit::ChromeClient::requestQuotaIncreaseForDatabaseOperation):
WebCoreSupport/ChromeClientGtk.h:

WebKit/mac:

Reviewed by Anders

Support for <rdar://problem/5556381> and <rdar://problem/5556379>

Hook up UI Delegate calls for the database engine feature and other small tweaks

Storage/WebDatabaseManager.mm: (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Renamed databaseName parameter to databaseIdentifier for clarity (-[WebDatabaseManager deleteDatabase:withOrigin:]): Renamed databaseName parameter to databaseIdentifier for clarity
Storage/WebDatabaseManagerPrivate.h:

Storage/WebDatabaseTrackerClient.h:
Storage/WebDatabaseTrackerClient.mm: (WebDatabaseTrackerClient::dispatchDidModifyDatabase): Renamed databaseName parameter to databaseIdentifier for clarity

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestQuotaIncreaseForNewDatabase): Call through to the UI Delegate (WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Ditto

WebView/WebUIDelegatePrivate.h: Added the two UI Delegate methods

WebView/WebView.mm: (CallDelegateReturningUnsignedLongLong): (CallUIDelegateReturningUnsignedLongLong):
WebView/WebViewInternal.h:

WebKit/qt:

Keep it building with new client method

WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::requestQuotaIncreaseForNewDatabase): (WebCore::ChromeClientQt::requestQuotaIncreaseForDatabaseOperation):
WebCoreSupport/ChromeClientQt.h:

WebKit/win:

Keep it building with new client method

WebChromeClient.cpp: (ChromeClient::requestQuotaIncreaseForNewDatabase): (ChromeClient::requestQuotaIncreaseForDatabaseOperation):
WebChromeClient.h:

WebKit/wx:

Keep it building with new client method

WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClient::requestQuotaIncreaseForNewDatabase): (WebCore::ChromeClient::requestQuotaIncreaseForDatabaseOperation):
WebKitSupport/ChromeClientWx.h:

11:21 AM Changeset in webkit [28191] by alice.liu@apple.com

2 edits in trunk/WebKitTools

Reviewed by Adam.

Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase

DumpRenderTree/win/EventSender.cpp: (keyDownCallback): uppercase letters were being sent as lowercase letters without the shift key down.

10:56 AM Drosera edited by kmccullough@apple.com

Added new information about the design of Drosera, specifically to add … (diff)

10:48 AM Changeset in webkit [28190] by mitz@apple.com

1 edit in trunk/WebKit/win/WebView.cpp

Fix typo

10:46 AM Changeset in webkit [28189] by kmccullough@apple.com

2 edits in trunk/WebKitTools

Windows build fix. VS express needs some love.

Drosera/win/Drosera.vcproj/Drosera.vcproj:

10:45 AM Changeset in webkit [28188] by mitz@apple.com

3 edits
1 add in trunk

WebCore:

Reviewed by Beth Dakin and Darin Adler.

manual test for <rdar://problem/5346394> Contextmenu event doesn't fire on body element inside frame

manual-tests/context-click-unfocused-frame.html: Added.

WebKit/win:

Reviewed by Beth Dakin and Darin Adler.

fix <rdar://problem/5346394> Contextmenu event doesn't fire on body element inside frame

WebView.cpp: (WebView::handleContextMenuEvent): Send the context menu event to the frame containing the node that was hit.

10:36 AM Changeset in webkit [28187] by kmccullough@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Sam.

Added recursive runloop guards.

DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer suspendProcessIfPaused]):

6:48 AM BuildingGtk edited by hendry@iki.fi

let people know about ccache (diff)

6:38 AM UsingGitWithWebKit edited by hendry@iki.fi

initial setup (diff)

4:49 AM Changeset in webkit [28186] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-29 Eric Seidel <eric@webkit.org>

Reviewed by Mark Rowe.

Fix for --guard crash of fast/js/regexp-charclass-crash introduced by r28151.

pcre/pcre_compile.cpp: (is_anchored):

3:57 AM Changeset in webkit [28185] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Gtk build fix.

3:44 AM Changeset in webkit [28184] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-29 Eric Seidel <eric@webkit.org>

Reviewed by Mark Rowe.

Attempt to fix non-mac builds after PCRE cleanup.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCoreSources.bkl:
pcre/pcre.pri:

3:39 AM Changeset in webkit [28183] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Give consistent naming to the RegExp options/compile flags

pcre/pcre_compile.cpp: (compile_branch): (is_anchored): (find_firstassertedchar): (printCompiledRegExp): (jsRegExpCompile):
pcre/pcre_exec.cpp: (jsRegExpExecute):
pcre/pcre_internal.h:

3:38 AM Changeset in webkit [28182] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Give consistent naming to the RegExp options/compile flags

pcre/pcre_compile.cpp: (compile_branch): (is_anchored): (find_firstassertedchar): (printCompiledRegExp): (jsRegExpCompile):
pcre/pcre_exec.cpp: (jsRegExpExecute):
pcre/pcre_internal.h:

3:37 AM Changeset in webkit [28181] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Pull first_byte and req_byte optimizations out into separate static funtions, SunSpider reported this as a win.

pcre/pcre_exec.cpp: (tryFirstByteOptimization): (tryRequiredByteOptimization): (jsRegExpExecute):
pcre/pcre_internal.h:

3:37 AM Changeset in webkit [28180] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

give PCRE_MULTILINE a better name: OptionMatchAcrossMultipleLines

pcre/pcre_compile.cpp: (compile_branch): (is_anchored): (printCompiledRegExp): (jsRegExpCompile):
pcre/pcre_exec.cpp: (jsRegExpExecute):
pcre/pcre_internal.h:

3:35 AM Changeset in webkit [28179] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Oliver.

Deprecate jsRegExpExecute's offset-vector fallback code

pcre/pcre_exec.cpp: (jsRegExpExecute):

3:34 AM Changeset in webkit [28178] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2007-11-28 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Centralize code for subjectPtr adjustments using inlines, only ever check for a single trailing surrogate (as UTF16

only allows one), possibly fix PCRE bugs involving char classes and garbled UTF16 strings.

pcre/pcre_exec.cpp: (match): (jsRegExpExecute):
pcre/pcre_internal.h: (getPreviousChar): (movePtrToPreviousChar): (movePtrToNextChar): (movePtrToStartOfCurrentChar):

3:33 AM Changeset in webkit [28177] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Make cur_is_word and prev_is_word locals, and change OP_ANY to OP_ANY_CHAR for clarity

pcre/pcre_compile.cpp: (find_fixedlength): (compile_branch): (canApplyFirstCharOptimization):
pcre/pcre_exec.cpp: (match):
pcre/pcre_internal.h:

3:32 AM Changeset in webkit [28176] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Mitz & Maciej.

Change _NC operators to use _IGNORING_CASE for clarity

pcre/pcre_compile.cpp: (find_fixedlength): (compile_branch): (find_firstassertedchar):
pcre/pcre_exec.cpp: (match):
pcre/pcre_internal.h:

3:32 AM Changeset in webkit [28175] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Mitz.

Remove branch from return

pcre/pcre_compile.cpp: (compile_branch):
pcre/pcre_exec.cpp: (match):

3:31 AM Changeset in webkit [28174] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Add repeatInformationFromInstructionOffset inline

pcre/pcre_exec.cpp: (repeatInformationFromInstructionOffset): (match):

3:30 AM Changeset in webkit [28173] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Remove no longer used error code JSRegExpErrorMatchLimit

kjs/regexp.cpp: (KJS::RegExp::match):
pcre/pcre.h:
pcre/pcre_internal.h:

3:30 AM Changeset in webkit [28172] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-28 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

change getChar* functions to return result and push 'c' into local scopes for clarity

pcre/pcre_compile.cpp: (compile_branch): (calculateCompiledPatternLengthAndFlags):
pcre/pcre_exec.cpp: (match):
pcre/pcre_internal.h: (getChar): (getCharAndAdvance): (getCharAndLength): (getCharAndAdvanceIfSurrogate):

3:29 AM Changeset in webkit [28171] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Make i locally scoped for better code clarity

pcre/pcre_exec.cpp: (match):

3:29 AM Changeset in webkit [28170] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-28 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Comment cleanup

pcre/pcre_exec.cpp: (match):

3:28 AM Changeset in webkit [28169] by eric@webkit.org

5 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Give subjectPtr and instructionPtr sane names, reduce size of MatchFrame for a 0.2% speedup.

pcre/pcre_compile.cpp: (compile_branch): (calculateCompiledPatternLengthAndFlags):
pcre/pcre_exec.cpp: (match_ref): (MatchStack::pushNewFrame): (getUTF8CharAndIncrementLength): (match):
pcre/pcre_internal.h: (getChar): (getCharAndAdvance): (getCharAndLength): (getCharAndAdvanceIfSurrogate):
pcre/pcre_xclass.cpp: (getUTF8CharAndAdvancePointer):

3:27 AM Changeset in webkit [28168] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-26 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Small speedup (0.7%) by simplifying canUseStackBufferForNextFrame() check

pcre/pcre_exec.cpp: (MatchStack::MatchStack): (MatchStack::popCurrentFrame):

3:27 AM Changeset in webkit [28167] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-25 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Lower MATCH_LIMIT_RECURSION to more sane levels to prevent hangs on run-javascriptcore-tests

pcre/pcre_internal.h:

3:26 AM Changeset in webkit [28166] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2007-11-25 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Remove match_is_group variable for another 5% speedup

pcre/pcre_compile.cpp:
pcre/pcre_exec.cpp: (startNewGroup): (match):

3:25 AM Changeset in webkit [28165] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Remove redundant eptrblock struct

pcre/pcre_exec.cpp: (MatchStack::pushNewFrame): (match):

3:25 AM Changeset in webkit [28164] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Remove redundant match_call_count and move recursion check out of super-hot code path
SunSpider says this is at least an 8% speedup for regexp.

pcre/pcre_exec.cpp: (MatchStack::MatchStack): (MatchStack::pushNewFrame): (MatchStack::popCurrentFrame): (MatchStack::popAllFrames): (match): (jsRegExpExecute):
pcre/pcre_internal.h:

3:24 AM Changeset in webkit [28163] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Get rid of GETCHAR* macros, replacing them with better named inlines

pcre/pcre_compile.cpp: (compile_branch): (calculateCompiledPatternLengthAndFlags):
pcre/pcre_exec.cpp: (match):
pcre/pcre_internal.h: (getCharAndAdvance): (getCharAndLength): (getCharAndAdvanceIfSurrogate):

3:24 AM Changeset in webkit [28162] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Further cleanup GET/PUT inlines

pcre/pcre_internal.h: (putOpcodeValueAtOffset): (getOpcodeValueAtOffset): (putOpcodeValueAtOffsetAndAdvance): (put2ByteOpcodeValueAtOffset): (get2ByteOpcodeValueAtOffset): (put2ByteOpcodeValueAtOffsetAndAdvance):

3:23 AM Changeset in webkit [28161] by eric@webkit.org

5 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Give GET, PUT better names, and add (poor) moveOpcodePtrPastAnyAlternateBranches

pcre/pcre_compile.cpp: (firstSignificantOpCodeSkippingAssertions): (find_fixedlength): (complete_callout): (compile_branch): (compile_regex): (is_anchored): (canApplyFirstCharOptimization): (find_firstassertedchar):
pcre/pcre_exec.cpp: (match):
pcre/pcre_internal.h: (putOpcodeValueAtOffset): (getOpcodeValueAtOffset): (putOpcodeValueAtOffsetAndAdvance): (put2ByteOpcodeValueAtOffset): (get2ByteOpcodeValueAtOffset): (moveOpcodePtrPastAnyAlternateBranches):
pcre/pcre_ucp_searchfuncs.cpp: (_pcre_ucp_othercase):

3:22 AM Changeset in webkit [28160] by eric@webkit.org

5 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Add inlines for toLowerCase, isWordChar, isSpaceChar for further regexp speedup

pcre/pcre_compile.cpp: (compile_branch): (jsRegExpCompile):
pcre/pcre_exec.cpp: (match): (jsRegExpExecute):
pcre/pcre_internal.h: (toLowerCase): (flipCase): (classBitmapForChar): (charTypeForChar): (isWordChar): (isSpaceChar): (CompileData::CompileData):
pcre/pcre_xclass.cpp: (_pcre_xclass):

3:21 AM Changeset in webkit [28159] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

cleanup _pcre_ucp_othercase

pcre/pcre_ucp_searchfuncs.cpp: (_pcre_ucp_othercase):

3:21 AM Changeset in webkit [28158] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-28 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Abstract frame variables into locals and args

pcre/pcre_compile.cpp: (compile_branch):
pcre/pcre_exec.cpp: (match):
pcre/pcre_internal.h:

3:20 AM Changeset in webkit [28157] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-28 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Section off MatchData arguments into args struct

pcre/pcre_exec.cpp: (MatchStack::pushNewFrame): (match):

3:19 AM Changeset in webkit [28156] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

split first_significant_code into two simpler functions

pcre/pcre_compile.cpp: (firstSignificantOpCode): (firstSignificantOpCodeSkippingAssertions): (is_anchored): (canApplyFirstCharOptimization): (find_firstassertedchar):

3:18 AM Changeset in webkit [28155] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

split first_significant_code into two simpler functions

pcre/pcre_compile.cpp: (firstSignificantOpCode): (firstSignificantOpCodeSkippingAssertions): (is_anchored): (canApplyFirstCharOptimization): (find_firstassertedchar):

3:18 AM Changeset in webkit [28154] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

clean up is_counted_repeat

pcre/pcre_compile.cpp: (is_counted_repeat):

3:17 AM Changeset in webkit [28153] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

clean up check_escape

pcre/pcre_compile.cpp: (check_escape):

3:16 AM Changeset in webkit [28152] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Reformat find_fixedlength

pcre/pcre_compile.cpp: (find_fixedlength):

3:16 AM Changeset in webkit [28151] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

reformat is_anchored

pcre/pcre_compile.cpp: (is_anchored):

3:15 AM Changeset in webkit [28150] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Remove unused function could_be_empty_branch

pcre/pcre_compile.cpp: (first_significant_code): (find_fixedlength): (compile_branch): (canApplyFirstCharOptimization):

3:14 AM Changeset in webkit [28149] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Pass around MatchData objects by reference

pcre/pcre_exec.cpp: (pchars): (match_ref): (match): (jsRegExpExecute):

3:13 AM Changeset in webkit [28148] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

give PCRE_STARTLINE a better name and rename match_data to MatchData

pcre/pcre_compile.cpp: (compile_branch): (canApplyFirstCharOptimization): (find_firstassertedchar): (printCompiledRegExp): (jsRegExpCompile):
pcre/pcre_exec.cpp: (pchars): (jsRegExpExecute):
pcre/pcre_internal.h:

3:12 AM Changeset in webkit [28147] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Clean up find_firstassertedchar

pcre/pcre_compile.cpp: (get_othercase_range): (find_firstassertedchar): (calculateCompiledPatternLengthAndFlags):

3:11 AM Changeset in webkit [28146] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Tim Hatcher.

Pass around CompileData& instead of CompileData*

pcre/pcre_compile.cpp: (compile_branch): (jsRegExpCompile):

3:10 AM Changeset in webkit [28145] by eric@webkit.org

4 edits
1 delete in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Clean up compile_branch, move _pcre_ord2utf8, and rename CompileData

JavaScriptCore.xcodeproj/project.pbxproj:
pcre/pcre_compile.cpp: (_pcre_ord2utf8): (calculateCompiledPatternLengthAndFlags): (jsRegExpCompile):
pcre/pcre_internal.h:
pcre/pcre_ord2utf8.cpp: Removed.

3:09 AM Changeset in webkit [28144] by eric@webkit.org

5 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

removing more macros

pcre/pcre_compile.cpp: (could_be_empty_branch): (compile_branch): (calculateCompiledPatternLengthAndFlags):
pcre/pcre_exec.cpp: (match): (jsRegExpExecute):
pcre/pcre_internal.h:
pcre/pcre_xclass.cpp:

3:08 AM Changeset in webkit [28143] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

clean up formating in compile_branch

pcre/pcre_compile.cpp: (compile_branch):

3:07 AM Changeset in webkit [28142] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Fix spacing for read_repeat_counts

pcre/pcre_compile.cpp: (read_repeat_counts):

3:06 AM Changeset in webkit [28141] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Get rid of PCRE custom char types

pcre/pcre_compile.cpp: (check_escape): (complete_callout): (compile_branch): (compile_regex): (calculateCompiledPatternLengthAndFlags): (jsRegExpCompile):
pcre/pcre_exec.cpp: (match_ref): (match): (jsRegExpExecute):
pcre/pcre_internal.h:

3:06 AM Changeset in webkit [28140] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

reformat get_othercase_range

pcre/pcre_compile.cpp: (get_othercase_range):

3:05 AM Changeset in webkit [28139] by eric@webkit.org

6 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Remove register keyword and more cleanup

pcre/pcre_compile.cpp: (find_fixedlength): (compile_branch): (is_anchored): (is_startline): (find_firstassertedchar): (calculateCompiledPatternLengthAndFlags): (jsRegExpCompile):
pcre/pcre_exec.cpp: (MatchStack::canUseStackBufferForNextFrame): (MatchStack::allocateNextFrame): (MatchStack::pushNewFrame): (MatchStack::frameIsStackAllocated): (MatchStack::popCurrentFrame): (MatchStack::unrollAnyHeapAllocatedFrames): (getUTF8CharAndIncrementLength): (match): (jsRegExpExecute):
pcre/pcre_internal.h: (PUT2INC): (isLeadingSurrogate): (isTrailingSurrogate): (decodeSurrogatePair): (getChar):
pcre/pcre_ord2utf8.cpp: (_pcre_ord2utf8):
pcre/pcre_xclass.cpp: (getUTF8CharAndAdvancePointer): (_pcre_xclass):

3:04 AM Changeset in webkit [28138] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2007-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.

Clean up jsRegExpExecute

pcre/pcre_compile.cpp: (returnError): (jsRegExpCompile):
pcre/pcre_exec.cpp: (jsRegExpExecute):
pcre/pcre_internal.h:

2:16 AM Changeset in webkit [28137] by mrowe@apple.com

2 edits in trunk/JavaScriptGlue

Fix REGRESSION(r27885): Installer hits assertion failure in JavaScriptGlue.

Reviewed by Maciej.

JSValueWrapper.cpp:

(getThreadGlobalExecState): Set the global object on the Interpreter before using it.

1:05 AM Changeset in webkit [28136] by mrowe@apple.com

2 edits in trunk/WebKit/mac

Fix an assertion failure seen on the layout tests, and when closing the window after visiting <http://www.coudal.com/losalamos/>.

Reviewed by Oliver Hunt.

Plugins/WebBaseNetscapePluginStream.mm:

(-[WebBaseNetscapePluginStream _destroyStream]): Unlink the file and close the file
descriptor even when the stream is being destroyed without the load completing. This
avoids leaking the path and file descriptor, and leaving the temporary file on disk.

12:46 AM Changeset in webkit [28135] by oliver@apple.com

5 edits in trunk/JavaScriptCore

Merging updated system alloc and spinlock code from r38 of TCMalloc.

Reviewed by Geoff

This is needed as a precursor to the merge of TCMalloc proper.

12:44 AM template.svg attached to IconContestIdeas by Adam Roben

Preliminary entry template

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed