⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 5, 2007:

11:40 PM Changeset in webkit [28483] by rwlbuis@webkit.org
  • 10 edits
    4 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=15289
WebKit does not respect clip paths of a 0x0 rect

Make empty clip paths clip the whole referencing graphic.

10:25 PM Changeset in webkit [28482] by Darin Adler
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

I don't know how to reproduce this in a test.

  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark): Call JSEventTargetNode::mark instead of DOMObject::mark. There's no difference right now, but it's best to call your base class, not your base's base.
  • bindings/js/kjs_events.h: Removed unneeded virtual from the JSUnprotectedEventListener::mark() function; it neither derives from or is derived from anyone else with a mark() function so there's no need for virtual.
  • bindings/js/kjs_window.cpp: (KJS::Window::mark): Call JSGlobalObject::mark, not JSObject::mark. This is the actual bug fix.
9:42 PM Changeset in webkit [28481] by alp@webkit.org
  • 3 edits in trunk/WebCore

2007-12-05 Pierre-Luc Beaudoin <​pierre-luc.beaudoin@collabora.co.uk>

​http://bugs.webkit.org/show_bug.cgi?id=16145
[gtk] Implement media support in GTK backend

Reviewed by Alp Toker.

Remove old comments, fix variable names, match WebKit coding style.

  • platform/graphics/gtk/MoviePrivateGStreamer.cpp: (WebCore::moviePrivateEOSCallback): (WebCore::MoviePrivate::MoviePrivate): (WebCore::MoviePrivate::load): (WebCore::MoviePrivate::play): (WebCore::MoviePrivate::pause): (WebCore::MoviePrivate::currentTime): (WebCore::MoviePrivate::seek): (WebCore::MoviePrivate::cancelSeek): (WebCore::MoviePrivate::seeking): (WebCore::MoviePrivate::naturalSize): (WebCore::MoviePrivate::setVolume): (WebCore::MoviePrivate::setMuted): (WebCore::MoviePrivate::maxTimeBuffered): (WebCore::MoviePrivate::bytesLoaded): (WebCore::MoviePrivate::totalBytesKnown): (WebCore::MoviePrivate::totalBytes): (WebCore::MoviePrivate::updateStates): (WebCore::MoviePrivate::didEnd): (WebCore::MoviePrivate::paint): (WebCore::MoviePrivate::createGSTPlayBin):
  • platform/graphics/gtk/MoviePrivateGStreamer.h:
9:37 PM Changeset in webkit [28480] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Speculative wx build fix. Add PlugInInfoStore::pluginNameForMIMEType to the temporary link stubs.

9:25 PM Changeset in webkit [28479] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Qt Windows build fix. Include the time-related headers in the correct place.

9:22 PM Changeset in webkit [28478] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Not reviewed; just undoing a previous commit.

The real bug was the backwards ?: in the compile function, which Geoff just
fixed. Rolling out the incorrect earlier fix.

  • pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags): Take out the unneeded preflight change. The regression test proves this is still working fine, so the bug remains fixed.
9:13 PM Changeset in webkit [28477] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-05 Alp Toker <​alp@atoker.com>

Rubber stamped by Mark Rowe.

Remove DEPENDPATH on the generated sources directory. This causes
trouble and is no longer necessary following the glib-genmarshal
generator split.

  • WebCore.pro:
8:14 PM Changeset in webkit [28476] by mrowe@apple.com
  • 7 edits in trunk/JavaScriptCore

Build fix. Include headers before trying to use the things that they declare.

7:11 PM Changeset in webkit [28475] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix: added some #includes.

  • kjs/JSImmediate.cpp:
7:07 PM Changeset in webkit [28474] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Build fix: added some #includes.

  • kjs/JSGlobalObject.cpp:
  • kjs/JSImmediate.cpp:
7:02 PM Changeset in webkit [28473] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix: Fixed #include spelling.

  • kjs/debugger.cpp:
6:57 PM Changeset in webkit [28472] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix: added #include.

  • kjs/debugger.cpp:
6:51 PM Changeset in webkit [28471] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix: added a forward declaration.

  • kjs/debugger.h:
6:47 PM Changeset in webkit [28470] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix: added an #include.

  • kjs/error_object.cpp:
6:41 PM Changeset in webkit [28469] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix: added an #include.

  • kjs/bool_object.cpp:
6:31 PM Changeset in webkit [28468] by ggaren@apple.com
  • 109 edits
    5 adds in trunk

JavaScriptCore:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and
functions accessing data members from Interpreter to JSGlobalObject.
Changed Interpreter member functions to static functions.


This resolves a bug in global object bootstrapping, where the global
ExecState could be used when uninitialized.


This is a big change, but it's mostly code motion and renaming.


Layout and JS tests, and testjsglue and testapi, pass. SunSpider reports
a .7% regression, but Shark sees no difference related to this patch,
and SunSpider reported a .7% speedup from an earlier step in this
refactoring, so I think it's fair to call that a wash.

JavaScriptGlue:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject. Replaced JSInterpreter
subclass with JSGlobalObject subclass.


  • JSRun.cpp: (JSRun::JSRun): (JSRun::Evaluate): (JSRun::CheckSyntax):
  • JSRun.h: (JSGlueGlobalObject::JSGlueGlobalObject):
  • JSUtils.cpp: (KJSValueToCFTypeInternal):
  • JSValueWrapper.cpp: (getThreadGlobalExecState):

WebCore:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject. Changed Interpreter
member functions to static functions. Same for the subclass,
ScriptInterpreter.


This is a big change, but it's mostly code motion and renaming.

WebKit/mac:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject.


  • WebView/WebFrame.mm: (-[WebFrame _attachScriptDebugger]):

WebKit/win:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject.


  • WebFrame.cpp: (WebFrame::globalContext): (WebFrame::attachScriptDebugger): (WebFrame::windowObjectCleared):
  • WebScriptDebugger.cpp: (WebScriptDebugger::WebScriptDebugger):
5:37 PM Changeset in webkit [28467] by alice.liu@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Antti.

Addressed <rdar://problem/5137284> fast/events/mouseout-dead-node.html fails on boomer

  • fast/events/mouseout-dead-node.html: Changed the questionable calls to mouseUp() to mouseMoveTo() to better simulate mouseovers
  • platform/win/Skipped: removed this test from skipped file
5:36 PM Changeset in webkit [28466] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/5625327> Crash toggling check grammar w/ spelling when no spell checker exists.


Reviewed by Adam.

  • WebView.cpp: (WebView::setGrammarCheckingEnabled): Add null check
4:56 PM Changeset in webkit [28465] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Add a crashing test.
4:33 PM Changeset in webkit [28464] by Darin Adler
  • 2 edits in trunk/WebCore

"Reviewed" by Geoff.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Removed assertion. (WebCore::FrameLoader::dispatchDidCommitLoad): This one too. The assertions are firing like crazy. Not sure why yet.
4:03 PM Changeset in webkit [28463] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler. (Or vice versa.)


Fixed ASSERT during run-javascriptcore-tests. (Darin just added the
ASSERT, but the bug wasn't new.)

  • pcre/pcre_compile.cpp: (compile_branch): The ?: operator here was backwards, causing us to execute the loop too many times, adding stray KET opcodes to the compiled regular expression.
3:56 PM BuildBot edited by Adam Roben
Add a note about the just-in-time debugger registry key on Windows (diff)
3:34 PM Changeset in webkit [28462] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Make the entry points extern "C".

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2:58 PM Changeset in webkit [28461] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::dispatchDidCommitLoad): Check m_creatingInitialEmptyDocument and don't deliver the client call in that case.
2:57 PM Changeset in webkit [28460] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

C++ warning fixes.


  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_Destroy): (NPP_SetWindow): (NPP_NewStream): (NPP_HandleEvent): (NPP_URLNotify): (NPP_GetValue):
2:54 PM Changeset in webkit [28459] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Add the .cpp files to the TestNetscapePlugIn target.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2:48 PM Changeset in webkit [28458] by kmccullough@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • Wait until local variable data is fully constructed before notifying the debugger of entering or leaving a call frame.
  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction):
  • kjs/nodes.cpp: (KJS::FunctionBodyNode::execute):
2:42 PM Changeset in webkit [28457] by andersca@apple.com
  • 3 edits
    3 moves in trunk/WebKitTools

Reviewed by Geoff.


Rename the TestNetscapePlugIn .c files to be .cpp.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2:30 PM Changeset in webkit [28456] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix 64-bit debug build.

Reviewed by Kevin Decker.

  • platform/text/mac/TextCodecMac.cpp:

(WebCore::TextCodecMac::decode): OSStatus is a long for 32-bit but int on 64-bit,
so we need to cast it to be able to use a single format specifier on both.

2:29 PM Changeset in webkit [28455] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix for GCC 4.2. Cast via a union to avoid strict-aliasing issues.

Reviewed by Oliver.

2:27 PM Changeset in webkit [28454] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Add another test failing due to fonts.
2:24 PM Changeset in webkit [28453] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix case of keypresses from the Windows implementation of eventSender.keyDown

This fixes several regression tests.

Reviewed by Alice.

  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Virtual keycodes for ASCII characters are always uppercase, so we need to check the case of the original character passed in to eventSender.keyDown.
2:08 PM Changeset in webkit [28452] by kdecker@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Corrected a Radar number in my previous ChangeLog entry.

1:51 PM Changeset in webkit [28451] by kdecker@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

<rdar://problem/5602071> Safari displays each pixel of 300 dpi US Patent TIFF Images, making them extremely large


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldUsePlugin): Allow plug-ins (with the exception of QuickTime) to takeover TIFF once again.
1:48 PM Changeset in webkit [28450] by timothy@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

Add another Inspector screenshot for an upcoming blog post.

  • blog-files/InspectorDatabaseBrowser.png: Added.
1:16 PM Changeset in webkit [28449] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix testkjs in 64-bit.

When built for 64-bit the TCMalloc spin lock uses pthread mutexes rather than a custom spin lock
implemented in assembly. If we fail to initialize the pthread mutex, attempts to lock or unlock
it will fail and trigger a call to abort.

Reviewed by Darin.

  • wtf/FastMalloc.cpp: Initialize the spin lock so that we can later lock and unlock it.
  • wtf/TCSpinLock.h: Add an Init method to the optimised spin lock.
1:12 PM HackingGtk edited by alp@atoker.com
Mention bundled code (diff)
12:26 PM Changeset in webkit [28448] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-05 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16290
[GTK] Pasting clipboard in rich text.

  • platform/gtk/PasteboardGtk.cpp: (Pasteboard::documentFragment): Implement rich text paste support.
12:10 PM Changeset in webkit [28447] by adele@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Reverting fix for <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges

We need to just fix the underlying focus ring repaint problem.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle):
12:01 PM Changeset in webkit [28446] by kmccullough@apple.com
  • 4 edits in trunk

WebCore:

Reviewed by Darin.

  • <rdar://5621435>
  • Security Fix. Instead of having it off by default, WebKit now must explicitly turn off local-resource restriction when needed for backwards compatibility reasons.
  • loader/FrameLoader.cpp:

WebKit/mac:

Reviewed by Darin.

  • <rdar://5621435>
  • Security Fix. Instead of having it off by default, WebKit now must explicitly turn off local-resource restriction when needed for backwards coimpatibility reasons.
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]):
11:38 AM Changeset in webkit [28445] by Adam Roben
  • 5 edits in trunk/WebKit/win

Expose WebView::setProhibitsMainFrameScrolling through IWebViewPrivate

Reviewed by Steve.

  • Interfaces/IWebViewPrivate.idl: Added declaration.
  • WebInspectorClient.cpp: (WebInspectorClient::createPage): Updated for change to setProhibitsMainFrameScrolling signature.
  • WebView.cpp: (WebView::setProhibitsMainFrameScrolling): Updated and robustified.
  • WebView.h:
11:36 AM Changeset in webkit [28444] by Adam Roben
  • 2 edits in trunk/WebCore

Set the menu item identifier for all menu items

This allows WebKit clients to distinguish between submenus in the
context menu.

Reviewed by Darin.

No test possible.

  • platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::ContextMenuItem):
10:51 AM Changeset in webkit [28443] by Adam Roben
  • 2 edits in trunk/WebKitTools

Learn from Tim's mistakes

  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Reset the authorAndUserStylesEnabled preference for each test.
10:46 AM Changeset in webkit [28442] by mitz@apple.com
  • 9 edits
    3 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • manual-tests/nested-plug-ins.html: Added.
  • manual-tests/resources/nested-plug-ins-inner-frame.html: Added.
  • manual-tests/resources/nested-plug-ins-outer-frame.html: Added.
  • platform/ScrollView.h:
  • platform/Widget.h: (WebCore::Widget::attachToWindow): Added. Tells the widget that it is connected via visible ScrollViews to the root ScrollView of the WebView. (WebCore::Widget::detachFromWindow): Added. Tells the widget that it is no longer connected via visible ScrollViews to the root ScrollView of the WebView.
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): Added m_visible and m_attachedToWindow members. (WebCore::ScrollView::attachToWindow): Added. Attaches all children if this view is visible. (WebCore::ScrollView::detachFromWindow): Added. Detaches all children if this view is visible (otherwise they would be detached already). (WebCore::ScrollView::show): Added. Attaches all children if this view is attached. (WebCore::ScrollView::hide): Added. Detaches all children if this view is attached (otherwise they would be detached already). (WebCore::ScrollView::isAttachedToWindow): Added.
  • platform/win/WidgetWin.cpp: (WebCore::Widget::setParent): Added calls to attachToWindow() and detachFromWindow() depending on whether the parent is set and attached or not.
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFocus): (WebCore::PluginViewWin::show): Changed to show the plug-in only if this view is attached. (WebCore::PluginViewWin::hide): Changed to hide the plug-in only if this view is attached (otherwise it would be hidden already). (WebCore::PluginViewWin::attachToWindow): Added. Shows the plug-in if this view is visible. (WebCore::PluginViewWin::detachFromWindow): Added. Hides the plug-in if this view is visible (otherwise it would be hidden already). (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h: Added m_attachedToWindow member.

WebKit/win:

Reviewed by Darin Adler.

  • WebView.cpp: (WebView::initWithFrame): Attach the main frame's view.
10:15 AM Changeset in webkit [28441] by beidson@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Kevin Deckers rubberstamp

Disclose and export the Databases Directory defaults key

  • Storage/WebDatabaseManager.mm:
  • Storage/WebDatabaseManagerPrivate.h:
  • WebKit.exp:
9:07 AM HackingGtk edited by alp@atoker.com
Update link to the Cairo SVG backend in SVN, add link to the Cairo canvas (diff)
8:42 AM Changeset in webkit [28440] by alp@webkit.org
  • 2 edits in trunk/WebKitTools

2007-12-05 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Initialize GTK+ and WebKit so the tests can run.

Reorganize the headers a little.

7:53 AM Changeset in webkit [28439] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-12-05 Michael Natterer <​mitch@imendio.com>

Reviewed by Alp Toker.

  • WebView/webkitwebview.cpp: split key and button event handlers into separate press and release functions.
7:16 AM Changeset in webkit [28438] by alp@webkit.org
  • 3 edits in trunk/WebKit/gtk

2007-12-05 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

Handle events for Home and End keys.

  • WebView/webkitwebview.cpp: (webkit_web_view_key_event):
  • WebCoreSupport/EditorClientGtk.cpp: (EditorClient::handleKeypress):
4:35 AM Changeset in webkit [28437] by alp@webkit.org
  • 5 edits in trunk/WebKit/gtk

2007-12-05 Michael Natterer <​mitch@imendio.com>

Reviewed by Alp Toker.

  • WebView/webkitwebview.cpp
  • WebCoreSupport/ChromeClientGtk.cpp
  • WebCoreSupport/FrameLoaderClientGtk.cpp: canonicalize signal names.
1:32 AM QtWebKitTodo edited by Simon Hausmann
(diff)
12:26 AM Changeset in webkit [28436] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Adam Roben.

  • fast/dom/ImageDocument-image-deletion-expected.txt: Added.
  • fast/dom/ImageDocument-image-deletion.html: Added.

Dec 4, 2007:

8:47 PM Changeset in webkit [28435] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix gtk build

7:58 PM Changeset in webkit [28434] by oliver@apple.com
  • 7 edits
    1 add in trunk/JavaScriptCore

Merge TCMalloc r38

Reviewed by Mark Rowe and Geoff Garen.

It also result in a performance progression between 0.5% and
0.9% depending on the test, however most if not all of this
gain will be consumed by the overhead involved in the later
change to release memory to the system.

6:48 PM Changeset in webkit [28433] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-04 Alp Toker <​alp@atoker.com>

Potential GTK+ build fix for the glib-genmarshal issue.

Split the glib-genmarshal qmake generator in two; one for the source
file, another for the header.

  • WebCore.pro:
6:34 PM Changeset in webkit [28432] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Remove IWebScriptScope include.


  • Drosera/win/DebuggerDocumentPlatform.cpp:
6:08 PM Changeset in webkit [28431] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-04 Alp Toker <​alp@atoker.com>

GTK+ build fix.

  • platform/PlugInInfoStore.h:
5:58 PM Changeset in webkit [28430] by sfalken@apple.com
  • 1 delete in tags/Safari-523.12.11b/Safari-3-branch

Remove bad tag.

5:56 PM Changeset in webkit [28429] by sfalken@apple.com
  • 1 copy in tags/Safari-523.12.11b/Safari-3-branch

New tag.

5:49 PM Changeset in webkit [28428] by sfalken@apple.com
  • 1 copy in tags/Safari-523.12.11b

New tag.

5:48 PM Changeset in webkit [28427] by sfalken@apple.com
  • 1 delete in tags/Safari-523.12.11b

Remove unnecessary tag.

5:46 PM Changeset in webkit [28426] by kdecker@apple.com
  • 9 edits in trunk

Reviewed by Anders.

<rdar://problem/5629125> PluginInfoStore needs the ability to return the name of a plug-in for a given MIME type

  • page/mac/WebCoreViewFactory.h: Added pluginNameForMIMEType: method.
  • platform/PlugInInfoStore.h:
  • platform/gtk/TemporaryLinkStubs.cpp: Added stub version of pluginNameForMIMEType. (PlugInInfoStore::pluginNameForMIMEType):
  • platform/mac/PlugInInfoStoreMac.mm: (WebCore::PlugInInfoStore::pluginNameForMIMEType): Added.
  • platform/qt/PlugInInfoStoreQt.cpp: (WebCore::PlugInInfoStore::pluginNameForMIMEType): Added stub version of pluginNameForMIMEType.
  • plugins/win/PlugInInfoStoreWin.cpp: (WebCore::PlugInInfoStore::pluginNameForMIMEType): Added stub version of pluginNameForMIMEType.
  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory pluginNameForMIMEType:]): Added.
5:44 PM Changeset in webkit [28425] by sfalken@apple.com
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

5:40 PM Changeset in webkit [28424] by sfalken@apple.com
  • 1 copy in tags/Safari-523.12.11b

New tag.

5:08 PM Changeset in webkit [28423] by adele@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle): Adjust outline-offset so it doesn't extend beyond the border to interfere with typing

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges

  • fast/forms/textfield-outline.html: Added.
  • platform/mac/fast/forms/textfield-outline-expected.checksum: Added.
  • platform/mac/fast/forms/textfield-outline-expected.png: Added.
  • platform/mac/fast/forms/textfield-outline-expected.txt: Added.
5:05 PM Changeset in webkit [28422] by adachan@apple.com
  • 6 edits in trunk/WebKit/win

Provide API for setting the default storage quota per database origin

Reviewed by Jon.

  • Interfaces/IWebPreferencesPrivate.idl: added SPI to get/set default database quota
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): default database quota is 5MB (WebPreferences::longlongValueForKey): (WebPreferences::setLongLongValue): (WebPreferences::defaultDatabaseQuota): (WebPreferences::setDefaultDatabaseQuota):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged): propagate default database quota change to WebCore settings.
4:46 PM Changeset in webkit [28421] by andersca@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Jon.

Always call NPP_NewStream, NPP_DestroyStream and NPP_URLNotify for JavaScript
result streams, even if the JavaScript expression threw an exception or returned undefined.
This matches what Firefox does.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::sendJavaScriptStream): Handle the result string being null, and set the correct NPReason if it is.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Always send the JavaScript stream, regardless of the result could be converted to a string or not.
4:30 PM Changeset in webkit [28420] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Mark Rowe

Tweaked the way we typedef and cast these objc_msgSend calls

  • WebView/WebView.mm: (CallDelegateReturningUnsignedLongLong):
4:23 PM Changeset in webkit [28419] by weinig@apple.com
  • 3 edits in trunk/WebKitTools

Rubber stamped by Mark Rowe.

Define CF as platform for mac and revert r28409

  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/mac/DumpRenderTreeMac.h:
4:14 PM Changeset in webkit [28418] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Adam Roben.

Remove http/tests/incremental/frame-focus-before-load.html from the skipped list
as it is no longer crashing. <rdar://problem/5507278>

  • platform/win/Skipped:
4:08 PM Changeset in webkit [28417] by adele@apple.com
  • 7 edits
    4 adds in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5622464> controls should show up for audio element

  • css/html4.css: Added styles for audio controls. This will need to be refined, since we may want a different look for audio controls.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): When the controls attribute changes detach and reattach if necessary. (WebCore::HTMLMediaElement::rendererIsNeeded): Added. (WebCore::HTMLMediaElement::createRenderer): Added. Uses RenderMedia.
  • html/HTMLMediaElement.h:
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): Added constructor that doesn't take intrinsic size.
  • rendering/RenderMedia.h:

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/5622464> controls should show up for audio element

  • media/audio-controls-rendering.html: Added.
  • platform/mac/media/audio-controls-rendering-expected.checksum: Added.
  • platform/mac/media/audio-controls-rendering-expected.png: Added.
  • platform/mac/media/audio-controls-rendering-expected.txt: Added.
4:01 PM Changeset in webkit [28416] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Brady Eidson (with help from Mark Rowe)


Fixed return values for unsigned-long-long delegate methods

  • WebView/WebView.mm: (CallDelegateReturningUnsignedLongLong): redid the change that Brady did at home over the weekend but forgot to check in
3:53 PM Changeset in webkit [28415] by andersca@apple.com
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Sam.

Make isSafeScript const.


  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::isSafeScript):

WebCore:

Reviewed by Sam.

Add isSafeScript(const JSGlobalObject*) so we won't get the JSGlobalObject
implementation, which always returns true(!).


  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript): Make the static isSafeScript method take two JSGlobalObjects.


  • bindings/js/kjs_window.h: (KJS::Window::isSafeScript): Implement isSafeScript and have it call the static method.
3:40 PM Changeset in webkit [28414] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Define CF as platform for windows.

Reviewed by Adam Roben.

  • DumpRenderTree/win/DumpRenderTreeWin.h:
3:19 PM Changeset in webkit [28413] by kmccullough@apple.com
  • 5 edits in trunk

WebKit/win:

Reviewed by Adam and Darin.

  • Fixed a crasher where the top of the stack was not updated correctly. And set the eol style on IWebScriptCallFrame.idl file.
  • Interfaces/IWebScriptCallFrame.idl:
  • WebScriptDebugger.cpp: (WebScriptDebugger::atStatement): (WebScriptDebugger::leaveFrame):

WebKitTools:

Reviewed by Adam and Darin.

  • Removed a needless BSTR cleanup.
  • Drosera/win/DebuggerDocumentPlatform.cpp: (DebuggerDocument::getPlatformCurrentFunctionStack):
2:54 PM Changeset in webkit [28412] by Adam Roben
  • 10 edits in trunk

Hook up the authorAndUserStylesEnabled preference on Windows

WebKit/win:

Hook up the authorAndUserStylesEnabled preference

This is the Windows counterpart of r28071.

Reviewed by Maciej.

  • Interfaces/IWebPreferencesPrivate.idl: Added new method declarations.
  • WebPreferenceKeysPrivate.h: Added a new preference key.
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Set the default for the new preference. (WebPreferences::setAuthorAndUserStylesEnabled): Added. (WebPreferences::authorAndUserStylesEnabled): Added.
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged): Communicate the new preference down to WebCore::Settings.

WebKitTools:

Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT

Reviewed by Maciej.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.

LayoutTests:

Remove a now-passing test from the Windows Skipped file

Reviewed by Maciej.

  • platform/win/Skipped:
2:52 PM Changeset in webkit [28411] by Adam Roben
  • 15 edits in trunk

Make the implementation of Frame::setNeedsReapplyStyles cross-platform

WebCore:

Make the implementation of Frame::setNeedsReapplyStyles cross-platform

Reviewed by Hyatt.

No change in functionality.

  • page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles): Added. Invalidates the FrameView so that FrameView::layout will be called, which ends up calling reapplyStyles. (WebCore::Frame::needsReapplyStyles): Added. (WebCore::Frame::reapplyStyles): Renamed from reparseConfiguration. (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h: Added new boolean member.
  • page/FrameView.cpp: (WebCore::FrameView::layout): Call Frame::reapplyStyles if needed. (WebCore::FrameView::needsLayout): Say that we need layout if the Frame needs styles reapplied.
  • page/mac/WebCoreFrameBridge.h: Removed setNeedsReapplyStyles.
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): Updated for rename.
  • bridge/win/FrameWin.cpp: Removed Frame::setNeedsReapplyStyles.
  • page/gtk/FrameGtk.cpp: Ditto.
  • page/mac/FrameMac.mm: Ditto.
  • page/qt/FrameQt.cpp: Ditto.
  • platform/wx/TemporaryLinkStubs.cpp: Ditto.

WebKit/mac:

Remove -[WebFrameBridge setNeedsReapplyStyles]

This functionality is now WebCore's responsibility.

Reviewed by Hyatt.

  • WebCoreSupport/WebFrameBridge.mm:
  • WebKit.order:
2:40 PM Changeset in webkit [28410] by sfalken@apple.com
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

2:28 PM Changeset in webkit [28409] by alp@webkit.org
  • 2 edits in trunk/WebKitTools

2007-12-04 Alp Toker <​alp@atoker.com>

Prospective Win DRT build fix.

  • DumpRenderTree/DumpRenderTree.h:
1:46 PM Changeset in webkit [28408] by Antti Koivisto
  • 2 edits in trunk/WebCore

Reviewed by Adele.

Pass intrinsic size to the base class.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia):
1:38 PM Changeset in webkit [28407] by sfalken@apple.com
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/Interfaces.vcproj

Build fix.

1:15 PM Changeset in webkit [28406] by Adam Roben
  • 2 edits in tags/Safari-525.2.3b/WebKit/win

Merge r28391

2007-12-04 Adam Roben <Adam Roben>

Windows build fix

  • WebScriptCallFrame.cpp:
1:12 PM Changeset in webkit [28405] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

2007-12-04 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Ollie.

Don't crash if our JavaPlugin DLL can't be found

  • WebFrame.cpp: (WebFrame::createJavaAppletWidget): Added null check
1:11 PM Changeset in webkit [28404] by sullivan@apple.com
  • 3 edits in trunk/WebKit/mac

Reviewed by Darin


Added deleteOrigin: SPI, which isn't fully implemented

  • Storage/WebDatabaseManagerPrivate.h:
  • Storage/WebDatabaseManager.mm: (-[WebDatabaseManager deleteOrigin:]): just calls deleteDatabasesWithOrigin: for now, but needs to delete origin itself too
1:11 PM Changeset in webkit [28403] by adele@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5578209> REGRESSION: Crash in WebCore::DeprecatedValueListImpl::Private::copyList when going back on zoomerang.com/survey

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::scheduleHistoryNavigation): When the new url is exactly the same as the old url, don't treat it like a fragment navigation, since its going to cause a reload.
1:04 PM Changeset in webkit [28402] by Adam Roben
  • 1 copy in tags/Safari-525.2.3b

New tag.

12:26 PM Changeset in webkit [28401] by timothy@apple.com
  • 3 edits in trunk/WebKit/mac

Reviewed by Mark Rowe.

Remove a check for early versions of Leopard CFNetwork now that
Leopard has shipped.

  • Misc/WebKitVersionChecks.h: Remove WEBKIT_FIRST_CFNETWORK_VERSION_WITH_LARGE_DISK_CACHE_FIX.
  • WebView/WebView.mm: (+[WebView _setCacheModel:]): Remove the early Leopard CFNetwork check.
11:56 AM Changeset in webkit [28400] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

2007-12-04 Kevin Decker <​kdecker@apple.com>

Reviewed by Darin.

Revised fix for: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang

This fix is exactly the same as chageset 28359 with the exception of an added early return in
updateAndSetWindow to cover the additional case of when a plug-in isn't drawable.


The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would
only call into the NPP_SetWindow() function when we tell the plug-in to draw. This created havoc with
Flash because Flash expects the browser to call NPP_SetWindow() and provide a valid graphics context
regardless of whether or not it actually needs to draw.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned down an ASSERT that was too strict. (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins which would sometimes altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow() function. Also tweaked a comment and added an early return if the plug-in can't draw.
11:47 AM Changeset in webkit [28399] by Darin Adler
  • 22 edits in trunk

WebCore:

Reviewed by Kevin Decker.

  • added an assertion for a situation that leads to a Safari assertion: a commit that is not followed by a load completion
  • removed some unneeded FrameLoader stuff -- maybe some day we'll get this class cut down to size
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): Added boolean for assertion. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Added code to assert that we already sent a commit before sending a complete. (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): Call client directly instead of indirecting through a function. (WebCore::FrameLoader::loadItem): Ditto. (WebCore::FrameLoader::goToItem): Ditto. (WebCore::FrameLoader::addHistoryForCurrentLocation): Get the private browsing state from Settings instead of FrameLoaderClient. Also call client directly instead of indirecting through a function. (WebCore::FrameLoader::updateHistoryForReload): Call client directly instead of indirecting through a function. (WebCore::FrameLoader::dispatchDidCommitLoad): Added code to assert that we did not yet send a commit and set the flag that will be used to check that we don't do this twice in a row without an intervening completion call.
  • loader/FrameLoader.h: Added a boolean for the assertion. Removed six now-unneeded functions.
  • loader/FrameLoaderClient.h: Removed now-unneeded privateBrowsingEnabled function.
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willCacheResponse): Get the private browsing state from Settings instead of FrameLoaderClient.
  • svg/graphics/SVGImageEmptyClients.h: Removed obsolete privateBrowsingEnabled.

WebKit/gtk:

Reviewed by Kevin Decker.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: Removed obsolete privateBrowsingEnabled.
  • WebCoreSupport/FrameLoaderClientGtk.h: Ditto.

WebKit/mac:

Reviewed by Kevin Decker.

  • WebCoreSupport/WebFrameLoaderClient.h: Removed obsolete privateBrowsingEnabled.
  • WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
  • WebKit.order: Ditto.

WebKit/qt:

Reviewed by Kevin Decker.

  • WebCoreSupport/FrameLoaderClientQt.cpp: Removed obsolete privateBrowsingEnabled.
  • WebCoreSupport/FrameLoaderClientQt.h: Ditto.

WebKit/win:

Reviewed by Kevin Decker.

  • WebFrame.cpp: Removed obsolete privateBrowsingEnabled.
  • WebFrame.h: Ditto.

WebKit/wx:

Reviewed by Kevin Decker.

  • WebKitSupport/FrameLoaderClientWx.cpp: Removed obsolete privateBrowsingEnabled.
  • WebKitSupport/FrameLoaderClientWx.h: Ditto.
11:46 AM Changeset in webkit [28398] by timothy@apple.com
  • 1 edit in trunk/WebKit/StringsNotToBeLocalized.txt

Update StringsNotToBeLocalized.txt.

11:21 AM Changeset in webkit [28397] by Antti Koivisto
  • 13 edits
    4 adds in trunk

WebCore:

Reviewed by Adele.


Fix <rdar://problem/5624802>
Controller displays outside of <video> element when width and height aren't specified

  • Explicitly adjust size of the controls tree root.
  • Switch RenderMedia base class back to RenderReplaced. It is easier to manage the shadow tree by hand. This also allows better code sharing with other replaced element classes.
  • Move duplicated layout and painting code from subclasses up to RenderReplaced.

Test: media/video-controls-rendering.html

  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced):
  • rendering/RenderHTMLCanvas.h:

Share code.

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced): (WebCore::RenderImage::minimumReplacedHeight):
  • rendering/RenderImage.h:

Share code.

  • rendering/RenderMedia.cpp: (WebCore::RenderMediaControlShadowRoot::RenderMediaControlShadowRoot): (WebCore::RenderMediaControlShadowRoot::setParent):

Add a subclass just to get through encapsulation to use setParent().

(WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):

Move initialization to the constructor.

(WebCore::RenderMedia::RenderMedia):
(WebCore::RenderMedia::~RenderMedia):
(WebCore::RenderMedia::layout):

Resize and layout the controller root by hand.

(WebCore::RenderMedia::firstChild):
(WebCore::RenderMedia::lastChild):
(WebCore::RenderMedia::removeChild):

Support one child renderer for controls.

(WebCore::RenderMedia::createControlsShadowRoot):

  • rendering/RenderMedia.h: (WebCore::RenderMedia::isMedia):

Switch base class to RenderReplaced, delete the now unnecessary stuff.

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::layout): (WebCore::RenderReplaced::paint):
  • rendering/RenderReplaced.h: (WebCore::RenderReplaced::minimumReplacedHeight): (WebCore::RenderReplaced::paintReplaced):

Share code.

  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::videoSizeChanged):

Simplify, just request relayout.

(WebCore::RenderVideo::paintReplaced):
(WebCore::RenderVideo::layout):

  • rendering/RenderVideo.h:

Share code.

LayoutTests:

Reviewed by Adele.


Test for <rdar://problem/5624802>
Controller displays outside of <video> element when width and height aren't specified

  • media/remove-from-document.html: Improve coverage by doing relayout before finishing.
  • media/video-controls-rendering.html: Added.
  • platform/mac/media/video-controls-rendering-expected.checksum: Added.
  • platform/mac/media/video-controls-rendering-expected.png: Added.
  • platform/mac/media/video-controls-rendering-expected.txt: Added.
11:10 AM Changeset in webkit [28396] by alp@webkit.org
  • 4 edits in trunk

2007-12-04 Michael Natterer <​mitch@imendio.com>

Reviewed by Alp Toker.

  • WebCore.pro: fix build of webkit-marshal by building the functions into a separate .cpp file instead of including them in the header. This way we can use the marshallers from more than one file without using bad hacks.

Add the generated sources directory to DEPENDPATH.

11:08 AM Changeset in webkit [28395] by Darin Adler
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Geoff.

Test: fast/js/regexp-overflow.html

  • pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags): Add room for the additional BRA/KET that was generated in the compile code but not taken into account here.

LayoutTests:

Reviewed by Geoff.

  • fast/js/regexp-overflow-expected.txt: Updated.
  • fast/js/resources/regexp-overflow.js: Added test cases.
10:52 AM Changeset in webkit [28394] by Adam Roben
  • 1 edit in tags/Safari-525.2.2b/WebKit/win/WebKit.vcproj/WebKit.make

Merge r28392

10:36 AM Changeset in webkit [28393] by sfalken@apple.com
  • 1 copy in tags/Safari-525.2.2b

New tag.

10:28 AM Changeset in webkit [28392] by sfalken@apple.com
  • 1 edit in trunk/WebKit/win/WebKit.vcproj/WebKit.make

Build fix.

10:27 AM Changeset in webkit [28391] by Adam Roben
  • 2 edits in trunk/WebKit/win

Windows build fix

  • WebScriptCallFrame.cpp:
9:58 AM Changeset in webkit [28390] by alp@webkit.org
  • 2 edits in trunk/WebKitSite

2007-12-04 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Link to Planet WebKit.

  • nav.inc:
8:50 AM Changeset in webkit [28389] by alp@webkit.org
  • 5 edits
    2 adds in trunk/WebCore

2007-12-04 Pierre-Luc Beaudoin <​pierre-luc.beaudoin@collabora.co.uk>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16145
[gtk] Implement media support in GTK backend

This implements the media tags of HTML5 on the GTK+ port based on the
Mac port. Media tests pass although some tests required a small modifications:
As per the HTML5 spec, the loading of the clip should start only after
all script are done. But in the case of the tests, the loading starts
before some callbacks get registered. This has been discussed with
Antti Koivisto, and the tests should be updated.

There is only one known issue: one time in 10 tries, loading a buffered
clip will never end buffering. The buffering will stall at 97% for no
apparent reasons. Reloading the page usually works around the problem.
On the GStreamer side, some codecs don't return correct values, therefore
they make the tests fail. For instance H.264 will make the video-end
test fail. This should be fixed in GStreamer 0.10.15.

This version displays video in a pop up window. A place holder is drawn
on the page where the video should appear.

By default, it is turned off in WebCore.pro until GStreamer/X
detection issues are sorted out.

  • WebCore.pro: Disable video for now
  • platform/Logging.cpp: (WebCore::):
  • platform/Logging.h: Added a logging level for Media stuff
  • platform/graphics/Movie.cpp:
  • platform/graphics/gtk/MoviePrivateGStreamer.cpp: Added. (WebCore::moviePrivateErrorCallback): (WebCore::moviePrivateEOSCallback): (WebCore::moviePrivateStateCallback): (WebCore::moviePrivateBufferingCallback): (WebCore::moviePrivateWindowIDCallback): (WebCore::MoviePrivate::MoviePrivate): (WebCore::MoviePrivate::~MoviePrivate): (WebCore::MoviePrivate::load): (WebCore::MoviePrivate::play): (WebCore::MoviePrivate::pause): (WebCore::MoviePrivate::duration): (WebCore::MoviePrivate::currentTime): (WebCore::MoviePrivate::seek): (WebCore::MoviePrivate::setEndTime): (WebCore::MoviePrivate::addCuePoint): (WebCore::MoviePrivate::removeCuePoint): (WebCore::MoviePrivate::clearCuePoints): (WebCore::MoviePrivate::startCuePointTimerIfNeeded): (WebCore::MoviePrivate::cancelSeek): (WebCore::MoviePrivate::cuePointTimerFired): (WebCore::MoviePrivate::paused): (WebCore::MoviePrivate::seeking): (WebCore::MoviePrivate::naturalSize): (WebCore::MoviePrivate::hasVideo): (WebCore::MoviePrivate::setVolume): (WebCore::MoviePrivate::setMuted): (WebCore::MoviePrivate::setRate): (WebCore::MoviePrivate::dataRate): (WebCore::MoviePrivate::networkState): (WebCore::MoviePrivate::readyState): (WebCore::MoviePrivate::maxTimeBuffered): (WebCore::MoviePrivate::maxTimeSeekable): (WebCore::MoviePrivate::maxTimeLoaded): (WebCore::MoviePrivate::bytesLoaded): (WebCore::MoviePrivate::totalBytesKnown): (WebCore::MoviePrivate::totalBytes): (WebCore::MoviePrivate::cancelLoad): (WebCore::MoviePrivate::updateStates): (WebCore::MoviePrivate::loadStateChanged): (WebCore::MoviePrivate::rateChanged): (WebCore::MoviePrivate::sizeChanged): (WebCore::MoviePrivate::timeChanged): (WebCore::MoviePrivate::volumeChanged): (WebCore::MoviePrivate::didEnd): (WebCore::MoviePrivate::loadingFailed): (WebCore::MoviePrivate::setRect): (WebCore::MoviePrivate::setVisible): (WebCore::MoviePrivate::paint): (WebCore::MoviePrivate::getSupportedTypes): (WebCore::MoviePrivate::createGSTPlayBin):
  • platform/graphics/gtk/MoviePrivateGStreamer.h: Added.
6:12 AM Changeset in webkit [28388] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-12-04 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

Fix a regression in key press propagation in r28386.

Fix indentation (was off by two spaces).

  • WebView/webkitwebview.cpp:
5:48 AM QtWebKitTodo edited by zecke2@selfish.org
(diff)
5:43 AM QtWebKitTodo edited by zecke2@selfish.org
(diff)
5:27 AM QtWebKitTodo edited by zecke2@selfish.org
CallOnMainThread is done, IconDataBase is outstanding (diff)
5:19 AM Changeset in webkit [28387] by zecke@webkit.org
  • 2 edits in trunk

Add the missing ChangeLog entries for r28349.

WebCore/ChangeLog:
2007-12-04 Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

Reviewed by Simon.

  • Implement the InspectorClient for the Qt port
  • It does not support highlighting of nodes yet
  • Use QRC to open the internal page. The important thing is the '/' in the URL to make WebCore::Document::completeURL behave the way we want.
  • To make the InspectorClient work we will have to mark qrc as secure.
  • WebCore.pro:
  • loader/FrameLoader.cpp: (WebCore::localSchemes):
  • page/inspector/WebKit.qrc: Added.

WebKit/qt:
2007-12-04 Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

Reviewed by Simon.

  • Implement the InspectorClient for the Qt port
  • It does not support highlighting of nodes yet
  • Use QRC to open the internal page. The important thing is the '/' in the URL to make WebCore::Document::completeURL behave the way we want.
  • To make the InspectorClient work we will have to mark qrc as secure.
  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • Api/qwebpage.h:
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientWebPage::hideEvent): (WebCore::InspectorClientQt::InspectorClientQt): (WebCore::InspectorClientQt::inspectorDestroyed): (WebCore::InspectorClientQt::createPage): (WebCore::InspectorClientQt::localizedStringsURL): (WebCore::InspectorClientQt::showWindow): (WebCore::InspectorClientQt::closeWindow): (WebCore::InspectorClientQt::attachWindow): (WebCore::InspectorClientQt::detachWindow):
  • WebCoreSupport/InspectorClientQt.h:
5:14 AM Changeset in webkit [28386] by alp@webkit.org
  • 4 edits in trunk/WebKit/gtk

2007-12-04 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=15911
[GTK] Use GtkBindingSet to make key bindings user-configurable

This patch doesn't cover the full range of bindings, only the ones
that seem obviously correct and have clear public API.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeypress): do not handle clipboard operations and select-all
  • WebView/webkitwebview.cpp: add cut, copy, paste and select-all signals and allow binding sets (issue #15911 and #16144)
  • WebView/webkitwebview.h:
4:34 AM Changeset in webkit [28385] by alp@webkit.org
  • 2 edits in trunk/WebKitTools

2007-12-04 Alp Toker <​alp@atoker.com>

Fix a clobbered copyright header.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:
4:16 AM Changeset in webkit [28384] by alp@webkit.org
  • 7 edits
    7 adds in trunk

2007-12-04 Xan Lopez <​xan@gnome.org>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=15561
GTK port needs DumpRenderTree implementation

Start work on the GTK+ DRT.

This does not work yet, and there are a few lingering style issues
(nothing major) but this patch has been stuck in the bug tracker for
too long already.

12:40 AM Changeset in webkit [28383] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Roll out r28359 as it causes serious problems with tabbed browsing in Safari when viewing pages containing plugins (<rdar://problem/5627529>).

12:31 AM Changeset in webkit [28382] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-04 Alp Toker <​alp@atoker.com>

Rubber stamped by Mark Rowe.

Remove two unused variables to silence warnings.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke):
Note: See TracTimeline for information about the timeline view.