Context Navigation

← Previous Period
Next Period →

Timeline

Dec 6, 2007:

11:27 PM Changeset in webkit [28514] by adachan@apple.com

2 edits in trunk/WebCore

Fixed the if statement (ERROR_SUCCESS is 0 and we were actually
returning true when there's an error).

Reviewed by Steve.

platform/win/FileSystemWin.cpp: (WebCore::makeAllDirectories):

11:02 PM Changeset in webkit [28513] by ap@webkit.org

1 edit
10 adds in trunk/LayoutTests

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16091
JSCRE needs to import the PCRE test suite

We can use two files from PCRE test suite, as others either test for features not supported
in JS, or use internal debugging facilities of PCRE.

The files are checked in almost unmodified, I have only converted them to UTF-8 and removed two
huge test cases that were completely incompatible with JSC, and were polluting the output.

Many of the failures in results are just legitimate differences in behavior or possibly
problems with the test runner, but some may be genuine bugs and even regressions in JSC.

fast/regex: Added.
fast/regex/pcre-test-runner.js: Added.
fast/regex/test1-expected.txt: Added.
fast/regex/test1.html: Added.
fast/regex/test4-expected.txt: Added.
fast/regex/test4.html: Added.
fast/regex/testinput1: Added.
fast/regex/testinput4: Added.
fast/regex/testoutput1: Added.
fast/regex/testoutput4: Added.

10:17 PM Changeset in webkit [28512] by beidson@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Oliver's rubber stamp

Let's go ahead and call the correct UI Delegate method, shall we?

WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Call the correct UI delegate

9:33 PM Changeset in webkit [28511] by kevino@webkit.org

3 edits in trunk/WebKit/wx

Linux build fix - ensure that webcore is linked before jscore so that the linker will know which symbols it needs to link in. Also fix MSVC project file name typo for sample app.

7:59 PM Changeset in webkit [28510] by Darin Adler

2 edits in trunk/WebCore

fix broken regression test

bindings/js/kjs_binding.cpp: (KJS::setDOMException): Oops, this was just supposed to be PERMISSION_DENIED.

7:18 PM Changeset in webkit [28509] by Darin Adler

9 edits
1 copy in trunk/WebCore

Reviewed by Sam Weinig.

fix http://bugs.webkit.org/show_bug.cgi?id=16332 ObjC DOM exception object descriptions should include the exception name

WebCore.pro: Added ExceptionCode.cpp.
WebCore.vcproj/WebCore.vcproj: Added ExceptionCode.cpp.
WebCore.xcodeproj/project.pbxproj: Added ExceptionCode.cpp.
WebCoreSources.bkl: Added ExceptionCode.cpp.

bindings/js/kjs_binding.cpp: (KJS::setDOMException): Moved the code to decompose an ExceptionCode into ExceptionCode.h/cpp -- getExceptionCodeDescription. Also removed the many unneeded includes that were here. Had to keep one special case here, for SECURITY_ERR.

bindings/objc/ExceptionHandlers.mm: (WebCore::raiseDOMException): Changed to use the new getExceptionCodeDescription function so that this shares the exception name information that was previously only available to JavaScript.

dom/ExceptionCode.cpp: Copied from bindings/js/kjs_binding.cpp. (WebCore::getExceptionCodeDescription): Added some assertions, and made the function handle exception names in a slightly more robust way that is not subject to integer overflow. (Not a real world issue since we should never receive a bad exception code.)

dom/ExceptionCode.h: Added the ExceptionCodeDescription struct and the getExceptionCodeDescription function.

svg/SVGException.h: Added a missing #include and got rid of some comments. Some of the comments were mildly helpful, but others were incorrect. This now matches the other exception-related headers such as RangeException.h.

6:49 PM Changeset in webkit [28508] by beidson@apple.com

2 edits in trunk/WebCore

Reviewed by Darin

Fixed a glaring bug that would prevent a statement from getting run a second time

storage/SQLStatement.cpp: (WebCore::SQLStatement::execute): Clear failure due to quota *before* we check the error and return early (WebCore::SQLStatement::clearFailureDueToQuota): Only clear the error if it was a quota error

6:10 PM Changeset in webkit [28507] by timothy@apple.com

4 edits in trunk/WebCore

Reviewed by Oliver Hunt.

Use keydown instead of keypress so keyIdentifier can be used.

page/inspector/ConsolePanel.js: Use keydown instead of keypress.
page/inspector/DatabasePanel.js: Ditto.
page/inspector/inspector.js: Ditto. Plus call removeEventListener before deleting windowLoaded.

6:05 PM Changeset in webkit [28506] by Adam Roben

2 edits in trunk/WebCore

Rename FontsTable.plist to FontsList.plist

Rubberstamped by Hyatt.

platform/graphics/win/FontDatabase.cpp:

6:00 PM Changeset in webkit [28505] by alice.liu@apple.com

4 edits in trunk/WebKit/win

Fixed <rdar://5540000> onbeforeunload doesn't fire when closing window/tab

Reviewed by Darin.

Interfaces/IWebViewPrivate.idl:
WebView.cpp: (WebView::shouldClose):
WebView.h:

5:51 PM Changeset in webkit [28504] by beidson@apple.com

2 edits in trunk/WebCore

Reviewed by Darin

Tweaked a comment and a few assertions from my last checkin

storage/SQLStatement.cpp: (WebCore::SQLStatement::execute): (WebCore::SQLStatement::clearFailureDueToQuota): (WebCore::SQLStatement::lastExecutionFailedDueToQuota):

5:04 PM Changeset in webkit [28503] by Adam Roben

4 edits in trunk/WebKit

Fix <rdar://5615283> Crash in WebFrame::receivedPolicyDecision

WebKit/mac:

Remove some assertions we know can fire and replace them with a FIXME

Reviewed by Anders.

WebCoreSupport/WebFrameLoaderClient.mm:

WebKit/win:

Fix <rdar://5615283> Crash in WebFrame::receivedPolicyDecision

It's possible for a second policy listener to be created while we're
waiting for a decision on the first policy listener. In this case we
would crash when the first policy listener had a decision made. Mac
WebKit already handles this by invalidating any existing policy
listener when creating a new one.

A test case is coming in a future commit.

Reviewed by Anders.

WebFrame.cpp: (WebFrame::setUpPolicyListener): Copy the Mac behavior of invalidating any existing policy listener, and remove some assertions that we know can fire.

4:50 PM Changeset in webkit [28502] by beidson@apple.com

9 edits in trunk/WebCore

Reviewed by Darin

Finished hooking up UI Delegate for databases - Database operations will now enforce a size quota and
will ask the UI Delegate for more space when that quota is met

platform/sql/SQLiteDatabase.cpp: Add the new SQLResultFull constant
platform/sql/SQLiteDatabase.h: Ditto

storage/Database.cpp: (WebCore::Database::securityOriginData): Added this accessor, copying for thread safety (WebCore::Database::stringIdentifier): Ditto
storage/Database.h:

storage/SQLStatement.cpp: (WebCore::SQLStatement::SQLStatement): (WebCore::SQLStatement::execute): Change to return an enum that represents 3 states - success, error, and quota. If the result is quota, this statement expects that it might be run again, presumably after the user increases the quota (WebCore::SQLStatement::setFailureDueToQuota): Setup a quota failure, including a flag and the error (WebCore::SQLStatement::clearFailureDueToQuota): Clear a quota failure, for when the statement is rerun (WebCore::SQLStatement::lastExecutionFailedDueToQuota):
storage/SQLStatement.h:

storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::performPendingCallback): Added an acceptable callback pointer (WebCore::SQLTransaction::openTransactionAndPreflight): Setup the quota in the database that will remain for this transaction. Note that in this patch, the quota being set is wrong - it makes sense to fix that in a follow up patch (WebCore::SQLTransaction::runStatements): Modified to add the ability to re-run a statement based on the UI delegate decision and whether the current statement was already run (WebCore::SQLTransaction::runCurrentStatement): Added another result condition - the Quota result - and handle it (WebCore::SQLTransaction::handleCurrentStatementError): Statements can now error-out from two places, so the code that handles a statement error was moved here (WebCore::SQLTransaction::deliverQuotaIncreaseCallback): Added - Consult the UI delegate for more quota, then reschedule the current statement on the database thread
storage/SQLTransaction.h:

3:32 PM Changeset in webkit [28501] by timothy@apple.com

2 edits in trunk/WebKit/mac

Change the ASSERT added for the previous fix. The ASSERT was firing for 10.5.0.
Only assert if the major version is zero, since zero is handled in the other cases.

WebView/WebView.mm: (callGestalt): Remove the ASSERT. (createMacOSXVersionString): ASSERT that major is not zero.

3:31 PM Changeset in webkit [28500] by sfalken@apple.com

2 edits in trunk/WebCore

<rdar://problem/5614257> Crash in timer / hashtable code due to uncaught exception

Don't use callback-based timers, since these cause Windows to eat Windows crashes
in code the timers call.

Windows appears to be defending against "shatter" attacks partially by setting
up a structured exception block while dispatching callback-based WM_TIMERs.

I verified this by adding a divide by zero into some timer callback code.
In the case where the timer was dispatched via a callback, the divide by zero
exception was silently handled and ignored, with execution continuing after
our call to DispatchMessage. When processed via the WNDPROC, no SEH
block was established by Windows, and our divide by zero generated a real
crash (which is what we wanted).

Windows handling our crashes for us led us to leave the timer data structures
in an invalid state so the next time a timer was set, we'd crash accessing an
invalid HashMap of timer data.

Reviewed by Hyatt.

platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc): (WebCore::setSharedTimerFireTime):

2:36 PM Changeset in webkit [28499] by Darin Adler

2 edits in trunk/WebKit/mac

Reviewed by Tim Hatcher.

fix <rdar://problem/5513394> No way to detect Tiger vs Leopard from Safari's user agent string

WebView/WebView.mm: (callGestalt): Added. (createMacOSXVersionString): Added. (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Added Mac OS X version string, right after the string "Mac OS X", but with underscores instead of dots to avoid the dreaded "4." problem (old libraries that think a "4." anywhere in the user agent means Netscape 4). (-[WebView _userAgentForURL:]): Fixed incorrect bug numbers.

2:11 PM Changeset in webkit [28498] by Adam Roben

9 edits in trunk

Fix <rdar://5108390> Feed title is too low in blue banner

WebCore:

Fix <rdar://5108390> Feed title is too low in blue banner

Way back in r23069 we started applying the same font ascent hack that
Mac WebKit applies to Helvetica, Times, and Courier. We did this so
that those fonts would match the Mac metrics when we run the
regression tests. However, this hack was applying to Arial on Windows
when a site would specify the Helvetica font face because Windows will
alias the font names. Instead of removing the hack entirely, we
turn it off by default but provide some SPI so that DumpRenderTree can
turn it on.

Reviewed by Hyatt.

All tests pass.

platform/graphics/FontData.h: Add a new static method to turn on the hack on Windows only.
platform/graphics/win/FontDataWin.cpp: (WebCore::FontData::setShouldApplyMacAscentHack): Added. (WebCore::FontData::platformInit): Only perform the hack if shouldApplyMacAscentHack is true.

WebKit/win:

Add SPI so that DumpRenderTree can turn on the Mac font ascent hack

Reviewed by Hyatt.

Interfaces/IWebViewPrivate.idl: Added new method declaration.
WebView.cpp: (WebView::setShouldApplyMacFontAscentHack): Added. Just calls down to FontData.
WebView.h:

WebKitTools:

Explicitly turn on the Mac font ascent hack on Windows

This keeps our font metrics matching those from Mac.

Reviewed by Hyatt.

DumpRenderTree/win/DumpRenderTree.cpp: (main):

1:25 PM Changeset in webkit [28497] by mitz@apple.com

3 edits in trunk/LayoutTests

updated render tree results for r28483

svg/batik/text/textEffect2-expected.txt:
svg/batik/text/textProperties-expected.txt:

1:19 PM Changeset in webkit [28496] by ggaren@apple.com

3 edits
3 adds in trunk

WebCore:

Reviewed by Sam Weinig.

Fixed http://bugs.webkit.org/show_bug.cgi?id=16328
REGRESSION (r28470): Crash expanding a GMail conversation

page/Frame.cpp: (WebCore::Frame::scriptProxy): Only return 0 if JS seems disabled *and* we haven't created the proxy yet. If we've created the proxy already, a script may be in the midst of execution, even though we've lost our settings object. During execution, scripts assume they have free access to the proxy.

LayoutTests:

Reviewed by Sam Weinig.

Test for http://bugs.webkit.org/show_bug.cgi?id=16328
REGRESSION (r28470): Crash expanding a GMail conversation

fast/frames/location-put-after-removal.html: Added.
fast/frames/resources/location-put-after-removal-frame.html: Added.
fast/frames/resources/location-put-after-removal-frame-expected.txt: Updated.

1:17 PM Changeset in webkit [28495] by andersca@apple.com

1 edit
1 copy in trunk/WebKitTools

Rename main.c to main.cpp here too.

DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.

1:10 PM Changeset in webkit [28494] by weinig@apple.com

2 edits in trunk/WebKitTools

Rubber stamped by Geoff.

Scripts/do-webcore-rename: Don't rename kjs_css twice.

1:00 PM Changeset in webkit [28493] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: Some more renaming plans.

12:37 PM Changeset in webkit [28492] by andersca@apple.com

2 edits in trunk/WebKitTools

Remove implementation of testGetIntIdentifier that was accidentally
removed somehow (possibly when I made PluginObject be a cpp file).

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvoke):

12:24 PM Changeset in webkit [28491] by Darin Adler

5 edits in trunk

JavaScriptCore:

Reviewed by Eric Seidel.

fix http://bugs.webkit.org/show_bug.cgi?id=16321 new RegExp("[\u0097]{4,6}", "gmy") crashes in DEBUG builds <rdar://problem/5632992>

Test: fast/js/regexp-oveflow.html

pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags): In the case where a single character character class is optimized to not use a character class at all, the preflight code was not setting the lastitemlength variable.

LayoutTests:

Reviewed by Eric Seidel.

fix http://bugs.webkit.org/show_bug.cgi?id=16321 new RegExp("[\u0097]{4,6}", "gmy") crashes in DEBUG builds <rdar://problem/5632992>

fast/js/regexp-overflow-expected.txt: Updated.
fast/js/resources/regexp-overflow.js: Added test.

12:11 PM Changeset in webkit [28490] by alp@webkit.org

5 edits in trunk/WebKit/gtk

2007-12-06 Xan Lopez <xan@gnome.org>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16329
[GTK] Two small cleanups

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::createWindow): (WebKit::ChromeClient::addMessageToConsole): (WebKit::ChromeClient::runJavaScriptAlert): (WebKit::ChromeClient::runJavaScriptConfirm): (WebKit::ChromeClient::runJavaScriptPrompt): (WebKit::ChromeClient::setStatusbarText): (WebKit::ChromeClient::mouseDidMoveOverElement): (WebKit::ChromeClient::setToolTip):
WebCoreSupport/ChromeClientGtk.h:
WebView/webkitprivate.cpp: (WebKit::kit): s/m_webPage/m_webView/
WebView/webkitwebview.cpp: Chain up to the parent class to activate bindings instead of doing it explicitely.

12:02 PM Changeset in webkit [28489] by adele@apple.com

4 edits
4 adds in trunk

WebCore:

Reviewed by Oliver.

Fix for <rdar://problem/5631356> Toggling display property on video causes controls to get lost

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attach): Call updateFromElement.
html/HTMLMediaElement.h:

LayoutTests:

Reviewed by Oliver.

Fix <rdar://problem/5631356> Toggling display property on video causes controls to get lost

media/video-display-toggle.html: Added.
platform/mac/media/video-display-toggle-expected.checksum: Added.
platform/mac/media/video-display-toggle-expected.png: Added.
platform/mac/media/video-display-toggle-expected.txt: Added.

11:33 AM Changeset in webkit [28488] by adachan@apple.com

2 edits in trunk/WebKit/win

Build fix.

Reviewed by Geoff.

WebScriptCallFrame.cpp: (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):

10:46 AM Changeset in webkit [28487] by Antti Koivisto

12 edits
6 moves in trunk/WebCore

Reviewed by Oliver.

Rename

Movie -> MediaPlayer
MoviePrivate -> MediaPlayerPrivate

Movie is QuickTime terminology and clashes with its C API.

WebCore.xcodeproj/project.pbxproj:
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::~HTMLMediaElement): (WebCore::HTMLMediaElement::initAndDispatchProgressEvent): (WebCore::HTMLMediaElement::bufferingRate): (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): (WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::progressEventTimerFired): (WebCore::HTMLMediaElement::seek): (WebCore::HTMLMediaElement::currentTime): (WebCore::HTMLMediaElement::duration): (WebCore::HTMLMediaElement::playbackRate): (WebCore::HTMLMediaElement::setPlaybackRate): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause): (WebCore::HTMLMediaElement::setVolume): (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::pickMedia): (WebCore::HTMLMediaElement::checkIfSeekNeeded): (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): (WebCore::HTMLMediaElement::mediaPlayerCuePointReached): (WebCore::HTMLMediaElement::addCuePoint): (WebCore::HTMLMediaElement::buffered): (WebCore::HTMLMediaElement::seekable): (WebCore::HTMLMediaElement::effectiveStart): (WebCore::HTMLMediaElement::effectiveEnd): (WebCore::HTMLMediaElement::effectiveLoopStart): (WebCore::HTMLMediaElement::effectiveLoopEnd): (WebCore::HTMLMediaElement::updateMediaPlayer): (WebCore::HTMLMediaElement::willSaveToCache):
html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::player):
html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::videoWidth): (WebCore::HTMLVideoElement::videoHeight):
platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedMediaMIMETypes): (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType): (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
platform/MIMETypeRegistry.h:
platform/graphics/MediaPlayer.cpp: Copied from WebCore/platform/graphics/Movie.cpp. (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::~MediaPlayer): (WebCore::MediaPlayer::load): (WebCore::MediaPlayer::cancelLoad): (WebCore::MediaPlayer::play): (WebCore::MediaPlayer::pause): (WebCore::MediaPlayer::duration): (WebCore::MediaPlayer::currentTime): (WebCore::MediaPlayer::seek): (WebCore::MediaPlayer::paused): (WebCore::MediaPlayer::seeking): (WebCore::MediaPlayer::naturalSize): (WebCore::MediaPlayer::hasVideo): (WebCore::MediaPlayer::networkState): (WebCore::MediaPlayer::readyState): (WebCore::MediaPlayer::volume): (WebCore::MediaPlayer::setVolume): (WebCore::MediaPlayer::rate): (WebCore::MediaPlayer::setRate): (WebCore::MediaPlayer::muted): (WebCore::MediaPlayer::setMuted): (WebCore::MediaPlayer::dataRate): (WebCore::MediaPlayer::setEndTime): (WebCore::MediaPlayer::addCuePoint): (WebCore::MediaPlayer::removeCuePoint): (WebCore::MediaPlayer::clearCuePoints): (WebCore::MediaPlayer::maxTimeBuffered): (WebCore::MediaPlayer::maxTimeSeekable): (WebCore::MediaPlayer::bytesLoaded): (WebCore::MediaPlayer::totalBytesKnown): (WebCore::MediaPlayer::totalBytes): (WebCore::MediaPlayer::setRect): (WebCore::MediaPlayer::visible): (WebCore::MediaPlayer::setVisible): (WebCore::MediaPlayer::paint): (WebCore::MediaPlayer::getSupportedTypes): (WebCore::MediaPlayer::networkStateChanged): (WebCore::MediaPlayer::readyStateChanged): (WebCore::MediaPlayer::volumeChanged): (WebCore::MediaPlayer::timeChanged): (WebCore::MediaPlayer::cuePointReached):
platform/graphics/MediaPlayer.h: Copied from WebCore/platform/graphics/Movie.h. (WebCore::MediaPlayerClient::~MediaPlayerClient): (WebCore::MediaPlayerClient::mediaPlayerNetworkStateChanged): (WebCore::MediaPlayerClient::mediaPlayerReadyStateChanged): (WebCore::MediaPlayerClient::mediaPlayerVolumeChanged): (WebCore::MediaPlayerClient::mediaPlayerTimeChanged): (WebCore::MediaPlayerClient::mediaPlayerCuePointReached):
platform/graphics/Movie.cpp: Removed.
platform/graphics/Movie.h: Removed.
platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Copied from WebCore/platform/graphics/gtk/MoviePrivateGStreamer.cpp. (WebCore::mediaPlayerPrivateErrorCallback): (WebCore::mediaPlayerPrivateEOSCallback): (WebCore::mediaPlayerPrivateStateCallback): (WebCore::mediaPlayerPrivateBufferingCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause): (WebCore::MediaPlayerPrivate::duration): (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::setEndTime): (WebCore::MediaPlayerPrivate::addCuePoint): (WebCore::MediaPlayerPrivate::removeCuePoint): (WebCore::MediaPlayerPrivate::clearCuePoints): (WebCore::MediaPlayerPrivate::startCuePointTimerIfNeeded): (WebCore::MediaPlayerPrivate::cancelSeek): (WebCore::MediaPlayerPrivate::cuePointTimerFired): (WebCore::MediaPlayerPrivate::paused): (WebCore::MediaPlayerPrivate::seeking): (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::hasVideo): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::dataRate): (WebCore::MediaPlayerPrivate::networkState): (WebCore::MediaPlayerPrivate::readyState): (WebCore::MediaPlayerPrivate::maxTimeBuffered): (WebCore::MediaPlayerPrivate::maxTimeSeekable): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::bytesLoaded): (WebCore::MediaPlayerPrivate::totalBytesKnown): (WebCore::MediaPlayerPrivate::totalBytes): (WebCore::MediaPlayerPrivate::cancelLoad): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::loadStateChanged): (WebCore::MediaPlayerPrivate::rateChanged): (WebCore::MediaPlayerPrivate::sizeChanged): (WebCore::MediaPlayerPrivate::timeChanged): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::loadingFailed): (WebCore::MediaPlayerPrivate::setRect): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::getSupportedTypes): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: Copied from WebCore/platform/graphics/gtk/MoviePrivateGStreamer.h.
platform/graphics/gtk/MoviePrivateGStreamer.cpp: Removed.
platform/graphics/gtk/MoviePrivateGStreamer.h: Removed.
platform/graphics/mac/MediaPlayerPrivateQTKit.h: Copied from WebCore/platform/graphics/mac/MoviePrivateQTKit.h.
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Copied from WebCore/platform/graphics/mac/MoviePrivateQTKit.mm. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::createQTMovie): (WebCore::MediaPlayerPrivate::createQTMovieView): (WebCore::MediaPlayerPrivate::createQTTime): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause): (WebCore::MediaPlayerPrivate::duration): (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::doSeek): (WebCore::MediaPlayerPrivate::cancelSeek): (WebCore::MediaPlayerPrivate::seekTimerFired): (WebCore::MediaPlayerPrivate::setEndTime): (WebCore::MediaPlayerPrivate::addCuePoint): (WebCore::MediaPlayerPrivate::removeCuePoint): (WebCore::MediaPlayerPrivate::clearCuePoints): (WebCore::MediaPlayerPrivate::startCuePointTimerIfNeeded): (WebCore::MediaPlayerPrivate::cuePointTimerFired): (WebCore::MediaPlayerPrivate::paused): (WebCore::MediaPlayerPrivate::seeking): (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::hasVideo): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::dataRate): (WebCore::MediaPlayerPrivate::networkState): (WebCore::MediaPlayerPrivate::readyState): (WebCore::MediaPlayerPrivate::maxTimeBuffered): (WebCore::MediaPlayerPrivate::maxTimeSeekable): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::bytesLoaded): (WebCore::MediaPlayerPrivate::totalBytesKnown): (WebCore::MediaPlayerPrivate::totalBytes): (WebCore::MediaPlayerPrivate::cancelLoad): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::loadStateChanged): (WebCore::MediaPlayerPrivate::rateChanged): (WebCore::MediaPlayerPrivate::sizeChanged): (WebCore::MediaPlayerPrivate::timeChanged): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::setRect): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::getSupportedTypes): (-[WebCoreMovieObserver initWithCallback:WebCore::]):
platform/graphics/mac/MoviePrivateQTKit.h: Removed.
platform/graphics/mac/MoviePrivateQTKit.mm: Removed.
rendering/RenderMedia.cpp: (WebCore::RenderMedia::player):
rendering/RenderMedia.h:
rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo): (WebCore::RenderVideo::~RenderVideo): (WebCore::RenderVideo::videoSizeChanged): (WebCore::RenderVideo::paintReplaced): (WebCore::RenderVideo::layout): (WebCore::RenderVideo::updateFromElement): (WebCore::RenderVideo::updatePlayer):
rendering/RenderVideo.h:

10:26 AM HackingGtk edited by alp@atoker.com

Add a link to the GStreamer video backend code (diff)

10:01 AM Changeset in webkit [28486] by ggaren@apple.com

2 edits in trunk/WebCore

Build fix: access global object directly.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::bindingInstance):

4:20 AM Changeset in webkit [28485] by mrowe@apple.com

2 edits in trunk/WebCore

Fix bug spotted by GCC 4.2. Remove extraneous semicolon that completely changed the meaning of allowPopUp.

Reviewed by Eric.

1:26 AM Changeset in webkit [28484] by alp@webkit.org

16 edits in trunk

2007-12-06 Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16173
Licensing change

Change license from BSD to LGPL.

Dec 5, 2007:

11:40 PM Changeset in webkit [28483] by rwlbuis@webkit.org

10 edits
4 adds in trunk

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=15289
WebKit does not respect clip paths of a 0x0 rect

Make empty clip paths clip the whole referencing graphic.

10:25 PM Changeset in webkit [28482] by Darin Adler

4 edits in trunk/WebCore

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=16266 <rdar://problem/5625279> REGRESSION: crash loading CNN.com at Interpreter::createObjectsForGlobalObjectProperties()

I don't know how to reproduce this in a test.

bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark): Call JSEventTargetNode::mark instead of DOMObject::mark. There's no difference right now, but it's best to call your base class, not your base's base.

bindings/js/kjs_events.h: Removed unneeded virtual from the JSUnprotectedEventListener::mark() function; it neither derives from or is derived from anyone else with a mark() function so there's no need for virtual.

bindings/js/kjs_window.cpp: (KJS::Window::mark): Call JSGlobalObject::mark, not JSObject::mark. This is the actual bug fix.

9:42 PM Changeset in webkit [28481] by alp@webkit.org

3 edits in trunk/WebCore

2007-12-05 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>

http://bugs.webkit.org/show_bug.cgi?id=16145
[gtk] Implement media support in GTK backend

Reviewed by Alp Toker.

Remove old comments, fix variable names, match WebKit coding style.

platform/graphics/gtk/MoviePrivateGStreamer.cpp: (WebCore::moviePrivateEOSCallback): (WebCore::MoviePrivate::MoviePrivate): (WebCore::MoviePrivate::load): (WebCore::MoviePrivate::play): (WebCore::MoviePrivate::pause): (WebCore::MoviePrivate::currentTime): (WebCore::MoviePrivate::seek): (WebCore::MoviePrivate::cancelSeek): (WebCore::MoviePrivate::seeking): (WebCore::MoviePrivate::naturalSize): (WebCore::MoviePrivate::setVolume): (WebCore::MoviePrivate::setMuted): (WebCore::MoviePrivate::maxTimeBuffered): (WebCore::MoviePrivate::bytesLoaded): (WebCore::MoviePrivate::totalBytesKnown): (WebCore::MoviePrivate::totalBytes): (WebCore::MoviePrivate::updateStates): (WebCore::MoviePrivate::didEnd): (WebCore::MoviePrivate::paint): (WebCore::MoviePrivate::createGSTPlayBin):
platform/graphics/gtk/MoviePrivateGStreamer.h:

9:37 PM Changeset in webkit [28480] by mrowe@apple.com

2 edits in trunk/WebCore

Speculative wx build fix. Add PlugInInfoStore::pluginNameForMIMEType to the temporary link stubs.

9:25 PM Changeset in webkit [28479] by mrowe@apple.com

3 edits in trunk/JavaScriptCore

Qt Windows build fix. Include the time-related headers in the correct place.

9:22 PM Changeset in webkit [28478] by Darin Adler

2 edits in trunk/JavaScriptCore

Not reviewed; just undoing a previous commit.

remove earlier incorrect fix for http://bugs.webkit.org/show_bug.cgi?id=16220 <rdar://problem/5625221> Crash opening www.news.com (CNet)

The real bug was the backwards ?: in the compile function, which Geoff just
fixed. Rolling out the incorrect earlier fix.

pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags): Take out the unneeded preflight change. The regression test proves this is still working fine, so the bug remains fixed.

9:13 PM Changeset in webkit [28477] by alp@webkit.org

2 edits in trunk/WebCore

2007-12-05 Alp Toker <alp@atoker.com>

Rubber stamped by Mark Rowe.

Remove DEPENDPATH on the generated sources directory. This causes
trouble and is no longer necessary following the glib-genmarshal
generator split.

WebCore.pro:

8:14 PM Changeset in webkit [28476] by mrowe@apple.com

7 edits in trunk/JavaScriptCore

Build fix. Include headers before trying to use the things that they declare.

7:11 PM Changeset in webkit [28475] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added some #includes.

kjs/JSImmediate.cpp:

7:07 PM Changeset in webkit [28474] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Build fix: added some #includes.

kjs/JSGlobalObject.cpp:
kjs/JSImmediate.cpp:

7:02 PM Changeset in webkit [28473] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: Fixed #include spelling.

kjs/debugger.cpp:

6:57 PM Changeset in webkit [28472] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added #include.

kjs/debugger.cpp:

6:51 PM Changeset in webkit [28471] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added a forward declaration.

kjs/debugger.h:

6:47 PM Changeset in webkit [28470] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added an #include.

kjs/error_object.cpp:

6:41 PM Changeset in webkit [28469] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added an #include.

kjs/bool_object.cpp:

6:31 PM Changeset in webkit [28468] by ggaren@apple.com

109 edits
5 adds in trunk

JavaScriptCore:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and
functions accessing data members from Interpreter to JSGlobalObject.
Changed Interpreter member functions to static functions.

This resolves a bug in global object bootstrapping, where the global
ExecState could be used when uninitialized.

This is a big change, but it's mostly code motion and renaming.

Layout and JS tests, and testjsglue and testapi, pass. SunSpider reports
a .7% regression, but Shark sees no difference related to this patch,
and SunSpider reported a .7% speedup from an earlier step in this
refactoring, so I think it's fair to call that a wash.

JavaScriptGlue:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject. Replaced JSInterpreter
subclass with JSGlobalObject subclass.

JSRun.cpp: (JSRun::JSRun): (JSRun::Evaluate): (JSRun::CheckSyntax):
JSRun.h: (JSGlueGlobalObject::JSGlueGlobalObject):
JSUtils.cpp: (KJSValueToCFTypeInternal):
JSValueWrapper.cpp: (getThreadGlobalExecState):

WebCore:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject. Changed Interpreter
member functions to static functions. Same for the subclass,
ScriptInterpreter.

This is a big change, but it's mostly code motion and renaming.

WebKit/mac:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject.

WebView/WebFrame.mm: (-[WebFrame _attachScriptDebugger]):

WebKit/win:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject.

WebFrame.cpp: (WebFrame::globalContext): (WebFrame::attachScriptDebugger): (WebFrame::windowObjectCleared):
WebScriptDebugger.cpp: (WebScriptDebugger::WebScriptDebugger):

5:37 PM Changeset in webkit [28467] by alice.liu@apple.com

3 edits in trunk/LayoutTests

Reviewed by Antti.

Addressed <rdar://problem/5137284> fast/events/mouseout-dead-node.html fails on boomer

fast/events/mouseout-dead-node.html: Changed the questionable calls to mouseUp() to mouseMoveTo() to better simulate mouseovers
platform/win/Skipped: removed this test from skipped file

5:36 PM Changeset in webkit [28466] by sfalken@apple.com

2 edits in trunk/WebKit/win

<rdar://problem/5625327> Crash toggling check grammar w/ spelling when no spell checker exists.

Reviewed by Adam.

WebView.cpp: (WebView::setGrammarCheckingEnabled): Add null check

4:56 PM Changeset in webkit [28465] by Adam Roben

2 edits in trunk/LayoutTests

platform/win/Skipped: Add a crashing test.

4:33 PM Changeset in webkit [28464] by Darin Adler

2 edits in trunk/WebCore

"Reviewed" by Geoff.

loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Removed assertion. (WebCore::FrameLoader::dispatchDidCommitLoad): This one too. The assertions are firing like crazy. Not sure why yet.

4:03 PM Changeset in webkit [28463] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler. (Or vice versa.)

Fixed ASSERT during run-javascriptcore-tests. (Darin just added the
ASSERT, but the bug wasn't new.)

pcre/pcre_compile.cpp: (compile_branch): The ?: operator here was backwards, causing us to execute the loop too many times, adding stray KET opcodes to the compiled regular expression.

3:56 PM BuildBot edited by Adam Roben

Add a note about the just-in-time debugger registry key on Windows (diff)

3:34 PM Changeset in webkit [28462] by andersca@apple.com

2 edits in trunk/WebKitTools

Make the entry points extern "C".

DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:

2:58 PM Changeset in webkit [28461] by Darin Adler

2 edits in trunk/WebCore

Reviewed by Adam Roben.

fix http://bugs.webkit.org/show_bug.cgi?id=16306 Assertion failed in WebCore/loader/FrameLoader.cpp:4642

loader/FrameLoader.cpp: (WebCore::FrameLoader::dispatchDidCommitLoad): Check m_creatingInitialEmptyDocument and don't deliver the client call in that case.

2:57 PM Changeset in webkit [28460] by andersca@apple.com

2 edits in trunk/WebKitTools

C++ warning fixes.

DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_Destroy): (NPP_SetWindow): (NPP_NewStream): (NPP_HandleEvent): (NPP_URLNotify): (NPP_GetValue):

2:54 PM Changeset in webkit [28459] by andersca@apple.com

2 edits in trunk/WebKitTools

Add the .cpp files to the TestNetscapePlugIn target.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

2:48 PM Changeset in webkit [28458] by kmccullough@apple.com

3 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Wait until local variable data is fully constructed before notifying the debugger of entering or leaving a call frame.

kjs/function.cpp: (KJS::FunctionImp::callAsFunction):
kjs/nodes.cpp: (KJS::FunctionBodyNode::execute):

2:42 PM Changeset in webkit [28457] by andersca@apple.com

3 edits
3 moves in trunk/WebKitTools

Reviewed by Geoff.

Rename the TestNetscapePlugIn .c files to be .cpp.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:

2:30 PM Changeset in webkit [28456] by mrowe@apple.com

2 edits in trunk/WebCore

Fix 64-bit debug build.

Reviewed by Kevin Decker.

platform/text/mac/TextCodecMac.cpp:

(WebCore::TextCodecMac::decode): OSStatus is a long for 32-bit but int on 64-bit,
so we need to cast it to be able to use a single format specifier on both.

2:29 PM Changeset in webkit [28455] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Build fix for GCC 4.2. Cast via a union to avoid strict-aliasing issues.

Reviewed by Oliver.

2:27 PM Changeset in webkit [28454] by Adam Roben

2 edits in trunk/LayoutTests

platform/win/Skipped: Add another test failing due to fonts.

2:24 PM Changeset in webkit [28453] by Adam Roben

2 edits in trunk/WebKitTools

Fix case of keypresses from the Windows implementation of eventSender.keyDown

This fixes several regression tests.

Reviewed by Alice.

DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Virtual keycodes for ASCII characters are always uppercase, so we need to check the case of the original character passed in to eventSender.keyDown.

2:08 PM Changeset in webkit [28452] by kdecker@apple.com

1 edit in trunk/WebCore/ChangeLog

Corrected a Radar number in my previous ChangeLog entry.

1:51 PM Changeset in webkit [28451] by kdecker@apple.com

2 edits in trunk/WebCore

Reviewed by Hyatt.

<rdar://problem/5602071> Safari displays each pixel of 300 dpi US Patent TIFF Images, making them extremely large

loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldUsePlugin): Allow plug-ins (with the exception of QuickTime) to takeover TIFF once again.

1:48 PM Changeset in webkit [28450] by timothy@apple.com

1 edit
1 add in trunk/WebKitSite

Add another Inspector screenshot for an upcoming blog post.

blog-files/InspectorDatabaseBrowser.png: Added.

1:16 PM Changeset in webkit [28449] by mrowe@apple.com

3 edits in trunk/JavaScriptCore

Fix testkjs in 64-bit.

When built for 64-bit the TCMalloc spin lock uses pthread mutexes rather than a custom spin lock
implemented in assembly. If we fail to initialize the pthread mutex, attempts to lock or unlock
it will fail and trigger a call to abort.

Reviewed by Darin.

wtf/FastMalloc.cpp: Initialize the spin lock so that we can later lock and unlock it.
wtf/TCSpinLock.h: Add an Init method to the optimised spin lock.

1:12 PM HackingGtk edited by alp@atoker.com

Mention bundled code (diff)

12:26 PM Changeset in webkit [28448] by alp@webkit.org

2 edits in trunk/WebCore

2007-12-05 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16290
[GTK] Pasting clipboard in rich text.

platform/gtk/PasteboardGtk.cpp: (Pasteboard::documentFragment): Implement rich text paste support.

12:10 PM Changeset in webkit [28447] by adele@apple.com

2 edits in trunk/WebCore

Reviewed by Hyatt.

Reverting fix for <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges

We need to just fix the underlying focus ring repaint problem.

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle):

12:01 PM Changeset in webkit [28446] by kmccullough@apple.com

4 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://5621435>
Security Fix. Instead of having it off by default, WebKit now must explicitly turn off local-resource restriction when needed for backwards compatibility reasons.

loader/FrameLoader.cpp:

WebKit/mac:

Reviewed by Darin.

<rdar://5621435>
Security Fix. Instead of having it off by default, WebKit now must explicitly turn off local-resource restriction when needed for backwards coimpatibility reasons.

WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]):

11:38 AM Changeset in webkit [28445] by Adam Roben

5 edits in trunk/WebKit/win

Expose WebView::setProhibitsMainFrameScrolling through IWebViewPrivate

Reviewed by Steve.

Interfaces/IWebViewPrivate.idl: Added declaration.
WebInspectorClient.cpp: (WebInspectorClient::createPage): Updated for change to setProhibitsMainFrameScrolling signature.
WebView.cpp: (WebView::setProhibitsMainFrameScrolling): Updated and robustified.
WebView.h:

11:36 AM Changeset in webkit [28444] by Adam Roben

2 edits in trunk/WebCore

Set the menu item identifier for all menu items

This allows WebKit clients to distinguish between submenus in the
context menu.

Reviewed by Darin.

No test possible.

platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::ContextMenuItem):

10:51 AM Changeset in webkit [28443] by Adam Roben

2 edits in trunk/WebKitTools

Learn from Tim's mistakes

DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Reset the authorAndUserStylesEnabled preference for each test.

10:46 AM Changeset in webkit [28442] by mitz@apple.com

9 edits
3 adds in trunk

WebCore:

Reviewed by Darin Adler.

WebCore part of fixing <rdar://problem/5111082> Flash popup video ad doesn't close when clicked at http://www.firestonecompleteautocare.com/

manual-tests/nested-plug-ins.html: Added.
manual-tests/resources/nested-plug-ins-inner-frame.html: Added.
manual-tests/resources/nested-plug-ins-outer-frame.html: Added.
platform/ScrollView.h:
platform/Widget.h: (WebCore::Widget::attachToWindow): Added. Tells the widget that it is connected via visible ScrollViews to the root ScrollView of the WebView. (WebCore::Widget::detachFromWindow): Added. Tells the widget that it is no longer connected via visible ScrollViews to the root ScrollView of the WebView.
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): Added m_visible and m_attachedToWindow members. (WebCore::ScrollView::attachToWindow): Added. Attaches all children if this view is visible. (WebCore::ScrollView::detachFromWindow): Added. Detaches all children if this view is visible (otherwise they would be detached already). (WebCore::ScrollView::show): Added. Attaches all children if this view is attached. (WebCore::ScrollView::hide): Added. Detaches all children if this view is attached (otherwise they would be detached already). (WebCore::ScrollView::isAttachedToWindow): Added.
platform/win/WidgetWin.cpp: (WebCore::Widget::setParent): Added calls to attachToWindow() and detachFromWindow() depending on whether the parent is set and attached or not.
plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFocus): (WebCore::PluginViewWin::show): Changed to show the plug-in only if this view is attached. (WebCore::PluginViewWin::hide): Changed to hide the plug-in only if this view is attached (otherwise it would be hidden already). (WebCore::PluginViewWin::attachToWindow): Added. Shows the plug-in if this view is visible. (WebCore::PluginViewWin::detachFromWindow): Added. Hides the plug-in if this view is visible (otherwise it would be hidden already). (WebCore::PluginViewWin::PluginViewWin):
plugins/win/PluginViewWin.h: Added m_attachedToWindow member.

WebKit/win: