Context Navigation

← Previous Period
Next Period →

Timeline

Dec 9, 2007:

10:22 PM Changeset in webkit [28578] by Darin Adler

4 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

fix http://bugs.webkit.org/show_bug.cgi?id=16369 REGRESSION (r28525): regular expression tests failing due to bad firstByte optimization

pcre/pcre_compile.cpp: Changed some names to use interCaps intead of under_scores. (branchIsAnchored): Broke is_anchored into two separate functions; this one works on a branch and the other on an anchor. The old function would only work on a bracket. Also removed unneeded parameters; the anchored check does not require the bracket map or the options any more because we have a reduced set of features. (bracketIsAnchored): Ditto. (branchNeedsLineStart): Broke canApplyFirstCharOptimization into two functions and gave both a better name. This is the function that was returning the wrong value. The failure was beacuse the old function would only work on a bracket. (bracketNeedsLineStart): Ditto. (jsRegExpCompile): Changed to call the appropriate branch or bracket flavor of the functions based on whether we compiled an outer bracket. Also removed inaccurate comments and unneeded parameters.

other small changes

pcre/pcre.h: Renumbered error codes, in a logical order. First, normal failure, then the recursion limit, then running out of memory, and finally an unexpected internal error.

pcre/pcre_exec.cpp: Fixed indentation. (jsRegExpExecute): Corrected an inaccurate comment.

8:05 PM Changeset in webkit [28577] by Darin Adler

7 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=16370 REGRESSION (r28540): source URL and line number no longer set for outer function/programs

Test: fast/js/exception-linenums-in-html-1.html
Test: fast/js/exception-linenums-in-html-2.html
Test: fast/js/exception-linenums.html

By the time the ProgramNode was constructed, the source URL was empty.

kjs/Parser.cpp: (KJS::Parser::parseProgram): Added code to set and clear m_sourceURL, which is now handled here instead of in the lexer; it needs to still be set when we create the program node. Call setLoc to set the first and last line number. (KJS::Parser::parseFunctionBody): Ditto, but for the body. (KJS::Parser::parse): Removed the sourceURL argument.

kjs/Parser.h: Added sourceURL(), m_sourceURL, and m_lastLine. Added a lastLine parameter to didFinishParsing, since the bison grammar knows the last line number and we otherwise do not know it. Removed the sourceURL parameter from parse, since that's now handled at a higher level.

kjs/grammar.y: Pass the last line number to didFinishParsing.

kjs/lexer.cpp: (KJS::Lexer::setCode): Removed the sourceURL argument and the code to set m_sourceURL. (KJS::Lexer::clear): Ditto.
kjs/lexer.h: More of the same.

kjs/nodes.cpp: (KJS::FunctionBodyNode::FunctionBodyNode): Get the source URL from the parser rather than from the lexer. Removed unneeded call to setLoc, since the line numbers already both default to -1.

7:33 PM Changeset in webkit [28576] by weinig@apple.com

2 edits in trunk/WebCore

Rubber stamped by Mark Rowe.

WebCore.xcodeproj/project.pbxproj: Add missing DerivedSources files.

5:12 PM Changeset in webkit [28575] by oliver@apple.com

4 edits in trunk

Need to read the spec properly.

Reviewed by Niko

Correction, 'z' and 'Z' are the only commands that cannot have an extended
list of arguments.

4:44 PM Changeset in webkit [28574] by oliver@apple.com

5 edits in trunk

Prevent unlimited iteration in the case of invalid path data.

Reviewed by Niko.

The only path commands that can leave numbers trailing the command processing
are 'm' and 'M', in which trailing numbers are parsed as arguments to an
implicit lineto command. In any case we should just terminate as an invalid
path.

1:52 PM Changeset in webkit [28573] by alp@webkit.org

3 edits in trunk/WebCore

2007-12-09 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=15825
[GTK] curl - slow dns causing hangs.

Create a vector of jobs, to satisfy requests in the right order.
Set a limit to the number of simultaneous connections.

platform/network/curl/ResourceHandleManager.cpp: (WebCore::maxRunningJobs): added (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::removeFromCurl): (WebCore::ResourceHandleManager::startScheduledJobs):

platform/network/curl/ResourceHandleManager.h: (WebCore::ResourceHandleList): removed (WebCore::ResourceHandleManager::m_runningJobs): added (WebCore::ResourceHandleManager::m_resourceHandleListHead): removed (WebCore::ResourceHandleManager::m_resourceHandleList): added

10:49 AM UsingGitWithWebKit edited by waameukee@schitterendedingen.com

(diff)

Dec 8, 2007:

11:56 PM Changeset in webkit [28572] by weinig@apple.com

3 edits in trunk/WebCore

Reviewed by Oliver.

Cleanup kjs_window.h/cpp.

bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::DOMWindowTimer::DOMWindowTimer): (KJS::Window::Window): (KJS::Window::retrieveWindow): (KJS::Window::retrieveActive): (KJS::Window::retrieve): (KJS::Window::location): (KJS::Window::mark): (KJS::allowPopUp): (KJS::parseModalDialogFeatures): (KJS::floatFeature): (KJS::canShowModalDialog): (KJS::canShowModalDialogNow): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::Window::getOwnPropertySlot): (KJS::Window::globalExec): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::Window::findOrCreateJSEventListener): (KJS::Window::findOrCreateJSUnprotectedEventListener): (KJS::Window::clearHelperObjectProperties): (KJS::Window::setCurrentEvent): (KJS::WindowProtoFuncAToB::callAsFunction): (KJS::WindowProtoFuncBToA::callAsFunction): (KJS::WindowProtoFuncOpen::callAsFunction): (KJS::WindowProtoFuncSetTimeout::callAsFunction): (KJS::WindowProtoFuncClearTimeout::callAsFunction): (KJS::WindowProtoFuncSetInterval::callAsFunction): (KJS::WindowProtoFuncAddEventListener::callAsFunction): (KJS::WindowProtoFuncRemoveEventListener::callAsFunction): (KJS::WindowProtoFuncShowModalDialog::callAsFunction): (KJS::WindowProtoFuncNotImplemented::callAsFunction):
bindings/js/kjs_window.h: (KJS::PausedTimeouts::PausedTimeouts): (KJS::PausedTimeouts::takeTimeouts): (KJS::ScheduledAction::ScheduledAction):

11:48 PM Changeset in webkit [28571] by weinig@apple.com

2 edits in trunk/LayoutTests

Rubber-stamped by Adam Roben.

fast/dom/Window/window-resize-and-move-arguments.html: Make the window small enough that this test won't fail on systems with lower resolutions.

4:47 PM Changeset in webkit [28570] by weinig@apple.com

10 edits
4 adds in trunk

WebCore:

Reviewed by Mitz.

Move window scrolling, moving and resizing methods from KJS::Window
to WebCore::DOMWindow so that there bindings can be autogenerated.

Tests: fast/dom/Window/window-resize-and-move-arguments.html

fast/dom/Window/window-scroll-arguments.html

WebCore.xcodeproj/project.pbxproj:
bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): Remove extraneous allowsAccessFrom check. (KJS::WindowProtoFuncOpen::callAsFunction): (KJS::WindowProtoFuncNotImplemented::callAsFunction): Remove extraneous allowsAccessFrom check.
bindings/js/kjs_window.h:
bindings/scripts/CodeGeneratorJS.pm: Add new extended attribute to ensure that the no less than the declared number of attributes is allowed.
page/DOMWindow.cpp: (WebCore::DOMWindow::adjustWindowRect): Moved from kjs_window. (WebCore::DOMWindow::scrollBy): (WebCore::DOMWindow::scrollTo): (WebCore::DOMWindow::moveBy): (WebCore::DOMWindow::moveTo): (WebCore::DOMWindow::resizeBy): (WebCore::DOMWindow::resizeTo):
page/DOMWindow.h: (WebCore::DOMWindow::scroll):
page/DOMWindow.idl:

LayoutTests:

Reviewed by Sam W.

Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.

Fixes <rdar://problem/5620249> Must disable SVG animation
<rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior

These layout test changes are caused by some of the experimental
features no longer being enabled by default.

fast/dom/Window/window-properties-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
platform/mac/svg/custom/empty-merge-expected.txt:
platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
platform/mac/svg/custom/filter-source-alpha-expected.txt:
platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
platform/mac/svg/custom/invalid-css-expected.txt:
platform/mac/svg/custom/non-opaque-filters-expected.txt:
platform/mac/svg/custom/text-filter-expected.txt:
platform/mac/svg/custom/visibility-override-filter-expected.txt:
svg/batik/filters/filterRegions-expected.txt:
svg/batik/text/textEffect-expected.txt:
svg/batik/text/textEffect3-expected.txt:
svg/batik/text/textFeatures-expected.txt:
svg/batik/text/textProperties-expected.txt:
svg/custom/js-svg-constructors-expected.txt:
svg/dom/font-face-elements-expected.txt:
svg/webarchive/svg-feimage-subresources-expected.txt:

4:32 PM Changeset in webkit [28569] by alp@webkit.org

3 edits in trunk/WebCore

2007-12-08 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=14651
[CURL] didReceiveResponse() only called for HTTP loads

http://bugs.webkit.org/show_bug.cgi?id=14583
[GDK] file:// relative CSS include URLs handled incorrectly

Make sure CURL sets the ResourceResponse URL and calls
didReceiveResponse for local files too.

platform/network/curl/ResourceHandleManager.cpp: (WebCore::writeCallback):

4:27 PM Changeset in webkit [28568] by oliver@apple.com

241 edits
2 adds in trunk

Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.

Reviewed by Sam W.

Fixes <rdar://problem/5620249> Must disable SVG animation

<rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior

In order to allow finer grained control over the set of SVG features
this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
distinct flags:

ENABLE_SVG_ANIMATION
ENABLE_SVG_FILTERS
ENABLE_SVG_FONTS
ENABLE_SVG_AS_IMAGE
ENABLE_SVG_USE

by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.

4:19 PM BuildingGtk edited by andi5.py@gmx.net

apt-get typo (diff)

3:45 PM Changeset in webkit [28567] by mitz@apple.com

4 edits
6 adds in trunk

WebCore:

Reviewed by Adele Peterson.

fix two bugs in parsing of stylesheets in <style> elements created by the parser:
1. each such stylesheet is parsed twice, once when the text node is added and again when the </style> tag is reached
2. re-inserting such a <style> element into the document fails to re-parse and apply its stylesheet.

Test for bug #2: fast/dom/HTMLStyleElement/insert-parser-generated.html

html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::finishedParsing):
svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::finishedParsing):

LayoutTests:

Reviewed by Adele Peterson.

test that re-inserting a parser-generated <style> element applies its sylesheet.

fast/dom/HTMLStyleElement: Added.
fast/dom/HTMLStyleElement/insert-parser-generated.html: Added.
platform/mac/fast/dom/HTMLStyleElement: Added.
platform/mac/fast/dom/HTMLStyleElement/insert-parser-generated-expected.checksum: Added.
platform/mac/fast/dom/HTMLStyleElement/insert-parser-generated-expected.png: Added.
platform/mac/fast/dom/HTMLStyleElement/insert-parser-generated-expected.txt: Added.

1:02 PM Changeset in webkit [28566] by weinig@apple.com

1 edit in trunk/JavaScriptCore/ChangeLog

Fix ChangeLog

10:03 AM Changeset in webkit [28565] by weinig@apple.com

10 edits in trunk

JavaScriptCore:

Reviewed by Darin.

Rename isSafeScript to allowsAccess.

bindings/NP_jsobject.cpp: (_isSafeScript):
kjs/JSGlobalObject.h: (KJS::JSGlobalObject::allowsAccessFrom): Reverse caller/argument of allowsAccessFrom to match the new call.

WebCore:

Reviewed by Darin.

Removes the faulty isSafeScript implementation that was only used for plugins.
Renames isSafeScript to allowsAccessFrom.

bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): (WebCore::JSDOMWindow::customPut):
bindings/js/kjs_dom.cpp: (WebCore::checkNodeSecurity):
bindings/js/kjs_window.cpp: (KJS::createWindow): (KJS::Window::getValueProperty): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::Window::allowsAccessFrom): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::WindowProtoFuncOpen::callAsFunction): (KJS::WindowProtoFuncSetTimeout::callAsFunction): (KJS::WindowProtoFuncClearTimeout::callAsFunction): (KJS::WindowProtoFuncSetInterval::callAsFunction): (KJS::WindowProtoFuncAddEventListener::callAsFunction): (KJS::WindowProtoFuncRemoveEventListener::callAsFunction): (KJS::WindowProtoFuncNotImplemented::callAsFunction): (KJS::Location::getOwnPropertySlot): (KJS::Location::put): (KJS::LocationProtoFuncReplace::callAsFunction): (KJS::LocationProtoFuncReload::callAsFunction): (KJS::LocationProtoFuncAssign::callAsFunction): (KJS::LocationProtoFuncToString::callAsFunction):
bindings/js/kjs_window.h: (KJS::Window::allowsAccessFrom):
bindings/objc/WebScriptObject.mm: (-[WebScriptObject _isSafeScript]): Reverse caller/argument of allowsAccessFrom to match the new call.
bindings/scripts/CodeGeneratorJS.pm:

6:39 AM Changeset in webkit [28564] by alp@webkit.org

5 edits in trunk/WebKit/gtk

2007-12-08 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16346
[GTK] Some webview parts must use the focused frame.

Also update some old code.

WebView/webkitprivate.cpp: (getFrameFromView): removed

WebView/webkitprivate.h: (getFrameFromView): removed

WebView/webkitwebview.cpp: (webkit_web_view_expose_event): (webkit_web_view_key_press_event): use focused frame (webkit_web_view_key_release_event): use focused frame (webkit_web_view_button_press_event): (webkit_web_view_button_release_event): (webkit_web_view_motion_event): (webkit_web_view_scroll_event): (webkit_web_view_size_allocate): (webkit_web_view_set_scroll_adjustments): (webkit_web_view_execute_script): (webkit_web_view_stop_loading): (webkit_web_view_load_string): (webkit_web_view_reload): (webkit_web_view_open): (webkit_web_view_can_go_forward): (webkit_web_view_can_go_backward): (webkit_web_view_go_forward): (webkit_web_view_go_backward):