Context Navigation

All back/forward list and page cache related items used to be in WebKit.
When they were pushed into WebCore, some sloppy compromises were made to keep the Back/Forward cache working on Mac.
Namely, a WebCore::HistoryItem had to know how to keep a WebDocumentView alive. We accomplished this via some #ifdefs
in CachedPage and having the Mac-only CachedPageMac.mm

To get rid of that nastiness and pave the way for adding Back/Forward cache on other platforms, this patch adds the
concept of "CachedPagePlatformData" which can contain anything the platform API wants.

I also took the opportunity to do other cleanup and renaming client methods to better fit their new purposes.

WebCore.base.exp:
WebCore.xcodeproj/project.pbxproj:

history/CachedPage.cpp: (WebCore::CachedPage::~CachedPage): Combined "close()" and "clear()" to just "clear()" - call it from here. (WebCore::CachedPage::clear): Call clear() on the CachedPagePlatformData if it exists. Also delete the CachedPagePlatformData. (WebCore::CachedPage::setCachedPagePlatformData): (WebCore::CachedPage::cachedPagePlatformData):
history/CachedPage.h:

history/CachedPagePlatformData.h: Added. (WebCore::CachedPagePlatformData::~CachedPagePlatformData): Virtual d'tor. (WebCore::CachedPagePlatformData::clear): Virtual method for platforms that need to do cleanup at the same time as CachedPage::clear().

history/PageCache.cpp: (WebCore::PageCache::releaseAutoreleasedPagesNow): Call "clear()" instead of "close()"

history/mac/CachedPageMac.mm: Removed. Functionality replaced with CachedPagePlatformData.

loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted): Call the new client methods. Make some work previously done by WebKitMac cross platform (setting the cached DocumentLoader to the Frame). (WebCore::FrameLoader::cachePageForHistoryItem): Renamed the client methods

loader/FrameLoaderClient.h: The very Mac-centric "makeDocumentView", "setDocumentViewFromCachedPage", and "saveDocumentViewToCachedPage" become "transitionToCommittedForNewPage", "transitionToCommittedFromCachedPage", and "savePlatformDataToCachedPage" accordingly

svg/graphics/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::savePlatformDataToCachedPage): (WebCore::SVGEmptyFrameLoaderClient::transitionToCommittedFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::transitionToCommittedForNewPage):

WebKit:

Reviewed by Sam Weinig

Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)

WebKit.xcodeproj/project.pbxproj: Added a new file

WebKit/gtk:

Reviewed by Sam Weinig

As part of doing some CachedPage and client cleanup, keep GTK building

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::savePlatformDataToCachedPage): (WebKit::FrameLoaderClient::transitionToCommittedFromCachedPage): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

Reviewed by Sam Weinig

Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)

WebCoreSupport/WebCachedPagePlatformData.h: Added. (WebCachedPagePlatformData::WebCachedPagePlatformData): Constructor takes a WebDocumentView for later restoration (WebCachedPagePlatformData::clear): (WebCachedPagePlatformData::webDocumentView):

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::savePlatformDataToCachedPage): (WebFrameLoaderClient::transitionToCommittedFromCachedPage): Don't set the DocumentLoader to the Frame here, because that is now done in WebCore. (WebFrameLoaderClient::transitionToCommittedForNewPage):

WebKit/qt:

Reviewed by Sam Weinig

As part of doing some CachedPage and client cleanup, keep Qt building

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::savePlatformDataToCachedPage): (WebCore::FrameLoaderClientQt::transitionToCommittedFromCachedPage): (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

Reviewed by Sam Weinig

Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)

Even though this new code isn't exercised yet because the page cache is still turned off for Windows, local testing
has indicated it works well.

WebCachedPagePlatformData.h: Added. (WebCachedPagePlatformData::WebCachedPagePlatformData): Constructor takes an IWebDataSource and the object retains it (WebCachedPagePlatformData::clear): (WebCachedPagePlatformData::webDataSource):

WebFrame.cpp: (WebFrame::savePlatformDataToCachedPage): (WebFrame::transitionToCommittedFromCachedPage): (WebFrame::transitionToCommittedForNewPage):
WebFrame.h:

WebKit.vcproj/WebKit.vcproj:

WebKit/wx:

Reviewed by Sam Weinig

As part of doing some CachedPage and client cleanup, keep Wx building

WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::savePlatformDataToCachedPage): (WebCore::FrameLoaderClientWx::transitionToCommittedFromCachedPage): (WebCore::FrameLoaderClientWx::transitionToCommittedForNewPage):
WebKitSupport/FrameLoaderClientWx.h:

11:04 PM Changeset in webkit [28671] by mitz@apple.com

5 edits
2 moves in trunk

WebCore:

Reviewed by Oliver Hunt.

fix <rdar://problem/5074620> text with font:initial; fails to appear (causes fast/text/font-initial.html to fail)

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): When the font property is set to 'initial', set the font size to its initial value, 'medium', and the font family to the standard family.

LayoutTests:

Reviewed by Oliver Hunt.

updated results and skipped tests file for <rdar://problem/5074620> text with font:initial; fails to appear (causes fast/text/font-initial.html to fail)

platform/mac-leopard/fast/text/font-initial-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/font-initial-expected.checksum.
platform/mac-leopard/fast/text/font-initial-expected.png: Copied from LayoutTests/platform/mac/fast/text/font-initial-expected.png.
platform/mac/fast/text/font-initial-expected.checksum: Removed.
platform/mac/fast/text/font-initial-expected.png: Removed.
platform/mac/fast/text/font-initial-expected.txt:
platform/win/Skipped:

10:56 PM Changeset in webkit [28670] by justin.garcia@apple.com

3 edits
6 adds in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5433862> Mail crashes at WebCore::highestAncestor() when deleting a particular selection

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removePreviouslySelectedEmptyTableRows): Don't remove the table row that contained the end of the selection if it is where we are about to place the ending selection. Don't remove all empty rows after the row that contained the start of the selection, they might come after the row that contained the end of the selection.

LayoutTests:

Reviewed by Darin Adler.

<rdar://problem/5433862> Mail crashes at WebCore::highestAncestor() when deleting a particular selection

editing/deleting/5433862-1-expected.txt: Added.
editing/deleting/5433862-1.html: Added.
editing/deleting/5433862-2.html: Added.
platform/mac/editing/deleting/5433862-2-expected.checksum: Added.
platform/mac/editing/deleting/5433862-2-expected.txt: Added.

9:33 PM Changeset in webkit [28669] by mjs@apple.com

2 edits in trunk/SunSpider

Reviewed by Sam.

Change sunspider-compare-results output from showing "% faster" values to "x as fast" values.

A sample of what new-style results would look like:

TEST COMPARISON FROM TO DETAILS
...
TOTAL : 1.41x as fast 6613.6ms +/- 0.1% 4703.0ms +/- 0.1% significant
...

3bit-bits-in-byte: *1.36x as slow* 88.8ms +/- 0.6% 121.1ms +/- 0.6% significant

resources/sunspider-compare-results.js:

5:47 PM Changeset in webkit [28668] by weinig@apple.com

4 edits in trunk/WebCore

Reviewed by Anders Carlsson.

Add button to clear the Web Inspector's console.

English.lproj/InspectorLocalizedStrings.js:
page/inspector/ConsolePanel.js:
page/inspector/inspector.css:

4:44 PM Changeset in webkit [28667] by andersca@apple.com

4 edits in trunk/WebCore

Reviewed by Adam and Jon.

<rdar://problem/5349282>
popup blocking is not applied to plugins on Windows.

Implement popup blocking. If the plug-in supports the new
NPN_PushPopupsEnabledState/NPN_PopPopupsEnabledState API we just use that
to determine if a plug-in request can open new windows.

If a plug-in does not support the new API, we assume that a plug-in can open new windows
in response to either mouse click or key press events.

plugins/win/PluginViewWin.cpp: (WebCore::PluginRequestWin::PluginRequestWin): (WebCore::PluginRequestWin::shouldAllowPopups): Add new shouldAllowPopups member.

(WebCore::PluginViewWin::popPopupsStateTimerFired):
Reset the popup state.

(WebCore::isWindowsMessageUserGesture):
New function that given a windows message id returns whether it's a user gesture or not.

(WebCore::PluginViewWin::wndProc):
Allow popups if the window message is a user gesture.

(WebCore::PluginViewWin::dispatchNPEvent):
New method that dispatches an NPEvent, turning on popups if necessary.

(WebCore::PluginViewWin::paint):
(WebCore::PluginViewWin::handleKeyboardEvent):
(WebCore::PluginViewWin::handleMouseEvent):
Call dispatchNPEvent().

(WebCore::PluginViewWin::performRequest):
(WebCore::PluginViewWin::load):
Add calls to shouldAllowPopups().

(WebCore::PluginViewWin::pushPopupsEnabledState):
(WebCore::PluginViewWin::popPopupsEnabledState):
New methods that maintain the popup state stack.

(WebCore::PluginViewWin::arePopupsAllowed):
New method that returns whether popups are allowed.

(WebCore::PluginViewWin::PluginViewWin):

plugins/win/PluginViewWin.h: Add new instance variables.

plugins/win/npapi.cpp: (NPN_PushPopupsEnabledState): (NPN_PopPopupsEnabledState): Implement these.

4:23 PM Changeset in webkit [28666] by mitz@apple.com

4 edits
2 adds in trunk

WebCore:

Reviewed by John Sullivan.

fix a bug in debug builds only where selecting an earlier item in a popup selects the first item

Test: fast/forms/menulist-selection-reset.html

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcListItems): Added an argument that tells that function whether it should update the selected state of option elements. (WebCore::HTMLSelectElement::checkListItems): Changed to pass false as the above argument.
html/HTMLSelectElement.h:

LayoutTests:

Reviewed by John Sullivan.

test for a bug in debug builds only where selecting an earlier item in a popup selects the first item

fast/forms/menulist-selection-reset-expected.txt: Added.
fast/forms/menulist-selection-reset.html: Added.

4:02 PM Changeset in webkit [28665] by Beth Dakin

1 edit in trunk/LayoutTests/ChangeLog

OOPS!

3:56 PM Changeset in webkit [28664] by adele@apple.com

10 edits in trunk/WebCore

Reviewed by Geoff.

Fix for <rdar://problem/5643054> Remove cue point implementation for media elements

When the specification for cue ranges is more final, we will implement those.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::~HTMLMediaElement): (WebCore::HTMLMediaElement::load):
html/HTMLMediaElement.h:
html/HTMLMediaElement.idl:
platform/graphics/MediaPlayer.cpp:
platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerTimeChanged):
platform/graphics/mac/MediaPlayerPrivateQTKit.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause): (WebCore::MediaPlayerPrivate::setEndTime): (WebCore::MediaPlayerPrivate::startEndPointTimerIfNeeded): (WebCore::MediaPlayerPrivate::endPointTimerFired): (WebCore::MediaPlayerPrivate::timeChanged): (WebCore::MediaPlayerPrivate::didEnd):
platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::startEndPointTimerIfNeeded): (WebCore::MediaPlayerPrivate::endPointTimerFired):
platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

3:35 PM Changeset in webkit [28663] by Beth Dakin

1 edit
2 adds in trunk/LayoutTests

Reviewed by Nico.

Updated pixel results from my recent SVG change.

svg/custom/inline-svg-in-xhtml-expected.checksum: Added.
svg/custom/inline-svg-in-xhtml-expected.png: Added.

2:37 PM Changeset in webkit [28662] by oliver@apple.com

2 edits in trunk/WebCore

2007-12-12 MorganL <morganl.webkit@yahoo.com> -- http://bugs.webkit.org/show_bug.cgi?id=16408

Reviewed by Maciej.

Fixes:
http://bugs.webkit.org/show_bug.cgi?id=16408

When navigating back/forward to a http:// link, we should prefer to
load from cache if possible.

loader/FrameLoader.cpp:

2:15 PM Changeset in webkit [28661] by andersca@apple.com

8 edits
2 adds in trunk

WebCore:

Reviewed by Sam.

<rdar://problem/5132003>
dumpResourceLoadCallbacks is not implemented in DRT on Windows.

platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::unpackPlatformError): Handle kCFErrorDomainWinSock.

platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): Ignore willSendRequest calls where the redirect response is null, like we do in the Mac version.

WebKitTools:

Reviewed by Sam.

<rdar://problem/5132003>
dumpResourceLoadCallbacks is not implemented in DRT on Windows.

DumpRenderTree/win/DumpRenderTree.cpp: (main): Set the resource load delegate.

DumpRenderTree/win/DumpRenderTree.vcproj:

DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
DumpRenderTree/win/ResourceLoadDelegate.h: Added.

LayoutTests:

Reviewed by Sam.

<rdar://problem/5132003>
dumpResourceLoadCallbacks is not implemented in DRT on Windows.

Remove now passing tests.

platform/win/Skipped:

2:14 PM Changeset in webkit [28660] by sfalken@apple.com

2 edits in trunk/WebCore

<rdar://problem/5643785> Fix iBench regression caused by mis-placed nested timer check.

Reviewed by Anders.

platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc): Don't set high-resolution timer flag inside non-high-resolution timer proc.

1:46 PM Changeset in webkit [28659] by sfalken@apple.com

2 edits in trunk/WebKit/win

Build fix.

WebKit.vcproj/WebKit.make: Copy only what we need out of obj/bin.

1:24 PM Changeset in webkit [28658] by Beth Dakin

4 edits in trunk/WebCore

Reviewed by Oliver.

Fix for <rdar://problem/5643770> REGRESSION: Free-standing SVGs
with width and height 100% clip to 300 x 150

Though it was correct in an earlier iteration of my patch, it is
not sufficient in the final, committed version to ask if the
relativeWidthValue() or relativeHeightValue() is greater than 0
just to determine if one has been set, for, they are now
initialized to 300 and 150 respectively! This patch instead adds a
bool to keep track of whether a container size has been set, and
only used the relative value if it has.

rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcViewport):
svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement):
svg/SVGSVGElement.h: (WebCore::SVGSVGElement::setContainerSize): (WebCore::SVGSVGElement::hasSetContainerSize):

11:26 AM Changeset in webkit [28657] by beidson@apple.com

2 edits in trunk/WebCore

Reviewed by Steve Falkenburg

<rdar://problem/5012636> - WebURLProtectionSpace::realm returns the hostname rather than the authentication realm

platform/network/ProtectionSpace.cpp: (WebCore::ProtectionSpace::ProtectionSpace): Assign the realm to m_realm, instead of the host

9:57 AM Changeset in webkit [28656] by ap@webkit.org

4 edits in trunk

Reviewed by Adam Roben.

Fix conversion from double to LPARAM in dispatchMessage().

DumpRenderTree/win/EventSender.cpp: (dispatchMessageCallback):

9:34 AM Changeset in webkit [28655] by alp@webkit.org

2 edits in trunk/WebCore

2007-12-12 Alp Toker <alp@atoker.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=16388
[GTK] Widget::setCursor() gets called frequently

Cache the current cursor to avoid calling gdk_window_set_cursor() when
there's no change in cursor.

platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::cursor): (WebCore::Widget::setCursor):

9:27 AM Changeset in webkit [28654] by alp@webkit.org

3 edits in trunk/WebCore

2007-12-12 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=16342
Build Warning and Error fixes in WebCore GTK+

Use C-style casts for casting function pointers to gpointer
Use static_cast<int> to cast a float to int to fix a warning

platform/gtk/PlatformScrollBarGtk.cpp: (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::gtkValueChanged):
platform/gtk/ThreadingGtk.cpp: (callFunctionOnMainThread): (callOnMainThread):

8:59 AM Changeset in webkit [28653] by mitz@apple.com

4 edits in trunk

WebCore:

Reviewed by Darin Adler.

better fix for a crash when pressing a key that is not associated with a command

editing/EditorCommand.cpp: (WebCore::Editor::command): Return the empty command if the command name is empty.

WebKit/win:

Reviewed by Darin Adler.

revert my earlier crash fix after making WebCore return the empty editor command for the empty command name.

WebView.cpp: (WebView::handleEditingKeyboardEvent):

8:57 AM Changeset in webkit [28652] by ap@webkit.org

3 edits
2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16410
Implement isKeypadEvent() on Windows

Test: platform/win/fast/events/keyLocation-numpad.html

platform/win/KeyEventWin.cpp: (WebCore::isKeypadEvent): Added. (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Also fixed a mistake with autorepeat.

8:27 AM Changeset in webkit [28651] by alp@webkit.org

2 edits in trunk

2007-12-12 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=16302
[GTK] Compiler flags for optimization

Use the compiler flags -fno-exceptions -fno-rtti.

This patch does not add all the flags discussed in the bug report,
only these two.

WebKit.pri:

8:25 AM Changeset in webkit [28650] by ap@webkit.org

1 edit in trunk/LayoutTests/platform/win/fast/events/alt-numpad.html

Remove an incorrect svn:executable property.

8:24 AM Changeset in webkit [28649] by mrowe@apple.com

4 edits in trunk/WebKit

Remove abuse of projectDirPath from WebKit.xcodeproj to fix Production builds.

Reviewed by Dave Kilzer.

8:14 AM Changeset in webkit [28648] by alp@webkit.org

4 edits in trunk/WebKit/gtk

2007-12-12 Alp Toker <alp@atoker.com>

Reviewed by Holger Freyther.

http://bugs.webkit.org/show_bug.cgi?id=15576
[GTK] Printing support

Add printing support.

The API will be kept internal for the time being, but printing can now
be triggered by Web pages or the JSC API using JavaScript.

The print spooler and pagination code is fairly abstract and could be
shared by other ports including Win and Qt once complete. It doesn't
have header/footer support yet.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::print):
WebView/webkitprivate.h:
WebView/webkitwebframe.cpp: (PrintContext::begin_print): (PrintContext::draw_page): (PrintContext::end_print): (PrintContext::webkit_web_frame_print):

3:33 AM Changeset in webkit [28647] by ap@webkit.org

1 edit
2 adds in trunk/LayoutTests

Reviewed by Oliver.

http://bugs.webkit.org/show_bug.cgi?id=15248
Can not enter accented characters using alt-numeric keypad

platform/win/fast/events/alt-numpad-expected.txt: Added.
platform/win/fast/events/alt-numpad.html: Added.

2:57 AM Changeset in webkit [28646] by oliver@apple.com

6 edits
2 adds in trunk

<rdar://problem/5071781> window.mouseout events are not sent to window when mouse moves out of window

Reviewed by Maciej.

Hook up the windows mouse tracking logic to allow us to detect the mouse leaving the window.

12:41 AM Changeset in webkit [28645] by weinig@apple.com

4 edits in trunk/WebKit

WebKit/gtk:

Build fix.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didChangeTitle):

WebKit/qt:

Build fix.

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::userAgent):

12:40 AM Changeset in webkit [28644] by weinig@apple.com

2 edits in trunk/WebCore

Fix Mac release build.

WebCore.base.exp:

12:13 AM Changeset in webkit [28643] by weinig@apple.com

17 edits in trunk

WebCore:

Build fix for Qt, Gtk, and Wx.

css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::urlSelected):
platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl): (WebCore::ResourceHandleManager::startJob):
platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies):
platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start):
platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeURL):

WebKit/gtk:

Build fix.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):

WebKit/qt:

Build fix.

Api/qwebnetworkinterface.cpp: (QWebNetworkRequestPrivate::init):
Api/qwebpage.cpp: (QWebPage::url): (QWebPageContext::QWebPageContext):
Api/qwebpagehistory.cpp: (QWebHistoryItem::originalUrl): (QWebHistoryItem::currentUrl):
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::cannotShowURLError): (WebCore::FrameLoaderClientQt::interruptForPolicyChangeError): (WebCore::FrameLoaderClientQt::cannotShowMIMETypeError): (WebCore::FrameLoaderClientQt::fileDoesNotExistError): (WebCore::FrameLoaderClientQt::dispatchWillSendRequest): (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientQt::createPlugin):

WebKit/wx:

Build fix.

WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::createWindow):
WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientWx::dispatchDidCommitLoad): (WebCore::FrameLoaderClientWx::dispatchDidFinishDocumentLoad): (WebCore::FrameLoaderClientWx::postProgressFinishedNotification): (WebCore::FrameLoaderClientWx::didChangeTitle): (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNavigationAction):

12:07 AM Changeset in webkit [28642] by mitz@apple.com

2 edits in trunk/WebKit/win

Reviewed by Alexey Proskuryakov.

fix a crash when pressing a key that is not associated with a command

WebView.cpp: (WebView::handleEditingKeyboardEvent): Check if the result of interpretKeyEvent() is empty.

12:00 AM Changeset in webkit [28641] by mitz@apple.com

6 edits in trunk

WebCore:

Reviewed by Maciej Stachowiak.

allow non-integer font sizes on Windows for small caps

platform/graphics/win/FontDataWin.cpp: (WebCore::FontData::smallCapsFontData):
platform/graphics/win/FontPlatformData.h: (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::setSize):
platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):

LayoutTests:

Reviewed by Maciej Stachowiak.

removed now-passing tests

platform/win/Skipped:

Dec 11, 2007:

11:44 PM Changeset in webkit [28640] by weinig@apple.com

5 edits in trunk/WebCore

Build fix for Qt, Gtk, and Wx.

platform/gtk/CookieJarGtk.cpp: (WebCore::setCookies): (WebCore::cookies):
platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writeURL):
platform/qt/CookieJarQt.cpp: (WebCore::setCookies): (WebCore::cookies):
platform/wx/PasteboardWx.cpp: (WebCore::Pasteboard::writeURL):

11:26 PM Changeset in webkit [28639] by weinig@apple.com

86 edits in trunk

WebCore:

Reviewed by Darin Adler.

Scrub URL out of the tree in preparation for renaming KURL to URL.

Renames Document::URL() -> Document::url()
Renames DocumentLoader::URL() -> DocumentLoader::url()
Renames KURL::url() to KURL::string() and KURL::deprecatedString()
Remove FrameLoader::URL()
Various variable renames.

The change from Document::URL() to Document::url() required changes
to the bindings scripts as well, because URL() is the name of a DOM
method. The code generation scripts now have code to special case URL()
to url().

WebCore.base.exp:
bindings/js/kjs_events.cpp: (WebCore::JSLazyEventListener::parseCode):
bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScript):
bindings/js/kjs_window.cpp: (KJS::Window::put): (KJS::Window::allowsAccessFrom): (KJS::Location::put): (KJS::LocationProtoFuncReplace::callAsFunction): (KJS::LocationProtoFuncReload::callAsFunction): (KJS::LocationProtoFuncAssign::callAsFunction):
bindings/scripts/CodeGenerator.pm:
bindings/scripts/CodeGeneratorCOM.pm:
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorObjC.pm:
css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseBackgroundImage): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::createImportRule):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::setEncodedURL):
dom/Document.cpp: (WebCore::Document::processHttpEquiv): (WebCore::Document::cookie): (WebCore::Document::setCookie): (WebCore::Document::domain): (WebCore::Document::setDomain): (WebCore::Document::getImageMap): (WebCore::Document::completeURL):
dom/Document.h: (WebCore::Document::url): (WebCore::Document::baseURL):
dom/Element.cpp: (WebCore::Element::baseURI):
dom/ProcessingInstruction.h:
dom/StyledElement.cpp: (WebCore::StyledElement::addCSSImageProperty):
dom/StyledElement.h:
dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::XMLTokenizer::end): (WebCore::):
dom/XMLTokenizer.h:
editing/Editor.cpp: (WebCore::Editor::copy):
editing/markup.cpp: (WebCore::completeURLs):
history/CachedPage.h: (WebCore::CachedPage::url):
history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::setURL): (WebCore::HistoryItem::isCurrentDocument):
html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::process):
html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::childrenChanged): (WebCore::HTMLScriptElement::insertedIntoDocument): (WebCore::HTMLScriptElement::evaluateScript):
html/HTMLScriptElement.h:
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::requestResource):
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource):
loader/CachedResource.h: (WebCore::CachedResource::):
loader/CachedScript.h:
loader/DocLoader.cpp: (WebCore::DocLoader::checkForReload): (WebCore::DocLoader::requestResource):
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::url): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::startLoadingMainResource):
loader/DocumentLoader.h:
loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::submitFormAgain): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::replaceContentsWithScriptResult): (WebCore::FrameLoader::executeScript): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::startIconLoader): (WebCore::FrameLoader::commitIconURLToIconDatabase): (WebCore::FrameLoader::scheduleRefresh): (WebCore::FrameLoader::redirectionTimerFired): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::didNotOpenURL): (WebCore::FrameLoader::updatePolicyBaseURL): (WebCore::FrameLoader::scrollToAnchor): (WebCore::FrameLoader::startRedirectionTimer): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canLoad): (WebCore::FrameLoader::shouldHideReferrer): (WebCore::FrameLoader::shouldAllowNavigation): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::open): (WebCore::FrameLoader::didTellBridgeAboutLoad): (WebCore::FrameLoader::haveToldBridgeAboutLoad): (WebCore::FrameLoader::post): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoader::createHistoryItem): (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): (WebCore::FrameLoader::loadItem): (WebCore::FrameLoader::urlsMatchItem): (WebCore::FrameLoader::recursiveGoToItem): (WebCore::FrameLoader::updateHistoryForStandardLoad): (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory):
loader/FrameLoader.h: (WebCore::FrameLoader::url):
loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure):
loader/MainResourceLoader.cpp: (WebCore::shouldLoadAsEmptyDocument): (WebCore::MainResourceLoader::didFinishLoading):
loader/NavigationAction.cpp: (WebCore::NavigationAction::NavigationAction):
loader/NavigationAction.h: (WebCore::NavigationAction::url):
loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::load): (WebCore::SubresourceLoader::create):
loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): (WebCore::IconLoader::finishLoading):
loader/loader.cpp: (WebCore::Loader::servePendingRequests):
loader/mac/LoaderNSURLExtras.m: (urlOriginalData):
page/Chrome.cpp: (WebCore::Chrome::setToolTip):
page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
page/Frame.cpp: (WebCore::Frame::setUserStyleSheetLocation):
page/InspectorController.cpp: (WebCore::InspectorResource::type): (WebCore::addSourceToFrame): (WebCore::InspectorController::addScriptResource): (WebCore::InspectorController::updateScriptResourceRequest): (WebCore::InspectorController::didCommitLoad):
page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]):
platform/KURL.h: (WebCore::KURL::string): (WebCore::KURL::deprecatedString):
platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::getData):
platform/mac/CookieJar.mm: (WebCore::cookies): (WebCore::setCookies):
platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeURL): (WebCore::fileWrapperForImage): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::plainText):
platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::portAllowed):
platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::isNull):
platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::didReceiveChallenge): (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start):
platform/win/ClipboardUtilitiesWin.cpp: (WebCore::createGlobalData): (WebCore::urlToMarkup):
platform/win/ClipboardWin.cpp: (WebCore::writeURL): (WebCore::writeImageToDataObject): (WebCore::ClipboardWin::writeURL): (WebCore::ClipboardWin::writeRange):
platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL):
plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::findPlugin):
plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::destroyStream):
plugins/win/PluginViewWin.cpp: (WebCore::scriptStringIfJavaScriptURL): (WebCore::PluginViewWin::performRequest):
svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::updateFromElement):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
xml/XSLImportRule.cpp: (WebCore::XSLImportRule::loadSheet):
xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): (WebCore::xsltStylesheetPointer): (WebCore::xmlDocPtrFromNode):

WebKit/mac:

Reviewed by Darin Adler.

Scrub URL out of the tree in preparation for renaming KURL to URL.

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary):
WebView/WebDataSource.mm: (-[WebDataSource _URL]):
WebView/WebView.mm: (-[WebView _dispatchDidReceiveIconFromWebFrame:]):

WebKit/win:

Reviewed by Darin Adler.

Scrub URL out of the tree in preparation for renaming KURL to URL.

WebFrame.cpp: (WebFrame::url): (WebFrame::dispatchWillPerformClientRedirect): (WebFrame::setTitle): (WebFrame::updateGlobalHistoryForStandardLoad): (WebFrame::updateGlobalHistoryForReload): (WebFrame::cancelledError): (WebFrame::blockedError): (WebFrame::interruptForPolicyChangeError): (WebFrame::createPlugin):
WebView.cpp: (WebView::notifyDidAddIcon):

9:04 PM Changeset in webkit [28638] by mitz@apple.com

4 edits in trunk

WebKitTools:

Reviewed by Mark Rowe and Sam Weinig too!

added Helvetica Oblique and Helvetica Bold Oblique to the list of fonts DumpRenderTree registers.

DumpRenderTree/win/DumpRenderTree.cpp: (initialize):

LayoutTests:

Reviewed by Mark Rowe and Sam Weinig too!

removed tests that pass when Helvetica Oblique and Helvetica Bold Oblique are available.

platform/win/Skipped:

7:23 PM Changeset in webkit [28637] by Beth Dakin

13 edits
30 adds in trunk

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5641255> SVGs with width and height 100%
fail to render when used as background images

CachedImage now has a setImageContainerSize function. It is only
needed for SVG right now.

loader/CachedImage.cpp: (WebCore::CachedImage::setImageContainerSize):
loader/CachedImage.h:

Relatively sized SVGs have no intrinsic size. Because this call is
low-level enough that we cannot pass in the container size and get
the real size of the SVG, we need to know if it has relative
dimensions, and if so, we need to get the size from scaledTileSize.

platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
platform/graphics/Image.h: (WebCore::Image::setContainerSize): (WebCore::Image::hasRelativeWidth): (WebCore::Image::hasRelativeHeight):

Re-factored calculateBackgroundSize a bit so that it returns an
IntSize. Made it a member function so that it can send m_width and
m_height along to setImageContainerSize.

rendering/RenderBox.cpp: (WebCore::RenderBox::calculateBackgroundSize): (WebCore::RenderBox::calculateBackgroundImageGeometry):
rendering/RenderBox.h:

Need to account for relatively sized SVGs in calcViewport()

rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcViewport):

Added new member variables to store the size of the SVG container.
relativeWidthValue() and relativeHeightValue() use the stored SVG
container size to correctly calculate the width and height of a
relatively sized SVG.

svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::setContainerSize): (WebCore::SVGSVGElement::relativeWidthValue): (WebCore::SVGSVGElement::relativeHeightValue):
svg/SVGSVGElement.h: (WebCore::SVGSVGElement::containerSize):

Re-factored size calculations to use the size of the container.

svg/graphics/SVGImage.cpp: (WebCore::SVGImage::setContainerSize): (WebCore::SVGImage::size): (WebCore::SVGImage::hasRelativeWidth): (WebCore::SVGImage::hasRelativeHeight):
svg/graphics/SVGImage.h:

LayoutTests:

Reviewed by Darin.

Tests for <rdar://problem/5641255> SVGs with width and height 100%
fail to render when used as background images

fast/backgrounds/resources/balloon.svg: Added.
fast/backgrounds/resources/eyes.svg: Added.
fast/backgrounds/resources/hearts.svg: Added.
fast/backgrounds/resources/linguistics.svg: Added.
fast/backgrounds/resources/map.svg: Added.
fast/backgrounds/resources/mouse-repel.svg: Added.
fast/backgrounds/svg-as-background-1.html: Added.
fast/backgrounds/svg-as-background-2.html: Added.
fast/backgrounds/svg-as-background-3.html: Added.
fast/backgrounds/svg-as-background-4.html: Added.
fast/backgrounds/svg-as-background-5.html: Added.
fast/backgrounds/svg-as-background-6.html: Added.
platform/mac/fast/backgrounds/svg-as-background-1-expected.checksum: Added.
platform/mac/fast/backgrounds/svg-as-background-1-expected.png: Added.
platform/mac/fast/backgrounds/svg-as-background-1-expected.txt: Added.
platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum: Added.
platform/mac/fast/backgrounds/svg-as-background-2-expected.png: Added.
platform/mac/fast/backgrounds/svg-as-background-2-expected.txt: Added.
platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum: Added.
platform/mac/fast/backgrounds/svg-as-background-3-expected.png: Added.
platform/mac/fast/backgrounds/svg-as-background-3-expected.txt: Added.
platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum: Added.
platform/mac/fast/backgrounds/svg-as-background-4-expected.png: Added.
platform/mac/fast/backgrounds/svg-as-background-4-expected.txt: Added.
platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum: Added.
platform/mac/fast/backgrounds/svg-as-background-5-expected.png: Added.
platform/mac/fast/backgrounds/svg-as-background-5-expected.txt: Added.
platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum: Added.
platform/mac/fast/backgrounds/svg-as-background-6-expected.png: Added.
platform/mac/fast/backgrounds/svg-as-background-6-expected.txt: Added.

5:32 PM Changeset in webkit [28636] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

Build fix: Note some variables that are used only for ASSERTs.

API/testapi.c: (Base_finalize): (globalObject_initialize): (testInitializeFinalize):

4:30 PM Changeset in webkit [28635] by ggaren@apple.com

5 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Fixed: All JS tests crash on Windows.

NDEBUG wasn't defined when compiling testkjs in release builds, so the
HashTable definition in HashTable.h included an extra data member.

The solution was to add NDEBUG to the release testkjs configuration on
Windows and Mac.

For giggles, I also added other missing #defines to testkjs on Windows.

Configurations/Base.xcconfig:
Configurations/JavaScriptCore.xcconfig:
JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
kjs/testkjs.cpp: (main):

4:05 PM Changeset in webkit [28634] by alp@webkit.org

5 edits in trunk/WebKit/gtk

2007-12-11 George Wright <george.wright@collabora.co.uk>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=14120
[GDK] Support input methods

This patch adds infrastructure for input method support.

It also adds Hildon features for the Maemo mobile platform sufficient
to support the virtual keyboard.

WebCoreSupport/EditorClientGtk.cpp: (WebKit::imContextCommitted): (WebKit::EditorClient::EditorClient): (WebKit::EditorClient::~EditorClient): (WebKit::EditorClient::textFieldDidBeginEditing): (WebKit::EditorClient::textFieldDidEndEditing):
WebCoreSupport/EditorClientGtk.h:
WebView/webkitprivate.h:
WebView/webkitwebview.cpp:

3:05 PM Changeset in webkit [28633] by andersca@apple.com

4 edits in trunk/WebKit/win

Reviewed by Darin.

<rdar://problem/5636865>
WebKit needs API to allow registering a protocol as local (RSS feeds appear unstyled)

Interfaces/IWebView.idl:
WebView.cpp: (WebView::registerURLSchemeAsLocal):
WebView.h:

2:39 PM Changeset in webkit [28632] by adachan@apple.com

3 edits in trunk/WebKit/win

Updated the database SPI to take in IWebFrame.

Reviewed by Adam.

Interfaces/IWebUIDelegatePrivate.idl:
WebChromeClient.cpp: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):

2:33 PM Changeset in webkit [28631] by Darin Adler

2 edits in trunk/WebCore

editing/Editor.cpp: (WebCore::Editor::yankFromKillRing): Try to fix non-Mac builds by adding a missing return statement.

1:35 PM Changeset in webkit [28630] by ap@webkit.org

2 edits in trunk/WebKit/win

Windows build fix.

WebView.cpp: (WebView::interpretKeyEvent):

1:16 PM Changeset in webkit [28629] by Nikolas Zimmermann

1 edit
3 adds in trunk/LayoutTests

Rubberstamped by Mark.
Add missing tests - their results have already been checked in over a month ago - I forgot to commit the tests itself.

1:14 PM Changeset in webkit [28628] by Nikolas Zimmermann

53 edits in trunk/LayoutTests

Rubberstamped by Mark.
Update pixel test results now that filters are disabled.

1:02 PM Changeset in webkit [28627] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Removed bogus ASSERT.

ASSERT should only be used when we know that a code path will not be
taken. This code path is taken often during the jsFunFuzz test.

pcre/pcre_exec.cpp: (jsRegExpExecute):

12:26 PM Changeset in webkit [28626] by Darin Adler

32 edits
1 copy
2 deletes in trunk

WebCore:

Reviewed by Geoff.

exposed many new commands to the DOM Document executeCommand function by merging the JSEditor and Editor executeCommand implementations
replaced the execCommand function with a EditorCommand class
replaced the WTF::StrHash<> class template with the WebCore::StringHash class
replaced the WTF::CaseInsensitiveHash<> class template with the WebCore::CaseFoldingHash class

WebCore.base.exp: Updated.
WebCore.pro: Added EditorCommand.cpp, removed JSEditor.cpp.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
WebCoreSources.bkl: Ditto.

dom/Document.cpp: (WebCore::Document::Document): Removed code to set up m_jsEditor. (WebCore::Document::~Document): Removed code to delete m_jsEditor. (WebCore::command): Added. Helper function that gets an Editor::Command. (WebCore::Document::executeCommand): Changed to use Editor::Command instead of JSEditor. (WebCore::Document::queryCommandEnabled): Ditto. (WebCore::Document::queryCommandIndeterm): (WebCore::Document::queryCommandState): Ditto. (WebCore::Document::queryCommandSupported): Ditto. (WebCore::Document::queryCommandValue): Ditto.

dom/Document.h: Removed JSEditor, jsEditor, m_jsEditor. Changed to use CaseFoldingHash.

editing/Editor.cpp: (WebCore::Editor::selectionForCommand): Renamed from selectionForEvent and made into a member function so it is accessible from the new EditorCommand.cpp file. Also changed to get the selection from the passed-in frame instead of from the page, because this should work on the targeted frame unless the event overrides it. (WebCore::Editor::handleKeypress): Updated for selectionForCommand change. (WebCore::Editor::handleInputMethodKeypress): Ditto. (WebCore::imageElementFromImageDocument): Renamed and changed to return a HTMLImageElement instead of a Node*. (WebCore::Editor::canCopy): Updated for name change. (WebCore::Editor::selectionUnorderedListState): Updated for TriState change. (WebCore::Editor::selectionOrderedListState): Ditto. (WebCore::Editor::selectionStartHasStyle): Make type of local more specific. (WebCore::updateState): Moved here from Frame. (WebCore::Editor::selectionHasStyle): Ditto. (WebCore::Editor::Editor): Initialize m_shouldStartNewKillRingSequence. (WebCore::Editor::insertTextWithoutSendingTextEvent): Updated for selectionForCommand change. (WebCore::Editor::copy): Updated for imageElementFromImageDocument change. (WebCore::Editor::toggleBold): Call the ToggleBold command via the command machinery since it's no longer in this file as a local function. (WebCore::Editor::toggleUnderline): Call the ToggleUnderline command. (WebCore::Editor::setBaseWritingDirection): Change type of argument and of local variable. (WebCore::Editor::addToKillRing): Moved here from EditorMac. Not useful without a kill ring, but it's relatively straightforward to implement one. (WebCore::Editor::appendToKillRing): Put default implementation here for platforms other than Mac. We should probably put a simple kill ring implementation here -- doesn't need to be shared with the OS oh platforms other than Mac. (WebCore::Editor::prependToKillRing): Ditto. (WebCore::Editor::yankFromKillRing): Ditto. (WebCore::Editor::startNewKillRingSequence): Ditto. (WebCore::Editor::setKillRingToYankedState): Ditto.

editing/Editor.h: Moved the TriState enum here instead of inside the Frame class. Added EditorCommandSource enum. Moved selectionHasStyle here from the Frame class. Added Editor::Command class with five functions for the various things you can do with a command (execute it, check if it can be used, and its state and value). Changed hte parameter of setBaseWritingDirection to be a const String& rather than a String. Got rid of the kill-ring-related operations, but added the kill ring functions themselves. Made selectedRange() public. Made the m_startNewKillRingSequence not Mac-specific and added "should" to its name.

editing/EditorCommand.cpp: Copied from WebCore/editing/Editor.cpp. Retained only the editing commands. (WebCore::targetFrame): Moved to the top of the file. (WebCore::executeApplyStyle): Added. Helper function for commands that need to apply styles. (WebCore::executeToggleStyle): Added. Helper function for commands that need to toggle styles based on the style of the start of selection. (WebCore::executeApplyParagraphStyle): Added. Like executeApplyStyle, but for paragraph styles. (WebCore::executeInsertFragment): Added. Helper function for commands that need to insert a DOM fragment. (WebCore::executeInsertNode): Added. Helper function for commands that need to insert a tree rooted in a single DOM node. (WebCore::stateStyle): Added. Helper function for the state of commands that represent style. (WebCore::valueStyle): Added. Helper function for the value of commands that represent style. (WebCore::canScroll): Added. Helper functions for some move and scroll commands that need to determine if the renderer they are in can scroll. (WebCore::unionDOMRanges): Moved here from EditorMac. (WebCore::executeBackColor): (WebCore::executeBackwardDelete): (WebCore::executeCopy): (WebCore::executeCreateLink): (WebCore::executeCut): (WebCore::executeDelete): (WebCore::executeDeleteToMark): (WebCore::executeDeleteWordBackward): (WebCore::executeDeleteWordForward): (WebCore::executeFindString): (WebCore::executeFontName): (WebCore::executeFontSize): (WebCore::executeFontSizeDelta): (WebCore::executeForeColor): (WebCore::executeFormatBlock): (WebCore::executeForwardDelete): (WebCore::executeIndent): (WebCore::executeInsertBacktab): (WebCore::executeInsertHorizontalRule): (WebCore::executeInsertHTML): (WebCore::executeInsertImage): (WebCore::executeInsertLineBreak): (WebCore::executeInsertNewline): (WebCore::executeInsertNewlineInQuotedContent): (WebCore::executeInsertOrderedList): (WebCore::executeInsertParagraph): (WebCore::executeInsertTab): (WebCore::executeInsertText): (WebCore::executeInsertUnorderedList): (WebCore::executeJustifyCenter): (WebCore::executeJustifyFull): (WebCore::executeJustifyLeft): (WebCore::executeJustifyRight): (WebCore::executeMoveBackward): (WebCore::executeMoveBackwardAndModifySelection): (WebCore::executeMoveDown): (WebCore::executeMoveDownAndModifySelection): (WebCore::executeMoveDownByPageAndModifyCaret): (WebCore::executeMoveForward): (WebCore::executeMoveForwardAndModifySelection): (WebCore::executeMoveLeft): (WebCore::executeMoveLeftAndModifySelection): (WebCore::executeMoveRight): (WebCore::executeMoveRightAndModifySelection): (WebCore::executeMoveToBeginningOfDocument): (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): (WebCore::executeMoveToBeginningOfLine): (WebCore::executeMoveToBeginningOfLineAndModifySelection): (WebCore::executeMoveToBeginningOfParagraph): (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): (WebCore::executeMoveToBeginningOfSentence): (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfDocument): (WebCore::executeMoveToEndOfDocumentAndModifySelection): (WebCore::executeMoveToEndOfSentence): (WebCore::executeMoveToEndOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfLine): (WebCore::executeMoveToEndOfLineAndModifySelection): (WebCore::executeMoveToEndOfParagraph): (WebCore::executeMoveToEndOfParagraphAndModifySelection): (WebCore::executeMoveParagraphBackwardAndModifySelection): (WebCore::executeMoveParagraphForwardAndModifySelection): (WebCore::executeMoveUp): (WebCore::executeMoveUpAndModifySelection): (WebCore::executeMoveUpByPageAndModifyCaret): (WebCore::executeMoveWordBackward): (WebCore::executeMoveWordBackwardAndModifySelection): (WebCore::executeMoveWordForward): (WebCore::executeMoveWordForwardAndModifySelection): (WebCore::executeMoveWordLeft): (WebCore::executeMoveWordLeftAndModifySelection): (WebCore::executeMoveWordRight): (WebCore::executeMoveWordRightAndModifySelection): (WebCore::executeOutdent): (WebCore::executePaste): (WebCore::executePasteAndMatchStyle): (WebCore::executePrint): (WebCore::executeRedo): (WebCore::executeRemoveFormat): (WebCore::executeSelectAll): (WebCore::executeSelectToMark): (WebCore::executeSetMark): (WebCore::executeStrikethrough): (WebCore::executeSubscript): (WebCore::executeSuperscript): (WebCore::executeSwapWithMark): (WebCore::executeToggleBold): (WebCore::executeToggleItalic): (WebCore::executeTranspose): (WebCore::executeUnderline): (WebCore::executeUndo): (WebCore::executeUnlink): (WebCore::executeUnscript): (WebCore::executeUnselect): (WebCore::executeYank): (WebCore::executeYankAndSelect): (WebCore::supported): (WebCore::supportedPaste): (WebCore::enabled): (WebCore::enabledAnySelection): (WebCore::enabledAnySelectionAndMark): (WebCore::enableCaretInEditableText): (WebCore::enabledCopy): (WebCore::enabledCut): (WebCore::enabledInEditableText): (WebCore::enabledInRichlyEditableText): (WebCore::enabledPaste): (WebCore::enabledRangeInEditableText): (WebCore::enabledRangeInRichlyEditableText): (WebCore::enabledRedo): (WebCore::enabledUndo): (WebCore::stateNone): (WebCore::stateBold): (WebCore::stateItalic): (WebCore::stateOrderedList): (WebCore::stateStrikethrough): (WebCore::stateSubscript): (WebCore::stateSuperscript): (WebCore::stateUnderline): (WebCore::stateUnorderedList): (WebCore::valueNull): (WebCore::valueBackColor): (WebCore::valueFontName): (WebCore::valueFontSize): (WebCore::valueFontSizeDelta): (WebCore::valueForeColor): (WebCore::createCommandMap): Added lots of commands, including all the commands from JSEditor. A few commands needed different behavior based on whether they are invoked from the DOM or a keyboard binding. (WebCore::Editor::command): Added. Gets a command object given a name. (WebCore::Editor::Command::Command): Added. (WebCore::Editor::Command::execute): Added. (WebCore::Editor::Command::isSupported): Added. (WebCore::Editor::Command::isEnabled): Added. (WebCore::Editor::Command::state): Added. (WebCore::Editor::Command::value): Added. (WebCore::Editor::execCommand): Changed to call command().execute().

editing/JSEditor.cpp: Removed.
editing/JSEditor.h: Removed.

editing/mac/EditorMac.mm: Changed to provide kill ring primitives intead of kill ring commands, so the kill ring commands can be cross-platform. (WebCore::Editor::appendToKillRing): Added. (WebCore::Editor::prependToKillRing): Added. (WebCore::Editor::yankFromKillRing): Added. (WebCore::Editor::startNewKillRingSequence): Added. (WebCore::Editor::setKillRingToYankedState): Added.

page/Frame.cpp: Removed selectionHasStyle, TriState, and updateState.
page/Frame.h: Ditto.

page/mac/WebCoreFrameBridge.mm: Removed selectionHasStyle.
page/mac/WebCoreFrameBridge.h: Ditto.

platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for TriState change.

platform/text/StringHash.h: (WebCore::StringHash::hash): Merged the StrHash<> template classes into this. (WebCore::StringHash::equal): Ditto. (WebCore::CaseFoldingHash::hash): Merged the CaseInsensitiveHash<> template classes into this. (WebCore::CaseFoldingHash::equal): Ditto.

platform/text/StringImpl.cpp: (WebCore::equal): Changed to invoke StringHash. (WebCore::equalIgnoringCase): Changed to invoke CaseFoldingHash.

dom/DOMImplementation.cpp: (WebCore::addString): Updated to use StringHash and CaseFoldingHash. (WebCore::isSVG10Feature): Ditto. (WebCore::isSVG11Feature): Ditto.
loader/FrameLoader.cpp: (WebCore::localSchemes): Ditto.
platform/graphics/FontCache.cpp: (WebCore::computeHash): Ditto.
platform/network/HTTPHeaderMap.h: Ditto.
platform/text/PlatformString.h: Ditto.
platform/text/StringImpl.h: Ditto.
rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Ditto.
xml/XMLHttpRequest.cpp: (WebCore::canSetRequestHeader): Ditto.

rendering/RenderTreeAsText.cpp: Removed stray include of JSEditor.h.

WebKit/mac:

Reviewed by Geoff.

change more editing commands to use WebCore::Editor
change to use the new WebCore::Editor::command() function

WebView/WebHTMLView.mm: Changed alignCenter, alignJustified, alignLeft, alignRight, cut, copy, deleteToMark, indent, insertNewlineIgnoringFieldEditor, insertTabIgnoringFieldEditor, outdent, selectAll, selectToMark, setMark, subscript, superscript, swapWithMark, underline, unscript, yank, and yankAndSelect to use the "forward to WebCore" macro instead of having hand-written implementations. (kit): Added function to change a TriState to an AppKit-style tri-state value. (-[WebHTMLView coreCommandBySelector:]): Added. No longer converts case of the first character or copies the selector name, since the Editor commands are not case sensitive any more. Returns a command object. (-[WebHTMLView coreCommandByName:]): Added. (-[WebHTMLView executeCoreCommandBySelector:]): Renamed from callWebCoreCommand:, and changed to use the new coreCommandBySelector: method. (-[WebHTMLView executeCoreCommandByName:]): Added. (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Changed all the methods that call through to WebCore to also use the state() and isEnabled() functions on the commands for the menu item state and user interface item enabling. (-[WebHTMLView _handleStyleKeyEquivalent:]): Use ToggleBold and ToggleItalic by name rather than having local methods for them; no need for methods with a single call site. (-[WebHTMLView insertParagraphSeparator:]): Use executeCoreCommandByName: rather than the deprecated execCommand(). (-[WebHTMLView doCommandBySelector:]): Changed to use command().execute() rather than the deprecated execCommand().
WebView/WebHTMLViewInternal.h: Removed some unneeded method declarations.

WebKit/win:

WebView.cpp: (WebView::handleEditingKeyboardEvent): Update for change to Editor API.

12:24 PM Changeset in webkit [28625] by Darin Adler

2 edits in trunk/WebCore

platform/wx/KeyboardEventWx.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Another try at fixing the WX build. Changes the code around a little bit.

12:00 PM Changeset in webkit [28624] by beidson@apple.com

2 edits in trunk/WebKitTools

Reviewed by Anders

Make DumpRenderTree on mac use its own path for Databases testing

DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree for future DRT-only use, then use it to construct the Databases path and set that default

11:57 AM Changeset in webkit [28623] by Darin Adler

2 edits in trunk/WebCore

platform/wx/KeyboardEventWx.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Quick try at fixing build.

11:54 AM Changeset in webkit [28622] by Darin Adler

2 edits in trunk/JavaScriptCore

wtf/unicode/qt4/UnicodeQt4.h: Try to fix Qt build by adding U16_IS_SINGLE.

11:36 AM Changeset in webkit [28621] by mitz@apple.com

6 edits
9 adds in trunk

WebCore:

Reviewed by Darin Adler.

fix <rdar://problem/5631507> Text doesn't wrap properly at Tamil version of Wikipedia

Test: fast/text/international/complex-character-based-fallback.html

platform/graphics/Font.cpp: (WebCore::Font::glyphDataForCharacter): Added a forceSmallCaps argument that forces this function to use the small caps font. It is used for combining marks that need to combine with a small cap.
platform/graphics/Font.h:
platform/win/UniscribeController.cpp: (WebCore::UniscribeController::advance): Changed to split the string into runs of characters that will be rendered using the same FontData. This is done by calling glyphDataForCharacter() for each cahracter to find the FontData it should be rendered with. (WebCore::UniscribeController::itemizeShapeAndPlace): Added a fontData argument that is passed on to shapeAndPlaceItem() instead of the smallCaps argument. (WebCore::UniscribeController::shapeAndPlaceItem): Added a fontData argument and removed the font fallback logic from this function, as it is now expected to be called with an item all of whose characters can be rendered with the given fontData.
platform/win/UniscribeController.h:

LayoutTests:

Reviewed by Darin Adler.

test for <rdar://problem/5631507> Text doesn't wrap properly at Tamil version of Wikipedia

fast/text/international/complex-character-based-fallback.html: Added.
platform/mac-leopard/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
platform/mac-leopard/fast/text/international/complex-character-based-fallback-expected.png: Added.
platform/mac/fast/text/international/complex-character-based-fallback-expected.txt: Added.
platform/win/fast/text: Added.
platform/win/fast/text/international: Added.
platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
platform/win/fast/text/international/complex-character-based-fallback-expected.png: Added.
platform/win/fast/text/international/complex-character-based-fallback-expected.txt: Added.

11:11 AM Changeset in webkit [28620] by ap@webkit.org

75 edits
7 adds in trunk

Reviewed by Darin.

<rdar://problem/5535636>
Have to press 4 times instead of 2 times to get the expected result of with german keyboard.

http://bugs.webkit.org/show_bug.cgi?id=13916
JavaScript detects Tab as a character input on a textfield validation

11:08 AM Changeset in webkit [28619] by sfalken@apple.com

1 copy in tags/Safari-523.13b

New tag.

11:08 AM Changeset in webkit [28618] by sfalken@apple.com

2 edits in branches/Safari-3-branch/WebKit/win

Bump versions for submit

11:06 AM Changeset in webkit [28617] by sfalken@apple.com

1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/PRODUCTVERSION

Versioning.

11:06 AM Changeset in webkit [28616] by sullivan@apple.com

2 edits in trunk/WebCore

Reviewed by Adele

Tiger build fix -- don't call QTMovieView setDelegate: directly because it's not public

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView): (WebCore::MediaPlayerPrivate::detachQTMovieView):

10:46 AM Changeset in webkit [28615] by kmccullough@apple.com

3 edits in trunk/WebKitTools

Reviewed by Oliver.

<rdar://5599845> Drosera: Does not show loal files in the file list on the left side.

Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings so the open source community can build.

9:30 AM Changeset in webkit [28614] by ap@webkit.org

2 edits
1 delete in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16325
<rdar://problem/5632997> REGRESSION: www.xerox.ru doesn't work

Fix this on Windows, too!

Test: http/tests/misc/empty-cookie.html

platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies): Same fix as on Mac, translated into CF.

platform/win/CookieJarWin.cpp: Removed - the real one is in platform/network/win.

5:22 AM Changeset in webkit [28613] by alp@webkit.org

2 edits
1 add in trunk/WebCore

2007-12-11 Christian Dywan <christian@twotoasts.de>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16371
Implement additional mouse cursors for Gtk

Added cursor bitmaps from Mozilla:
http://lxr.mozilla.org/mozilla1.8/source/widget/src/gtk2/nsGtkCursors.h

platform/gtk/CursorGtk.cpp: (WebCore::customCursorNew): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
platform/gtk/CursorGtk.h: Added.

2:21 AM QtWebKitTodo edited by lars@webkit.org

(diff)

12:43 AM Changeset in webkit [28612] by oliver@apple.com

3 edits
3 adds in trunk

Fix character set used for dynamically loaded scripts.

Reviewed by Weinig, Dan and Alexey.

Fix for:

<rdar://problem/5333163> Safari can not display the mouse over pop menu on ChinaTimes News site correctly.
<rdar://problem/5530048> [Safari]? :Leopard9A576: The typed CH characters displays as garbage in Sina website after reloading the webpage.
<rdar://problem/5416588> All menus for chinese IBM site have wrong encoding

Use the same logic to determine the charset for a script loaded dynamically
as we do for a statically loaded script.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed