Context Navigation

Add final changes to make TCMalloc release memory to the system.
This results in a 0.4% regression against ToT, but this is offset
against the gains made by the original TCMalloc r38 merge - in fact
we retain around 0.3-0.4% progression overall.

3:42 PM Changeset in webkit [28726] by Darin Adler

3 edits in trunk/WebCore

Reviewed by Adele.

fix http://bugs.webkit.org/show_bug.cgi?id=16442 navigation policy delegate gets called twice for each load

loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): Removed call to checkNavigationPolicy. That's handled by FrameLoader.

loader/MainResourceLoader.h: Removed callContinueAfterNavigationPolicy and continueAfterNavigationPolicy.

3:41 PM Changeset in webkit [28725] by Darin Adler

3 edits in trunk/WebKit/win

Reviewed by Adele.

http://bugs.webkit.org/show_bug.cgi?id=16443 implement some missing Windows WebKit functions

DOMHTMLClasses.cpp: (DOMHTMLDocument::URL): Implemented.

WebActionPropertyBag.cpp: (WebActionPropertyBag::Read): Fixed the WebActionElementKey case.

3:06 PM Changeset in webkit [28724] by mitz@apple.com

1 edit
1 move in trunk/LayoutTests

share the results of this test between Tiger and Leopard

platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt.

2:06 PM Changeset in webkit [28723] by andersca@apple.com

6 edits
3 adds in trunk

WebCore:

Reviewed by Brady.

Make document.open count as committing a document load, so that -[WebFrame dataSource:] won't
return nil in that case.

loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen):

WebKitTools:

Reviewed by Brady.

Assert that a web frame that's loading a resource always has either a data source or
a provisional data source.

DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):

LayoutTests:

Reviewed by Brady.

Add test that calls window.open and then immediately writes into the document
of the newly opened window.

http/tests/misc/resources/compass.jpg: Added.
http/tests/misc/window-open-then-write-expected.txt: Added.
http/tests/misc/window-open-then-write.html: Added.
platform/win/Skipped:

1:48 PM Changeset in webkit [28722] by weinig@apple.com

17 edits
1 move
45 adds in trunk

WebCore:

Reviewed by Mitz.

fix http://bugs.webkit.org/show_bug.cgi?id=14955 Implement getElementsByClassName.

This patch also renames AtomicStringList to ClassNames to better reflect its actual use,
and takes advantage of admitting that it's class-specific to encapsulate class attribute
parsing so it can be shared. It also changes the class to use a Vector, rather than a linked
list to store the class names.

Tests: fast/dom/getElementsByClassName/001.html

fast/dom/getElementsByClassName/002.html
fast/dom/getElementsByClassName/003.html
fast/dom/getElementsByClassName/004.html
fast/dom/getElementsByClassName/005.html
fast/dom/getElementsByClassName/006.html
fast/dom/getElementsByClassName/007.html
fast/dom/getElementsByClassName/008.html
fast/dom/getElementsByClassName/009.html
fast/dom/getElementsByClassName/010.xml
fast/dom/getElementsByClassName/011.xml
fast/dom/getElementsByClassName/012.html
fast/dom/getElementsByClassName/013.html
fast/dom/getElementsByClassName/014.html
fast/dom/getElementsByClassName/array/001.html
fast/dom/getElementsByClassName/array/002.html
fast/dom/getElementsByClassName/array/003.html
fast/dom/getElementsByClassName/array/004.html
fast/dom/getElementsByClassName/dumpNodeList.html

WebCore.xcodeproj/project.pbxproj:
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): (WebCore::CSSStyleSelector::checkOneSelector):
dom/AtomicStringList.h: Removed.
dom/ClassNames.cpp: Added. (WebCore::ClassNames::contains): (WebCore::ClassNames::parseClassAttribute):
dom/ClassNames.h: Copied from WebCore/dom/AtomicStringList.h. (WebCore::ClassNames::ClassNames): (WebCore::ClassNames::size): (WebCore::ClassNames::clear): (WebCore::ClassNames::operator[]): (WebCore::isClassWhitespace):
dom/ClassNodeList.cpp: Added. (WebCore::ClassNodeList::ClassNodeList): (WebCore::ClassNodeList::length): (WebCore::ClassNodeList::item): (WebCore::ClassNodeList::nodeMatches):
dom/ClassNodeList.h: Added.
dom/Document.cpp: (WebCore::Document::getElementsByName): (WebCore::Document::getElementsByClassName):
dom/Document.h:
dom/Document.idl:
dom/Element.cpp: (WebCore::Element::getClassNames): (WebCore::Element::getElementsByClassName):
dom/Element.h:
dom/Element.idl:
dom/NameNodeList.cpp: (WebCore::NameNodeList::NameNodeList): (WebCore::NameNodeList::item): (WebCore::NameNodeList::nodeMatches):
dom/NameNodeList.h:
dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::clearAttributes): (WebCore::NamedMappedAttrMap::parseClassAttribute):
dom/NamedMappedAttrMap.h: (WebCore::NamedMappedAttrMap::getClassNames):
dom/StyledElement.cpp: (WebCore::StyledElement::getClassNames):
dom/StyledElement.h:

LayoutTests:

Reviewed by Mitz.

test for http://bugs.webkit.org/show_bug.cgi?id=14955 Implement getElementsByClassName

Tests added from http://tc.labs.opera.com/apis/getElementsByClassName/

fast/dom/Window/window-properties-expected.txt:
fast/dom/getElementsByClassName: Added.
fast/dom/getElementsByClassName/001-expected.txt: Added.
fast/dom/getElementsByClassName/001.html: Added.
fast/dom/getElementsByClassName/002-expected.txt: Added.
fast/dom/getElementsByClassName/002.html: Added.
fast/dom/getElementsByClassName/003-expected.txt: Added.
fast/dom/getElementsByClassName/003.html: Added.
fast/dom/getElementsByClassName/004-expected.txt: Added.
fast/dom/getElementsByClassName/004.html: Added.
fast/dom/getElementsByClassName/005-expected.txt: Added.
fast/dom/getElementsByClassName/005.html: Added.
fast/dom/getElementsByClassName/006-expected.txt: Added.
fast/dom/getElementsByClassName/006.html: Added.
fast/dom/getElementsByClassName/007-expected.txt: Added.
fast/dom/getElementsByClassName/007.html: Added.
fast/dom/getElementsByClassName/008-expected.txt: Added.
fast/dom/getElementsByClassName/008.html: Added.
fast/dom/getElementsByClassName/009-expected.txt: Added.
fast/dom/getElementsByClassName/009.html: Added.
fast/dom/getElementsByClassName/010-expected.txt: Added.
fast/dom/getElementsByClassName/010.xml: Added.
fast/dom/getElementsByClassName/011-expected.txt: Added.
fast/dom/getElementsByClassName/011.xml: Added.
fast/dom/getElementsByClassName/012-expected.txt: Added.
fast/dom/getElementsByClassName/012.html: Added.
fast/dom/getElementsByClassName/013-expected.txt: Added.
fast/dom/getElementsByClassName/013.html: Added.
fast/dom/getElementsByClassName/014-expected.txt: Added.
fast/dom/getElementsByClassName/014.html: Added.
fast/dom/getElementsByClassName/array: Added.
fast/dom/getElementsByClassName/array/001-expected.txt: Added.
fast/dom/getElementsByClassName/array/001.html: Added.
fast/dom/getElementsByClassName/array/002-expected.txt: Added.
fast/dom/getElementsByClassName/array/002.html: Added.
fast/dom/getElementsByClassName/array/003-expected.txt: Added.
fast/dom/getElementsByClassName/array/003.html: Added.
fast/dom/getElementsByClassName/array/004-expected.txt: Added.
fast/dom/getElementsByClassName/array/004.html: Added.
fast/dom/getElementsByClassName/dumpNodeList-expected.txt: Added.
fast/dom/getElementsByClassName/dumpNodeList.html: Added.
fast/dom/getElementsByClassName/resources: Added.
fast/dom/getElementsByClassName/resources/common.js: Added.

12:50 PM Changeset in webkit [28721] by Darin Adler

6 edits in trunk

JavaScriptCore:

Reviewed by Sam.

removed unnecessary includes of "Vector.h"

wtf/HashMap.h: (WTF::copyKeysToVector): Make the type of the vector be a template parameter. This allows copying keys into a vector of a base class or one with an inline capacity. (WTF::copyValuesToVector): Ditto.
wtf/HashSet.h: (WTF::copyToVector): Ditto.

WebCore:

Reviewed by Sam.

fix http://bugs.webkit.org/show_bug.cgi?id=16351 FontFallbackList.h doesn't include wtf/PassRefPtr.h

platform/graphics/FontFallbackList.h: Added include of <wtf/Forward.h>
platform/graphics/GlyphPageTreeNode.h: Removed an unneeded include.

12:42 PM Changeset in webkit [28720] by Darin Adler

3 edits in trunk/WebKitTools

fix mistake causing nearly all tests to fail on Windows

DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with npos, not 0. Also pass URL in to URL function rather than passing the entire message.

DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather than passing the entire message.

12:34 PM Changeset in webkit [28719] by Darin Adler

2 edits in trunk/WebKitTools

fix Tiger build

DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any new-to-Leopard methods.

12:25 PM Changeset in webkit [28718] by Darin Adler

4 edits in trunk

WebKit/mac:

Reviewed by Brady.

fix http://bugs.webkit.org/show_bug.cgi?id=16296 <rdar://problem/5635641> -[WebFrameLoadDelegate didReceiveIcon:forFrame:] never called

WebView/WebView.mm: (-[WebView setFrameLoadDelegate:]): Call [WebIconDatabase sharedIconDatabase] if the a didReceiveIcon method is present.

WebKitTools:

DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method since it now triggers unwanted icon loading. We only had it because we implemented "all" delegate methods here.

12:03 PM Changeset in webkit [28717] by Darin Adler

38 edits in trunk

WebCore:

Reviewed by Alexey.

http://bugs.webkit.org/show_bug.cgi?id=16420 change regression tests to use document.execCommand instead of textInputController.doCommand

Add a few more operations to document.execCommand.

Finished up the transition to the new Editor::Command, including removing
the Editor::execCommand function.

WebCore.base.exp: Added Editor::Command::isSupported.
editing/Editor.h: Removed execCommand.
editing/EditorCommand.cpp: (WebCore::expandSelectionToGranularity): Added. (WebCore::verticalScrollDistance): Added; replaces canScroll. (WebCore::executeDeleteBackward): Added. Moved code here from WebHTMLView. (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): Ditto. (WebCore::executeDeleteForward): Ditto. (WebCore::executeDeleteToBeginningOfLine): Ditto. (WebCore::executeDeleteToBeginningOfParagraph): Ditto. (WebCore::executeDeleteToEndOfLine): Ditto. (WebCore::executeDeleteToEndOfParagraph): Ditto. (WebCore::executeMovePageDown): Renamed this command to be consistent with all the other Move commands. They all modify the caret. Reimplemented to match the Mac OS X version by removing the explicit scrolling, and letting it be done automatically by code that makes the caret visible. In some cases the old code would scroll twice which was harmless but unnecessary. (WebCore::executeMovePageDownAndModifySelection): Added. Moved code here from WebHTMLView. (WebCore::executeMovePageUp): See MovePageDown above. (WebCore::executeMovePageUpAndModifySelection): Added. Moved code here from WebHTMLView. (WebCore::executeSelectLine): Ditto. (WebCore::executeSelectParagraph): Ditto. (WebCore::executeSelectSentence): Ditto. (WebCore::executeSelectWord): Ditto. (WebCore::executeSwapWithMark): Some small tweaks.

page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Changed to use Editor::command() instead of Editor::execCommand(). This code could be changed to use Editor::Command quite a bit more, but I didn't do that this time.

Removed some obsolete unused code.

page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMouseDownEventToWidget): Removed the special case code for NSTextView. This was left over from when we used NSTextField and NSTextView for form elements and is no longer used at all.

page/mac/WebCoreFrameBridge.h: Removed 20 unused methods that were still on one side of the bridge or another. We really need to find a time to tear down the rest of the bridge, but that's not this patch.

page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge addData:]): Changed to get at the _shouldCreateRenderers field directly instead of using a method. (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]): Took out obsolete comment about matching enums (we use a single enum now and have for some time). (-[WebCoreFrameBridge selectionGranularity]): Ditto.

WebKit:

StringsNotToBeLocalized.txt: Updated.

WebKit/gtk:

Reviewed by Alexey.

WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeyboardEvent): Changed to use Editor::command instead of Editor::execCommand.
WebView/webkitwebview.cpp: Ditto.

WebKit/mac:

Reviewed by Alexey.

Changed a few more editing operations to use WebCore instead of WebKit.
Removed some obsolete unused code.

WebCoreSupport/WebFrameBridge.h: Moved declarations of methods that are both defined and used on the WebKit side to here. These no longer belong on the bridge and should be moved to the WebFrame class (or elsewhere).
WebCoreSupport/WebFrameBridge.mm: Removed some unused methods.

WebView/WebFrameView.mm: (+[WebFrameView _viewTypesAllowImageTypeOmission:]): Fix typo in comment.

WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): Removed unused firstResponderTextViewAtMouseDownTime. (-[WebHTMLViewPrivate clear]): Ditto. (-[WebHTMLView _setMouseDownEvent:]): Ditto. (commandNameForSelector): Added special cases for pageDown:, pageDownAndModifySelection:, pageUp:, and pageUpAndModifySelection:, since those names probably aren't specific enough to be used in WebCore (what AppKit calls scrollPageDown: vs. pageDown: needs to be disambiguated with the word "Move"). Added deleteBackward:, deleteBackwardByDecomposingPreviousCharacter:, deleteForward:, deleteToBeginningOfLine:, deleteToBeginningOfParagraph:, deleteToEndOfLine:, deleteToEndOfParagraph:, pageDown:, pageDownAndModifySelection:, pageUp:, pageUpAndModifySelection:, selectLine:, selectParagraph:, selectSentence:, and selectWord: to the list of commands that are forwarded to WebCore. (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Eliminated the long list of operations that we forward to WebCore. Instead, look up any command that WebCore can handle, after any that we handle specially in WebHTMLView. Also fixed a bug where an item that's not a menu item with changeBaseWritingDirection:NSWritingDirectionNatural would end up enabled instead of disabled and streamlined the logic for toggleGrammarChecking:. (-[WebHTMLView mouseDown:]): Removed unused firstResponderTextViewAtMouseDownTime. (-[WebHTMLView becomeFirstResponder]): Removed unused willBecomeFirstResponderForNodeFocus. (-[WebHTMLView resignFirstResponder]): Ditto. (-[WebHTMLView checkSpelling:]): Took unneeded extra initialization of NSSpellChecker.

WebView/WebHTMLViewInternal.h: Removed unused willBecomeFirstResponderForNodeFocus, firstResponderTextViewAtMouseDownTime, _textViewWasFirstResponderAtMouseDownTime: and _willMakeFirstResponderForNodeFocus.

WebKit/qt:

Reviewed by Alexey.

Api/qwebpage.cpp: (QWebPage::triggerAction): Removed some use of Editor member functions we plan to eventually eliminate. Switch from Editor::execCommand to Editor::command.
WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent): Ditto. Also updated name from MoveUpByPageAndModifyCaret to MovePageUp and from MoveDownByPageAndModifyCaret to MovePageDown.

WebKit/win:

Reviewed by Alexey.

WebView.cpp: (WebView::execCommand): Switched from Editor::execCommand to Editor:command. Updated name from MoveUpByPageAndModifyCaret to MovePageUp and from MoveDownByPageAndModifyCaret to MovePageDown. (WebView::copy): Switched from Editor::execCommand to Editor:command. (WebView::cut): Ditto. (WebView::paste): Ditto. (WebView::delete_): Ditto.

WebKit/wx:

Reviewed by Alexey.

WebKitSupport/EditorClientWx.cpp: (WebCore::EditorClientWx::handleKeyboardEvent): Switched from Editor::execCommand to Edtor::command.

LayoutTests:

Reviewed by Alexey.

http://bugs.webkit.org/show_bug.cgi?id=16420 change regression tests to use document.execCommand instead of textInputController.doCommand

To avoid changing results at this time, I didn't correct the many tests that now have
misleading "this test cannot be run manually" text or references to "NSResponder" or
uneeded instructions for running the test manually. We can do that on a later pass.

editing/deleting/5300379.html: Use execCommand instead of doCommand.
editing/deleting/delete-to-end-of-paragraph.html: Ditto.
editing/deleting/smart-delete-003.html: Ditto.
editing/deleting/smart-delete-004.html: Ditto.
editing/execCommand/nsresponder-indent.html: Ditto.
editing/execCommand/nsresponder-outdent.html: Ditto.
editing/selection/4947387.html: Ditto.
editing/selection/5195166-1.html: Ditto.
editing/selection/5195166-2.html: Ditto.
editing/selection/select-line.html: Ditto.
editing/selection/selection-actions.html: Ditto.

11:55 AM Changeset in webkit [28716] by justin.garcia@apple.com

8 edits
6 adds in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5575101> GoogleDocs: Hang in SplitElementCommand::doApply when outdenting a list item in a particular list

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode): Moved here.
editing/CompositeEditCommand.h:
editing/IndentOutdentCommand.cpp: Moved splitTreeToNode.
editing/IndentOutdentCommand.h: Ditto, and removed unimplemented splitTreeTo.
editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Split ancestors of listChildNode between it and listNode, if they exists, so that moving listChildNode doesn't put it out of order. Added a test case to cover each change.
editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::doApply): Added an ASSERT to catch code that tries to split a container at a bogus child, and an early return to avoid a hang in that case.

LayoutTests:

Reviewed by Darin Adler.

<rdar://problem/5575101> Hang in SplitElementCommand::doApply when outdenting a list item in a particular list

editing/execCommand/5575101-1-expected.txt: Added.
editing/execCommand/5575101-1.html: Added.
editing/execCommand/5575101-2-expected.txt: Added.
editing/execCommand/5575101-2.html: Added.
editing/execCommand/5575101-3-expected.txt: Added.
editing/execCommand/5575101-3.html: Added.

11:47 AM Changeset in webkit [28715] by andersca@apple.com

11 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Darin and Geoff.

<rdar://problem/5619295>
REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)

Get rid of unnecessary and incorrect security checks for plug-ins accessing JavaScript objects.

The way this used to work was that each NPObject that wrapped a JSObject would have a root object
corresponding to the frame object (used for managing the lifecycle) and an origin root object (used for
doing security checks).

This would prevent a plug-in from accessing a frame's window object if it's security origin was different
(some parts of the window, such as the location object, can be accessed from frames with different security
origins, and those checks are being done in WebCore).

Also, if a plug-in were to access a window object of a frame that later went away, it could lead to that
Window JSObject being garbage collected and the NPObject pointing to freed memory.

How this works now is that there is no origin root object anymore, and all NPObject wrappers that are created
for a plug-in will have the root object of the containing frame of that plug-in.

bindings/NP_jsobject.cpp: (jsDeallocate): Don't free the origin root object.

(_NPN_CreateScriptObject):
Remove the origin root object parameter.

(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_GetProperty):
(_NPN_SetProperty):
(_NPN_RemoveProperty):
(_NPN_HasProperty):
(_NPN_HasMethod):
(_NPN_Enumerate):
Get rid of all security checks.

bindings/NP_jsobject.h: Remove originRootObject from the JavaScriptObject struct.

bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Always use the root object from the ExecState.

WebCore:

Reviewed by Darin and Geoff.

<rdar://problem/5619295>
REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)

_NPN_CreateScriptObject doesn't take an origin root object anymore.

html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::createNPObject):
page/Frame.cpp: (WebCore::Frame::windowScriptNPObject):

WebKitTools:

Reviewed by Darin and Geoff.

<rdar://problem/5619295>
REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)

Add property getting methods to the plug-in.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvoke):

LayoutTests:

Reviewed by Darin and Geoff.

<rdar://problem/5619295>
REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)

Add cross frame plug/in test where a plug/in inside an iframe tries to access properties of the
top-level frame.

http/tests/plugins/cross-frame-object-access-expected.txt: Added.
http/tests/plugins/cross-frame-object-access.html: Added.
http/tests/plugins/resources/cross-frame-object-access.html: Added.

11:37 AM Changeset in webkit [28714] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Darin Adler.

fix <rdar://problem/5643663> text-shadow and box-shadow offsets 1px smaller than specified which is the root cause of: http://bugs.webkit.org/show_bug.cgi?id=12943 box-shadow: small values don't affect shadow position http://bugs.webkit.org/show_bug.cgi?id=14736 Safari implementation of text-shadow off by 1px

platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setShadow): Slightly increase the magnitude of the offsets passed to CGContextSetShadow* to ensure that the end result after truncation is the desired integer offsets.

10:34 AM Changeset in webkit [28713] by oliver@apple.com

2 edits
1 add in trunk/LayoutTests

Move layout test to mac skipped list until mac frt bug fixed.

Reviewed by Adam.

Fix test output, and move test to mac skipped list until
<rdar://problem/5647952> fast/events/mouseout-on-window.html
is fixed.

10:19 AM Changeset in webkit [28712] by kmccullough@apple.com

2 edits in trunk/WebKitTools

Reviewed by Darin.

Layout test fix for mac. When dumped to the console local file paths now only show the name of the resource not the whole path. This is to make the results machine and OS independent.

DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:addMessageToConsole:]):

Dec 13, 2007:

10:56 PM Changeset in webkit [28711] by alp@webkit.org

2 edits in trunk/WebCore

2007-12-13 Alp Toker <alp@atoker.com>

curl backend build fix for breakage introduced in r28709.

platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):

9:32 PM Changeset in webkit [28710] by justin.garcia@apple.com

4 edits
12 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

<rdar://problem/5607069> In Mail, a crash occurs at WebCore::AppendNodeCommand() after dragging image into a <FORM> element

editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::shouldUseBreakElement): Equip this function to handle editing positions, like [input, 0];
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Pass enclosingBlock a node peeled off of a non-editing position, to fix a bug where the enclosing block of [input, 0] was the input element itself. Insert a <br> when a <form> element is the enclosing block instead of splitting/cloning or nesting a <div>.

LayoutTests:

Reviewed by Oliver Hunt.

<rdar://problem/5607069> In Mail, a crash occurs at WebCore::AppendNodeCommand() after dragging image into a <FORM> element

editing/inserting/5607069-1-expected.checksum: Added.
editing/inserting/5607069-1-expected.png: Added.
editing/inserting/5607069-1-expected.txt: Added.
editing/inserting/5607069-1.html: Added.
editing/inserting/5607069-2.html: Added.
editing/inserting/5607069-3.html: Added.
platform/mac/editing/inserting/5607069-2-expected.checksum: Added.
platform/mac/editing/inserting/5607069-2-expected.png: Added.
platform/mac/editing/inserting/5607069-2-expected.txt: Added.
platform/mac/editing/inserting/5607069-3-expected.checksum: Added.
platform/mac/editing/inserting/5607069-3-expected.png: Added.
platform/mac/editing/inserting/5607069-3-expected.txt: Added.

7:37 PM Changeset in webkit [28709] by alp@webkit.org

2 edits in trunk/WebCore

2007-12-13 Alp Toker <alp@atoker.com>

Reviewed by Oliver Hunt.

http://bugs.webkit.org/show_bug.cgi?id=16365
[cURL] Acid2 test segmentation fault

This patch makes the Acid2 test pass.

Defer the cleanup of cancelled jobs and halt further transfer as early
as possible.

Bug found by and initial patch provided by Luca Bruno.

platform/network/curl/ResourceHandleManager.cpp: (WebCore::writeCallback): (WebCore::headerCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::cancel):

7:32 PM Changeset in webkit [28708] by weinig@apple.com

4 edits in trunk/WebCore

Reviewed by Mark Rowe.

Fix typos and rename InspectorController::moveByUnrestricted to InspectorController::moveWindowBy.

page/InspectorController.cpp: (WebCore::moveByUnrestricted): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::moveWindowBy):
page/InspectorController.h:
page/inspector/inspector.js:

7:20 PM UsingGitWithWebKit edited by ddkilzer@apple.com

(diff)

7:19 PM UsingGitWithWebKit edited by ddkilzer@apple.com

(diff)

7:16 PM UsingGitWithWebKit edited by ddkilzer@apple.com

(diff)

6:58 PM UsingGitWithWebKit edited by ddkilzer@apple.com

(diff)

6:40 PM UsingGitWithWebKit edited by ddkilzer@apple.com

(diff)

6:30 PM UsingGitWithWebKit edited by ddkilzer@apple.com

(diff)

6:25 PM Changeset in webkit [28707] by mitz@apple.com

7 edits
2 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

fix <rdar://problem/5642426> explicit cubic-bezier curves all treated as "default" for transition-timing-function

Test: fast/css/transition-timing-function.html

css/CSSStyleSelector.cpp: Changed the HANDLE_MULTILAYER_VALUE macro to not reject non-primitive non-list values, and instead made sure that the mapping functions rejected them if necessary. This allows non-primitive timing functions to be mapped. (WebCore::CSSStyleSelector::mapBackgroundAttachment): (WebCore::CSSStyleSelector::mapBackgroundClip): (WebCore::CSSStyleSelector::mapBackgroundComposite): (WebCore::CSSStyleSelector::mapBackgroundOrigin): (WebCore::CSSStyleSelector::mapBackgroundImage): (WebCore::CSSStyleSelector::mapBackgroundRepeat): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition): (WebCore::CSSStyleSelector::mapTransitionDuration): (WebCore::CSSStyleSelector::mapTransitionRepeatCount): (WebCore::CSSStyleSelector::mapTransitionTimingFunction): (WebCore::CSSStyleSelector::mapTransitionProperty):
css/CSSTimingFunctionValue.cpp: (WebCore::CSSTimingFunctionValue::cssText): Implemented for use in the regression test.
css/CSSTimingFunctionValue.h: (WebCore::CSSTimingFunctionValue::isTransitionTimingFunctionValue): Added. Returns true.
css/CSSValue.h: (WebCore::CSSValue::isTransitionTimingFunctionValue): Added. Returns false.

LayoutTests:

Reviewed by Dave Hyatt.

test for <rdar://problem/5642426> explicit cubic-bezier curves all treated as "default" for transition-timing-function

fast/css/transition-timing-function-expected.txt: Added.
fast/css/transition-timing-function.html: Added.

6:14 PM Changeset in webkit [28706] by mjs@apple.com

5 edits in trunk/SunSpider

Reviewed by Oliver.

Add some explanatory test and a dumb logo to SunSpider web hosted version

hosted/sunspider-driver.html:
hosted/sunspider-results.html:
hosted/sunspider.css:
hosted/sunspider.html:

6:07 PM Changeset in webkit [28705] by kmccullough@apple.com

12 edits
2 adds
5 deletes in trunk

WebKitTools:

Reviewed by Adam.

Layout tests fix. We need a way to remove machine-dependent information from paths in layout test results. The UIDelegate now does this.

DumpRenderTree/DumpRenderTree.h:
DumpRenderTree/win/DumpRenderTree.cpp: (urlSuitableForTestResult):
DumpRenderTree/win/DumpRenderTreeWin.h:
DumpRenderTree/win/ResourceLoadDelegate.cpp:
DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::webViewAddMessageToConsole):

LayoutTests:

Reviewed by Adam.

Layout tests fix. Removed machine dependant results and generated new results without machine specific information.

fast/dom/frame-loading-via-document-write-expected.txt: Added.
http/tests/security/frame-loading-via-document-write-expected.txt: Added.
http/tests/security/local-CSS-from-remote-expected.txt:
http/tests/security/local-JavaScript-from-remote-expected.txt:
http/tests/security/local-iFrame-from-remote-expected.txt:
http/tests/security/local-image-from-remote-expected.txt:
platform/mac/fast/dom/frame-loading-via-document-write-expected.checksum: Removed.
platform/mac/fast/dom/frame-loading-via-document-write-expected.png: Removed.
platform/mac/fast/dom/frame-loading-via-document-write-expected.txt: Removed.
platform/mac/http/tests/security: Removed.
platform/mac/http/tests/security/frame-loading-via-document-write-expected.checksum: Removed.
platform/mac/http/tests/security/frame-loading-via-document-write-expected.png: Removed.
platform/mac/http/tests/security/frame-loading-via-document-write-expected.txt: Removed.
platform/win/Skipped:
platform/win/http: Removed.
platform/win/http/tests: Removed.
platform/win/http/tests/security: Removed.
platform/win/http/tests/security/frame-loading-via-document-write-expected.txt: Removed.

5:23 PM Changeset in webkit [28704] by sfalken@apple.com

10 edits
2 adds in trunk

WebCore:

Move source file generation into its own vcproj to fix build dependencies.

Reviewed by Adam.

WebCore.vcproj/WebCore.make:
WebCore.vcproj/WebCore.sln:
WebCore.vcproj/WebCore.submit.sln:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcproj/WebCoreGenerated.vcproj: Added.

WebKit/win:

Move source file generation into its own vcproj to fix build dependencies.

Reviewed by Adam.

WebKit.vcproj/Interfaces.vcproj:
WebKit.vcproj/InterfacesGenerated.vcproj: Added.
WebKit.vcproj/WebKit.sln:
WebKit.vcproj/WebKit.submit.sln:
WebKit.vcproj/build-generated-files.sh:

5:22 PM Changeset in webkit [28703] by justin.garcia@apple.com

1 edit in trunk/WebCore/editing/ApplyStyleCommand.cpp

Fix the build.

5:12 PM Changeset in webkit [28702] by justin.garcia@apple.com

2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

<rdar://problem/4145786> Undoing a color change of text in a compose window always changes it back to black

Some of the operations performed in removeHTMLFontStyle were non-undoable.

I'm having trouble writing a layout test for this because I can't get DRT to
perform editing operations in separate Undo steps without adding unacceptably long
wait times between operations. I filed:

<rdar://problem/5646779> Can't get DRT to perform editing operations in separate Undo steps

editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeHTMLFontStyle):

5:10 PM Changeset in webkit [28701] by weinig@apple.com

4 edits in trunk/WebCore

Reviewed by Anders.

Fix for http://bugs.webkit.org/show_bug.cgi?id=16352
Toolbar dragged inspector cannot be moved beyond screen edges

page/InspectorController.cpp: (WebCore::moveByUnrestricted): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::moveByUnrestricted):
page/InspectorController.h:
page/inspector/inspector.js:

5:07 PM Changeset in webkit [28700] by Adam Roben

6 edits in trunk

Fix <rdar://5517707> Crash on wptv.wp.pl when "make bigger" button is clicked

WebCore:

Fix <rdar://5517707> Crash on wptv.wp.pl when "make bigger" button is clicked

Windows Media Player has a modal message loop that will deliver
messages to us at inappropriate times and we will crash if we handle
them when they are delivered. In PluginViewWin, we add a quirk for
Media Player to set a flag whenever we give the plugin a chance to
execute code, and in SharedTimerWin we check if the plugin is
executing code and repost messages if so.

Reviewed by Anders.

platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc): Repost messages if we're calling a plugin.
plugins/win/PluginViewWin.cpp: Surround all calls to the plugin with setCallingPlugin(true/false). (WebCore::PluginViewWin::updateWindow): (WebCore::PluginViewWin::dispatchNPEvent): (WebCore::PluginViewWin::setNPWindowRect): (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::stop): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::bindingInstance): (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::setCallingPlugin): Added. (WebCore::PluginViewWin::isCallingPlugin): Added.
plugins/win/PluginViewWin.h: Added a new quirk.

WebKit/win:

Fix <rdar://5517707> Crash on wptv.wp.pl when "make bigger" button is clicked

Reviewed by Anders.

WebView.cpp: (WebViewWndProc): Repost paint messages and ignore all other messages when we're calling a plugin.

4:56 PM Changeset in webkit [28699] by alp@webkit.org

2 edits in trunk/WebKitTools

2007-12-13 Alp Toker <alp@atoker.com>

Build fix for DRT breakage introduced in r28690.

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pathToLocalResource):

4:32 PM Changeset in webkit [28698] by alp@webkit.org

2 edits in trunk/WebCore

2007-12-13 Alp Toker <alp@atoker.com>

Add a missing DEPENDPATH. Fixes non-clean builds following networking
header changes.

WebCore.pro:

3:48 PM Changeset in webkit [28697] by sfalken@apple.com

6 edits
2 adds in trunk

JavaScriptCore:

Move source file generation into its own vcproj to fix build dependencies.

Reviewed by Adam.

JavaScriptCore.vcproj/JavaScriptCore.sln:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Added.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Added.
JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:

WebKit/win:

Fix project dependencies based on JavaScriptCore change.

WebKit.vcproj/WebKit.sln:

2:59 PM Changeset in webkit [28696] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

fix regression in fast/text/international/bidi-override on Tiger

platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage): Add bidi overrides here too. I forgot to add them when I added them to treatAsZeroWidthSpace in an earlier patch.

2:17 PM Changeset in webkit [28695] by ap@webkit.org

3 edits
2 adds in trunk

Reviewed by Adele.

http://bugs.webkit.org/show_bug.cgi?id=16421
REGRESSION(r28669): Page scrolls down when you hit space key in text area

Test: fast/events/space-scroll-event.html

WebView.cpp: (WebView::keyDown): (WebView::keyPress): Moved space handliing to keyPress() to fix this bug and to match IE. Scrolling via arrow keys is correctly handled in keyDown().

1:32 PM Changeset in webkit [28694] by justin.garcia@apple.com

14 edits
4 adds in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5601583> GMail Editor: Copied link doesn't paste as a link, just colored text

The code that checks the selected Range to see if it's inside an anchor
checks ancestors of the Range's commonAncestor() but not the
commonAncestor() itself, and so we'd fail to add markup for the enclosing
anchor to the pasteboard.

Some enclosing element getters check the node passed to the getter and some
don't. There were a few places where we incorrectly assumed that enclosing
element getters check the node passed to the getter, but this is the only
case that I'm able to write a test case for at the moment.

In this patch I've:
Changed enclosingNodeWithType and enclosingNodeWithTag to take in positions,
like the newer enclosing element getters. This is important because we must
soon add code to the getters so that they understand that some editing positions
inside nodes don't actually refer to positions inside those nodes but positions
before and after them. Like [table, 0].
Changed enclosingNodeWithType and enclosingNodeWithTag to check nodes starting with
n where [n, o] is the position passed to the getter, instead of starting the the parent
of n. This makes all but a few of the enclosing element getters behave consistently.
Changed enclosingNodeWithType and enclosingNodeWithTag to not return non-editable
nodes if the input position was editable. This fixes a bug that that the above change
exposed.
Changed enclosingTableCell to simply call enclosingNodeWithType. We should do
this for the rest of the getters, or simply remove them in favor of enclosingNodeWithType
unless doing so would affect readability, like it would in the case of enclosingTableCell.
Ditto for enclosingBlock.

editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::doApply):
editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement):
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor):
editing/Editor.cpp: (WebCore::Editor::selectionUnorderedListState): (WebCore::Editor::selectionOrderedListState):
editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): (WebCore::IndentOutdentCommand::outdentParagraph):
editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply):
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMerge): (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
editing/TextIterator.cpp:
editing/htmlediting.cpp: (WebCore::enclosingBlock): (WebCore::enclosingNodeWithTag): (WebCore::enclosingNodeOfType): (WebCore::enclosingTableCell): (WebCore::isTableCell):
editing/htmlediting.h:
editing/markup.cpp: (WebCore::appendStartMarkup): (WebCore::createMarkup):

LayoutTests:

Reviewed by Darin Adler.

<rdar://problem/5601583> GMail Editor: Copied link doesn't paste as a link, just colored text

editing/pasteboard/5601583-1.html: Added.
platform/mac/editing/pasteboard/5601583-1-expected.checksum: Added.
platform/mac/editing/pasteboard/5601583-1-expected.png: Added.
platform/mac/editing/pasteboard/5601583-1-expected.txt: Added.

12:40 PM Changeset in webkit [28693] by ap@webkit.org

13 edits in trunk

Reviewed by Darin.

Turn on keyboard event processing quirks for feed views and old applications on Mac OS X.

11:38 AM Changeset in webkit [28692] by alp@webkit.org

2 edits in trunk/JavaScriptCore

2007-12-13 Alp Toker <alp@atoker.com>

http://bugs.webkit.org/show_bug.cgi?id=16406
[Gtk] JavaScriptCore needs -lpthread

Build fix for Debian and any other platforms that don't implicitly
link to pthread.

Link to pthread on non-Windows platforms until this dependency is
removed from JSC.

11:36 AM Changeset in webkit [28691] by mitz@apple.com

2 edits in trunk/WebCore

build fix

platform/network/cf/ResourceErrorCF.cpp:

11:07 AM Changeset in webkit [28690] by kmccullough@apple.com

27 edits
4 adds in trunk

WebKitTools:

Reviewed by Alice and Sam.

<rdar://5621435> Need a way to specify local resources (being loaded from HTTP tests) on Windows.
Implemented pathToLocalResource which exposes the functionality of converting a given unix path to the correct location on Windows.

DumpRenderTree/LayoutTestController.cpp: (pathToLocalResourceCallback): (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pathToLocalResource):
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pathToLocalResource):

LayoutTests:

Reviewed by Alice and Sam.

<rdar://5621435> Need a way to specify local resources (being loaded from HTTP tests) on Windows.
Updated the following tests to use the new layoutTestController function, pathToLocalResource to get a Windows viable path (when on Windows) to the local resources they are attempting to access.
Also clarified and updated some results.

fast/dom/frame-loading-via-document-write.html:
fast/loader/local-CSS-from-local-expected.txt:
fast/loader/local-CSS-from-local.html:
fast/loader/local-JavaScript-from-local-expected.txt:
fast/loader/local-JavaScript-from-local.html:
fast/loader/local-iFrame-source-from-local-expected.txt:
fast/loader/local-iFrame-source-from-local.html:
fast/loader/local-image-from-local-expected.txt:
fast/loader/local-image-from-local.html:
http/tests/security/frame-loading-via-document-write.html:
http/tests/security/local-CSS-from-remote-expected.txt:
http/tests/security/local-CSS-from-remote.html:
http/tests/security/local-JavaScript-from-remote-expected.txt:
http/tests/security/local-JavaScript-from-remote.html:
http/tests/security/local-iFrame-from-remote-expected.txt:
http/tests/security/local-iFrame-from-remote.html:
http/tests/security/local-image-from-remote-expected.txt:
http/tests/security/local-image-from-remote.html:
http/tests/security/local-user-CSS-from-remote.html:
platform/mac/fast/dom/frame-loading-via-document-write-expected.txt:
platform/win/Skipped:
platform/win/http: Added.
platform/win/http/tests: Added.
platform/win/http/tests/security: Added.
platform/win/http/tests/security/frame-loading-via-document-write-expected.txt: Added.

10:55 AM Changeset in webkit [28689] by Antti Koivisto

2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Fix <rdar://problem/5605674>
Make <video> display WebKit context menu instead of the QTKit one.

It doesn't really matter where the QTMovieView is.

ChangeLog:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView): (WebCore::MediaPlayerPrivate::setRect):

10:45 AM Changeset in webkit [28688] by mitz@apple.com

5 edits
4 adds in trunk

WebCore:

Reviewed by Adam Roben.

ensure that Unicode bidi control characters are rendered as zero width spaces

Test: fast/text/international/bidi-control-chars-treated-as-ZWS.html

platform/graphics/Font.h: (WebCore::Font::treatAsZeroWidthSpace):
platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage):
platform/text/CharacterNames.h:

LayoutTests:

Reviewed by Adam Roben.

test that Unicode bidi control characters are rendered as zero width spaces

fast/text/international/bidi-control-chars-treated-as-ZWS.html: Added.
platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum: Added.
platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Added.
platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.

5:51 AM QtWebKitTodo edited by Simon Hausmann