⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 15, 2007:

10:57 PM Changeset in webkit [28768] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

Fix urlSuitableForTestResult to correctly identify wstring::npos as
the case when wstring.find doesn't find anything.

  • DumpRenderTree/win/DumpRenderTree.cpp: (urlSuitableForTestResult):
6:00 PM Changeset in webkit [28767] by Darin Adler
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • better build fix for the problem affecting GTK and some other platforms "this time for sure"
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventTargetBase.cpp: Move the include of the .lut.h file here.
  • bindings/js/JSEventTargetBase.h: Instead of including the .lut.h file in the header, which won't work, declare the tables that are in the .lut.h file in the header.
5:54 PM Changeset in webkit [28766] by kevino@webkit.org
  • 3 edits in trunk/WebCore

Fixed the Wx port's FontPlatformData for use in HashTable.

5:33 PM Changeset in webkit [28765] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix <rdar://problem/5636090> Text in Georgia, Armenian, Inuktitut, Cree, or Cherokee (KA, HY, IU, CR, CHR) draws as all missing glyphs
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::metaFileEnumProc): Added. Called during metafile record enumeration and extracts the font from the create font record. (WebCore::FontCache::getFontDataForCharacters): If font linking fails, let Uniscribe draw the characters and see what font it chooses.
5:31 PM Changeset in webkit [28764] by Darin Adler
  • 2 edits in trunk/WebCore
  • WebCore.pro: Roll my last change out. Was wrong and didn't fix the build.
5:30 PM Changeset in webkit [28763] by Darin Adler
  • 285 edits
    1 move in trunk/LayoutTests

Disabled the smallFonts.svg test, which has been failing for weeks. I heard that Niko
is going to fix this soon. He should rename it back at that time.

Removed the svn:executable flag from many .svg, .png, and .css files that had it set
for no good reason.

  • svg/batik/text/smallFonts.svg: Removed.
  • svg/batik/text/smallFonts.svg-disabled: Copied from svg/batik/text/smallFonts.svg.
5:11 PM Changeset in webkit [28762] by Darin Adler
  • 2 edits in trunk/WebCore

Another try at a GTK build fix.

  • WebCore.pro: Add JSEventTargetBase.cpp to LUT_TABLE_FILES instead of LUT_FILES.
4:07 PM Changeset in webkit [28761] by weinig@apple.com
  • 3 edits in trunk/WebCore

Force windows to regenerate COM DOM bindings.

  • WebCore.vcproj/build-generated-files.sh: Add license.
  • bindings/scripts/CodeGeneratorCOM.pm: Use shared WK_ucfirst.
3:32 PM Changeset in webkit [28760] by weinig@apple.com
  • 3 edits in trunk/WebCore

Fix Windows and wx builds.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
3:31 PM Changeset in webkit [28759] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Gtk build fix. Add JSEventTargetBase.cpp to SOURCES.

3:24 PM Changeset in webkit [28758] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix wx build.

  • WebCoreSources.bkl:
3:23 PM Changeset in webkit [28757] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Not reviewed. Build fix for Qt/Gtk.

2:48 PM Changeset in webkit [28756] by Nikolas Zimmermann
  • 10 edits
    2 adds in trunk/WebCore

Reviewed by Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=16445 (Refactor EventTargetNode & JSEventTargetNode for an upcoming SVG patch)

Split up JSEventTargetNode in JSEventTargetNode & JSEventTargetBase - where most functionality has been moved down
in the base class. Applied the same refactorization to EventTargetNode.

This makes it possible for the upcoming patch implementing the EventTarget interface for SVGElementInstance
to share as much code as possible with the EventTargetNode classes.

12:03 PM Changeset in webkit [28755] by eric@webkit.org
  • 6 edits
    5 adds in trunk

2007-12-15 Eric Seidel <​eric@webkit.org>

Reviewed by Oliver.

Width of SVG elements not applied to container elements
​http://bugs.webkit.org/show_bug.cgi?id=16305
Added calcPrefWidths for RenderSVGRoot (copied from RenderReplaced)
This is caused by poor factoring in the render tree. RenderContainer probably should be a template.

svg/css/css-box-min-width.html

  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcPrefWidths): Added.
  • rendering/RenderSVGRoot.h:
  • css/SVGCSSStyleSelector::applySVGProperty: fixed ASSERT in debug builds
6:46 AM Changeset in webkit [28754] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Fix comment after isSafeScript() was renamed to allowsAccessFrom().

  • bindings/js/kjs_window.cpp: (KJS::createWindow):
6:13 AM Changeset in webkit [28753] by alp@webkit.org
  • 2 edits in trunk/WebKitTools

2007-12-15 Alp Toker <​alp@atoker.com>

GTK+ DRT build fix for GLib < 2.14.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setWaitToDump):
5:40 AM Changeset in webkit [28752] by alp@webkit.org
  • 2 edits in trunk/LayoutTests

2007-12-15 Alp Toker <​alp@atoker.com>

​http://bugs.webkit.org/show_bug.cgi?id=16449
cairo_arc() functions hang or crash when passed inf as radius or start/end angle

Fixed in r28751. Remove these tests from the skip list:

fast/canvas/arc-crash.html
fast/canvas/canvas-with-incorrect-args.html

  • platform/gtk/Skipped:
5:12 AM Changeset in webkit [28751] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-15 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16449
cairo_arc() functions hang or crash when passed inf as radius or start/end angle

Add checks. This matches a similar workaround for a CG bug in the CG
graphics backend: <rdar://problem/5189233>

Fixes:

fast/canvas/arc-crash.html
fast/canvas/canvas-with-incorrect-args.html

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArc):
4:39 AM Changeset in webkit [28750] by mrowe@apple.com
  • 4 edits in trunk/WebKitTools

Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.
This prevents many layout tests from hanging while waiting on user responses to dialogs.

Reviewed by Alp Toker.

4:39 AM Changeset in webkit [28749] by mrowe@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Add a skeleton Gtk skipped list containing only tests that hang run-webkit-tests.

3:00 AM Changeset in webkit [28748] by mrowe@apple.com
  • 6 edits in trunk/WebKitTools

Flesh out DumpRenderTree for Gtk. After these changes, the majority of the tests in fast/js pass.

Reviewed by Alp Toker.

1:30 AM Changeset in webkit [28747] by ap@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Correct a mistake in ChangeLog.

1:07 AM Changeset in webkit [28746] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=16436
Alt+Space works incorrectly

Test: platform/win/fast/events/alt-space-scroll.html

  • WebView.cpp: (WebView::keyDown): (WebView::keyPress): We do not handle WM_SYSCHAR events.
1:03 AM Changeset in webkit [28745] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=16078
Google Maps zooming via the scroll wheel (almost) always zooms IN only.

  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): Ensure that delta is never rounded down to zero - we are getting values less than 1 from many mice on OS X, and Google Maps code assumes scrolling down if event.wheelDelta is zero.

Dec 14, 2007:

10:24 PM Changeset in webkit [28744] by alp@webkit.org
  • 2 edits in trunk/JavaScriptCore

2007-12-14 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Enable the AllInOneFile.cpp optimization for the GTK+ port.

8:35 PM Changeset in webkit [28743] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Remove commented out fprintf's that were for debugging purposes only.

8:31 PM Changeset in webkit [28742] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Don't use the MADV_DONTNEED code path for now as it has no effect on Mac OS X and is currently untested on other platforms.

Reviewed by Maciej Stachowiak.

  • wtf/TCSystemAlloc.cpp:

(TCMalloc_SystemRelease): Return after releasing memory rather than potentially falling
through into another mechanism if multiple are supported.

8:21 PM Changeset in webkit [28741] by alp@webkit.org
  • 2 edits in trunk/JavaScriptCore

2007-12-14 Alp Toker <​alp@atoker.com>

Build fix for GTK+/Qt and ports that don't use AllInOneFile.cpp.

Include UnusedParam.h.

7:53 PM Changeset in webkit [28740] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix build on windows

Reviewd by Stephanie

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::IncrementalScavenge):

7:26 PM Changeset in webkit [28739] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • Windows build fix
  • WebCore.vcproj/WebCore.vcproj:
7:02 PM Changeset in webkit [28738] by mitz@apple.com
  • 2 edits in trunk/WebKit/win
  • yet another build fix
  • DOMHTMLClasses.cpp: (DOMHTMLDocument::URL):
7:00 PM Changeset in webkit [28737] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-12-14 Alp Toker <​alp@atoker.com>

Fix inconsistent indentation in the license header. Maciej was right!

  • WebCoreSupport/FrameLoaderClientGtk.cpp:
6:51 PM Changeset in webkit [28736] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-14 Alp Toker <​alp@atoker.com>

GTK+/Qt build fix. Track added files in r28722.

  • WebCore.pro:
6:16 PM Changeset in webkit [28735] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/5647272> Remove user agent string hack for flickr.com

Reviewed by Darin.

  • WebView/WebView.mm: (-[WebView _userAgentForURL:]): Removed hack.
6:15 PM Changeset in webkit [28734] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/5647261> Remove user agent string hack for yahoo.com

Reviewed by Darin.

  • WebView/WebView.mm: (-[WebView _userAgentForURL:]): Removed hack.
6:09 PM Changeset in webkit [28733] by mitz@apple.com
  • 2 edits in trunk/JavaScriptCore
  • try again to fix the Windows build
  • wtf/TCSystemAlloc.cpp: (TCMalloc_SystemRelease):
6:00 PM Changeset in webkit [28732] by mitz@apple.com
  • 2 edits in trunk/JavaScriptCore
  • try to fix the Windows build
  • wtf/TCSystemAlloc.cpp: (TCMalloc_SystemRelease):
5:35 PM Changeset in webkit [28731] by mitz@apple.com
  • 2 edits in trunk/WebKit/win
  • build fix
  • WebIconDatabase.h:
5:19 PM Changeset in webkit [28730] by weinig@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog

5:17 PM Changeset in webkit [28729] by weinig@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

Speed up getElementByClassName.

  • platform/text/StringImpl.cpp: (WebCore::StringImpl::foldCase): Optimize the case when all the characters are ASCII.
5:03 PM Changeset in webkit [28728] by alp@webkit.org
  • 21 edits in trunk

2007-12-14 Alp Toker <​alp@atoker.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=16432
[GTK] Update license headers

Consent has been given by the authors of these files to change license
to the LGPL as outlined in the bug report.

4:25 PM Changeset in webkit [28727] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Add logic for TCMalloc to release memory to the system

Reviewed by Maciej and Oliver.

Add final changes to make TCMalloc release memory to the system.
This results in a 0.4% regression against ToT, but this is offset
against the gains made by the original TCMalloc r38 merge - in fact
we retain around 0.3-0.4% progression overall.

3:42 PM Changeset in webkit [28726] by Darin Adler
  • 3 edits in trunk/WebCore

Reviewed by Adele.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): Removed call to checkNavigationPolicy. That's handled by FrameLoader.
  • loader/MainResourceLoader.h: Removed callContinueAfterNavigationPolicy and continueAfterNavigationPolicy.
3:41 PM Changeset in webkit [28725] by Darin Adler
  • 3 edits in trunk/WebKit/win

Reviewed by Adele.

  • DOMHTMLClasses.cpp: (DOMHTMLDocument::URL): Implemented.
  • WebActionPropertyBag.cpp: (WebActionPropertyBag::Read): Fixed the WebActionElementKey case.
3:06 PM Changeset in webkit [28724] by mitz@apple.com
  • 1 edit
    1 move in trunk/LayoutTests
  • share the results of this test between Tiger and Leopard
  • platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
  • platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt.
2:06 PM Changeset in webkit [28723] by andersca@apple.com
  • 6 edits
    3 adds in trunk

WebCore:

Reviewed by Brady.

Make document.open count as committing a document load, so that -[WebFrame dataSource:] won't
return nil in that case.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen):

WebKitTools:

Reviewed by Brady.

Assert that a web frame that's loading a resource always has either a data source or
a provisional data source.


  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):

LayoutTests:

Reviewed by Brady.

Add test that calls window.open and then immediately writes into the document
of the newly opened window.


  • http/tests/misc/resources/compass.jpg: Added.
  • http/tests/misc/window-open-then-write-expected.txt: Added.
  • http/tests/misc/window-open-then-write.html: Added.
  • platform/win/Skipped:
1:48 PM Changeset in webkit [28722] by weinig@apple.com
  • 17 edits
    1 move
    45 adds in trunk

WebCore:

Reviewed by Mitz.

This patch also renames AtomicStringList to ClassNames to better reflect its actual use,
and takes advantage of admitting that it's class-specific to encapsulate class attribute
parsing so it can be shared. It also changes the class to use a Vector, rather than a linked
list to store the class names.

Tests: fast/dom/getElementsByClassName/001.html

fast/dom/getElementsByClassName/002.html
fast/dom/getElementsByClassName/003.html
fast/dom/getElementsByClassName/004.html
fast/dom/getElementsByClassName/005.html
fast/dom/getElementsByClassName/006.html
fast/dom/getElementsByClassName/007.html
fast/dom/getElementsByClassName/008.html
fast/dom/getElementsByClassName/009.html
fast/dom/getElementsByClassName/010.xml
fast/dom/getElementsByClassName/011.xml
fast/dom/getElementsByClassName/012.html
fast/dom/getElementsByClassName/013.html
fast/dom/getElementsByClassName/014.html
fast/dom/getElementsByClassName/array/001.html
fast/dom/getElementsByClassName/array/002.html
fast/dom/getElementsByClassName/array/003.html
fast/dom/getElementsByClassName/array/004.html
fast/dom/getElementsByClassName/dumpNodeList.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): (WebCore::CSSStyleSelector::checkOneSelector):
  • dom/AtomicStringList.h: Removed.
  • dom/ClassNames.cpp: Added. (WebCore::ClassNames::contains): (WebCore::ClassNames::parseClassAttribute):
  • dom/ClassNames.h: Copied from WebCore/dom/AtomicStringList.h. (WebCore::ClassNames::ClassNames): (WebCore::ClassNames::size): (WebCore::ClassNames::clear): (WebCore::ClassNames::operator[]): (WebCore::isClassWhitespace):
  • dom/ClassNodeList.cpp: Added. (WebCore::ClassNodeList::ClassNodeList): (WebCore::ClassNodeList::length): (WebCore::ClassNodeList::item): (WebCore::ClassNodeList::nodeMatches):
  • dom/ClassNodeList.h: Added.
  • dom/Document.cpp: (WebCore::Document::getElementsByName): (WebCore::Document::getElementsByClassName):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/Element.cpp: (WebCore::Element::getClassNames): (WebCore::Element::getElementsByClassName):
  • dom/Element.h:
  • dom/Element.idl:
  • dom/NameNodeList.cpp: (WebCore::NameNodeList::NameNodeList): (WebCore::NameNodeList::item): (WebCore::NameNodeList::nodeMatches):
  • dom/NameNodeList.h:
  • dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::clearAttributes): (WebCore::NamedMappedAttrMap::parseClassAttribute):
  • dom/NamedMappedAttrMap.h: (WebCore::NamedMappedAttrMap::getClassNames):
  • dom/StyledElement.cpp: (WebCore::StyledElement::getClassNames):
  • dom/StyledElement.h:

LayoutTests:

Reviewed by Mitz.

Tests added from ​http://tc.labs.opera.com/apis/getElementsByClassName/

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/getElementsByClassName: Added.
  • fast/dom/getElementsByClassName/001-expected.txt: Added.
  • fast/dom/getElementsByClassName/001.html: Added.
  • fast/dom/getElementsByClassName/002-expected.txt: Added.
  • fast/dom/getElementsByClassName/002.html: Added.
  • fast/dom/getElementsByClassName/003-expected.txt: Added.
  • fast/dom/getElementsByClassName/003.html: Added.
  • fast/dom/getElementsByClassName/004-expected.txt: Added.
  • fast/dom/getElementsByClassName/004.html: Added.
  • fast/dom/getElementsByClassName/005-expected.txt: Added.
  • fast/dom/getElementsByClassName/005.html: Added.
  • fast/dom/getElementsByClassName/006-expected.txt: Added.
  • fast/dom/getElementsByClassName/006.html: Added.
  • fast/dom/getElementsByClassName/007-expected.txt: Added.
  • fast/dom/getElementsByClassName/007.html: Added.
  • fast/dom/getElementsByClassName/008-expected.txt: Added.
  • fast/dom/getElementsByClassName/008.html: Added.
  • fast/dom/getElementsByClassName/009-expected.txt: Added.
  • fast/dom/getElementsByClassName/009.html: Added.
  • fast/dom/getElementsByClassName/010-expected.txt: Added.
  • fast/dom/getElementsByClassName/010.xml: Added.
  • fast/dom/getElementsByClassName/011-expected.txt: Added.
  • fast/dom/getElementsByClassName/011.xml: Added.
  • fast/dom/getElementsByClassName/012-expected.txt: Added.
  • fast/dom/getElementsByClassName/012.html: Added.
  • fast/dom/getElementsByClassName/013-expected.txt: Added.
  • fast/dom/getElementsByClassName/013.html: Added.
  • fast/dom/getElementsByClassName/014-expected.txt: Added.
  • fast/dom/getElementsByClassName/014.html: Added.
  • fast/dom/getElementsByClassName/array: Added.
  • fast/dom/getElementsByClassName/array/001-expected.txt: Added.
  • fast/dom/getElementsByClassName/array/001.html: Added.
  • fast/dom/getElementsByClassName/array/002-expected.txt: Added.
  • fast/dom/getElementsByClassName/array/002.html: Added.
  • fast/dom/getElementsByClassName/array/003-expected.txt: Added.
  • fast/dom/getElementsByClassName/array/003.html: Added.
  • fast/dom/getElementsByClassName/array/004-expected.txt: Added.
  • fast/dom/getElementsByClassName/array/004.html: Added.
  • fast/dom/getElementsByClassName/dumpNodeList-expected.txt: Added.
  • fast/dom/getElementsByClassName/dumpNodeList.html: Added.
  • fast/dom/getElementsByClassName/resources: Added.
  • fast/dom/getElementsByClassName/resources/common.js: Added.
12:50 PM Changeset in webkit [28721] by Darin Adler
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Sam.

  • removed unnecessary includes of "Vector.h"
  • wtf/HashMap.h: (WTF::copyKeysToVector): Make the type of the vector be a template parameter. This allows copying keys into a vector of a base class or one with an inline capacity. (WTF::copyValuesToVector): Ditto.
  • wtf/HashSet.h: (WTF::copyToVector): Ditto.

WebCore:

Reviewed by Sam.


  • platform/graphics/FontFallbackList.h: Added include of <wtf/Forward.h>
  • platform/graphics/GlyphPageTreeNode.h: Removed an unneeded include.
12:42 PM Changeset in webkit [28720] by Darin Adler
  • 3 edits in trunk/WebKitTools
  • fix mistake causing nearly all tests to fail on Windows
  • DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with npos, not 0. Also pass URL in to URL function rather than passing the entire message.
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather than passing the entire message.
12:34 PM Changeset in webkit [28719] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • fix Tiger build
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any new-to-Leopard methods.
12:25 PM Changeset in webkit [28718] by Darin Adler
  • 4 edits in trunk

WebKit/mac:

Reviewed by Brady.

  • WebView/WebView.mm: (-[WebView setFrameLoadDelegate:]): Call [WebIconDatabase sharedIconDatabase] if the a didReceiveIcon method is present.

WebKitTools:

  • DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method since it now triggers unwanted icon loading. We only had it because we implemented "all" delegate methods here.
12:03 PM Changeset in webkit [28717] by Darin Adler
  • 38 edits in trunk

WebCore:

Reviewed by Alexey.

Add a few more operations to document.execCommand.

Finished up the transition to the new Editor::Command, including removing
the Editor::execCommand function.

  • WebCore.base.exp: Added Editor::Command::isSupported.
  • editing/Editor.h: Removed execCommand.
  • editing/EditorCommand.cpp: (WebCore::expandSelectionToGranularity): Added. (WebCore::verticalScrollDistance): Added; replaces canScroll. (WebCore::executeDeleteBackward): Added. Moved code here from WebHTMLView. (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): Ditto. (WebCore::executeDeleteForward): Ditto. (WebCore::executeDeleteToBeginningOfLine): Ditto. (WebCore::executeDeleteToBeginningOfParagraph): Ditto. (WebCore::executeDeleteToEndOfLine): Ditto. (WebCore::executeDeleteToEndOfParagraph): Ditto. (WebCore::executeMovePageDown): Renamed this command to be consistent with all the other Move commands. They all modify the caret. Reimplemented to match the Mac OS X version by removing the explicit scrolling, and letting it be done automatically by code that makes the caret visible. In some cases the old code would scroll twice which was harmless but unnecessary. (WebCore::executeMovePageDownAndModifySelection): Added. Moved code here from WebHTMLView. (WebCore::executeMovePageUp): See MovePageDown above. (WebCore::executeMovePageUpAndModifySelection): Added. Moved code here from WebHTMLView. (WebCore::executeSelectLine): Ditto. (WebCore::executeSelectParagraph): Ditto. (WebCore::executeSelectSentence): Ditto. (WebCore::executeSelectWord): Ditto. (WebCore::executeSwapWithMark): Some small tweaks.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Changed to use Editor::command() instead of Editor::execCommand(). This code could be changed to use Editor::Command quite a bit more, but I didn't do that this time.
  • Removed some obsolete unused code.
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMouseDownEventToWidget): Removed the special case code for NSTextView. This was left over from when we used NSTextField and NSTextView for form elements and is no longer used at all.
  • page/mac/WebCoreFrameBridge.h: Removed 20 unused methods that were still on one side of the bridge or another. We really need to find a time to tear down the rest of the bridge, but that's not this patch.
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge addData:]): Changed to get at the _shouldCreateRenderers field directly instead of using a method. (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]): Took out obsolete comment about matching enums (we use a single enum now and have for some time). (-[WebCoreFrameBridge selectionGranularity]): Ditto.

WebKit:

  • StringsNotToBeLocalized.txt: Updated.

WebKit/gtk:

Reviewed by Alexey.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeyboardEvent): Changed to use Editor::command instead of Editor::execCommand.
  • WebView/webkitwebview.cpp: Ditto.

WebKit/mac:

Reviewed by Alexey.

  • Changed a few more editing operations to use WebCore instead of WebKit.
  • Removed some obsolete unused code.
  • WebCoreSupport/WebFrameBridge.h: Moved declarations of methods that are both defined and used on the WebKit side to here. These no longer belong on the bridge and should be moved to the WebFrame class (or elsewhere).
  • WebCoreSupport/WebFrameBridge.mm: Removed some unused methods.
  • WebView/WebFrameView.mm: (+[WebFrameView _viewTypesAllowImageTypeOmission:]): Fix typo in comment.
  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): Removed unused firstResponderTextViewAtMouseDownTime. (-[WebHTMLViewPrivate clear]): Ditto. (-[WebHTMLView _setMouseDownEvent:]): Ditto. (commandNameForSelector): Added special cases for pageDown:, pageDownAndModifySelection:, pageUp:, and pageUpAndModifySelection:, since those names probably aren't specific enough to be used in WebCore (what AppKit calls scrollPageDown: vs. pageDown: needs to be disambiguated with the word "Move"). Added deleteBackward:, deleteBackwardByDecomposingPreviousCharacter:, deleteForward:, deleteToBeginningOfLine:, deleteToBeginningOfParagraph:, deleteToEndOfLine:, deleteToEndOfParagraph:, pageDown:, pageDownAndModifySelection:, pageUp:, pageUpAndModifySelection:, selectLine:, selectParagraph:, selectSentence:, and selectWord: to the list of commands that are forwarded to WebCore. (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Eliminated the long list of operations that we forward to WebCore. Instead, look up any command that WebCore can handle, after any that we handle specially in WebHTMLView. Also fixed a bug where an item that's not a menu item with changeBaseWritingDirection:NSWritingDirectionNatural would end up enabled instead of disabled and streamlined the logic for toggleGrammarChecking:. (-[WebHTMLView mouseDown:]): Removed unused firstResponderTextViewAtMouseDownTime. (-[WebHTMLView becomeFirstResponder]): Removed unused willBecomeFirstResponderForNodeFocus. (-[WebHTMLView resignFirstResponder]): Ditto. (-[WebHTMLView checkSpelling:]): Took unneeded extra initialization of NSSpellChecker.
  • WebView/WebHTMLViewInternal.h: Removed unused willBecomeFirstResponderForNodeFocus, firstResponderTextViewAtMouseDownTime, _textViewWasFirstResponderAtMouseDownTime: and _willMakeFirstResponderForNodeFocus.

WebKit/qt:

Reviewed by Alexey.

  • Api/qwebpage.cpp: (QWebPage::triggerAction): Removed some use of Editor member functions we plan to eventually eliminate. Switch from Editor::execCommand to Editor::command.
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent): Ditto. Also updated name from MoveUpByPageAndModifyCaret to MovePageUp and from MoveDownByPageAndModifyCaret to MovePageDown.

WebKit/win:

Reviewed by Alexey.

  • WebView.cpp: (WebView::execCommand): Switched from Editor::execCommand to Editor:command. Updated name from MoveUpByPageAndModifyCaret to MovePageUp and from MoveDownByPageAndModifyCaret to MovePageDown. (WebView::copy): Switched from Editor::execCommand to Editor:command. (WebView::cut): Ditto. (WebView::paste): Ditto. (WebView::delete_): Ditto.

WebKit/wx:

Reviewed by Alexey.

  • WebKitSupport/EditorClientWx.cpp: (WebCore::EditorClientWx::handleKeyboardEvent): Switched from Editor::execCommand to Edtor::command.

LayoutTests:

Reviewed by Alexey.

To avoid changing results at this time, I didn't correct the many tests that now have
misleading "this test cannot be run manually" text or references to "NSResponder" or
uneeded instructions for running the test manually. We can do that on a later pass.

  • editing/deleting/5300379.html: Use execCommand instead of doCommand.
  • editing/deleting/delete-to-end-of-paragraph.html: Ditto.
  • editing/deleting/smart-delete-003.html: Ditto.
  • editing/deleting/smart-delete-004.html: Ditto.
  • editing/execCommand/nsresponder-indent.html: Ditto.
  • editing/execCommand/nsresponder-outdent.html: Ditto.
  • editing/selection/4947387.html: Ditto.
  • editing/selection/5195166-1.html: Ditto.
  • editing/selection/5195166-2.html: Ditto.
  • editing/selection/select-line.html: Ditto.
  • editing/selection/selection-actions.html: Ditto.
11:55 AM Changeset in webkit [28716] by justin.garcia@apple.com
  • 8 edits
    6 adds in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5575101> GoogleDocs: Hang in SplitElementCommand::doApply when outdenting a list item in a particular list

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode): Moved here.
  • editing/CompositeEditCommand.h:
  • editing/IndentOutdentCommand.cpp: Moved splitTreeToNode.
  • editing/IndentOutdentCommand.h: Ditto, and removed unimplemented splitTreeTo.
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Split ancestors of listChildNode between it and listNode, if they exists, so that moving listChildNode doesn't put it out of order. Added a test case to cover each change.
  • editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::doApply): Added an ASSERT to catch code that tries to split a container at a bogus child, and an early return to avoid a hang in that case.

LayoutTests:

Reviewed by Darin Adler.


<rdar://problem/5575101> Hang in SplitElementCommand::doApply when outdenting a list item in a particular list

  • editing/execCommand/5575101-1-expected.txt: Added.
  • editing/execCommand/5575101-1.html: Added.
  • editing/execCommand/5575101-2-expected.txt: Added.
  • editing/execCommand/5575101-2.html: Added.
  • editing/execCommand/5575101-3-expected.txt: Added.
  • editing/execCommand/5575101-3.html: Added.
11:47 AM Changeset in webkit [28715] by andersca@apple.com
  • 11 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Darin and Geoff.

<rdar://problem/5619295>
REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)


Get rid of unnecessary and incorrect security checks for plug-ins accessing JavaScript objects.


The way this used to work was that each NPObject that wrapped a JSObject would have a root object
corresponding to the frame object (used for managing the lifecycle) and an origin root object (used for
doing security checks).


This would prevent a plug-in from accessing a frame's window object if it's security origin was different
(some parts of the window, such as the location object, can be accessed from frames with different security
origins, and those checks are being done in WebCore).


Also, if a plug-in were to access a window object of a frame that later went away, it could lead to that
Window JSObject being garbage collected and the NPObject pointing to freed memory.


How this works now is that there is no origin root object anymore, and all NPObject wrappers that are created
for a plug-in will have the root object of the containing frame of that plug-in.


  • bindings/NP_jsobject.cpp: (jsDeallocate): Don't free the origin root object.


(_NPN_CreateScriptObject):
Remove the origin root object parameter.


(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_GetProperty):
(_NPN_SetProperty):
(_NPN_RemoveProperty):
(_NPN_HasProperty):
(_NPN_HasMethod):
(_NPN_Enumerate):
Get rid of all security checks.


  • bindings/NP_jsobject.h: Remove originRootObject from the JavaScriptObject struct.


  • bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Always use the root object from the ExecState.

WebCore:

Reviewed by Darin and Geoff.

<rdar://problem/5619295>
REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)

_NPN_CreateScriptObject doesn't take an origin root object anymore.


  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::createNPObject):
  • page/Frame.cpp: (WebCore::Frame::windowScriptNPObject):

WebKitTools:

Reviewed by Darin and Geoff.

<rdar://problem/5619295>
REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)


Add property getting methods to the plug-in.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvoke):

LayoutTests:

Reviewed by Darin and Geoff.

<rdar://problem/5619295>
REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)


Add cross frame plug/in test where a plug/in inside an iframe tries to access properties of the
top-level frame.


  • http/tests/plugins/cross-frame-object-access-expected.txt: Added.
  • http/tests/plugins/cross-frame-object-access.html: Added.
  • http/tests/plugins/resources/cross-frame-object-access.html: Added.
11:37 AM Changeset in webkit [28714] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setShadow): Slightly increase the magnitude of the offsets passed to CGContextSetShadow* to ensure that the end result after truncation is the desired integer offsets.
10:34 AM Changeset in webkit [28713] by oliver@apple.com
  • 2 edits
    1 add in trunk/LayoutTests

Move layout test to mac skipped list until mac frt bug fixed.

Reviewed by Adam.

Fix test output, and move test to mac skipped list until
<rdar://problem/5647952> fast/events/mouseout-on-window.html
is fixed.

10:19 AM Changeset in webkit [28712] by kmccullough@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • Layout test fix for mac. When dumped to the console local file paths now only show the name of the resource not the whole path. This is to make the results machine and OS independent.
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:addMessageToConsole:]):
Note: See TracTimeline for information about the timeline view.