⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 17, 2007:

10:01 PM Changeset in webkit [28827] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

  • restore ButtonFace and ThreeDFace to their previous values for non-Mac platforms. The Mac port also uses the same values for now instead of NSColor-based ones.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::systemColor):
9:24 PM Changeset in webkit [28826] by mrowe@apple.com
  • 3 edits in trunk/WebCore

2007-12-17 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Maciej Stachowiak.

Define WTF_USE_NPOBJECT and WTF_USE_JAVASCRIPTCORE_BINDINGS for GTK+
Add required Frame::createScriptInstanceForWidget to FrameGtk

  • config.h:
  • page/gtk/FrameGtk.cpp (Frame::createScriptInstanceForWidget):
8:39 PM Changeset in webkit [28825] by mjs@apple.com
  • 4 edits in trunk

SunSpider:

Reviewed by Eric.


  • work around IE layout bugs
  • hosted/sunspider.css:

WebKitSite:

Reviewed by Eric.


  • work around IE layout bugs
  • perf/sunspider-0.9/sunspider.css:
6:21 PM Changeset in webkit [28824] by alice.liu@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Fixed <rdar://5566435> window with no scrollbars can be scrolled

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::maximumScroll): corrected maximumScroll() to account for scrolling not allowed. (WebCore::ScrollView::wheelEvent):
6:10 PM Changeset in webkit [28823] by alice.liu@apple.com
  • 3 edits
    2 adds in trunk/LayoutTests

Reviewed by Adam.

Test for <rdar://problem/5566435> window with no scrollbars can still be scrolled with wheelevent

  • fast/events/attempt-scroll-with-no-scrollbars-expected.txt: Added.
  • fast/events/attempt-scroll-with-no-scrollbars.html: Added.
  • platform/mac/Skipped: Adding to mac Skipped list because of <rdar://problem/5643675> window.scrollTo scrolls a window with no scrollbars
  • platform/win/Skipped: Adding to win Skipped list because of <rdar://problem/5132009> Windows DRT does not support multiple windows
5:30 PM Changeset in webkit [28822] by Darin Adler
  • 3 edits in trunk/WebKit/win

Reviewed by Sam.

  • <rdar://4516170> Back/Forward Cache on Windows
  • WebFrame.cpp: (WebFrame::forceLayout): Implemented this. Just calling through to Frame::forceLayout matches the Mac pretty well and should be enough for now. Without this we won't repaint the new page when we go back and forward. (WebFrame::dispatchWillSubmitForm): Use COMPtr's AdoptCOM constructor instead of the adoptRef function. (WebFrame::restoreViewState): Removed unneeded notImplemented() call. This is implemented as much as it needs to be. (WebFrame::shouldGoToHistoryItem): Ditto. (WebFrame::saveViewStateToItem): Ditto. (WebFrame::canCachePage): Ditto, also changed it to return true. This is what was preventing the back/forward cache from running, and there's no need for any additional checks in the Windows version.
  • WebView.cpp: (PreferencesChangedOrRemovedObserver::onNotify): Fix backwards null check that was preventing this notification from ever being sent, which in turn meant that page cache had a capacity of 0. (WebView::initWithFrame): Removed unneeded setUsesPageCache(false) code. This actually was ineffective and ended up doing no harm, but we don't need it.
5:07 PM Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@apple.com
(diff)
5:05 PM Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@apple.com
(diff)
3:10 PM Changeset in webkit [28821] by sfalken@apple.com
  • 3 edits in tags/Safari-525.3.2b/WebCore

Merged r28816.

2:54 PM Changeset in webkit [28820] by Darin Adler
  • 1 edit
    1 move in trunk/LayoutTests
  • disabling this test until we can find a way to make it pass on diverse machines
  • fast/css/css2-system-color.html: Removed.
  • fast/css/css2-system-color.html-disabled: Copied from fast/css/css2-system-color.html.
1:31 PM Changeset in webkit [28819] by sfalken@apple.com
  • 1 copy in tags/Safari-525.3.2b

New tag.

12:54 PM Changeset in webkit [28818] by alp@webkit.org
  • 12 edits
    2 deletes in trunk

2007-12-14 Juan A. Suarez Romero <​jasuarez@igalia.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16042
[GTK] Eliminate webkit_init()

Move webkit initialization to WebView class init.

12:51 PM Changeset in webkit [28817] by alp@webkit.org
  • 9 edits in trunk

2007-12-17 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=13542
gdklauncher doesnt change URL in adress GTKEntry.

Let DOMDocument observers do their work before emitting title-changed.
The load-committed signal has been added for both the view and the frame.

12:14 PM QtWebKitTodo edited by zander@kde.org
(diff)
11:48 AM Changeset in webkit [28816] by jhoneycutt@apple.com
  • 3 edits in trunk/WebCore

2007-12-17 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

<rdar://problem/5651291> REGRESSION: Flash content doesn't display
(www.adobe.com)

We were passing NPEvent instead of NPEvent* to NPP_HandleEvent.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::dispatchNPEvent): Changed to take NPEvent&, not NPEvent* (WebCore::PluginViewWin::paint): Pass NPEvent, not NPEvent* (WebCore::PluginViewWin::handleKeyboardEvent): same (WebCore::PluginViewWin::handleMouseEvent): same
  • plugins/win/PluginViewWin.h:
11:44 AM Changeset in webkit [28815] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Fix argument to window.open.

  • http/tests/misc/window-open-then-write.html:
10:42 AM Changeset in webkit [28814] by mrowe@apple.com
  • 3 edits in trunk/LayoutTests

2007-12-17 Mark Rowe <​mrowe@apple.com>

Update test results after r28812.

  • platform/mac-tiger/fast/css/css2-system-color-expected.txt:
  • platform/mac/fast/css/css2-system-color-expected.txt:
10:34 AM Changeset in webkit [28813] by ap@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Darin.

Live to the promise of never making AppKit special character codes visible via DOM.

Test: fast/events/arrow-keys-on-body.html

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Check for empty keypress characters after disambiguation, to let quirks-aware code strip special charactrers.
  • platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): If not in keyboard event quirks mode, remove the text if it's a special character.
10:21 AM Changeset in webkit [28812] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-12-17 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

Fix incorrect array size and incorrect array index in convertNSColorToColor.

  • rendering/RenderThemeMac.mm: (WebCore::convertNSColorToColor):
9:53 AM Changeset in webkit [28811] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::dispatchNextTaskIdentifier): Use a RefPtr for the database because there's no guarantee it won't lose its last reference otherwise.
9:09 AM Changeset in webkit [28810] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

  • fix <rdar://problem/5333260> Some Chinese characters in Text Encoding menu are bold, others are not and <rdar://problem/5280188> Chinese text looks worse on Safari for Windows cf. Safari for Mac
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters): To ensure that font linking gives consistent results for characters that are exclusive to the simplified Chinese code page and characters that belong to that code page and other code pages, always ask to map to simplified Chinese alone first.
8:18 AM Changeset in webkit [28809] by alp@webkit.org
  • 3 edits in trunk/WebCore

2007-12-17 Christian Dywan <​christian@twotoasts.de>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16378
Implement Icon for Gtk

Icon provides a GdkPixbuf containing a themed icon.
The icon theme is probed for an icon name according to the
Icon Naming Specification or conventional Gnome icon names respectively.

See ​http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html

  • platform/graphics/Icon.h:
  • platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::~Icon): (WebCore::lookupIconName): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint):
3:55 AM Changeset in webkit [28808] by mjs@apple.com
  • 1 copy in tags/SunSpider-0.9

Tag SunSpider 0.9.

3:55 AM Changeset in webkit [28807] by mjs@apple.com
  • 1 delete in tags/SunSpider-0.9

Remove bad tag

3:50 AM Changeset in webkit [28806] by mjs@apple.com
  • 4 edits in trunk

SunSpider:

Reviewed by Mark.


  • fix compare feature
  • hosted/sunspider-results.html:

WebKitSite:

Reviewed by Mark.


  • fix compare feature
  • perf/sunspider-0.9/sunspider-results.html:
3:23 AM QtWebKitTodo edited by Simon Hausmann
(diff)
1:44 AM Changeset in webkit [28805] by mjs@apple.com
  • 1 copy in tags/SunSpider-0.9

Tag SunSpider 0.9.

1:44 AM Changeset in webkit [28804] by mjs@apple.com
  • 1 delete in tags/SunSpider-0.9

Remove bad tag

1:44 AM Changeset in webkit [28803] by mjs@apple.com
  • 1 edit
    36 adds in trunk/WebKitSite

Rubber stamped by Mark.


  • Add a copy of SunSpider 0.9 to the site
  • perf: Added.
  • perf/sunspider-0.9: Added.
  • perf/sunspider-0.9/3d-cube.html: Added.
  • perf/sunspider-0.9/3d-morph.html: Added.
  • perf/sunspider-0.9/3d-raytrace.html: Added.
  • perf/sunspider-0.9/access-binary-trees.html: Added.
  • perf/sunspider-0.9/access-fannkuch.html: Added.
  • perf/sunspider-0.9/access-nbody.html: Added.
  • perf/sunspider-0.9/access-nsieve.html: Added.
  • perf/sunspider-0.9/bitops-3bit-bits-in-byte.html: Added.
  • perf/sunspider-0.9/bitops-bits-in-byte.html: Added.
  • perf/sunspider-0.9/bitops-bitwise-and.html: Added.
  • perf/sunspider-0.9/bitops-nsieve-bits.html: Added.
  • perf/sunspider-0.9/controlflow-recursive.html: Added.
  • perf/sunspider-0.9/crypto-aes.html: Added.
  • perf/sunspider-0.9/crypto-md5.html: Added.
  • perf/sunspider-0.9/crypto-sha1.html: Added.
  • perf/sunspider-0.9/date-format-tofte.html: Added.
  • perf/sunspider-0.9/date-format-xparb.html: Added.
  • perf/sunspider-0.9/math-cordic.html: Added.
  • perf/sunspider-0.9/math-partial-sums.html: Added.
  • perf/sunspider-0.9/math-spectral-norm.html: Added.
  • perf/sunspider-0.9/regexp-dna.html: Added.
  • perf/sunspider-0.9/string-base64.html: Added.
  • perf/sunspider-0.9/string-fasta.html: Added.
  • perf/sunspider-0.9/string-tagcloud.html: Added.
  • perf/sunspider-0.9/string-unpack-code.html: Added.
  • perf/sunspider-0.9/string-validate-input.html: Added.
  • perf/sunspider-0.9/sunspider-analyze-results.js: Added.
  • perf/sunspider-0.9/sunspider-compare-results.js: Added.
  • perf/sunspider-0.9/sunspider-driver.html: Added.
  • perf/sunspider-0.9/sunspider-record-result.js: Added.
  • perf/sunspider-0.9/sunspider-results.html: Added.
  • perf/sunspider-0.9/sunspider-test-prefix.js: Added.
  • perf/sunspider-0.9/sunspider.css: Added.
  • perf/sunspider-0.9/sunspider.html: Added.
1:43 AM Changeset in webkit [28802] by mjs@apple.com
  • 1 copy in tags/SunSpider-0.9/SunSpider

Tag SunSpider 0.9.

1:43 AM Changeset in webkit [28801] by mjs@apple.com
  • 3 edits in trunk/SunSpider

Reviewed by Mark.


  • Change the format of the output URL to be shorter, to meet IE constraints
  • hosted/sunspider-driver.html:
  • hosted/sunspider-results.html:
1:19 AM Changeset in webkit [28800] by mjs@apple.com
  • 1 copy in tags/SunSpider-0.9

Tag SunSpider 0.9.

12:56 AM Changeset in webkit [28799] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • speculative build fix for non-gcc platforms
  • pcre/pcre_exec.cpp: (match): Remove unused cases from return switch.

Dec 16, 2007:

11:19 PM Changeset in webkit [28798] by weinig@apple.com
  • 10 edits
    2 copies in trunk/WebCore

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16466
Move the JS Location object to its own file

  • Move Location into its own file and rename it JSLocation.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDocumentCustom.cpp:
  • bindings/js/JSLocation.cpp: Copied from WebCore/bindings/js/kjs_window.cpp. (WebCore::): (WebCore::JSLocation::JSLocation): (WebCore::JSLocation::getValueProperty): (WebCore::JSLocation::getOwnPropertySlot): (WebCore::JSLocation::put): (WebCore::JSLocationProtoFuncReplace::callAsFunction): (WebCore::JSLocationProtoFuncReload::callAsFunction): (WebCore::JSLocationProtoFuncAssign::callAsFunction): (WebCore::JSLocationProtoFuncToString::callAsFunction):
  • bindings/js/JSLocation.h: Copied from WebCore/bindings/js/kjs_window.h. (WebCore::JSLocation::): (WebCore::JSLocation::frame): (WebCore::JSLocation::classInfo):
  • bindings/js/kjs_window.cpp: (KJS::Window::location):
  • bindings/js/kjs_window.h:
  • history/CachedPage.cpp:
10:26 PM Changeset in webkit [28797] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • make 'cursor: copy' and 'cursor: none' work.

Already covered by manual-tests/cursor.html

  • rendering/RenderStyle.h: Increase the _cursor_style field to 6 bits, needed for the 33rd and 34th cursor values.
10:01 PM Changeset in webkit [28796] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Speculative build fix for non-Mac platforms.

10:00 PM Changeset in webkit [28795] by mrowe@apple.com
  • 10 edits
    2 copies
    1 move
    1 delete in trunk

Refactor Mac plugin stream code to use the shared NetscapePlugInStreamLoader implementation.

Reviewed by Maciej Stachowiak.

8:50 PM Changeset in webkit [28794] by weinig@apple.com
  • 9 edits
    2 copies in trunk/WebCore

Reviewed by Maciej.

Yet more of ​http://bugs.webkit.org/show_bug.cgi?id=16385
Cleanup kjs_window

  • Move ScheduledAction into its own file and put it in the WebCore namespace.
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/PausedTimeouts.cpp:
  • bindings/js/PausedTimeouts.h:
  • bindings/js/ScheduledAction.cpp: Copied from bindings/js/kjs_window.cpp. (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h: Copied from bindings/js/kjs_window.h. (WebCore::ScheduledAction::ScheduledAction):
  • bindings/js/kjs_window.cpp: (KJS::DOMWindowTimer::DOMWindowTimer): (KJS::DOMWindowTimer::action): (KJS::DOMWindowTimer::takeAction): (KJS::Window::installTimeout): (KJS::Window::timerFired):
  • bindings/js/kjs_window.h:
8:19 PM Changeset in webkit [28793] by Darin Adler
  • 10 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • ​http://bugs.webkit.org/show_bug.cgi?id=16438
  • removed some more unused code
  • changed quite a few more names to WebKit-style
  • moved more things out of pcre_internal.h
  • changed some indentation to WebKit-style
  • improved design of the functions for reading and writing 2-byte values from the opcode stream (in pcre_internal.h)
  • pcre/dftables.cpp: (main): Added the kjs prefix a normal way in lieu of using macros.
  • pcre/pcre_compile.cpp: Moved some definitions here from pcre_internal.h. (errorText): Name changes, fewer typedefs. (checkEscape): Ditto. Changed uppercase conversion to use toASCIIUpper. (isCountedRepeat): Name change. (readRepeatCounts): Name change. (firstSignificantOpcode): Got rid of the use of OP_lengths, which is very lightly used here. Hard-coded the length of OP_BRANUMBER. (firstSignificantOpcodeSkippingAssertions): Ditto. Also changed to use the advanceToEndOfBracket function. (getOthercaseRange): Name changes. (encodeUTF8): Ditto. (compileBranch): Name changes. Removed unused after_manual_callout and the code to handle it. Removed code to handle OP_ONCE since we never emit this opcode. Changed to use advanceToEndOfBracket in more places. (compileBracket): Name changes. (branchIsAnchored): Removed code to handle OP_ONCE since we never emit this opcode. (bracketIsAnchored): Name changes. (branchNeedsLineStart): More fo the same. (bracketNeedsLineStart): Ditto. (branchFindFirstAssertedCharacter): Removed OP_ONCE code. (bracketFindFirstAssertedCharacter): More of the same. (calculateCompiledPatternLengthAndFlags): Ditto. (returnError): Name changes. (jsRegExpCompile): Ditto.
  • pcre/pcre_exec.cpp: Moved some definitions here from pcre_internal.h. (matchRef): Updated names. Improved macros to use the do { } while(0) idiom so they expand to single statements rather than to blocks or multiple statements. And refeactored the recursive match macros. (MatchStack::pushNewFrame): Name changes. (getUTF8CharAndIncrementLength): Name changes. (match): Name changes. Removed the ONCE opcode. (jsRegExpExecute): Name changes.
  • pcre/pcre_internal.h: Removed quite a few unneeded includes. Rewrote quite a few comments. Removed the macros that add kjs prefixes to the functions with external linkage; instead renamed the functions. Removed the unneeded typedefs pcre_uint16, pcre_uint32, and uschar. Removed the dead and not-all-working code for LINK_SIZE values other than 2, although we aim to keep the abstraction working. Removed the OP_LENGTHS macro. (put2ByteValue): Replaces put2ByteOpcodeValueAtOffset. (get2ByteValue): Replaces get2ByteOpcodeValueAtOffset. (put2ByteValueAndAdvance): Replaces put2ByteOpcodeValueAtOffsetAndAdvance. (putLinkValueAllowZero): Replaces putOpcodeValueAtOffset; doesn't do the addition, since a comma is really no better than a plus sign. Added an assertion to catch out of range values and changed the parameter type to int rather than unsigned. (getLinkValueAllowZero): Replaces getOpcodeValueAtOffset. (putLinkValue): New function that most former callers of the putOpcodeValueAtOffset function can use; asserts the value that is being stored is non-zero and then calls putLinkValueAllowZero. (getLinkValue): Ditto. (putLinkValueAndAdvance): Replaces putOpcodeValueAtOffsetAndAdvance. No caller was using an offset, which makes sense given the advancing behavior. (putLinkValueAllowZeroAndAdvance): Ditto. (isBracketOpcode): Added. For use in an assertion. (advanceToEndOfBracket): Renamed from moveOpcodePtrPastAnyAlternateBranches, and removed comments about how it's not well designed. This function takes a pointer to the beginning of a bracket and advances to the end of the bracket.
  • pcre/pcre_tables.cpp: Updated names.
  • pcre/pcre_ucp_searchfuncs.cpp: (kjs_pcre_ucp_othercase): Ditto.
  • pcre/pcre_xclass.cpp: (getUTF8CharAndAdvancePointer): Ditto. (kjs_pcre_xclass): Ditto.
  • pcre/ucpinternal.h: Ditto.
  • wtf/ASCIICType.h: (WTF::isASCIIAlpha): Added an int overload, like the one we already have for isASCIIDigit. (WTF::isASCIIAlphanumeric): Ditto. (WTF::isASCIIHexDigit): Ditto. (WTF::isASCIILower): Ditto. (WTF::isASCIISpace): Ditto. (WTF::toASCIILower): Ditto. (WTF::toASCIIUpper): Ditto.
8:08 PM Changeset in webkit [28792] by alp@webkit.org
  • 4 edits
    2 adds in trunk/WebCore

2007-12-16 Alp Toker <​alp@atoker.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=16356
[GTK] Integrate GStreamer video with the graphics backend

Integrate the GStreamer media backend with the Cairo graphics backend.
There are still some issues: Data is copied more often than necessary,
and repaint() is not called, causing transformed video not to update
sometimes.

  • WebCore.pro:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::setEndTime): (WebCore::MediaPlayerPrivate::seeking): (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::setRect): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::repaint): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gtk/VideoSinkGStreamer.cpp: Added. (webkit_video_sink_base_init): (webkit_video_sink_init): (webkit_video_sink_idle_func): (webkit_video_sink_render): (webkit_video_sink_set_caps): (webkit_video_sink_dispose): (webkit_video_sink_finalize): (webkit_video_sink_set_property): (webkit_video_sink_get_property): (webkit_video_sink_stop): (webkit_video_sink_class_init): (webkit_video_sink_new): (webkit_video_sink_set_surface): (plugin_init):
  • platform/graphics/gtk/VideoSinkGStreamer.h: Added.
6:09 PM Changeset in webkit [28791] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-12-16 Mark Rowe <​mrowe@apple.com>

Mac build fix.

  • WebCore.xcodeproj/project.pbxproj: Remove NetscapePlugInStreamLoader.cpp from the WebCore target. Mac currently has its own implementation in NetscapePlugInStreamLoaderMac.mm which conflicts with the new shared implementation.
5:50 PM Changeset in webkit [28790] by mrowe@apple.com
  • 3 edits
    1 delete in trunk/WebCore

2007-12-16 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Maciej Stachowiak.

​http://bugs.webkit.org/show_bug.cgi?id=16389
Bug 16389: Common Implementation of NetscapePlugInStreamLoader

  • WebCore.vcproj/WebCore.vcproj: Remove NetscapePlugInStreamLoaderWin.cpp.
  • loader/NetscapePlugInStreamLoader.cpp: Copy method implementations from NetscapePlugInStreamLoaderWin.cpp.
  • loader/win/NetscapePlugInStreamLoaderWin.cpp: Removed.
5:35 PM Changeset in webkit [28789] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

2007-12-16 Dimitri Glazkov <​dimitri@glazkov.com>

Reviewed by Adam Roben.

Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.

  • FindSafari/FindSafari.cpp: (_tmain):
5:33 PM Changeset in webkit [28788] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

2007-12-16 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=16315
FindSafari needs a path-only option.

  • FindSafari/FindSafari.cpp: (_tmain):
5:31 PM Changeset in webkit [28787] by Darin Adler
  • 2 edits in trunk/LayoutTests
  • fast/js/regexp-overflow-expected.txt: Updated. I accidentally checked in an out-of-date file last time.
5:28 PM Changeset in webkit [28786] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Darin Adler.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=16433.
Bug 16433: LOW_BANDWIDTH_DISPLAY build is broken

  • dom/Document.cpp: (WebCore::Document::Document):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addLowBandwidthDisplayRequest): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
5:26 PM Changeset in webkit [28785] by Darin Adler
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

The problem was that \B was not handled properly in character classes.

Test: fast/js/regexp-overflow.html

  • pcre/pcre_compile.cpp: (check_escape): Added handling of ESC_b and ESC_B in character classes here. Allows us to get rid of the handling of \b in character classes from all the call sites that handle it separately and to handle \B properly as well. (compileBranch): Remove the ESC_b handling, since it's not needed any more. (calculateCompiledPatternLengthAndFlags): Ditto.

LayoutTests:

Reviewed by Maciej.

  • fast/js/regexp-overflow-expected.txt: Updated.
  • fast/js/resources/regexp-overflow.js: Added test cases.
5:26 PM Changeset in webkit [28784] by mrowe@apple.com
  • 3 edits in trunk/WebCore

2007-12-16 Grace Kloba <​klobag@gmail.com>

Reviewed by Darin Adler.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=16433.
Bug 16433: LOW_BANDWIDTH_DISPLAY build is broken

  • dom/Document.cpp: (WebCore::Document::Document):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addLowBandwidthDisplayRequest): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
5:20 PM Changeset in webkit [28783] by mrowe@apple.com
  • 2 edits
    2 adds in trunk/WebKitSite

2007-12-16 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Maciej Stachowiak.

​http://bugs.webkit.org/show_bug.cgi?id=16446.

  • building/debug.html: Update to expand the win32 debugging instructions.
5:14 PM Changeset in webkit [28782] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix ​http://bugs.webkit.org/show_bug.cgi?id=16448 ([GTK] Celtic Kane JavaScript performance on Array test is slow relative to Mac).

Reviewed by Maciej Stachowiak.

  • kjs/array_instance.cpp:

(KJS::compareByStringPairForQSort):
(KJS::ArrayInstance::sort): Convert JSValue's to strings once up front and then sort the
results. This avoids calling toString twice per comparison, but requires a temporary buffer
so we only use this approach in cases where the array being sorted is not too large.

4:24 PM Changeset in webkit [28781] by Darin Adler
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

More of ​http://bugs.webkit.org/show_bug.cgi?id=16385
Cleanup kjs_window

  • Move PausedTimeouts into its own file and put it in the WebCore namespace.
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/PausedTimeouts.cpp: Copied from bindings/js/kjs_window.cpp.
  • bindings/js/PausedTimeouts.h: Copied from bindings/js/kjs_window.h.
  • bindings/js/kjs_window.cpp: (KJS::Window::pauseTimeouts):
  • bindings/js/kjs_window.h:
  • history/CachedPage.cpp:
  • history/CachedPage.h:
  • page/Chrome.cpp:

LayoutTests:

Reviewed by Maciej.

  • tests for the argument handling of the executeSql function
  • storage/execute-sql-args-expected.txt: Added.
  • storage/execute-sql-args.html: Added.
4:17 PM Changeset in webkit [28780] by Darin Adler
  • 2 edits
    3 copies
    2 adds in trunk/LayoutTests
  • try to get the system color test passing on the buildbot

I fear this test may be vulnerable to slight platform differences.

  • platform/mac-tiger/fast: Added.
  • platform/mac-tiger/fast/css: Added.
  • platform/mac-tiger/fast/css/css2-system-color-expected.checksum: Copied from platform/mac/fast/css/css2-system-color-expected.checksum.
  • platform/mac-tiger/fast/css/css2-system-color-expected.png: Copied from platform/mac/fast/css/css2-system-color-expected.png.
  • platform/mac-tiger/fast/css/css2-system-color-expected.txt: Copied from platform/mac/fast/css/css2-system-color-expected.txt. Then updated to match what the buildbot says.
  • platform/mac/fast/css/css2-system-color-expected.txt: Updated to match results I'm getting locally on my Leopard machine.
3:59 PM Changeset in webkit [28779] by weinig@apple.com
  • 10 edits
    2 copies in trunk/WebCore

Reviewed by Darin.

More of ​http://bugs.webkit.org/show_bug.cgi?id=16385
Cleanup kjs_window

  • Move PausedTimeouts into its own file and put it in the WebCore namespace.
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/PausedTimeouts.cpp: Copied from bindings/js/kjs_window.cpp.
  • bindings/js/PausedTimeouts.h: Copied from bindings/js/kjs_window.h.
  • bindings/js/kjs_window.cpp: (KJS::Window::pauseTimeouts):
  • bindings/js/kjs_window.h:
  • history/CachedPage.cpp:
  • history/CachedPage.h:
  • page/Chrome.cpp:
3:08 PM Changeset in webkit [28778] by Beth Dakin
  • 4 edits
    10 adds in trunk

WebCore:

Reviewed by Geoff.

Make relative-size SVGs work in border-image.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calculateBackgroundSize):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintBorderImage):

LayoutTests:

Reviewed by Geoff.

Tests for SVG as border-image.

  • fast/borders/resources/green-fixed-size-rect.svg: Added.
  • fast/borders/resources/green-relative-size-rect.svg: Added.
  • fast/borders/svg-as-border-image-2.html: Added.
  • fast/borders/svg-as-border-image.html: Added.
  • platform/mac/fast/borders/svg-as-border-image-2-expected.checksum: Added.
  • platform/mac/fast/borders/svg-as-border-image-2-expected.png: Added.
  • platform/mac/fast/borders/svg-as-border-image-2-expected.txt: Added.
  • platform/mac/fast/borders/svg-as-border-image-expected.checksum: Added.
  • platform/mac/fast/borders/svg-as-border-image-expected.png: Added.
  • platform/mac/fast/borders/svg-as-border-image-expected.txt: Added.
2:53 PM Changeset in webkit [28777] by ggaren@apple.com
  • 6 edits
    1 copy in trunk/JavaScriptCore

Reviewed by Darin Adler and Maciej Stachowiak.


More refactoring to support global variable optimization.


Changed SymbolTable to use RefPtr<UString::Rep> as its key instead of
UString::Rep*. With globals, the symbol table can outlast the
declaration node for any given symbol, so the symbol table needs to ref
its symbol names.


In support, specialized HashMaps with RefPtr keys to allow lookup
via raw pointer, avoiding refcount churn.


SunSpider reports a .6% speedup (prolly just noise).

  • kjs/JSVariableObject.cpp: (KJS::JSVariableObject::getPropertyNames): Symbol table keys are RefPtrs now.
  • kjs/SymbolTable.h: Modified key traits to match RefPtr. Added a static Rep* for null, which helps compute the deletedValue() trait.
  • wtf/HashMap.h: #include the RefPtr specialization so everyone can use it.
  • wtf/RefPtrHashMap.h: Copied from wtf/HashMap.h. Added overloaded versions of find(), contains(), get(), set(), add(), remove(), and take() that take raw pointers as keys.
12:43 PM QtWebKitTodo edited by Simon Hausmann
(diff)
12:14 PM Changeset in webkit [28776] by Darin Adler
  • 2 edits in trunk/WebCore
  • fix Tiger build (my fault it was broken)
  • rendering/RenderThemeMac.mm: Define NSUInteger if on Tiger.
11:26 AM Changeset in webkit [28775] by Darin Adler
  • 10 edits
    4 adds in trunk

WebCore:

Reviewed by Darin.


​http://bugs.webkit.org/show_bug.cgi?id=6129
Incomplete implementation of CSS 2.1 system colors

Test: fast/css/css2-system-color.html


Based on original patch by Rob Buis.


System colors are retrieved from NSColor as appropriate. If the color is a pattern color
(and therefore NSColor won't let us retrieve a color from it) we draw a 1x1 image of the
color and sample that to get a solid color.

  • css/CSSStyleSelector.cpp: (WebCore::): (WebCore::colorForCSSValue):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::systemColor):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::getSystemColor): (WebCore::RenderThemeMac::platformColorsDidChange): (WebCore::RenderThemeMac::systemColor):

LayoutTests:

Reviewed by Darin.


​http://bugs.webkit.org/show_bug.cgi?id=6129
Incomplete implementation of CSS 2.1 system colors


Add layout test for this bug and update tests for new system-derived colors

  • fast/css/css2-system-color.html: Added.
  • platform/mac/fast/css/css2-system-color-expected.checksum: Added.
  • platform/mac/fast/css/css2-system-color-expected.png: Added.
  • platform/mac/fast/css/css2-system-color-expected.txt: Added.
  • platform/mac/fast/css/css2-system-fonts-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug103533-expected.txt:
10:40 AM Changeset in webkit [28774] by mitz@apple.com
  • 4 edits
    5 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/overflow/scrollbar-position-update.html

  • platform/mac/PlatformScrollBarMac.mm: (WebCore::PlatformScrollbar::updateThumbProportion): Update the NSScroller's value for the new proportions.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout): Removed unnecessary repaint(). Scrollbars repaint themselves as needed.

LayoutTests:

Reviewed by Darin Adler.

  • fast/overflow/scrollbar-position-update.html: Added.
  • platform/mac-leopard/fast/overflow: Added.
  • platform/mac-leopard/fast/overflow/scrollbar-position-update-expected.checksum: Added.
  • platform/mac-leopard/fast/overflow/scrollbar-position-update-expected.png: Added.
  • platform/mac/fast/overflow/scrollbar-position-update-expected.txt: Added.
10:13 AM Changeset in webkit [28773] by Darin Adler
  • 2 edits in trunk/WebKit/wx
  • try to fix the build
  • WebView.cpp: (wxWebView::OnKeyEvents): Add a WebCore prefix.
9:37 AM Changeset in webkit [28772] by ap@webkit.org
  • 6 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14140
<rdar://problem/5270958> REGRESSION: Complex system KeyBindings don't work properly

WebCore:

  • dom/KeyboardEvent.h: (WebCore::KeypressCommand::KeypressCommand): (WebCore::KeyboardEvent::keypressCommands): Change stored command class to preserve complete information about commands.
  • editing/EditorCommand.cpp: (WebCore::CommandEntry::): Mark InsertText as a text insertion command, which it is. Previously, we couldn't do it because WebKit didn't really treat insertText: as a command.
  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Copy commands saved while interpreting a keydown event into keypress, to avoid losing state when running interpretKeyEvents: again.

WebKit:

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): Made command replaying work when handling keypress, too. (-[WebHTMLView doCommandBySelector:]): Adapted for the new way to store commands in events. (-[WebHTMLView insertText:]): Append a command, not replace the whole existing vector. Also, restore the state for additional commands to be saved correctly.
9:31 AM Changeset in webkit [28771] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=16162
Problems with float parsing on Linux (locale-dependent parsing was used).

  • kjs/dtoa.cpp: Removed USE_LOCALE to reduce future confusion.
  • kjs/lexer.cpp: (KJS::Lexer::lex): Parse with kjs_strtod, not the system one.
9:23 AM QtWebKitTodo edited by zander@kde.org
(diff)
8:16 AM Changeset in webkit [28770] by ap@webkit.org
  • 9 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=16462
REGRESSION: access keys broken on Windows

5:20 AM Changeset in webkit [28769] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-16 Xan Lopez <​xan@gnome.org>

Reviewed by Alexey Proskuryakov.

​http://bugs.webkit.org/show_bug.cgi?id=16454
[GTK] Text input doesn't work consistently on PPC

  • platform/gtk/KeyEventGtk.cpp: (WebCore::singleCharacterString):

UChar is 2 bytes (UTF-16), so transform accordingly from
gunichar (UCS-4). Fixes keyboard input on big endian systems.

Note: See TracTimeline for information about the timeline view.