Context Navigation

← Previous Period
Next Period →

Timeline

Dec 18, 2007:

11:53 PM Changeset in webkit [28856] by Beth Dakin

8 edits
5 adds in trunk

WebCore:

Reviewed by Oliver.

Fix for <rdar://problem/5616982> SVGs with width and height 100%
fail to render when used as <img> or CSS image (16167)

This final part of the work fixes the <img> tag.

This is the real fix.

rendering/RenderImage.cpp: (WebCore::RenderImage::calcReplacedWidth): Set the container size on the image. Setting the container size only actually sticks if the values are non-zero, so if the container size really was set, use the imageSize that is calculated using the container size. If it did not stick but the image does have relative width (meaning that the container size is 0), set the width to 0 by hand. We want to avoid setting the width before we have a container size or we will end up incorrectly using the default size of 300x150. (WebCore::RenderImage::calcReplacedHeight): Same as above, but for height.

A few more pieces of information have to be exposed through cached
image to make this happen.

loader/CachedImage.cpp: (WebCore::CachedImage::usesImageContainerSize): As mentioned above, when setContainerSize() is called, the container size is only actually set if the values are non-zero. This call tells you if it was set. (WebCore::CachedImage::imageHasRelativeWidth): (WebCore::CachedImage::imageHasRelativeHeight):
loader/CachedImage.h:
platform/graphics/Image.h: (WebCore::Image::usesContainerSize):
svg/graphics/SVGImage.cpp: (WebCore::SVGImage::usesContainerSize):
svg/graphics/SVGImage.h:

LayoutTests:

Reviewed by Oliver.

Test for <rdar://problem/5616982> SVGs with width and height 100%
fail to render when used as <img> or CSS image (16167)

fast/images/resources/green-relative-size-rect.svg: Added.
fast/images/svg-as-relative-image.html: Added.
platform/mac/fast/images/svg-as-relative-image-expected.checksum: Added.
platform/mac/fast/images/svg-as-relative-image-expected.png: Added.
platform/mac/fast/images/svg-as-relative-image-expected.txt: Added.

11:42 PM Changeset in webkit [28855] by oliver@apple.com

3 edits in trunk/JavaScriptCore

Remove dead code due to removal of post-parse declaration discovery.

RS=Geoff.

Due to the removal of the declaration discovery pass after parsing we
no longer need any of the logic used for that discovery.

11:42 PM Changeset in webkit [28854] by oliver@apple.com

7 edits in trunk/JavaScriptCore

Replace post-parse pass to find declarations with logic in the parser itself

Reviewed by Geoff.

Instead of finding declarations in a pass following the initial parsing of
a program, we incorporate the logic directly into the parser. This lays
the groundwork for further optimisations (such as improving performance in
declaration expressions -- var x = y; -- to match that of standard assignment)
in addition to providing a 0.4% performance improvement in SunSpider.

9:04 PM Changeset in webkit [28853] by mrowe@apple.com

4 edits in trunk

Versioning.

9:02 PM Changeset in webkit [28852] by mrowe@apple.com

1 copy in tags/Safari-4525.1

New tag.

9:02 PM Changeset in webkit [28851] by mrowe@apple.com

1 copy in tags/Safari-5525.1

New tag.

8:58 PM Changeset in webkit [28850] by mrowe@apple.com

4 edits in trunk

Fix typo in hosted SunSpider page.

8:54 PM Changeset in webkit [28849] by sfalken@apple.com

2 edits in trunk/WebKitSite

Correct link to Visual Studio Express 2005.
Old link points to 2008.

Reviewed by Mark.

building/tools.html:

7:11 PM Changeset in webkit [28848] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.

6:58 PM Changeset in webkit [28847] by ddkilzer@apple.com

2 edits in trunk/JavaScriptCore

2007-12-18 Xan Lopez <xan@gnome.org>

Reviewed by Geoff.

Fix http://bugs.webkit.org/show_bug.cgi?id=14521
Bug 14521: JavaScriptCore fails to build on Linux/PPC gcc 4.1.2

wtf/TCSpinLock.h: (TCMalloc_SpinLock::Unlock):

Use less strict memory operand constraint on inline asm generation.
PLATFORM(DARWIN) left unpatched due to Apple's GCC bug.

Patch by David Kilzer <ddkilzer@webkit.org>

6:12 PM Changeset in webkit [28846] by mrowe@apple.com

2 edits
2 deletes in trunk

Remove outdated and non-functioning project files for the Apollo port. Rubber-stamped by Maciej Stachowiak and Chris Brichford.

5:41 PM Changeset in webkit [28845] by mitz@apple.com

2 edits in trunk/LayoutTests

Reviewed by John Sullivan.

remove passing test and reclassify one failing test

platform/win/Skipped: Removed fast/text/international/002.html.

5:12 PM Changeset in webkit [28844] by weinig@apple.com

3 edits in trunk/LayoutTests

Reviewed by Geoffrey.

Temporarily remove calls that are causing subsequent tests in DRT to fail. Filled http://bugs.webkit.org/show_bug.cgi?id=16510 to track the issue.

http/tests/security/cross-frame-access-history-expected.txt:
http/tests/security/cross-frame-access-history.html:

4:58 PM Changeset in webkit [28843] by sfalken@apple.com

1 edit
1 add in trunk/WebKitTools

Add script to run Drosera as part of the nightly.

Reviewed by Kevin M.

Scripts/run-drosera.cmd: Added.

4:35 PM Changeset in webkit [28842] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: Remove a stray K.

4:34 PM Changeset in webkit [28841] by Darin Adler

2 edits in trunk/JavaScriptCore

fix Windows build

pcre/pcre_exec.cpp: (jsRegExpExecute): Change back from false/true to 0/1 -- I probably should not have deleted MATCH_MATCH and MATCH_NOMATCH, but I'm going to leave them out.

3:40 PM Changeset in webkit [28840] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: Plan more renaming.

3:38 PM Changeset in webkit [28839] by sfalken@apple.com

2 edits in trunk/WebCore

<rdar://problem/5649911> REGRESSION (304-306A9): Typing 'p' in popup menu for type-to-select brings up Safari Help

Need to translate the char back into a key code for posting our WM_KEYDOWN.

Reviewed by Ada.

platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc):

2:56 PM Changeset in webkit [28838] by sfalken@apple.com

2 edits in trunk/WebCore

<rdar://problem/5651534> REGRESSION(r28764-r28765): GDI leak drawing text when no appropriate font is available

Our captured metafile from Uniscribe may contain multiple calls to CreateFontIndirect.
Only create a font with the last one.

Reviewed by Mitz, Darin.

platform/graphics/win/FontCacheWin.cpp: (WebCore::metaFileEnumProc): (WebCore::FontCache::getFontDataForCharacters):

2:32 PM Changeset in webkit [28837] by Darin Adler

3 edits in trunk/LayoutTests

fix failing regression test

fast/regex/resources/TEMPLATE.html: Updated this template -- I accidentally landed the one that was copied without updating the paths.
fast/regex/slow.html: Regenerated.

1:50 PM Changeset in webkit [28836] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Reviewed by Darin.

Fixed <rdar://problem/5646454> REGRESSION: dom/xhtml/level2/html/HTMLDocument12 fails on Leopard

fast/cookies/local-file-can-set-cookies.html: cookies are matched by domain and path, and since layout tests are file URLs, they all match on domain. setting a cookie without specifying the path will make CFNetwork pick up the path from the URL automatically. Since fast/cookies/local-file-can-set-cookies.html set a specific path of /, that cookie will be set for EVERY local file loaded in Safari. removing that component from the cookie string will fix the problem.

1:37 PM Changeset in webkit [28835] by alp@webkit.org

5 edits
2 adds in trunk/WebCore

2007-12-17 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16464
Modify WebCore to use win32 thread primitives

Updates to support native windows threading primitives
rather than pthreads emulation library.

WebCore.vcproj/WebCore.vcproj:
config.h:
platform/Threading.h:
platform/win/MutexWin.cpp: Added. (WebCore::Mutex::Mutex): (WebCore::Mutex::~Mutex): (WebCore::Mutex::lock): (WebCore::Mutex::tryLock): (WebCore::Mutex::unlock):
platform/win/ThreadConditionWin.cpp: Added. (WebCore::ThreadCondition::ThreadCondition): (WebCore::ThreadCondition::~ThreadCondition): (WebCore::ThreadCondition::wait): (WebCore::ThreadCondition::signal): (WebCore::ThreadCondition::broadcast):
platform/win/ThreadingWin.cpp: (WebCore::threadMapMutex): (WebCore::threadMap): (WebCore::storeThreadHandleByIdentifier): (WebCore::identifierByThreadHandle): (WebCore::threadHandleForIdentifier): (WebCore::clearThreadHandleForIdentifier): (WebCore::createThread): (WebCore::waitForThreadCompletion): (WebCore::detachThread): (WebCore::currentThread):

1:36 PM Changeset in webkit [28834] by alp@webkit.org

2 edits in trunk/WebCore

2007-12-18 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed by Darin Adler.

Handle EINTR when set by select() and try the select() again
http://bugs.webkit.org/show_bug.cgi?id=16071

platform/network/curl/ResourceHandleManager.cpp: (ResourceHandleManager::downloadTimerCallback):

11:30 AM Changeset in webkit [28833] by Darin Adler

4 edits
1 copy
4 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

test for http://bugs.webkit.org/show_bug.cgi?id=16458 REGRESSION (r28164): regular expressions can now hang due to lack of a match limit <rdar://problem/5636067>

Test: fast/regex/slow.html

Slows down SunSpider a bit (about 1.01x); filed a bug to follow up on that:
http://bugs.webkit.org/show_bug.cgi?id=16503

pcre/pcre.h: Changed name of error code to not specifically mention "recursion".
pcre/pcre_exec.cpp: (match): Replaced the depth limit, MATCH_RECURSION_LIMIT, with a total match looping limit, matchLimit. Also eliminated the constants for MATCH_MATCH and MATCH_NOMATCH, since they are just true and false (1 and 0). (jsRegExpExecute): More of the MATCH_MATCH change.

LayoutTests:

Reviewed by Geoff.

test for http://bugs.webkit.org/show_bug.cgi?id=16458 REGRESSION (r28164): regular expressions can now hang due to lack of a match limit

fast/regex/resources: Added.
fast/regex/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
fast/regex/resources/slow.js: Added.
fast/regex/slow-expected.txt: Added.
fast/regex/slow.html: Added.

10:58 AM Changeset in webkit [28832] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

avoid the simplified Chinese font linking code for characters that are not in any Windows code page

platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters):

10:35 AM Changeset in webkit [28831] by mitz@apple.com

2 edits in trunk/LayoutTests

Reviewed by John Sullivan.

remove passing test

platform/win/Skipped: Removed fast/text/international/wrap-CJK-001.html

10:19 AM Changeset in webkit [28830] by beidson@apple.com

7 edits in trunk/WebCore

Reviewed by Adele

<rdar://problem/5525770> REGRESSION: HTTP Auth protected favicon request results in a password sheet

Some http-auth protected sites have the main resource(s) unprotected, but many subresources are
protected by authentication. Occasionally one can view the main page of a site but the favicon
is behind the iron curtain - in these cases, we should *not* prompt for a username and password
solely for the favicon.

loader/ResourceLoader.h: Make didReceiveAuthenticationChallenge virtual

loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveAuthenticationChallenge): Now that this method is virtual from ResourceLoader, SubresourceLoader can override. First call to the SubresourceLoaderClient. If they cancel the resource load, return early. Otherwise, let ResourceLoader work its magic (resulting in the auth sheet coming down)
loader/SubresourceLoader.h:

loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didReceiveAuthenticationChallenge):

loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveAuthenticationChallenge): Cancel the resource load, since we should never prompt the user for credentials just for a favicon.
loader/icon/IconLoader.h:

9:07 AM Changeset in webkit [28829] by sullivan@apple.com

2 edits in trunk/WebCore

Reviewed by Brady

fixed <rdar://problem/5652380> Initial prompt shows "" for databases with no user-visible name

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase): pass "name" instead of "displayName" if there's no displayName

1:27 AM Changeset in webkit [28828] by mjs@apple.com

2 edits in trunk/SunSpider

Reviewed by Eric.

give an extra digit of precision for small differences.

resources/sunspider-compare-results.js:

Dec 17, 2007:

10:01 PM Changeset in webkit [28827] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

restore ButtonFace and ThreeDFace to their previous values for non-Mac platforms. The Mac port also uses the same values for now instead of NSColor-based ones.

rendering/RenderTheme.cpp: (WebCore::RenderTheme::systemColor):

9:24 PM Changeset in webkit [28826] by mrowe@apple.com

3 edits in trunk/WebCore

2007-12-17 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed by Maciej Stachowiak.

Define WTF_USE_NPOBJECT and WTF_USE_JAVASCRIPTCORE_BINDINGS for GTK+
Add required Frame::createScriptInstanceForWidget to FrameGtk

config.h:
page/gtk/FrameGtk.cpp (Frame::createScriptInstanceForWidget):

8:39 PM Changeset in webkit [28825] by mjs@apple.com

4 edits in trunk

SunSpider:

Reviewed by Eric.

work around IE layout bugs

hosted/sunspider.css:

WebKitSite:

Reviewed by Eric.

work around IE layout bugs

perf/sunspider-0.9/sunspider.css:

6:21 PM Changeset in webkit [28824] by alice.liu@apple.com

2 edits in trunk/WebCore

Reviewed by Adam.

Fixed <rdar://5566435> window with no scrollbars can be scrolled

platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::maximumScroll): corrected maximumScroll() to account for scrolling not allowed. (WebCore::ScrollView::wheelEvent):

6:10 PM Changeset in webkit [28823] by alice.liu@apple.com

3 edits
2 adds in trunk/LayoutTests

Reviewed by Adam.

Test for <rdar://problem/5566435> window with no scrollbars can still be scrolled with wheelevent

fast/events/attempt-scroll-with-no-scrollbars-expected.txt: Added.
fast/events/attempt-scroll-with-no-scrollbars.html: Added.
platform/mac/Skipped: Adding to mac Skipped list because of <rdar://problem/5643675> window.scrollTo scrolls a window with no scrollbars
platform/win/Skipped: Adding to win Skipped list because of <rdar://problem/5132009> Windows DRT does not support multiple windows

5:30 PM Changeset in webkit [28822] by Darin Adler

3 edits in trunk/WebKit/win

Reviewed by Sam.

<rdar://4516170> Back/Forward Cache on Windows

WebFrame.cpp: (WebFrame::forceLayout): Implemented this. Just calling through to Frame::forceLayout matches the Mac pretty well and should be enough for now. Without this we won't repaint the new page when we go back and forward. (WebFrame::dispatchWillSubmitForm): Use COMPtr's AdoptCOM constructor instead of the adoptRef function. (WebFrame::restoreViewState): Removed unneeded notImplemented() call. This is implemented as much as it needs to be. (WebFrame::shouldGoToHistoryItem): Ditto. (WebFrame::saveViewStateToItem): Ditto. (WebFrame::canCachePage): Ditto, also changed it to return true. This is what was preventing the back/forward cache from running, and there's no need for any additional checks in the Windows version.

WebView.cpp: (PreferencesChangedOrRemovedObserver::onNotify): Fix backwards null check that was preventing this notification from ever being sent, which in turn meant that page cache had a capacity of 0. (WebView::initWithFrame): Removed unneeded setUsesPageCache(false) code. This actually was ineffective and ended up doing no harm, but we don't need it.

5:07 PM Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@apple.com

(diff)

5:05 PM Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@apple.com

(diff)

3:10 PM Changeset in webkit [28821] by sfalken@apple.com

3 edits in tags/Safari-525.3.2b/WebCore

Merged r28816.

2:54 PM Changeset in webkit [28820] by Darin Adler

1 edit
1 move in trunk/LayoutTests

disabling this test until we can find a way to make it pass on diverse machines

fast/css/css2-system-color.html: Removed.
fast/css/css2-system-color.html-disabled: Copied from fast/css/css2-system-color.html.

1:31 PM Changeset in webkit [28819] by sfalken@apple.com

1 copy in tags/Safari-525.3.2b

New tag.

12:54 PM Changeset in webkit [28818] by alp@webkit.org

12 edits
2 deletes in trunk

2007-12-14 Juan A. Suarez Romero <jasuarez@igalia.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16042
[GTK] Eliminate webkit_init()

Move webkit initialization to WebView class init.

12:51 PM Changeset in webkit [28817] by alp@webkit.org

9 edits in trunk

2007-12-17 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=13542
gdklauncher doesnt change URL in adress GTKEntry.

Let DOMDocument observers do their work before emitting title-changed.
The load-committed signal has been added for both the view and the frame.

12:14 PM QtWebKitTodo edited by zander@kde.org

(diff)

11:48 AM Changeset in webkit [28816] by jhoneycutt@apple.com

3 edits in trunk/WebCore

2007-12-17 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Darin.

<rdar://problem/5651291> REGRESSION: Flash content doesn't display
(www.adobe.com)

We were passing NPEvent instead of NPEvent* to NPP_HandleEvent.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::dispatchNPEvent): Changed to take NPEvent&, not NPEvent* (WebCore::PluginViewWin::paint): Pass NPEvent, not NPEvent* (WebCore::PluginViewWin::handleKeyboardEvent): same (WebCore::PluginViewWin::handleMouseEvent): same
plugins/win/PluginViewWin.h:

11:44 AM Changeset in webkit [28815] by andersca@apple.com

2 edits in trunk/LayoutTests

Fix argument to window.open.

http/tests/misc/window-open-then-write.html:

10:42 AM Changeset in webkit [28814] by mrowe@apple.com

3 edits in trunk/LayoutTests

2007-12-17 Mark Rowe <mrowe@apple.com>

Update test results after r28812.

platform/mac-tiger/fast/css/css2-system-color-expected.txt:
platform/mac/fast/css/css2-system-color-expected.txt:

10:34 AM Changeset in webkit [28813] by ap@webkit.org

4 edits
2 adds in trunk

Reviewed by Darin.

Live to the promise of never making AppKit special character codes visible via DOM.

Test: fast/events/arrow-keys-on-body.html

page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Check for empty keypress characters after disambiguation, to let quirks-aware code strip special charactrers.
platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): If not in keyboard event quirks mode, remove the text if it's a special character.

10:21 AM Changeset in webkit [28812] by mrowe@apple.com

2 edits in trunk/WebCore

2007-12-17 Mark Rowe <mrowe@apple.com>

Reviewed by Darin Adler.

Fix incorrect array size and incorrect array index in convertNSColorToColor.

rendering/RenderThemeMac.mm: (WebCore::convertNSColorToColor):

9:53 AM Changeset in webkit [28811] by Darin Adler

2 edits in trunk/WebCore

Reviewed by Mark Rowe.

fix http://bugs.webkit.org/show_bug.cgi?id=16468 REGRESSION(r28781): Crash running storage/transaction_callback_exception_crash.html

storage/DatabaseThread.cpp: (WebCore::DatabaseThread::dispatchNextTaskIdentifier): Use a RefPtr for the database because there's no guarantee it won't lose its last reference otherwise.

9:09 AM Changeset in webkit [28810] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

fix <rdar://problem/5333260> Some Chinese characters in Text Encoding menu are bold, others are not and <rdar://problem/5280188> Chinese text looks worse on Safari for Windows cf. Safari for Mac

platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters): To ensure that font linking gives consistent results for characters that are exclusive to the simplified Chinese code page and characters that belong to that code page and other code pages, always ask to map to simplified Chinese alone first.

8:18 AM Changeset in webkit [28809] by alp@webkit.org

3 edits in trunk/WebCore

2007-12-17 Christian Dywan <christian@twotoasts.de>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16378
Implement Icon for Gtk

Icon provides a GdkPixbuf containing a themed icon.
The icon theme is probed for an icon name according to the
Icon Naming Specification or conventional Gnome icon names respectively.

See http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html

platform/graphics/Icon.h:
platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::~Icon): (WebCore::lookupIconName): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint):

3:55 AM Changeset in webkit [28808] by mjs@apple.com