⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 19, 2007:

10:40 PM Changeset in webkit [28883] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • remove two more tests that pass now due to changed font fallback
  • platform/win/Skipped:
10:29 PM BuildingGtk edited by chad.kittel@gmail.com
added Lunar-Linux's package information. (diff)
10:21 PM Changeset in webkit [28882] by mitz@apple.com
  • 7 edits in trunk

WebCore:

Reviewed by Darin Adler and Dave Hyatt.

  • Substitute the user's preferred standard font for an unknown primary font before falling back on the platform's last resort font

Cannot be tested in DumpRenderTree because it sets the standard font to
Times, which is also the hard-coded last resort font on Mac.

  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::getFontData): Changed the early bail out condition to allow getting generic font families from settings even if there are not @font-face rules. Fixed a typo that mapped fantasy to cursive. Added a mapping from -webkit-standard to the standard family.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Changed to always create a font selector. (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::applyProperty): Changed to always use the font selector.
  • css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::fontSelector):
  • platform/graphics/FontCache.cpp: (WebCore::FontCache::getFontData): Try the user's preferred standard font before the platform's last resort font.

LayoutTests:

  • remove passing tests following the change to font fallback
  • platform/win/Skipped: Removed tests that failed only because they specified as primary font family a font family that was not available on Windows and therefore were rendered using the platform last resort font, Times New Roman. Now they are rendered using the 'standard' font family, which is set to Times on both Mac and Windows when running the tests.
8:24 PM Changeset in webkit [28881] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

Make svn-apply/svn-unapply work with patches from git-format-patch.

Reviewed by Darin.

  • Scripts/svn-apply: (patch): If 'Index:' can't be found in the text passed in, print it out with a warning and return early.
  • Scripts/svn-unapply: (patch): Ditto.
7:03 PM Changeset in webkit [28880] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-19 Sven Herzberg <​sven@imendio.com>

Reviewed by Alp Toker.

Scaled font destruction takes place in FontData::platformDestroy(). No
need to do it in FontPlatformData::~FontPlatformData().

Destroying platform data in platformDestroy() is a convention we
borrow from the Mac and Win ports.

  • platform/graphics/gtk/FontPlatformDataGtk.cpp:
5:12 PM Changeset in webkit [28879] by alice.liu@apple.com
  • 3 edits in trunk/WebCore

build fix (Windows)

Changed uint to unsigned int. uint caused Windows build breakage

  • page/Page.cpp: (WebCore::Page::markAllMatchesForText):
  • page/Page.h:
4:23 PM Changeset in webkit [28878] by alp@webkit.org
  • 6 edits in trunk

2007-12-19 Christian Dywan <​christian@twotoasts.de>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16222
[GTK] Implement inline search and highlighting of matching strings.

4:02 PM Changeset in webkit [28877] by ggaren@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Sam Weinig, Dan Bernstein.

Tiger build fix: restored some graphics code still needed on Tiger.

  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::setCompositeOperation):
3:22 PM Changeset in webkit [28876] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-19 Alp Toker <​alp@atoker.com>

Build fix for Pango < 1.18.0 breakage introduced in r28864. Use Fc and
the Pango backend API in these cases.

  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData):
2:51 PM Changeset in webkit [28875] by alice.liu@apple.com
  • 7 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Fixed <rdar://problem/5592485> Safari crashed trying to get a motorcycle insurance quote
on Geico.com WebCore::Document::inPageCache()

Calling Node::willRemove on the focusedNode would immediately tell the document to remove
the focused node, and trigger JS events. This means that the document is mutated while
the engine is trying to tell all child nodes that it's about to removed. To avoid
crashing, we need to hold off on mutating the document until node traversal is finished.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::removeChildren):
  • dom/Node.cpp:
  • dom/Node.h: (WebCore::Node::willRemove):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear):

LayoutTests:

Reviewed by Darin.

Fixed <rdar://problem/5592485> Safari crashed trying to get a motorcycle insurance quote
on Geico.com WebCore::Document::inPageCache()

  • fast/events/nested-event-remove-node-crash-expected.txt: Added.
  • fast/events/nested-event-remove-node-crash.html: Added.
1:57 PM Changeset in webkit [28874] by aboule@apple.com
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Dan Bernstein.

Adding tests for canvas compositing modes to make sure the results don't change after:
<rdar://problem/5640059> GraphicsContext::setCompositeOperation should use CGContextSetBlendMode

The following compositing modes don't pass however that is covered by another bug:
source-in
source-out
destination-in
destination-atop
copy
<rdar://problem/5651783> Some canvas tag compositing modes don't render correctly

  • fast/canvas/canvas-composite.html: Added.
  • platform/mac/fast/canvas/canvas-composite-expected.checksum: Added.
  • platform/mac/fast/canvas/canvas-composite-expected.png: Added.
  • platform/mac/fast/canvas/canvas-composite-expected.txt: Added.

WebCore:

Reviewed by Dan Bernstein.

Test: fast/canvas/canvas-composite.html

Fix for:
<rdar://problem/5640059> GraphicsContext::setCompositeOperation should use CGContextSetBlendMode

This fix makes setCompositeOperation consistent across all platforms that use CG.

The following compositing modes don't pass however that is covered by another bug:
source-in
source-out
destination-in
destination-atop
copy
<rdar://problem/5651783> Some canvas tag compositing modes don't render correctly

  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setCompositeOperation):
  • platform/graphics/mac/GraphicsContextMac.mm:
  • platform/win/GraphicsContextWin.cpp:
1:45 PM Changeset in webkit [28873] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/5650045> REGRESSION: major layout problems in svn r28754 WebKit on Vox.com page

Test: fast/dynamic/subtree-boundary-percent-height.html

  • rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): Do not allow overflows with percent heights because sometimes they compute to 'auto'.

LayoutTests:

Reviewed by Dave Hyatt.

  • test for <rdar://problem/5650045> REGRESSION: major layout problems in svn r28754 WebKit on Vox.com page
  • fast/dynamic/subtree-boundary-percent-height.html: Added.
  • platform/mac/fast/dynamic/subtree-boundary-percent-height-expected.checksum: Added.
  • platform/mac/fast/dynamic/subtree-boundary-percent-height-expected.png: Added.
  • platform/mac/fast/dynamic/subtree-boundary-percent-height-expected.txt: Added.
1:21 PM Changeset in webkit [28872] by hyatt@apple.com
  • 1 edit in trunk/WebCore/page/Settings.cpp

Fix unsigned/enum problem on Win32. r=darin.

12:26 PM Changeset in webkit [28871] by Beth Dakin
  • 2 edits in trunk/WebCore

Oops! Typo!

12:15 PM Changeset in webkit [28870] by hyatt@apple.com
  • 1 edit in trunk/WebCore/page/Settings.cpp

Fix unsigned/enum problem on Win32. r=darin.

12:14 PM Changeset in webkit [28869] by hyatt@apple.com
  • 3 edits in trunk/WebCore/page

Fix unsigned/enum problem on Win32. r=darin.

12:11 PM Changeset in webkit [28868] by weinig@apple.com
  • 14 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=16511
Speed up ClassNodeList and NamedNodeList by using the caching mechanism employed by ChildNodeList.

  • dom/ChildNodeList.cpp: Use the caching NodeList constructor to turn on caching. (WebCore::ChildNodeList::ChildNodeList):
  • dom/ClassNodeList.cpp: (WebCore::ClassNodeList::ClassNodeList):
  • dom/ClassNodeList.h:

Move getElementsByName and getElementsByClassName to Node so they
can use easily employ the caching already used by ChildNodeLists. In the case of
getElementsByClassName, this reduces code duplication in Element as well

  • dom/Document.cpp:
  • dom/Document.h:

Move getElementsByClassName to Node.

  • dom/Element.cpp:
  • dom/Element.h:
  • dom/NameNodeList.cpp: Use the caching NodeList constructor to turn on caching. (WebCore::NameNodeList::NameNodeList): (WebCore::NameNodeList::item):
  • dom/NameNodeList.h:

Add maps of caches for ClassNodeLists and NameNodeList to NodeListsNodeData.

  • dom/Node.cpp: (WebCore::TagNodeList::TagNodeList): (WebCore::Node::Node): (WebCore::Node::~Node): (WebCore::Node::childNodes): (WebCore::Node::registerNodeList): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):
  • dom/Node.h: Make m_nodeLists an OwnPtr. Moved getElementsByName and getElementsByClassName here

Allow subclasses to choose whether they want to receive the notifications using a new bit.

  • dom/NodeList.cpp: (WebCore::NodeList::NodeList):
  • dom/NodeList.h: (WebCore::NodeList::needsNotifications):
11:24 AM Changeset in webkit [28867] by hyatt@apple.com
  • 19 edits in trunk/WebCore

Add support for GDI text on Windows.

11:13 AM Changeset in webkit [28866] by hyatt@apple.com
  • 5 edits in trunk/WebKit/win

Add fourth preference value for GDI text font smoothing to WebKit.

10:41 AM Changeset in webkit [28865] by alp@webkit.org
  • 2 edits in trunk

2007-12-19 Alp Toker <​alp@atoker.com>

Remove the cairo-ft pkg-config check. The GTK+ port doesn't use
cairo-ft directly following changes in r28864.

  • WebKit.pri:
10:00 AM Changeset in webkit [28864] by alp@webkit.org
  • 6 edits in trunk/WebCore

2007-12-19 Sven Herzberg <​sven@imendio.com>

Reviewed by Alp Toker.

Replace the fontconfig/freetype based font management with a pango
based one. Fixes:
​http://bugs.webkit.org/show_bug.cgi?id=15229

  • platform/gtk/FontDataGtk.cpp (FontData::platformDestroy()): updated the platform specific destroy code (FontData::containsCharacters()): implemented font coverage with pango
  • platform/gtk/FontPlatformData.h: replaced fontconfig specific members with pango-specific ones
  • platform/gtk/FontPlatformDataGtk.cpp: added static members for the FontPlatformData class (FontPlatformData::FontPlatformData()): implemented the font-matching with a PangoFontDescription instead of an FcPattern; initialize the scaled font by using the API for PangoCairoFont (FontPlatformData::init()): initialize the PangoFontMap and set up a hash table to translate the font family name into a font family (FontPlatformData::isFixedPitch()): implemented by querying the PangoFontFamily (FontPlatformData::operator==): compare the FontPlatformData by comparing the font pointers or the described fonts
  • platform/gtk/GlyphPageTreeNodeGtk.cpp (pango_font_get_glyph()): added a function to query a glyph from a PangoFont (GlyphPage::fill()): implemented the fill function with Pango instead of fontconfig/freetype
9:36 AM Changeset in webkit [28863] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build process improvements, including added checks and outdated changes after the move to trunk.

Reviewed by Alp Toker

9:00 AM Changeset in webkit [28862] by alp@webkit.org
  • 4 edits in trunk/WebKit/gtk

2007-12-19 Alp Toker <​alp@atoker.com>

Reviewed by Holger Freyther.

Delete when Destroy functions are called to avoid leaks

This matches the Mac port.

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ContextMenuClientGtk.cpp:
  • WebCoreSupport/InspectorClientGtk.cpp:
8:55 AM Changeset in webkit [28861] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-19 Alp Toker <​alp@atoker.com>

Reviewed by Holger Freyther.

Improve graphics operator approximations

These changes match Cairo's own CG approximations.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::toCairoOperator):
8:55 AM Changeset in webkit [28860] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-19 Alp Toker <​alp@atoker.com>

Reviewed by Holger Freyther.

Check the bounding box before doing a full hit test

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::contains):
1:10 AM Changeset in webkit [28859] by mrowe@apple.com
  • 3 edits
    1 add in trunk/JavaScriptCore

Build fix for non-Mac platforms. Move NodeInfo into its own header so that the YYTYPE declaration in grammar.h is able to declare members of that type.

12:41 AM Changeset in webkit [28858] by weinig@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Geoff.

Fix for <rdar://problem/5646478>
REGRESSION: fast/events/event-view-toString fails on Leopard

This fixes an issue where we were incorrectly setting the lastInPrototypeChain
for the JSDOMWindow (the global object) before a call to setPrototype overwrote
it. This fixes it by passing the prototype up the constructor chain so that it
is set before any calls can be made.

  • bindings/js/kjs_window.cpp: (KJS::Window::Window):
  • bindings/js/kjs_window.h:
  • bindings/scripts/CodeGeneratorJS.pm:
12:13 AM Changeset in webkit [28857] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Make appendToVarDeclarationList static

RS=Weinig

Dec 18, 2007:

11:53 PM Changeset in webkit [28856] by Beth Dakin
  • 8 edits
    5 adds in trunk

WebCore:

Reviewed by Oliver.

Fix for <rdar://problem/5616982> SVGs with width and height 100%
fail to render when used as <img> or CSS image (16167)

This final part of the work fixes the <img> tag.

This is the real fix.

  • rendering/RenderImage.cpp: (WebCore::RenderImage::calcReplacedWidth): Set the container size on the image. Setting the container size only actually sticks if the values are non-zero, so if the container size really was set, use the imageSize that is calculated using the container size. If it did not stick but the image does have relative width (meaning that the container size is 0), set the width to 0 by hand. We want to avoid setting the width before we have a container size or we will end up incorrectly using the default size of 300x150. (WebCore::RenderImage::calcReplacedHeight): Same as above, but for height.

A few more pieces of information have to be exposed through cached
image to make this happen.

  • loader/CachedImage.cpp: (WebCore::CachedImage::usesImageContainerSize): As mentioned above, when setContainerSize() is called, the container size is only actually set if the values are non-zero. This call tells you if it was set. (WebCore::CachedImage::imageHasRelativeWidth): (WebCore::CachedImage::imageHasRelativeHeight):
  • loader/CachedImage.h:
  • platform/graphics/Image.h: (WebCore::Image::usesContainerSize):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::usesContainerSize):
  • svg/graphics/SVGImage.h:

LayoutTests:

Reviewed by Oliver.

Test for <rdar://problem/5616982> SVGs with width and height 100%
fail to render when used as <img> or CSS image (16167)

  • fast/images/resources/green-relative-size-rect.svg: Added.
  • fast/images/svg-as-relative-image.html: Added.
  • platform/mac/fast/images/svg-as-relative-image-expected.checksum: Added.
  • platform/mac/fast/images/svg-as-relative-image-expected.png: Added.
  • platform/mac/fast/images/svg-as-relative-image-expected.txt: Added.
11:42 PM Changeset in webkit [28855] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Remove dead code due to removal of post-parse declaration discovery.

RS=Geoff.

Due to the removal of the declaration discovery pass after parsing we
no longer need any of the logic used for that discovery.

11:42 PM Changeset in webkit [28854] by oliver@apple.com
  • 7 edits in trunk/JavaScriptCore

Replace post-parse pass to find declarations with logic in the parser itself

Reviewed by Geoff.

Instead of finding declarations in a pass following the initial parsing of
a program, we incorporate the logic directly into the parser. This lays
the groundwork for further optimisations (such as improving performance in
declaration expressions -- var x = y; -- to match that of standard assignment)
in addition to providing a 0.4% performance improvement in SunSpider.

9:04 PM Changeset in webkit [28853] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

9:02 PM Changeset in webkit [28852] by mrowe@apple.com
  • 1 copy in tags/Safari-4525.1

New tag.

9:02 PM Changeset in webkit [28851] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.1

New tag.

8:58 PM Changeset in webkit [28850] by mrowe@apple.com
  • 4 edits in trunk

Fix typo in hosted SunSpider page.

8:54 PM Changeset in webkit [28849] by sfalken@apple.com
  • 2 edits in trunk/WebKitSite

Correct link to Visual Studio Express 2005.
Old link points to 2008.


Reviewed by Mark.

  • building/tools.html:
7:11 PM Changeset in webkit [28848] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
6:58 PM Changeset in webkit [28847] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-12-18 Xan Lopez <​xan@gnome.org>

Reviewed by Geoff.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=14521
Bug 14521: JavaScriptCore fails to build on Linux/PPC gcc 4.1.2


  • wtf/TCSpinLock.h: (TCMalloc_SpinLock::Unlock):

Use less strict memory operand constraint on inline asm generation.
PLATFORM(DARWIN) left unpatched due to Apple's GCC bug.

Patch by David Kilzer <​ddkilzer@webkit.org>

6:12 PM Changeset in webkit [28846] by mrowe@apple.com
  • 2 edits
    2 deletes in trunk

Remove outdated and non-functioning project files for the Apollo port. Rubber-stamped by Maciej Stachowiak and Chris Brichford.

5:41 PM Changeset in webkit [28845] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by John Sullivan.

  • remove passing test and reclassify one failing test
  • platform/win/Skipped: Removed fast/text/international/002.html.
5:12 PM Changeset in webkit [28844] by weinig@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Geoffrey.

  • http/tests/security/cross-frame-access-history-expected.txt:
  • http/tests/security/cross-frame-access-history.html:
4:58 PM Changeset in webkit [28843] by sfalken@apple.com
  • 1 edit
    1 add in trunk/WebKitTools

Add script to run Drosera as part of the nightly.


Reviewed by Kevin M.

  • Scripts/run-drosera.cmd: Added.
4:35 PM Changeset in webkit [28842] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Remove a stray K.
4:34 PM Changeset in webkit [28841] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • fix Windows build
  • pcre/pcre_exec.cpp: (jsRegExpExecute): Change back from false/true to 0/1 -- I probably should not have deleted MATCH_MATCH and MATCH_NOMATCH, but I'm going to leave them out.
3:40 PM Changeset in webkit [28840] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Plan more renaming.
3:38 PM Changeset in webkit [28839] by sfalken@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/5649911> REGRESSION (304-306A9): Typing 'p' in popup menu for type-to-select brings up Safari Help


Need to translate the char back into a key code for posting our WM_KEYDOWN.


Reviewed by Ada.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc):
2:56 PM Changeset in webkit [28838] by sfalken@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/5651534> REGRESSION(r28764-r28765): GDI leak drawing text when no appropriate font is available


Our captured metafile from Uniscribe may contain multiple calls to CreateFontIndirect.
Only create a font with the last one.


Reviewed by Mitz, Darin.

  • platform/graphics/win/FontCacheWin.cpp: (WebCore::metaFileEnumProc): (WebCore::FontCache::getFontDataForCharacters):
2:32 PM Changeset in webkit [28837] by Darin Adler
  • 3 edits in trunk/LayoutTests
  • fix failing regression test
  • fast/regex/resources/TEMPLATE.html: Updated this template -- I accidentally landed the one that was copied without updating the paths.
  • fast/regex/slow.html: Regenerated.
1:50 PM Changeset in webkit [28836] by alice.liu@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Darin.

Fixed <rdar://problem/5646454> REGRESSION: dom/xhtml/level2/html/HTMLDocument12 fails on Leopard

  • fast/cookies/local-file-can-set-cookies.html: cookies are matched by domain and path, and since layout tests are file URLs, they all match on domain. setting a cookie without specifying the path will make CFNetwork pick up the path from the URL automatically. Since fast/cookies/local-file-can-set-cookies.html set a specific path of /, that cookie will be set for EVERY local file loaded in Safari. removing that component from the cookie string will fix the problem.
1:37 PM Changeset in webkit [28835] by alp@webkit.org
  • 5 edits
    2 adds in trunk/WebCore

2007-12-17 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=16464
Modify WebCore to use win32 thread primitives

Updates to support native windows threading primitives
rather than pthreads emulation library.

  • WebCore.vcproj/WebCore.vcproj:
  • config.h:
  • platform/Threading.h:
  • platform/win/MutexWin.cpp: Added. (WebCore::Mutex::Mutex): (WebCore::Mutex::~Mutex): (WebCore::Mutex::lock): (WebCore::Mutex::tryLock): (WebCore::Mutex::unlock):
  • platform/win/ThreadConditionWin.cpp: Added. (WebCore::ThreadCondition::ThreadCondition): (WebCore::ThreadCondition::~ThreadCondition): (WebCore::ThreadCondition::wait): (WebCore::ThreadCondition::signal): (WebCore::ThreadCondition::broadcast):
  • platform/win/ThreadingWin.cpp: (WebCore::threadMapMutex): (WebCore::threadMap): (WebCore::storeThreadHandleByIdentifier): (WebCore::identifierByThreadHandle): (WebCore::threadHandleForIdentifier): (WebCore::clearThreadHandleForIdentifier): (WebCore::createThread): (WebCore::waitForThreadCompletion): (WebCore::detachThread): (WebCore::currentThread):
1:36 PM Changeset in webkit [28834] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-18 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Darin Adler.

Handle EINTR when set by select() and try the select() again
​http://bugs.webkit.org/show_bug.cgi?id=16071

  • platform/network/curl/ResourceHandleManager.cpp: (ResourceHandleManager::downloadTimerCallback):
11:30 AM Changeset in webkit [28833] by Darin Adler
  • 4 edits
    1 copy
    4 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

Test: fast/regex/slow.html

Slows down SunSpider a bit (about 1.01x); filed a bug to follow up on that:
​http://bugs.webkit.org/show_bug.cgi?id=16503

  • pcre/pcre.h: Changed name of error code to not specifically mention "recursion".
  • pcre/pcre_exec.cpp: (match): Replaced the depth limit, MATCH_RECURSION_LIMIT, with a total match looping limit, matchLimit. Also eliminated the constants for MATCH_MATCH and MATCH_NOMATCH, since they are just true and false (1 and 0). (jsRegExpExecute): More of the MATCH_MATCH change.

LayoutTests:

Reviewed by Geoff.

  • fast/regex/resources: Added.
  • fast/regex/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
  • fast/regex/resources/slow.js: Added.
  • fast/regex/slow-expected.txt: Added.
  • fast/regex/slow.html: Added.
10:58 AM Changeset in webkit [28832] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • avoid the simplified Chinese font linking code for characters that are not in any Windows code page
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters):
10:35 AM Changeset in webkit [28831] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by John Sullivan.

  • remove passing test
  • platform/win/Skipped: Removed fast/text/international/wrap-CJK-001.html
10:19 AM Changeset in webkit [28830] by beidson@apple.com
  • 7 edits in trunk/WebCore

Reviewed by Adele

<rdar://problem/5525770> REGRESSION: HTTP Auth protected favicon request results in a password sheet

Some http-auth protected sites have the main resource(s) unprotected, but many subresources are
protected by authentication. Occasionally one can view the main page of a site but the favicon
is behind the iron curtain - in these cases, we should *not* prompt for a username and password
solely for the favicon.

  • loader/ResourceLoader.h: Make didReceiveAuthenticationChallenge virtual
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveAuthenticationChallenge): Now that this method is virtual from ResourceLoader, SubresourceLoader can override. First call to the SubresourceLoaderClient. If they cancel the resource load, return early. Otherwise, let ResourceLoader work its magic (resulting in the auth sheet coming down)
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didReceiveAuthenticationChallenge):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveAuthenticationChallenge): Cancel the resource load, since we should never prompt the user for credentials just for a favicon.
  • loader/icon/IconLoader.h:
9:07 AM Changeset in webkit [28829] by sullivan@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Brady


  • fixed <rdar://problem/5652380> Initial prompt shows "" for databases with no user-visible name
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase): pass "name" instead of "displayName" if there's no displayName
1:27 AM Changeset in webkit [28828] by mjs@apple.com
  • 2 edits in trunk/SunSpider

Reviewed by Eric.


  • give an extra digit of precision for small differences.
  • resources/sunspider-compare-results.js:
Note: See TracTimeline for information about the timeline view.