⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 22, 2007:

6:18 PM Changeset in webkit [28965] by alp@webkit.org
  • 4 edits in trunk/WebKit/gtk

2007-12-22 Xan Lopez <​xan@gnome.org>

Reviewed by Alp Toker.

Use webView, web_view, etc for variable names instead of page, which
was left over from the old API.

3:54 PM Changeset in webkit [28964] by alp@webkit.org
  • 4 edits in trunk

2007-12-22 Alp Toker <​alp@atoker.com>

GTK+ build fix

GTK_TARGET_OTHER_APP is not available in older GTK+ versions. Pass
empty target flags for now.

Check GTK+, not GLib versions, since they are different.

3:12 PM Changeset in webkit [28963] by alp@webkit.org
  • 9 edits
    3 adds in trunk

2007-12-22 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16311
[Gtk] Copy rich text to clipboard as text/plain and text/html.

Add copy and paste targets for WebView and implement
WebCore::PasteboardHelper.

1:39 PM Changeset in webkit [28962] by Nikolas Zimmermann
  • 6 edits
    4 adds in trunk

Reviewed by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=15966 (Crash in SVGRootInlineBox::walkTextChunks() on mouse hover)

Add new isSVGRootInlineBox() function to InlineBox to be able to differentiate between RootInlineBox/SVGRootInlineBox.
SVG assumed it's root inline box (for <text> elements) is always of type SVGRootInlineBox, which is not the case
for HTML text in <foreignObject>. Text selection doesn't work so far as line box offsets are wrong - which is visible
in Web Inspector.

1:04 PM Changeset in webkit [28961] by Antti Koivisto
  • 2 edits in trunk/WebKitTools

Fix a typo.

12:03 PM Changeset in webkit [28960] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-22 Alp Toker <​alp@atoker.com>

LOW_BANDWIDTH_DISPLAY build fix

Track recent KURL DeprecatedString changes.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
8:48 AM Changeset in webkit [28959] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • Windows build fix
  • WebCore.vcproj/WebCore.vcproj:
8:35 AM Changeset in webkit [28958] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-12-22 Xan Lopez <​xan@gnome.org>

Reviewed by Alp Toker.

Follow up to ​http://bugs.webkit.org/show_bug.cgi?id=16144

  • WebView/webkitwebview.cpp: Fix signal id arguments for g_signal_emit in clipboard functions.
8:34 AM Changeset in webkit [28957] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-22 Xan Lopez <​xan@gnome.org>

Reviewed by Alp Toker.

Add missing return 0 to fix a compile warning.

  • page/gtk/FrameGtk.cpp: (WebCore::Frame::createScriptInstanceForWidget):

Dec 21, 2007:

11:26 PM Changeset in webkit [28956] by dsmith@webkit.org
  • 2 edits in trunk/WebKitSite

At bdash's suggestion, display a message if someone attempts to run the 'native' version of the getElementsByClassName benchmark in a browser that doesn't support that.

  • blog-files/gebcnspeedtest.html:
11:02 PM Changeset in webkit [28955] by dsmith@webkit.org
  • 1 edit
    2 adds in trunk/WebKitSite

Add the benchmark from the previous commit as well.

  • blog-files/gebcnspeedtest.html: Added.
  • blog-files/prototype-for-gebcn-test.js: Added.
10:45 PM Changeset in webkit [28954] by dsmith@webkit.org
  • 1 edit
    1 add in trunk/WebKitSite

Add a graph of benchmark results for an upcoming blog post.

  • blog-files/gebcnwebkitonly.png: Added.
10:12 PM Changeset in webkit [28953] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

10:11 PM Changeset in webkit [28952] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.2

New tag.

10:11 PM Changeset in webkit [28951] by mrowe@apple.com
  • 1 copy in tags/Safari-4525.2

New tag.

9:54 PM Changeset in webkit [28950] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-12-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver Hunt.

8:40 PM Changeset in webkit [28949] by mrowe@apple.com
  • 2 edits in trunk/WebKitLibraries

Fix ​http://bugs.webkit.org/show_bug.cgi?id=16549 (WebKit nightly build failing to launch on PowerPC G3s).

Rubber-stamped by Dan Bernstein.

  • libWebKitSystemInterfaceTiger.a: Update to a G3-friendly version.
8:18 PM Changeset in webkit [28948] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

  • Disable the back/forward cache using the new WebPreferences API instead of through the BackForwardList. This makes us match what we do on Windows.
  • DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): (setDefaultsToConsistentValuesForTesting):
5:39 PM Changeset in webkit [28947] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

  • disable the back/forward cache in Windows DumpRenderTree. It is already disabled in Mac DumpRenderTree.
  • DumpRenderTree/win/DumpRenderTree.cpp: (initializePreferences):
5:09 PM Changeset in webkit [28946] by Antti Koivisto
  • 2 edits in trunk/WebKitSite

Reviewed by Darin and Steve.

Add instructions to install the QuickTime SDK for Windows.

5:07 PM Changeset in webkit [28945] by Antti Koivisto
  • 12 edits
    7 adds in trunk

Reviewed by Darin, Adam and Steve.

Add media playback support for Windows.


The implementation uses low level QuickTime API. DLL is
needed to work around CF use in both WebKit and QuickTime.


This makes Windows build depend on the QuickTime SDK


​http://developer.apple.com/quicktime/download/


but not QuickTime itself.


QTMovieWinTimer contains some copy code from SharedTimerWin. It
is used in the QuickTime access DLL which can't use WebCore
SharedTimer due to dependency problems.

5:01 PM Changeset in webkit [28944] by alp@webkit.org
  • 5 edits in trunk/WebCore

2007-12-21 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16558
Cairo WebCore Rendering Fails on arc drawing

Fix for bug reported (and patched) by Apollo team in which
arcs were draw in reverse (resulting in inverted images).
Review of the source found that the 'clockwise' term was
actually meant to mean 'anticlockwise' so the IDL and
supporting classes have been changed to match this.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arc):
  • html/CanvasRenderingContext2D.idl:
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArc): (WebCore::Path::addEllipse):
  • platform/graphics/Path.h:
4:41 PM Changeset in webkit [28943] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-12-21 Alp Toker <​alp@atoker.com>

Documentation typo fix: s/wether/whether

  • WebView/webkitwebview.cpp:
4:36 PM Changeset in webkit [28942] by alp@webkit.org
  • 4 edits in trunk/WebKit/gtk

2007-12-21 Christian Dywan <​christian@twotoasts.de>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16144
[GTK] Clipboard/ selection handling functions

  • WebView/webkitprivate.h:
  • WebView/webkitwebview.cpp:
  • WebView/webkitwebview.h:
4:35 PM Changeset in webkit [28941] by weinig@apple.com
  • 4 edits in trunk/LayoutTests

Reviewed by Adele.

Fix another mistaken duplication, this time in cross-frame-access-parent-explicit-domain.html,
that was causing intermittent failures.

  • http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-parent-explicit-domain.html:
  • http/tests/security/cross-frame-access-port-explicit-domain-expected.txt:
4:01 PM Changeset in webkit [28940] by weinig@apple.com
  • 4 edits in trunk/LayoutTests

Reviewed by Dan Bernstein.

Fix mistaken duplication in cross-frame-access-child-explicit-domain.html that was causing
intermittent failures.

  • http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-child-explicit-domain.html:
  • http/tests/security/cross-frame-access-custom-expected.txt:
3:15 PM Changeset in webkit [28939] by adachan@apple.com
  • 2 edits in trunk/WebKit/win

Implemented DOMDocument::getElementById().

Reviewed by Darin.

  • DOMCoreClasses.cpp: (DOMDocument::getElementById):
2:02 PM Changeset in webkit [28938] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Requested by Maciej.

  • kjs/nodes.h: Use the new NEVER_INLINE here and eliminate the old KJS_NO_INLINE. We don't want to have two, and we figured it was better to keep the one that's in WTF.
1:54 PM Changeset in webkit [28937] by Darin Adler
  • 12 edits in trunk/JavaScriptCore

Reviewed by Eric.

1.022x as fast on SunSpider.

  • kjs/NodeInfo.h: Renamed SourceElementsStub to SourceElements, since that more accurately describes the role of this object, which is a reference-counted wrapper for a Vector.
  • kjs/Parser.cpp: (KJS::Parser::didFinishParsing): Changed parameter type to SourceElements, and use plain assignment instead of set.
  • kjs/Parser.h: Changed parameter type of didFinishParsing to a SourceElements. Also changed m_sourceElements; we now use a RefPtr instead of an OwnPtr as well.
  • kjs/grammar.y: Got rid of all the calls to release() on SourceElements. That's now handed inside the constructors for various node types, since we now use vector swapping instead.
  • kjs/nodes.cpp: (KJS::Node::rethrowException): Added NEVER_INLINE, because this was getting inlined and we want exception handling out of the normal code flow. (KJS::SourceElements::append): Moved here from the header. This now handles creating a BreakpointCheckStatement for each statement in the debugger case. That way we can get breakpoint handling without having it in every execute function. (KJS::BreakpointCheckStatement::BreakpointCheckStatement): Added. (KJS::BreakpointCheckStatement::execute): Added. Contains the code that was formerly in the StatementNode::hitStatement function and the KJS_BREAKPOINT macro. (KJS::BreakpointCheckStatement::streamTo): Added. (KJS::ArgumentListNode::evaluateList): Use KJS_CHECKEXCEPTIONVOID since the return type is void. (KJS::VarStatementNode::execute): Removed KJS_BREAKPOINT. (KJS::BlockNode::BlockNode): Changed parameter type to SourceElements. Changed code to use release since the class now contains a vector rather than a vector point. (KJS::BlockNode::optimizeVariableAccess): Updated since member is now a vector rather than a vector pointer. (KJS::BlockNode::execute): Ditto. (KJS::ExprStatementNode::execute): Removed KJS_BREAKPOINT. (KJS::IfNode::execute): Ditto. (KJS::IfElseNode::execute): Ditto. (KJS::DoWhileNode::execute): Ditto. (KJS::WhileNode::execute): Ditto. (KJS::ContinueNode::execute): Ditto. (KJS::BreakNode::execute): Ditto. (KJS::ReturnNode::execute): Ditto. (KJS::WithNode::execute): Ditto. (KJS::CaseClauseNode::optimizeVariableAccess): Updated since member is now a vector rather than a vector pointer. (KJS::CaseClauseNode::executeStatements): Ditto. (KJS::SwitchNode::execute): Removed KJS_BREAKPOINT. (KJS::ThrowNode::execute): Ditto. (KJS::TryNode::execute): Ditto. (KJS::ScopeNode::ScopeNode): Changed parameter type to SourceElements. (KJS::ProgramNode::ProgramNode): Ditto. (KJS::EvalNode::EvalNode): Ditto. (KJS::FunctionBodyNode::FunctionBodyNode): Ditto. (KJS::ScopeNode::optimizeVariableAccess): Updated since member is now a vector rather than a vector pointer.
  • kjs/nodes.h: Removed hitStatement. Renamed SourceElements to StatementVector. Renamed SourceElementsStub to SourceElements and made it derive from ParserRefCounted rather than from Node, hold a vector rather than a pointer to a vector, and changed the release function to swap with another vector rather than the pointer idiom. Updated BlockNode and CaseClauseNode to hold actual vectors instead of pointers to vectors. Added BreakpointCheckStatement.
  • kjs/nodes2string.cpp: (KJS::statementListStreamTo): Changed to work on a vector instead of a pointer to a vector. (KJS::BlockNode::streamTo): Ditto. (KJS::CaseClauseNode::streamTo): Ditto.
  • wtf/AlwaysInline.h: Added NEVER_INLINE.
  • wtf/PassRefPtr.h: Tweaked formatting. Added clear() function that matches the ones in OwnPtr and auto_ptr.
  • wtf/RefPtr.h: Ditto.
12:17 PM Changeset in webkit [28936] by ap@webkit.org
  • 2 edits in trunk/WebKit/win

Reviewed by Steve and Darin.

<rdar://problem/5497037> Win32: Accelerator keys (ctrl-x,c,v,w,q,etc) only fire keyUp,
keyDown/Press consumed by accelerator table (14104)

<rdar://problem/5346299> preventing default behavior for key down does not block accelerators like Ctrl+N

This is WebKit part of a fix, most of which will be in Safari.

  • WebView.cpp: (WebViewWndProc): Return our result for WM_(SYS)KEYDOWN to let the client know whether further procesing is desired.
7:36 AM Changeset in webkit [28935] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • fix broken regression tests

The broken tests were fast/js/do-while-expression-value.html and
fast/js/while-expression-value.html.

  • kjs/nodes.cpp: Check in the correct version of this file. I had accidentally landed an old version of my patch for bug 16471. (KJS::statementListExecute): The logic here was backwards. Have to set the value even for non-normal execution results.
3:00 AM Changeset in webkit [28934] by ap@webkit.org
  • 5 edits
    1 add in trunk

Reviewed by Oliver.

<rdar://problem/5629995> Incorrect display of Danish characters on web site.

Test: http/tests/xmlhttprequest/response-encoding.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveData): Default to UTF-8 for HTML, too. It's unfortunate that we have to use different rules for main content and XHR responses, but this matches both IE and Firefox.
2:57 AM Changeset in webkit [28933] by ap@webkit.org
  • 1 edit in trunk/WebKit/win/ChangeLog

Correct ChangeLog spelling.

2:55 AM Changeset in webkit [28932] by ap@webkit.org
  • 2 edits in trunk/WebKit/win

Build fix: cannot use framework-style include for ProgIDMacros.h,
because the file is only created on a leter step.

  • ForEachCoClass.h:
1:09 AM Changeset in webkit [28931] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

Buildbot fix for wx port.

Note: See TracTimeline for information about the timeline view.