⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 27, 2007:

11:50 PM Changeset in webkit [29011] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Alexey Proskuryakov.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): Avoid calling EventHandler::resizeLayerDestroyed() if the document is being destroyed.
11:13 PM ApplicationsGtk created by alp@atoker.com
List WebKit/GTK+ applications (feel free to add more)
7:22 PM Changeset in webkit [29010] by mitz@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

Test: fast/layers/resize-layer-deletion-crash.html

The event handler has only a weak reference to the layer that is
currently in resize mode, so it is the layer's responsibility to let
the event handler know if it has been destroyed while in that mode.

  • page/EventHandler.cpp: (WebCore::EventHandler::resizeLayerDestroyed): Added. Resets m_resizeLayer to 0.
  • page/EventHandler.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): Added a call to EventHandler::resizeLayerDestroyed() if the layer is in resize mode.

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/layers/resize-layer-deletion-crash-expected.txt: Added.
  • fast/layers/resize-layer-deletion-crash.html: Added.
5:25 PM Changeset in webkit [29009] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Alice Liu.

  • platform/win/Skipped: Remove xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame.html since it is now passing.
4:57 PM Changeset in webkit [29008] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Sam Weinig.

​http://bugs.webkit.org/show_bug.cgi?id=16539
<rdar://problem/5659269>

The same-origin check was missing in the implementation of
setTimeout, setInterval, addEventListener, and removeEventListener.

Suppose <​http://www.badguy.com/> contains an iframe to
<​http://www.goodguy.com/>. Now www.badguy.com can steal
www.goodguy.com cookies by running this code:

setTimeout.call(frames[0], "alert(document.cookie)", 1000);

This patch changes the behavior so that setTimeout to does
nothing and returns an undefined value if the caller is not
permitted to script the window whose setTimeout method is being
called. The same applies to setInterval, addEventListener, and
removeEventListener.

Tests: http/tests/security/cross-frame-access-call.html

  • bindings/js/kjs_window.cpp: (KJS::WindowProtoFuncSetTimeout::callAsFunction) (KJS::WindowProtoFuncSetInterval::callAsFunction) (KJS::WindowProtoFuncAddEventListener::callAsFunction) (KJS::WindowProtoFuncRemoveEventListener::callAsFunction)

LayoutTests:

Reviewed by Sam Weinig.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=16539
<rdar://problem/5659269>

  • http/tests/security/cross-frame-access-call-expected.txt: Added.
  • http/tests/security/cross-frame-access-call.html: Added.
4:11 PM Changeset in webkit [29007] by mitz@apple.com
  • 3 edits
    8 adds in trunk

WebCore:

Reviewed by Dave Hyatt and Sam Weinig.

  • fix <rdar://problem/5605937> Inspector: Disclosure triangle not drawn in node's properties panel until click

Test: fast/layers/add-layer-with-nested-stacking.html
Test: fast/layers/remove-layer-with-nested-stacking.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::addChild): If the new child is overflow-only but has children of its own, dirty the stacking context's z-order lists since the grandchildren might need to be in them. (WebCore::RenderLayer::removeChild): Similarly for the old child.

LayoutTests:

Reviewed by Dave Hyatt and Sam Weinig.

  • pixel tests for <rdar://problem/5605937> Inspector: Disclosure triangle not drawn in node's properties panel until click
  • fast/layers/add-layer-with-nested-stacking.html: Added.
  • fast/layers/remove-layer-with-nested-stacking.html: Added.
  • platform/mac/fast/layers/add-layer-with-nested-stacking-expected.checksum: Added.
  • platform/mac/fast/layers/add-layer-with-nested-stacking-expected.png: Added.
  • platform/mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/mac/fast/layers/remove-layer-with-nested-stacking-expected.checksum: Added.
  • platform/mac/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
  • platform/mac/fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
3:14 PM Changeset in webkit [29006] by alp@webkit.org
  • 6 edits in trunk

2007-12-27 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16353
[GTK] Check for deprecated API use (G_DISABLE_DEPRECATED etc.)

Added the flags mentioned in the bug only when doing 'debug'
builds. -DGST_DISABLE_DEPRECATED only added when video is enabled.

2:20 PM Changeset in webkit [29005] by eric@webkit.org
  • 3 edits
    3 adds in trunk

Reviewed by Sam.

ASSERT in JavaScriptCore while viewing WICD test case
​http://bugs.webkit.org/show_bug.cgi?id=16626

  • kjs/nodes.cpp: (KJS::ForInNode::execute): move KJS_CHECK_EXCEPTION to proper place
1:58 PM Changeset in webkit [29004] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Alice Liu.

  • platform/mac-leopard/Skipped: Remove dom/html/level2/html/HTMLDocument12.html from the Skipped list because it is now passing.
12:55 PM Changeset in webkit [29003] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix typo in ChangeLog

12:54 PM Changeset in webkit [29002] by mitz@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

Reviewed by Eric Seidel.

Test: fast/dynamic/paused-event-dispatch.html

  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): (WebCore::FrameView::layout): Changed to always pause event dispatch and always resume event dispatch, regardless of whether the post-layout task time is active. However, if it is active, assert that event dispatch is still paused.

LayoutTests:

Reviewed by Eric Seidel.

  • fast/dynamic/paused-event-dispatch-expected.txt: Added.
  • fast/dynamic/paused-event-dispatch.html: Added.
  • fast/dynamic/resources/paused-event-dispatch-iframe.html: Added.
8:54 AM Changeset in webkit [29001] by mrowe@apple.com
  • 2 edits in trunk/PlanetWebKit

Add another feed to Planet WebKit.

12:34 AM Changeset in webkit [29000] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Maciej.

  • platform/win/Skipped: Move cross-frame-access-protocol* tests to show that they are failing because of a lack of ssl on windows.
12:28 AM Changeset in webkit [28999] by weinig@apple.com
  • 48 edits in trunk/LayoutTests

Rubber-stamped by Maciej.

  • Change more tests to use the new layoutTestController.globalFlag style polling instead of the "flag frame hack".
  • http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-port-expected.txt:
  • http/tests/security/cross-frame-access-private-browsing-expected.txt:
  • http/tests/security/cross-frame-access-protocol-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url.html:
  • http/tests/security/host-compare-case-insensitive-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS.html:
  • http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessee-iframe.html:
  • http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessee-opened-frame.html:
  • http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessor-iframe.html:
  • http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessor-opened-frame.html:
  • http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html:
  • http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-window-open.html:
  • http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe.html:
  • http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open.html:
  • http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe.html:
  • http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open.html:
  • http/tests/security/protocol-compare-case-insensitive-expected.txt:
  • http/tests/security/resources/cross-frame-iframe.html:
12:22 AM Changeset in webkit [28998] by ap@webkit.org
  • 3 edits
    10 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14500
need to be more generous about charset declaration with meta tag


​http://bugs.webkit.org/show_bug.cgi?id=12526
<rdar://problem/4867183> Safari ignores encoding description "charset=Shift_JIS" in invalid html

<rdar://problem/4892428> Unlike other browsers, WebKit ignores <meta> charset definitions outside the head

<rdar://problem/5643774> REGRESSION: Text is garbled when clicking a link inside an Arabic website

Tests: fast/encoding/ahram-org-eg.html

fast/encoding/bandai-co-jp-releases.html
fast/encoding/floraexpress-ru.html
fast/encoding/hanarei-blog32-fc2-com.html
fast/encoding/yahoo-mail.html

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Don't stop looking for <meta> until we've seen at least 512 bytes of input.

Dec 26, 2007:

10:54 PM BuildingGtk edited by jmalonzo@unpluggable.com
added autotools documentation (diff)
10:05 PM Changeset in webkit [28997] by alp@webkit.org
  • 6 edits
    7 adds in trunk

2007-12-26 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16390
Use autotools or GNU make as the build system for the GTK port

8:01 PM Changeset in webkit [28996] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Anders Carlsson.

  • re-categorize some SVG tests the are failing on Windows
  • platform/win/Skipped:
6:33 PM Changeset in webkit [28995] by weinig@apple.com
  • 12 edits
    5 moves in trunk/LayoutTests

Reviewed by Alice Liu.

Re-enable disabled tests with new polling logic using layoutTestController.globalFlag.

  • http/tests/security/dataURL/resources/foreign-domain-data-url-accessee-iframe.html:
  • http/tests/security/dataURL/resources/foreign-domain-data-url-accessee-opened-frame.html:
  • http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-iframe.html:
  • http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-opened-frame.html:
  • http/tests/security/dataURL/resources/foreign-domain-data-url-window-location.html:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html-disabled.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html-disabled: Removed.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html-disabled.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html-disabled: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html-disabled.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html-disabled: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html-disabled.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html-disabled: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html-disabled.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html-disabled: Removed.
  • platform/win/Skipped:
3:55 PM Changeset in webkit [28994] by alice.liu@apple.com
  • 2 edits in trunk/LayoutTests

removing tests tracked by <rdar://5463489> A number of layout tests should be using
execCommand instead of textInputController

2:16 PM Changeset in webkit [28993] by ap@webkit.org
  • 2 edits
    1 move
    2 adds in trunk

Reviewed by Sam Weinig.

​http://bugs.webkit.org/show_bug.cgi?id=16609
Make manual-tests/xmlhttprequest-contenttype-empty.html test automatic

1:25 AM Changeset in webkit [28992] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

12:40 AM Changeset in webkit [28991] by rwlbuis@webkit.org
  • 6 edits
    8 adds in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=15514
<clipPath> with <use> not respected
​http://bugs.webkit.org/show_bug.cgi?id=16557
SVG circle elements have been clipped away completely, instead of partially.

Add toClipPath to get clip path data for the clipping paths. Implement it for <use>, thereby allowing clip paths using use.

Note: See TracTimeline for information about the timeline view.