⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 31, 2007:

7:04 PM Changeset in webkit [29058] by weinig@apple.com
  • 10 edits
    8 adds
    2 deletes in trunk

WebCore:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=16637
Acid3 expects ExeceptionCode constants to be defined on DOMException objects

  • Make DOMException a real JS object.

Test: fast/dom/DOMException/prototype-object.html

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:

This is no longer needed as the autogenerated classes now includes the
constructor.

  • bindings/js/JSDOMExceptionConstructor.cpp: Removed.
  • bindings/js/JSDOMExceptionConstructor.h: Removed.

Create on demand and use the new class for DOMExceptions.

  • bindings/js/kjs_binding.cpp: (KJS::setDOMException):

Remove no longer needed custom constructor getter.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):

Don't expose DOMCoreException as the name of class by special casing
the user visible class name to be DOMException.

  • bindings/scripts/CodeGeneratorJS.pm:

The DOMException class/file needs to be named DOMCoreException because there is
name conflict with one of the Objective-C bindings classes. It should be renamed
to DOMException when the Objective-C bindings are moved into WebKit.

  • dom/DOMCoreException.cpp: Added. (WebCore::DOMCoreException::DOMCoreException): (WebCore::DOMCoreException::toString):
  • dom/DOMCoreException.h: Added. (WebCore::DOMCoreException::): (WebCore::DOMCoreException::code): (WebCore::DOMCoreException::name): (WebCore::DOMCoreException::message):
  • dom/DOMCoreException.idl: Added.
  • page/DOMWindow.idl:

LayoutTests:

Reviewed by Darin.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=16637
Acid3 expects ExeceptionCode constants to be defined on DOMException objects

  • fast/dom/DOMException: Added.
  • fast/dom/DOMException/prototype-object-expected.txt: Added.
  • fast/dom/DOMException/prototype-object.html: Added.
  • fast/dom/DOMException/resources: Added.
  • fast/dom/DOMException/resources/prototype-object.js: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/xmlhttprequest/connection-error-sync-expected.txt:
6:01 PM Changeset in webkit [29057] by weinig@apple.com
  • 5 edits in trunk/WebCore

Re-enable querySelector and querySelectorAll and touch the necessary files to not
kill the windows build.

  • WebCore.vcproj/build-generated-files.sh:
  • bindings/scripts/CodeGeneratorCOM.pm:
  • dom/Document.idl:
  • dom/Element.idl:
5:45 PM Changeset in webkit [29056] by Darin Adler
  • 2 edits in trunk/LayoutTests
  • fast/dom/HTMLFormElement/elements-not-in-document-expected.txt: Updated results to expect success. I accdidentally landed an expected failure instead!
5:37 PM Changeset in webkit [29055] by Darin Adler
  • 3 edits in trunk/WebCore
  • fix Windows build
  • dom/Document.idl: Temporarily disable querySelector and querySelectorAll, since they are showing up as pure virtual functions. Sam can fix this later.
  • dom/Element.idl: Ditto.
5:32 PM Changeset in webkit [29054] by mitz@apple.com
  • 21 edits
    5 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/dynamic/create-renderer-for-whitespace-only-text.html

  • dom/Node.cpp: (WebCore::Node::attach): Added code to check if this node's renderer has become the "previous renderer" of any sibling text node, and if so, ensure that that node gets a renderer if it now needs one. (WebCore::Node::createRendererIfNeeded): Removed the assertion that the node is not attached.

LayoutTests:

Reviewed by Darin Adler.

  • fast/dynamic/create-renderer-for-whitespace-only-text.html: Added.
  • fast/dynamic/style-access-late-stylesheet-load-expected.txt:
  • platform/mac-leopard/fast/dynamic: Added.
  • platform/mac-leopard/fast/dynamic/create-renderer-for-whitespace-only-text-expected.checksum: Added.
  • platform/mac-leopard/fast/dynamic/create-renderer-for-whitespace-only-text-expected.png: Added.
  • platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/mac/editing/inserting/editable-html-element-expected.txt:
  • platform/mac/editing/inserting/editing-empty-divs-expected.txt:
  • platform/mac/editing/pasteboard/paste-TIFF-expected.txt:
  • platform/mac/editing/selection/4983858-expected.txt:
  • platform/mac/editing/selection/5136696-expected.txt:
  • platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
  • platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-after-paragraph-expected.txt:
  • platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-from-stylesheet-expected.txt:
  • platform/mac/fast/dynamic/create-renderer-for-whitespace-only-text-expected.txt: Added.
  • platform/mac/fast/dynamic/move-node-with-selection-expected.txt:
  • platform/mac/fast/forms/input-align-expected.txt:
  • platform/mac/fast/inline/positionedLifetime-expected.txt:
5:17 PM Changeset in webkit [29053] by Darin Adler
  • 7 edits
    6 adds in trunk

WebCore:

Reviewed by Mitz.

Test: fast/dom/HTMLFormElement/elements-not-in-document.html

This was a bug specific to forms that are not in the document tree.
The fix was to change the code to increment the document version number to match
up with other document change tracking. Maybe at some point we can clean these up
so we don't have so many competing change notification systems.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::replaceChild): Removed bogus comment. (WebCore::ContainerNode::addChild): Added an explicit incDOMTreeVersion call here, since this code path bypasses the subtree-modified event code.
  • dom/Element.cpp: (WebCore::Element::setAttribute): Remove the inDocument() check -- not all HTML collections are for things in the document. (WebCore::Element::setAttributeMap): Ditto.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent): Added a call to incDOMTreeVersion here; covers most cases of tree structure changes.
  • dom/Node.cpp: (WebCore::Node::attach): Remove call to incDOMTreeVersion -- creating a renderer has nothing to do with changes to the DOM tree! (WebCore::Node::detach): Ditto.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::registerFormElement): Remove call to incDOMTreeVersion. This is handled at a lower level and doesn't need to be here. (WebCore::HTMLFormElement::removeFormElement): Ditto.

LayoutTests:

Reviewed by Mitz.

  • fast/dom/HTMLFormElement: Added.
  • fast/dom/HTMLFormElement/elements-not-in-document-expected.txt: Added.
  • fast/dom/HTMLFormElement/elements-not-in-document.html: Added.
  • fast/dom/HTMLFormElement/resources: Added.
  • fast/dom/HTMLFormElement/resources/TEMPLATE.html: Added.
  • fast/dom/HTMLFormElement/resources/elements-not-in-document.js: Added.
4:20 PM Changeset in webkit [29052] by Darin Adler
  • 2 edits in trunk/WebKitTools

Suggested by Antti.

  • Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until we get it installed on the build bots.
4:18 PM Changeset in webkit [29051] by Darin Adler
  • 16 edits
    8 adds in trunk

WebCore:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14994
Support for MessageEvent and cross-domain messaging

Test: http/tests/messaging/cross-domain-message-send.html

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Allow cross-domain access to the postMessage function. (WebCore::JSDOMWindow::postMessage):
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • dom/Event.cpp: (WebCore::Event::isMessageEvent):
  • dom/Event.h:
  • dom/EventNames.h: New event name
  • dom/MessageEvent.cpp: Added.
  • dom/MessageEvent.h: Added.
  • dom/MessageEvent.idl: Added.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Added.
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

Reviewed by Darin.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=14994
Support for MessageEvent and cross-domain messaging

  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/messaging: Added.
  • http/tests/messaging/cross-domain-message-send-expected.txt: Added.
  • http/tests/messaging/cross-domain-message-send.html: Added.
  • http/tests/messaging/resources: Added.
  • http/tests/messaging/resources/cross-domain-message-receive.html: Added.
3:56 PM Changeset in webkit [29050] by Darin Adler
  • 3 edits in trunk/WebCore

Suggested by Antti.

  • turn ENABLE_VIDEO back off for Windows until we can install QuickTime on the build bots
  • WebCore.vcproj/WebCore.vcproj: Removed ENABLE_VIDEO.
  • WebCore.vcproj/build-generated-files.sh: Ditto.
4:56 AM ApplicationsGtk edited by alp@atoker.com
Add a feed reader app (diff)

Dec 30, 2007:

11:48 PM Changeset in webkit [29049] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-30 Alp Toker <​alp@atoker.com>

Reviewed by Dan Bernstein.

Silence warning.

  • dom/NodeList.h:
11:06 PM Changeset in webkit [29048] by pewtermoose@webkit.org
  • 3 edits in trunk/WebKit/win

Reviewed by Darin.

Bug 16578: Windows Web Inspector window needs minimum size
​http://bugs.webkit.org/show_bug.cgi?id=16578

  • WebInspectorClient.cpp: (WebInspectorClient::onGetMinMaxInfo): (WebInspectorWndProc):
  • WebInspectorClient.h:
11:03 PM Changeset in webkit [29047] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam.

More small cleanup to array_object.cpp

  • kjs/array_object.cpp: (KJS::ArrayProtoFuncToString::callAsFunction): (KJS::ArrayProtoFuncToLocaleString::callAsFunction): (KJS::ArrayProtoFuncJoin::callAsFunction): (KJS::ArrayProtoFuncConcat::callAsFunction): (KJS::ArrayProtoFuncReverse::callAsFunction): (KJS::ArrayProtoFuncShift::callAsFunction): (KJS::ArrayProtoFuncSlice::callAsFunction): (KJS::ArrayProtoFuncSort::callAsFunction): (KJS::ArrayProtoFuncSplice::callAsFunction): (KJS::ArrayProtoFuncUnShift::callAsFunction): (KJS::ArrayProtoFuncFilter::callAsFunction): (KJS::ArrayProtoFuncMap::callAsFunction): (KJS::ArrayProtoFuncEvery::callAsFunction):
11:03 PM Changeset in webkit [29046] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam.

Apply wkstyle to array_object.cpp

  • kjs/array_object.cpp: (KJS::ArrayPrototype::ArrayPrototype): (KJS::ArrayPrototype::getOwnPropertySlot): (KJS::ArrayProtoFuncConcat::callAsFunction): (KJS::ArrayProtoFuncPop::callAsFunction): (KJS::ArrayProtoFuncReverse::callAsFunction): (KJS::ArrayProtoFuncShift::callAsFunction): (KJS::ArrayProtoFuncSlice::callAsFunction): (KJS::ArrayProtoFuncSort::callAsFunction): (KJS::ArrayProtoFuncSplice::callAsFunction): (KJS::ArrayProtoFuncUnShift::callAsFunction): (KJS::ArrayProtoFuncFilter::callAsFunction): (KJS::ArrayProtoFuncMap::callAsFunction): (KJS::ArrayProtoFuncEvery::callAsFunction): (KJS::ArrayProtoFuncLastIndexOf::callAsFunction): (KJS::ArrayObjectImp::ArrayObjectImp): (KJS::ArrayObjectImp::implementsConstruct): (KJS::ArrayObjectImp::construct): (KJS::ArrayObjectImp::callAsFunction):
11:02 PM Changeset in webkit [29045] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

Reviewed by Sam.

Remove maxInt/minInt, replacing with std:max/min<int>()

  • kjs/array_object.cpp: (KJS::ArrayProtoFuncSplice::callAsFunction):
  • kjs/operations.cpp:
  • kjs/operations.h:
11:02 PM Changeset in webkit [29044] by weinig@apple.com
  • 4 edits
    3 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16387
Variable names can be enumerated across domains
<rdar://problem/5640454>

Test: http/tests/security/cross-frame-access-enumeration.html

  • bindings/js/kjs_window.cpp: (KJS::Window::getPropertyNames): Override method to test same-origin policy.
  • bindings/js/kjs_window.h:

LayoutTests:

Reviewed by Oliver Hunt.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=16387

  • http/tests/security/cross-frame-access-enumeration-expected.txt: Added.
  • http/tests/security/cross-frame-access-enumeration.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-enumeration-test.html: Added.
11:01 PM Changeset in webkit [29043] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Sam.

  • Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
10:37 PM Changeset in webkit [29042] by Darin Adler
  • 1 edit
    1 add in trunk/LayoutTests
  • added missing results file
  • fast/events/event-instanceof-expected.txt: Added.
2:24 PM Changeset in webkit [29041] by weinig@apple.com
  • 13 edits
    2 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=10686
event instanceof MouseEvent throws exception

Add JS constructors for all the Event types.

Test: fast/events/event-instanceof.html

  • WebCore.xcodeproj/project.pbxproj:
  • dom/KeyboardEvent.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/OverflowEvent.idl:
  • dom/ProgressEvent.idl:
  • dom/TextEvent.idl:
  • dom/UIEvent.idl:
  • dom/WheelEvent.idl:
  • page/DOMWindow.idl:

LayoutTests:

Reviewed by Oliver Hunt.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=10686
event instanceof MouseEvent throws exception

  • fast/dom/Window/window-properties-expected.txt:
  • fast/events/event-instanceof.html: Added.
  • fast/events/resources/event-instanceof.js: Added.
9:44 AM Changeset in webkit [29040] by alp@webkit.org
  • 2 edits in trunk

2007-12-30 Alp Toker <​alp@atoker.com>

Build fix for older autoconf versions.

  • configure.ac:
9:05 AM Changeset in webkit [29039] by ddkilzer@apple.com
  • 6 edits
    8 moves
    2 adds in trunk

WebCore:

Reviewed by Darin.

The problem occurs when a replaced element (image, canvas, etc.) with
a percent-height attribute is contained by a table cell with an auto-
or percent-height attribute. If there are no other conditions to cause
the table cell's height to expand, an available height of zero will
always be returned. In these cases, the intrinsic height of the
replaced element should be used if it is greater than the available
height of the table cell.

Tests: fast/replaced/table-percent-height.html

tables/mozilla/bugs/bug137388-1.html
tables/mozilla/bugs/bug137388-2.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedHeightUsing):

LayoutTests:

Reviewed by Darin.

This test was added specifically for this bug. It tests the height of
replaced elements (canvas, embed, img, object, button, input, isindex,
select, textarea ) within table cells.

  • fast/replaced/table-percent-height-expected.txt: Added.
  • fast/replaced/table-percent-height.html: Added.

These test results were updated because they are more correct.

  • platform/mac/fast/replaced/width100percent-image-expected.checksum: Updated.
  • platform/mac/fast/replaced/width100percent-image-expected.png: Updated.
  • platform/mac/fast/replaced/width100percent-image-expected.txt: Updated.

Moved tests and results for these two tests from tables/mozilla_expected_failures/bugs
to tables/mozilla/bugs since these results have been fixed.

  • platform/mac/tables/mozilla/bugs/bug137388-1-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum.
  • platform/mac/tables/mozilla/bugs/bug137388-1-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.png.
  • platform/mac/tables/mozilla/bugs/bug137388-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt.
  • platform/mac/tables/mozilla/bugs/bug137388-2-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.checksum.
  • platform/mac/tables/mozilla/bugs/bug137388-2-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.png.
  • platform/mac/tables/mozilla/bugs/bug137388-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.png: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.checksum: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.png: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt: Removed.
  • tables/mozilla/bugs/bug137388-1.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug137388-1.html.
  • tables/mozilla/bugs/bug137388-2.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug137388-2.html.
  • tables/mozilla_expected_failures/bugs/bug137388-1.html: Removed.
  • tables/mozilla_expected_failures/bugs/bug137388-2.html: Removed.
8:21 AM Changeset in webkit [29038] by mrowe@apple.com
  • 17 edits in trunk/WebKitSite

2007-12-30 Mark Rowe <​mrowe@apple.com>

Unreviewed. Update WordPress to 2.3.2, which includes security fixes.

  • blog/wp-admin/admin.php:
  • blog/wp-admin/includes/file.php:
  • blog/wp-admin/install.php:
  • blog/wp-admin/setup-config.php:
  • blog/wp-app.php:
  • blog/wp-includes/formatting.php:
  • blog/wp-includes/functions.php:
  • blog/wp-includes/pluggable.php:
  • blog/wp-includes/post.php:
  • blog/wp-includes/query.php:
  • blog/wp-includes/taxonomy.php:
  • blog/wp-includes/version.php:
  • blog/wp-includes/wp-db.php:
  • blog/wp-mail.php:
  • blog/wp-settings.php:
  • blog/xmlrpc.php:
3:52 AM Changeset in webkit [29037] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-30 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16099
Crash in CURL for empty POST

We have to set POST even when the data is empty, otherwise cURL will
hang while waiting for a response.

  • platform/network/curl/ResourceHandleManager.cpp (ResourceHandleManager::setupPOST): allow empty POST
12:38 AM Changeset in webkit [29036] by eric@webkit.org
  • 12 edits
    1 add in trunk

Reviewed by Sam.

Update Number.toString to properly throw exceptions.
Cleanup code in Number.toString implementation.

  • kjs/number_object.cpp: (KJS::numberToString):
  • kjs/object.cpp: (KJS::Error::create): Remove bogus debug lines.
Note: See TracTimeline for information about the timeline view.