⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 1, 2008:

11:03 PM Changeset in webkit [29078] by Darin Adler
  • 2 edits in trunk/WebCore
  • fix release build
  • bindings/js/kjs_binding.cpp: (KJS::setDOMException): Initialize to avoid uninitialized variable warning. Removed default so we get a warning if there's a missing case.
10:59 PM Changeset in webkit [29077] by ddkilzer@apple.com
  • 5 edits in trunk/WebCore

Scripting MIME Types application/ecmascript, application/javascript not viewable
<​http://bugs.webkit.org/show_bug.cgi?id=11063>

Reviewed by Darin.

This patch consolidates the list of acceptable MIME types for JavaScript
source into the MIMETypeRegistry class, and replaces checks for these
types with a call to MIMETypeRegistry::isSupportedJavaScriptMIMEType().

No tests added since viewing JavaScript source is not testable.

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::isTextMIMEType): Use MIMETypeRegistry::isSupportedJavaScriptMIMEType() instead of a single hard-coded MIME type, "application/x-javascript".
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript): Moved list of JavaScript MIME types from here to MIMETypeRegistry::initialiseSupportedJavaScriptMIMETypes().
  • platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedJavaScriptMIMETypes): Added. List of MIME types came from HTMLScriptElement::shouldExecuteAsJavaScript(). (WebCore::initialiseSupportedNonImageMimeTypes): Remove single hard-coded MIME type, "application/x-javascript", from the list. (WebCore::initialiseMIMETypeRegistry): Initialise supportedJavaScriptMIMETypes, then pre-populate supportedNonImageMIMETypes with values in supportedJavaScriptMIMETypes. (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): Added.
  • platform/MIMETypeRegistry.h: Added isSupportedJavaScriptMIMEType().
10:54 PM Changeset in webkit [29076] by weinig@apple.com
  • 1 edit in trunk/WebCore/WebCoreSources.bkl

Fix wx build

10:44 PM Changeset in webkit [29075] by Darin Adler
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Eric.

Test: fast/js/kde/parse.html

  • kjs/lexer.cpp: (KJS::Lexer::lex): Added additional states to distinguish Unicode escapes at the start of identifiers from ones inside identifiers. Rejected characters that don't pass the isIdentStart and isIdentPart tests. (KJS::Lexer::convertUnicode): Removed incorrect FIXME comment.
  • kjs/lexer.h: Added new states to distinguish \u escapes at the start of identifiers from \u escapes inside identifiers.

LayoutTests:

Reviewed by Eric.

  • fast/js/kde/parse-expected.txt: Updated.
  • fast/js/kde/resources/parse.js: Added tests that cover both the non-ASCII characters themselves and the same characters parsed as \u sequences.
10:38 PM Changeset in webkit [29074] by Darin Adler
  • 1 edit in trunk/WebKit/win/ForEachCoClass.cpp

Fix a stray executable bit.

9:46 PM Changeset in webkit [29073] by weinig@apple.com
  • 31 edits
    15 copies
    1 move
    6 adds in trunk

WebCore:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=16691
Use real JS objects for the rest of the DOMExceptions (EventException, RangeException, etc)

  • Create JS objects for all the different types of exceptions, each with there own prototype and constructor.
  • Abstract all the logic and storage for exception classes in to an ExceptionBase class.
  • Move specialized ExceptionCodes into the exception classes. (ie. the EventExceptionCode enum is now in EventException).

Tests: fast/dom/DOMException/EventException.html

fast/dom/DOMException/RangeException.html
fast/dom/DOMException/XPathException.html
http/tests/xmlhttprequest/XMLHttpRequestException.html
svg/custom/SVGException.html

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::rotateFromVector):
  • bindings/js/kjs_binding.cpp: (KJS::setDOMException):
  • bindings/scripts/CodeGeneratorJS.pm: Use the constant values defined in the IDL as the ObjC bindings do.
  • bindings/scripts/CodeGeneratorObjC.pm:
  • dom/DOMCoreException.cpp: Removed.
  • dom/DOMCoreException.h: (WebCore::DOMCoreException::DOMCoreException):
  • dom/DOMCoreException.idl:
  • dom/Event.h:
  • dom/EventException.h: Copied from WebCore/dom/DOMCoreException.h. (WebCore::EventException::EventException): (WebCore::EventException::):
  • dom/EventException.idl: Copied from WebCore/dom/DOMCoreException.idl.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchEvent):
  • dom/ExceptionBase.cpp: Copied from WebCore/dom/DOMCoreException.cpp. (WebCore::ExceptionBase::ExceptionBase): (WebCore::ExceptionBase::toString):
  • dom/ExceptionBase.h: Copied from WebCore/dom/DOMCoreException.h. (WebCore::ExceptionBase::code):
  • dom/ExceptionCode.cpp: (WebCore::getExceptionCodeDescription):
  • dom/ExceptionCode.h: (WebCore::):
  • dom/Range.cpp: (WebCore::Range::insertNode): (WebCore::Range::checkNodeWOffset): (WebCore::Range::checkNodeBA): (WebCore::Range::selectNode): (WebCore::Range::selectNodeContents): (WebCore::Range::surroundContents):
  • dom/RangeException.h: (WebCore::RangeException::RangeException): (WebCore::RangeException::):
  • dom/RangeException.idl:
  • page/DOMWindow.idl:
  • svg/SVGColor.cpp: (WebCore::SVGColor::setRGBColor):
  • svg/SVGException.h: (WebCore::SVGException::SVGException): (WebCore::SVGException::):
  • svg/SVGException.idl:
  • svg/SVGLocatable.cpp: (WebCore::SVGLocatable::getTransformToElement):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dispatchEvent): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send):
  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequestException.h: Copied from WebCore/dom/DOMCoreException.h. (WebCore::XMLHttpRequestException::XMLHttpRequestException): (WebCore::XMLHttpRequestException::):
  • xml/XMLHttpRequestException.idl: Copied from WebCore/dom/DOMCoreException.idl.
  • xml/XPathEvaluator.h:
  • xml/XPathException.h: Copied from WebCore/dom/DOMCoreException.h. (WebCore::XPathException::XPathException): (WebCore::XPathException::):
  • xml/XPathException.idl: Copied from WebCore/dom/DOMCoreException.idl.
  • xml/XPathParser.cpp: (WebCore::XPath::Parser::parseStatement):
  • xml/XPathResult.cpp: (WebCore::XPathResult::convertTo): (WebCore::XPathResult::numberValue): (WebCore::XPathResult::stringValue): (WebCore::XPathResult::booleanValue): (WebCore::XPathResult::singleNodeValue): (WebCore::XPathResult::snapshotLength): (WebCore::XPathResult::iterateNext): (WebCore::XPathResult::snapshotItem):

LayoutTests:

Reviewed by Darin.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=16691
Use real JS objects for the rest of the DOMExceptions (EventException, RangeException, etc)

  • fast/dom/DOMException/EventException-expected.txt: Added.
  • fast/dom/DOMException/EventException.html: Copied from LayoutTests/fast/dom/DOMException/prototype-object.html.
  • fast/dom/DOMException/RangeException-expected.txt: Added.
  • fast/dom/DOMException/RangeException.html: Copied from LayoutTests/fast/dom/DOMException/prototype-object.html.
  • fast/dom/DOMException/XPathException-expected.txt: Added.
  • fast/dom/DOMException/XPathException.html: Copied from LayoutTests/fast/dom/DOMException/prototype-object.html.
  • fast/dom/DOMException/resources/EventException.js: Copied from LayoutTests/fast/dom/DOMException/resources/prototype-object.js.
  • fast/dom/DOMException/resources/RangeException.js: Copied from LayoutTests/fast/dom/DOMException/resources/prototype-object.js.
  • fast/dom/DOMException/resources/XPathException.js: Copied from LayoutTests/fast/dom/DOMException/resources/prototype-object.js.
  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/xmlhttprequest/XMLHttpRequestException-expected.txt: Added.
  • http/tests/xmlhttprequest/XMLHttpRequestException.html: Added.
  • svg/custom/SVGException-expected.txt: Added.
  • svg/custom/SVGException.html: Copied from LayoutTests/fast/dom/DOMException/prototype-object.html.
  • svg/custom/resources/SVGException.js: Copied from LayoutTests/fast/dom/DOMException/resources/prototype-object.js.
4:38 PM Changeset in webkit [29072] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Dan.

  • DefaultDelegates/WebDefaultPolicyDelegate.m: Check return value of -[NSFileManager fileExistsAtPath:isDirectory:] before using the value of isDirectory.
12:44 PM Changeset in webkit [29071] by weinig@apple.com
  • 2 edits in trunk/WebCore

Remove JSDomExceptionConstructor.lut.h from clean step
as it no longer exists.

  • GNUmakefile.am:
12:42 PM Changeset in webkit [29070] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • Windows build fix
  • WebCore.vcproj/WebCore.vcproj:
11:52 AM Changeset in webkit [29069] by pewtermoose@webkit.org
  • 3 edits in trunk/WebKit/win

Attempt to fix the Windows bots until they can get the Windows SDK installed.

11:47 AM Changeset in webkit [29068] by Darin Adler
  • 4 edits in trunk/JavaScriptCore
  • rolled scope chain optimization out; it was breaking the world
11:35 AM Changeset in webkit [29067] by Darin Adler
  • 13 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Also included one other speed-up -- remove the call to reserveCapacity from
FunctionBodyNode::processDeclarations in all but the most unusual cases.

Together these make SunSpider 1.016x as fast.

  • JavaScriptCore.exp: Updated.
  • kjs/ExecState.cpp: (KJS::globalEmptyList): Added. Called only when creating global ExecState instances. (KJS::ExecState::ExecState): Broke constructor up into three separate functions, for the three separate node types. Also went through each of the three and streamlined as much as possible, removing dead code. This prevents us from having to access the global in the function body version of the constructor.
  • kjs/ExecState.h: Added emptyList(). Replaced the constructor with a set of three that are specific to the different node types that can create new execution state objects.
  • kjs/array_object.cpp: (KJS::ArrayProtoFuncToLocaleString::callAsFunction): Use exec->emptyList() instead of List::empty(). (KJS::ArrayProtoFuncConcat::callAsFunction): Ditto. (KJS::ArrayProtoFuncSlice::callAsFunction): Ditto. (KJS::ArrayProtoFuncSplice::callAsFunction): Ditto. (KJS::ArrayProtoFuncFilter::callAsFunction): Ditto.
  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): Updated to call new ExecState constructor. (KJS::GlobalFuncImp::callAsFunction): Ditto (for eval).
  • kjs/function_object.cpp: (FunctionObjectImp::construct): Use exec->emptyList() instead of List::empty().
  • kjs/list.cpp: Removed List::empty.
  • kjs/list.h: Ditto.
  • kjs/nodes.cpp: (KJS::ElementNode::evaluate): Use exec->emptyList() instead of List::empty(). (KJS::ArrayNode::evaluate): Ditto. (KJS::ObjectLiteralNode::evaluate): Ditto. (KJS::PropertyListNode::evaluate): Ditto. (KJS::FunctionBodyNode::processDeclarations): Another speed-up. Check the capacity before calling reserveCapacity, because it doesn't get inlined the local storage vector is almost always big enough -- saving the function call overhead is a big deal. (KJS::FuncDeclNode::makeFunction): Use exec->emptyList() instead of List::empty(). (KJS::FuncExprNode::evaluate): Ditto.
  • kjs/object.cpp: (KJS::tryGetAndCallProperty): Ditto.
  • kjs/property_slot.cpp: (KJS::PropertySlot::functionGetter): Ditto.
  • kjs/string_object.cpp: (KJS::StringProtoFuncSplit::callAsFunction): Ditto.
11:16 AM Changeset in webkit [29066] by Darin Adler
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Geoff.

Fixes 34 failing test cases in the fast/regex/test1.html test.

Restored the stack which prevents infinite loops for brackets that match the empty
string; it had been removed as an optimization.

Unfortunately, restoring this stack causes the regular expression test in SunSpider
to be 1.095x as slow and the overall test to be 1.004x as slow. Maybe we can find
a correct optimization to restore the speed!

It's possible the original change was on the right track but just off by one.

  • pcre/pcre_exec.cpp: Add back eptrblock, but name it BracketChainNode. (MatchStack::pushNewFrame): Add back the logic needed here. (startNewGroup): Ditto. (match): Ditto.

LayoutTests:

Reviewed by Geoff.

  • fast/regex/test1-expected.txt: Update results changed by restoring the logic to avoid failing on infinite repeats of brackets that match the empty string.
11:13 AM Changeset in webkit [29065] by Darin Adler
  • 4 edits in trunk/JavaScriptCore

Reviewed by Geoff.

This gives a 1.019x speedup on SunSpider.

After doing this, I realized this probably will be obsolete when the optimization
to avoid creating an activation object is done. When we do that one we should check
if rolling this out will speed things up, since this does add overhead at the time
you copy the scope chain.

  • kjs/object.h: Removed the ScopeChain::release function. It was marked inline, and called in exactly one place, so moved it there. No idea why it was in this header file!
  • kjs/scope_chain.cpp: Removed the overload of the ScopeChain::push function that takes another ScopeChain. It was unused. I think we used it over in WebCore at one point, but not any more.
  • kjs/scope_chain.h: Changed ScopeChainNode into a struct rather than a class, got rid of its constructor so we can have one that's uninitialized, and moved the refCount into a derived struct, ScopeChainHeapNode. Made _node mutable so it can be changed in the moveToHeap function. Changed the copy constructor and assignment operator to call moveToHeap, since the top node can't be shared when it's embedded in another ScopeChain object. Updated functions as needed to handle the case where the first object isn't on the heap or to add casts for cases where it's guaranteed to be. Changed the push function to always put the new node into the ScopeChain object; it will get put onto the heap when needed later.
10:57 AM Changeset in webkit [29064] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.


Fixed slight logic error in reserveCapacity, where we would reallocate
the storage buffer unnecessarily.

  • wtf/Vector.h: (WTF::::reserveCapacity): No need to grow the buffer if newCapacity is equal to capacity().
10:14 AM BuildingGtk edited by sylvain.pasche@gmail.com
link to ApplicationsGtk (diff)
10:12 AM ApplicationsGtk edited by sylvain.pasche@gmail.com
added PyWebKitGtk (diff)
10:05 AM Changeset in webkit [29063] by weinig@apple.com
  • 2 edits in trunk/WebCore

Try again to fix the builds

  • DerivedSources.make:
9:45 AM Changeset in webkit [29062] by weinig@apple.com
  • 4 edits in trunk/WebCore

Fix non-mac builds.

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
2:40 AM Changeset in webkit [29061] by eric@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Alexey.

Don't replace \ with / in data: urls
​http://bugs.webkit.org/show_bug.cgi?id=16692

Test: fast/loader/url-data-replace-backslash.html

  • platform/KURL.cpp: (WebCore::KURL::init):
1:05 AM Changeset in webkit [29060] by alp@webkit.org
  • 4 edits in trunk

2008-01-01 Alp Toker <​alp@atoker.com>

GTK+ autotools build fix. Track changes in r29051, r29058 and pass the
correct parameter to AM_INIT_AUTOMAKE.

12:43 AM Changeset in webkit [29059] by Darin Adler
  • 6 edits in trunk/JavaScriptCore

Reviewed by Oliver.

Speeds SunSpider up 1.003x. That's a small amount, but measurable.

  • JavaScriptCore.exp: Updated.
  • kjs/Parser.h: (KJS::Parser::parse): Create the node with a static member function named create() instead of using new explicitly.
  • kjs/grammar.y: Changed calls to new FunctionBodyNode to use FunctionBodyNode::create().
  • kjs/nodes.cpp: (KJS::ProgramNode::create): Added. Calls new. (KJS::EvalNode::create): Ditto. (KJS::FunctionBodyNode::create): Ditto, but creates FunctionBodyNodeWithDebuggerHooks when a debugger is present. (KJS::FunctionBodyNode::execute): Removed debugger hooks. (KJS::FunctionBodyNodeWithDebuggerHooks::FunctionBodyNodeWithDebuggerHooks): Added. (KJS::FunctionBodyNodeWithDebuggerHooks::execute): Calls the debugger, then the code, then the debugger again.
  • kjs/nodes.h: Added create functions, made the constructors private and protected.

Dec 31, 2007:

7:04 PM Changeset in webkit [29058] by weinig@apple.com
  • 10 edits
    8 adds
    2 deletes in trunk

WebCore:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=16637
Acid3 expects ExeceptionCode constants to be defined on DOMException objects

  • Make DOMException a real JS object.

Test: fast/dom/DOMException/prototype-object.html

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:

This is no longer needed as the autogenerated classes now includes the
constructor.

  • bindings/js/JSDOMExceptionConstructor.cpp: Removed.
  • bindings/js/JSDOMExceptionConstructor.h: Removed.

Create on demand and use the new class for DOMExceptions.

  • bindings/js/kjs_binding.cpp: (KJS::setDOMException):

Remove no longer needed custom constructor getter.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):

Don't expose DOMCoreException as the name of class by special casing
the user visible class name to be DOMException.

  • bindings/scripts/CodeGeneratorJS.pm:

The DOMException class/file needs to be named DOMCoreException because there is
name conflict with one of the Objective-C bindings classes. It should be renamed
to DOMException when the Objective-C bindings are moved into WebKit.

  • dom/DOMCoreException.cpp: Added. (WebCore::DOMCoreException::DOMCoreException): (WebCore::DOMCoreException::toString):
  • dom/DOMCoreException.h: Added. (WebCore::DOMCoreException::): (WebCore::DOMCoreException::code): (WebCore::DOMCoreException::name): (WebCore::DOMCoreException::message):
  • dom/DOMCoreException.idl: Added.
  • page/DOMWindow.idl:

LayoutTests:

Reviewed by Darin.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=16637
Acid3 expects ExeceptionCode constants to be defined on DOMException objects

  • fast/dom/DOMException: Added.
  • fast/dom/DOMException/prototype-object-expected.txt: Added.
  • fast/dom/DOMException/prototype-object.html: Added.
  • fast/dom/DOMException/resources: Added.
  • fast/dom/DOMException/resources/prototype-object.js: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/xmlhttprequest/connection-error-sync-expected.txt:
6:01 PM Changeset in webkit [29057] by weinig@apple.com
  • 5 edits in trunk/WebCore

Re-enable querySelector and querySelectorAll and touch the necessary files to not
kill the windows build.

  • WebCore.vcproj/build-generated-files.sh:
  • bindings/scripts/CodeGeneratorCOM.pm:
  • dom/Document.idl:
  • dom/Element.idl:
5:45 PM Changeset in webkit [29056] by Darin Adler
  • 2 edits in trunk/LayoutTests
  • fast/dom/HTMLFormElement/elements-not-in-document-expected.txt: Updated results to expect success. I accdidentally landed an expected failure instead!
5:37 PM Changeset in webkit [29055] by Darin Adler
  • 3 edits in trunk/WebCore
  • fix Windows build
  • dom/Document.idl: Temporarily disable querySelector and querySelectorAll, since they are showing up as pure virtual functions. Sam can fix this later.
  • dom/Element.idl: Ditto.
5:32 PM Changeset in webkit [29054] by mitz@apple.com
  • 21 edits
    5 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/dynamic/create-renderer-for-whitespace-only-text.html

  • dom/Node.cpp: (WebCore::Node::attach): Added code to check if this node's renderer has become the "previous renderer" of any sibling text node, and if so, ensure that that node gets a renderer if it now needs one. (WebCore::Node::createRendererIfNeeded): Removed the assertion that the node is not attached.

LayoutTests:

Reviewed by Darin Adler.

  • fast/dynamic/create-renderer-for-whitespace-only-text.html: Added.
  • fast/dynamic/style-access-late-stylesheet-load-expected.txt:
  • platform/mac-leopard/fast/dynamic: Added.
  • platform/mac-leopard/fast/dynamic/create-renderer-for-whitespace-only-text-expected.checksum: Added.
  • platform/mac-leopard/fast/dynamic/create-renderer-for-whitespace-only-text-expected.png: Added.
  • platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/mac/editing/inserting/editable-html-element-expected.txt:
  • platform/mac/editing/inserting/editing-empty-divs-expected.txt:
  • platform/mac/editing/pasteboard/paste-TIFF-expected.txt:
  • platform/mac/editing/selection/4983858-expected.txt:
  • platform/mac/editing/selection/5136696-expected.txt:
  • platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
  • platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-after-paragraph-expected.txt:
  • platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-from-stylesheet-expected.txt:
  • platform/mac/fast/dynamic/create-renderer-for-whitespace-only-text-expected.txt: Added.
  • platform/mac/fast/dynamic/move-node-with-selection-expected.txt:
  • platform/mac/fast/forms/input-align-expected.txt:
  • platform/mac/fast/inline/positionedLifetime-expected.txt:
5:17 PM Changeset in webkit [29053] by Darin Adler
  • 7 edits
    6 adds in trunk

WebCore:

Reviewed by Mitz.

Test: fast/dom/HTMLFormElement/elements-not-in-document.html

This was a bug specific to forms that are not in the document tree.
The fix was to change the code to increment the document version number to match
up with other document change tracking. Maybe at some point we can clean these up
so we don't have so many competing change notification systems.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::replaceChild): Removed bogus comment. (WebCore::ContainerNode::addChild): Added an explicit incDOMTreeVersion call here, since this code path bypasses the subtree-modified event code.
  • dom/Element.cpp: (WebCore::Element::setAttribute): Remove the inDocument() check -- not all HTML collections are for things in the document. (WebCore::Element::setAttributeMap): Ditto.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent): Added a call to incDOMTreeVersion here; covers most cases of tree structure changes.
  • dom/Node.cpp: (WebCore::Node::attach): Remove call to incDOMTreeVersion -- creating a renderer has nothing to do with changes to the DOM tree! (WebCore::Node::detach): Ditto.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::registerFormElement): Remove call to incDOMTreeVersion. This is handled at a lower level and doesn't need to be here. (WebCore::HTMLFormElement::removeFormElement): Ditto.

LayoutTests:

Reviewed by Mitz.

  • fast/dom/HTMLFormElement: Added.
  • fast/dom/HTMLFormElement/elements-not-in-document-expected.txt: Added.
  • fast/dom/HTMLFormElement/elements-not-in-document.html: Added.
  • fast/dom/HTMLFormElement/resources: Added.
  • fast/dom/HTMLFormElement/resources/TEMPLATE.html: Added.
  • fast/dom/HTMLFormElement/resources/elements-not-in-document.js: Added.
4:20 PM Changeset in webkit [29052] by Darin Adler
  • 2 edits in trunk/WebKitTools

Suggested by Antti.

  • Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until we get it installed on the build bots.
4:18 PM Changeset in webkit [29051] by Darin Adler
  • 16 edits
    8 adds in trunk

WebCore:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14994
Support for MessageEvent and cross-domain messaging

Test: http/tests/messaging/cross-domain-message-send.html

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Allow cross-domain access to the postMessage function. (WebCore::JSDOMWindow::postMessage):
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • dom/Event.cpp: (WebCore::Event::isMessageEvent):
  • dom/Event.h:
  • dom/EventNames.h: New event name
  • dom/MessageEvent.cpp: Added.
  • dom/MessageEvent.h: Added.
  • dom/MessageEvent.idl: Added.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Added.
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

Reviewed by Darin.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=14994
Support for MessageEvent and cross-domain messaging

  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/messaging: Added.
  • http/tests/messaging/cross-domain-message-send-expected.txt: Added.
  • http/tests/messaging/cross-domain-message-send.html: Added.
  • http/tests/messaging/resources: Added.
  • http/tests/messaging/resources/cross-domain-message-receive.html: Added.
3:56 PM Changeset in webkit [29050] by Darin Adler
  • 3 edits in trunk/WebCore

Suggested by Antti.

  • turn ENABLE_VIDEO back off for Windows until we can install QuickTime on the build bots
  • WebCore.vcproj/WebCore.vcproj: Removed ENABLE_VIDEO.
  • WebCore.vcproj/build-generated-files.sh: Ditto.
4:56 AM ApplicationsGtk edited by alp@atoker.com
Add a feed reader app (diff)
Note: See TracTimeline for information about the timeline view.