⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 4, 2008:

9:45 PM Changeset in webkit [29193] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • update the list of tests failing on Windows because of font differences and uncomment a test that has been re-enabled on Mac.
  • platform/win/Skipped:
9:20 PM Changeset in webkit [29192] by oliver@apple.com
  • 5 edits in trunk

Fix bounds computation bugs responsible for ​http://bugs.webkit.org/show_bug.cgi?id=16015
and other image repaint bugs.

Reviewed by Beth Dakin.

We now cache the full local bounds for the <image> element, as otherwise certain
combinations of attribute changes could result in incorrect dirty rects.
Additionally we no longer use any of the integer bounds fields on RenderObject for
determining repaint bounds (this was the principle cause of bug #16015).

I also removed the outline painting code as it was both wrong, and not correctly
repainted. I feel safe doing this as no other browser or viewer supports outline
properties on svg elements.

I was unable to make a testcase for this unfortunately, despite seemingly deterministic
behaviour :(

9:13 PM Changeset in webkit [29191] by Beth Dakin
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Oliver.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16704 input with
type="hidden" matches :enabled/:disabled (Acid3 bug)

Prevent :enabled and :disabled from applying to input type="hidden"

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Rather than allowing :enabled and :disabled to apply to all controls, only allow it to apply to non-"hidden" controls
  • dom/Element.h: (WebCore::Element::isInputTypeHidden):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isInputTypeHidden):

LayoutTests:

Reviewed by Oliver.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=16704 input with
type="hidden" matches :enabled/:disabled (Acid3 bug)

  • fast/forms/hidden-input-not-enabled-expected.txt: Added.
  • fast/forms/hidden-input-not-enabled.html: Added.
8:05 PM Changeset in webkit [29190] by weinig@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add missing expected result.

  • fast/images/border-expected.txt: Added.
8:04 PM Changeset in webkit [29189] by weinig@apple.com
  • 10 edits
    3 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

  • Match the spec when calling getFloatValue, getStringValue, getCounterValue, getRectValue and getRGBColorValue of CSSPrimitiveValue by throwing exceptions if the type of the CSSPrimitiveValue is not the same as the type requested.
  • Fix the intermittent assertion failure seen in svg/css/glyph-orientation-rounding-test.xhtml

Test: fast/css/CSSPrimitiveValue-exceptions.html

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::getDoubleValue): (WebCore::CSSPrimitiveValue::getStringValue): (WebCore::CSSPrimitiveValue::getCounterValue): (WebCore::CSSPrimitiveValue::getRectValue): (WebCore::CSSPrimitiveValue::getRGBColorValue): (WebCore::CSSPrimitiveValue::getPairValue):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::getIntValue): (WebCore::CSSPrimitiveValue::getCounterValue): (WebCore::CSSPrimitiveValue::getRectValue): (WebCore::CSSPrimitiveValue::getDashboardRegionValue):
  • css/CSSPrimitiveValue.idl:

LayoutTests:

Reviewed by Oliver Hunt.

Throw exceptions for the CSSPrimitiveValue getters, matching the spec.

  • fast/css/CSSPrimitiveValue-exceptions-expected.txt: Added.
  • fast/css/CSSPrimitiveValue-exceptions.html: Added.
  • fast/css/resources/CSSPrimitiveValue-exceptions.js: Added.
  • fast/dom/prototypes.html:
  • fast/dom/wrapper-classes.html:
  • platform/mac/fast/dom/wrapper-classes-objc.html:
  • svg/css/glyph-orientation-rounding-test-expected.txt:
  • svg/css/glyph-orientation-rounding-test.xhtml: Pass in a unit so this doesn't throw. This patch also fixes the associated intermittent failure seen in this test.
6:32 PM Changeset in webkit [29188] by Antti Koivisto
  • 6 edits in trunk/WebCore

Reviewed by Darin.

Windows part of <rdar://problem/5647034>
Media tests crash if an old version of QuickTime is installed

Check QuickTime version on Windows too.

5:51 PM Changeset in webkit [29187] by weinig@apple.com
  • 4 edits
    1 copy
    1 add in trunk/LayoutTests

Reviewed by Kevin McCullough.

  • Splits Objective-C tests out of wrapper-classes.html and into platform specific test.
  • Adds tests for .proto and .constructor to JS wrapper tests.
  • fast/dom/wrapper-classes.html:
  • platform/mac/fast/dom/wrapper-classes-expected.txt:
  • platform/mac/fast/dom/wrapper-classes-objc-expected.txt: Added.
  • platform/mac/fast/dom/wrapper-classes-objc.html: Copied from fast/dom/wrapper-classes.html.
  • platform/win/Skipped:
5:45 PM Changeset in webkit [29186] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

Move svg/batik/text/smallFonts.svg
to skip list since it is still failing on tiger.

  • platform/mac-tiger/Skipped:
5:11 PM Changeset in webkit [29185] by Darin Adler
  • 3 edits
    1 copy
    2 adds in trunk

WebCore:

Reviewed by Maciej and Alice.

  • fix <rdar://problem/4404302> Borders where there should be none (canadasmountains.com)

Test: fast/images/border.html

  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Change the code that handles cases where the border value is not a number to use the value "0" for the border width instead of not setting the border width and style at all. This matches other browsers, and makes more sense.

LayoutTests:

Reviewed by Maciej and Alice.

  • test for <rdar://problem/4404302> Borders where there should be none (canadasmountains.com)
  • fast/images/border.html: Added.
  • fast/images/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
  • fast/images/resources/border.js: Added.
4:32 PM Changeset in webkit [29184] by alice.liu@apple.com
  • 6 edits in trunk

WebKitTools:

Reviewed by Alexey and Darin.

Adding "home" and "end" to DRT's keydown since
DOM key events can't handle keyIdentifiers at this point.

  • DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:]):
  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback):

LayoutTests:

Reviewed by Alexey and Darin.

  • editing/selection/move-begin-end.html: add a codepath that will test the same kind of functionality for home and end keys
  • platform/win/Skipped: removing section of tests that have been resolved
4:28 PM Changeset in webkit [29183] by Antti Koivisto
  • 2 edits in trunk/WebCore

Try to fix 64-bit build

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::isAvailable):
4:15 PM Changeset in webkit [29182] by Stephanie Lewis
  • 2 edits in trunk/WebCore

Fix another stringImpl leak.

  • platform/text/StringImpl.cpp: remove an extra allocation (WebCore::StringImpl::StringImpl):
3:34 PM Changeset in webkit [29181] by alice.liu@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

  • platform/graphics/win/FontCacheWin.cpp: fix loop condition that was causing crash
2:56 PM Changeset in webkit [29180] by oliver@apple.com
  • 1 edit
    1 move
    4 adds
    2 deletes in trunk/LayoutTests

Update tiger layout test results for svg/batik/text/smallFonts, and move to mac-tiger platform

RS=Adam

2:43 PM Changeset in webkit [29179] by timothy@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Adam Roben.

<rdar://problem/5671059> Always show the Timeline and Console buttons in the Inspector

  • page/inspector/inspector.css: Remove styles related to the toggle button and make the area always visible.
  • page/inspector/inspector.html: Remove the toggle button.
  • page/inspector/inspector.js: Remove code to toggle the status area.
2:35 PM Changeset in webkit [29178] by ap@webkit.org
  • 4 edits in trunk

Reviewed by Adam Roben.

Restore compatibility with shipping Safari beta.

WebKit:

​http://bugs.webkit.org/show_bug.cgi?id=16733
REGRESSION: Crash on Safari Start

  • Interfaces/IWebViewPrivate.idl: Should have added a new method at the end.

WebCore:

Temporarily restore BackwardDelete for Windows nightlies to work correctly.

  • editing/EditorCommand.cpp: (WebCore::CommandEntry::):
2:27 PM Changeset in webkit [29177] by ap@webkit.org
  • 8 edits in trunk

Reviewed by Darin.

<rdar://problem/5611712> xsl:sort does not use a case folding sort, and the 'case-order' attribute is ignored (16077)

Enable the fix on Windows.

2:08 PM Changeset in webkit [29176] by Antti Koivisto
  • 2 edits in trunk/WebCore

Fix build.

  • bindings/js/JSHTMLElementWrapperFactory.cpp:
1:44 PM Changeset in webkit [29175] by Antti Koivisto
  • 8 edits in trunk/WebCore

Reviewed by Darin.


Partial fix for <rdar://problem/5647034>
Media tests crash if an old version of QuickTime is installed

Disable media support if QuickTime is not current enough (>=7.3).


Windows patch coming soon.

  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • html/HTMLElementFactory.cpp: (WebCore::audioConstructor): (WebCore::videoConstructor): (WebCore::sourceConstructor):
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::isAvailable):
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::isAvailable):
1:02 PM Changeset in webkit [29174] by timothy@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5604409> JavaScript privilege escalation when Web Inspector accesses page unsafely (16011)

Check if the property is a getter before asking for the value.
If the property is a getter, we no longer show the value.

  • page/inspector/PropertiesSidebarPane.js:
  • page/inspector/inspector.css:
12:54 PM Changeset in webkit [29173] by alp@webkit.org
  • 2 edits in trunk

2008-01-04 Alp Toker <​alp@atoker.com>

Rubber-stamped by Mark Rowe.

Remove AM_MAINTAINER_MODE, as recommended by the automake manual. The
"rebuild rules" will now be enabled by default.

This obviates the need to pass '--enable-maintainer-mode' to
configure.

  • configure.ac:
11:31 AM Changeset in webkit [29172] by Adam Roben
  • 3 edits
    4 adds in trunk

Fix <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text

WebKit/win:

Fix <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text

Test: platform/win/editing/selection/shift-page-down-up.html

Reviewed by Oliver.

  • WebView.cpp: Correct the commands associated with Shift-PageUp/Shift-PageDown.

LayoutTests:

Added a test for <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text

Reviewed by Oliver.

  • platform/win/editing/selection/shift-page-up-down-expected.txt: Added.
  • platform/win/editing/selection/shift-page-up-down.html: Added.
11:25 AM Changeset in webkit [29171] by oliver@apple.com
  • 2 edits
    1 move in trunk/LayoutTests

<rdar://problem/5646437> REGRESSION (r28015): svg/batik/text/smallFonts fails

Reviewed by Darin

Regenerated expected output as filter elements are no longer generated in a default
build. This wasn't done when filters were turned off earlier due to other (now gone)
layout failures i didn't want to put in the expected output.

11:23 AM Changeset in webkit [29170] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix synthetic bold and italic on Windows

Covered by an existing test.

  • platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
9:18 AM Changeset in webkit [29169] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added some more failures.
6:52 AM Changeset in webkit [29168] by alp@webkit.org
  • 4 edits in trunk

2008-01-04 Alp Toker <​alp@atoker.com>

GTK+ autotools build fix. Terminate empty rules.

6:49 AM Changeset in webkit [29167] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

fix DRT after the changes to QWebPage.

The great thing is that we actually don't have
any regressions from the QWebPage change :)

Signed-off-by: Simon

6:49 AM Changeset in webkit [29166] by Simon Hausmann
  • 10 edits in trunk

Remove most dependencies of Widget/ScrollView onto native QWidgets.

This also brings the code closer in line with the Windows code. Seems
to work nicely on first try :)

Signed-off-by: Simon

6:48 AM Changeset in webkit [29165] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt
  • Remove the todo from QWebPage and move the code to QWebView.

Signed-off-by: Simon

6:48 AM Changeset in webkit [29164] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt
  • Move the various event methods to QWebPagePrivate. This is similar to QTextControl as well.

Signed-off-by: Simon

6:48 AM Changeset in webkit [29163] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt
  • Forward the event from QWebView to QWebPage through QObject::event. This is similar to the way QTextControl is working.

Signed-off-by: Simon

6:47 AM Changeset in webkit [29162] by Simon Hausmann
  • 16 edits in trunk

make QWebPage a QObject and get things to compile.

Nothing works currently though.

Signed-off-by: Simon

4:47 AM QtWebKitGitInstructions edited by bmeyer@trolltech.com
Joe Doe needs quotes otherwise the name is Joe (diff)
4:26 AM Changeset in webkit [29161] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Added some preliminary class documentation for QWebView, fixed a missing const() and some missing Q_PROPERTYs

Signed-off-by: Lars

4:25 AM Changeset in webkit [29160] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

add a viewportSize to QWebPage.

This is required to eventually make it a QObject only.

Signed-off-by: Simon

4:25 AM Changeset in webkit [29159] by Simon Hausmann
  • 5 edits in trunk

take a QString as identifier in QWebFrame::addToJSWindowObject.

Signed-off-by: Simon

4:24 AM Changeset in webkit [29158] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Call the frame arguments for the javascript callbacks "originatingFrame"

Signed-off-by: Lars

4:24 AM Changeset in webkit [29157] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

Moved the QWebPage::addToHistory signal into QWebHistoryInterface

Signed-off-by: Lars

4:23 AM Changeset in webkit [29156] by Simon Hausmann
  • 7 edits in trunk/WebKit/qt

moved title(), url(), icon() and initialLayoutComplete() from QWebPage to QWebFrame

Signed-off-by: Simon

4:19 AM Changeset in webkit [29155] by alp@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix bug URL in ChangeLog entry

4:18 AM Changeset in webkit [29154] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-04 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/attachment.cgi?bugid=16667&action=enter
make -j is failing with the autotools based system

Support parallel code generation. Nearly every use of explicit
multiple targets was a potential concurrency bug, though in practice
the bison rules were the first to be noticed because they took longer
to complete and broke the build immediately.

  • GNUmakefile.am:
2:44 AM Changeset in webkit [29153] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-04 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Re-use a single static dummy surface rather than creating and
destroying a surface for each CairoPath.

  • platform/graphics/cairo/CairoPath.h: (WebCore::CairoPath::CairoPath):
12:16 AM Changeset in webkit [29152] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Tiger build fix.

  • platform/Threading.h: The OSAtomic functions take non-volatile pointers on Tiger.
12:05 AM Changeset in webkit [29151] by alp@webkit.org
  • 2 edits in trunk/WebKitTools

2008-01-04 Alp Toker <​alp@atoker.com>

GTK+ DRT build fix for breakage introduced in r29149.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::execCommand):

Jan 3, 2008:

11:55 PM Changeset in webkit [29150] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Use platform-provided atomic operations in place of inline assembly to increase portability.

Reviewed by Maciej Stachowiak.

  • platform/Threading.h:

(WebCore::atomicIncrement):
(WebCore::atomicDecrement):

11:31 PM Changeset in webkit [29149] by ap@webkit.org
  • 24 edits in trunk

Reviewed by Darin.

<rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController

Added layoutTestController.execCommand to access editor commands that are not available
via document.execCommand.

11:15 PM Changeset in webkit [29148] by oliver@apple.com
  • 4 edits
    4 adds in trunk

Fix <rdar://problem/5668517> REGRESSION: Major under painting issues in SVG (carto.net dock example)

Revied by Maciej.

We need to cache the absolute bounds of the <image>,
as there's no reliable way to recompute the old bounding
box one we have started layout.

10:34 PM Changeset in webkit [29147] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-01-03 Xan Lopez <​xan@gnome.org>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16654
[GTK] Signal "navigation-requested" does not react correctly on
return TRUE from callbacks


  • WebView/webkitwebview.cpp: use our own accumulator for signals returning WebKitNavigationResponse. The emission will be stopped when any callback returns anything but WEBKIT_NAVIGATION_RESPONSE_ACCEPT.
10:23 PM Changeset in webkit [29146] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-03 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Support building in Scratchbox, which has a version of make that fails
on wildcard syntax. Use a vpath to match IDL files instead.

  • GNUmakefile.am:
10:00 PM Changeset in webkit [29145] by Darin Adler
  • 2 edits in trunk/WebKit
  • fix Safari build
  • WebKit.xcodeproj/project.pbxproj: Mark header private (fixes Safari build).
9:41 PM Changeset in webkit [29144] by mrowe@apple.com
  • 2 edits in trunk/WebKitLibraries

Update Tiger library to a G3-friendly version.

8:38 PM Changeset in webkit [29143] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Sam Weinig.

  • skip tests that are failing because font fallback results in a different font being used on Windows than on Mac.
  • platform/win/Skipped:
8:22 PM Changeset in webkit [29142] by jhoneycutt@apple.com
  • 3 edits in trunk/WebCore

2008-01-03 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

<rdar://problem/5504775> PDF page will not load first time after Adobe
Reader install, unless browser is relaunched

Refresh and re-search the plugin database if the MIME type is not
registered.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::isMIMETypeRegistered):
  • plugins/win/PluginDatabaseWin.h:
8:03 PM Changeset in webkit [29141] by adele@apple.com
  • 4 edits in trunk/WebKitLibraries

Update libraries for <rdar://problem/4106190> Include "Where from" metadata in drag-and-dropped images

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
6:04 PM Changeset in webkit [29140] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • platform/graphics/win/FontCacheWin.cpp: (WebCore::linkedFontEnumProc): Added. This callback is used to fetch a valid LOGFONT for a given family. (WebCore::getLinkedFonts): Added. Returns a vector of font families linked to the given font family by the Windows registry key HKLM\Software\...\FontLink\SystemLink. The registry values typically differ based on the installed language version of Windows. (WebCore::FontCache::getFontDataForCharacters): Changed to not use MLang font mapping, which is Windows code page based, except for characters in the range U+2000..U+200F. Instead, this function gets the font Uniscribe would use for the character. However, that font might not actually contain the character, in which case GDI font linking would substitute a different font. Therefore, this function walks the linked font list until it finds a font that actually contains the character.
5:28 PM Changeset in webkit [29139] by alice.liu@apple.com
  • 14 edits in trunk

WebKitTools:

Reviewed by Darin, Mitz.

fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly

the clickcount should not increase if the last click was at a different location. it's a new click.

  • DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
  • DumpRenderTree/mac/EventSendingController.h:
  • DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]):

LayoutTests:

Reviewed by Darin, Mitz.

updating expected results after fixing clickcount for
<rdar://5130762> mousedowns in different locations increase the clickcount incorrectly

  • fast/forms/focus-selection-input-expected.txt:
  • fast/forms/focus-selection-textarea-expected.txt:
  • platform/mac/fast/events/objc-event-api-expected.txt:
  • platform/mac/fast/inline/dirtyLinesForInline-expected.txt:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac/svg/custom/pointer-events-image-expected.txt:
  • platform/mac/svg/custom/pointer-events-path-expected.txt:
  • platform/mac/svg/custom/pointer-events-text-expected.txt:
  • platform/mac/svg/custom/text-hit-test-expected.txt:
5:17 PM Changeset in webkit [29138] by Darin Adler
  • 4 edits
    5 adds in trunk

WebCore:

Reviewed by Mitz.

Test: fast/table/border-changes.html

  • html/HTMLTableElement.h:
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute): Check the border type before and after parsing attributes, rather than doing this only for the rules attribute. (WebCore::HTMLTableElement::cellBorders): Added. (WebCore::HTMLTableElement::getSharedCellDecl): Changed to use cellBorders to factor out the rule about what type of borders to use.

LayoutTests:

Reviewed by Mitz.

  • fast/table/border-changes-expected.txt: Added.
  • fast/table/border-changes.html: Added.
  • fast/table/resources: Added.
  • fast/table/resources/TEMPLATE.html: Added.
  • fast/table/resources/border-changes.js: Added.
5:00 PM Changeset in webkit [29137] by adachan@apple.com
  • 2 edits in trunk/WebKit/win

Replaced the use of editor command "ForwardDelete" with "DeleteForward" to be consistent
with our use of "DeleteBackward".

Rubber-stamped by Jon.

  • WebView.cpp:
4:13 PM Changeset in webkit [29136] by Darin Adler
  • 2 edits in trunk/WebKitTools

Reviewed by Adam.

  • Scripts/update-webkit: Make this work a little better for the people at Apple who have a directory named Internal.
2:45 PM Changeset in webkit [29135] by kdecker@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Darin.

Fixed: <rdar://problem/4106190> Include "Where from" metadata in drag-and-dropped images


  • Misc/WebNSFileManagerExtras.h:
  • Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Added new method. Uses WebKitSystemInterface to set "Where from:" metadata information.
  • WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Added "Where from:" metadata for drag and dropped images.
2:10 PM Changeset in webkit [29134] by weinig@apple.com
  • 39 edits in trunk/WebCore

Reviewed by Darin.

Pass the prototype of WebCore JS objects up the constructor chain
rather than explicitly setting using setPrototype. This removes many
redundant settings of the prototype on construction. To avoid a CG
hazard, the prototype must be constructed before before calling the
constructor of the JS object.

  • JS objects that inherit from DOMObject, which all bindings objects (except Window) do, now can't implicitly have a jsNull prototype, but must explicitly pass it up the construction chain.
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::toJS):
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNode::JSEventTargetNode):
  • bindings/js/JSEventTargetNode.h:
  • bindings/js/JSHTMLAllCollection.h: (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
  • bindings/js/JSHTMLAudioElementConstructor.cpp: (WebCore::JSHTMLAudioElementConstructor::JSHTMLAudioElementConstructor):
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::toJS):
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter):
  • bindings/js/JSHTMLInputElementBase.cpp: (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
  • bindings/js/JSHTMLInputElementBase.h:
  • bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
  • bindings/js/JSLocation.cpp: (WebCore::JSLocation::JSLocation):
  • bindings/js/JSLocation.h:
  • bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
  • bindings/js/JSNamedNodesCollection.h:
  • bindings/js/JSNodeCustom.cpp: (WebCore::toJS):
  • bindings/js/JSSVGElementWrapperFactory.cpp: (WebCore::createJSSVGWrapper):
  • bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS):
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp): (KJS::JSXMLHttpRequestConstructorImp::construct): (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
  • bindings/js/JSXMLHttpRequest.h:
  • bindings/js/JSXSLTProcessor.cpp: (KJS::JSXSLTProcessor::JSXSLTProcessor): (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp): (KJS::XSLTProcessorConstructorImp::implementsConstruct): (KJS::XSLTProcessorConstructorImp::construct):
  • bindings/js/JSXSLTProcessor.h:
  • bindings/js/kjs_binding.h: (KJS::DOMObject::DOMObject): (KJS::cacheDOMObject): (KJS::cacheSVGDOMObject):
  • bindings/js/kjs_css.cpp: (WebCore::JSRGBColor::JSRGBColor): (WebCore::getJSRGBColor):
  • bindings/js/kjs_css.h:
  • bindings/js/kjs_events.cpp: (WebCore::JSClipboard::JSClipboard): (WebCore::toJS):
  • bindings/js/kjs_events.h:
  • bindings/js/kjs_html.cpp: (WebCore::ImageConstructorImp::ImageConstructorImp):
  • bindings/js/kjs_navigator.cpp: (KJS::Navigator::Navigator): (KJS::PluginBase::PluginBase):
  • bindings/js/kjs_navigator.h:
  • bindings/js/kjs_window.cpp: (KJS::Window::Window): (KJS::Window::location): (KJS::Window::getValueProperty):
  • bindings/js/kjs_window.h:
  • bindings/scripts/CodeGeneratorJS.pm:
1:40 PM Changeset in webkit [29133] by ap@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=10909
Hixie's XMLHttpRequest/018.html test fails

This was fixed earlier, just adding a test case.

  • http/tests/xmlhttprequest/web-apps/018-expected.txt: Added.
  • http/tests/xmlhttprequest/web-apps/018.html: Added.
  • http/tests/xmlhttprequest/web-apps/resources: Added.
  • http/tests/xmlhttprequest/web-apps/resources/018-test.xml: Added.
1:21 PM Changeset in webkit [29132] by alice.liu@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin.

This fixes pageup/down in iframes. test for this is fast/frames/iframe-scroll-page-up-down.html

  • WebView/WebHTMLView.mm: (-[WebHTMLView doCommandBySelector:]): Have the editor handle all the commands it supports instead of just text commands. If not handled by the editor, the webview will handle the command.
11:35 AM Changeset in webkit [29131] by adachan@apple.com
  • 3 edits in trunk/WebKit/win

Regression: backspace stopped working on text inputs

  • Replaced the use of editor command "BackwardDelete" with "DeleteBackward" since it's no longer supported.

Reviewed by Adam.

  • WebEditorClient.cpp: (WebEditorClient::textWillBeDeletedInTextField):
  • WebView.cpp:
11:00 AM Changeset in webkit [29130] by zecke@webkit.org
  • 4 edits in trunk/WebCore

2008-01-03 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Alp.

-This is from ​http://bugs.webkit.org/show_bug.cgi?id=16115

Change the Gtk ContextMenuItem code to generate the GtkMenuItem
or GtkCheckMenuItem on the fly. Currently we will create a
GtkCheckMenuItem if the ContextMenuItem has been checked. What needs
to be done is to change WebCore to tell the platform code if an item
is checkable or not.

  • platform/ContextMenuItem.h: (WebCore::PlatformMenuItemDescription::PlatformMenuItemDescription):
  • platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::appendItem):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::createNativeMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked):
10:37 AM Changeset in webkit [29129] by Adam Roben
  • 2 edits in trunk/WebKitTools

Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default

Rubberstamped by Mark.

  • Scripts/update-webkit-auxiliary-libs:
10:28 AM Changeset in webkit [29128] by mitz@apple.com
  • 2 edits in trunk/WebCore

Rubber-stamped by Adam Roben.

  • update the project hierarchy to match the on-disk organization of the platform directory.
  • WebCore.vcproj/WebCore.vcproj:
10:19 AM Changeset in webkit [29127] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily

​http://bugs.webkit.org/show_bug.cgi?id=15663

Added a fuzz factor into the Last-Modified comparison for downloading
WebKitAuxiliaryLibrary.zip.

The zip file is served from a set of mirrors who give Last-Modified
times that are off by 1-3 seconds from each other. This was causing
the build bots to redownload WebKitAuxiliaryLibrary for every build,
which would then cause all of WebCore to rebuild each time.

Reviewed by Mark.

  • Scripts/update-webkit-auxiliary-libs: Check if the new zip file is at least 30 seconds newer than the old one -- otherwise we assume that the difference in time is due to the mirrors being slightly offset from each other. (sub lastModifiedToUnixTime): Added.
9:15 AM Changeset in webkit [29126] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin.


Fixed: <rdar://problem/5660603> QuickDraw plug-ins can cause a 100% reproducible assertion failure in AppKit (breaks Safari UI)

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView updateAndSetWindow]): Simplified an early return for non-QuickDraw plug-ins and switched to using the more NSView friendly version of lockFocus, lockFocusIfCanDraw.
7:34 AM Changeset in webkit [29125] by Adam Roben
  • 2 edits in trunk/WebCore

Fix a buffer overrun and a leak introduced in r29098

Reviewed by Mark.

  • platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Only allocate one buffer, and make it be big enough to hold the string contents plus the null terminator.
6:40 AM Changeset in webkit [29124] by ap@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

Windows build fix.

  • DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
5:53 AM Changeset in webkit [29123] by Simon Hausmann
  • 11 edits in trunk

Moved QWebPage::open to QWebFrame::load and added setHtml.

Signed-off-by: Lars

5:50 AM Changeset in webkit [29122] by Simon Hausmann
  • 13 edits
    2 adds in trunk

Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.

Signed-off-by: Lars

5:40 AM Changeset in webkit [29121] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Fix compilation with gcc 4.3, include limits.h for INT_MAX

4:02 AM Changeset in webkit [29120] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-03 Alp Toker <​alp@atoker.com>

Suggested by Mark Rowe.

Fix indentation and remove trailing whitespace.

  • platform/network/curl/ResourceHandleManager.cpp:
3:57 AM QtWebKitContrib edited by Simon Hausmann
(diff)
3:56 AM QtWebKitContrib edited by Simon Hausmann
(diff)
3:53 AM QtWebKitContrib edited by Simon Hausmann
(diff)
3:31 AM QtWebKitContrib edited by Simon Hausmann
(diff)
3:04 AM Changeset in webkit [29119] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-03 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

Fix HTTP POST-based logins to sites like Facebook, GMail by ensuring
that the two POST methods don't conflict.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPOST):
1:30 AM QtWebKitTodo edited by zander@kde.org
(diff)
12:49 AM Changeset in webkit [29118] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • tests/mozilla/expected.html: The fix for bug 16696 also fixed a test case, ecma_3/RegExp/perlstress-002.js, so updated results to expect that test to succeed.
Note: See TracTimeline for information about the timeline view.