Context Navigation

← Previous Period
Next Period →

Timeline

Jan 5, 2008:

6:36 PM Changeset in webkit [29203] by weinig@apple.com

3 edits
4 adds in trunk

WebCore:

Reviewed by Eric Seidel.

Patch for http://bugs.webkit.org/show_bug.cgi?id=16758
ASSERT when using TreeWalker methods for a current node outside of the root (Acid3)

Ensure that returned nodes are within the root node, or return 0, in adherence with the spec.

Test: fast/dom/TreeWalker/TreeWalker-currentNode.html

dom/TreeWalker.cpp: (WebCore::TreeWalker::parentNode): (WebCore::TreeWalker::firstChild): (WebCore::TreeWalker::lastChild): (WebCore::TreeWalker::previousSibling): (WebCore::TreeWalker::nextSibling): (WebCore::TreeWalker::previousNode): (WebCore::TreeWalker::nextNode):

LayoutTests:

Reviewed by Eric Seidel.

Test for http://bugs.webkit.org/show_bug.cgi?id=16758
ASSERT when using TreeWalker methods for a current node outside of the root (Acid3)

fast/dom/TreeWalker: Added.
fast/dom/TreeWalker/TreeWalker-currentNode.html: Added.
fast/dom/TreeWalker/resources: Added.
fast/dom/TreeWalker/resources/TreeWalker-currentNode.js: Added.

6:24 PM Changeset in webkit [29202] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: Some more renaming plans.

6:16 PM Changeset in webkit [29201] by Darin Adler

2 edits in trunk/JavaScriptCore

API/JSRetainPtr.h: One more file that needed the change below.

6:14 PM Changeset in webkit [29200] by Darin Adler

2 edits in trunk/JavaScriptCore

wtf/OwnPtr.h: OwnPtr needs the same fix as RefPtr below.

6:12 PM Changeset in webkit [29199] by Adam Roben

2 edits in trunk/JavaScriptCore

Build fix.

Reviewed by Maciej.

wtf/RetainPtr.h: Use PtrType instead of T* because of the RemovePointer magic.

2:46 PM Changeset in webkit [29198] by Darin Adler

6 edits in trunk/JavaScriptCore

Rubber stamped by Maciej Stachowiak.

cut down own PIC branches by using a pointer-to-member-data instead of a pointer-to-member-function in WTF smart pointers

wtf/OwnArrayPtr.h:
wtf/OwnPtr.h:
wtf/PassRefPtr.h:
wtf/RefPtr.h:
wtf/RetainPtr.h: Use a pointer to the m_ptr member instead of the get member. The GCC compiler generates better code for this idiom.

3:44 AM Changeset in webkit [29197] by alp@webkit.org

2 edits in trunk

2008-01-05 Alp Toker <alp@atoker.com>

Rubber-stamped by Mark Rowe.

Fix configure script output with correct descriptions of the default
configuration options.

2:23 AM Changeset in webkit [29196] by alp@webkit.org

2 edits in trunk

2008-01-05 Sylvain Pasche <sylvain.pasche@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16736
Allow autogen.sh invocation from a separate build directory.

autogen.sh:

12:26 AM Changeset in webkit [29195] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

2008-01-05 Henry Mason <hmason@mac.com>

Reviewed by Maciej Stachowiak.

http://bugs.webkit.org/show_bug.cgi?id=16738
Bug 16738: Collector block offset could be stored as an cell offset instead of a byte offset

Gives a 0.4% SunSpider boost and prettier code.

kjs/collector.cpp: Switched to cell offsets from byte offsets (KJS::Collector::heapAllocate): (KJS::Collector::sweep):

12:02 AM Changeset in webkit [29194] by mrowe@apple.com

3 edits in trunk/JavaScriptCore

Have the two malloc zones print useful diagnostics if their free method are unexpectedly invoked.
Due to <rdar://problem/5671357> this can happen if an application attempts to free a pointer that
was not allocated by any registered malloc zone on the system.

Reviewed by Maciej Stachowiak.

Jan 4, 2008:

9:45 PM Changeset in webkit [29193] by mitz@apple.com

2 edits in trunk/LayoutTests

update the list of tests failing on Windows because of font differences and uncomment a test that has been re-enabled on Mac.

platform/win/Skipped:

9:20 PM Changeset in webkit [29192] by oliver@apple.com

5 edits in trunk

Fix bounds computation bugs responsible for http://bugs.webkit.org/show_bug.cgi?id=16015
and other image repaint bugs.

Reviewed by Beth Dakin.

We now cache the full local bounds for the <image> element, as otherwise certain
combinations of attribute changes could result in incorrect dirty rects.
Additionally we no longer use any of the integer bounds fields on RenderObject for
determining repaint bounds (this was the principle cause of bug #16015).

I also removed the outline painting code as it was both wrong, and not correctly
repainted. I feel safe doing this as no other browser or viewer supports outline
properties on svg elements.

I was unable to make a testcase for this unfortunately, despite seemingly deterministic
behaviour :(

9:13 PM Changeset in webkit [29191] by Beth Dakin

5 edits
2 adds in trunk

WebCore:

Reviewed by Oliver.

Fix for http://bugs.webkit.org/show_bug.cgi?id=16704 input with
type="hidden" matches :enabled/:disabled (Acid3 bug)

Prevent :enabled and :disabled from applying to input type="hidden"

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Rather than allowing :enabled and :disabled to apply to all controls, only allow it to apply to non-"hidden" controls
dom/Element.h: (WebCore::Element::isInputTypeHidden):
html/HTMLInputElement.h: (WebCore::HTMLInputElement::isInputTypeHidden):

LayoutTests:

Reviewed by Oliver.

Test for http://bugs.webkit.org/show_bug.cgi?id=16704 input with
type="hidden" matches :enabled/:disabled (Acid3 bug)

fast/forms/hidden-input-not-enabled-expected.txt: Added.
fast/forms/hidden-input-not-enabled.html: Added.

8:05 PM Changeset in webkit [29190] by weinig@apple.com

1 edit
1 add in trunk/LayoutTests

Add missing expected result.

fast/images/border-expected.txt: Added.

8:04 PM Changeset in webkit [29189] by weinig@apple.com

10 edits
3 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

Match the spec when calling getFloatValue, getStringValue, getCounterValue, getRectValue and getRGBColorValue of CSSPrimitiveValue by throwing exceptions if the type of the CSSPrimitiveValue is not the same as the type requested.
Fix the intermittent assertion failure seen in svg/css/glyph-orientation-rounding-test.xhtml

Test: fast/css/CSSPrimitiveValue-exceptions.html

css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::getDoubleValue): (WebCore::CSSPrimitiveValue::getStringValue): (WebCore::CSSPrimitiveValue::getCounterValue): (WebCore::CSSPrimitiveValue::getRectValue): (WebCore::CSSPrimitiveValue::getRGBColorValue): (WebCore::CSSPrimitiveValue::getPairValue):
css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::getIntValue): (WebCore::CSSPrimitiveValue::getCounterValue): (WebCore::CSSPrimitiveValue::getRectValue): (WebCore::CSSPrimitiveValue::getDashboardRegionValue):
css/CSSPrimitiveValue.idl:

LayoutTests:

Reviewed by Oliver Hunt.

Throw exceptions for the CSSPrimitiveValue getters, matching the spec.

fast/css/CSSPrimitiveValue-exceptions-expected.txt: Added.
fast/css/CSSPrimitiveValue-exceptions.html: Added.
fast/css/resources/CSSPrimitiveValue-exceptions.js: Added.
fast/dom/prototypes.html:
fast/dom/wrapper-classes.html:
platform/mac/fast/dom/wrapper-classes-objc.html:
svg/css/glyph-orientation-rounding-test-expected.txt:
svg/css/glyph-orientation-rounding-test.xhtml: Pass in a unit so this doesn't throw. This patch also fixes the associated intermittent failure seen in this test.

6:32 PM Changeset in webkit [29188] by Antti Koivisto

6 edits in trunk/WebCore

Reviewed by Darin.

Windows part of <rdar://problem/5647034>
Media tests crash if an old version of QuickTime is installed

Check QuickTime version on Windows too.

5:51 PM Changeset in webkit [29187] by weinig@apple.com

4 edits
1 copy
1 add in trunk/LayoutTests

Reviewed by Kevin McCullough.

Splits Objective-C tests out of wrapper-classes.html and into platform specific test.
Adds tests for .proto and .constructor to JS wrapper tests.

fast/dom/wrapper-classes.html:
platform/mac/fast/dom/wrapper-classes-expected.txt:
platform/mac/fast/dom/wrapper-classes-objc-expected.txt: Added.
platform/mac/fast/dom/wrapper-classes-objc.html: Copied from fast/dom/wrapper-classes.html.
platform/win/Skipped:

5:45 PM Changeset in webkit [29186] by Stephanie Lewis

2 edits in trunk/LayoutTests

Move svg/batik/text/smallFonts.svg
to skip list since it is still failing on tiger.

platform/mac-tiger/Skipped:

5:11 PM Changeset in webkit [29185] by Darin Adler

3 edits
1 copy
2 adds in trunk

WebCore:

Reviewed by Maciej and Alice.

fix <rdar://problem/4404302> Borders where there should be none (canadasmountains.com)

Test: fast/images/border.html

html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Change the code that handles cases where the border value is not a number to use the value "0" for the border width instead of not setting the border width and style at all. This matches other browsers, and makes more sense.

LayoutTests:

Reviewed by Maciej and Alice.

test for <rdar://problem/4404302> Borders where there should be none (canadasmountains.com)

fast/images/border.html: Added.
fast/images/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
fast/images/resources/border.js: Added.

4:32 PM Changeset in webkit [29184] by alice.liu@apple.com

6 edits in trunk

WebKitTools:

Reviewed by Alexey and Darin.

Adding "home" and "end" to DRT's keydown since
DOM key events can't handle keyIdentifiers at this point.

DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:]):
DumpRenderTree/win/EventSender.cpp: (keyDownCallback):

LayoutTests:

Reviewed by Alexey and Darin.

editing/selection/move-begin-end.html: add a codepath that will test the same kind of functionality for home and end keys
platform/win/Skipped: removing section of tests that have been resolved

4:28 PM Changeset in webkit [29183] by Antti Koivisto

2 edits in trunk/WebCore

Try to fix 64-bit build

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::isAvailable):

4:15 PM Changeset in webkit [29182] by Stephanie Lewis

2 edits in trunk/WebCore

Fix another stringImpl leak.

platform/text/StringImpl.cpp: remove an extra allocation (WebCore::StringImpl::StringImpl):

3:34 PM Changeset in webkit [29181] by alice.liu@apple.com

2 edits in trunk/WebCore

Reviewed by Mitz.

platform/graphics/win/FontCacheWin.cpp: fix loop condition that was causing crash

2:56 PM Changeset in webkit [29180] by oliver@apple.com

1 edit
1 move
4 adds
2 deletes in trunk/LayoutTests

Update tiger layout test results for svg/batik/text/smallFonts, and move to mac-tiger platform

RS=Adam

2:43 PM Changeset in webkit [29179] by timothy@apple.com

4 edits in trunk/WebCore

Reviewed by Adam Roben.

<rdar://problem/5671059> Always show the Timeline and Console buttons in the Inspector

page/inspector/inspector.css: Remove styles related to the toggle button and make the area always visible.
page/inspector/inspector.html: Remove the toggle button.
page/inspector/inspector.js: Remove code to toggle the status area.

2:35 PM Changeset in webkit [29178] by ap@webkit.org

4 edits in trunk

Reviewed by Adam Roben.

Restore compatibility with shipping Safari beta.

WebKit:

http://bugs.webkit.org/show_bug.cgi?id=16733
REGRESSION: Crash on Safari Start

Interfaces/IWebViewPrivate.idl: Should have added a new method at the end.

WebCore:

Temporarily restore BackwardDelete for Windows nightlies to work correctly.

editing/EditorCommand.cpp: (WebCore::CommandEntry::):

2:27 PM Changeset in webkit [29177] by ap@webkit.org

8 edits in trunk

Reviewed by Darin.

<rdar://problem/5611712> xsl:sort does not use a case folding sort, and the 'case-order' attribute is ignored (16077)

Enable the fix on Windows.

2:08 PM Changeset in webkit [29176] by Antti Koivisto

2 edits in trunk/WebCore

Fix build.

bindings/js/JSHTMLElementWrapperFactory.cpp:

1:44 PM Changeset in webkit [29175] by Antti Koivisto

8 edits in trunk/WebCore

Reviewed by Darin.

Partial fix for <rdar://problem/5647034>
Media tests crash if an old version of QuickTime is installed

Disable media support if QuickTime is not current enough (>=7.3).

Windows patch coming soon.

bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
html/HTMLElementFactory.cpp: (WebCore::audioConstructor): (WebCore::videoConstructor): (WebCore::sourceConstructor):
platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::isAvailable):
platform/graphics/MediaPlayer.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::isAvailable):

1:02 PM Changeset in webkit [29174] by timothy@apple.com

3 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5604409> JavaScript privilege escalation when Web Inspector accesses page unsafely (16011)

Check if the property is a getter before asking for the value.
If the property is a getter, we no longer show the value.

page/inspector/PropertiesSidebarPane.js:
page/inspector/inspector.css:

12:54 PM Changeset in webkit [29173] by alp@webkit.org

2 edits in trunk

2008-01-04 Alp Toker <alp@atoker.com>

Rubber-stamped by Mark Rowe.

Remove AM_MAINTAINER_MODE, as recommended by the automake manual. The
"rebuild rules" will now be enabled by default.

This obviates the need to pass '--enable-maintainer-mode' to
configure.

configure.ac:

11:31 AM Changeset in webkit [29172] by Adam Roben

3 edits
4 adds in trunk

Fix <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text

WebKit/win:

Fix <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text

Test: platform/win/editing/selection/shift-page-down-up.html

Reviewed by Oliver.

WebView.cpp: Correct the commands associated with Shift-PageUp/Shift-PageDown.

LayoutTests:

Added a test for <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text

Reviewed by Oliver.

platform/win/editing/selection/shift-page-up-down-expected.txt: Added.
platform/win/editing/selection/shift-page-up-down.html: Added.

11:25 AM Changeset in webkit [29171] by oliver@apple.com

2 edits
1 move in trunk/LayoutTests

<rdar://problem/5646437> REGRESSION (r28015): svg/batik/text/smallFonts fails

Reviewed by Darin

Regenerated expected output as filter elements are no longer generated in a default
build. This wasn't done when filters were turned off earlier due to other (now gone)
layout failures i didn't want to put in the expected output.

11:23 AM Changeset in webkit [29170] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Darin Adler.

fix synthetic bold and italic on Windows

Covered by an existing test.

platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):

9:18 AM Changeset in webkit [29169] by Adam Roben

2 edits in trunk/LayoutTests

platform/win/Skipped: Added some more failures.

6:52 AM Changeset in webkit [29168] by alp@webkit.org

4 edits in trunk

2008-01-04 Alp Toker <alp@atoker.com>

GTK+ autotools build fix. Terminate empty rules.

6:49 AM Changeset in webkit [29167] by Simon Hausmann

2 edits in trunk/WebKitTools

fix DRT after the changes to QWebPage.

The great thing is that we actually don't have
any regressions from the QWebPage change :)

Signed-off-by: Simon

6:49 AM Changeset in webkit [29166] by Simon Hausmann

10 edits in trunk

Remove most dependencies of Widget/ScrollView onto native QWidgets.

This also brings the code closer in line with the Windows code. Seems
to work nicely on first try :)

Signed-off-by: Simon

6:48 AM Changeset in webkit [29165] by Simon Hausmann

3 edits in trunk/WebKit/qt

Remove the todo from QWebPage and move the code to QWebView.

Signed-off-by: Simon

6:48 AM Changeset in webkit [29164] by Simon Hausmann

4 edits in trunk/WebKit/qt

Move the various event methods to QWebPagePrivate. This is similar to QTextControl as well.

Signed-off-by: Simon

6:48 AM Changeset in webkit [29163] by Simon Hausmann

5 edits in trunk/WebKit/qt

Forward the event from QWebView to QWebPage through QObject::event. This is similar to the way QTextControl is working.

Signed-off-by: Simon

6:47 AM Changeset in webkit [29162] by Simon Hausmann

16 edits in trunk

make QWebPage a QObject and get things to compile.

Nothing works currently though.

Signed-off-by: Simon

4:47 AM QtWebKitGitInstructions edited by bmeyer@trolltech.com

Joe Doe needs quotes otherwise the name is Joe (diff)

4:26 AM Changeset in webkit [29161] by Simon Hausmann

3 edits in trunk/WebKit/qt

Added some preliminary class documentation for QWebView, fixed a missing const() and some missing Q_PROPERTYs

Signed-off-by: Lars

4:25 AM Changeset in webkit [29160] by Simon Hausmann

3 edits in trunk/WebKit/qt

add a viewportSize to QWebPage.

This is required to eventually make it a QObject only.

Signed-off-by: Simon

4:25 AM Changeset in webkit [29159] by Simon Hausmann

5 edits in trunk

take a QString as identifier in QWebFrame::addToJSWindowObject.

Signed-off-by: Simon

4:24 AM Changeset in webkit [29158] by Simon Hausmann

2 edits in trunk/WebKit/qt

Call the frame arguments for the javascript callbacks "originatingFrame"

Signed-off-by: Lars

4:24 AM Changeset in webkit [29157] by Simon Hausmann

4 edits in trunk/WebKit/qt

Moved the QWebPage::addToHistory signal into QWebHistoryInterface

Signed-off-by: Lars

4:23 AM Changeset in webkit [29156] by Simon Hausmann

7 edits in trunk/WebKit/qt

moved title(), url(), icon() and initialLayoutComplete() from QWebPage to QWebFrame

Signed-off-by: Simon

4:19 AM Changeset in webkit [29155] by alp@webkit.org

1 edit in trunk/WebCore/ChangeLog

Fix bug URL in ChangeLog entry

4:18 AM Changeset in webkit [29154] by alp@webkit.org

2 edits in trunk/WebCore

2008-01-04 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

http://bugs.webkit.org/attachment.cgi?bugid=16667&action=enter
make -j is failing with the autotools based system

Support parallel code generation. Nearly every use of explicit
multiple targets was a potential concurrency bug, though in practice
the bison rules were the first to be noticed because they took longer
to complete and broke the build immediately.