⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 6, 2008:

10:06 PM Changeset in webkit [29217] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam.

Abstract all DateObject.set* functions in preparation for fixing:
http://bugs.webkit.org/show_bug.cgi?id=16753

SunSpider had random changes here and there but was overall a wash.

  • kjs/date_object.cpp: (KJS::fillStructuresUsingTimeArgs): (KJS::setNewValueFromTimeArgs): (KJS::setNewValueFromDateArgs): (KJS::DateProtoFuncSetMilliSeconds::callAsFunction): (KJS::DateProtoFuncSetUTCMilliseconds::callAsFunction): (KJS::DateProtoFuncSetSeconds::callAsFunction): (KJS::DateProtoFuncSetUTCSeconds::callAsFunction): (KJS::DateProtoFuncSetMinutes::callAsFunction): (KJS::DateProtoFuncSetUTCMinutes::callAsFunction): (KJS::DateProtoFuncSetHours::callAsFunction): (KJS::DateProtoFuncSetUTCHours::callAsFunction): (KJS::DateProtoFuncSetDate::callAsFunction): (KJS::DateProtoFuncSetUTCDate::callAsFunction): (KJS::DateProtoFuncSetMonth::callAsFunction): (KJS::DateProtoFuncSetUTCMonth::callAsFunction): (KJS::DateProtoFuncSetFullYear::callAsFunction): (KJS::DateProtoFuncSetUTCFullYear::callAsFunction):
2:52 PM Changeset in webkit [29216] by Nikolas Zimmermann
  • 7 edits in trunk/WebCore

Reviewed by Oliver.
Small CG paint server cleanups - use more GraphicsContext method where possible.p

2:43 PM Changeset in webkit [29215] by Nikolas Zimmermann
  • 5 edits in trunk

Reviewed by Dan.
Add new helper function isArabicChar - SVG Fonts support needs it.

2:33 PM Changeset in webkit [29214] by andrew@webkit.org
  • 3 edits
    3 adds in trunk

WebCore:

Reviewed by Darin.


DOMRange doesn't correctly re-size when inserting items (Acid3)
http://bugs.webkit.org/show_bug.cgi?id=16764


Update the offset for the range when inserting items into the range.

Test: fast/dom/Range/range-modifycontents.html

  • dom/Range.cpp: (WebCore::Range::insertNode):

LayoutTests:

Reviewed by Darin.


DOMRange doesn't correctly re-size when inserting items (Acid3)
http://bugs.webkit.org/show_bug.cgi?id=16764


Update the offset for the range when inserting items into the range.

  • fast/dom/Range/range-modifycontents-expected.txt: Added.
  • fast/dom/Range/range-modifycontents.html: Added.
  • fast/dom/Range/resources/range-modifycontents.js: Added.
2:25 PM Changeset in webkit [29213] by weinig@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add missing expected result.

  • fast/dom/TreeWalker/TreeWalker-currentNode-expected.txt: Added.
12:35 PM Changeset in webkit [29212] by eric@webkit.org
  • 3 edits
    3 adds in trunk

Reviewed by darin.

Make attr selectors case-insensitive for certain HTML attributes
http://bugs.webkit.org/show_bug.cgi?id=15470

Test: fast/css/html-attr-case-sensitivity.html

  • css/CSSStyleSelector.cpp: (WebCore::addLocalNameToSet): (WebCore::createHtmlCaseInsensitiveAttributesSet): (WebCore::htmlAttributeHasCaseInsensitiveValue): (WebCore::CSSStyleSelector::checkOneSelector):
11:35 AM Changeset in webkit [29211] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16731
Incorrect node type for whitespace when setting innerHTML in an XHTML document

Test: fast/dom/xhtml-fragment-whitespace.xhtml

  • dom/XMLTokenizer.cpp: (WebCore::parseXMLDocumentFragment): Use balancedCharactersHandler for ignorable whitespace.
11:33 AM Changeset in webkit [29210] by ap@webkit.org
  • 3 edits
    3 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16701
<rdar://problem/5666580> REGRESSION: URL-encoded space (%20) in livejournal url
causes page load error

Test: http/tests/misc/location-with-space.php

  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): Do update its URL, too.
11:10 AM Changeset in webkit [29209] by alp@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-01-06 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

Use $(EXEEXT) to account for the .exe extension in the GTK+ Windows
build. (This is already done correctly in DerivedSources.make.) Issue
noticed by Mikkel when building in Cygwin.

Add a missing slash. This was a hack from the qmake build system that
isn't necessary with autotools.

  • GNUmakefile.am:
3:35 AM Changeset in webkit [29208] by mrowe@apple.com
  • 3 edits in trunk/WebKitTools

Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.

Reviewed by Alp Toker.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(processWork): Process pending work.
(webViewLoadFinished): Schedule processing of pending work.

  • DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
3:27 AM Changeset in webkit [29207] by andrew@webkit.org
  • 3 edits
    3 adds in trunk

WebCore:

Reviewed by Darin.


DOMRange.cloneContents does not work (Acid3 bug)
http://bugs.webkit.org/show_bug.cgi?id=16748


When cloning an empty range, return an empty DocmentFragment instead of
null or undefined.

Test: fast/dom/Range/range-clone-empty.html

  • dom/Range.cpp: (WebCore::Range::processContents):

LayoutTests:

Reviewed by Darin.


DOMRange.cloneContents does not work (Acid3 bug)
http://bugs.webkit.org/show_bug.cgi?id=16748


When cloning an empty range, return an empty DocmentFragment instead of
null or undefined.

  • fast/dom/Range/range-clone-empty-expected.txt: Added.
  • fast/dom/Range/range-clone-empty.html: Added.
  • fast/dom/Range/resources/range-clone-empty.js: Added.
2:57 AM Changeset in webkit [29206] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-06 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

Remove curl handles immediately if the timer is not running.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::cancel):
12:48 AM Changeset in webkit [29205] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-06 Alp Toker <alp@atoker.com>

Reviewed by Eric.

Cairo canvas refcounting fix. Reference the surface in the constructor
to match its destruction in the destructor.

Fixes a crash triggered by leaving this page:

http://philip.html5.org/tests/canvas/misc/globalalpha-pattern.html

  • html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern):
12:13 AM Changeset in webkit [29204] by eric@webkit.org
  • 3 edits
    4 adds in trunk

Reviewed by Sam.

Fix :checked matching type='text' and add test case
http://bugs.webkit.org/show_bug.cgi?id=16750

Test: fast/dom/HTMLInputElement/checked-pseudo-selector.html

  • html/HTMLInputElement.h: isChecked() can only be true for RADIO or CHECKBOX

Jan 5, 2008:

6:36 PM Changeset in webkit [29203] by weinig@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Eric Seidel.

Patch for http://bugs.webkit.org/show_bug.cgi?id=16758
ASSERT when using TreeWalker methods for a current node outside of the root (Acid3)

  • Ensure that returned nodes are within the root node, or return 0, in adherence with the spec.

Test: fast/dom/TreeWalker/TreeWalker-currentNode.html

  • dom/TreeWalker.cpp: (WebCore::TreeWalker::parentNode): (WebCore::TreeWalker::firstChild): (WebCore::TreeWalker::lastChild): (WebCore::TreeWalker::previousSibling): (WebCore::TreeWalker::nextSibling): (WebCore::TreeWalker::previousNode): (WebCore::TreeWalker::nextNode):

LayoutTests:

Reviewed by Eric Seidel.

Test for http://bugs.webkit.org/show_bug.cgi?id=16758
ASSERT when using TreeWalker methods for a current node outside of the root (Acid3)

  • fast/dom/TreeWalker: Added.
  • fast/dom/TreeWalker/TreeWalker-currentNode.html: Added.
  • fast/dom/TreeWalker/resources: Added.
  • fast/dom/TreeWalker/resources/TreeWalker-currentNode.js: Added.
6:24 PM Changeset in webkit [29202] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Some more renaming plans.
6:16 PM Changeset in webkit [29201] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • API/JSRetainPtr.h: One more file that needed the change below.
6:14 PM Changeset in webkit [29200] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • wtf/OwnPtr.h: OwnPtr needs the same fix as RefPtr below.
6:12 PM Changeset in webkit [29199] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Build fix.

Reviewed by Maciej.

  • wtf/RetainPtr.h: Use PtrType instead of T* because of the RemovePointer magic.
2:46 PM Changeset in webkit [29198] by Darin Adler
  • 6 edits in trunk/JavaScriptCore

Rubber stamped by Maciej Stachowiak.

  • cut down own PIC branches by using a pointer-to-member-data instead of a pointer-to-member-function in WTF smart pointers
  • wtf/OwnArrayPtr.h:
  • wtf/OwnPtr.h:
  • wtf/PassRefPtr.h:
  • wtf/RefPtr.h:
  • wtf/RetainPtr.h: Use a pointer to the m_ptr member instead of the get member. The GCC compiler generates better code for this idiom.
3:44 AM Changeset in webkit [29197] by alp@webkit.org
  • 2 edits in trunk

2008-01-05 Alp Toker <alp@atoker.com>

Rubber-stamped by Mark Rowe.

Fix configure script output with correct descriptions of the default
configuration options.

2:23 AM Changeset in webkit [29196] by alp@webkit.org
  • 2 edits in trunk

2008-01-05 Sylvain Pasche <sylvain.pasche@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16736
Allow autogen.sh invocation from a separate build directory.

  • autogen.sh:
12:26 AM Changeset in webkit [29195] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-01-05 Henry Mason <hmason@mac.com>

Reviewed by Maciej Stachowiak.

http://bugs.webkit.org/show_bug.cgi?id=16738
Bug 16738: Collector block offset could be stored as an cell offset instead of a byte offset

Gives a 0.4% SunSpider boost and prettier code.

  • kjs/collector.cpp: Switched to cell offsets from byte offsets (KJS::Collector::heapAllocate): (KJS::Collector::sweep):
12:02 AM Changeset in webkit [29194] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Have the two malloc zones print useful diagnostics if their free method are unexpectedly invoked.
Due to <rdar://problem/5671357> this can happen if an application attempts to free a pointer that
was not allocated by any registered malloc zone on the system.

Reviewed by Maciej Stachowiak.

Note: See TracTimeline for information about the timeline view.