⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 9, 2008:

7:48 PM Changeset in webkit [29349] by mjs@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Sam.

  • refactor SecurityOrigin in preparation for merging with SecurityOriginData
  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::create): (WebCore::SecurityOrigin::createForFrame):
  • platform/SecurityOrigin.h:
7:03 PM Changeset in webkit [29348] by adachan@apple.com
  • 6 edits
    1 copy
    1 add in trunk

WebCore:

Tabs with ctrl, meta, or altgraph modifier key down should not advance focus.

Reviewed by Darin.

Test: fast/forms/tabs-with-modifiers.html

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): (WebCore::EventHandler::defaultTabEventHandler): bail if ctrl, meta, or altgraph key is down. Clean up the code a bit.
  • page/EventHandler.h:
  • page/FocusController.cpp: Remove the advanceFocus() that takes in a KeyboardEvent. It was only called in EventHandler::defaultTabEventHandler() but we have cleaned up the code there and no longer needs it.
  • page/FocusController.h:


LayoutTests:

Tests tabbing with different combinations of modifiers keys, where some
should advance focus and some should not.

Reviewed by Darin.

  • fast/forms/tabs-with-modifiers-expected.txt: Added.
  • fast/forms/tabs-with-modifiers.html: Copied from fast/forms/focus2.html.


6:57 PM Changeset in webkit [29347] by adachan@apple.com
  • 2 edits in trunk/WebKit/win

Fix crash that could happen if the key we are passing to the HashMap is 0 in WebView::interpretKeyEvent().

Reviewed by Darin.

  • WebView.cpp: (WebView::interpretKeyEvent):
6:51 PM Changeset in webkit [29346] by mjs@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.


  • add some more renames, adjust some
  • Scripts/do-webcore-rename:
5:41 PM Changeset in webkit [29345] by Antti Koivisto
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=16376
<rdar://problem/5665206>
<video> element fails to play frames when navigating back to page (16376)


Don't make MediaPlayer visible when it is actually in page cache.

  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer):
5:38 PM Changeset in webkit [29344] by andersca@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5532361>
CrashTracer: 9840 crashes in Safari at com.apple.JavaScriptCore: KJS::Bindings::CInstance::~CInstance [in-charge deleting] + 35


Clear the frame's plugin root objects so that they don't outlive the plugin bundle.


  • page/Frame.cpp: (WebCore::Frame::pageDestroyed):
5:37 PM Changeset in webkit [29343] by mitz@apple.com
  • 2 edits
    4 moves
    1 delete in trunk/LayoutTests

Reviewed by Darin Adler.

  • move a WebKit test which was inadvertently added to a test suite directory into a custom test directory and change it to give the same results on Windows.
  • css1/text_properties/text-transCapitalize.html: Removed.
  • fast/text/capitalize-boundaries.html: Copied from LayoutTests/css1/text_properties/text-transCapitalize.html, updated the Bugzilla URL and added @font-face rules to make Windows results match Mac OS X.
  • platform/mac/css1/text_properties/text-transCapitalize-expected.checksum: Removed.
  • platform/mac/css1/text_properties/text-transCapitalize-expected.png: Removed.
  • platform/mac/css1/text_properties/text-transCapitalize-expected.txt: Removed.
  • platform/mac/fast/text/capitalize-boundaries-expected.checksum: Copied from LayoutTests/platform/mac/css1/text_properties/text-transCapitalize-expected.checksum.
  • platform/mac/fast/text/capitalize-boundaries-expected.png: Copied from LayoutTests/platform/mac/css1/text_properties/text-transCapitalize-expected.png.
  • platform/mac/fast/text/capitalize-boundaries-expected.txt: Copied from LayoutTests/platform/mac/css1/text_properties/text-transCapitalize-expected.txt.
  • platform/qt/css1/text_properties/text-transCapitalize-expected.txt: Removed.
  • platform/win/Skipped: Removed css1/text_properties/text-transCapitalize.html.
3:02 PM Changeset in webkit [29342] by sullivan@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben and Anders Carlsson


  • fixed <rdar://problem/5469398> Repro assertion failure in context menu code due to missing-but-expected Reload item
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): use isLoadingInAPISense when deciding whether to include Stop or Reload in context menu, to match the WebKit API
12:26 PM Changeset in webkit [29341] by alp@webkit.org
  • 4 edits in trunk/WebKit/gtk

2008-01-09 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16802
[GTK] Missing gtk properties


Add missing properties to WebKitViewFrame and WebKitWebView.


  • WebView/webkitprivate.h: add some useful defines for param specs
  • WebView/webkitwebframe.cpp: (webkit_web_frame_get_property): added (webkit_web_frame_class_init): add name, title and uri read-only properties
  • WebView/webkitwebview.cpp: (webkit_web_view_get_property): add editable property read (webkit_web_view_set_property): added for editable property write (webkit_web_view_class_init): add read-write editable property
12:13 PM Changeset in webkit [29340] by ap@webkit.org
  • 3 edits in trunk/LayoutTests

Reviewed by Adam Roben.

<rdar://problem/5673716> fast/loader/opaque-base-url.html is failing
<rdar://problem/5670275> fast/loader/onunload-form-submit-crash.html is failing
<rdar://problem/5667277> fast/loader/onunload-form-submit-crash-2.html is failing

  • fast/loader/meta-refresh-vs-open.html: Changed to be more DRT-friendly.
  • platform/win/Skipped: Removed tests that were victims of the above.
12:10 PM Changeset in webkit [29339] by ap@webkit.org
  • 4 edits in trunk/LayoutTests

Reviewed by Adam Roben.

Fix fast/encoding/frame-default-enc.html, which is failing on buildbot.

Internal frame names for this test are changing for no apparent reason (see r25269).
Make the test independent of the names.

  • fast/encoding/frame-default-enc-expected.txt:
  • fast/encoding/frame-default-enc.html:
  • fast/encoding/resources/frame-default-enc-frame.html:
10:03 AM Changeset in webkit [29338] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix Windows debug build for opensource developers.

  • WebCore.vcproj/QTMovieWin.vcproj: Use the correct library suffix.
10:01 AM Changeset in webkit [29337] by Adam Roben
  • 6 edits in trunk/LayoutTests

Update some test results

Reviewed by Anders.

  • fast/dom/Window/window-properties-expected.txt: Updated after r29328.
  • platform/win/media/audio-controls-rendering-expected.txt: Regenerated results with the correct fonts.
  • platform/win/media/video-aspect-ratio-expected.txt: Ditto.
  • platform/win/media/video-controls-rendering-expected.txt: Ditto.
  • platform/win/media/video-transformed-expected.txt: Ditto.
8:32 AM ApplicationsGtk edited by alp@atoker.com
Add a mail client (diff)
1:23 AM Changeset in webkit [29336] by eric@webkit.org
  • 8 edits
    16 adds in trunk

Reworked by Eric, Reviewed by Hyatt.

Tests: fast/selectors/lang-inheritance.html

fast/selectors/lang-inheritance2.html
fast/selectors/lang-vs-xml-lang.html
fast/selectors/lang-vs-xml-lang-xhtml.xhtml

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Do not share style between elements with different LANG-attribute. (WebCore::CSSStyleSelector::checkOneSelector): Change :lang() to recursively check the LANG attribute for all the elements parents and the content-language of the document.
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Parse MIME Content-Language
  • dom/Document.h: (WebCore::Document::contentLanguage): (WebCore::Document::setContentLanguage):

Jan 8, 2008:

8:49 PM Changeset in webkit [29335] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Bug 16678: Unreproducible crash in KJS::JSObject::inherits() after using Web Inspector
​http://bugs.webkit.org/show_bug.cgi?id=16678

Add a NULL check for controller before calling JSObjectSetPrivate.

  • page/InspectorController.cpp: (WebCore::InspectorController::~InspectorController):
8:45 PM Changeset in webkit [29334] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-08 Xan Lopez <​xan@gnome.org>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=15610
[GTK] Text rendering using Pango

Use Pango to render Complex path text.

  • platform/graphics/gtk/FontGtk.cpp: (WebCore::utf16_to_utf8): (WebCore::convertUniCharToUTF8): (WebCore::setPangoAttributes): (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
8:35 PM Changeset in webkit [29333] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5665860> With the web inspector displayed, a crash occurs
at WebCore::Frame::document() when navigating back to previous page

This fixes the crash, but the inspector was totally broken with back/forward.
So this also fixes back/forward navigation so the right main resource shows
up in the inspector.

  • page/InspectorController.cpp: (WebCore::addSourceToFrame): Add some null checks for the frame when getting the textEncoding. This was the crash. (WebCore::InspectorController::addScriptResource): Create a script object only if needed, and always add it by calling addResource. (WebCore::InspectorController::didCommitLoad): Check if the loader is loading from the page cache, and clear m_mainResource. If the load is normal, then call addAndUpdateScriptResource with the main resource. (WebCore::InspectorController::identifierForInitialRequest): If the load is from the page cache and the resource is the main resource call addAndUpdateScriptResource since didCommitLoad did not do it.
8:15 PM Changeset in webkit [29332] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-08 Alp Toker <​alp@atoker.com>

Back out VIDEO by default in the GTK+ qmake build. The build bot
doesn't have the necessary libraries installed.

  • WebCore.pro:
7:41 PM Changeset in webkit [29331] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-08 Alp Toker <​alp@atoker.com>

Win build fix for breakage introduced in r29328.

  • WebCore.vcproj/WebCore.vcproj:
7:37 PM Changeset in webkit [29330] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-08 Alp Toker <​alp@atoker.com>

Rubber-stamped by Mark Rowe.

Enable VIDEO by default in the GTK+ qmake build.

  • WebCore.pro:
7:13 PM Changeset in webkit [29329] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-01-08 Alp Toker <​alp@atoker.com>

GTK+ VIDEO build fix for breakage introduced in r29328.

Issue noticed by Ori_B.

  • GNUmakefile.am:
  • WebCore.pro:
5:41 PM Changeset in webkit [29328] by Antti Koivisto
  • 5 edits
    2 moves
    2 adds in trunk

WebCore:

Reviewed by Darin.


HTMLAudioElement needs generated constructor. Otherwise video instanceof HTMLAudioElement is true which is
bit strange.


Renamed custom constructor JSHTMLAudioElementConstructor to JSAudioConstructor to avoid name clashes.

Test: media/constructors.html

  • ChangeLog:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAudioConstructor.cpp: Copied from WebCore/bindings/js/JSHTMLAudioElementConstructor.cpp. (WebCore::JSAudioConstructor::JSAudioConstructor): (WebCore::JSAudioConstructor::implementsConstruct): (WebCore::JSAudioConstructor::construct):
  • bindings/js/JSAudioConstructor.h: Copied from WebCore/bindings/js/JSHTMLAudioElementConstructor.h.
  • bindings/js/JSHTMLAudioElementConstructor.cpp: Removed.
  • bindings/js/JSHTMLAudioElementConstructor.h: Removed.
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • html/HTMLAudioElement.idl:

LayoutTests:

Reviewed by Darin.


Test that media element constructors behave consistently.

  • media/constructors-expected.txt: Added.
  • media/constructors.html: Added.
4:45 PM Changeset in webkit [29327] by andersca@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

Don't add the applet widget to the view, that's done later by RenderApplet.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createJavaAppletWidget):
4:35 PM Changeset in webkit [29326] by Adam Roben
  • 1 edit
    1 move in trunk/LayoutTests
  • fast/replaced/image-map.html: Disabled this until bug 16782 is fixed.
4:35 PM Changeset in webkit [29325] by Adam Roben
  • 3 edits
    1 delete in trunk

Fix fast/dom/Window/window-properties.html on Windows

WebCore:

  • bindings/scripts/CodeGeneratorJS.pm: Touch this so the bindings will rebuild on Windows now that the media elements are enabled.

LayoutTests:

Fix fast/dom/Window/window-properties.html on Windows

Windows now has the same results as other platforms.

  • platform/win/fast/dom/Window/window-properties-expected.txt: Removed.
4:17 PM Changeset in webkit [29324] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • remove a test from the skipped list
  • platform/win/Skipped:
4:12 PM Changeset in webkit [29323] by Antti Koivisto
  • 5 edits in trunk

WebCore:

Reviewed by Weinig.


Add security check for Audio constructor.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):

LayoutTests:

Reviewed by Weinig.


Test cross-frame access to media properties.

  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-get.html:
3:51 PM Changeset in webkit [29322] by timothy@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Adam Roben.

<rdar://problem/5676515> List of scripts and images missing when opening Web Inspector from new window (16567)

InspectorController::didLoadResourceFromMemoryCache was not being called for
resources that loaded from the memory cache that the FrameLoader's client
has already been notified about. This fix always calls the InspectorController
when loading a memory cached resource. No test possible for the Web Inspector.

  • loader/DocLoader.cpp: (WebCore::DocLoader::checkCacheObjectStatus): Moved most of the logic to FrameLoader::loadedResourceFromMemoryCache so the InspectorController can always be notified.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didTellClientAboutLoad): Renamed from didTellBridgeAboutLoad. (WebCore::FrameLoader::haveToldClientAboutLoad): Renamed from haveToldBridgeAboutLoad. (WebCore::FrameLoader::loadResourceSynchronously): Call the renamed didTellClientAboutLoad. (WebCore::FrameLoader::loadedResourceFromMemoryCache): Only takes a CachedResource now. Always call InspectorController. If the resource's sendResourceLoadCallbacks is false or didTellClientAboutLoad is true, do an early return. Otherwise call the client and call didTellClientAboutLoad. (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Removed, work now done in FrameLoader::loadedResourceFromMemoryCache.
  • loader/FrameLoader.h: Renamed {didTell,haveTold}BridgeAboutLoad to {didTell,haveTold}ClientAboutLoad. Made loadedResourceFromMemoryCache only take a CachedResource. Renamed m_urlsBridgeKnowsAbout to m_urlsClientKnowsAbout.
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::load): Call the renamed didTellClientAboutLoad.
2:11 PM Changeset in webkit [29321] by Antti Koivisto
  • 2 edits
    5 adds in trunk/LayoutTests

Rubber stamped by Darin.


Enable media tests on Windows.

1:47 PM Changeset in webkit [29320] by mitz@apple.com
  • 5 edits in trunk/WebCore

Rubber-stamped by Sam Weinig.

  • prefix all member variables in CSSStyleSelector with m_
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::setEncodedURL): (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::matchRules): (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::initElementAndPseudoState): (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::locateSharedStyle): (WebCore::CSSStyleSelector::matchUARules): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::updateFont): (WebCore::CSSStyleSelector::cacheBorderAndBackground): (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::checkOneSelector): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundImage): (WebCore::CSSStyleSelector::mapBackgroundSize): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition): (WebCore::CSSStyleSelector::checkForTextSizeAdjust): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
  • css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::): (WebCore::CSSRuleData::CSSRuleData): (WebCore::CSSRuleDataList::CSSRuleDataList): (WebCore::CSSRuleDataList::append):
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • rendering/RenderStyle.cpp: (WebCore::RenderStyle::isStyleAvailable):
1:43 PM Changeset in webkit [29319] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Removed unnecessary files from Copy Bundle Resources build phase.

Reviewed by Sam.

  • WebCore.xcodeproj/project.pbxproj: Files removed from build phase: DOMCoreException.idl EventException.idl MessageEvent.idl SVGAElement.idl SVGAngle.idl SVGAnimateColorElement.idl SVGAnimateElement.idl SVGAnimateTransformElement.idl SVGAnimatedAngle.idl SVGAnimatedBoolean.idl SVGAnimatedEnumeration.idl SVGAnimatedInteger.idl SVGAnimatedLength.idl SVGAnimatedLengthList.idl SVGAnimatedNumber.idl SVGAnimatedNumberList.idl SVGAnimatedPathData.idl SVGAnimatedPoints.idl SVGAnimatedPreserveAspectRatio.idl SVGAnimatedRect.idl SVGAnimatedString.idl SVGAnimatedTransformList.idl SVGAnimationElement.idl SVGCSSPropertyNames.in SVGCSSValueKeywords.in SVGCircleElement.idl SVGClipPathElement.idl SVGColor.idl SVGComponentTransferFunctionElement.idl SVGCursorElement.idl SVGDefinitionSrcElement.idl SVGDefsElement.idl SVGDescElement.idl SVGDocument.idl SVGElement.idl SVGElementInstance.idl SVGElementInstanceList.idl SVGEllipseElement.idl SVGException.idl SVGExternalResourcesRequired.idl SVGFEBlendElement.idl SVGFEColorMatrixElement.idl SVGFEComponentTransferElement.idl SVGFECompositeElement.idl SVGFEDiffuseLightingElement.idl SVGFEDisplacementMapElement.idl SVGFEDistantLightElement.idl SVGFEFloodElement.idl SVGFEFuncAElement.idl SVGFEFuncBElement.idl SVGFEFuncGElement.idl SVGFEFuncRElement.idl SVGFEGaussianBlurElement.idl SVGFEImageElement.idl SVGFEMergeElement.idl SVGFEMergeNodeElement.idl SVGFEOffsetElement.idl SVGFEPointLightElement.idl SVGFESpecularLightingElement.idl SVGFESpotLightElement.idl SVGFETileElement.idl SVGFETurbulenceElement.idl SVGFilterElement.idl SVGFilterPrimitiveStandardAttributes.idl SVGFitToViewBox.idl SVGFontElement.idl SVGFontFaceElement.idl SVGFontFaceFormatElement.idl SVGFontFaceNameElement.idl SVGFontFaceSrcElement.idl SVGFontFaceUriElement.idl SVGForeignObjectElement.idl SVGGElement.idl SVGGlyphElement.idl SVGGradientElement.idl SVGImageElement.idl SVGLangSpace.idl SVGLength.idl SVGLengthList.idl SVGLineElement.idl SVGLinearGradientElement.idl SVGLocatable.idl SVGMarkerElement.idl SVGMaskElement.idl SVGMatrix.idl SVGMetadataElement.idl SVGMissingGlyphElement.idl SVGNumber.idl SVGNumberList.idl SVGPaint.idl SVGPathElement.idl SVGPathSeg.idl SVGPathSegArcAbs.idl SVGPathSegArcRel.idl SVGPathSegClosePath.idl SVGPathSegCurvetoCubicAbs.idl SVGPathSegCurvetoCubicRel.idl SVGPathSegCurvetoCubicSmoothAbs.idl SVGPathSegCurvetoCubicSmoothRel.idl SVGPathSegCurvetoQuadraticAbs.idl SVGPathSegCurvetoQuadraticRel.idl SVGPathSegCurvetoQuadraticSmoothAbs.idl SVGPathSegCurvetoQuadraticSmoothRel.idl SVGPathSegLinetoAbs.idl SVGPathSegLinetoHorizontalAbs.idl SVGPathSegLinetoHorizontalRel.idl SVGPathSegLinetoRel.idl SVGPathSegLinetoVerticalAbs.idl SVGPathSegLinetoVerticalRel.idl SVGPathSegList.idl SVGPathSegMovetoAbs.idl SVGPathSegMovetoRel.idl SVGPatternElement.idl SVGPoint.idl SVGPointList.idl SVGPolygonElement.idl SVGPolylineElement.idl SVGPreserveAspectRatio.idl SVGRadialGradientElement.idl SVGRect.idl SVGRectElement.idl SVGRenderingIntent.idl SVGSVGElement.idl SVGScriptElement.idl SVGSetElement.idl SVGStopElement.idl SVGStringList.idl SVGStylable.idl SVGStyleElement.idl SVGSwitchElement.idl SVGSymbolElement.idl SVGTRefElement.idl SVGTSpanElement.idl SVGTests.idl SVGTextContentElement.idl SVGTextElement.idl SVGTextPathElement.idl SVGTextPositioningElement.idl SVGTitleElement.idl SVGTransform.idl SVGTransformList.idl SVGTransformable.idl SVGURIReference.idl SVGUnitTypes.idl SVGUseElement.idl SVGViewElement.idl SVGViewSpec.idl SVGZoomAndPan.idl SVGZoomEvent.idl XMLHttpRequestException.idl XPathException.idl character-sets.txt mac-encodings.txt make-charset-table.pl svgattrs.in svgtags.in xlinkattrs.in
1:34 PM Changeset in webkit [29318] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-08 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

Support copying the selected URL to the clipboard.

  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeURL): implemented
1:27 PM Changeset in webkit [29317] by ddkilzer@apple.com
  • 6 edits in trunk/WebCore

Renamed CharacterData::m_str to m_data

Rubber-stamped by Adam again.

No test cases added since there is no change in behavior.

  • dom/CDATASection.cpp:
  • dom/CharacterData.cpp: (WebCore::CharacterData::CharacterData): (WebCore::CharacterData::setData): (WebCore::CharacterData::substringData): (WebCore::CharacterData::appendData): (WebCore::CharacterData::insertData): (WebCore::CharacterData::deleteData): (WebCore::CharacterData::replaceData): (WebCore::CharacterData::nodeValue): (WebCore::CharacterData::containsOnlyWhitespace): (WebCore::CharacterData::dispatchModifiedEvent): (WebCore::CharacterData::checkCharDataOperation): (WebCore::CharacterData::dump):
  • dom/CharacterData.h:
  • dom/Comment.cpp:
  • dom/Text.cpp: (WebCore::Text::splitText): (WebCore::Text::createRenderer): (WebCore::Text::recalcStyle):
12:52 PM Changeset in webkit [29316] by sfalken@apple.com
  • 3 edits in trunk/WebCore

Fix a couple of compiler warnings.


Reviewed by Mitz.

  • platform/win/ThreadingWin.cpp:
  • platform/win/UniscribeController.cpp: Remove unused function. (WebCore::UniscribeController::advance): Fix bogus warning about un-initialized variable.
12:50 PM Changeset in webkit [29315] by adele@apple.com
  • 5 edits in trunk

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5674667> fast/forms/slider-mouse-events.html is broken by media control checkin 29257

  • rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): After fixing a bug in EventHandler to make sure events always go to the capturing node, this bug was exposed. MouseMove and MouseUp events were going to the thumb element, but not to the slider input element. This change makes the input element the capturing node, and then the input element forwards the mouse events to the thumb element. I also added a missing call to setDefaultHandled for the mousemove event.

LayoutTests:

Reviewed by Darin.

Updated test for:
<rdar://problem/5674667> fast/forms/slider-mouse-events.html is broken by media control checkin 29257

  • fast/forms/slider-mouse-events-expected.txt:
  • fast/forms/slider-mouse-events.html: Now tests mousemove events too.
12:27 PM Changeset in webkit [29314] by adele@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam.

  • rendering/RenderThemeSafari.cpp: Use the SafariTheme version number to decide whether or not to paint the media controls in RenderThemeSafari.
12:25 PM Changeset in webkit [29313] by oliver@apple.com
  • 2 edits in trunk/WebCore

Fix <rdar://problem/5652740> Crash occurs at WebCore::Widget::getView() after dragging file into window that contains web page ( ​http://www.econocraft.com/flood_arch.htm )

Reviewed by Adele and John.

We hit this crash if the page reloads between DragController::dragUpdated
and DragController::performDrag, meaning that m_document starts pointing to
a now viewless document. This is picked up by an assertion in performDrag
which I have now replaced with an assignment given that the assertion is
invalid -- it is possible for m_document to be changed between dragUpdated
performDrag

11:55 AM Changeset in webkit [29312] by ap@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fixing spaces in ChangeLog.

11:52 AM Changeset in webkit [29311] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

<rdar://problem/5659812> CrashTracer: 462 crashes in Safari at com.apple.WebCore:
WebCore::Node::setChanged + 96

Test: fast/dom/cssTarget-crash.html

  • dom/Node.cpp: (WebCore::Node::removedFromDocument): Check to see if the node being removed is currently set as the Document's cssTarget.

Ê Ê Ê Ê If it is, clear the cssTarget to prevent a hanging reference to it.

11:42 AM Changeset in webkit [29310] by Adam Roben
  • 2 edits in trunk/WebCore
  • svg/svgtags.in: Touch this again for the sake of the Windows bots.
11:40 AM Changeset in webkit [29309] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Use JSRetainPtr in the Web Inspector everywhere we own a JSStringRef.
Also added some #pragma marks to help find places in the file.

  • page/InspectorController.cpp: (WebCore::callSimpleFunction): Use JSRetainPtr<JSStringRef>. And return the result of JSObjectCallAsFunction. (WebCore::search): Use JSRetainPtr<JSStringRef>. (WebCore::databaseTableNames): Ditto. (WebCore::localizedStrings): Ditto. (WebCore::InspectorController::~InspectorController): Ditto. (WebCore::InspectorController::focusNode): Ditto. (WebCore::InspectorController::windowScriptObjectAvailable): Ditto. (WebCore::InspectorController::scriptObjectReady): Ditto. (WebCore::addHeaders): Ditto. (WebCore::InspectorController::addScriptResource): Ditto. (WebCore::InspectorController::removeScriptResource): Ditto. (WebCore::InspectorController::updateScriptResourceRequest): Ditto. (WebCore::InspectorController::updateScriptResourceResponse): Ditto. (WebCore::InspectorController::updateScriptResource): Ditto. (WebCore::InspectorController::addDatabaseScriptResource): Ditto. (WebCore::InspectorController::removeDatabaseScriptResource): Ditto. (WebCore::InspectorController::addScriptConsoleMessage): Ditto.
11:14 AM Changeset in webkit [29308] by mitz@apple.com
  • 9 edits
    2 moves in trunk/WebCore

Rubber-stamped by Sam Weinig.

  • rename FontDataBaseClass.{cpp,h} back to FontData.{cpp,h}
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • editing/Editor.cpp:
  • platform/graphics/FontData.cpp: Copied from WebCore/platform/graphics/FontDataBaseClass.cpp.
  • platform/graphics/FontData.h: Copied from WebCore/platform/graphics/FontDataBaseClass.h.
  • platform/graphics/FontDataBaseClass.cpp: Removed.
  • platform/graphics/FontDataBaseClass.h: Removed.
  • platform/graphics/SegmentedFontData.h:
  • platform/graphics/SimpleFontData.h:
10:51 AM Changeset in webkit [29307] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Fix build.

  • DOMCoreClasses.cpp:
10:32 AM Changeset in webkit [29306] by andersca@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Mitz.

<rdar://problem/5667286>
plugins/createScriptableObject-before-start.html is failing due to denied cross-frame access


Use our own test plug-in instead of the Flash plug-in. The Flash plug-in tries to get the URL of the top frame
which will cause a security exception.


  • platform/win/Skipped:
  • plugins/createScriptableObject-before-start.html:
9:56 AM Changeset in webkit [29305] by mitz@apple.com
  • 2 edits in trunk/WebCore

Fix a Wx build error.

  • platform/graphics/wx/GlyphMapWx.cpp: (WebCore::GlyphPage::fill):
9:48 AM Changeset in webkit [29304] by mitz@apple.com
  • 2 edits in trunk/WebCore

Fix a Qt build error.

  • platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::fontDataForCharacter): (WebCore::SimpleFontData::isSegmented):
9:43 AM Changeset in webkit [29303] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix.

Touch config.h to force a rebuild (apparently changing preprocessor
definitions in the .vcproj doesn't force a rebuild).

  • config.h:
9:31 AM Changeset in webkit [29302] by mitz@apple.com
  • 2 edits in trunk/WebCore

Fix a Wx build failure.

  • webcore-wx.bkl:
9:27 AM Changeset in webkit [29301] by mitz@apple.com
  • 2 edits in trunk/WebCore

Fix a Qt build failure.

  • WebCore.pro:
9:21 AM Changeset in webkit [29300] by sullivan@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben


  • fixed <rdar://problem/5671668> REGRESSION (r28711-r28730): With caret in an empty form field, Delete menu item is enabled but shouldn't be

The enabled logic was incorrect for the Delete menu item. To fix this, I added an EditorCommandSource
parameter to the enabled functions so that they can have parallel logic to the execute functions.

  • editing/EditorCommand.cpp: added EditorCommandSource parameter to isEnabled function prototype (WebCore::enabled): added unused EditorCommandSource parameter to these isEnabled functions: (WebCore::enabledAnySelection): (WebCore::enabledAnySelectionAndMark): (WebCore::enableCaretInEditableText): (WebCore::enabledCopy): (WebCore::enabledCut):

(WebCore::enabledDelete):
new function, uses logic previously used by Delete command for DOM sources; uses logic in enabledCut
for menu source

added unused EditorCommandSource parameter to these isEnabled functions:
(WebCore::enabledInEditableText):
(WebCore::enabledInRichlyEditableText):
(WebCore::enabledPaste):
(WebCore::enabledRangeInEditableText):
(WebCore::enabledRangeInRichlyEditableText):
(WebCore::enabledRedo):
(WebCore::enabledUndo):


(WebCore::CommandEntry::):
wire up new enabledDelete function as delete function for Delete command


(WebCore::Editor::Command::isEnabled):
pass EditorCommandSource parameter to isEnabled function

9:10 AM Changeset in webkit [29299] by Adam Roben
  • 2 edits in trunk/WebCore

Visual C++ Express build fix

  • WebCore.vcproj/QTMovieWin.vcproj: Explicitly link against user32.lib and advapi32.lib. VS implicitly links against these, VC++ Express doesn't.
8:45 AM Changeset in webkit [29298] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • add bug number
  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData):
7:34 AM Changeset in webkit [29297] by mitz@apple.com
  • 2 edits in trunk/WebCore

Try to fix the Qt build.

  • WebCore.pro:
7:07 AM Changeset in webkit [29296] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Not reviewed. Try to fix Qt builds after Timothy's inspector changes.

5:31 AM Changeset in webkit [29295] by mjs@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Mark.

  • remove duplicate definition of getElementById from HTMLDocument IDL (and ObjC bindings)
  • bindings/objc/PublicDOMInterfaces.h:
  • html/HTMLDocument.idl:
5:02 AM Changeset in webkit [29294] by ddkilzer@apple.com
  • 6 edits in trunk/WebCore

Renamed CharacterData::str to m_str to match coding style

Rubber-stamped by Adam.

No test cases added since there is no change in behavior.

  • dom/CDATASection.cpp:
  • dom/CharacterData.cpp: (WebCore::CharacterData::CharacterData): (WebCore::CharacterData::setData): (WebCore::CharacterData::substringData): (WebCore::CharacterData::appendData): (WebCore::CharacterData::insertData): (WebCore::CharacterData::deleteData): (WebCore::CharacterData::replaceData): (WebCore::CharacterData::nodeValue): (WebCore::CharacterData::containsOnlyWhitespace): (WebCore::CharacterData::dispatchModifiedEvent): (WebCore::CharacterData::checkCharDataOperation): (WebCore::CharacterData::dump):
  • dom/CharacterData.h:
  • dom/Comment.cpp:
  • dom/Text.cpp: (WebCore::Text::splitText): (WebCore::Text::createRenderer): (WebCore::Text::recalcStyle):
3:33 AM Changeset in webkit [29293] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Turn testIsInteger assertions into compile-time asserts and move them into HashTraits.h where possible.

Reviewed by Maciej Stachowiak.

  • kjs/testkjs.cpp:
  • wtf/HashTraits.h:
1:25 AM Changeset in webkit [29292] by oliver@apple.com
  • 2 edits in trunk/WebCore

Set the ENABLE_SVG_FONTS flag in Windows build, now builds.

I'm not sure if it just caused the right files to regenerate,
or if there's some configuration weirdness in the non-SVG-fonts
build.

1:11 AM Changeset in webkit [29291] by mjs@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Brady.

  • fixed <rdar://problem/5644300> Back/Forward Cache should not include pages with databases


Track whether a document has ever opened a database; if so, exclude it from b/f caching (for now)


  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h: (WebCore::Document::setHasOpenDatabases): (WebCore::Document::hasOpenDatabases):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePage):
  • storage/Database.cpp: (WebCore::Database::openDatabase):
12:04 AM Changeset in webkit [29290] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

  • fix leaks seen on the build bot
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Avoid creating a CSSFontFaceSource for SVG font-face elements going into an SVGCSSFontFace because it just leaks them. Avoid adding SVG font- face elements to a CSSFontFace because it will not work as expected.
Note: See TracTimeline for information about the timeline view.