⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 10, 2008:

11:50 PM Changeset in webkit [29393] by mjs@apple.com
  • 3 edits in trunk/WebKit/win

Not reviewed, build fix.


  • more build fixing
  • WebDatabaseManager.cpp:
  • WebSecurityOrigin.h:
11:30 PM Changeset in webkit [29392] by mjs@apple.com
  • 3 edits in trunk/WebKit/win

Not reviewed, build fix.


  • try to fix build
  • WebDatabaseManager.cpp: (WebDatabaseManager::databasesWithOrigin):
  • WebSecurityOrigin.h:
9:29 PM Changeset in webkit [29391] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build fix. Don't build dftables any longer since it's now a Perl script.

9:12 PM Changeset in webkit [29390] by eric@webkit.org
  • 1 edit in trunk/WebCore/css/CSSGrammar.y

Add FIXME for replacing YYPARSE_PARAM with %parse-param to CSSGrammar.y

8:42 PM Changeset in webkit [29389] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Adele.

No functional changes, only code cleanup.

  • css/MediaQueryEvaluator.cpp: (WebCore::compareValue): renamed from cmpvalue (WebCore::colorMediaFeatureEval): (WebCore::device_aspect_ratioMediaFeatureEval): (WebCore::device_pixel_ratioMediaFeatureEval): (WebCore::gridMediaFeatureEval): (WebCore::device_heightMediaFeatureEval): (WebCore::device_widthMediaFeatureEval): (WebCore::heightMediaFeatureEval): (WebCore::widthMediaFeatureEval):
8:19 PM Changeset in webkit [29388] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • fix a crash when calling alert() from a repeating timer

On non-Mac platforms, the PageGroupLoadDeferrer pauses DOM timers during
alert() and other similar functions, which deletes the actual
DOMWindowTimer objects and replaces them with new objects when resuming.

  • bindings/js/kjs_window.cpp: (KJS::Window::timerFired): Re-fetch the timer object from the map in case it has been deleted or replaced.
7:51 PM Changeset in webkit [29387] by mjs@apple.com
  • 2 edits in trunk/WebKit/mac

Not reviewed. Build fix.


  • Attempt to fix mac build.
  • Storage/WebDatabaseManager.mm:
7:36 PM Changeset in webkit [29386] by mjs@apple.com
  • 45 edits
    2 deletes in trunk

WebCore:

Reviewed by Sam.

  • remove SecurityOriginData and fold its functionality into SecurityOrigin
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
  • dom/Document.cpp: (WebCore::Document::domain):
  • page/Chrome.cpp: (WebCore::Chrome::requestQuotaIncreaseForNewDatabase): (WebCore::Chrome::requestQuotaIncreaseForDatabaseOperation):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::copy): (WebCore::SecurityOrigin::createFromIdentifier): (WebCore::SecurityOrigin::stringIdentifier):
  • platform/SecurityOrigin.h: (WebCore::SecurityOrigin::host): (WebCore::SecurityOrigin::protocol): (WebCore::SecurityOrigin::port): (WebCore::SecurityOrigin::equal):
  • platform/SecurityOriginData.cpp: Removed.
  • platform/SecurityOriginData.h: Removed.
  • storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::securityOriginCopy):
  • storage/Database.h:
  • storage/DatabaseTracker.cpp: (WebCore::SecurityOriginHash::hash): (WebCore::SecurityOriginHash::equal): (WebCore::SecurityOriginTraits::deletedValue): (WebCore::SecurityOriginTraits::emptyValue): (WebCore::DatabaseTracker::canEstablishDatabase): (WebCore::DatabaseTracker::hasEntryForOrigin): (WebCore::DatabaseTracker::hasEntryForDatabase): (WebCore::DatabaseTracker::establishEntryForOrigin): (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::detailsForNameAndOrigin): (WebCore::DatabaseTracker::setDatabaseDetails): (WebCore::DatabaseTracker::usageForDatabase): (WebCore::DatabaseTracker::usageForOrigin): (WebCore::DatabaseTracker::quotaForOrigin): (WebCore::DatabaseTracker::setQuota): (WebCore::DatabaseTracker::addDatabase): (WebCore::DatabaseTracker::deleteAllDatabases): (WebCore::DatabaseTracker::deleteDatabasesWithOrigin): (WebCore::DatabaseTracker::deleteDatabase): (WebCore::DatabaseTracker::deleteDatabaseFile): (WebCore::notificationQueue): (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged): (WebCore::DatabaseTracker::notifyDatabasesChanged):
  • storage/DatabaseTracker.h:
  • storage/DatabaseTrackerClient.h:
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::openTransactionAndPreflight): (WebCore::SQLTransaction::runStatements): (WebCore::SQLTransaction::deliverQuotaIncreaseCallback): (WebCore::SQLTransaction::postflightAndCommit): (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
  • svg/graphics/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::requestQuotaIncreaseForNewDatabase): (WebCore::SVGEmptyChromeClient::requestQuotaIncreaseForDatabaseOperation):

WebKit/gtk:

Reviewed by Sam.

  • remove SecurityOriginData and fold its functionality into SecurityOrigin
  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::requestQuotaIncreaseForNewDatabase): (WebKit::ChromeClient::requestQuotaIncreaseForDatabaseOperation):
  • WebCoreSupport/ChromeClientGtk.h:

WebKit/mac:

Reviewed by Sam.

  • remove SecurityOriginData and fold its functionality into SecurityOrigin
  • Storage/WebDatabaseManager.mm: (-[WebDatabaseManager origins]): (-[WebDatabaseManager databasesWithOrigin:]): (-[WebDatabaseManager detailsForDatabase:withOrigin:]): (-[WebDatabaseManager deleteDatabasesWithOrigin:]): (-[WebDatabaseManager deleteDatabase:withOrigin:]):
  • Storage/WebDatabaseTrackerClient.h:
  • Storage/WebDatabaseTrackerClient.mm: (WebDatabaseTrackerClient::dispatchDidModifyOrigin): (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
  • Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin initWithProtocol:domain:port:]): (-[WebSecurityOrigin protocol]): (-[WebSecurityOrigin domain]): (-[WebSecurityOrigin port]): (-[WebSecurityOrigin usage]): (-[WebSecurityOrigin quota]): (-[WebSecurityOrigin setQuota:]): (-[WebSecurityOrigin isEqual:]): (-[WebSecurityOrigin dealloc]): (-[WebSecurityOrigin finalize]): (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]): (-[WebSecurityOrigin _core]):
  • Storage/WebSecurityOriginInternal.h:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):

WebKit/qt:

Reviewed by Sam.

  • remove SecurityOriginData and fold its functionality into SecurityOrigin
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::requestQuotaIncreaseForNewDatabase): (WebCore::ChromeClientQt::requestQuotaIncreaseForDatabaseOperation):
  • WebCoreSupport/ChromeClientQt.h:

WebKit/win:

Reviewed by Sam.

  • remove SecurityOriginData and fold its functionality into SecurityOrigin
  • WebChromeClient.cpp: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
  • WebChromeClient.h:
  • WebDatabaseManager.cpp: (WebDatabaseManager::origins): (WebDatabaseManager::databasesWithOrigin): (WebDatabaseManager::detailsForDatabaseWithOrigin): (WebDatabaseManager::deleteDatabasesWithOrigin): (WebDatabaseManager::deleteDatabaseWithOrigin): (WebDatabaseManager::dispatchDidModifyOrigin): (WebDatabaseManager::dispatchDidModifyDatabase):
  • WebDatabaseManager.h:
  • WebSecurityOrigin.cpp: (WebSecurityOrigin::createInstance): (WebSecurityOrigin::WebSecurityOrigin): (WebSecurityOrigin::protocol): (WebSecurityOrigin::domain): (WebSecurityOrigin::port): (WebSecurityOrigin::usage): (WebSecurityOrigin::quota): (WebSecurityOrigin::setQuota):
  • WebSecurityOrigin.h:

WebKit/wx:

Reviewed by Sam.

  • remove SecurityOriginData and fold its functionality into SecurityOrigin
  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::requestQuotaIncreaseForNewDatabase): (WebCore::ChromeClientWx::requestQuotaIncreaseForDatabaseOperation):
  • WebKitSupport/ChromeClientWx.h:
6:48 PM Changeset in webkit [29385] by Stephanie Lewis
  • 3 edits in trunk/LayoutTests

2008-01-10 Stephanie <Stephanie Lewis>

RS=Oliver.

Move svg/batik/text/smallfonts.svg to the right skip list.

  • platform/mac-tiger/Skipped:
  • platform/mac/Skipped:
6:09 PM Changeset in webkit [29384] by andersca@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam.

Use the correct frame loader load method. Using the old method would not cause a
new window to be open if the frame navigation was not allowed.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
4:55 PM Changeset in webkit [29383] by alp@webkit.org
  • 4 edits in trunk

2008-01-10 Alp Toker <​alp@atoker.com>

SVG font build fix for GTK+/autotools.

4:41 PM Changeset in webkit [29382] by ddkilzer@apple.com
  • 1 edit in trunk/JavaScriptCore/pcre/dftables

BUILD FIX: Make dftables executable.

4:35 PM Changeset in webkit [29381] by ddkilzer@apple.com
  • 10 edits
    1 move
    2 deletes in trunk

JavaScriptCore:

dftables should be rewritten as a script

<​http://bugs.webkit.org/show_bug.cgi?id=16818>
<rdar://problem/5681463>

Reviewed by Darin.

Rewrote the dftables utility in Perl. Attempted to switch all
build systems to call the script directly instead of building
a binary first. Only the Xcode build was able to be tested.

  • DerivedSources.make: Added pcre directory to VPATH and changed to invoke dftables directly.
  • GNUmakefile.am: Removed build information and changed to invoke dftables directly.
  • JavaScriptCore.vcproj/JavaScriptCore.sln: Removed reference to dftables project.
  • JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Ditto.
  • JavaScriptCore.vcproj/dftables: Removed.
  • JavaScriptCore.vcproj/dftables/dftables.vcproj: Removed.
  • JavaScriptCore.xcodeproj/project.pbxproj: Removed dftables target.
  • jscore.bkl: Removed dftables executable definition.
  • pcre/dftables: Copied from JavaScriptCore/pcre/dftables.cpp.
  • pcre/dftables.cpp: Removed.
  • pcre/dftables.pro: Removed.
  • pcre/pcre.pri: Removed references to dftables.cpp and changed to invoke dftables directly.

WebKit/win:

dftables should be rewritten as a script

<​http://bugs.webkit.org/show_bug.cgi?id=16818>
<rdar://problem/5681463>

Reviewed by Darin.

  • WebKit.vcproj/WebKit.sln: Removed reference to dftables project.
4:23 PM Changeset in webkit [29380] by weinig@apple.com
  • 15 edits
    7 adds in trunk

WebCore:

Reviewed by Sam Weinig and Anders Carlsson.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=16522
<rdar://problem/5657355>

This patch makes two changes:

1) Java calls FrameLoader::load in a slightly different way than

JavaScript, which previously let a malicious web site bypass the
shouldAllowNavigation check. This patch adds that check to that
code path.

2) FrameLoader now wraps calls to m_frame->tree()->find(name) with

findFrameForNavigation, which calls shouldAllowNavigation. This
treats disallowed frame navigations as if the named frame did not
exist, resulting in a popup window when appropriate.

Tests: http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html

http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html

  • WebCore.base.exp:
  • bindings/js/kjs_window.cpp: (KJS::WindowProtoFuncOpen::callAsFunction):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::load): (WebCore::FrameLoader::post): (WebCore::FrameLoader::findFrameForNavigation):
  • loader/FrameLoader.h:

WebKit/mac:

Reviewed by Anders Carlsson.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=16522
<rdar://problem/5657355>

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadPluginRequest:]): call findFrameForNavigation to ensure the shouldAllowNavigation check is made.

WebKitTools:

Reviewed by Anders Carlsson.

Make DRT track open windows instead of allocated windows so that
we can avoid ASSERTION due to late deallocs out of our control.

  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpBackForwardListForAllWindows): (runTest):
  • DumpRenderTree/mac/DumpRenderTreeMac.h:
  • DumpRenderTree/mac/DumpRenderTreeWindow.h:
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm: (+[DumpRenderTreeWindow openWindows]): (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): (-[DumpRenderTreeWindow close]):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::windowCount):

LayoutTests:

Reviewed by Anders Carlsson.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=16522
<rdar://problem/5657355>

  • http/tests/security/frameNavigation/resources/frame-with-link-to-navigate.html: Added.
  • http/tests/security/frameNavigation/resources/frame-with-plugin-to-navigate.html: Added.
  • http/tests/security/frameNavigation/resources/navigation-happened.html: Added.
  • http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Added.
  • http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html: Added.
  • http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt: Added.
  • http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html: Added.
  • platform/win/Skipped:
4:10 PM Changeset in webkit [29379] by sullivan@apple.com
  • 2 edits in trunk/WebCore

Written by Hyatt, reviewed by me


  • fixed <rdar://problem/5654297> Mail crashes occurs at WebCore::FontFallbackList::fontDataAt() when attempting to display a <video> element that uses controls attribute
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): force the render style to inherit from the media element's style; Hyatt filed 5682383 to cover cleaning up this architecture, but this one-line fix will prevent the crash in the meantime
4:02 PM Changeset in webkit [29378] by andersca@apple.com
  • 1 edit in trunk/WebCore/plugins/win/PluginViewWin.cpp

Whoops, did not mean to commit that.

4:00 PM Changeset in webkit [29377] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix fast/forms/input-radio-checked-tab.html
Meta key is not the same as Alt key on windows.

Reviewed by Darin.

  • platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
3:11 PM Changeset in webkit [29376] by adachan@apple.com
  • 2 edits in trunk/WebKitTools

Meta key is not the same as Alt key on windows.

Reviewed by Darin.

  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3:11 PM Changeset in webkit [29375] by adachan@apple.com
  • 2 edits in trunk/WebCore

Fix fast/forms/input-radio-checked-tab.html
Meta key is not the same as Alt key on windows.

Reviewed by Darin.

  • platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2:17 PM Changeset in webkit [29374] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Removed a test that was fixed in r26826.
2:14 PM Changeset in webkit [29373] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Removed a test that was fixed in r28372.
1:51 PM Changeset in webkit [29372] by andersca@apple.com
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/5455889>
REGRESSION: BumperCar crashes when attempting to load a long invalid URL


Make sure to call FrameLoader::receivedMainResourceError before calling
FrameLoader::didFailToLoad. The call to receivedMainResourceError takes care of
clearing out the provisional document loader so that we won't call the didFail
ResourceLoadDelegate method twice. This also makes us call the FrameLoadDelegate method
didFailPrivisionalLoad before calling the ResourceLoadDelegate method, which Safari 2.0 does.


  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::receivedError):
1:48 PM Changeset in webkit [29371] by Antti Koivisto
  • 4 edits in trunk/WebCore

Reviewed by Adele.

Fix <rdar://problem/5658048>
After <video> has finished playing, dragging the scroller on different location of controller starts to play movie


  • Move to paused state if the playback had ended and the controller is used to seek to earlier time
  • Pause video playback during drag so the knob does not constantly try to escape from the mouse pointer
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::updateMediaPlayer): (WebCore::HTMLMediaElement::setPausedInternal):
  • html/HTMLMediaElement.h:
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler):
1:33 PM Changeset in webkit [29370] by ap@webkit.org
  • 4 edits in trunk

Reviewed by Adam Roben.

<rdar://problem/5667003> fast/dom/xmlhttprequest-html-response-encoding.html is failing

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Do not disable sniffing for ​file:// requests, as CFNetwork doesn't perform extension to MIME type mapping then.
1:23 PM Changeset in webkit [29369] by Adam Roben
  • 9 edits in trunk

Fix many bugs by giving Windows one FrameView per page load

WebCore:

Fixes to allow multiple FrameViews on Windows

Reviewed by Hyatt.

  • page/FrameView.cpp: (WebCore::FrameView::FrameView): Added a new constructor that takes an IntSize to specify the FrameView's initial size. (WebCore::FrameView::scheduleRelayout): Added an assertion that our Document is not in the page cache.
  • page/FrameView.h:
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::~Widget): Add a warm, fuzzy ASSERT.
  • platform/qt/WidgetQt.cpp: (WebCore::Widget::~Widget): Ditto.
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidget): Make sure to remove any existing Widget from the Widget hierarchy before deleting it. One instance where this is needed is when setWidget is called during FrameView creation on Windows.

WebKit/win:

Fix many bugs by giving Windows one FrameView per page load

Bugs include:

<rdar://5659200>

Windows back/forward cache causes crashes in the layout tests

<rdar://5659355>
<​http://bugs.webkit.org/show_bug.cgi?id=16808>

REGRESSION: PLT broken on Windows due to back/forward cache

<rdar://5663654>
<​http://bugs.webkit.org/show_bug.cgi?id=16607>

Random crashes in FrameView::scheduleRelayout while surfing
Thinkgeek

On Windows until now we've only had one FrameView per Frame. Once the
back/forward cache was turned on this started causing assertions to
fail and crashes to occur due to a single FrameView being both in the
back/forward cache (possibly multiple times!) and used by a live
document. We now create a new FrameView for each page load, just as
Mac does.

This has the side-effect of plugging some of the world leaks seen at
the end of the PLT.

Reviewed by Hyatt.

  • WebFrame.cpp: (WebFrame::initWithWebFrameView): Don't create the FrameView right away -- it'll be created when the load is committed. (WebFrame::transitionToCommittedFromCachedPage): Match the Mac by no longer calling resetMultipleFormSubmissionProtection here. (WebFrame::transitionToCommittedForNewPage): Ported code from -[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:], -[WebCoreFrameBridge installInFrame:], and moved code here from WebFrame::initWithWebFrameView and WebView::initWithFrame. WebCore takes care of resetMultipleFormSubmissionProtection, just like it does on the Mac.
  • WebView.cpp: (WebView::initWithFrame): Moved FrameView initialization code to WebFrame::transitionToCommittedForNewPage.
1:10 PM Changeset in webkit [29368] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-10 Alp Toker <​alp@atoker.com>

Include math.h to get ceilf(). Part of the SVG font GTK+ build fix.

  • svg/SVGFontFaceElement.cpp:
12:40 PM Changeset in webkit [29367] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Alice Liu.

<rdar://problem/5658603> Crash in InsertNodeBefore::doUnapply() on Undo in Yahoo Mail
<rdar://problem/5658709> Crash in RenderView::setSelection on Undo in Yahoo Mail


Make sure we have an updated layout before we perform any editing work.

  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply):
12:29 PM Changeset in webkit [29366] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-10 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

Back out r29206 which was causing regressions in curl http job
cancellation.

  • platform/network/curl/ResourceHandleManager.cpp (ResourceHandleManager::cancel):
11:33 AM Changeset in webkit [29365] by kmccullough@apple.com
  • 11 edits
    4 adds in trunk

WebCore:

Reviewed by Darin, Sam, and Adam.

  • <rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
  • link in gmail message displays JavaScript alert falsely complaining about pop-up blocking
  • When trying to open a new window, we now see if the user gesture occurred in the global dynamic object instead of the frame since that is the only place an event can occur.
  • bindings/js/kjs_window.cpp: - Check the dynamic global object instead of the frame. (KJS::allowPopUp): (KJS::showModalDialog): (KJS::WindowProtoFuncOpen::callAsFunction):

WebKitTools:

Reviewed by Darin, Sam and Adam.

-<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
link in gmail message displays JavaScript alert falsely complaining
about pop-up blocking.

  • Added the ability to enable the pop-up blocker via the LayoutTestController.
  • DumpRenderTree/LayoutTestController.cpp: (setPopupBlockingEnabledCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setPopupBlockingEnabled):

LayoutTests:

Reviewed by Darin, Sam, and Adam.

-<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
link in gmail message displays JavaScript alert falsely complaining
about pop-up blocking

  • When trying to open a new window, we now see if the user gesture occurred in the global dynamic object instead of the frame since that is the only place an event can occur.
  • fast/events/open-window-from-another-frame-expected.txt: Added.
  • fast/events/open-window-from-another-frame.html: Added.
  • fast/events/resources/open-window-from-another-frame-otherFrame.html: Added.
  • fast/events/resources/window-opened.html: Added.
  • platform/win/Skipped:
11:29 AM Changeset in webkit [29364] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix for bug 16247, visibility:hidden not honored when hit testing inline replaced elements.

Reviewed by adele

Added fast/css/visibility-hit-test.html test case.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
11:28 AM Changeset in webkit [29363] by hyatt@apple.com
  • 4 adds in trunk/LayoutTests

Add new layout test for visibility bug.

9:39 AM Changeset in webkit [29362] by mitz@apple.com
  • 5 edits
    1 move in trunk

JavaScriptCore:

Reviewed by Darin Adler.

The crash resulted from a native object (DumpRenderTree's
EventSender) causing its wrapper to be invalidated (by clicking a
link that replaced the document in the window) and consequently
deallocated. The fix is to use RefPtrs to protect the native object
from deletion by self-invalidation.

  • bindings/runtime_method.cpp: (RuntimeMethod::callAsFunction):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter): (RuntimeObjectImp::put): (RuntimeObjectImp::defaultValue): (RuntimeObjectImp::callAsFunction):

LayoutTests:

Reviewed by Darin Adler.

  • fast/replaced/image-map-expected.txt: Updated results for the new behavior, which is to replace the document with the success message.
  • fast/replaced/image-map.html: Copied from LayoutTests/fast/replaced/image-map.html-disabled.
  • fast/replaced/image-map.html-disabled: Removed.
8:47 AM Changeset in webkit [29361] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

document QWebHistory

8:47 AM Changeset in webkit [29360] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Make the reset() functions not do anything on the default QWebSettings object.

8:47 AM Changeset in webkit [29359] by Simon Hausmann
  • 10 edits
    3 moves in trunk

rename QWebPageHistory to QWebHistory.

8:39 AM Changeset in webkit [29358] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Documentation for QWebSettings

8:38 AM Changeset in webkit [29357] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Document QWebHistoryInterface.

8:38 AM Changeset in webkit [29356] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

Documentation for QWebFrame.

8:19 AM Changeset in webkit [29355] by Simon Hausmann
  • 7 edits in trunk

fix the drawing errors that where introduced due to refactoring.

Correctly clip to the rectangle we want to draw in ScrollView::paint().

Signed-off-by: Simon

8:19 AM Changeset in webkit [29354] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Added a whole bunch of docs for QWebPage and fixed some minor doc glitches in QWebView.

Signed-off-by: Lars

8:19 AM Changeset in webkit [29353] by Simon Hausmann
  • 2 edits in trunk/WebCore

Temporarily disable gzip decompression in qhttp due to a bug.

Signed-off-by: Lars

7:28 AM Changeset in webkit [29352] by Simon Hausmann
  • 7 edits in trunk/WebCore

​http://bugs.webkit.org/show_bug.cgi?id=16588

Added a (last) Frame argument to ResourceHandle::loadResourceSynchronously.
This allows implementing the synchronous loading correctly for the Qt port where the networking
backend is bound to the page.

Signed-off-by: Lars

7:22 AM Changeset in webkit [29351] by mitz@apple.com
  • 5 edits in trunk/LayoutTests

Reviewed by John Sullivan.

  • make more tests pass on Windows by forcing font fallback to match Mac OS X.
  • fast/css/beforeSelectorOnCodeElement.html:
  • fast/css/rtl-ordering.html:
  • fast/css/text-security.html:
  • platform/win/Skipped:
12:49 AM Changeset in webkit [29350] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix for changes in r29328

Jan 9, 2008:

7:48 PM Changeset in webkit [29349] by mjs@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Sam.

  • refactor SecurityOrigin in preparation for merging with SecurityOriginData
  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::create): (WebCore::SecurityOrigin::createForFrame):
  • platform/SecurityOrigin.h:
7:03 PM Changeset in webkit [29348] by adachan@apple.com
  • 6 edits
    1 copy
    1 add in trunk

WebCore:

Tabs with ctrl, meta, or altgraph modifier key down should not advance focus.

Reviewed by Darin.

Test: fast/forms/tabs-with-modifiers.html

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): (WebCore::EventHandler::defaultTabEventHandler): bail if ctrl, meta, or altgraph key is down. Clean up the code a bit.
  • page/EventHandler.h:
  • page/FocusController.cpp: Remove the advanceFocus() that takes in a KeyboardEvent. It was only called in EventHandler::defaultTabEventHandler() but we have cleaned up the code there and no longer needs it.
  • page/FocusController.h:


LayoutTests:

Tests tabbing with different combinations of modifiers keys, where some
should advance focus and some should not.

Reviewed by Darin.

  • fast/forms/tabs-with-modifiers-expected.txt: Added.
  • fast/forms/tabs-with-modifiers.html: Copied from fast/forms/focus2.html.


6:57 PM Changeset in webkit [29347] by adachan@apple.com
  • 2 edits in trunk/WebKit/win

Fix crash that could happen if the key we are passing to the HashMap is 0 in WebView::interpretKeyEvent().

Reviewed by Darin.

  • WebView.cpp: (WebView::interpretKeyEvent):
6:51 PM Changeset in webkit [29346] by mjs@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.


  • add some more renames, adjust some
  • Scripts/do-webcore-rename:
5:41 PM Changeset in webkit [29345] by Antti Koivisto
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=16376
<rdar://problem/5665206>
<video> element fails to play frames when navigating back to page (16376)


Don't make MediaPlayer visible when it is actually in page cache.

  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer):
5:38 PM Changeset in webkit [29344] by andersca@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5532361>
CrashTracer: 9840 crashes in Safari at com.apple.JavaScriptCore: KJS::Bindings::CInstance::~CInstance [in-charge deleting] + 35


Clear the frame's plugin root objects so that they don't outlive the plugin bundle.


  • page/Frame.cpp: (WebCore::Frame::pageDestroyed):
5:37 PM Changeset in webkit [29343] by mitz@apple.com
  • 2 edits
    4 moves
    1 delete in trunk/LayoutTests

Reviewed by Darin Adler.

  • move a WebKit test which was inadvertently added to a test suite directory into a custom test directory and change it to give the same results on Windows.
  • css1/text_properties/text-transCapitalize.html: Removed.
  • fast/text/capitalize-boundaries.html: Copied from LayoutTests/css1/text_properties/text-transCapitalize.html, updated the Bugzilla URL and added @font-face rules to make Windows results match Mac OS X.
  • platform/mac/css1/text_properties/text-transCapitalize-expected.checksum: Removed.
  • platform/mac/css1/text_properties/text-transCapitalize-expected.png: Removed.
  • platform/mac/css1/text_properties/text-transCapitalize-expected.txt: Removed.
  • platform/mac/fast/text/capitalize-boundaries-expected.checksum: Copied from LayoutTests/platform/mac/css1/text_properties/text-transCapitalize-expected.checksum.
  • platform/mac/fast/text/capitalize-boundaries-expected.png: Copied from LayoutTests/platform/mac/css1/text_properties/text-transCapitalize-expected.png.
  • platform/mac/fast/text/capitalize-boundaries-expected.txt: Copied from LayoutTests/platform/mac/css1/text_properties/text-transCapitalize-expected.txt.
  • platform/qt/css1/text_properties/text-transCapitalize-expected.txt: Removed.
  • platform/win/Skipped: Removed css1/text_properties/text-transCapitalize.html.
3:02 PM Changeset in webkit [29342] by sullivan@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben and Anders Carlsson


  • fixed <rdar://problem/5469398> Repro assertion failure in context menu code due to missing-but-expected Reload item
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): use isLoadingInAPISense when deciding whether to include Stop or Reload in context menu, to match the WebKit API
12:26 PM Changeset in webkit [29341] by alp@webkit.org
  • 4 edits in trunk/WebKit/gtk

2008-01-09 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16802
[GTK] Missing gtk properties


Add missing properties to WebKitViewFrame and WebKitWebView.


  • WebView/webkitprivate.h: add some useful defines for param specs
  • WebView/webkitwebframe.cpp: (webkit_web_frame_get_property): added (webkit_web_frame_class_init): add name, title and uri read-only properties
  • WebView/webkitwebview.cpp: (webkit_web_view_get_property): add editable property read (webkit_web_view_set_property): added for editable property write (webkit_web_view_class_init): add read-write editable property
12:13 PM Changeset in webkit [29340] by ap@webkit.org
  • 3 edits in trunk/LayoutTests

Reviewed by Adam Roben.

<rdar://problem/5673716> fast/loader/opaque-base-url.html is failing
<rdar://problem/5670275> fast/loader/onunload-form-submit-crash.html is failing
<rdar://problem/5667277> fast/loader/onunload-form-submit-crash-2.html is failing

  • fast/loader/meta-refresh-vs-open.html: Changed to be more DRT-friendly.
  • platform/win/Skipped: Removed tests that were victims of the above.
12:10 PM Changeset in webkit [29339] by ap@webkit.org
  • 4 edits in trunk/LayoutTests

Reviewed by Adam Roben.

Fix fast/encoding/frame-default-enc.html, which is failing on buildbot.

Internal frame names for this test are changing for no apparent reason (see r25269).
Make the test independent of the names.

  • fast/encoding/frame-default-enc-expected.txt:
  • fast/encoding/frame-default-enc.html:
  • fast/encoding/resources/frame-default-enc-frame.html:
10:03 AM Changeset in webkit [29338] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix Windows debug build for opensource developers.

  • WebCore.vcproj/QTMovieWin.vcproj: Use the correct library suffix.
10:01 AM Changeset in webkit [29337] by Adam Roben
  • 6 edits in trunk/LayoutTests

Update some test results

Reviewed by Anders.

  • fast/dom/Window/window-properties-expected.txt: Updated after r29328.
  • platform/win/media/audio-controls-rendering-expected.txt: Regenerated results with the correct fonts.
  • platform/win/media/video-aspect-ratio-expected.txt: Ditto.
  • platform/win/media/video-controls-rendering-expected.txt: Ditto.
  • platform/win/media/video-transformed-expected.txt: Ditto.
8:32 AM ApplicationsGtk edited by alp@atoker.com
Add a mail client (diff)
1:23 AM Changeset in webkit [29336] by eric@webkit.org
  • 8 edits
    16 adds in trunk

Reworked by Eric, Reviewed by Hyatt.

Tests: fast/selectors/lang-inheritance.html

fast/selectors/lang-inheritance2.html
fast/selectors/lang-vs-xml-lang.html
fast/selectors/lang-vs-xml-lang-xhtml.xhtml

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Do not share style between elements with different LANG-attribute. (WebCore::CSSStyleSelector::checkOneSelector): Change :lang() to recursively check the LANG attribute for all the elements parents and the content-language of the document.
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Parse MIME Content-Language
  • dom/Document.h: (WebCore::Document::contentLanguage): (WebCore::Document::setContentLanguage):
Note: See TracTimeline for information about the timeline view.