⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 12, 2008:

11:33 PM Changeset in webkit [29445] by alp@webkit.org
  • 6 edits in trunk

2008-01-12 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Hide non-public symbols in GTK+/autotools release builds.

10:54 PM Changeset in webkit [29444] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix. Add WebCore/icu/include for Mac builds using only stock ICU.

8:52 PM Changeset in webkit [29443] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-01-12 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Mark Rowe.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=16852
Fixes leaking of ActivationStackNode objects.

  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::deleteActivationStack): (KJS::JSGlobalObject::~JSGlobalObject): (KJS::JSGlobalObject::init): (KJS::JSGlobalObject::reset):
  • kjs/JSGlobalObject.h:
1:23 PM QtWebKitContrib edited by staikos@webkit.org
(diff)
11:25 AM Changeset in webkit [29442] by mrowe@apple.com
  • 5 edits in trunk/WebCore

2008-01-12 Rodney Dawes <​dobey@wayofthemonkey.com>

Gtk debug build fix. Reviewed by Mark Rowe.

Add plugin logging channel, and use it rather than Win32-specific debugging methods _RPTF1 _RPTF2 and _CRT_WARN.

  • WebCore.pro: Add plugins directory to DEPENDPATH so dependencies are correctly tracked.
  • platform/Logging.cpp:
  • platform/Logging.h:
  • plugins/PluginDebug.h:
10:35 AM Changeset in webkit [29441] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Update expected results for fast/replaced/image-map-expected after
r29432 disabled document replacement by the JavaScript result in this
case.

  • fast/replaced/image-map-expected.txt:
10:19 AM Changeset in webkit [29440] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • try to fix Qt Windows build
  • pcre/dftables: Remove reliance on the list form of Perl pipes.
10:05 AM Changeset in webkit [29439] by Darin Adler
  • 3 edits in trunk/JavaScriptCore
  • try to fix Qt build
  • kjs/function.cpp: Added include of scope_chain_mark.h.
  • kjs/scope_chain_mark.h: Added multiple-include guards.
7:43 AM Changeset in webkit [29438] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Roll out r29435 as it introduces many, many crashes.

6:25 AM Changeset in webkit [29437] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-01-12 Mark Rowe <​mrowe@apple.com>

Another Windows build fix.

  • kjs/Activation.h:
6:12 AM Changeset in webkit [29436] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-01-12 Mark Rowe <​mrowe@apple.com>

Attempted Windows build fix. Use struct consistently when forward-declaring
ActivationStackNode and StackActivation.

  • kjs/Activation.h:
  • kjs/JSGlobalObject.h:
6:06 AM Changeset in webkit [29435] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-01-12 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Mark Rowe.

Fixes leaking of ActivationStackNode objects.

  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::deleteActivationStack): (KJS::JSGlobalObject::~JSGlobalObject): (KJS::JSGlobalObject::init): (KJS::JSGlobalObject::reset):
  • kjs/JSGlobalObject.h:
5:48 AM Changeset in webkit [29434] by zecke@webkit.org
  • 5 edits
    1 add in trunk
  • Make launching of the WebKit httpd work on GNU/Debian/Linux

The configuration of Apache2 and installation does not depend on
the kernel but on the distribution policy. Make launching of httpd
work for Debian derived distributions.

5:19 AM Changeset in webkit [29433] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.

Reviewed by Maciej Stachowiak.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to

match the callers expectations that it can take ownership of the string.

4:03 AM Changeset in webkit [29432] by mjs@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Maciej (and also tweaked a little bit).

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::executeIfJavaScriptURL):
  • loader/FrameLoader.h:
3:03 AM Changeset in webkit [29431] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Fixes a problem with the ActivationImp tear-off patch (r29425) where
some of the calls to JSGlobalObject::tearOffActivation() were using
the wrong test to determine whether it should leave a relic behind.

  • kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::ActivationImp::getOwnPropertySlot):
12:37 AM Changeset in webkit [29430] by mjs@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • fixed <rdar://problem/5556374> REGRESSION: cross-domain error when one URL uses an explicit port number and another doesn't


  • platform/SecurityOrigin.cpp: (WebCore::isDefaultPortForProtocol): (WebCore::SecurityOrigin::SecurityOrigin):

Jan 11, 2008:

11:40 PM Changeset in webkit [29429] by alp@webkit.org
  • 3 edits in trunk

2008-01-11 Alp Toker <​alp@atoker.com>

Reviewed by Oliver Hunt.

Enable FastMalloc by default in GTK+/autotools and add a configure
switch.

  • GNUmakefile.am:
  • configure.ac:
11:19 PM Changeset in webkit [29428] by ggaren@apple.com
  • 19 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Oliver Hunt.


Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
variable access (16644)


This bug was caused by var declarations shadowing built-in properties of
the global object.


To match Firefox, we've decided that var declarations will never shadow
built-in properties of the global object or its prototypes. We used to
behave more like IE, which allows shadowing, but walking that line got
us into trouble with websites that sent us down the Firefox codepath.

  • kjs/JSVariableObject.h: (KJS::JSVariableObject::symbolTableGet): New code to support calling hasProperty before the variable object is fully initialized (so you can call it during initialization).
  • kjs/nodes.cpp:. (KJS::ProgramNode::initializeSymbolTable): Always do a full hasProperty check when looking for duplicates, not getDirect, since it only checks the property map, and not hasOwnProperty, since it doesn't check prototypes. (KJS::EvalNode::processDeclarations): ditto
  • kjs/property_slot.h: (KJS::PropertySlot::ungettableGetter): Best function name evar.

WebCore:

Reviewed by Oliver Hunt.


Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
variable access (16644)


Removed the ReadOnly bit from some properties, to match Firefox. Also
removed status-related setters, to allow using their names as variable
names.


  • bindings/scripts/CodeGeneratorJS.pm: Added support for properties that are one-way across domain boundaries, to match Firefox.
  • bindings/js/kjs_window.cpp: Changed ReadOnly declarations to match FF.
  • bindings/scripts/CodeGeneratorJS.pm: Don't use JSObject:: because we don't know that JSObject is our base class.
  • page/DOMWindow.idl: Replaced lots of readonly declarations with [Replaceable] declarations.
  • page/DOMWindow.h: Removed interfaces for setting status text via the DOM. (They were getting in the way of, e.g., "var status" declarations.) By default, IE 7 and FF disable these interfaces in order to defend against phishing attacks that try to spoof domain names in the statusbar.
  • page/DOMWindow.cpp:

LayoutTests:

Reviewed by Oliver Hunt.


Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
variable access (16644)


Added a test. Updated other tests to match new behavior.


  • fast/js/var-declarations-shadowing-expected.txt: Added.
  • fast/js/var-declarations-shadowing.html: Added.
  • fast/dom/HTMLScriptElement/script-load-events.html: Changed this test a bit because the original design made it hard to understand why it was failing.
  • fast/dom/HTMLScriptElement/script-load-events-expected.txt:


  • fast/dom/Window/get-set-properties.html: Changed this test to expect our new behavior, which matches Firefox.
  • fast/dom/Window/get-set-properties-expected.txt:
  • fast/dom/Window/window-property-shadowing.html: Removed some cases that differed from Firefox.
  • fast/dom/Window/window-property-shadowing-expected.txt:
  • http/tests/security/cross-frame-access-put-expected.txt: This test emits more "Unsafe JavaScript attempt" messages now because property sets that used to be prohibited (somewhat accidentally) by the ReadOnly attribute are now prohibited by security checks.
9:50 PM Changeset in webkit [29427] by mitz@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

2008-01-11 Anyang Ren <​anyang.ren@gmail.com>

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=15960
The view source mode should skip an empty attribute value only if
the attribute name is not followed by an equal sign (=).

Test: fast/frames/viewsource-empty-attribute-value.html

  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):

LayoutTests:

2008-01-11 Anyang Ren <​anyang.ren@gmail.com>

Reviewed by Darin Adler.

Add a new regression test for
​http://bugs.webkit.org/show_bug.cgi?id=15960
The view source mode should skip an empty attribute value only if
the attribute name is not followed by an equal sign (=).

  • fast/frames/resources/viewsource-frame-1.html: Added.
  • fast/frames/viewsource-empty-attribute-value-expected.txt: Added.
  • fast/frames/viewsource-empty-attribute-value.html: Added.
6:22 PM Changeset in webkit [29426] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-11 Sylvain Pasche <​sylvain.pasche@gmail.com>

Reviewed by Alp Toker.

[Gtk] Uneven glyph spacing with subpixel antialiasing
​http://bugs.webkit.org/show_bug.cgi?id=16715

Use cairo font options from the default GDK screen when creating a
scaled font.

  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
6:08 PM Changeset in webkit [29425] by mjs@apple.com
  • 16 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

Optimized ActivationImp allocation, so that activation records are now
first allocated on an explicitly managed stack and only heap allocated
when necessary. Roughly a 5% improvement on SunSpider, and a larger
improvement on benchmarks that use more function calls.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/Activation.h: Added. (KJS::ActivationImp::ActivationData::ActivationData): (KJS::ActivationImp::ActivationImp): (KJS::ActivationImp::classInfo): (KJS::ActivationImp::isActivationObject): (KJS::ActivationImp::isOnStack): (KJS::ActivationImp::d): (KJS::StackActivation::StackActivation):
  • kjs/ExecState.cpp: (KJS::ExecState::ExecState): (KJS::ExecState::~ExecState):
  • kjs/ExecState.h: (KJS::ExecState::replaceScopeChainTop): (KJS::ExecState::setActivationObject): (KJS::ExecState::setLocalStorage):
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset): (KJS::JSGlobalObject::pushActivation): (KJS::JSGlobalObject::checkActivationCount): (KJS::JSGlobalObject::popActivationHelper): (KJS::JSGlobalObject::popActivation): (KJS::JSGlobalObject::tearOffActivation):
  • kjs/JSGlobalObject.h:
  • kjs/JSVariableObject.h: (KJS::JSVariableObject::JSVariableObjectData::JSVariableObjectData): (KJS::JSVariableObject::JSVariableObject):
  • kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::ActivationImp::ActivationImp): (KJS::ActivationImp::~ActivationImp): (KJS::ActivationImp::init): (KJS::ActivationImp::getOwnPropertySlot): (KJS::ActivationImp::markHelper): (KJS::ActivationImp::mark): (KJS::ActivationImp::ActivationData::ActivationData): (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function.h:
  • kjs/nodes.cpp: (KJS::PostIncResolveNode::evaluate): (KJS::PostDecResolveNode::evaluate): (KJS::PreIncResolveNode::evaluate): (KJS::PreDecResolveNode::evaluate): (KJS::ReadModifyResolveNode::evaluate): (KJS::AssignResolveNode::evaluate): (KJS::WithNode::execute): (KJS::TryNode::execute): (KJS::FunctionBodyNode::processDeclarations): (KJS::FuncExprNode::evaluate):
  • kjs/object.h:
  • kjs/scope_chain.h: (KJS::ScopeChain::replace):
  • kjs/scope_chain_mark.h: Added. (KJS::ScopeChain::mark):

WebCore:

Reviewed by Maciej.

Added a new forwarding header, because Activation.h has been separated
from function.h

  • ForwardingHeaders/kjs/Activation.h: Added.

LayoutTests:

Reviewed by Maciej.

Added a test case that came up when developing the ActivationImp tear-off.

  • fast/js/resources/vardecl-preserve-arguments.js:
  • fast/js/vardecl-preserve-arguments-expected.txt:
5:52 PM Changeset in webkit [29424] by justin.garcia@apple.com
  • 5 edits
    2 adds in trunk/LayoutTests

<rdar://problem/5541054> editing/pasteboard/paste-RTFD.html failing on Tiger

  • editing/pasteboard/paste-RTFD.html: Mention the Tiger bug that this demonstrates.
  • platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.checksum: Added.
  • platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.png: Added.
  • platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt: Updated expected results to reflect the new info included in the test.
  • platform/mac/editing/pasteboard/paste-RTFD-expected.checksum: Ditto.
  • platform/mac/editing/pasteboard/paste-RTFD-expected.png:
  • platform/mac/editing/pasteboard/paste-RTFD-expected.txt:
5:36 PM Changeset in webkit [29423] by alp@webkit.org
  • 5 edits in trunk/WebCore

2008-01-11 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16729
[cURL] Allow multiple files for upload

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::readCallback): added (WebCore::ResourceHandleManager::setupPOST): setup for streaming the POST (WebCore::ResourceHandleManager::startJob): (WebCore::ResourceHandleManager::cancel): revert the previous patch for regression
  • platform/network/curl/ResourceHandleManager.h:
4:25 PM Changeset in webkit [29422] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-01-11 Christian Dywan <​christian@imendio.com>

Reviewed by Alp Toker.

[Gtk] Menu items need underscores
​http://bugs.webkit.org/show_bug.cgi?id=16817

Add underscores to appropriate menu labels.
Also adjust strings slightly.

  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::createNativeMenuItem):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuClearRecentSearchesText):
3:56 PM Changeset in webkit [29421] by adachan@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/5681557> On Windows Safari, mouse events are ignored after clicking on link that triggers download
Moved the call to cache page from provisionalLoadStarted() to commitProvisionalLoad(), since
provisionalLoadStarted() can be called for cases that do not result in a page navigation, for example,
when a link to download a file has been clicked.

Reviewed by John and Anders.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::commitProvisionalLoad):
2:42 PM Changeset in webkit [29420] by jhoneycutt@apple.com
  • 2 edits in trunk/LayoutTests

2008-01-11 Jon Honeycutt <​jhoneycutt@apple.com>

  • platform/win/Skipped: Remove a test that was fixed in r29419.
2:38 PM Changeset in webkit [29419] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2008-01-11 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://problem/5683529> plugins/embed-inside-object.html is timing
out/failing

Revert to using FrameTree::find() so that frame aliases like "_self" and
"_current" are interpreted properly

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::load):
1:58 PM Changeset in webkit [29418] by alp@webkit.org
  • 7 edits
    2 adds in trunk/WebCore

2008-01-11 Alp Toker <​alp@atoker.com>

Reviewed by Dave Hyatt and Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16089
[GTK] Support custom fonts, CachedFont::platformDataFromCustomData()

Add support for CSS2 @font-face custom/downloadable fonts to the GTK+
port.

  • GNUmakefile.am:
  • WebCore.pro:
  • loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allReferencesRemoved):
  • platform/graphics/gtk/FontCustomPlatformData.cpp: Added. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::releaseData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/gtk/FontCustomPlatformData.h: Added. (WebCore::FontCustomPlatformData::FontCustomPlatformData):
  • platform/graphics/gtk/FontPlatformData.h:
  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::init): (WebCore::FontPlatformData::isFixedPitch):
  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformDestroy):
1:04 PM Changeset in webkit [29417] by ap@webkit.org
  • 4 edits in trunk

Reviewed by Adam Roben.

<rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing

  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events, as these are only posted because the test window is not a normal visible one, and they confuse drag&drop machinery.
12:51 PM Changeset in webkit [29416] by Adam Roben
  • 2 edits in trunk/WebCore

Remove FrameLoader::committedFirstRealDocumentLoad

This method no longer has any callers.

Reviewed by Hyatt.

  • loader/FrameLoader.h:
12:50 PM Changeset in webkit [29415] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix Bug 16828: WebView never paints if first page load is canceled after being committed but before layout

<​http://bugs.webkit.org/show_bug.cgi?id=16828>
<rdar://5682402>

Now that we have 1) a real loader and 2) multiple FrameViews per
Frame, we no longer need the hackery we had in our WM_PAINT handler
that decided whether or not to paint. We now always want to paint,
letting the swapping of FrameViews that happens in
transitionToCommittedForNewPage handle which document gets painted.

Reviewed by Hyatt.

  • WebView.cpp: (WebViewWndProc): Removed hackery that decided sometimes not to paint.
12:19 PM Changeset in webkit [29414] by Antti Koivisto
  • 1 edit
    2 adds in trunk/WebCore

Add a standalone version of the blog post video player as a manual test.

  • manual-tests/resources/touch-poster.png: Added.
  • manual-tests/video-player.html: Added.
12:07 PM Changeset in webkit [29413] by alice.liu@apple.com
  • 1 edit in trunk/LayoutTests/platform/win/Skipped

test is failing on trunk-win-release, so putting it back to make it green

11:47 AM Changeset in webkit [29412] by sfalken@apple.com
  • 1 edit
    6 adds in trunk/WebKitLibraries

Add shared vsprops to help unify our Windows tools settings.

Reviewed by Hyatt.

  • win/tools: Added.
  • win/tools/WinTools.make: Added.
  • win/tools/vsprops: Added.
  • win/tools/vsprops/common.vsprops: Added.
  • win/tools/vsprops/debug.vsprops: Added.
  • win/tools/vsprops/release.vsprops: Added.
11:29 AM Changeset in webkit [29411] by alice.liu@apple.com
  • 1 edit in trunk/LayoutTests/platform/win/Skipped

removing test that doesn't fail

11:19 AM Changeset in webkit [29410] by Antti Koivisto
  • 3 edits in trunk/WebCore

Reviewed by Adam.

Fix <rdar://problem/5682767>
Video does not show up in ​http://webkit.org/blog/140/html5-media-support/ on Windows


Take care that GWorld is created and deletes when needed as size or visibility changes.

10:33 AM Mobile created by alp@atoker.com
Add a page on WebKit for mobile devices
10:27 AM Changeset in webkit [29409] by hyatt@apple.com
  • 3 edits in trunk/WebCore

Fix for bug 11188, setting hspace on a table overrides align=center. Fix align=center to be done using
mapped attributes so that it does not get overridden by hspace all the time.

Reviewed by mitz

Added fast/table/table-hspace-align-center.html

  • css/html4.css:
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
10:25 AM Changeset in webkit [29408] by hyatt@apple.com
  • 4 adds in trunk/LayoutTests

Add layout test for table bug.

10:15 AM Changeset in webkit [29407] by alice.liu@apple.com
  • 1 edit in trunk/LayoutTests/platform/win/Skipped

moved couple of tests to a better category

10:14 AM Changeset in webkit [29406] by Adam Roben
  • 3 edits in trunk/WebKitTools

Fix a crash when pathToLocalResource fails and a leak

Reviewed by Darin.

  • DumpRenderTree/LayoutTestController.cpp: (pathToLocalResourceCallback): Dont leak the JSStringRef, and make sure not to pass null to JSValueMakeString.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pathToLocalResource): Print an error message if the conversion fails so it's clear what happened.
8:32 AM Changeset in webkit [29405] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added some new failures.
8:31 AM Changeset in webkit [29404] by alp@webkit.org
  • 2 edits in trunk

2008-01-11 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16838
[GTK] Bad autotools debug and video options

Fix some configure options.

  • configure.ac:
4:40 AM Changeset in webkit [29403] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Qt build fix.

4:26 AM Changeset in webkit [29402] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

Fix the (clean) qmake build. For generating chartables.c we don't
depend on a separate input source file anymore, the dftables perl
script is enough. So use that instead as value for the .input
variable, to ensure that qmake also generates a rule to call dftables.

3:56 AM Changeset in webkit [29401] by mrowe@apple.com
  • 2 edits in trunk/WebKit/win

Windows build fix. Update to match method name in WebCore.

3:53 AM Changeset in webkit [29400] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Qt build fix. Add link stubs for the new FileSystem.h functions introduced in r29399.

3:32 AM Changeset in webkit [29399] by mrowe@apple.com
  • 9 edits
    4 moves in trunk/WebCore

2008-01-11 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Anders Carlsson.

Bug 16779: Make the PluginStream implementation be shared across platforms
​http://bugs.webkit.org/show_bug.cgi?id=16779

Add the new shared PluginStream files to the GTK+ and Win32 builds.
Add PluginStreamClient class for the streamDidFinishLoading method.
Add open/close/write methods to FileSystem for temporary file handling.
Add PluginDebug.h and npfunctions.h for shared PluginStream.
Add shared PluginStream.
Remove PluginStreamWin.
Update PluginViewWin to use shared PluginStream and PluginStreamClass.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/FileSystem.h:
  • platform/gtk/FileSystemGtk.cpp:
  • platform/win/FileSystemWin.cpp:
  • plugins/PluginDebug.h:
  • plugins/PluginStream.cpp:
  • plugins/PluginStream.h:
  • plugins/npfunctions.h:
  • plugins/win/PluginDebug: Moved to PluginDebug.h.
  • plugins/win/PluginStreamWin.cpp: Moved to PluginStream.cpp.
  • plugins/win/PluginStreamWin.h: Moved to PluginStream.h
  • plugins/win/PluginViewWin.cpp:
  • plugins/win/PluginViewWin.h:
  • plugins/win/npfunctions.h: Moved to npfunctions.h
2:09 AM Changeset in webkit [29398] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Try to fix Mac build: Edit the right .exp file.

  • WebCore.base.exp:
2:03 AM Changeset in webkit [29397] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Try to fix Qt build: don't use pthreads if they're not available.

  • bindings/js/GCController.cpp:
1:52 AM Changeset in webkit [29396] by ggaren@apple.com
  • 18 edits
    2 deletes in trunk

JavaScriptCore:

Reviewed by John Sullivan.

Fixed some world leak reports:

  • <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript Interpreter after running cvs-base suite
  • <rdar://problem/5669423> PLT complains about world leak if browser window is open when PLT starts


  • kjs/collector.h: Added the ability to distinguish between global objects and GC-protected global objects, since we only consider the latter to be world leaks.
  • kjs/collector.cpp:

WebCore:

Reviewed by John Sullivan.

Fixed some world leak reports:

  • <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript Interpreter after running cvs-base suite
  • <rdar://problem/5669423> PLT complains about world leak if browser window is open when PLT starts


These were both bugs in the reporting mechanism, so I took the
opportunity to do some house cleaning there.

Stupid class, I kill you:

  • bridge/JavaScriptStatistics.cpp: Removed.
  • bridge/JavaScriptStatistics.h: Removed.
  • bindings/js/GCController.h: Adopted the only useful features of JavaScriptStatistics, since they were GC-related.
  • bindings/js/GCController.cpp:

WebKit/mac:

Reviewed by John Sullivan.

Fixed some world leak reports:

  • <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript Interpreter after running cvs-base suite
  • <rdar://problem/5669423> PLT complains about world leak if browser window is open when PLT starts


These were both bugs in the reporting mechanism, so I took the
opportunity to do some house cleaning there.

  • Misc/WebCoreStatistics.h: Did a little renaming, to match JavaScriptCore better. I kept the methods with the old names around, though, because old versions of Safari need them.
  • Misc/WebCoreStatistics.mm: Removed dependence on WebCore::JavaScriptStatistics, which is gone now.


These two methods are now distinct, for the sake of world leak reporting:
(+[WebCoreStatistics javaScriptGlobalObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):

WebKit/win:

Reviewed by John Sullivan.

Updated for transition away from JavaScriptStatistics, which is gone now.

  • WebJavaScriptCollector.cpp: (WebJavaScriptCollector::collect): (WebJavaScriptCollector::collectOnAlternateThread): (WebJavaScriptCollector::objectCount):

WebKitTools:

Reviewed by John Sullivan.

  • DumpRenderTree/mac/GCControllerMac.mm: (GCController::collectOnAlternateThread): Updated for name change.
12:22 AM Changeset in webkit [29395] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Silence qmake warning about ctgen lacking input. Rubber-stamped by Alp Toker.

12:04 AM Changeset in webkit [29394] by mrowe@apple.com
  • 2 edits in trunk

Attempt to fix the GTK+ and Qt builds.

Note: See TracTimeline for information about the timeline view.