⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 13, 2008:

10:05 PM Changeset in webkit [29458] by sfalken@apple.com
  • 19 edits
    1 move
    4 adds
    23 deletes in trunk

JavaScriptCore:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Reviewed by Adam Roben.

WebCore:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

Reviewed by Adam Roben.

  • WebCore.vcproj/PRODUCTVERSION: Removed.
  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/VERSION: Removed.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/auto-version.sh: Removed.
  • WebCore.vcproj/debug.vsprops: Removed.
  • WebCore.vcproj/debug_internal.vsprops: Removed.
  • WebCore.vcproj/release.vsprops: Removed.

WebKit/win:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

Reviewed by Adam Roben.

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/PRODUCTVERSION: Removed.
  • WebKit.vcproj/VERSION: Removed.
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebKit.vcproj/auto-version.sh: Removed.
  • WebKit.vcproj/debug.vsprops: Removed.
  • WebKit.vcproj/debug_internal.vsprops: Removed.
  • WebKit.vcproj/release.vsprops: Removed.

WebKitLibraries:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Moved auto-version.sh, VERSION, PRODUCTVERSION to tools.

Reviewed by Adam Roben.

  • win/tools/WinTools.make:
  • win/tools/scripts: Added.
  • win/tools/scripts/PRODUCTVERSION: Added.
  • win/tools/scripts/VERSION: Added.
  • win/tools/scripts/auto-version.sh: Copied from WebCore/WebCore.vcproj/auto-version.sh.
  • win/tools/vsprops/debug.vsprops:
  • win/tools/vsprops/debug_internal.vsprops: Added.
  • win/tools/vsprops/release.vsprops:

WebKitTools:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

Reviewed by Adam Roben.

  • Drosera/win/Drosera.vcproj/Drosera.vcproj:
  • Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
  • Drosera/win/Drosera.vcproj/VERSION: Removed.
  • Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
  • Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
  • Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
  • Drosera/win/Drosera.vcproj/release.vsprops: Removed.
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/debug.vsprops: Removed.
  • DumpRenderTree/win/debug_internal.vsprops: Removed.
  • DumpRenderTree/win/release.vsprops: Removed.
8:40 PM Changeset in webkit [29457] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::destroy): Removed the call to RenderLayer::destroy() from here, because ~RenderLayer() calls RenderObject() methods.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Added the call to RenderLayer::destroy() here.
5:35 PM Changeset in webkit [29456] by eric@webkit.org
  • 3 edits
    6 adds in trunk

Reviewed by darin.

Range.insertNode does not update endContainer endIndex correctly
in the case where it had to split a text node.
​http://bugs.webkit.org/show_bug.cgi?id=16765

Darin pointed out during review that we still don't handle the dynamic
range case (where the dom tree changes not using range methods)
Thus this code will get ripped out when we add that. The test cases
are still valid and useful however, so I'm landing this as-is.

Tests: fast/dom/Range/range-insertNode-separate-endContainer.html

fast/dom/Range/range-insertNode-splittext.html

  • dom/Range.cpp: (WebCore::Range::insertNode): handle the splitText case correctly.
11:54 AM Changeset in webkit [29455] by Darin Adler
  • 2 edits
    3 adds in trunk/WebKitTools

Reviewed by Maciej.

  • Scripts/gdb-drosera: Added.
  • Scripts/run-drosera: Added.
  • Scripts/run-drosera-nightly.cmd: Added.
  • Scripts/webkitdirs.pm: Added runDrosera function.
11:47 AM Changeset in webkit [29454] by Darin Adler
  • 5 edits in trunk/JavaScriptCore

Contributions and review by Adriaan de Groot,
Simon Hausmann, Eric Seidel, and Darin Adler.

  • kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime): Use the WIN_OS code path for SOLARIS too, presumably because Solaris also lacks the tm_gtoff and tm_zone fields. (KJS::GregorianDateTime::operator tm): Ditto.
  • kjs/collector.cpp: (KJS::currentThreadStackBase): Use thr_stksegment on Solaris.
  • wtf/MathExtras.h: (isfinite): Implement for Solaris. (isinf): Ditto. (signbit): Ditto. But this one is wrong, so I added a FIXME.
  • wtf/Platform.h: Define PLATFORM(SOLARIS) when "sun" or "sun" is defined.
11:34 AM Changeset in webkit [29453] by kevino@webkit.org
  • 8 edits in trunk/WebKit/wx

wxWebKit API changes in preparation for DRT implementation.

Reviewed by Darin Adler.

11:19 AM Changeset in webkit [29452] by Darin Adler
  • 10 edits in trunk/WebCore

Reviewed by Eric.

  • dom/Document.cpp: (WebCore::Document::setDomain): Removed unneeded call to copy. (WebCore::Document::parseQualifiedName): Removed unneeded call to copy, and unneeded length argument to substring, which stops at the end of the string if you don't specify a length. (WebCore::Document::createAttributeNS): Replaced code that was calling copy with more-efficient code using the substring function.
  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor): Removed unneeded call to copy.
  • editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand): Removed unneeded copy and also initialized text instead of assigning to it. (WebCore::InsertIntoTextNodeCommand::doApply): Removed redundant assertions. (WebCore::InsertIntoTextNodeCommand::doUnapply): Ditto.
  • editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Removed unneeded call to copy. This one was particularly bad since we just turned around and copied it again!
  • editing/markup.cpp: (WebCore::stringValueForRange): Removed unneeded call to copy.
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::performOpenInitialization): Changed logging code to not get the path from the database object. This was the only reason the database had to keep its path around.
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open): Use a local variable instead of a data member to convert the string to a null-terminated one. (WebCore::SQLiteDatabase::close): Removed the code to clear out m_path.
  • platform/sql/SQLiteDatabase.h: Removed the m_path data member and the path functio member. Also tweaked formatting and comments a bit. Removed the unused escapeSQLString function.
  • platform/text/String.cpp: (WebCore::operator+): Removed uneeded calls to copy.
9:24 AM Changeset in webkit [29451] by mitz@apple.com
  • 2 edits in trunk/WebKitTools
  • fix breakage due to last-minute change
  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Declare the loop variable.
9:15 AM Changeset in webkit [29450] by mitz@apple.com
  • 8 edits in trunk

WebKitTools:

Reviewed by Adam Roben.

  • fix <rdar://problem/5132009> Windows DRT does not support multiple windows
  • DumpRenderTree/win/DumpRenderTree.cpp: (DumpRenderTreeWndProc): (initialize): (dumpBackForwardList): (dumpBackForwardListForAllWindows): (dump): (resetWebViewToConsistentStateBeforeTesting): Factored out of runTest(). (runTest): (allWindows): Added. Returns a vector of all open windows. (windowToWebViewMap): Added. Returns a map from open windows to their WebViews. (createWebViewAndOffscreenWindow): Factored out of main() to be reusable for creating extra windows. (main):
  • DumpRenderTree/win/DumpRenderTreeWin.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::windowCount): Implemented.
  • DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::createWebViewWithRequest): Implemented. (UIDelegate::webViewClose): Implemented.
  • DumpRenderTree/win/UIDelegate.h:

LayoutTests:

Reviewed by Adam Roben.

  • enable tests affected by <rdar://problem/5132009> Windows DRT does not support multiple windows
  • platform/win/Skipped:
5:20 AM Changeset in webkit [29449] by oliver@apple.com
  • 2 edits in trunk/WebCore

Attempt to fix QT build

5:09 AM Changeset in webkit [29448] by oliver@apple.com
  • 3 edits in trunk/WebCore

Avoid repainting the entire canvas element when possible.

Reviewed by Mark Rowe.

We now only register the dirty regions of a canvas for repainting, rather
than the entire element (though repaint coalescing may choose to combine
these regions). This doesn't cause a measurable regression in the worst
case (clearing the canvas repeatedly), but is a moderate-large win if only
a minor update has occurred. If there is any CSS scaling applied to the
canvas almost any update short of clearing the entire element is substantially
faster.

3:08 AM Changeset in webkit [29447] by mrowe@apple.com
  • 13 edits in trunk

2008-01-13 Michael Goddard <​michael.goddard@trolltech.com>

Reviewed by Anders Carlsson.

Add binding language type to Instance.
Allows runtime determination of the type of an
Instance, to allow safe casting. Doesn't actually
add any safe casting yet, though.

Add a helper function to get an Instance from a JSObject*.
Given an object and the expected binding language, see if
the JSObject actually wraps an Instance of the given type
and return it. Otherwise return 0.

Move RuntimeObjectImp creations into Instance.
Make the ctor protected, and Instance a friend class, so
that all creation of RuntimeObjectImps goes through
one place.

Remove copy ctor/assignment operator for QtInstance.
Instance itself is Noncopyable, so QtInstance doesn't
need to have these.

Add caching for QtInstance and associated RuntimeObjectImps.
Push any dealings with QtLanguage bindings into QtInstance,
and cache them there, rather than in the Instance layer. Add
a QtRuntimeObjectImp to help with caching.

  • JavaScriptCore.exp:
  • bindings/c/c_instance.h:
  • bindings/jni/jni_instance.h:
  • bindings/objc/objc_instance.h:
  • bindings/qt/qt_instance.cpp: (KJS::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp): (KJS::Bindings::QtRuntimeObjectImp::~QtRuntimeObjectImp): (KJS::Bindings::QtRuntimeObjectImp::invalidate): (KJS::Bindings::QtRuntimeObjectImp::removeFromCache): (KJS::Bindings::QtInstance::QtInstance): (KJS::Bindings::QtInstance::~QtInstance): (KJS::Bindings::QtInstance::getQtInstance): (KJS::Bindings::QtInstance::getRuntimeObject):
  • bindings/qt/qt_instance.h: (KJS::Bindings::QtInstance::getBindingLanguage):
  • bindings/runtime.cpp: (KJS::Bindings::Instance::createBindingForLanguageInstance): (KJS::Bindings::Instance::createRuntimeObject): (KJS::Bindings::Instance::getInstance):
  • bindings/runtime.h:
  • bindings/runtime_object.h: (KJS::RuntimeObjectImp::getInternalInstance):

2008-01-13 Michael Goddard <​michael.goddard@trolltech.com>

Reviewed by Anders Carlsson.

Move RuntimeObjectImp creations into Instance.
Make the ctor protected, and Instance a friend class, so
that all creation of RuntimeObjectImps goes through
one place.

  • bindings/js/kjs_dom.cpp: (WebCore::getRuntimeObject):
2:20 AM BuildingGtk edited by lethalman88@gmail.com
Gentoo overlay for WebKit (diff)
12:51 AM Changeset in webkit [29446] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Change test to match the results landed in r29424. The test changes were
omitted in that check-in.

  • editing/pasteboard/paste-RTFD.html:

Jan 12, 2008:

11:33 PM Changeset in webkit [29445] by alp@webkit.org
  • 6 edits in trunk

2008-01-12 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Hide non-public symbols in GTK+/autotools release builds.

10:54 PM Changeset in webkit [29444] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix. Add WebCore/icu/include for Mac builds using only stock ICU.

8:52 PM Changeset in webkit [29443] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-01-12 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Mark Rowe.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=16852
Fixes leaking of ActivationStackNode objects.

  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::deleteActivationStack): (KJS::JSGlobalObject::~JSGlobalObject): (KJS::JSGlobalObject::init): (KJS::JSGlobalObject::reset):
  • kjs/JSGlobalObject.h:
1:23 PM QtWebKitContrib edited by staikos@webkit.org
(diff)
11:25 AM Changeset in webkit [29442] by mrowe@apple.com
  • 5 edits in trunk/WebCore

2008-01-12 Rodney Dawes <​dobey@wayofthemonkey.com>

Gtk debug build fix. Reviewed by Mark Rowe.

Add plugin logging channel, and use it rather than Win32-specific debugging methods _RPTF1 _RPTF2 and _CRT_WARN.

  • WebCore.pro: Add plugins directory to DEPENDPATH so dependencies are correctly tracked.
  • platform/Logging.cpp:
  • platform/Logging.h:
  • plugins/PluginDebug.h:
10:35 AM Changeset in webkit [29441] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Update expected results for fast/replaced/image-map-expected after
r29432 disabled document replacement by the JavaScript result in this
case.

  • fast/replaced/image-map-expected.txt:
10:19 AM Changeset in webkit [29440] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • try to fix Qt Windows build
  • pcre/dftables: Remove reliance on the list form of Perl pipes.
10:05 AM Changeset in webkit [29439] by Darin Adler
  • 3 edits in trunk/JavaScriptCore
  • try to fix Qt build
  • kjs/function.cpp: Added include of scope_chain_mark.h.
  • kjs/scope_chain_mark.h: Added multiple-include guards.
7:43 AM Changeset in webkit [29438] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Roll out r29435 as it introduces many, many crashes.

6:25 AM Changeset in webkit [29437] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-01-12 Mark Rowe <​mrowe@apple.com>

Another Windows build fix.

  • kjs/Activation.h:
6:12 AM Changeset in webkit [29436] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-01-12 Mark Rowe <​mrowe@apple.com>

Attempted Windows build fix. Use struct consistently when forward-declaring
ActivationStackNode and StackActivation.

  • kjs/Activation.h:
  • kjs/JSGlobalObject.h:
6:06 AM Changeset in webkit [29435] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-01-12 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Mark Rowe.

Fixes leaking of ActivationStackNode objects.

  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::deleteActivationStack): (KJS::JSGlobalObject::~JSGlobalObject): (KJS::JSGlobalObject::init): (KJS::JSGlobalObject::reset):
  • kjs/JSGlobalObject.h:
5:48 AM Changeset in webkit [29434] by zecke@webkit.org
  • 5 edits
    1 add in trunk
  • Make launching of the WebKit httpd work on GNU/Debian/Linux

The configuration of Apache2 and installation does not depend on
the kernel but on the distribution policy. Make launching of httpd
work for Debian derived distributions.

5:19 AM Changeset in webkit [29433] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.

Reviewed by Maciej Stachowiak.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to

match the callers expectations that it can take ownership of the string.

4:03 AM Changeset in webkit [29432] by mjs@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Maciej (and also tweaked a little bit).

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::executeIfJavaScriptURL):
  • loader/FrameLoader.h:
3:03 AM Changeset in webkit [29431] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Fixes a problem with the ActivationImp tear-off patch (r29425) where
some of the calls to JSGlobalObject::tearOffActivation() were using
the wrong test to determine whether it should leave a relic behind.

  • kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::ActivationImp::getOwnPropertySlot):
12:37 AM Changeset in webkit [29430] by mjs@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • fixed <rdar://problem/5556374> REGRESSION: cross-domain error when one URL uses an explicit port number and another doesn't


  • platform/SecurityOrigin.cpp: (WebCore::isDefaultPortForProtocol): (WebCore::SecurityOrigin::SecurityOrigin):
Note: See TracTimeline for information about the timeline view.