⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 14, 2008:

9:43 PM Changeset in webkit [29487] by eric@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by mjs.

Remove a couple more uses of DeprecatedString

No functional changes, thus no test case.

  • dom/Document.cpp: (WebCore::Document::write): (WebCore::Document::writeln): (WebCore::Document::recalcStyleSelector):
  • dom/Document.h:
9:41 PM Changeset in webkit [29486] by alp@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2008-01-14 Pierre-Luc Beaudoin <​pierre-luc.beaudoin@collabora.co.uk>

Reviewed by Alp Toker.

Build fix: missing symbols when compiling WebKit/Gtk+ with --enable-svg-filters
​http://bugs.webkit.org/show_bug.cgi?id=16874

  • GNUmakefile.am:
  • svg/graphics/cairo/SVGResourceFilterCairo.cpp: Added. (WebCore::SVGResourceFilter::createPlatformData): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
7:59 PM Changeset in webkit [29485] by Stephanie Lewis
  • 2 edits in trunk/WebKitTools

2008-01-14 Stephanie <Stephanie Lewis>

revert accidental character.

7:52 PM Changeset in webkit [29484] by Stephanie Lewis
  • 4 edits in trunk

2008-01-14 Stephanie <Stephanie Lewis>

RS=Oliver

add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>

  • Scripts/run-webkit-tests:

add svg/css/glyph-orientation-rounding-test.xhtml to skip list. See <rdar://problem/5686552>

  • platform/mac-leopard/Skipped:
5:31 PM Changeset in webkit [29483] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by hyatt & eseidel.

This patch fixes an issue with addLineBoxRects not correctly calculating the
rects due to an off-by-one error in using box->end(). We were assuming that
end() gives the index past the last character, when in fact it gives the
index _of_ the last character.

Eric Seidel and I could not find a way to test this via DRT. This method is
only used by WebKit or Safari for displaying selection rects AFAICT.

  • rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):
5:03 PM Changeset in webkit [29482] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • fix crash seen in layout tests
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::attach): Remove incorrect cast to HTMLElement* for parentNode(). The parent is either an HTMLElement or a Document, not necessarily an HTMLElement.
2:51 PM Changeset in webkit [29481] by Darin Adler
  • 14 edits
    1 add in trunk/WebCore

Reviewed by Sam.

  • fix mistakes Sam noticed in my re-speed-up patch
  • dom/Element.cpp: (WebCore::Element::virtualHasTagName): Moved out of header file. No reason to make this inline.
  • dom/Element.h: Moved virtualHasTagName out of header file.
  • dom/Node.cpp: (WebCore::Node::virtualHasTagName): Moved out of header file. No reason to make this inline.
  • dom/Node.h: Removed incorrect "virtual" on hasTagName and moved virtualHasTagName out of header file.
  • platform/text/StringBuffer.h: Added. Has just the new StringBuffer class.
  • platform/text/StringImpl.h: Removed StringBuffer class.
  • loader/DocumentLoader.cpp: Added StringBuffer.h include.
  • platform/text/String.cpp: Ditto.
  • platform/text/StringImpl.cpp: Ditto.
  • platform/text/TextCodecLatin1.cpp: Ditto.
  • platform/text/TextCodecUTF16.cpp: Ditto.
  • platform/text/TextCodecUserDefined.cpp: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Added StringBuffer.h.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
2:35 PM Changeset in webkit [29480] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Queue up another rename.
1:05 PM Changeset in webkit [29479] by hyatt@apple.com
  • 2 edits
    3 moves in trunk/WebCore

Clean up VS project file after graphics files moved.

12:13 PM Changeset in webkit [29478] by ggaren@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Sam Weinig.


Some cleanup to my last patch.

Removed one unused setter declaration and one unused setter definition.


Renamed DoNotCheckDomainSecurityOnRead to DoNotCheckDomainSecurityOnGet
because "get" is all over the IDL files, and "read" is not.

  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.h: (WebCore::DOMWindow::defaultstatus):
  • page/DOMWindow.idl:
11:26 AM Changeset in webkit [29477] by mitz@apple.com
  • 2 edits in trunk/WebCore

Rubber-stamped by Alice Liu.

  • remove reference to nonexistent file
  • WebCore.vcproj/WebCore.vcproj: Removed reference to SVGFont.h.
11:25 AM Changeset in webkit [29476] by ddkilzer@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix date; restore '<'.

11:11 AM Changeset in webkit [29475] by Adam Roben
  • 2 edits in trunk/JavaScriptCore
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added some headers that were missing from the vcproj so their contents will be included in Find in Files.
11:02 AM Changeset in webkit [29474] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Fix Bug 16871: Crash when loading apple.com/startpage

<​http://bugs.webkit.org/show_bug.cgi?id=16871>
<rdar://problem/5686670>

Patch written by Darin, reviewed by me.

  • kjs/ExecState.cpp: (KJS::ExecState::mark): Call ActivationImp::markChildren if our m_activation is on the stack. This is what ScopeChain::mark also does, but apparently in some cases it's possible for an ExecState's ActivationImp to not be in any ScopeChain.
10:38 AM Changeset in webkit [29473] by zecke@webkit.org
  • 2 edits in trunk/WebKitTools
10:28 AM Changeset in webkit [29472] by kmccullough@apple.com
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Oliver.

-<rdar://problem/5622667> REGRESSION (Leopard-ToT): Endless loading loop
trying to view techreport.com comments

  • We need to set values in the map, because if they are already in the map they will not be reset when we use add().
  • kjs/array_instance.cpp: (KJS::ArrayInstance::put):

LayoutTests:

Reviewed by Oliver.

  • <rdar://problem/5622667> REGRESSION (Leopard-ToT): Endless loading loop trying to view techreport.com comments
  • Any resetting of a value in an array of sufficient size, would cause the second value to be lost.
  • fast/js/array-reset-large-index-expected.txt: Added.
  • fast/js/array-reset-large-index.html: Added.
  • fast/js/resources/array-reset-large-index.js: Added.
10:24 AM Changeset in webkit [29471] by zecke@webkit.org
  • 2 edits in trunk/WebKitTools
9:51 AM Changeset in webkit [29470] by Darin Adler
  • 40 edits in trunk

JavaScriptCore:

Reviewed by Adam.

  • re-speed-up the page load test (my StringImpl change slowed it down)
  • wtf/RefCounted.h: (WTF::RefCounted::RefCounted): Allow derived classes to start with a reference count other than 0. Eventually everyone will want to start with a 1. This is a staged change. For now, there's a default of 0, and you can specify 1. Later, there will be no default and everyone will have to specify. And then later, there will be a default of 1. Eventually, we can take away even the option of starting with 0!
  • wtf/Vector.h: (WTF::Vector::Vector): Sped up creation of non-empty vectors by removing the overhead of first constructing something empty and then calling resize. (WTF::Vector::clear): Sped up the common case of calling clear on an empty vector by adding a check for that case. (WTF::Vector::releaseBuffer): Marked this function inline and removed a branch in the case of vectors with no inline capacity (normal vectors) by leaving out the code to copy the inline buffer in that case.

WebCore:

Reviewed by Adam.

  • re-speed-up the page load test (my StringImpl change slowed it down) <rdar://problem/5677241> 1.5% PLT regression from r29098

To reverse the slowdown I caused by changing StringImpl, I tightened it up,
and also did a little optimization in the HTML tokenizer and in other clients
of Vector.

  • WebCore.base.exp: Removed export of a now-inline function.
  • css/CSSParser.cpp: (WebCore::CSSParser::parseTransitionProperty): Removed use of DeprecatedString to get property ID. This could be sped up even more by writing a fast path to use a local Vector<char> rather than allocating a string. (WebCore::convertASCIIToFloat): Added. Allows numeric conversion without allocating a string object to hold the number. (WebCore::CSSParser::lex): Changed to call convertASCIIToFloat instead of DeprecatedString::toFloat.
  • dom/Element.h: (WebCore::Element::hasTagName): Made this non-virtual and inline if you have an Element*. It's still virtual if you have a Node*. (WebCore::Element::virtualHasTagName): Virtual version that makes the Node* case work.
  • dom/Node.h: (WebCore::Node::hasTagName): Made this non-virtual and inline so that Element can override it with an inline. This is the same technique we use for firstChild and lastChild. (WebCore::Node::virtualHasTagName): This is the private virtual that Element overrides.
  • dom/Text.cpp: (WebCore::Text::splitText): Clean up by using a RefPtr here instead of a PassRefPtr.
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): Use the new advancePastNonNewline(), which is more efficient in cases where we know the character is not a newline and hence we don't have to update the line number. (WebCore::HTMLTokenizer::parseComment): Ditto. (WebCore::HTMLTokenizer::parseServer): Ditto. (WebCore::HTMLTokenizer::parseProcessingInstruction): Ditto. (WebCore::HTMLTokenizer::parseText): Ditto. (WebCore::HTMLTokenizer::parseEntity): Ditto. (WebCore::HTMLTokenizer::parseTag): Ditto. Also streamline the QuotedValue case so there's one less branch taken for non-punctuation characters since this code path is *so* hot. (WebCore::HTMLTokenizer::write): More of the same.
  • loader/Cache.cpp: (WebCore::Cache::lruListFor): Use Vector::grow instead of resize.
  • loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle): Use StringBuffer instead of Vector<UChar>.
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForCSSCharset): Use Vector::grow instead of resize. (WebCore::TextResourceDecoder::checkForHeadCharset): Ditto. (WebCore::TextResourceDecoder::decode): Use Vector::grow and shrink instead of resize. (WebCore::TextResourceDecoder::flush): Use Vector::shrink instead of resize.
  • platform/KURL.cpp: (WebCore::KURL::decode_string): Use Vector::grow instead of resize.
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::clear): Use Vector::shrink instead of resize.
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::cacheFrame): Use Vector::grow instead of resize.
  • platform/network/FormData.cpp: (WebCore::FormData::appendData): Use Vector::grow instead of resize. (WebCore::FormData::flatten): Ditto.
  • platform/text/AtomicString.cpp: (WebCore::CStringTranslator::translate): Use a new StringImpl constructor made just for use by AtomicString. Avoids setting fields twice, and also preserves reference count behavior (which I changed for the other constructors, since they're entirely private and used only inside the class). (WebCore::UCharBufferTranslator::translate): Ditto.
  • platform/text/Base64.cpp: (WebCore::base64Encode): Use Vector::grow instead of resize. (WebCore::base64Decode): Use Vector::grow and shrink instead of resize.
  • platform/text/PlatformString.h: (WebCore::String::adopt): Added an overload for the new StringBuffer class. Also made both versions inline.
  • platform/text/SegmentedString.h: (WebCore::SegmentedString::advancePastNewline): Added. One less branch for case where the character is known to be a newline. (WebCore::SegmentedString::advancePastNonNewline): Added. Less code for case where the character is known not to be a newline.
  • platform/text/String.cpp: (WebCore::String::append): Use StringBuffer instead of Vector<UChar>. (WebCore::String::insert): Ditto. (WebCore::String::truncate): Ditto. (WebCore::String::remove): Ditto. (WebCore::String::format): Use Vector::grow instead of resize.
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Changed constructors to start with a refCount of 1 instead of 0, and made them all inline. Eliminates the WithOneRef constructor since they all behave this way now. The only exceptions are the constructors for AtomicString, which retain the old behavior. (WebCore::StringImpl::empty): Simplified, since we no longer need to use the special WithOneRef constructor. (WebCore::StringImpl::toCoordsArray): Use StringBuffer instead of Vector<UChar>. (WebCore::StringImpl::lower): Ditto. (WebCore::StringImpl::upper): Ditto. (WebCore::StringImpl::secure): Ditto. (WebCore::StringImpl::foldCase): Ditto. (WebCore::StringImpl::simplifyWhiteSpace): Ditto. Also change to use Vector::shrink instead of resize (since half of the function uses Vector<UChar>). (WebCore::StringImpl::capitalize): Use StringBuffer instead of Vector<UChar>. (WebCore::StringImpl::replace): Ditto. (WebCore::StringImpl::ascii): Streamlined a bit. (WebCore::StringImpl::createStrippingNullCharacters): Use StringBuffer insetad of Vector<UChar>. Took out checks for null characters and 0 length that aren't needed. Coded the check for null characters in a slightly more efficient way. Since this is so hot, didn't call adopt at all, putting the code right in here, including the call to the StringImpl constructor and adoptRef (for the fast case). (WebCore::StringImpl::adopt): Added a version for the new StringBuffer class. Removed the attempt to resize the buffer at the time we adopt based on measuring actual use and realizing that it's just a character here or there and not worth a call to fastRealloc. Changed to use adoptRef since the constructor now starts with a refCount of 1. (WebCore::StringImpl::create): Changed to use adoptRef since the constructor now starts with a refCount of 1. (WebCore::StringImpl::createWithTerminatingNullCharacter): Ditto. (WebCore::StringImpl::copy): Ditto. Also made non-inline since the constructor itself is now inline.
  • platform/text/StringImpl.h: Added a StringBuffer class that's useful for putting characters into a buffer before creating an immutable string. Not good at resizing the way Vector<UChar> is, so only useful for things that rarely need to be resized. Added a new AdoptBuffer constructor and empty constructor, but made all constructors private so they can be inlined and only used inside the StringImpl class. Added two new constructors for AtomicString. Made copy() no longer inline. Changed the type of the [] operator to unsigned instead of int and added an assertion. Made the hash functions inline.
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::encode): Use Vector::grow instead of resize.
  • platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode): Use StringBuffer instead of Vector<UChar>. (WebCore::encodeComplexWindowsLatin1): Use Vector::grow instead of resize.
  • platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::decode): Use StringBuffer instead of Vector<UChar>.
  • platform/text/TextCodecUserDefined.cpp: (WebCore::TextCodecUserDefined::decode): Use StringBuffer instead of Vector<UChar>. (WebCore::encodeComplexUserDefined): Use Vector::grow instead of resize.
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode): Use Vector::grow instead of resize.
  • platform/text/TextStream.cpp: (WebCore::TextStream::operator<<): Use Vector::grow instead of resize.
  • platform/text/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::encode): Use Vector::grow instead of resize.
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::insertSpanCell): Use Vector::grow instead of resize.
  • rendering/RenderFrameSet.h: (WebCore::FrameEdgeInfo::FrameEdgeInfo): Allocate vectors with the correct initial size instead of calling resize on them after allocating empty.
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): Use Vector::grow instead of resize.
  • rendering/RenderStyle.cpp: Removed CursorList::operator==.
  • rendering/RenderStyle.h: (WebCore::CursorList::operator==): Implemented using the Vector ==. (WebCore::CursorList::operator!=): Ditto.
  • rendering/RenderTable.cpp: (WebCore::RenderTable::splitColumn): Use Vector::grow instead of resize. (WebCore::RenderTable::appendColumn): Ditto.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::ensureRows): Use Vector::grow instead of resize.
  • rendering/bidi.cpp: (WebCore::addMidpoint): Use Vector::grow instead of resize.
  • xml/XPathNodeSet.h: (WebCore::XPath::NodeSet::clear): Use Vector::shrink instead of resize.
9:47 AM Changeset in webkit [29469] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: More ignore list tweaking.
9:45 AM Changeset in webkit [29468] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Add another leak to the ignore list.
9:03 AM Changeset in webkit [29467] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Fixed a typo pointed out by Alexey.
8:44 AM Changeset in webkit [29466] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added some intermittent failures.
8:35 AM Changeset in webkit [29465] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Put back a failing test.
7:39 AM Changeset in webkit [29464] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

  • try to fix failure in fast/dom/Window/window-onFocus.html seen on the build bots
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
7:36 AM Changeset in webkit [29463] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Re-added two tests that weren't failing for me, but fail on the buildbot.

  • platform/win/Skipped:
7:20 AM Changeset in webkit [29462] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Added fast/frames/frame-name-reset.html, which crashes, and sometimes freezes buildbot.

  • platform/win/Skipped:
6:15 AM Changeset in webkit [29461] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Removed some more tests, moved one to a better place.

  • platform/win/Skipped:
4:33 AM Changeset in webkit [29460] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Remove a test that doesn't fail for me - let's see what the bot thinks.

  • platform/win/Skipped: Removed http/tests/xmlhttprequest/XMLHttpRequestException.html.
1:12 AM Changeset in webkit [29459] by ap@webkit.org
  • 3 edits
    3 adds in trunk

Reviewed by David Kilzer.

​http://bugs.webkit.org/show_bug.cgi?id=16787
array.splice() with 1 element not working

Test: fast/js/array-splice.html

  • kjs/array_object.cpp: (KJS::ArrayProtoFuncSplice::callAsFunction): Implement this Mozilla extension, and fix some other edge cases.

Jan 13, 2008:

10:05 PM Changeset in webkit [29458] by sfalken@apple.com
  • 19 edits
    1 move
    4 adds
    23 deletes in trunk

JavaScriptCore:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Reviewed by Adam Roben.

WebCore:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

Reviewed by Adam Roben.

  • WebCore.vcproj/PRODUCTVERSION: Removed.
  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/VERSION: Removed.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/auto-version.sh: Removed.
  • WebCore.vcproj/debug.vsprops: Removed.
  • WebCore.vcproj/debug_internal.vsprops: Removed.
  • WebCore.vcproj/release.vsprops: Removed.

WebKit/win:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

Reviewed by Adam Roben.

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/PRODUCTVERSION: Removed.
  • WebKit.vcproj/VERSION: Removed.
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebKit.vcproj/auto-version.sh: Removed.
  • WebKit.vcproj/debug.vsprops: Removed.
  • WebKit.vcproj/debug_internal.vsprops: Removed.
  • WebKit.vcproj/release.vsprops: Removed.

WebKitLibraries:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Moved auto-version.sh, VERSION, PRODUCTVERSION to tools.

Reviewed by Adam Roben.

  • win/tools/WinTools.make:
  • win/tools/scripts: Added.
  • win/tools/scripts/PRODUCTVERSION: Added.
  • win/tools/scripts/VERSION: Added.
  • win/tools/scripts/auto-version.sh: Copied from WebCore/WebCore.vcproj/auto-version.sh.
  • win/tools/vsprops/debug.vsprops:
  • win/tools/vsprops/debug_internal.vsprops: Added.
  • win/tools/vsprops/release.vsprops:

WebKitTools:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

Reviewed by Adam Roben.

  • Drosera/win/Drosera.vcproj/Drosera.vcproj:
  • Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
  • Drosera/win/Drosera.vcproj/VERSION: Removed.
  • Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
  • Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
  • Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
  • Drosera/win/Drosera.vcproj/release.vsprops: Removed.
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/debug.vsprops: Removed.
  • DumpRenderTree/win/debug_internal.vsprops: Removed.
  • DumpRenderTree/win/release.vsprops: Removed.
8:40 PM Changeset in webkit [29457] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::destroy): Removed the call to RenderLayer::destroy() from here, because ~RenderLayer() calls RenderObject() methods.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Added the call to RenderLayer::destroy() here.
5:35 PM Changeset in webkit [29456] by eric@webkit.org
  • 3 edits
    6 adds in trunk

Reviewed by darin.

Range.insertNode does not update endContainer endIndex correctly
in the case where it had to split a text node.
​http://bugs.webkit.org/show_bug.cgi?id=16765

Darin pointed out during review that we still don't handle the dynamic
range case (where the dom tree changes not using range methods)
Thus this code will get ripped out when we add that. The test cases
are still valid and useful however, so I'm landing this as-is.

Tests: fast/dom/Range/range-insertNode-separate-endContainer.html

fast/dom/Range/range-insertNode-splittext.html

  • dom/Range.cpp: (WebCore::Range::insertNode): handle the splitText case correctly.
11:54 AM Changeset in webkit [29455] by Darin Adler
  • 2 edits
    3 adds in trunk/WebKitTools

Reviewed by Maciej.

  • Scripts/gdb-drosera: Added.
  • Scripts/run-drosera: Added.
  • Scripts/run-drosera-nightly.cmd: Added.
  • Scripts/webkitdirs.pm: Added runDrosera function.
11:47 AM Changeset in webkit [29454] by Darin Adler
  • 5 edits in trunk/JavaScriptCore

Contributions and review by Adriaan de Groot,
Simon Hausmann, Eric Seidel, and Darin Adler.

  • kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime): Use the WIN_OS code path for SOLARIS too, presumably because Solaris also lacks the tm_gtoff and tm_zone fields. (KJS::GregorianDateTime::operator tm): Ditto.
  • kjs/collector.cpp: (KJS::currentThreadStackBase): Use thr_stksegment on Solaris.
  • wtf/MathExtras.h: (isfinite): Implement for Solaris. (isinf): Ditto. (signbit): Ditto. But this one is wrong, so I added a FIXME.
  • wtf/Platform.h: Define PLATFORM(SOLARIS) when "sun" or "sun" is defined.
11:34 AM Changeset in webkit [29453] by kevino@webkit.org
  • 8 edits in trunk/WebKit/wx

wxWebKit API changes in preparation for DRT implementation.

Reviewed by Darin Adler.

11:19 AM Changeset in webkit [29452] by Darin Adler
  • 10 edits in trunk/WebCore

Reviewed by Eric.

  • dom/Document.cpp: (WebCore::Document::setDomain): Removed unneeded call to copy. (WebCore::Document::parseQualifiedName): Removed unneeded call to copy, and unneeded length argument to substring, which stops at the end of the string if you don't specify a length. (WebCore::Document::createAttributeNS): Replaced code that was calling copy with more-efficient code using the substring function.
  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor): Removed unneeded call to copy.
  • editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand): Removed unneeded copy and also initialized text instead of assigning to it. (WebCore::InsertIntoTextNodeCommand::doApply): Removed redundant assertions. (WebCore::InsertIntoTextNodeCommand::doUnapply): Ditto.
  • editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Removed unneeded call to copy. This one was particularly bad since we just turned around and copied it again!
  • editing/markup.cpp: (WebCore::stringValueForRange): Removed unneeded call to copy.
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::performOpenInitialization): Changed logging code to not get the path from the database object. This was the only reason the database had to keep its path around.
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open): Use a local variable instead of a data member to convert the string to a null-terminated one. (WebCore::SQLiteDatabase::close): Removed the code to clear out m_path.
  • platform/sql/SQLiteDatabase.h: Removed the m_path data member and the path functio member. Also tweaked formatting and comments a bit. Removed the unused escapeSQLString function.
  • platform/text/String.cpp: (WebCore::operator+): Removed uneeded calls to copy.
9:24 AM Changeset in webkit [29451] by mitz@apple.com
  • 2 edits in trunk/WebKitTools
  • fix breakage due to last-minute change
  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Declare the loop variable.
9:15 AM Changeset in webkit [29450] by mitz@apple.com
  • 8 edits in trunk

WebKitTools:

Reviewed by Adam Roben.

  • fix <rdar://problem/5132009> Windows DRT does not support multiple windows
  • DumpRenderTree/win/DumpRenderTree.cpp: (DumpRenderTreeWndProc): (initialize): (dumpBackForwardList): (dumpBackForwardListForAllWindows): (dump): (resetWebViewToConsistentStateBeforeTesting): Factored out of runTest(). (runTest): (allWindows): Added. Returns a vector of all open windows. (windowToWebViewMap): Added. Returns a map from open windows to their WebViews. (createWebViewAndOffscreenWindow): Factored out of main() to be reusable for creating extra windows. (main):
  • DumpRenderTree/win/DumpRenderTreeWin.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::windowCount): Implemented.
  • DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::createWebViewWithRequest): Implemented. (UIDelegate::webViewClose): Implemented.
  • DumpRenderTree/win/UIDelegate.h:

LayoutTests:

Reviewed by Adam Roben.

  • enable tests affected by <rdar://problem/5132009> Windows DRT does not support multiple windows
  • platform/win/Skipped:
5:20 AM Changeset in webkit [29449] by oliver@apple.com
  • 2 edits in trunk/WebCore

Attempt to fix QT build

5:09 AM Changeset in webkit [29448] by oliver@apple.com
  • 3 edits in trunk/WebCore

Avoid repainting the entire canvas element when possible.

Reviewed by Mark Rowe.

We now only register the dirty regions of a canvas for repainting, rather
than the entire element (though repaint coalescing may choose to combine
these regions). This doesn't cause a measurable regression in the worst
case (clearing the canvas repeatedly), but is a moderate-large win if only
a minor update has occurred. If there is any CSS scaling applied to the
canvas almost any update short of clearing the entire element is substantially
faster.

3:08 AM Changeset in webkit [29447] by mrowe@apple.com
  • 13 edits in trunk

2008-01-13 Michael Goddard <​michael.goddard@trolltech.com>

Reviewed by Anders Carlsson.

Add binding language type to Instance.
Allows runtime determination of the type of an
Instance, to allow safe casting. Doesn't actually
add any safe casting yet, though.

Add a helper function to get an Instance from a JSObject*.
Given an object and the expected binding language, see if
the JSObject actually wraps an Instance of the given type
and return it. Otherwise return 0.

Move RuntimeObjectImp creations into Instance.
Make the ctor protected, and Instance a friend class, so
that all creation of RuntimeObjectImps goes through
one place.

Remove copy ctor/assignment operator for QtInstance.
Instance itself is Noncopyable, so QtInstance doesn't
need to have these.

Add caching for QtInstance and associated RuntimeObjectImps.
Push any dealings with QtLanguage bindings into QtInstance,
and cache them there, rather than in the Instance layer. Add
a QtRuntimeObjectImp to help with caching.

  • JavaScriptCore.exp:
  • bindings/c/c_instance.h:
  • bindings/jni/jni_instance.h:
  • bindings/objc/objc_instance.h:
  • bindings/qt/qt_instance.cpp: (KJS::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp): (KJS::Bindings::QtRuntimeObjectImp::~QtRuntimeObjectImp): (KJS::Bindings::QtRuntimeObjectImp::invalidate): (KJS::Bindings::QtRuntimeObjectImp::removeFromCache): (KJS::Bindings::QtInstance::QtInstance): (KJS::Bindings::QtInstance::~QtInstance): (KJS::Bindings::QtInstance::getQtInstance): (KJS::Bindings::QtInstance::getRuntimeObject):
  • bindings/qt/qt_instance.h: (KJS::Bindings::QtInstance::getBindingLanguage):
  • bindings/runtime.cpp: (KJS::Bindings::Instance::createBindingForLanguageInstance): (KJS::Bindings::Instance::createRuntimeObject): (KJS::Bindings::Instance::getInstance):
  • bindings/runtime.h:
  • bindings/runtime_object.h: (KJS::RuntimeObjectImp::getInternalInstance):

2008-01-13 Michael Goddard <​michael.goddard@trolltech.com>

Reviewed by Anders Carlsson.

Move RuntimeObjectImp creations into Instance.
Make the ctor protected, and Instance a friend class, so
that all creation of RuntimeObjectImps goes through
one place.

  • bindings/js/kjs_dom.cpp: (WebCore::getRuntimeObject):
2:20 AM BuildingGtk edited by lethalman88@gmail.com
Gentoo overlay for WebKit (diff)
12:51 AM Changeset in webkit [29446] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Change test to match the results landed in r29424. The test changes were
omitted in that check-in.

  • editing/pasteboard/paste-RTFD.html:
Note: See TracTimeline for information about the timeline view.