⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 17, 2008:

8:05 PM Changeset in webkit [29603] by ggaren@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixed: lots of WebCore leaks reported when quitting Safari


If we're quitting with a GC still scheduled, do the GC before quitting.
That way, WebCore's leak counters won't count objects that were
scheduled for GC.

  • bindings/js/GCController.cpp: (WebCore::GCController::~GCController): (WebCore::GCController::garbageCollectNow):
  • bindings/js/GCController.h:
7:29 PM Changeset in webkit [29602] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-17 Alp Toker <​alp@atoker.com>

Reviewed by Oliver Hunt.

gdk_screen_get_font_options() returns NULL if no default options are
set so we always have to NULL check to avoid crashes later on since
Cairo doesn't accept NULL font options.

  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
5:58 PM Changeset in webkit [29601] by Antti Koivisto
  • 6 edits in trunk

Reviewed by Adele.

Windows fix for <rdar://problem/5605682>
Disallow streaming protocols for media elements
and <rdar://problem/5668711>
Limit the container and codec types that the <video> tag supports


  • Disable unsupported QuickTime tracks types.
  • Disallow streaming protocols (for now).
5:14 PM Changeset in webkit [29600] by sfalken@apple.com
  • 4 edits in trunk

WebKit/win:

Build fix.

  • WebKit.vcproj/WebKit.make:

WebKitTools:

Build fix.

  • Drosera/DroseraWin.make:
5:14 PM Changeset in webkit [29599] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

2008-01-17 Stephanie <Stephanie Lewis>

RS=Adam


Move some new failing tests to the skipped list

  • platform/win/Skipped:
4:34 PM Changeset in webkit [29598] by sfalken@apple.com
  • 2 edits in trunk/WebKitSite

Added Vista crash logging information.


Reviewed by Adam.

  • quality/crashlogs.html:
4:21 PM Changeset in webkit [29597] by oliver@apple.com
  • 5 edits in trunk/WebCore

Support smart copy and paste during drag and drop

Reviewed by Alice

In order for the drag and drop tests in Windows DRT to pass
we need to support smart cut and paste operations during
drag and drop on windows.

There is no layout test as drag and drop is still unsupported
on windows. Once supported smart drag/drop is tested by existing
tests

4:10 PM Changeset in webkit [29596] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin


  • fixed <rdar://problem/5692068> -1 WebFrameView world leaks reported after closing view source window
  • WebView/WebFrameView.mm: (-[WebFrameView initWithCoder:]): override to bump the global WebFrameView count
3:58 PM Changeset in webkit [29595] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Fixed a bug number.
1:33 PM Changeset in webkit [29594] by oliver@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/5692940> Crash when attempting to get text properties in SVG with no renderer

Reviewed by Anders

We use the element renderer to calculate the text element bounds,
however there was no check against the possibility of the text dimension
properties being requested on a element with no renderer (eg. unattached,
display: none).

1:05 PM Changeset in webkit [29593] by andersca@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5636742>
CrashTracer: [USER] 1302 crashes in Safari at com.apple.WebCore: WTF::Vector<char, 0ul>::reserveCapacity + 78


When loading full-frame plug-ins, disable buffering data for the main resource loader. Otherwise, this can cause us
to crash when loading large files such as movies in the browser. We already do this for embedded plug-ins.


  • WebCore.base.exp:
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::mainResourceLoader): New accessor method.


  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData): Disable buffering for the main resource loader.


  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::setShouldBufferData):
  • loader/ResourceLoader.h: Have this free the buffer when disabling buffering.
12:45 PM Changeset in webkit [29592] by Antti Koivisto
  • 2 edits in trunk/JavaScriptCore

Fix Windows build.

  • kjs/regexp_object.cpp: (KJS::regExpProtoFuncToString):
12:39 PM Changeset in webkit [29591] by Adam Roben
  • 3 edits in trunk/WebCore

More Qt/GTK+ build fixing.

  • platform/gtk/ScrollViewGtk.cpp:
  • platform/qt/ScrollViewQt.cpp:
12:06 PM Changeset in webkit [29590] by ap@webkit.org
  • 5 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=16902
<rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html fails when run after
fast/dom/Window/window-property-shadowing.html

Test: fast/dom/Window/window-property-shadowing_.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Clear the frame name, too.
11:50 AM Changeset in webkit [29589] by ap@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=16908
run-webkit-tests complains about missing FindSafari.exe

  • Scripts/webkitdirs.pm: Append _debug as appropriate.
11:27 AM Changeset in webkit [29588] by weinig@apple.com
  • 17 edits in trunk/JavaScriptCore

Reviewed by Darin.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16901
Convert remaining JS function objects to use the new PrototypeFunction class

  • Moves Boolean, Function, RegExp, Number, Object and Global functions to their own static function implementations so that they can be used with the PrototypeFunction class. SunSpider says this is 1.003x as fast.
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset):
  • kjs/array_object.h:
  • kjs/bool_object.cpp: (KJS::BooleanInstance::BooleanInstance): (KJS::BooleanPrototype::BooleanPrototype): (KJS::booleanProtoFuncToString): (KJS::booleanProtoFuncValueOf): (KJS::BooleanObjectImp::BooleanObjectImp): (KJS::BooleanObjectImp::implementsConstruct): (KJS::BooleanObjectImp::construct): (KJS::BooleanObjectImp::callAsFunction):
  • kjs/bool_object.h: (KJS::BooleanInstance::classInfo):
  • kjs/error_object.cpp: (KJS::ErrorPrototype::ErrorPrototype): (KJS::errorProtoFuncToString):
  • kjs/error_object.h:
  • kjs/function.cpp: (KJS::globalFuncEval): (KJS::globalFuncParseInt): (KJS::globalFuncParseFloat): (KJS::globalFuncIsNaN): (KJS::globalFuncIsFinite): (KJS::globalFuncDecodeURI): (KJS::globalFuncDecodeURIComponent): (KJS::globalFuncEncodeURI): (KJS::globalFuncEncodeURIComponent): (KJS::globalFuncEscape): (KJS::globalFuncUnEscape): (KJS::globalFuncKJSPrint): (KJS::PrototypeFunction::PrototypeFunction):
  • kjs/function.h:
  • kjs/function_object.cpp: (KJS::FunctionPrototype::FunctionPrototype): (KJS::functionProtoFuncToString): (KJS::functionProtoFuncApply): (KJS::functionProtoFuncCall):
  • kjs/function_object.h:
  • kjs/number_object.cpp: (KJS::NumberPrototype::NumberPrototype): (KJS::numberProtoFuncToString): (KJS::numberProtoFuncToLocaleString): (KJS::numberProtoFuncValueOf): (KJS::numberProtoFuncToFixed): (KJS::numberProtoFuncToExponential): (KJS::numberProtoFuncToPrecision):
  • kjs/number_object.h: (KJS::NumberInstance::classInfo): (KJS::NumberObjectImp::classInfo): (KJS::NumberObjectImp::):
  • kjs/object_object.cpp: (KJS::ObjectPrototype::ObjectPrototype): (KJS::objectProtoFuncValueOf): (KJS::objectProtoFuncHasOwnProperty): (KJS::objectProtoFuncIsPrototypeOf): (KJS::objectProtoFuncDefineGetter): (KJS::objectProtoFuncDefineSetter): (KJS::objectProtoFuncLookupGetter): (KJS::objectProtoFuncLookupSetter): (KJS::objectProtoFuncPropertyIsEnumerable): (KJS::objectProtoFuncToLocaleString): (KJS::objectProtoFuncToString):
  • kjs/object_object.h:
  • kjs/regexp_object.cpp: (KJS::RegExpPrototype::RegExpPrototype): (KJS::regExpProtoFuncTest): (KJS::regExpProtoFuncExec): (KJS::regExpProtoFuncCompile): (KJS::regExpProtoFuncToString):
  • kjs/regexp_object.h:
11:23 AM Changeset in webkit [29587] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Name the test for a recent bug fix.

11:06 AM Changeset in webkit [29586] by Adam Roben
  • 3 edits in trunk/WebCore

Qt/GTK+ build fix.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::ScrollViewPrivate::isActive):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::isActive):
10:55 AM Changeset in webkit [29585] by mitz@apple.com
  • 22 edits
    2 adds in trunk/LayoutTests

Reviewed by Dave Hyatt.

  • make more test pass on Windows by using @font-face to force font fallback to match Mac OS X.
  • editing/deleting/5144139-2.html:
  • fast/encoding/invalid-UTF-8.html:
  • fast/events/updateLayoutForHitTest.html:
  • fast/forms/select-visual-hebrew.html:
  • fast/forms/select-writing-direction-natural.html:
  • fast/forms/visual-hebrew-text-field.html:
  • fast/text/in-rendered-text-rtl.html:
  • fast/text/international/bidi-L2-run-reordering.html:
  • fast/text/international/bidi-LDB-2-CSS.html:
  • fast/text/international/bidi-LDB-2-HTML.html:
  • fast/text/international/bidi-LDB-2-formatting-characters.html:
  • fast/text/international/bidi-european-terminators.html:
  • fast/text/international/bidi-ignored-for-first-child-inline.html:
  • fast/text/international/bidi-innertext.html:
  • fast/text/international/bidi-listbox-atsui.html:
  • fast/text/international/bidi-listbox.html:
  • fast/text/international/bidi-menulist.html:
  • fast/text/international/bidi-override.html:
  • fast/text/international/resources: Added.
  • fast/text/international/resources/Mac-compatible-font-fallback.css: Added.
  • fast/text/international/rtl-caret.html:
  • platform/mac/editing/deleting/5144139-2-expected.txt:
  • platform/win/Skipped:
9:46 AM Changeset in webkit [29584] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added another failure.
9:46 AM Changeset in webkit [29583] by Adam Roben
  • 4 edits in trunk/WebKit/win

Trigger activation changes at the right time by listening for WM_NCACTIVATE

This is the final part of <rdar://5006915> Inactive look for Aqua
controls

WebView now listens to messages sent to its top-level parent window.
When the top-level parent receives a WM_NCACTIVATE message, WebView
recalculates whether it is contained within the current active window.

Reviewed by Darin.

  • Interfaces/IWebViewPrivate.idl: (IWebViewPrivate::windowAncestryDidChange): Added. WebKit clients should call this when they change the parent window chain of a WebView.
  • WebView.cpp: (WebView::WebView): Initialize new member. (findTopLevelParent): Added. (WebViewWndProc):
    • Separated activation handling from focus handling, now that activation handling is taken care of by updateActiveState exclusively.
    • Compare top-level parents in our WM_KILLFOCUS handler so that we really know if focus is staying inside our top-level window.
    • Update our active state on WM_WINDOWPOSCHANGED.
    • Added a WM_TIMER handler.

(WebView::initWithFrame): Call windowAncestryDidChange after setting
up our HWND as a child of the host window.
(WebView::windowReceivedMessage): Added. Update our active state when
our top-level parent receives a WM_NCACTIVATE message.
(WebView::updateActiveStateSoon): Added.
(WebView::setHostWindow): Call windowAncestryDidChange after changing
the host window.
(WebView::updateActiveState): We are active if our top-level parent is
the same as the top-level parent of the active window.
(WebView::windowAncestryDidChange): Added. Recalculates our top-level
parent and registers as a listener for the new top-level parent's
messages.

  • WebView.h: Made WebView and WindowMessageListener so that it can utilize WindowMessageBroadcaster to listen to its top-level parent's messages.
9:45 AM Changeset in webkit [29582] by Adam Roben
  • 16 edits in trunk

Update scroll bars/form controls when FocusController::isActive changes

WebCore:

Update scroll bars/form controls when FocusController::isActive changes

Part of <rdar://5006915> Inactive look for Aqua controls

Reviewed by Darin.

All tests pass.

  • page/FocusController.cpp: (WebCore::FocusController::setActive): Update control tints when the active state changes.
  • page/FrameView.cpp: (WebCore::FrameView::updateControlTints): On Windows, we have to ask ScrollView to paint so that the outermost scroll bars will paint. On Mac, the outermost scroll bars are taken care of by NSScroller.
  • platform/PopupMenu.h: Updated for ScrollBarClient changes.
  • platform/ScrollBar.h: Added a new ScrollBarClient method.
  • platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paint): Invalidate when updating control tints so that we can paint with the new tint later. (WebCore::PlatformScrollbar::paintButton): Pass the active state down to SafariTheme. (WebCore::PlatformScrollbar::paintTrack): Ditto. (WebCore::PlatformScrollbar::paintThumb): Ditto.
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::isActive): Added. (WebCore::ScrollView::paint): Pass paint calls on down if we're updating control tints so the scroll bars can invalidate.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::isActive): Added.
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::isActive): Added.
  • rendering/RenderListBox.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isActive): Added.
  • rendering/RenderTheme.h:
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::determineState): Pass the active state down to SafariTheme.

WebKit/win:

Updated for ScrollBarClient changes

Reviewed by Darin.

  • WebScrollBar.h: (WebScrollBar::isActive): Added.
9:44 AM Changeset in webkit [29581] by Adam Roben
  • 23 edits in trunk

Move focused/active state from Frame to SelectionController/FocusController

WebCore:

Move focused/active state from Frame to SelectionController/FocusController

This is the first part of <rdar://5006915> Inactive look for Aqua
controls.

The following methods were moved/renamed:

  • Frame::setIsActive -> FocusController::setActive
  • Frame::isActive -> SelectionController::isActiveAndFocused
  • Frame::setWindowHasFocus -> SelectionController::setFocused

Active state is now correctly a Page-level concept.

The Mac parts of this patch were written by Darin.

Reviewed by Darin.

All tests pass.

  • WebCore.base.exp: Updated for method renames.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Ditto.
  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): Initialize new member. (WebCore::SelectionController::focusedOrActiveStateChanged): New private method. Most of this code came from Frame::setIsActive. (WebCore::SelectionController::pageActivationChanged): Added. (WebCore::SelectionController::setFocused): Added. Replaces Frame::setWindowHasFocus. (WebCore::SelectionController::isFocusedAndActive): Added. Replaces Frame::isActive.
  • editing/SelectionController.h:
  • page/FocusController.cpp: (WebCore::FocusController::FocusController): Initialize new member. (WebCore::FocusController::setFocusedFrame): Changed to just call SelectionController::setFocused, since active state has doesn't change when the focused frame changes. (WebCore::FocusController::setActive): Added. Replaces Frame::setIsActive.
  • page/FocusController.h: (WebCore::FocusController::isActive): Added.
  • page/Frame.cpp: (WebCore::Frame::setDocument): Updated for method renames. (WebCore::Frame::setFocusedNodeIfNeeded): Ditto. (WebCore::Frame::updateSecureKeyboardEntryIfActive): Ditto. (WebCore::FramePrivate::FramePrivate): Removed initialization of removed members.
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/mac/WebCoreFrameBridge.h: Removed -selectionColor.
  • page/mac/WebCoreFrameBridge.mm: Ditto.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): Updated for method renames. (WebCore::RenderListBox::paintItemBackground): Ditto.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::selectionBackgroundColor): Ditto. (WebCore::RenderObject::selectionForegroundColor): Ditto.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::capsLockStateMayHaveChanged): Ditto.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isFocused): Ditto.

WebKit/mac:

Updated for renames/removal of WebCore methods.

Reviewed by Darin.

  • Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerSelectionColor]): Changed to ask isFocusedAndActive directly, instead of going through the frame bridge.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]): Updated for method renames.

WebKit/win:

Updated for changes to WebCore methods

Focus and active state are now handled (somewhat) separately. Future
patches will further separate these concepts.

Reviewed by Darin.

  • WebView.cpp: (WebViewWndProc): Updated for method renames. (WebView::updateActiveState): Only change the active state here. Focus is handled inside WM_SETFOCUS and WM_KILLFOCUS message handlers.

WebKit/wx:

Updated for WebCore method renames.

Reviewed by Darin.

  • WebView.cpp: (wxWebView::OnSetFocus): (wxWebView::OnKillFocus): (wxWebView::OnActivate):
8:52 AM Mobile edited by dacarson@gmail.com
(diff)
8:37 AM Mobile edited by dacarson@gmail.com
(diff)
8:20 AM Changeset in webkit [29580] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Re-add DEBUG_WEBKIT_HAS_SUFFIX.


Rubber-stamped by Jon Honeycutt.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
8:06 AM Mobile edited by dacarson@gmail.com
(diff)
8:03 AM Mobile edited by dacarson@gmail.com
(diff)
7:54 AM Changeset in webkit [29579] by Simon Hausmann
  • 2 edits in trunk/WebCore
  • Make the nice 'safari' feature work on our port. When viewing a single image, clicking on the image will zoom it.
  • It seems like our platform can only determine the size of the image once it is completely loaded. Call m_doc->imageChanged on the last chunk of data as well.
7:53 AM Changeset in webkit [29578] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Minor documentation fixes

7:51 AM Changeset in webkit [29577] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix form elements not focusing correctly after the qt widget lost its focus.

When receiving a focus out event notify the focus controller. Otherwise its
m_focusedFrame variable remains unchanged and setFocusedFrame on a focusIn
event shortcuts and doesn't call setActive(true).

7:44 AM Changeset in webkit [29576] by Simon Hausmann
  • 6 edits in trunk/WebKit/qt

Lots of updates to the documentation.

6:06 AM Changeset in webkit [29575] by Simon Hausmann
  • 6 edits in trunk/WebKit/qt

Added a urlChanged signals to QWebFrame and QWebView.

6:05 AM Changeset in webkit [29574] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fixed docs and sanity checks in QWebSettings::setIconDatabaseEnabled

6:04 AM Changeset in webkit [29573] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

Added QWebView::createWindow() which is forwarded from QWebPage::createWindow() for convenience.

6:03 AM Changeset in webkit [29572] by Simon Hausmann
  • 2 edits in trunk/WebCore

Set the library version of QtWebKit to the Qt version.

6:03 AM Changeset in webkit [29571] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

add a 0 pointer check.

Fixes a crash in the demo web browser.

5:03 AM Changeset in webkit [29570] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix QWebFrame::title().

For the titleChanged() signal we use the documentloader's title. For the property we have to use the same
instead of Document::title() as the latter is not trimmed and not suited for a window caption.

5:01 AM Changeset in webkit [29569] by Simon Hausmann
  • 2 edits in trunk/WebCore

Re-enable gzip compression as accepted encoding, now that the bug is fixed in Qt 4.4's network module.

4:07 AM Changeset in webkit [29568] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-01-17 Simon Hausmann <Simon Hausmann>

Another Windows build fix, setCookies accidentially had a const
Document pointer.

3:48 AM Changeset in webkit [29567] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-01-17 Simon Hausmann <Simon Hausmann>

MSVC Windows build fix. Forward declaring Document in CookieJar.h
seems not enough for MSVC.

3:37 AM Changeset in webkit [29566] by Simon Hausmann
  • 12 edits in trunk

​http://bugs.webkit.org/show_bug.cgi?id=16589

Add a document parameter to WebCore::cookies, setCookies and cookiesEnabled.

2:45 AM Changeset in webkit [29565] by Simon Hausmann
  • 2 edits in trunk/WebCore

Windows build fix.

2:04 AM Changeset in webkit [29564] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix linking on MinGW and at least one MSVC platform by having gmtimeQt in the correct namespace.

2:01 AM Changeset in webkit [29563] by Simon Hausmann
  • 2 edits in trunk/WebCore

Don't link QtWebKit against libQtXml when building against Qt 4.4.

This is not necessary anymore since QXmlStream has been moved into QtCore.

1:49 AM Changeset in webkit [29562] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Follow QWidget::keyPressEvent advice and call parents.

Without this, Back does not work in Qtopia, for example.

1:49 AM Changeset in webkit [29561] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix compilation on arm

1:48 AM Changeset in webkit [29560] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix compilation against Qt 4.3 after the recent KURL <> QUrl conversion fixes.

1:48 AM Changeset in webkit [29559] by Simon Hausmann
  • 9 edits in trunk

Fix compilation against Qt 4.4 without files that are specific for the Qt 4.3 build.

Signed-off-by: Holger

1:46 AM Changeset in webkit [29558] by Simon Hausmann
  • 3 edits in trunk/WebCore

Fixes compilation with MinGW.

Neither localtime_r nor localtime_s are available on MingW, so instead of
calling back to the thread-unsafe localtime use QDateTime instead.

Signed-off-by: Simon Hausmann <Simon Hausmann>

1:44 AM Changeset in webkit [29557] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Fixes compilation with QT_NO_DRAGANDDROP

1:16 AM Changeset in webkit [29556] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix compilation

1:04 AM Changeset in webkit [29555] by mitz@apple.com
  • 4 edits in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix determinePitch for segmented fonts

Covered by and existing test.

  • platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::determinePitch): If the primary font is segmented, treat as fixed pitch only if it has only one segment and that segment is fixed-pitch.

LayoutTests:

Reviewed by Dave Hyatt.

  • update results for fixing determinePitch for segmented fonts
  • platform/mac/fast/css/font-face-implicit-local-font-expected.txt:
12:27 AM Changeset in webkit [29554] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Add preprocessor define accidently dropped in my unification,
and required by some builds. Fixes an issue that caused both
debug and release DLLs to be loaded.


Rubber-stamped by Jon Honeycutt.

  • win/tools/vsprops/debug_internal.vsprops:

Jan 16, 2008:

10:20 PM Changeset in webkit [29553] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16611

Make sure vertical-align length values are offset from their parents rather than being absolute to the
line.

Reviewed by olliej

Added fast/css/vertical-align-lengths.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::getVerticalPosition):

LayoutTests:

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16611

Reviewed by olliej

  • ChangeLog:
  • fast/css/vertical-align-lengths.html: Added.
  • platform/mac/fast/css/vertical-align-lengths-expected.checksum: Added.
  • platform/mac/fast/css/vertical-align-lengths-expected.png: Added.
  • platform/mac/fast/css/vertical-align-lengths-expected.txt: Added.
10:13 PM Changeset in webkit [29552] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix for @font-face rules with unicode-range: always use a local font where not explicitly overlaid.

Test: fast/css/font-face-implicit-local-font.html

  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Changed to insert an implicit @font-face rule with the local font the matches the family and description before any explicit @font-face rules that overlay specific ranges of the same font.
  • css/CSSSegmentedFontFace.h: (WebCore::CSSSegmentedFontFace::numRanges): Addded.

LayoutTests:

Reviewed by Dave Hyatt.

  • add test for @font-face rules with unicode-range: always use a local font where not explicitly overlaid.
  • fast/css/font-face-implicit-local-font.html: Added.
  • platform/mac-leopard/fast/css/font-face-implicit-local-font-expected.checksum: Added.
  • platform/mac-leopard/fast/css/font-face-implicit-local-font-expected.png: Added.
  • platform/mac/fast/css/font-face-implicit-local-font-expected.txt: Added.
6:53 PM Changeset in webkit [29551] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/5097419> Cursor flickers when over window resizer


Reviewed by Sam.

  • WebView.cpp: (WebViewWndProc): Don't set the resize cursor when over the non-border resize area.
6:27 PM Changeset in webkit [29550] by alp@webkit.org
  • 7 edits in trunk

2008-01-16 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16218
[GTK] API: Should this entry point be called go_back rather than go_backward?

Obsolete 'backward' terminology in API in favour of 'back'. Introduce
step-based back/forward functions.

Document more functions.

5:11 PM Changeset in webkit [29549] by Antti Koivisto
  • 2 edits in trunk/WebCore

Fix Tiger build.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
4:45 PM Changeset in webkit [29548] by Antti Koivisto
  • 2 edits in trunk/LayoutTests

Add tests for unsupported types to Windows skip list for now.

  • platform/win/Skipped:
4:34 PM Changeset in webkit [29547] by Antti Koivisto
  • 4 edits
    8 adds in trunk

WebCore:

Reviewed by Adele.


OS X fix for <rdar://problem/5605682>
Disallow streaming protocols for media elements
and <rdar://problem/5668711>
Limit the container and codec types that the <video> tag supports


  • Disable unsupported QuickTime tracks types.
  • Disallow streaming protocols (for now).
  • Set QTMovie QTMoviePreventExternalURLLinksAttribute and QTSecurityPolicyNoCrossSiteAttribute to limit QuickTime's access to external resources.


Windows patch coming up.

Tests: media/broken-video.html

media/unsupported-rtsp.html
media/unsupported-tracks.html

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):

LayoutTests:

Reviewed by Adele.


Tests for <rdar://problem/5605682>
Disallow streaming protocols for media elements
and <rdar://problem/5668711>
Limit the container and codec types that the <video> tag supports


  • test that rtsp: protocol is disabled (for now).
  • test that QuickTime files with unsupported track types are handled correctly
  • test that broken video file produces an error
  • media/broken-video-expected.txt: Added.
  • media/broken-video.html: Added.
  • media/content/garbage.mp4: Added.
  • media/content/unsupported_track.mov: Added.
  • media/unsupported-rtsp-expected.txt: Added.
  • media/unsupported-rtsp.html: Added.
  • media/unsupported-tracks-expected.txt: Added.
  • media/unsupported-tracks.html: Added.
4:15 PM Changeset in webkit [29546] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-01-16 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16897
Add shared plugins directory to INCLUDE path

Add the plugins directory to INCLUDEPATH

  • GNUmakefile.am:
  • WebCore.pro:
3:59 PM Changeset in webkit [29545] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Use recommended security-related compiler settings.


Reviewed by Adam.

  • win/tools/vsprops/common.vsprops:
3:54 PM Changeset in webkit [29544] by ggaren@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Sam Weinig.


Added a debug counter for SQL transactions. This helped me debug an SQL
leak.

  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::): (WebCore::JSCustomSQLTransactionCallbackCounter::~JSCustomSQLTransactionCallbackCounter): (WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback): (WebCore::JSCustomSQLTransactionCallback::~JSCustomSQLTransactionCallback):
  • bindings/js/JSCustomSQLTransactionCallback.h:
  • bindings/js/kjs_window.cpp: Removed a silly comment.
3:36 PM Changeset in webkit [29543] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Adam and Dan


  • cleaned up some existing logging
  • WebView/WebHTMLView.mm: (-[WebHTMLView setNeedsDisplay:]): add method name to log, use "YES" and "NO" instead of (int)flag (-[WebHTMLView setNeedsLayout:]): ditto (-[WebHTMLView setNeedsToApplyStyles:]): ditto
3:16 PM Changeset in webkit [29542] by mjs@apple.com
  • 4 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej & Darin.

Fixes Bug 16868: Gmail crash

and Bug 16871: Crash when loading apple.com/startpage

<​http://bugs.webkit.org/show_bug.cgi?id=16868>
<rdar://problem/5686108>

<​http://bugs.webkit.org/show_bug.cgi?id=16871>
<rdar://problem/5686670>

Adds ActivationImp tear-off for cross-window eval() and fixes an
existing garbage collection issue exposed by the ActivationImp tear-off
patch (r29425) that can occur when an ExecState's m_callingExec is
different than its m_savedExec.

  • kjs/ExecState.cpp: (KJS::ExecState::mark):
  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):

LayoutTests:

Reviewed by Maciej.

Added a test that checks whether ActivationImp tear-off occurs before
a cross-window eval(). Relevant to

Bug 16868: Gmail crash

<​http://bugs.webkit.org/show_bug.cgi?id=16868>
<rdar://problem/5686108>

  • fast/js/window-eval-tearoff-expected.txt: Added.
  • fast/js/window-eval-tearoff.html: Added.
2:31 PM Changeset in webkit [29541] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by Oliver.

Clean up MathObjectImp, it needed a little scrubbing.

  • kjs/math_object.cpp: (KJS::MathObjectImp::MathObjectImp): (KJS::MathObjectImp::getOwnPropertySlot): (KJS::MathObjectImp::getValueProperty): (KJS::mathProtoFuncACos): (KJS::mathProtoFuncASin): (KJS::mathProtoFuncATan): (KJS::mathProtoFuncATan2): (KJS::mathProtoFuncCos): (KJS::mathProtoFuncExp): (KJS::mathProtoFuncLog): (KJS::mathProtoFuncSin): (KJS::mathProtoFuncSqrt): (KJS::mathProtoFuncTan):
  • kjs/math_object.h: (KJS::MathObjectImp::classInfo): (KJS::MathObjectImp::):
2:13 PM Changeset in webkit [29540] by hyatt@apple.com
  • 5 edits in trunk/LayoutTests

Update layout tests after fix for <rdar://problem/5681647>.

  • platform/mac/tables/mozilla/bugs/bug101674-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2973-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug57828-2-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.txt:
1:56 PM Changeset in webkit [29539] by hyatt@apple.com
  • 5 edits
    4 adds in trunk

WebCore:

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=14846, cell padding can't be changed dynamically.

Reviewed by Eric Seidel

Added fast/table/dynamic-cellpadding.html

  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::setCellPadding):
  • rendering/RenderTable.h:

LayoutTests:

Reviewed by Eric Seidel

​http://bugs.webkit.org/show_bug.cgi?id=14846

  • fast/table/dynamic-cellpadding.html: Added.
  • platform/mac/fast/table/dynamic-cellpadding-expected.checksum: Added.
  • platform/mac/fast/table/dynamic-cellpadding-expected.png: Added.
  • platform/mac/fast/table/dynamic-cellpadding-expected.txt: Added.
1:53 PM Changeset in webkit [29538] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoffrey Garen.

Rename Lexer variable bol to atLineStart.

  • kjs/lexer.cpp: (KJS::Lexer::Lexer): (KJS::Lexer::setCode): (KJS::Lexer::nextLine): (KJS::Lexer::lex):
  • kjs/lexer.h:
1:50 PM Changeset in webkit [29537] by weinig@apple.com
  • 5 edits in trunk/JavaScriptCore

Reviewed by Geoffrey Garen and Anders Carlsson.

Remove uses of KJS_PURE_ECMA as we don't ever build with it defined,
and we have many features that are not included in the ECMA spec.

  • kjs/lexer.cpp: (KJS::Lexer::Lexer): (KJS::Lexer::setCode): (KJS::Lexer::nextLine): (KJS::Lexer::lex):
  • kjs/lexer.h:
  • kjs/string_object.cpp:
  • kjs/string_object.h:
1:27 PM Changeset in webkit [29536] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5681647> Item pages on ​http://www.stendmarsofa.com/ hang Safari

This regression was caused by an attempt to implement a WinIE quirk in RenderBlock::calcInlinePrefWidths.
The original patch introduced pathological O(n2) behavior into this function even when the quirk didn't need
to apply. In addition the quirk was only partially implemented (the full quirk did not care what was adjacent
to images and also needed bidi.cpp patched, since the quirk applies both when computing pref widths and when
laying out).

This new patch rewrites the quirk to be complete. The original test case attached to the bug that tested a variety
of image/text combinations now fully matches WinIE.

Reviewed by Beth

Added fast/table/unbreakable-images-quirk.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):
1:24 PM Changeset in webkit [29535] by hyatt@apple.com
  • 1 edit in trunk/WebCore/rendering/bidi.cpp

I don't know what happened here. It did not commit with my checkin.

1:22 PM Changeset in webkit [29534] by Adam Roben
  • 2 edits in trunk/WebKitTools

Windows build fix after r29488

  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Build into a subdirectory of $WebKitOutputDir\bin to match where DRT expects to find the plugin.
1:20 PM Changeset in webkit [29533] by hyatt@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Beth.

<rdar://problem/5681647> Item pages on ​http://www.stendmarsofa.com/ hang Safari

  • fast/table/unbreakable-images-quirk.html: Added.
  • platform/mac/fast/table/unbreakable-images-quirk-expected.checksum: Added.
  • platform/mac/fast/table/unbreakable-images-quirk-expected.png: Added.
  • platform/mac/fast/table/unbreakable-images-quirk-expected.txt: Added.
1:13 PM Changeset in webkit [29532] by jhoneycutt@apple.com
  • 5 edits in trunk/WebCore

2008-01-16 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Jon Honeycutt

Move isPluginBlacklisted to PluginPackageWin.cpp, to avoid
a circular dependency on PluginDatabaseWin
Remove the getFileVersion method, and just check the versions directly
in isPluginBlacklisted, as it was the only caller

​http://bugs.webkit.org/show_bug.cgi?id=16884

  • plugins/win/PluginDatabaseWin.cpp:
  • plugins/win/PluginDatabaseWin.h:
  • plugins/win/PluginPackageWin.cpp:
  • plugins/win/PluginPackageWin.h:
9:14 AM Changeset in webkit [29531] by mitz@apple.com
  • 1 edit
    1 copy
    4 adds in trunk/LayoutTests

Reviewed by Adam Roben.

  • copied Windows expected results for svg/hixie/viewbox/preserveAspectRatio/001.xml from Tiger
  • platform/win/svg: Added.
  • platform/win/svg/hixie: Added.
  • platform/win/svg/hixie/viewbox: Added.
  • platform/win/svg/hixie/viewbox/preserveAspectRatio: Added.
  • platform/win/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt.
4:07 AM Changeset in webkit [29530] by alp@webkit.org
  • 1 edit in trunk

​http://bugs.webkit.org/show_bug.cgi?id=16732
Update svn:ignore properties for autotools build

Reviewed by Alp Toker.

Ignore files placed in the source tree by the autotools build (these
files are generated even during an out-of-tree build).

2:34 AM Changeset in webkit [29529] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Removed a whole bunch of notImplemented() warnings.

I don't want to hide the real warnings in lots of things that
I am by now pretty certain we won't need.

Signed-off-by: Simon Hausmann <​simon.hausmann@trolltech.com>

2:18 AM Changeset in webkit [29528] by Simon Hausmann
  • 2 edits in trunk/WebCore
  • Set the cursor on the containingWindow() instead of the nativeWidget()
  • This should be safe even with plugins as the cursor is set on the mouse events.

Signed-Off-By: Lars

2:18 AM Changeset in webkit [29527] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix crash when bringing up the context menu on maps.google.com.

If the website provides its own context menu then we don't have a ContextMenu pointer.

2:18 AM Changeset in webkit [29526] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Don't crash when receiving all sorts of events on a default constructed QWebView without a page.

2:18 AM Changeset in webkit [29525] by Simon Hausmann
  • 2 edits in trunk/WebCore

Improve the sqlite3 dependency when building WebKit inside Qt.

Build sqlite3 into QtWebKit if a system sqlite3 development package
can't be found.

Signed-off-by: Lars

2:17 AM Changeset in webkit [29524] by Simon Hausmann
  • 2 edits in trunk/WebCore

Implement GraphicsContext::clipOut and fix transparency layers.

Transparency layers where broken in two ways: It always used the
complete device rect as the size of the layer pixmap and the pixmaps
where not correctly initialized to transparent.

This fixes the worst drawing errors in the Inspector and makes drawing it
10 times faster.

2:17 AM Changeset in webkit [29523] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Made the url property read-write.

2:17 AM Changeset in webkit [29522] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Don't crash when showing a default initialized QWebView that has no page/frame yet.

2:17 AM Changeset in webkit [29521] by Simon Hausmann
  • 2 edits in trunk/WebCore

Trivially implement the themed search field by mapping it to a text field

Also add a bunch of notImplemented warnings for other places where we don't
have an implementatin in RenderTheme.

2:02 AM ApplicationsGtk edited by alp@atoker.com
Add another feed reader (diff)
1:57 AM BuildingGtk edited by alp@atoker.com
Link to the archived GTK+/qmake build instructions (diff)
1:56 AM Changeset in webkit [29520] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Change hoveringOverLink implementation to have less issues.

  • Currently we only compare a pointer. In the worst case we could delete the Element we have pointed to and a new one gets the same address. But even if that doesn't happen the WebCore::Element is mutable and JavaScript could change the URL, Title or Content. So we have to compare all these three attributes.
  • This does not seem to be a performance impact.
1:55 AM Changeset in webkit [29519] by Simon Hausmann
  • 2 edits in trunk/WebCore
  • Follow the EventHandlerWin.cpp and always return true in the handlers.
  • Match the windows implementation more closely as well.
  • This is fixing "selection" bugs with the Web Inspector
1:55 AM Changeset in webkit [29518] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt
  • Move the hoverElement from QWebFrame to QWebPage. As it is only used there.
1:54 AM Changeset in webkit [29517] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

EventHandler changes/fixes in QWebPage:

-mouse{Press,Move,Release}Event:

Send the event always to the mainFrame of the QWebPage.

-contextMenuEvent, key{Press,Release}Event:

Send the event to the focused frame.

This is following the Windows port and fixes a issue with the
Web Inspector where we were sending the events to a wrong frame.

It is guaranteed that the mainFrame will always have an eventHandler
and frameView set. There is no need to check for this in QWebPage.

1:52 AM Changeset in webkit [29516] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt
  • Add core and kit functions to QWebFramePrivate to convert from QWebFrame to WebCore::Frame and vice versa.
1:38 AM Changeset in webkit [29515] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix crashes in the new networking code.

When the ResourceLoader cancels the handle we have to make sure not to access
the resource handle afterwards again.

1:38 AM Changeset in webkit [29514] by Simon Hausmann
  • 11 edits
    1 add in trunk

add conversion methods from and to QUrl to KURL.

Use them in the places I found at the moment. Fixes a bug
where form data was encoded twice.
Also fix QWebSettings to take a QUrl for the user style sheet
location.

Signed-off-by: Simon

1:37 AM Changeset in webkit [29513] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt
  • Make the InspectorClientView inherit from QWebView instead of QWidget. This way paintEvent, mouse{Press,Release}Event and other events get forwarded to the QWebPage/WebInspector automatically.
12:18 AM Changeset in webkit [29512] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Build fix.

  • win/tools/vsprops/release.vsprops:
12:02 AM Changeset in webkit [29511] by Darin Adler
  • 3 edits in trunk/WebCore

Rubber-stamped by Maciej Stachowiak and Oliver Hunt.

  • fix <rdar://problem/5689748> REGRESSION: Cannot redirect to protocols handled by external applications

Put navigation policy delegate calls back for redirects.
Just rolled out the change where I took them out.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::willSendRequest):
  • loader/MainResourceLoader.h:
Note: See TracTimeline for information about the timeline view.