⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 20, 2008:

11:07 PM Changeset in webkit [29683] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-01-20 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

Attach the widget's style to its window and set the background to the
base background to avoid black flicker when repainting. This is
similar to what GtkTextView does.

  • WebView/webkitwebview.cpp:
9:34 PM Changeset in webkit [29682] by mrowe@apple.com
  • 4 edits in trunk/WebKit

Remove code bracketed by REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as we are no longer interested in supporting Safari 2 with TOT WebKit.

Reviewed by Dan Bernstein.

  • WebKit.xcodeproj/project.pbxproj: Don't define REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as it is no longer used.
  • mac/WebView/WebView.mm:

(+[WebView initialize]):

8:30 PM Changeset in webkit [29681] by oliver@apple.com
  • 2 edits in trunk/WebCore

Fix http://bugs.webkit.org/show_bug.cgi?id=16816 , rdar://problem/5682985

Reviewed by Mitz

Correctly trigger willPerformDragDestinationAction when a drop causes a
load to occur. The logic that originally did this was lost during the
great drag migration of '07.

8:04 PM Changeset in webkit [29680] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • update Tiger-specific results for r29667
  • platform/mac/editing/pasteboard/paste-RTFD-expected.txt:
6:01 PM Changeset in webkit [29679] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

Assertion failure in FrameView::scheduleRelayout (!m_frame->document()
!m_frame->document()->inPageCache()) when going back from a page with a focused popup
  • dom/Document.cpp: (WebCore::Document::setFocusedNode): Bail out if the document is in the page cache. Documents in the back/forward cache are "frozen" and should not change state.
3:18 PM Changeset in webkit [29678] by weinig@apple.com
  • 3 edits
    10 adds in trunk

WebCore:

Reviewed by Sam Weinig.

Fix for http://bugs.webkit.org/show_bug.cgi?id=16775

We now use frame()->loader()->url() for postMessage, preventing a
malicious sender from overwriting the uri property (using a <base> tag,
for example). Also, use frame->loader()->url().host() instead of
instead of document()->SecurityOrigin()->domain() to reflect a recent
clarification in the HTML5 spec.

Tests: http/tests/security/postMessage/domain-affected-by-document-domain.html

http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag.html
http/tests/security/postMessage/javascript-page-still-sends-domain.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):

LayoutTests:

Reviewed by Sam Weinig.

Tests for http://bugs.webkit.org/show_bug.cgi?id=16775

  • http/tests/security/postMessage: Added.
  • http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag-expected.txt: Added.
  • http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag.html: Added.
  • http/tests/security/postMessage/domain-unaffected-by-document-domain-expected.txt: Added.
  • http/tests/security/postMessage/domain-unaffected-by-document-domain.html: Added.
  • http/tests/security/postMessage/javascript-page-still-sends-domain-expected.txt: Added.
  • http/tests/security/postMessage/javascript-page-still-sends-domain.html: Added.
  • http/tests/security/postMessage/resources: Added.
  • http/tests/security/postMessage/resources/javascript-post-message-sender.html: Added.
  • http/tests/security/postMessage/resources/post-message-listener.html: Added.
1:22 PM Changeset in webkit [29677] by Antti Koivisto
  • 5 edits in trunk

WebCore:

Reviewed by Adele.

Fix <rdar://problem/5695451>
Middle part of the media timeline missing on Windows if load failed

Add some null checking to avoid getting garbage results from the functions.

  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::duration): (QTMovieWin::currentTime): (QTMovieWin::setCurrentTime): (QTMovieWin::maxTimeLoaded):

LayoutTests:

Reviewed by Adele.

Update test so it checks the state of time related properties after the failure.

  • media/video-error-does-not-exist-expected.txt:
  • media/video-error-does-not-exist.html:

Jan 19, 2008:

8:53 PM Changeset in webkit [29676] by alp@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix 'Reviewed by' typo in ChangeLog

8:49 PM Changeset in webkit [29675] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-19 Alp Toker <alp@atoker.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16944
Use of GST_PLUGIN_DEFINE_STATIC results in a module-level constructor

http://bugzilla.gnome.org/show_bug.cgi?id=510547
Epiphany/Webkit fails to start due to initializing threads twice

Don't call GST_PLUGIN_DEFINE_STATIC() as it performs g_thread_init()
in the global initializer, breaking subsequent calls to
g_thread_init() in applications.

  • platform/graphics/gtk/VideoSinkGStreamer.cpp:
8:25 PM WikiStart edited by webkit@mattlilek.com
Remove spam (diff)
10:51 AM Changeset in webkit [29674] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Allow the --http flag to run-webkit-tests to override
the default behaviour of disabling HTTP tests for Qt,
Gtk and Wx.

Reviewed by Alp Toker.

  • Scripts/run-webkit-tests:
10:34 AM Changeset in webkit [29673] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-19 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

Remove any fragment part from the URL to be requested just before
passing it to curl, otherwise curl sends it as part of the HTTP/local
file request, causing page loads to fail.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startJob):
10:27 AM Changeset in webkit [29672] by mrowe@apple.com
  • 272 edits in trunk

Set svn:eol-style=native on .idl and .c files that were missed in r29663.

10:10 AM Changeset in webkit [29671] by mrowe@apple.com
  • 9 edits in trunk/WebKit/win

2008-01-19 Mark Rowe <mrowe@apple.com>

Fix inconsistent line endings and set svn:eol-style=native
on IDL files that did not have it set.

  • Interfaces/IGEN_DOMObject.idl:
7:46 AM Changeset in webkit [29670] by alp@webkit.org
  • 4 edits in trunk

2008-01-19 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

Add svg foreign object and svg experimental to the GTK+/autotools
build system.

5:58 AM Changeset in webkit [29669] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-01-19 Christian Dywan <christian@imendio.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16882
[GTK] ChromeClientGtk is incompete

Implement these functions.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowRect): (WebKit::ChromeClient::pageRect): (WebKit::ChromeClient::scaleFactor): (WebKit::ChromeClient::focus): (WebKit::ChromeClient::unfocus): (WebKit::ChromeClient::canTakeFocus): (WebKit::ChromeClient::takeFocus): (WebKit::ChromeClient::canRunBeforeUnloadConfirmPanel):
2:43 AM Changeset in webkit [29668] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<rdar://problem/5695344> check-for-global-initializers script never checks any object files

Reviewed by Darin.

We now touch a check-for-global-initializers.timestamp file in
the TARGET_TEMP_DIR directory to determine when new object files
have been compiled and thus need to be checked. If the timestamp
file doesn't exist, all object files will be checked.

Previously the modification time of the "executable" (the
framework binary, e.g., WebKit.framework/WebKit) was used, but
since this was the last file modified at the end of the compile
phase, no object files would ever get checked!

Also added JSCustomSQLTransactionCallback.o to the list of files
since it has static initializers in Debug builds of WebCore.

  • Scripts/check-for-global-initializers:
2:12 AM Changeset in webkit [29667] by mitz@apple.com
  • 21 edits
    5 adds in trunk

WebCore:

Reviewed by Maciej Stachowiak.

  • fix <rdar://problem/5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116

Test: editing/selection/inconsistent-in-removeChildNode.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): If the selection base or extent are not visible any more, adjust the selection.

LayoutTests:

Reviewed by Maciej Stachowiak.

  • test and updated results for <rdar://problem/5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116
  • editing/selection/inconsistent-in-removeChildNode.html: Added.
  • platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt:
  • platform/mac-leopard/editing/selection: Added.
  • platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.checksum: Added.
  • platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.png: Added.
  • platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
  • platform/mac/editing/deleting/delete-4083333-fix-expected.txt:
  • platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-line-011-expected.txt:
  • platform/mac/editing/execCommand/find-after-replace-expected.txt:
  • platform/mac/editing/execCommand/paste-1-expected.txt:
  • platform/mac/editing/execCommand/paste-2-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt: Added.
  • platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
  • platform/mac/editing/selection/replace-selection-1-expected.txt:
  • platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
  • platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-expected.txt:
  • platform/mac/editing/style/remove-underline-in-bold-expected.txt:
  • platform/mac/editing/style/unbold-in-bold-expected.txt:
1:43 AM Changeset in webkit [29666] by oliver@apple.com
  • 2 edits in trunk/WebCore

Build fix for --svg-foreign-object path

Reviewed by Eric Seidel

Note: See TracTimeline for information about the timeline view.