Context Navigation

← Previous Period
Next Period →

Timeline

Jan 23, 2008:

11:44 PM Changeset in webkit [29755] by mrowe@apple.com

4 edits in trunk

Versioning.

11:42 PM Changeset in webkit [29754] by mrowe@apple.com

1 copy in tags/Safari-5525.6

New tag.

4:47 PM Changeset in webkit [29753] by ddkilzer@apple.com

2 edits in trunk/WebCore

<rdar://problem/5702947> WebCore: CGContextDrawPDFDocument will be deprecated

Reviewed by Darin.

No test cases added since there is no change in behavior.

platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::draw): Replace CGContextDrawPDFDocument() with calls to CG methods that perform the equivalent work.

3:08 PM Changeset in webkit [29752] by Antti Koivisto

4 edits in trunk/WebCore

Reviewed by Hyatt, Adele.

Timers for media controls keep running when the page is in the page cache.

Stop timers in RenderMedia and get rid of the controls tree when the page goes to the cache.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::willSaveToCache): (WebCore::HTMLMediaElement::didRestoreFromCache):
html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::inPageCache):
rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):

2:26 PM Changeset in webkit [29751] by Antti Koivisto

2 edits in trunk/WebCore

Reviewed by Adam.

Video that had already played to the end would start playing (from beginning) on back/forward navigation.

Use setPausedInternal() instead of pause(). This avoid generating pause/play events and matches specification text.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::willSaveToCache):

2:20 PM Changeset in webkit [29750] by ap@webkit.org

5 edits
6 adds in trunk

Reviewed by Darin.

<rdar://problem/4200075> Missing support for accented chars in mailto forms

With some combinations of form parameters, this was resulting in regressed behavior.

Tests: fast/forms/mailto/get-non-ascii-text-plain-latin-1.html

fast/forms/mailto/post-text-plain-with-accept-charset.html
fast/forms/mailto/post-text-plain.html

html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Ignore accept-charset for mailto forms, which are always encoded as UTF-8. (WebCore::HTMLFormElement::isMailtoForm): Added. (WebCore::HTMLFormElement::dataEncoding): Added (factored out from formData). (WebCore::HTMLFormElement::submit): When round-tripping in text/plain case, use utf-8 encoding.
html/HTMLFormElement.h: Added a isMailtoForm() function. It may be a bit unfortunate that its result is calculated repeatedly, but this doesn't seem to be anywhere near hot code.

2:04 PM Changeset in webkit [29749] by sfalken@apple.com

7 edits in trunk

WebCore:

Reviewed by Alice Liu.

<rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updateFromElement): If value == text() and m_innerText is empty, then value and text() are "". In that case both DOM mutations are no-ops and there is no reason to clear the Undo stack.

WebKit/win:

<rdar://problem/5698732> Copyright strings should include 2008

Reviewed by Sam.

WebKit.vcproj/WebKit.rc:

WebKitTools:

<rdar://problem/5698732> Copyright strings should include 2008

Reviewed by Sam.

Drosera/win/Drosera.vcproj/Drosera.rc:
DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:

1:51 PM Changeset in webkit [29748] by justin.garcia@apple.com

3 edits
2 adds in trunk

WebCore:

Reviewed by Alice Liu.

<rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updateFromElement): If value == text() and m_innerText is empty, then value and text() are "". In that case both DOM mutations are no-ops and there is no reason to clear the Undo stack.

LayoutTests:

Reviewed by Alice Liu.

<rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

editing/undo/5658727-expected.txt: Added.
editing/undo/5658727.html: Added.

1:08 PM Changeset in webkit [29747] by Adam Roben

2 edits in trunk/WebKit/win

Fix <rdar://5698502> Inspector window reverts to default position/size unexpectedly

Reviewed by Hyatt.

WebInspectorClient.cpp: (defaultWindowRect): Added. (WebInspectorClient::createPage):
- Use defaultWindowRect() to set the initial size/position of the Inspector window.
- Pass the Inspector window's client rect to IWebView::initWithFrame so that the WebView will be initially sized to fill the window.

(WebInspectorClient::showWindow): Don't move/resize the window back to
the defaults every time this method is called.

1:07 PM Changeset in webkit [29746] by Adam Roben

3 edits
2 adds in trunk

Fix <rdar://5700620> REGRESSION (r28190): "Open frame in new tab" instead of "Open link in new tab" @ digg.com

WebKit/win:

Fix <rdar://5700620> REGRESSION (r28190): "Open frame in new tab" instead of "Open link in new tab" @ digg.com

Test: fast/events/contextmenu-scrolled-page-with-frame.html

Reviewed by Dan.

WebView.cpp: (WebView::handleContextMenuEvent): Translate the mouse coordinates into document coordinates before performing the hit-test. This is what EventHandler does internally.

LayoutTests:

Add a test for <rdar://5700620> REGRESSION (r28190): "Open frame in
new tab" instead of "Open link in new tab" @ digg.com

Reviewed by Dan.

fast/events/contextmenu-scrolled-page-with-frame-expected.txt: Added.
fast/events/contextmenu-scrolled-page-with-frame.html: Added.

11:43 AM Changeset in webkit [29745] by sfalken@apple.com

9 edits in trunk

WebCore:

<rdar://problem/5699509> Allow file upload dialog to be localized.

Reviewed by Darin.

platform/LocalizedStrings.h:
platform/win/FileChooserWin.cpp: (WebCore::FileChooser::openFileChooser):

WebKit:

Update localization exceptions.

Reviewed by Darin.

English.lproj/Localizable.strings:
StringsNotToBeLocalized.txt:

WebKit/win:

<rdar://problem/5699509> Allow file upload dialog to be localized.

Reviewed by Darin.

English.lproj/Localizable.strings: Updated.
WebCoreLocalizedStrings.cpp: (WebCore::uploadFileText): Added. (WebCore::allFilesText): Added.

9:49 AM Changeset in webkit [29744] by dsmith@webkit.org

1 edit
19 adds in trunk/WebKitSite

Reviewed by Darin.

Added a modified version of the MooTools SlickSpeed Selector Test/Benchmark to show off querySelectorAll. MIT licensed.

perf/slickspeed: Added.
perf/slickspeed/config.ini: Added.
perf/slickspeed/footer.html: Added.
perf/slickspeed/frameworks: Added.
perf/slickspeed/frameworks/DomQuery.js: Added.
perf/slickspeed/frameworks/dummy.js: Added.
perf/slickspeed/frameworks/jquery-1.2.1.js: Added.
perf/slickspeed/frameworks/prototype.js: Added.
perf/slickspeed/header.html: Added.
perf/slickspeed/index.php: Added.
perf/slickspeed/instructions.txt: Added.
perf/slickspeed/logo.png: Added.
perf/slickspeed/selectors.list: Added.
perf/slickspeed/style.css: Added.
perf/slickspeed/system: Added.
perf/slickspeed/system/index.php: Added.
perf/slickspeed/system/slickspeed.js: Added.
perf/slickspeed/system/template.php: Added.
perf/slickspeed/template.html: Added.

9:38 AM Changeset in webkit [29743] by Adam Roben

2 edits in trunk/WebCore

Fix behavior of type-to-select in <select> menus

In r27825 we started posting both a WM_KEYDOWN and WM_CHAR message
whenever a key was pressed in the dropdown menu. However, since posted
messages go through TranslateMessage, the WM_KEYDOWN was generating
another WM_CHAR message, so two WM_CHAR messages in a row would reach
the WebView. This caused the searching to happen twice for each key,
so typing "dog" would search for "ddoogg".

Reviewed by Darin.

platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc): Repost the WM_KEYDOWN message to the WebView. This is will generate a WM_CHAR message which will trigger the type-to-select behavior. This is very similar to our behavior prior to r27825, except that we're now calling PostMessage instead of SendMessage.

8:18 AM Changeset in webkit [29742] by mitz@apple.com

4 edits in trunk/LayoutTests

updated results following <http://trac.webkit.org/projects/webkit/changeset/29721>

platform/mac/fast/frames/viewsource-attribute-expected.checksum:
platform/mac/fast/frames/viewsource-attribute-expected.png:
platform/mac/fast/frames/viewsource-attribute-expected.txt:

7:55 AM Changeset in webkit [29741] by alp@webkit.org

8 edits in trunk

2008-01-23 Alp Toker <alp@atoker.com>

Rubber-stamped by Mark Rowe.

Remove whitespace after -I in automake include lists.

3:16 AM Changeset in webkit [29740] by Simon Hausmann

2 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Fix leaking of sub frames (WebCore::Frame). We keep one reference too many. This was found while working on the page-cache, other ports are not affected.
Rubber stamped by Simon

3:14 AM Changeset in webkit [29739] by Simon Hausmann

2 edits in trunk/WebCore

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Load images incrementally. This will show warnings on the console and we want to fix them for Qt4.4. If that happens we have to remove the comment from the enum inside the ImageDecoderQt.cpp

Rubber stamped by Simon

3:11 AM Changeset in webkit [29738] by Simon Hausmann

2 edits in trunk/WebKit/qt

Rohan McGovern <rohan.mcgovern@trolltech.com>

Fix Qtopia compilation with QT_NO_TOOLTIP

3:11 AM Changeset in webkit [29737] by Simon Hausmann

2 edits in trunk/WebKit/qt

Geir Vattekar <gvatteka@trolltech.com>

Doc: Replaced \code with snippets in the docs

3:10 AM Changeset in webkit [29736] by Simon Hausmann

2 edits in trunk/WebCore

Lars Knoll <lars@trolltech.com>

Fix rendering of the Scrollbar as well as mouse handling for some styles.

The QStyle expects that that painter is set up to clip to the scrollbar bounds
and some of the styles seem to paint somewhat outside of these bounds. Clipping to
the scrollbar bounds before drawing removes some artifacts.

Also set m_opt.rect.topLeft to (0/0) in the mouse handlers. Fixes some issues with
the oxygen style.

1:55 AM Changeset in webkit [29735] by Simon Hausmann

3 edits in trunk/WebCore

Michael Brasser <michael.brasser@trolltech.com>

Rendering fixes for Qtopia.

Make the focus ring work with line breaks (until we have QPainterPath::simplify) and
call QStyle with better arguments when painting themed elements.

1:55 AM Changeset in webkit [29734] by Simon Hausmann

3 edits in trunk/WebCore

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

FormData::flatten does not include to be uploaded files. Create our own QIODevice for the QNetworkAccessManager and feed the complete content of the FormData* to the (HTTP) backend.
Try to optimize the ::readData implementation to fill the buffer as best as possible

1:55 AM Changeset in webkit [29733] by Simon Hausmann

2 edits in trunk/WebCore

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Coding-Style fixes

1:48 AM Changeset in webkit [29732] by Simon Hausmann

2 edits in trunk/WebCore

Michael Brasser <michael.brasser@trolltech.com>

use PopupClient's font for popup menu. Otherwise, in Qtopia, the popup's font is much bigger (QApplication::font()?) and the text doesn't fit.

1:44 AM Changeset in webkit [29731] by Simon Hausmann

2 edits in trunk/WebKit/qt

Benjamin Meyer <bmeyer@trolltech.com>

Tweak key presses even to match commonly expected behavior

space key == page down
page down moved down not a page, but slightly less then a page so you don't loose your spot when reading.
Use font height rather then a hard coded "10" for left, right, up, down
Ctrl-Up moves to the top of the page
Ctrl-Down move to the bottom of the page
Backspace == GoBack
Shift-Backspace == GoForward

1:43 AM Changeset in webkit [29730] by Simon Hausmann

7 edits in trunk

Implemented FrameLoaderClient::startDownload() and FrameLoaderClient::download().

Added two signals to QWebPage to handle downloading of links and handling of
unsupported content.

1:39 AM Changeset in webkit [29729] by Simon Hausmann

12 edits in trunk

Michael Goddard <michael.goddard@trolltech.com>

Reworked the JavaScriptCore Qt bindings:

Add initial support for string and variant arrays, as well as sub QObjects in the JS bindings.

Don't expose fields marked as not scriptable by moc.

Add support for dynamic properties and accessing named QObject children of an object (like QtScript and older IE DOM style JS).
Add support for custom toString methods.

Fine tune some bindings to be closer to QtScript. Make void functions return undefined, and empty/ null QStrings return a zero length string.

Create framework for allowing more direct method calls. Since RuntimeMethod doesn't allow us to add additional methods/properties to a function, add these classes. Start prototyping object.signal.connect(...).

Add signal support to the Qt bindings. Allow connecting to signals (object.signal.connect(slot)), disconnecting, and emitting signals. Currently chooses the first signal that matches the name, so this will need improvement.

Add property names, and resolve signals closer to use. Enumerating properties now returns some of the Qt properties and signals. Slots and methods aren't quite present. Also, resolve signal connections etc. closer to the time of use, so we can do more dynamic resolution based on argument type etc. Still picks the first one with the same name, at the moment.

Make signature comparison code consistent. Use the same code for checking meta signatures in the method and fallback getters, and avoid a QByteArray construction when we can.

Fix minor memory leak, and handle pointers better. Delete the private object in the dtors, and use RefPtrs for holding Instances etc.

Handle method lookup better. Allow invocation time method lookup based on the arguments, which is closer to QtScript behaviour. Also, cache the method lists and delete them in the QtClass dtor (stops a memory leak).

Improve JS to Qt data type conversions. Add some support for Date & RegExp JS objects, and provide some metrics on the quality of the conversion.

A couple of fixes for autotest failures. Better support for converting lists, read/write only QMetaProperty support, modified slot search order...)

Update JS DRT controller for Qt JS binding changes. There were two functions that needed some changes so that the layout tests would work, so this makes a few tests pass again.

Bump the timeout for layout tests up to 11s. At least some tests have an internal timeout of 10 seconds, so make the waitUntilDone approach wait at least 11s. fast/dom/open-and-close-by-DOM.html is one of these - now the failure message is more accurate.

Jan 22, 2008:

8:01 PM Changeset in webkit [29728] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Adele Peterson.

fix http://bugs.webkit.org/show_bug.cgi?id=16905 <rdar://problem/5692407> REGRESSION (3.0.4-TOT): "menu" pseudocolor is badly chosen

The regression test for this is fast/css/css2-system-color.html which
is currently disabled.

rendering/RenderThemeMac.mm: (WebCore::menuBackgroundColor): Added. Uses HIThemeDrawMenuBackground to draw the menu item background into a bitmap graphics context and returns the color of the pixel at (0, 0). (WebCore::RenderThemeMac::systemColor): Changed to call menuBackgroundColor for the CSS2 menu color.

4:29 PM Changeset in webkit [29727] by Darin Adler

2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

turn full repainting back on for <canvas> until we get incremental repaint working properly

Ollie and I came up with a plan for testing this, but for now we should
just fall back on the "repaint everything" behavior we have always had.

html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::willDraw): Just call repaint.

3:16 PM Changeset in webkit [29726] by andersca@apple.com

5 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Darin and Adam.

<rdar://problem/5688975>
div element on microsoft site has wrong left offset.

Return true even if NPN_GetProperty returns null or undefined. This matches Firefox
(and is what the Silverlight plug-in expects).

bindings/NP_jsobject.cpp: (_NPN_GetProperty):

WebKitTools:

Reviewed by Darin and Adam.

<rdar://problem/5688975>
div element on microsoft site has wrong left offset.

Add new method for testing the return vale of NPN_GetProperty.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvoke):

LayoutTests:

Reviewed by Darin and Adam.

<rdar://problem/5688975>
div element on microsoft site has wrong left offset.

Add test.

plugins/netscape-get-property-return-value-expected.txt: Added.
plugins/netscape-get-property-return-value.html: Added.

1:23 PM Changeset in webkit [29725] by alp@webkit.org

2 edits in trunk/WebCore

2008-01-22 Alp Toker <alp@atoker.com>

GTK+/qmake build fix.

WebCore.pro:

12:46 PM Changeset in webkit [29724] by ap@webkit.org

4 edits in trunk

Reviewed by Adam Roben.

<rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail

DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.

12:45 PM Changeset in webkit [29723] by alp@webkit.org

9 edits
2 adds
2 deletes in trunk

2008-01-22 Christian Dywan <christian@imendio.com>

Reviewed by Alp Toker.

[GTK] API: WebKitWebSettings is not usable
http://bugs.webkit.org/show_bug.cgi?id=16219

Implement WebKitWebSettings.

11:33 AM Changeset in webkit [29722] by Adam Roben

6 edits
9 adds in trunk

Fix <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn't be on an ad on cnn.com

WebCore:

Add HTMLFrameOwnerElement::scrollingMode

This new virtual method is overridden by HTMLFrameElementBase to
provide the scrolling mode set on the frame or iframe element. Object
elements always have scrolling=auto, so there's no need to override
this method for HTMLPlugInElement.

Reviewed by Hyatt.

html/HTMLFrameElementBase.h: Declare scrollingMode as virtual.
html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::scrollingMode): Added.

WebKit/win:

Fix <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn't be on an ad on cnn.com

Now that we have multiple FrameViews per Frame on Windows, we need to
make sure each FrameView gets its scrolling mode set correctly. On Mac
this works because WebFrameView holds the scrolling mode and a single
WebFrameView is shared by many FrameViews. On Windows, we have no such
shared object, so we just ask the Frame's owner element for the
scrolling mode.

Tests: fast/frames/frame-scrolling-attribute.html

fast/frames/iframe-scrolling-attribute.html

Reviewed by Hyatt.

WebFrame.cpp: (WebFrame::transitionToCommittedForNewPage): Set the scrolling mode on the FrameView based on the scrolling mode of the Frame's owner element.

LayoutTests:

Tests for <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn't be on an ad on cnn.com

Reviewed by Hyatt.

fast/frames/frame-scrolling-attribute.html: Added.
fast/frames/iframe-scrolling-attribute.html: Added.
platform/mac/fast/frames/frame-scrolling-attribute-expected.checksum: Added.
platform/mac/fast/frames/frame-scrolling-attribute-expected.png: Added.
platform/mac/fast/frames/frame-scrolling-attribute-expected.txt: Added.
platform/mac/fast/frames/iframe-scrolling-attribute-expected.checksum: Added.
platform/mac/fast/frames/iframe-scrolling-attribute-expected.png: Added.
platform/mac/fast/frames/iframe-scrolling-attribute-expected.txt: Added.

9:36 AM Changeset in webkit [29721] by hyatt@apple.com

2 edits in trunk/WebCore

Fix for <rdar://problem/5698481> REGRESSION: Web Inspector source view gutter double divider and no padding

Now that cellpadding cascades properly on <td>s, we need to make the view source padding rules in the user
agent sheet have !important in order to override author settings.

Reviewed by Tim

css/view-source.css:

8:09 AM Changeset in webkit [29720] by Nikolas Zimmermann

5 edits in trunk/WebCore

Reviewed by Alp.
Allow to use SVGPaintServerSolid without RenderObject/RenderStyle. Used later to draw SVG Fonts in HTML.

6:57 AM Changeset in webkit [29719] by Nikolas Zimmermann

2 edits in trunk/WebCore

Reviewed by Alp.

Initialize missing variables, m_lineGap / m_lineSpacing.
Only noticeable when trying to render HTML text using SVG Fonts (which is not possible with trunk, but with my local version).

5:53 AM Changeset in webkit [29718] by alp@webkit.org

4 edits in trunk/WebCore

2008-01-22 Alp Toker <alp@atoker.com>

Reviewed by Nikolas.

Fix Cairo SVG fonts following changes in r29700.

Set the font description's details as needed in FontPlatformData and
eliminate GraphicsContext::setPlatformFont() since it was redundant
and assumed all fonts were Cairo fonts.

platform/graphics/GraphicsContext.cpp:
platform/graphics/cairo/GraphicsContextCairo.cpp:
platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):

3:10 AM Changeset in webkit [29717] by Nikolas Zimmermann