Context Navigation

Adds simplified UndoManager to windows DRT to allow testing the undo/redo code paths in WebCore and WebKit. This is a temporary solution to an issue that should eventually be solved by having a shared UndoManager in WebKit.

DumpRenderTree/win/DumpRenderTree.cpp: (runTest):
DumpRenderTree/win/UIDelegate.cpp: (DRTUndoObject::DRTUndoObject): (DRTUndoObject::invoke): (DRTUndoStack::~DRTUndoStack): (DRTUndoStack::isEmpty): (DRTUndoStack::clear): (DRTUndoStack::push): (DRTUndoStack::pop): (DRTUndoManager::canRedo): (DRTUndoManager::canUndo): (DRTUndoManager::DRTUndoManager): (DRTUndoManager::removeAllActions): (DRTUndoManager::registerUndoWithTarget): (DRTUndoManager::redo): (DRTUndoManager::undo): (UIDelegate::UIDelegate): (UIDelegate::resetUndoManager): (UIDelegate::registerUndoWithTarget): (UIDelegate::removeAllActionsWithTarget): (UIDelegate::setActionTitle): (UIDelegate::undo): (UIDelegate::redo): (UIDelegate::canUndo): (UIDelegate::canRedo):
DumpRenderTree/win/UIDelegate.h:

LayoutTests:

Reviewed by Ada Chan.

<rdar://5131975> DumpRenderTree doesn't support undo/redo

platform/win/Skipped: With undo/redo support enabled, we can now remove the undo tests from the Skipped list.

3:50 PM Changeset in webkit [29781] by Adam Roben

6 edits in trunk/WebCore

Better fix for Bug 16996

Rubberstamped by Mitz.

loader/CachedFont.cpp: (WebCore::CachedFont::ensureCustomFontData): Don't call createFontCustomPlatformData if m_data is null.
platform/graphics/gtk/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Added an assertion.
platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Ditto.
platform/graphics/qt/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Ditto.
platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Ditto.

3:13 PM Changeset in webkit [29780] by Adam Roben

3 edits
2 adds in trunk

Fix Bug 16996: Crash in createFontCustomPlatformData when loading 0-byte font via @font-face

WebCore:

Fix Bug 16996: Crash in createFontCustomPlatformData when loading
0-byte font via @font-face

<http://bugs.webkit.org/show_bug.cgi?id=16996>

Reviewed by Hyatt.

Test: fast/loader/font-face-empty.html

platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Null-check the buffer parameter.

LayoutTests:

Test for Bug 16996: Crash in createFontCustomPlatformData when loading
0-byte font via @font-face

<http://bugs.webkit.org/show_bug.cgi?id=16996>

Reviewed by Hyatt.

fast/loader/font-face-empty-expected.txt: Added.
fast/loader/font-face-empty.html: Added.

2:02 PM Changeset in webkit [29779] by hyatt@apple.com

1 edit in trunk/LayoutTests/platform/mac/editing/selection/end-of-document-expected.txt

Update results for an editing test that changed from Acid3 fix.

1:53 PM Changeset in webkit [29778] by jhoneycutt@apple.com

6 edits
1 add in trunk/WebCore

2008-01-24 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://problem/5588807> Crash in Flash when destroying plug-in (found
using yahoo beta mail)

Flash can dereference NULL in the call to NPP_URLNotify if a request
made with NPN_PostURLNotify fails before NPP_NewStream is called.

Work around this by creating a quirk, PluginQuirkFlashURLNotifyBug, and
checking for this quirk before calling NPP_URLNotify for any request
made with NPN_PostURLNotify. If the quirk is present, call NPP_NewStream
and NPP_DestroyStream before calling NPP_URLNotify.

WebCore.vcproj/WebCore.vcproj:
plugins/PluginQuirkSet.h: Added. Moved quirks out of PluginViewWin so PluginViewWin and PluginStream could share it. Created a class, PluginQuirkSet, to store plug-in quirks (WebCore::): (WebCore::PluginQuirkSet::PluginQuirkSet): (WebCore::PluginQuirkSet::add): (WebCore::PluginQuirkSet::contains):
plugins/PluginStream.cpp: (WebCore::PluginStream::PluginStream): Copy the PluginQuirkSet for this plug-in (WebCore::PluginStream::destroyStream): Check for the FlashURLNotifyBug quirk
plugins/PluginStream.h:
plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Pass the quirks when creating the PluginStream (WebCore::PluginViewWin::didReceiveResponse): Same (WebCore::PluginViewWin::wndProc): Use add / contains instead of bit ops (WebCore::PluginViewWin::userAgent): Same (WebCore::PluginViewWin::invalidateRect): Same (WebCore::PluginViewWin::~PluginViewWin): Same (WebCore::PluginViewWin::determineQuirks): Same (WebCore::PluginViewWin::setParameters): Same (WebCore::PluginViewWin::PluginViewWin): Same (WebCore::PluginViewWin::init): Same (WebCore::PluginViewWin::setCallingPlugin): Same
plugins/win/PluginViewWin.h:

1:52 PM Changeset in webkit [29777] by hyatt@apple.com

3 adds in trunk/LayoutTests/platform/mac/fast/parser

Add test results for Acid3 buckets parsing issue.

1:51 PM Changeset in webkit [29776] by hyatt@apple.com

1 add in trunk/LayoutTests/fast/parser/style-script-head-test.html

Add test of Acid3 buckets parsing issue.

1:49 PM Changeset in webkit [29775] by hyatt@apple.com

2 edits in trunk/WebCore

http://bugs.webkit.org/show_bug.cgi?id=16982

Make sure to make <head> the current block if it is created before a <body> already exists.

Reviewed by Dan

html/HTMLParser.cpp: (WebCore::HTMLParser::createHead):

11:40 AM Changeset in webkit [29774] by ap@webkit.org

4 edits
2 deletes in trunk

http://bugs.webkit.org/show_bug.cgi?id=16993
<rdar://problem/5704331> REGRESSION: Loading page leads to many unexpected redirections

Rolled out r29590, which was not a correct fix for <rdar://problem/5692566>.

10:24 AM Changeset in webkit [29773] by Antti Koivisto

4 edits
2 adds in trunk

WebCore:

Reviewed by Adam.

If the media is playing and the load stalls the playback wont restart by seeking backwards.

We should be in CAN_PLAY state if the current time is less than the maximum loaded time. Rate
tricks were for streaming case and are not necessary now since that is now disabled.

Windows patch coming separately.

Test: http/tests/media/video-play-stall-seek.html

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates):

LayoutTests:

Reviewed by Adam.

Test that playback can be resumed by seeking backwards after a stall.

http/tests/media/video-play-stall-seek-expected.txt: Added.
http/tests/media/video-play-stall-seek.html: Added.
platform/win/Skipped:

10:18 AM Changeset in webkit [29772] by Antti Koivisto

11 edits in trunk/WebCore

Reviewed by Adam.

Fix <rdar://problem/5684815>
After navigating back to the page that contains a <audio> that has been muted, the audio is still heard

get rid of the separate muted state in MediaPlayer, maintain the state in the cross platform code only
remove volumeChanged() callbacks from HTMLMediaElement and OS X MediaPlayer, they were not used for anything
rename updateMediaPlayer -> updatePlayState which tells more about what it actually does

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause): (WebCore::HTMLMediaElement::setVolume): (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::checkIfSeekNeeded): (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): (WebCore::HTMLMediaElement::updateVolume): (WebCore::HTMLMediaElement::updatePlayState): (WebCore::HTMLMediaElement::setPausedInternal):
html/HTMLMediaElement.h:
platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer):
platform/graphics/MediaPlayer.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie):
platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
platform/graphics/win/QTMovieWin.cpp:
platform/graphics/win/QTMovieWin.h:

9:38 AM Changeset in webkit [29771] by Adam Roben

2 edits in trunk/WebKit/win

Build fix

WebView.cpp: Added a comma.

9:27 AM Changeset in webkit [29770] by Adam Roben

2 edits in trunk/WebKitTools

Allow directories containing ChangeLogs to be passed to resolve-ChangeLogs

Reviewed by David Kilzer.

Scripts/resolve-ChangeLogs: (sub findChangeLog): Return a ChangeLog contained within the specified directory if one exists.

8:36 AM Changeset in webkit [29769] by ap@webkit.org

2 edits in trunk/WebKit/win

Reviewed by Adam Roben.

<rdar://problem/5702734> REGRESSION(r28936/r15890): Shift+del does not work in win Safari

WebView.cpp: Fixed keyDownEntries to list this shortcut (and related ones, for consistency).

6:52 AM Changeset in webkit [29768] by Simon Hausmann

2 edits in trunk/WebCore

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Fix "QObject::startTimer: QTimer can only be used with threads started with QThread"
The JSC GCController gets automatically destructed on application exit, it will stop its timer and we try to schedule the next timer. Now the GCController can get destructed after our QApplication is gone. This will trigger the above warning, we can avoid this by checking if our qApp is still around.

6:27 AM Changeset in webkit [29767] by Simon Hausmann

2 edits in trunk/WebCore

Morten Johan Sørvig <msorvig@trolltech.com>

Qt/Mac: Make sure the scrollbars does not overlap the grow box.

When showing only one scrollbar we need to move it so it doesn't overlap the
grow box. This is similar to the code in QAbstractScrollArea.

6:24 AM Changeset in webkit [29766] by Simon Hausmann

4 edits in trunk/WebKit/qt

David Boddie <dboddie@trolltech.com>

Documentation tidying.

6:23 AM Changeset in webkit [29765] by Simon Hausmann

2 edits in trunk/WebKit/qt

Jarek Kobus <jkobus@trolltech.com>

Text for translations were used wrongly as comments

6:18 AM Changeset in webkit [29764] by Simon Hausmann

3 edits
2 adds in trunk

Michael Goddard <michael.goddard@trolltech.com>

http://bugs.webkit.org/show_bug.cgi?id=16888

Fix for CSS crash in -webkit-border-image.
Reviewed by Darin.

While parsing -webkit-border-image, store
the border widths as naked pointers rather
than as OwnPtrs, since they point to the
middle of an array.

Test: fast/css/border-image-crash.html

6:13 AM Changeset in webkit [29763] by Simon Hausmann

2 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

We have a KURL->QUrl conversion on KURL itself, make use of it.
This conversion is supposed to be loss-free

6:08 AM Changeset in webkit [29762] by Simon Hausmann

3 edits in trunk/WebCore

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Attempt to fix showing of popup again after a popup has been shown but the user did not select any item (e.g. clicked outside of the popup)
Keep track of the popup status using the virtuals showPopup and hidePopup and do not go into recursion when hiding a popup.

6:01 AM Changeset in webkit [29761] by Simon Hausmann

2 edits in trunk/WebCore

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Assert the presence of the PopupMenuClient

5:56 AM Changeset in webkit [29760] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Michael Goddard <michael.goddard@trolltech.com>

Fix QDateTime to JS Date conversion.
Several conversion errors (some UTC related, some month
offset related) and the conversion distance for Date
to DateTime conversion weights were fixed (it should never
be better to convert a JS Number into a Date rather than
an int).

5:51 AM Changeset in webkit [29759] by Simon Hausmann

6 edits in trunk/JavaScriptCore

Michael Goddard <michael.goddard@trolltech.com>

Add support for calling QObjects.
Add support for invokeDefaultMethod (via a call to
a specific slot), and also allow using it as a
constructor, like QtScript.

5:44 AM Changeset in webkit [29758] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Michael Goddard <michael.goddard@trolltech.com>

Code style cleanups.
Add spaces before/after braces in inline function.

5:41 AM Changeset in webkit [29757] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Michael Goddard <michael.goddard@trolltech.com>

Code style cleanups.
Remove spaces and unneeded declared parameter names.

5:37 AM Changeset in webkit [29756] by Simon Hausmann

4 edits in trunk/JavaScriptCore

Michael Goddard <michael.goddard@trolltech.com>

Clear stale RuntimeObjectImps.
Since other objects can have refs to the QtInstance,
we can't rely on the QtInstance being deleted when the
RuntimeObjectImp is invalidate or deleted. This
could result in a stale JSObject being returned for
a valid Instance.

Jan 23, 2008:

11:44 PM Changeset in webkit [29755] by mrowe@apple.com

4 edits in trunk

Versioning.

11:42 PM Changeset in webkit [29754] by mrowe@apple.com

1 copy in tags/Safari-5525.6

New tag.

4:47 PM Changeset in webkit [29753] by ddkilzer@apple.com

2 edits in trunk/WebCore

<rdar://problem/5702947> WebCore: CGContextDrawPDFDocument will be deprecated

Reviewed by Darin.

No test cases added since there is no change in behavior.

platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::draw): Replace CGContextDrawPDFDocument() with calls to CG methods that perform the equivalent work.

3:08 PM Changeset in webkit [29752] by Antti Koivisto

4 edits in trunk/WebCore

Reviewed by Hyatt, Adele.

Timers for media controls keep running when the page is in the page cache.

Stop timers in RenderMedia and get rid of the controls tree when the page goes to the cache.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::willSaveToCache): (WebCore::HTMLMediaElement::didRestoreFromCache):
html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::inPageCache):
rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):

2:26 PM Changeset in webkit [29751] by Antti Koivisto

2 edits in trunk/WebCore

Reviewed by Adam.

Video that had already played to the end would start playing (from beginning) on back/forward navigation.

Use setPausedInternal() instead of pause(). This avoid generating pause/play events and matches specification text.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::willSaveToCache):

2:20 PM Changeset in webkit [29750] by ap@webkit.org

5 edits
6 adds in trunk

Reviewed by Darin.

<rdar://problem/4200075> Missing support for accented chars in mailto forms

With some combinations of form parameters, this was resulting in regressed behavior.

Tests: fast/forms/mailto/get-non-ascii-text-plain-latin-1.html

fast/forms/mailto/post-text-plain-with-accept-charset.html
fast/forms/mailto/post-text-plain.html

html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Ignore accept-charset for mailto forms, which are always encoded as UTF-8. (WebCore::HTMLFormElement::isMailtoForm): Added. (WebCore::HTMLFormElement::dataEncoding): Added (factored out from formData). (WebCore::HTMLFormElement::submit): When round-tripping in text/plain case, use utf-8 encoding.
html/HTMLFormElement.h: Added a isMailtoForm() function. It may be a bit unfortunate that its result is calculated repeatedly, but this doesn't seem to be anywhere near hot code.

2:04 PM Changeset in webkit [29749] by sfalken@apple.com

7 edits in trunk

WebCore:

Reviewed by Alice Liu.

<rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updateFromElement): If value == text() and m_innerText is empty, then value and text() are "". In that case both DOM mutations are no-ops and there is no reason to clear the Undo stack.

WebKit/win:

<rdar://problem/5698732> Copyright strings should include 2008

Reviewed by Sam.

WebKit.vcproj/WebKit.rc:

WebKitTools:

<rdar://problem/5698732> Copyright strings should include 2008

Reviewed by Sam.

Drosera/win/Drosera.vcproj/Drosera.rc:
DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:

1:51 PM Changeset in webkit [29748] by justin.garcia@apple.com

3 edits
2 adds in trunk

WebCore:

Reviewed by Alice Liu.

<rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updateFromElement): If value == text() and m_innerText is empty, then value and text() are "". In that case both DOM mutations are no-ops and there is no reason to clear the Undo stack.

LayoutTests:

Reviewed by Alice Liu.

<rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

editing/undo/5658727-expected.txt: Added.
editing/undo/5658727.html: Added.

1:08 PM Changeset in webkit [29747] by Adam Roben

2 edits in trunk/WebKit/win

Fix <rdar://5698502> Inspector window reverts to default position/size unexpectedly

Reviewed by Hyatt.

WebInspectorClient.cpp: (defaultWindowRect): Added. (WebInspectorClient::createPage):
- Use defaultWindowRect() to set the initial size/position of the Inspector window.
- Pass the Inspector window's client rect to IWebView::initWithFrame so that the WebView will be initially sized to fill the window.

(WebInspectorClient::showWindow): Don't move/resize the window back to
the defaults every time this method is called.

1:07 PM Changeset in webkit [29746] by Adam Roben

3 edits
2 adds in trunk

Fix <rdar://5700620> REGRESSION (r28190): "Open frame in new tab" instead of "Open link in new tab" @ digg.com

WebKit/win:

Fix <rdar://5700620> REGRESSION (r28190): "Open frame in new tab" instead of "Open link in new tab" @ digg.com

Test: fast/events/contextmenu-scrolled-page-with-frame.html

Reviewed by Dan.

WebView.cpp: (WebView::handleContextMenuEvent): Translate the mouse coordinates into document coordinates before performing the hit-test. This is what EventHandler does internally.

LayoutTests:

Add a test for <rdar://5700620> REGRESSION (r28190): "Open frame in
new tab" instead of "Open link in new tab" @ digg.com

Reviewed by Dan.

fast/events/contextmenu-scrolled-page-with-frame-expected.txt: Added.
fast/events/contextmenu-scrolled-page-with-frame.html: Added.

11:43 AM Changeset in webkit [29745] by sfalken@apple.com

9 edits in trunk

WebCore:

<rdar://problem/5699509> Allow file upload dialog to be localized.

Reviewed by Darin.

platform/LocalizedStrings.h:
platform/win/FileChooserWin.cpp: (WebCore::FileChooser::openFileChooser):

WebKit:

Update localization exceptions.

Reviewed by Darin.

English.lproj/Localizable.strings:
StringsNotToBeLocalized.txt:

WebKit/win:

<rdar://problem/5699509> Allow file upload dialog to be localized.

Reviewed by Darin.

English.lproj/Localizable.strings: Updated.
WebCoreLocalizedStrings.cpp: (WebCore::uploadFileText): Added. (WebCore::allFilesText): Added.

9:49 AM Changeset in webkit [29744] by dsmith@webkit.org

1 edit
19 adds in trunk/WebKitSite

Reviewed by Darin.

Added a modified version of the MooTools SlickSpeed Selector Test/Benchmark to show off querySelectorAll. MIT licensed.

perf/slickspeed: Added.
perf/slickspeed/config.ini: Added.
perf/slickspeed/footer.html: Added.
perf/slickspeed/frameworks: Added.
perf/slickspeed/frameworks/DomQuery.js: Added.
perf/slickspeed/frameworks/dummy.js: Added.
perf/slickspeed/frameworks/jquery-1.2.1.js: Added.
perf/slickspeed/frameworks/prototype.js: Added.
perf/slickspeed/header.html: Added.
perf/slickspeed/index.php: Added.
perf/slickspeed/instructions.txt: Added.
perf/slickspeed/logo.png: Added.
perf/slickspeed/selectors.list: Added.
perf/slickspeed/style.css: Added.
perf/slickspeed/system: Added.
perf/slickspeed/system/index.php: Added.
perf/slickspeed/system/slickspeed.js: Added.
perf/slickspeed/system/template.php: Added.
perf/slickspeed/template.html: Added.

9:38 AM Changeset in webkit [29743] by Adam Roben

2 edits in trunk/WebCore

Fix behavior of type-to-select in <select> menus

In r27825 we started posting both a WM_KEYDOWN and WM_CHAR message
whenever a key was pressed in the dropdown menu. However, since posted
messages go through TranslateMessage, the WM_KEYDOWN was generating
another WM_CHAR message, so two WM_CHAR messages in a row would reach
the WebView. This caused the searching to happen twice for each key,
so typing "dog" would search for "ddoogg".

Reviewed by Darin.

platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc): Repost the WM_KEYDOWN message to the WebView. This is will generate a WM_CHAR message which will trigger the type-to-select behavior. This is very similar to our behavior prior to r27825, except that we're now calling PostMessage instead of SendMessage.

8:18 AM Changeset in webkit [29742] by mitz@apple.com

4 edits in trunk/LayoutTests

updated results following <http://trac.webkit.org/projects/webkit/changeset/29721>

platform/mac/fast/frames/viewsource-attribute-expected.checksum:
platform/mac/fast/frames/viewsource-attribute-expected.png:
platform/mac/fast/frames/viewsource-attribute-expected.txt:

7:55 AM Changeset in webkit [29741] by alp@webkit.org

8 edits in trunk

2008-01-23 Alp Toker <alp@atoker.com>

Rubber-stamped by Mark Rowe.

Remove whitespace after -I in automake include lists.

3:16 AM Changeset in webkit [29740] by Simon Hausmann

2 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Fix leaking of sub frames (WebCore::Frame). We keep one reference too many. This was found while working on the page-cache, other ports are not affected.
Rubber stamped by Simon

3:14 AM Changeset in webkit [29739] by Simon Hausmann

2 edits in trunk/WebCore

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Load images incrementally. This will show warnings on the console and we want to fix them for Qt4.4. If that happens we have to remove the comment from the enum inside the ImageDecoderQt.cpp

Rubber stamped by Simon

3:11 AM Changeset in webkit [29738] by Simon Hausmann

2 edits in trunk/WebKit/qt

Rohan McGovern <rohan.mcgovern@trolltech.com>

Fix Qtopia compilation with QT_NO_TOOLTIP

3:11 AM Changeset in webkit [29737] by Simon Hausmann

2 edits in trunk/WebKit/qt

Geir Vattekar <gvatteka@trolltech.com>

Doc: Replaced \code with snippets in the docs

3:10 AM Changeset in webkit [29736] by Simon Hausmann

2 edits in trunk/WebCore

Lars Knoll <lars@trolltech.com>

Fix rendering of the Scrollbar as well as mouse handling for some styles.

The QStyle expects that that painter is set up to clip to the scrollbar bounds
and some of the styles seem to paint somewhat outside of these bounds. Clipping to
the scrollbar bounds before drawing removes some artifacts.

Also set m_opt.rect.topLeft to (0/0) in the mouse handlers. Fixes some issues with
the oxygen style.

1:55 AM Changeset in webkit [29735] by Simon Hausmann

3 edits in trunk/WebCore

Michael Brasser <michael.brasser@trolltech.com>

Rendering fixes for Qtopia.

Make the focus ring work with line breaks (until we have QPainterPath::simplify) and
call QStyle with better arguments when painting themed elements.

1:55 AM Changeset in webkit [29734] by Simon Hausmann

3 edits in trunk/WebCore

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

FormData::flatten does not include to be uploaded files. Create our own QIODevice for the QNetworkAccessManager and feed the complete content of the FormData* to the (HTTP) backend.
Try to optimize the ::readData implementation to fill the buffer as best as possible

1:55 AM Changeset in webkit [29733] by Simon Hausmann

2 edits in trunk/WebCore

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Coding-Style fixes

1:48 AM Changeset in webkit [29732] by Simon Hausmann

2 edits in trunk/WebCore

Michael Brasser <michael.brasser@trolltech.com>

use PopupClient's font for popup menu. Otherwise, in Qtopia, the popup's font is much bigger (QApplication::font()?) and the text doesn't fit.

1:44 AM Changeset in webkit [29731] by Simon Hausmann

2 edits in trunk/WebKit/qt

Benjamin Meyer <bmeyer@trolltech.com>

Tweak key presses even to match commonly expected behavior

space key == page down
page down moved down not a page, but slightly less then a page so you don't loose your spot when reading.
Use font height rather then a hard coded "10" for left, right, up, down
Ctrl-Up moves to the top of the page
Ctrl-Down move to the bottom of the page
Backspace == GoBack
Shift-Backspace == GoForward

1:43 AM Changeset in webkit [29730] by Simon Hausmann

7 edits in trunk

Implemented FrameLoaderClient::startDownload() and FrameLoaderClient::download().

Added two signals to QWebPage to handle downloading of links and handling of
unsupported content.

1:39 AM Changeset in webkit [29729] by Simon Hausmann

12 edits in trunk

Michael Goddard <michael.goddard@trolltech.com>

Reworked the JavaScriptCore Qt bindings:

Add initial support for string and variant arrays, as well as sub QObjects in the JS bindings.

Don't expose fields marked as not scriptable by moc.

Add support for dynamic properties and accessing named QObject children of an object (like QtScript and older IE DOM style JS).
Add support for custom toString methods.

Fine tune some bindings to be closer to QtScript. Make void functions return undefined, and empty/ null QStrings return a zero length string.

Create framework for allowing more direct method calls. Since RuntimeMethod doesn't allow us to add additional methods/properties to a function, add these classes. Start prototyping object.signal.connect(...).

Add signal support to the Qt bindings. Allow connecting to signals (object.signal.connect(slot)), disconnecting, and emitting signals. Currently chooses the first signal that matches the name, so this will need improvement.

Add property names, and resolve signals closer to use. Enumerating properties now returns some of the Qt properties and signals. Slots and methods aren't quite present. Also, resolve signal connections etc. closer to the time of use, so we can do more dynamic resolution based on argument type etc. Still picks the first one with the same name, at the moment.

Make signature comparison code consistent. Use the same code for checking meta signatures in the method and fallback getters, and avoid a QByteArray construction when we can.

Fix minor memory leak, and handle pointers better. Delete the private object in the dtors, and use RefPtrs for holding Instances etc.

Handle method lookup better. Allow invocation time method lookup based on the arguments, which is closer to QtScript behaviour. Also, cache the method lists and delete them in the QtClass dtor (stops a memory leak).

Improve JS to Qt data type conversions. Add some support for Date & RegExp JS objects, and provide some metrics on the quality of the conversion.

A couple of fixes for autotest failures. Better support for converting lists, read/write only QMetaProperty support, modified slot search order...)

Update JS DRT controller for Qt JS binding changes. There were two functions that needed some changes so that the layout tests would work, so this makes a few tests pass again.

Bump the timeout for layout tests up to 11s. At least some tests have an internal timeout of 10 seconds, so make the waitUntilDone approach wait at least 11s. fast/dom/open-and-close-by-DOM.html is one of these - now the failure message is more accurate.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed