⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 25, 2008:

11:58 PM Changeset in webkit [29803] by oliver@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix typo in changelog

11:54 PM Changeset in webkit [29802] by oliver@apple.com
  • 6 edits in trunk

Fix for bug 17012: REGRESSION: JSC can't round trip an object literal

Reviewed by Maciej.

Add logic to ensure that object literals and function expressions get
parenthesis when necessary.

5:16 PM Changeset in webkit [29801] by Stephanie Lewis
  • 1 edit in trunk/WebCore/ChangeLog

fix changelog

5:09 PM Changeset in webkit [29800] by Stephanie Lewis
  • 2 edits in trunk/WebCore

2008-01-25 U-SLEWIS-WIN\Stephanie <Stephanie Lewis>

Reviewed by Tim.

expand workaround for <rdar://5695848> to include js files so that the
web inspector can work

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):
5:03 PM Changeset in webkit [29799] by Antti Koivisto
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Adele.


(this is for r29798, my commit failed to include the log)


Windows fix to match r29773
If the media is playing and the load stalls the playback wont restart by seeking backwards.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::updateStates):
3:41 PM Changeset in webkit [29798] by Antti Koivisto
  • 1 edit in trunk/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp

Reviewed by Adele.


Windows fix to match r29773
If the media is playing and the load stalls the playback wont restart by seeking backwards.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::updateStates):
3:40 PM Changeset in webkit [29797] by Darin Adler
  • 12 edits
    2 adds in trunk

WebCore:

Reviewed by Anders.

  • fix <rdar://problem/5691072> ASSERTION FAILED: isPrepared() when executing an empty statement

For empty statements, SQLite returns 0 for the statement. We have to cope with that.

Test: storage/empty-statement.html

  • platform/sql/SQLiteStatement.cpp: (WebCore::sqlite3_prepare16_v2): Added overload so we don't need an #if inside the prepare function. (WebCore::SQLiteStatement::SQLiteStatement): Initialize the m_isPrepared boolean. Removed the code to add a null character to the end of the string; instead we will use charactersWithNullTermination. (WebCore::SQLiteStatement::prepare): Set m_isPrepared based on the error value returned. Use the error value from sqlite3_prepare16_v2, not from lastError(). (WebCore::SQLiteStatement::step): Assert that the statement is prepared rather than checking it at runtime. However, in the case where this is called with m_statement of 0, return success rather than an error. That's needed for empty statements. (WebCore::SQLiteStatement::finalize): Use early return idiom for clarity. When there is no statement, return SQLITE_OK instead of calling lastError(). (WebCore::SQLiteStatement::reset): Use early return idiom for clarity. When there is no statement, return SQLITE_OK rather than SQLITE_ERROR, but assert the statement is prepared. (WebCore::SQLiteStatement::executeCommand): Adjust the code that does a prepare so that it will work for empty statements. Do we really need to allow calling this without prepare? It would be simpler to just be able to assert that it's prepared. (WebCore::SQLiteStatement::returnsAtLeastOneResult): Ditto. (WebCore::SQLiteStatement::bindBlob): Added some assertions. Return SQLITE_ERROR if this is called with m_statement of 0 (should not be possible without assertions firing first). Return the actual error code rather than lastError(). (WebCore::SQLiteStatement::bindText): Ditto. Also simplified the special case for empty strings, since it requires any non-null pointer, not a pointer to a global zero character. (WebCore::SQLiteStatement::bindInt64): Ditto. (WebCore::SQLiteStatement::bindDouble): Ditto. (WebCore::SQLiteStatement::bindNull): Ditto. (WebCore::SQLiteStatement::bindValue): Moved default case out of the switch to take advantage of the gcc compiler warning for unhandled enum values in a switch. (WebCore::SQLiteStatement::bindParameterCount): Added assertion and code to handle the empty statement case. (WebCore::SQLiteStatement::columnCount): Added assertion and changed the code to use the early-return idiom. (WebCore::SQLiteStatement::getColumnName): Removed getColumnName16 -- we always use 16-bit characters and have no reason to ever use the 8-bit function. Added assertions about the passed-in column number. It's a little strange that this function checks the column number for too-large column numbers, but not for negative ones. I didn't change that for now. (WebCore::SQLiteStatement::getColumnText): Ditto. (WebCore::SQLiteStatement::getColumnDouble): Ditto. (WebCore::SQLiteStatement::getColumnInt): Ditto. (WebCore::SQLiteStatement::getColumnInt64): Ditto. (WebCore::SQLiteStatement::getColumnBlobAsVector): Ditto. (WebCore::SQLiteStatement::getColumnBlob): Tightened up function a bit, including use of the early-return idiom and replacing the multiple "size = 0" with a single one at the start of the function. (WebCore::SQLiteStatement::returnTextResults): Added a failure case when the prepare call doesn't work. Cleared the vector earlier to make the failure code simpler. Moved the declaration of the result boolean down lower to make it clearer what it's for. Changed use of lastError() to call on the database, to make it clearer that there's no per-statement last error kept around. It'd be even better to not use lastError() here. (WebCore::SQLiteStatement::returnIntResults): Ditto. (WebCore::SQLiteStatement::returnInt64Results): Ditto. (WebCore::SQLiteStatement::returnDoubleResults): Ditto.
(WebCore::SQLiteStatement::isExpired): Changed to use
rather than ?: because I think

it's slightly easier to read that way.

  • platform/sql/SQLiteStatement.h: Removed unneeded includes and forward declarations. Also removed unnneeded functions isPrepared, getColumnName16, getColumnText16, returnTextResults16, lastError, and lastErrorMsg. Changed prepareAndStep so that it checks the result of prepare before callling step. Added a debug-only m_isPrepared boolean.
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::checkIntegrity): Remove 16 suffix from text-related function names. (WebCore::IconDatabase::performURLImport): Ditto. (WebCore::IconDatabase::pruneUnretainedIcons): Ditto.
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::clearAllTables): Ditto.
  • storage/Database.cpp: (WebCore::retrieveTextResultFromDatabase): Ditto. (WebCore::Database::performGetTableNames): Ditto.
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): Ditto. (WebCore::DatabaseTracker::populateOrigins): Ditto. (WebCore::DatabaseTracker::databaseNamesForOrigin): Ditto. (WebCore::DatabaseTracker::addDatabase): Ditto.
  • storage/SQLStatement.cpp: (WebCore::SQLStatement::execute): Ditto.
  • platform/sql/SQLiteDatabase.h: Removed unneeded includes.
  • storage/SQLResultSet.h: Ditto.
  • storage/SQLResultSetRowList.h: Ditto.

LayoutTests:

Reviewed by Anders.

  • test for <rdar://problem/5691072> ASSERTION FAILED: isPrepared() when executing an empty statement
  • storage/empty-statement-expected.txt: Added.
  • storage/empty-statement.html: Added.
3:07 PM Changeset in webkit [29796] by Antti Koivisto
  • 7 edits in trunk/LayoutTests

Reviewed by Darin.


Fix <rdar://problem/5674282>
Some media tests fail on Windows


  • fix the script to exit cleanly
  • slightly increase the amount of data to hand out before stalling, apparently QT on Windows needs more to start playback
2:28 PM Changeset in webkit [29795] by adele@apple.com
  • 89 edits
    4 adds in trunk

WebCore:

Reviewed by Sam.

Fix for <rdar://problem/5679452> Finish tweaking layout/alignment of media controls slider to match QuickTime plug-in

  • css/html4.css: Add horizontal padding to the media slider.
  • rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): Replace use of absoluteBoundingBox() with width() and height() (WebCore::RenderSlider::positionForOffset): ditto. Also, use the trackSize() for the maximum offset. (WebCore::RenderSlider::layout): Use contentWidth() and contentHeight() to take padding into account. (WebCore::RenderSlider::trackSize): ditto.

LayoutTests:

Reviewed by Sam.

Adding new test and updated results for:
<rdar://problem/5679452> Finish tweaking layout/alignment of media controls slider to match QuickTime plug-in

  • fast/forms/slider-padding.html: Added.
  • platform/mac/fast/forms/slider-padding-expected.checksum: Added.
  • platform/mac/fast/forms/slider-padding-expected.png: Added.
  • platform/mac/fast/forms/slider-padding-expected.txt: Added.
  • platform/mac/media/audio-controls-rendering-expected.checksum:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/broken-video-expected.checksum:
  • platform/mac/media/broken-video-expected.png:
  • platform/mac/media/progress-event-expected.checksum:
  • platform/mac/media/progress-event-expected.png:
  • platform/mac/media/unsupported-rtsp-expected.checksum:
  • platform/mac/media/unsupported-rtsp-expected.png:
  • platform/mac/media/unsupported-tracks-expected.checksum:
  • platform/mac/media/unsupported-tracks-expected.png:
  • platform/mac/media/video-append-source-expected.checksum:
  • platform/mac/media/video-append-source-expected.png:
  • platform/mac/media/video-autoplay-expected.checksum:
  • platform/mac/media/video-autoplay-expected.png:
  • platform/mac/media/video-buffered-expected.checksum:
  • platform/mac/media/video-buffered-expected.png:
  • platform/mac/media/video-controls-expected.checksum:
  • platform/mac/media/video-controls-expected.png:
  • platform/mac/media/video-controls-rendering-expected.checksum:
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-currentTime-set2-expected.checksum:
  • platform/mac/media/video-currentTime-set2-expected.png:
  • platform/mac/media/video-display-toggle-expected.checksum:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-dom-autoplay-expected.checksum:
  • platform/mac/media/video-dom-autoplay-expected.png:
  • platform/mac/media/video-dom-src-expected.checksum:
  • platform/mac/media/video-dom-src-expected.png:
  • platform/mac/media/video-dom-start-expected.checksum:
  • platform/mac/media/video-dom-start-expected.png:
  • platform/mac/media/video-error-abort-expected.checksum:
  • platform/mac/media/video-error-abort-expected.png:
  • platform/mac/media/video-error-does-not-exist-expected.checksum:
  • platform/mac/media/video-error-does-not-exist-expected.png:
  • platform/mac/media/video-load-networkState-expected.checksum:
  • platform/mac/media/video-load-networkState-expected.png:
  • platform/mac/media/video-load-readyState-expected.checksum:
  • platform/mac/media/video-load-readyState-expected.png:
  • platform/mac/media/video-muted-expected.checksum:
  • platform/mac/media/video-muted-expected.png:
  • platform/mac/media/video-no-autoplay-expected.checksum:
  • platform/mac/media/video-no-autoplay-expected.png:
  • platform/mac/media/video-pause-empty-events-expected.checksum:
  • platform/mac/media/video-pause-empty-events-expected.png:
  • platform/mac/media/video-play-empty-events-expected.checksum:
  • platform/mac/media/video-play-empty-events-expected.png:
  • platform/mac/media/video-play-pause-events-expected.checksum:
  • platform/mac/media/video-play-pause-events-expected.png:
  • platform/mac/media/video-play-pause-exception-expected.checksum:
  • platform/mac/media/video-play-pause-exception-expected.png:
  • platform/mac/media/video-seek-past-end-paused-expected.checksum:
  • platform/mac/media/video-seek-past-end-paused-expected.png:
  • platform/mac/media/video-seek-past-end-playing-expected.checksum:
  • platform/mac/media/video-seek-past-end-playing-expected.png:
  • platform/mac/media/video-seekable-expected.checksum:
  • platform/mac/media/video-seekable-expected.png:
  • platform/mac/media/video-seeking-expected.checksum:
  • platform/mac/media/video-seeking-expected.png:
  • platform/mac/media/video-size-expected.checksum:
  • platform/mac/media/video-size-expected.png:
  • platform/mac/media/video-source-expected.checksum:
  • platform/mac/media/video-source-expected.png:
  • platform/mac/media/video-source-media-expected.checksum:
  • platform/mac/media/video-source-media-expected.png:
  • platform/mac/media/video-source-type-expected.checksum:
  • platform/mac/media/video-source-type-expected.png:
  • platform/mac/media/video-src-change-expected.checksum:
  • platform/mac/media/video-src-change-expected.png:
  • platform/mac/media/video-src-expected.checksum:
  • platform/mac/media/video-src-expected.png:
  • platform/mac/media/video-src-remove-expected.checksum:
  • platform/mac/media/video-src-remove-expected.png:
  • platform/mac/media/video-src-set-expected.checksum:
  • platform/mac/media/video-src-set-expected.png:
  • platform/mac/media/video-src-source-expected.checksum:
  • platform/mac/media/video-src-source-expected.png:
  • platform/mac/media/video-start-expected.checksum:
  • platform/mac/media/video-start-expected.png:
  • platform/mac/media/video-volume-expected.checksum:
  • platform/mac/media/video-volume-expected.png:
  • platform/mac/media/video-width-height-expected.checksum:
  • platform/mac/media/video-width-height-expected.png:
1:38 PM Changeset in webkit [29794] by Antti Koivisto
  • 3 edits in trunk/LayoutTests

<rdar://problem/5674277>
Test media/video-display-toggle.html crashes on Windows


Appears to be some problem in DRT when test ends with layout pending.
Fixed by forcing layout, this improves test coverage too.

  • media/video-display-toggle.html:
  • platform/win/Skipped:
10:31 AM Changeset in webkit [29793] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-01-25 Ori Bernstein <​ori@eigenstate.org>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16795
WebKitGtk crashes when there is no focused Frame

Add a null check. focusedFrame() isn't used directly anywhere else so
this is the only case that needs to be fixed.

  • WebView/webkitwebview.cpp:
7:01 AM Changeset in webkit [29792] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

<rdar://problem/5706788> http/tests/security/cross-frame-access-port-explicit-domain.html fails on Windows

  • platform/win/Skipped:
6:42 AM Changeset in webkit [29791] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

http/tests/xmlhttprequest/readystatechange.html fails on buildbot.

  • platform/win/Skipped:
3:45 AM Changeset in webkit [29790] by ap@webkit.org
  • 3 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

<rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing

  • DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment (matching Mac DRT).
  • DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
1:14 AM S60IDE edited by mgroeber@gmx.net
Adding info about missing variant.cfg update (diff)

Jan 24, 2008:

5:50 PM Changeset in webkit [29789] by sfalken@apple.com
  • 3 edits in tags/Safari-5525.6.1/WebKit/win

Merged r29785

5:49 PM Changeset in webkit [29788] by sfalken@apple.com
  • 2 edits in tags/Safari-5525.6.1/JavaScriptCore

Merged r29784

5:46 PM Changeset in webkit [29787] by sfalken@apple.com
  • 2 edits in tags/Safari-5525.6.1/JavaScriptCore

Merged r29783

5:16 PM Changeset in webkit [29786] by sfalken@apple.com
  • 1 copy in tags/Safari-5525.6.1

New tag.

5:13 PM Changeset in webkit [29785] by sfalken@apple.com
  • 3 edits in trunk/WebKit/win

Build fix

  • WebKit.vcproj/WebKit.sln:
  • WebKit.vcproj/WebKit.submit.sln:
5:08 PM Changeset in webkit [29784] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

5:07 PM Changeset in webkit [29783] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

4:51 PM Changeset in webkit [29782] by weinig@apple.com
  • 6 edits in trunk

WebKitTools:

Reviewed by Ada Chan.

Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo

  • Adds simplified UndoManager to windows DRT to allow testing the undo/redo code paths in WebCore and WebKit. This is a temporary solution to an issue that should eventually be solved by having a shared UndoManager in WebKit.
  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest):
  • DumpRenderTree/win/UIDelegate.cpp: (DRTUndoObject::DRTUndoObject): (DRTUndoObject::invoke): (DRTUndoStack::~DRTUndoStack): (DRTUndoStack::isEmpty): (DRTUndoStack::clear): (DRTUndoStack::push): (DRTUndoStack::pop): (DRTUndoManager::canRedo): (DRTUndoManager::canUndo): (DRTUndoManager::DRTUndoManager): (DRTUndoManager::removeAllActions): (DRTUndoManager::registerUndoWithTarget): (DRTUndoManager::redo): (DRTUndoManager::undo): (UIDelegate::UIDelegate): (UIDelegate::resetUndoManager): (UIDelegate::registerUndoWithTarget): (UIDelegate::removeAllActionsWithTarget): (UIDelegate::setActionTitle): (UIDelegate::undo): (UIDelegate::redo): (UIDelegate::canUndo): (UIDelegate::canRedo):
  • DumpRenderTree/win/UIDelegate.h:

LayoutTests:

Reviewed by Ada Chan.

<rdar://5131975> DumpRenderTree doesn't support undo/redo

  • platform/win/Skipped: With undo/redo support enabled, we can now remove the undo tests from the Skipped list.
3:50 PM Changeset in webkit [29781] by Adam Roben
  • 6 edits in trunk/WebCore

Better fix for Bug 16996

Rubberstamped by Mitz.

  • loader/CachedFont.cpp: (WebCore::CachedFont::ensureCustomFontData): Don't call createFontCustomPlatformData if m_data is null.
  • platform/graphics/gtk/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Added an assertion.
  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Ditto.
  • platform/graphics/qt/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Ditto.
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Ditto.
3:13 PM Changeset in webkit [29780] by Adam Roben
  • 3 edits
    2 adds in trunk

Fix Bug 16996: Crash in createFontCustomPlatformData when loading 0-byte font via @font-face

WebCore:

Fix Bug 16996: Crash in createFontCustomPlatformData when loading
0-byte font via @font-face

<​http://bugs.webkit.org/show_bug.cgi?id=16996>

Reviewed by Hyatt.

Test: fast/loader/font-face-empty.html

  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Null-check the buffer parameter.

LayoutTests:

Test for Bug 16996: Crash in createFontCustomPlatformData when loading
0-byte font via @font-face

<​http://bugs.webkit.org/show_bug.cgi?id=16996>

Reviewed by Hyatt.

  • fast/loader/font-face-empty-expected.txt: Added.
  • fast/loader/font-face-empty.html: Added.
2:02 PM Changeset in webkit [29779] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/editing/selection/end-of-document-expected.txt

Update results for an editing test that changed from Acid3 fix.

1:53 PM Changeset in webkit [29778] by jhoneycutt@apple.com
  • 6 edits
    1 add in trunk/WebCore

2008-01-24 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://problem/5588807> Crash in Flash when destroying plug-in (found
using yahoo beta mail)

Flash can dereference NULL in the call to NPP_URLNotify if a request
made with NPN_PostURLNotify fails before NPP_NewStream is called.

Work around this by creating a quirk, PluginQuirkFlashURLNotifyBug, and
checking for this quirk before calling NPP_URLNotify for any request
made with NPN_PostURLNotify. If the quirk is present, call NPP_NewStream
and NPP_DestroyStream before calling NPP_URLNotify.

  • WebCore.vcproj/WebCore.vcproj:
  • plugins/PluginQuirkSet.h: Added. Moved quirks out of PluginViewWin so PluginViewWin and PluginStream could share it. Created a class, PluginQuirkSet, to store plug-in quirks (WebCore::): (WebCore::PluginQuirkSet::PluginQuirkSet): (WebCore::PluginQuirkSet::add): (WebCore::PluginQuirkSet::contains):
  • plugins/PluginStream.cpp: (WebCore::PluginStream::PluginStream): Copy the PluginQuirkSet for this plug-in (WebCore::PluginStream::destroyStream): Check for the FlashURLNotifyBug quirk
  • plugins/PluginStream.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Pass the quirks when creating the PluginStream (WebCore::PluginViewWin::didReceiveResponse): Same (WebCore::PluginViewWin::wndProc): Use add / contains instead of bit ops (WebCore::PluginViewWin::userAgent): Same (WebCore::PluginViewWin::invalidateRect): Same (WebCore::PluginViewWin::~PluginViewWin): Same (WebCore::PluginViewWin::determineQuirks): Same (WebCore::PluginViewWin::setParameters): Same (WebCore::PluginViewWin::PluginViewWin): Same (WebCore::PluginViewWin::init): Same (WebCore::PluginViewWin::setCallingPlugin): Same
  • plugins/win/PluginViewWin.h:
1:52 PM Changeset in webkit [29777] by hyatt@apple.com
  • 3 adds in trunk/LayoutTests/platform/mac/fast/parser

Add test results for Acid3 buckets parsing issue.

1:51 PM Changeset in webkit [29776] by hyatt@apple.com
  • 1 add in trunk/LayoutTests/fast/parser/style-script-head-test.html

Add test of Acid3 buckets parsing issue.

1:49 PM Changeset in webkit [29775] by hyatt@apple.com
  • 2 edits in trunk/WebCore

​http://bugs.webkit.org/show_bug.cgi?id=16982

Make sure to make <head> the current block if it is created before a <body> already exists.

Reviewed by Dan

  • html/HTMLParser.cpp: (WebCore::HTMLParser::createHead):
11:40 AM Changeset in webkit [29774] by ap@webkit.org
  • 4 edits
    2 deletes in trunk

​http://bugs.webkit.org/show_bug.cgi?id=16993
<rdar://problem/5704331> REGRESSION: Loading page leads to many unexpected redirections

Rolled out r29590, which was not a correct fix for <rdar://problem/5692566>.

10:24 AM Changeset in webkit [29773] by Antti Koivisto
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Adam.


If the media is playing and the load stalls the playback wont restart by seeking backwards.


We should be in CAN_PLAY state if the current time is less than the maximum loaded time. Rate
tricks were for streaming case and are not necessary now since that is now disabled.


Windows patch coming separately.

Test: http/tests/media/video-play-stall-seek.html

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates):

LayoutTests:

Reviewed by Adam.


Test that playback can be resumed by seeking backwards after a stall.

  • http/tests/media/video-play-stall-seek-expected.txt: Added.
  • http/tests/media/video-play-stall-seek.html: Added.
  • platform/win/Skipped:
10:18 AM Changeset in webkit [29772] by Antti Koivisto
  • 11 edits in trunk/WebCore

Reviewed by Adam.

Fix <rdar://problem/5684815>
After navigating back to the page that contains a <audio> that has been muted, the audio is still heard


  • get rid of the separate muted state in MediaPlayer, maintain the state in the cross platform code only
  • remove volumeChanged() callbacks from HTMLMediaElement and OS X MediaPlayer, they were not used for anything
  • rename updateMediaPlayer -> updatePlayState which tells more about what it actually does
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause): (WebCore::HTMLMediaElement::setVolume): (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::checkIfSeekNeeded): (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): (WebCore::HTMLMediaElement::updateVolume): (WebCore::HTMLMediaElement::updatePlayState): (WebCore::HTMLMediaElement::setPausedInternal):
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer):
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/win/QTMovieWin.cpp:
  • platform/graphics/win/QTMovieWin.h:
9:38 AM Changeset in webkit [29771] by Adam Roben
  • 2 edits in trunk/WebKit/win

Build fix

  • WebView.cpp: Added a comma.
9:27 AM Changeset in webkit [29770] by Adam Roben
  • 2 edits in trunk/WebKitTools

Allow directories containing ChangeLogs to be passed to resolve-ChangeLogs

Reviewed by David Kilzer.

  • Scripts/resolve-ChangeLogs: (sub findChangeLog): Return a ChangeLog contained within the specified directory if one exists.
8:36 AM Changeset in webkit [29769] by ap@webkit.org
  • 2 edits in trunk/WebKit/win

Reviewed by Adam Roben.

<rdar://problem/5702734> REGRESSION(r28936/r15890): Shift+del does not work in win Safari

  • WebView.cpp: Fixed keyDownEntries to list this shortcut (and related ones, for consistency).
6:52 AM Changeset in webkit [29768] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Fix "QObject::startTimer: QTimer can only be used with threads started with QThread"
  • The JSC GCController gets automatically destructed on application exit, it will stop its timer and we try to schedule the next timer. Now the GCController can get destructed after our QApplication is gone. This will trigger the above warning, we can avoid this by checking if our qApp is still around.
6:27 AM Changeset in webkit [29767] by Simon Hausmann
  • 2 edits in trunk/WebCore

Morten Johan Sørvig <​msorvig@trolltech.com>

Qt/Mac: Make sure the scrollbars does not overlap the grow box.

When showing only one scrollbar we need to move it so it doesn't overlap the
grow box. This is similar to the code in QAbstractScrollArea.

6:24 AM Changeset in webkit [29766] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

David Boddie <​dboddie@trolltech.com>

Documentation tidying.

6:23 AM Changeset in webkit [29765] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Jarek Kobus <​jkobus@trolltech.com>

Text for translations were used wrongly as comments

6:18 AM Changeset in webkit [29764] by Simon Hausmann
  • 3 edits
    2 adds in trunk

Michael Goddard <​michael.goddard@trolltech.com>

​http://bugs.webkit.org/show_bug.cgi?id=16888

Fix for CSS crash in -webkit-border-image.
Reviewed by Darin.

While parsing -webkit-border-image, store
the border widths as naked pointers rather
than as OwnPtrs, since they point to the
middle of an array.

Test: fast/css/border-image-crash.html

6:13 AM Changeset in webkit [29763] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • We have a KURL->QUrl conversion on KURL itself, make use of it.
  • This conversion is supposed to be loss-free
6:08 AM Changeset in webkit [29762] by Simon Hausmann
  • 3 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Attempt to fix showing of popup again after a popup has been shown but the user did not select any item (e.g. clicked outside of the popup)
  • Keep track of the popup status using the virtuals showPopup and hidePopup and do not go into recursion when hiding a popup.
6:01 AM Changeset in webkit [29761] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Assert the presence of the PopupMenuClient
5:56 AM Changeset in webkit [29760] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Michael Goddard <​michael.goddard@trolltech.com>

Fix QDateTime to JS Date conversion.
Several conversion errors (some UTC related, some month
offset related) and the conversion distance for Date
to DateTime conversion weights were fixed (it should never
be better to convert a JS Number into a Date rather than
an int).

5:51 AM Changeset in webkit [29759] by Simon Hausmann
  • 6 edits in trunk/JavaScriptCore

Michael Goddard <​michael.goddard@trolltech.com>

Add support for calling QObjects.
Add support for invokeDefaultMethod (via a call to
a specific slot), and also allow using it as a
constructor, like QtScript.

5:44 AM Changeset in webkit [29758] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Michael Goddard <​michael.goddard@trolltech.com>

Code style cleanups.
Add spaces before/after braces in inline function.

5:41 AM Changeset in webkit [29757] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Michael Goddard <​michael.goddard@trolltech.com>

Code style cleanups.
Remove spaces and unneeded declared parameter names.

5:37 AM Changeset in webkit [29756] by Simon Hausmann
  • 4 edits in trunk/JavaScriptCore

Michael Goddard <​michael.goddard@trolltech.com>

Clear stale RuntimeObjectImps.
Since other objects can have refs to the QtInstance,
we can't rely on the QtInstance being deleted when the
RuntimeObjectImp is invalidate or deleted. This
could result in a stale JSObject being returned for
a valid Instance.

Note: See TracTimeline for information about the timeline view.