Context Navigation

Added an isSVGFont method to CachedFont and use it to decide how to
process the font data. Currently whether the data is SVG is determined
based on the format property in the @font-face rule, but in the future
the MIME type or other metadata may be used when the format is
unspecified.

css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData): Changed to parse the data as SVG only if the CachedFont is an SVG font.
css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Mark the CachedFont as an SVG font based on format.
loader/CachedFont.cpp: (WebCore::CachedFont::CachedFont): Initialize m_isSVGFont to false. (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::ensureSVGFontData): (WebCore::CachedFont::getSVGFontById):
loader/CachedFont.h: (WebCore::CachedFont::isSVGFont): Added. (WebCore::CachedFont::setSVGFont): Added.

LayoutTests:

Reviewed by Dave Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=17085 <rdar://problem/5714136> REGRESSION (r29839): All remote fonts are treated as SVG fonts

This is the first @font-face test that actually tests loading font data
from a URL.

fast/css/font-face-remote.html: Added.
fast/css/resources/Ahem.ttf: Added.
platform/mac/fast/css/font-face-remote-expected.checksum: Added.
platform/mac/fast/css/font-face-remote-expected.png: Added.
platform/mac/fast/css/font-face-remote-expected.txt: Added.

7:43 PM Changeset in webkit [29863] by Adam Roben

2 edits in trunk/WebKit/win

Fix a crash when opening the Inspector

Reviewed by Anders.

WebInspectorClient.cpp: (WebInspectorClient::createPage): Call WebPreferences::initWithIdentifier so our custom WebPreferences will have all its members initialized.

6:45 PM Changeset in webkit [29862] by Adam Roben

2 edits in trunk/WebKit/win

Fix Bug 16786: "Display images when page opens" preference affects Inspector

<http://bugs.webkit.org/show_bug.cgi?id=16786>
<rdar://5712914>

Reviewed by Anders and Darin.

WebInspectorClient.cpp: (WebInspectorClient::createPage): Create our own custom WebPreferences so that we won't be affected by global preference changes. This matches what Mac does.

6:38 PM Changeset in webkit [29861] by Antti Koivisto

3 edits in trunk/WebCore

Some comment cleanup.

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::load): (QTMovieWin::disableUnsupportedTracks):

6:00 PM Changeset in webkit [29860] by adele@apple.com

1 edit
108 deletes in trunk/LayoutTests

Reviewed by Oliver.

Remove pixel results for text-only tests that I mistakingly added.

platform/mac/media/audio-constructor-expected.checksum: Removed.
platform/mac/media/audio-constructor-expected.png: Removed.
platform/mac/media/audio-constructor-src-expected.checksum: Removed.
platform/mac/media/audio-constructor-src-expected.png: Removed.
platform/mac/media/broken-video-expected.checksum: Removed.
platform/mac/media/broken-video-expected.png: Removed.
platform/mac/media/constructors-expected.checksum: Removed.
platform/mac/media/constructors-expected.png: Removed.
platform/mac/media/fallback-expected.checksum: Removed.
platform/mac/media/fallback-expected.png: Removed.
platform/mac/media/progress-event-expected.checksum: Removed.
platform/mac/media/progress-event-expected.png: Removed.
platform/mac/media/remove-from-document-expected.checksum: Removed.
platform/mac/media/remove-from-document-expected.png: Removed.
platform/mac/media/unsupported-rtsp-expected.checksum: Removed.
platform/mac/media/unsupported-rtsp-expected.png: Removed.
platform/mac/media/unsupported-tracks-expected.checksum: Removed.
platform/mac/media/unsupported-tracks-expected.png: Removed.
platform/mac/media/video-append-source-expected.checksum: Removed.
platform/mac/media/video-append-source-expected.png: Removed.
platform/mac/media/video-autoplay-expected.checksum: Removed.
platform/mac/media/video-autoplay-expected.png: Removed.
platform/mac/media/video-buffered-expected.checksum: Removed.
platform/mac/media/video-buffered-expected.png: Removed.
platform/mac/media/video-controls-expected.checksum: Removed.
platform/mac/media/video-controls-expected.png: Removed.
platform/mac/media/video-currentTime-expected.checksum: Removed.
platform/mac/media/video-currentTime-expected.png: Removed.
platform/mac/media/video-currentTime-set-expected.checksum: Removed.
platform/mac/media/video-currentTime-set-expected.png: Removed.
platform/mac/media/video-currentTime-set2-expected.checksum: Removed.
platform/mac/media/video-currentTime-set2-expected.png: Removed.
platform/mac/media/video-dom-autoplay-expected.checksum: Removed.
platform/mac/media/video-dom-autoplay-expected.png: Removed.
platform/mac/media/video-dom-end-expected.checksum: Removed.
platform/mac/media/video-dom-end-expected.png: Removed.
platform/mac/media/video-dom-loopcount-expected.checksum: Removed.
platform/mac/media/video-dom-loopcount-expected.png: Removed.
platform/mac/media/video-dom-loopend-expected.checksum: Removed.
platform/mac/media/video-dom-loopend-expected.png: Removed.
platform/mac/media/video-dom-loopstart-expected.checksum: Removed.
platform/mac/media/video-dom-loopstart-expected.png: Removed.
platform/mac/media/video-dom-src-expected.checksum: Removed.
platform/mac/media/video-dom-src-expected.png: Removed.
platform/mac/media/video-dom-start-expected.checksum: Removed.
platform/mac/media/video-dom-start-expected.png: Removed.
platform/mac/media/video-end-expected.checksum: Removed.
platform/mac/media/video-end-expected.png: Removed.
platform/mac/media/video-error-abort-expected.checksum: Removed.
platform/mac/media/video-error-abort-expected.png: Removed.
platform/mac/media/video-error-does-not-exist-expected.checksum: Removed.
platform/mac/media/video-error-does-not-exist-expected.png: Removed.
platform/mac/media/video-load-networkState-expected.checksum: Removed.
platform/mac/media/video-load-networkState-expected.png: Removed.
platform/mac/media/video-load-readyState-expected.checksum: Removed.
platform/mac/media/video-load-readyState-expected.png: Removed.
platform/mac/media/video-loopcount-expected.checksum: Removed.
platform/mac/media/video-loopcount-expected.png: Removed.
platform/mac/media/video-loopend-expected.checksum: Removed.
platform/mac/media/video-loopend-expected.png: Removed.
platform/mac/media/video-loopstart-expected.checksum: Removed.
platform/mac/media/video-loopstart-expected.png: Removed.
platform/mac/media/video-muted-expected.checksum: Removed.
platform/mac/media/video-muted-expected.png: Removed.
platform/mac/media/video-no-autoplay-expected.checksum: Removed.
platform/mac/media/video-no-autoplay-expected.png: Removed.
platform/mac/media/video-pause-empty-events-expected.checksum: Removed.
platform/mac/media/video-pause-empty-events-expected.png: Removed.
platform/mac/media/video-play-empty-events-expected.checksum: Removed.
platform/mac/media/video-play-empty-events-expected.png: Removed.
platform/mac/media/video-play-pause-events-expected.checksum: Removed.
platform/mac/media/video-play-pause-events-expected.png: Removed.
platform/mac/media/video-play-pause-exception-expected.checksum: Removed.
platform/mac/media/video-play-pause-exception-expected.png: Removed.
platform/mac/media/video-poster-expected.checksum: Removed.
platform/mac/media/video-poster-expected.png: Removed.
platform/mac/media/video-seek-past-end-paused-expected.checksum: Removed.
platform/mac/media/video-seek-past-end-paused-expected.png: Removed.
platform/mac/media/video-seek-past-end-playing-expected.checksum: Removed.
platform/mac/media/video-seek-past-end-playing-expected.png: Removed.
platform/mac/media/video-seekable-expected.checksum: Removed.
platform/mac/media/video-seekable-expected.png: Removed.
platform/mac/media/video-seeking-expected.checksum: Removed.
platform/mac/media/video-seeking-expected.png: Removed.
platform/mac/media/video-size-expected.checksum: Removed.
platform/mac/media/video-size-expected.png: Removed.
platform/mac/media/video-source-expected.checksum: Removed.
platform/mac/media/video-source-expected.png: Removed.
platform/mac/media/video-source-media-expected.checksum: Removed.
platform/mac/media/video-source-media-expected.png: Removed.
platform/mac/media/video-source-type-expected.checksum: Removed.
platform/mac/media/video-source-type-expected.png: Removed.
platform/mac/media/video-src-change-expected.checksum: Removed.
platform/mac/media/video-src-change-expected.png: Removed.
platform/mac/media/video-src-expected.checksum: Removed.
platform/mac/media/video-src-expected.png: Removed.
platform/mac/media/video-src-remove-expected.checksum: Removed.
platform/mac/media/video-src-remove-expected.png: Removed.
platform/mac/media/video-src-set-expected.checksum: Removed.
platform/mac/media/video-src-set-expected.png: Removed.
platform/mac/media/video-src-source-expected.checksum: Removed.
platform/mac/media/video-src-source-expected.png: Removed.
platform/mac/media/video-start-expected.checksum: Removed.
platform/mac/media/video-start-expected.png: Removed.
platform/mac/media/video-volume-expected.checksum: Removed.
platform/mac/media/video-volume-expected.png: Removed.
platform/mac/media/video-width-height-expected.checksum: Removed.
platform/mac/media/video-width-height-expected.png: Removed.

5:40 PM Changeset in webkit [29859] by adele@apple.com

4 edits in trunk

WebCore:

Reviewed by Antti.

Fix for <rdar://5683527> media/{audio,videocontrols-rendering.html failing

rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::isControlStyled): Don't treat all media controls as styled. This causes builds with an old version of SafariTheme to have different metrics for these controls.

LayoutTests:

Reviewed by Antti.

Removing test from Skipped list for <rdar://5683527> media/{audio,videocontrols-rendering.html failing

platform/win/Skipped:

4:52 PM Changeset in webkit [29858] by mitz@apple.com

2 edits in trunk/LayoutTests

re-add a couple of tests that are still failing back to the list

platform/win/Skipped:

4:28 PM Changeset in webkit [29857] by mitz@apple.com

4 edits in trunk/WebCore

Reviewed by Dave Hyatt.

make Font instances cache their primary font

WebCore.base.exp:
platform/graphics/Font.cpp: (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::cachePrimaryFont): (WebCore::Font::update):
platform/graphics/Font.h: (WebCore::Font::primaryFont):

4:18 PM Changeset in webkit [29856] by ggaren@apple.com

25 edits
2 adds in trunk

WebKitTools:

Reviewed by Sam Weinig. Sam Weinig.

Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
fails when run after fast/dom/Window/window-property-shadowing.html (16902)

Modified our policy delegates not to output window.name. Since a
previous test may have explicitly set window.name, we can't rely on its
implicit value in test results.

DumpRenderTree/mac/PolicyDelegate.mm: (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):

DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::decidePolicyForNavigationAction):

LayoutTests:

Reviewed by Sam Weinig. Sam Weinig.

Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
fails when run after fast/dom/Window/window-property-shadowing.html (16902)

These layout tests demonstrate the expected behavior of window.name,
including the fact that one test can change the window.name value seen
by another test:

fast/dom/Window/window-property-shadowing-name-expected.txt: Added.
fast/dom/Window/window-property-shadowing-name.html: Added.
fast/dom/Window/window-property-clearing-expected.txt:
fast/dom/Window/window-property-clearing.html:

Modified these expected results not to depend on window.name. Since a
previous test may have explicitly set window.name, we can't rely on its
implicit value:

fast/encoding/mailto-always-utf-8-expected.txt:
fast/forms/mailto/advanced-get-expected.txt:
fast/forms/mailto/advanced-put-expected.txt:
fast/forms/mailto/get-multiple-items-expected.txt:
fast/forms/mailto/get-multiple-items-text-plain-expected.txt:
fast/forms/mailto/get-multiple-items-x-www-form-urlencoded-expected.txt:
fast/forms/mailto/get-non-ascii-always-utf-8-expected.txt:
fast/forms/mailto/get-non-ascii-expected.txt:
fast/forms/mailto/get-non-ascii-text-plain-expected.txt:
fast/forms/mailto/get-non-ascii-text-plain-latin-1-expected.txt:
fast/forms/mailto/get-overwrite-query-expected.txt:
fast/forms/mailto/post-append-query-expected.txt:
fast/forms/mailto/post-multiple-items-expected.txt:
fast/forms/mailto/post-multiple-items-multipart-form-data-expected.txt:
fast/forms/mailto/post-multiple-items-text-plain-expected.txt:
fast/forms/mailto/post-multiple-items-x-www-form-urlencoded-expected.txt:
fast/forms/mailto/post-text-plain-expected.txt:
fast/forms/mailto/post-text-plain-with-accept-charset-expected.txt:
http/tests/security/feed-urls-from-remote-expected.txt:

4:16 PM Changeset in webkit [29855] by mitz@apple.com

2 edits in trunk/WebCore

Leopard build fix

platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):

4:13 PM Changeset in webkit [29854] by mrowe@apple.com

8 edits
4 adds in trunk

<rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).

Reviewed by Tim Hatcher.

3:03 PM Changeset in webkit [29853] by mitz@apple.com

4 edits in trunk

WebCore:

Reviewed by Adam Roben and Oliver Hunt.

fix <rdar://problem/5713131> REGRESSION (r29246): Many SVG font tests are failing

platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): Use double instead of float for consistent rounding behavior between Mac OS X and Windows.

LayoutTests:

Reviewed by Adam Roben and Oliver Hunt.

remove skipped tests after fixing <rdar://problem/5713131> REGRESSION (r29246): Many SVG font tests are failing

platform/win/Skipped:

3:03 PM Changeset in webkit [29852] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

Refactor ChangeLog path code

Reviewed by Adam.

Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract duplicate code in another foreach() loop.

2:33 PM Changeset in webkit [29851] by Adam Roben

5 edits in trunk

Fix <rdar://5713302> Web Inspector on Windows is not using the localized strings

WebCore:

Fix <rdar://5713302> Web Inspector on Windows is not using the
localized strings

Reviewed by Steve.

WebCore.vcproj/WebCore.vcproj: Copy InspectorLocalizedStrings.js to $WebKitOutputDir.
page/InspectorController.cpp: Touch this to force the project to build.

WebKit/win:

Fix <rdar://5713302> Web Inspector on Windows is not using the
localized strings

Reviewed by Steve.

WebInspectorClient.cpp: (getWebKitBundle): Added. (WebInspectorClient::createPage): Call getWebKitBundle. (WebInspectorClient::localizedStringsURL): Implemented.

2:22 PM Changeset in webkit [29850] by eric@webkit.org

4 edits
2 adds in trunk

Reviewed by Nikolas.

Acid3 after double-attach
http://bugs.webkit.org/show_bug.cgi?id=17058

I believe SVGTextPathElement::buildPendingResource() was entirely
bogus, removing it did not cause any tests to fail.

Test: svg/custom/textPath-assert.svg

svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::insertedIntoDocument): remove buildPendingResource()
svg/SVGTextPathElement.h:

1:35 PM Changeset in webkit [29849] by Adam Roben

2 edits in trunk/WebCore

Fix Bug 16234: Inspector should support searching for elements by CSS selectors

<http://bugs.webkit.org/show_bugs.cgi?id=16234>
<rdar://5712862>

Reviewed by Tim.

page/inspector/inspector.js: Use Document.querySelectorAll to search for elements by CSS selector. Also store a custom property on nodes being added to the search results to avoid showing the same node more than once.

12:20 PM Changeset in webkit [29848] by Adam Roben

2 edits in trunk/LayoutTests

platform/win/Skipped: Added new failures.

11:55 AM Changeset in webkit [29847] by Adam Roben

2 edits in trunk/WebCore

Fix <rdar://5711136> Full-screen Flash on 1up.com is unresponsive

Reviewed by Anders and Darin.

No test possible.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::wndProc): Set/release capture on mouse down/up, like Firefox does.

9:18 AM Changeset in webkit [29846] by ap@webkit.org

6 edits in trunk

Reviewed by Darin.

<rdar://problem/5710692> All storage tests fail/crash

WebKit:

WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Clients that do not implement database quota callbacks should have no database support - but not crash.

WebKitTools:

DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an arbitrary quota of 5 megabytes.

(-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
(-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
Removed unused (I think) code.

DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported. (UIDelegate::webViewPainted): A stub implementation. (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
DumpRenderTree/win/UIDelegate.h:

3:47 AM Changeset in webkit [29845] by ap@webkit.org

2 edits in trunk/WebKitLibraries

Debug (external) build fix.

Removed _DEBUG preprocessor definition, which indicates that debug libraries are used (while they aren't).
This preprocessor definition is automatically set by Visual Studio as needed anyway.

win/tools/vsprops/debug.vsprops:

Jan 28, 2008:

9:32 PM Changeset in webkit [29844] by mitz@apple.com

5 edits in trunk/WebCore

Reviewed by Sam Weinig.

make isSVGFont non-virtual

platform/graphics/FontData.h:
platform/graphics/SegmentedFontData.cpp:
platform/graphics/SegmentedFontData.h:
platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::isSVGFont):

6:05 PM Changeset in webkit [29843] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Adam Roben.

fix <rdar://problem/5700824> Chunky scrolling + scrolling artifacts @ netflix.com/Notebook

platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::valueChanged): Send the scroll event before updating the window, thus giving event handlers a chance to update layout for the new scroll position, eliminating the jitter.

6:03 PM Changeset in webkit [29842] by eric@webkit.org

2 edits
1 copy
4 adds in trunk/JavaScriptGlue

Reviewed by darin.

Add icu headers to JSG in preparation for depending on ::UChar.

Configurations/Base.xcconfig:
ForwardingHeaders/wtf/unicode: Added.
ForwardingHeaders/wtf/unicode/Unicode.h: Added.
ForwardingHeaders/wtf/unicode/icu: Added.
ForwardingHeaders/wtf/unicode/icu/UnicodeIcu.h: Added.
icu: Copied from ../JavaScriptCore/icu.

5:55 PM Changeset in webkit [29841] by Adam Roben

2 edits in trunk/WebCore

Fix <rdar://5555260> Gmail doesn't load when a user stylesheet is specified

Reviewed by Darin.

A null value exception was being thrown in Gmail's JS code because a
call to document.write failed. document.write failed because
Document::close had not yet been called. Document::close was not
called because the Document was considered to not be "complete" in
FrameLoader::checkComplete because the user stylesheet was in the
process of loading. The user stylesheet was loading because it had
previously been evicted from the cache and was loading fresh from
disk. It had been evicted from the cache because the calculation of
the expiration date was incorrectly casting/overflowing in
ResourceResponseCFNet.cpp.

We now calculate the expiration date in a way that does not cause us
to overflow a time_t, and we correctly clamp the value to the range of
a time_t. I also made the fix for the last modified date, though that
was not causing any bug I am aware of.

In the long-term it seems like whether or not Document::close is
called should not be dependent upon whether the user stylesheet has
finished loading or not.

platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::toTimeT): Added. Converts from CFAbsoluteTime to time_t and clamps to the range of time_t. (WebCore::ResourceResponse::doUpdateResourceResponse): Call toTimeT.

4:41 PM Changeset in webkit [29840] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Nikolas Zimmermann.

fix leaks introduced in r29838

svg/SVGFont.cpp: (WebCore::floatWidthMissingGlyphCallback): (WebCore::drawTextMissingGlyphCallback):

3:37 PM Changeset in webkit [29839] by Nikolas Zimmermann

23 edits
5 adds in trunk

Reviewed by Eric, Dan & Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=16980

Support external SVG Fonts, by reusing the custom font handling logic.
This enables us - as first engine - to render HTML pages using SVG Fonts.

Fixes fonts-elem-03-b.svg / fonts-elem-04-b.svg / fonts-elem-07-b.svg
Add new testcase svg-fonts-in-html.html.

2:47 PM Changeset in webkit [29838] by mitz@apple.com

4 edits in trunk

WebCore:

Reviewed by Adam Roben.

fix svg/W3C-SVG-1.1/fonts-glyph-04-t.svg failure on Windows

The results differed between Mac OS X and Windows because the code was
using a 0-size font, which Mac OS X changes to 12pt.

svg/SVGFont.cpp: (WebCore::floatWidthMissingGlyphCallback): Use the font description of the primary font to initialize the fallback font. (WebCore::drawTextMissingGlyphCallback): Ditto.

LayoutTests:

Reviewed by Adam Roben.

updated results for a test that was failing on Windows

platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:

1:30 PM Changeset in webkit [29837] by eric@webkit.org

6 edits in trunk/WebCore

Reviewed by Nikolas Zimmermann.

Use class instead of struct to appease MSVC.

history/HistoryItem.h:
loader/FrameLoaderClient.h:
page/InspectorController.h:
platform/network/ResourceRequestBase.h:
platform/network/mac/ResourceRequest.h:

12:50 PM Changeset in webkit [29836] by weinig@apple.com

4 edits in trunk/JavaScriptCore

Rubber-stamped by Darin Adler.

Fix whitespace in nodes.h/cpp and nodes2string.cpp.

(NOTE: Specific changed functions elided for space and clarity)

kjs/nodes.cpp:
kjs/nodes.h:
kjs/nodes2string.cpp:

12:04 PM Changeset in webkit [29835] by ap@webkit.org

2 edits in trunk/LayoutTests

<rdar://problem/5667017> storage/execute-sql-args.html failing -- openDatabase returning null on buildbot

platform/win/Skipped: Removed a passing test.

9:40 AM Changeset in webkit [29834] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

Reviewed by Darin Adler.

fix http://bugs.webkit.org/show_bug.cgi?id=16774 REGRESSION (r27464-r27504) javascript popup menu does not display 'close' button

Test: fast/dynamic/float-no-longer-overhanging.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::addOverhangingFloats): If a child's float turns out not to be overhanging at this time, ensure that the child paints it.

LayoutTests: