⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 30, 2008:

9:39 PM Changeset in webkit [29884] by mitz@apple.com
  • 9 edits
    4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • change the interpretation of unicode-range values in "from-to" form to include the "to" character.

Test: fast/css/font-face-unicode-range.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseFontFaceUnicodeRange):
  • css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::overlayRange):
  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage):
  • platform/graphics/SegmentedFontData.cpp: (WebCore::SegmentedFontData::fontDataForCharacter): (WebCore::SegmentedFontData::containsCharacters):

LayoutTests:

Reviewed by Sam Weinig.

  • add a test for the unicode-range @font-face property
  • update @font-face rules in existing tests after changing unicode-range values in "from-to" form to include the "to" character
  • fast/css/font-face-unicode-range.html: Added.
  • fast/css/rtl-ordering.html:
  • fast/text/international/resources/Mac-compatible-font-fallback.css:
  • platform/mac-leopard/fast/css/font-face-unicode-range-expected.checksum: Added.
  • platform/mac-leopard/fast/css/font-face-unicode-range-expected.png: Added.
  • platform/mac/fast/css/font-face-unicode-range-expected.txt: Added.
  • platform/win/css2.1/resources/Mac-compatible-font-fallback.css:
9:36 PM Changeset in webkit [29883] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • prune references to custom fonts' SimpleFontData from the glyph page tree when they are destroyed
  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::pruneTable):
6:45 PM Changeset in webkit [29882] by justin.garcia@apple.com
  • 1 add
    1 delete in trunk/LayoutTests/editing/style

This test started failed with my last checkin. The new results are *correct* but I don't know why my changes would have fixed the test, so I want to investigate a bit before I check in new results.

5:45 PM Changeset in webkit [29881] by timothy@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

New fix for <rdar://problem/5688428> Reproducible assertion failure
in SQLTransaction::performNextStep() (16876)

Fixes a deadlock that was happening for all Database use. All
storage layout tests pass.

  • storage/Database.cpp: (WebCore::CurrentThreadSetter::CurrentThreadSetter): New helper class to set the current thread and zero it on destruction. (WebCore::CurrentThreadSetter::~CurrentThreadSetter): Set threadIdentifierStorage to 0. (WebCore::Database::Database): Set m_transactionStepThread to 0. (WebCore::Database::performTransactionStep): Set m_transactionStepThread to currentThread(). (WebCore::Database::scheduleTransactionCallback): Assert m_transactionStepThread is currentThread().
  • storage/Database.h: Add m_transactionStepThread for debug builds to track which thread performTransactionStep() was called on.
5:23 PM Changeset in webkit [29880] by Stephanie Lewis
  • 2 edits in trunk/WebKitTools

2008-01-30 Stephanie <Stephanie Lewis>

Reviewed by Geoff.

Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth. This should make it easier for the buildbots to track new leaks.

  • Scripts/run-webkit-tests:
4:55 PM Changeset in webkit [29879] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

ASSERTION FAILED: JSLock::lockCount() > 0 when opening the
Web Inspector on a page with a Database.

Fix the ASSERT by taking a JSLock before calling toJS().

  • page/InspectorController.cpp: (WebCore::InspectorController::addDatabaseScriptResource):
4:43 PM Changeset in webkit [29878] by Beth Dakin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5598609> CrashTracer: [USER] 626 crashes in
Safari at com.apple.WebCore: WebCore::FrameView::needsFullRepaint
const + 6

The real problem here is tracked by rdar://5598072, which is that
frames can lose sync between their view and their document when a
non-HTML view is loaded (such as bookmarks view or a PDF). That can
cause this crash if the layout timer fires before things have fixed
themselves. This fix turns an ASSERT in FrameView::layout() into an
early return to cause graceful failure until the root of the
problem is addressed.

  • page/FrameView.cpp: (WebCore::FrameView::layout):
4:16 PM Changeset in webkit [29877] by justin.garcia@apple.com
  • 3 edits
    8 adds in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5700414> REGRESSION (Adama-ToT): Selecting "Header 1" style in Leopard Server wiki inserts newline

  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): If the selected paragraph was empty, we may still need to call moveParagrah to remove the line break that holds that paragraph open because the new block of the requested type needs to to replace it.

LayoutTests:

Reviewed by Darin Adler.


<rdar://problem/5700414> REGRESSION (Adama-ToT): Selecting "Header 1" style in Leopard Server wiki inserts newline

  • editing/execCommand/5700414-1.html: Added.
  • editing/execCommand/5700414-2.html: Added.
  • platform/mac/editing/execCommand/5700414-1-expected.checksum: Added.
  • platform/mac/editing/execCommand/5700414-1-expected.png: Added.
  • platform/mac/editing/execCommand/5700414-1-expected.txt: Added.
  • platform/mac/editing/execCommand/5700414-2-expected.checksum: Added.
  • platform/mac/editing/execCommand/5700414-2-expected.png: Added.
  • platform/mac/editing/execCommand/5700414-2-expected.txt: Added.
2:26 PM Changeset in webkit [29876] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5688428> Reproducible assertion failure in SQLTransaction::performNextStep() (16876)

Revised fix to use the globalCallbackMutex() mutex and hold the mutex
for the entire function scope.

  • storage/Database.cpp: (WebCore::Database::performTransactionStep):
2:06 PM Changeset in webkit [29875] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Make ResourceTreeElement inherit the prototype of TreeElement.

  • page/inspector/Resource.js:
2:01 PM Changeset in webkit [29874] by jess@apple.com
  • 2 edits in trunk/WebKitSite

Reviewed by Tim Hatcher.

  • coding/coding-style.html: Adding a note about avoiding explicit nil/NO initialization of Objective-C instance variables.
1:56 PM Changeset in webkit [29873] by weinig@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Adam Roben.

Don't include SecurityOrigin.h in Document.h so that we can avoid massive
recompilation when changing the SecurityOrigin.

  • dom/Document.cpp: (WebCore::Document::setSecurityOrigin):
  • dom/Document.h:
12:38 PM Changeset in webkit [29872] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher and Brady.

<rdar://problem/5688428> Reproducible assertion failure in SQLTransaction::performNextStep() (16876)

  • storage/Database.cpp: (WebCore::Database::performTransactionStep): Do not perform the next transaction if a global callback is already scheduled.
11:40 AM Changeset in webkit [29871] by jhoneycutt@apple.com
  • 4 edits in trunk/WebCore

2008-01-30 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

<rdar://problem/5669317> Crash closing pop up window with Real Player
content

Some RealPlayer versions hang on unload. To prevent this hang, don't
unload versions since the last known unloadable version.
<rdar://problem/5713147> tracks revisiting this when the bug in
RealPlayer is fixed and we can again unload the plug-in.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::compareFileVersion): Compare the plug-in's file version to the passed file version, returning -1, 0, or 1 if the plug-in's version is less than, equal to, or greater than the version passed. (WebCore::PluginPackageWin::isPluginBlacklisted): Use compareFileVersion()
  • plugins/win/PluginPackageWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::determineQuirks): If the plug-in version is newer than the last-known unloadable version, add the DontUnloadPlugin quirk
9:55 AM Changeset in webkit [29870] by ap@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

One more debug (external) fix.

  • DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal and Debug configurations.
4:14 AM Changeset in webkit [29869] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Move off deprecated NSTableView methods.

Reviewed by Oliver Hunt.

  • WebView/WebHTMLView.mm:

(-[WebTextCompleteController _buildUI]): Switch from -setDrawsGrid: to -setGridStyleMask:.
(-[WebTextCompleteController _placePopupWindow:]): Switch from -selectRow:byExtendingSelection: to -selectRowIndexes:byExtendingSelection:.
(-[WebTextCompleteController filterKeyDown:]): Ditto.

Jan 29, 2008:

9:26 PM Changeset in webkit [29868] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Look for headers relative to NEXT_ROOT so that build-root picks up the WebCoreSQLite version of sqlite3.h rather than the older system version.

Reviewed by Tim Hatcher.

9:10 PM Changeset in webkit [29867] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Dave Hyatt.

  • try to make this test more robust on slower machines
  • fast/css/font-face-remote.html:
8:32 PM Changeset in webkit [29866] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • build fix
  • loader/CachedFont.cpp: (WebCore::CachedFont::CachedFont):
8:03 PM Changeset in webkit [29865] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Add the correct directory to the header search paths in Production builds. Reviewed by Brady Eidson.

7:50 PM Changeset in webkit [29864] by mitz@apple.com
  • 6 edits
    5 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Test: fast/css/font-face-remote.html

Added an isSVGFont method to CachedFont and use it to decide how to
process the font data. Currently whether the data is SVG is determined
based on the format property in the @font-face rule, but in the future
the MIME type or other metadata may be used when the format is
unspecified.

  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData): Changed to parse the data as SVG only if the CachedFont is an SVG font.
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Mark the CachedFont as an SVG font based on format.
  • loader/CachedFont.cpp: (WebCore::CachedFont::CachedFont): Initialize m_isSVGFont to false. (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::ensureSVGFontData): (WebCore::CachedFont::getSVGFontById):
  • loader/CachedFont.h: (WebCore::CachedFont::isSVGFont): Added. (WebCore::CachedFont::setSVGFont): Added.

LayoutTests:

Reviewed by Dave Hyatt.

This is the first @font-face test that actually tests loading font data
from a URL.

  • fast/css/font-face-remote.html: Added.
  • fast/css/resources/Ahem.ttf: Added.
  • platform/mac/fast/css/font-face-remote-expected.checksum: Added.
  • platform/mac/fast/css/font-face-remote-expected.png: Added.
  • platform/mac/fast/css/font-face-remote-expected.txt: Added.
7:43 PM Changeset in webkit [29863] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix a crash when opening the Inspector

Reviewed by Anders.

  • WebInspectorClient.cpp: (WebInspectorClient::createPage): Call WebPreferences::initWithIdentifier so our custom WebPreferences will have all its members initialized.
6:45 PM Changeset in webkit [29862] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix Bug 16786: "Display images when page opens" preference affects Inspector

<​http://bugs.webkit.org/show_bug.cgi?id=16786>
<rdar://5712914>

Reviewed by Anders and Darin.

  • WebInspectorClient.cpp: (WebInspectorClient::createPage): Create our own custom WebPreferences so that we won't be affected by global preference changes. This matches what Mac does.
6:38 PM Changeset in webkit [29861] by Antti Koivisto
  • 3 edits in trunk/WebCore

Some comment cleanup.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::load): (QTMovieWin::disableUnsupportedTracks):
6:00 PM Changeset in webkit [29860] by adele@apple.com
  • 1 edit
    108 deletes in trunk/LayoutTests

Reviewed by Oliver.

Remove pixel results for text-only tests that I mistakingly added.

  • platform/mac/media/audio-constructor-expected.checksum: Removed.
  • platform/mac/media/audio-constructor-expected.png: Removed.
  • platform/mac/media/audio-constructor-src-expected.checksum: Removed.
  • platform/mac/media/audio-constructor-src-expected.png: Removed.
  • platform/mac/media/broken-video-expected.checksum: Removed.
  • platform/mac/media/broken-video-expected.png: Removed.
  • platform/mac/media/constructors-expected.checksum: Removed.
  • platform/mac/media/constructors-expected.png: Removed.
  • platform/mac/media/fallback-expected.checksum: Removed.
  • platform/mac/media/fallback-expected.png: Removed.
  • platform/mac/media/progress-event-expected.checksum: Removed.
  • platform/mac/media/progress-event-expected.png: Removed.
  • platform/mac/media/remove-from-document-expected.checksum: Removed.
  • platform/mac/media/remove-from-document-expected.png: Removed.
  • platform/mac/media/unsupported-rtsp-expected.checksum: Removed.
  • platform/mac/media/unsupported-rtsp-expected.png: Removed.
  • platform/mac/media/unsupported-tracks-expected.checksum: Removed.
  • platform/mac/media/unsupported-tracks-expected.png: Removed.
  • platform/mac/media/video-append-source-expected.checksum: Removed.
  • platform/mac/media/video-append-source-expected.png: Removed.
  • platform/mac/media/video-autoplay-expected.checksum: Removed.
  • platform/mac/media/video-autoplay-expected.png: Removed.
  • platform/mac/media/video-buffered-expected.checksum: Removed.
  • platform/mac/media/video-buffered-expected.png: Removed.
  • platform/mac/media/video-controls-expected.checksum: Removed.
  • platform/mac/media/video-controls-expected.png: Removed.
  • platform/mac/media/video-currentTime-expected.checksum: Removed.
  • platform/mac/media/video-currentTime-expected.png: Removed.
  • platform/mac/media/video-currentTime-set-expected.checksum: Removed.
  • platform/mac/media/video-currentTime-set-expected.png: Removed.
  • platform/mac/media/video-currentTime-set2-expected.checksum: Removed.
  • platform/mac/media/video-currentTime-set2-expected.png: Removed.
  • platform/mac/media/video-dom-autoplay-expected.checksum: Removed.
  • platform/mac/media/video-dom-autoplay-expected.png: Removed.
  • platform/mac/media/video-dom-end-expected.checksum: Removed.
  • platform/mac/media/video-dom-end-expected.png: Removed.
  • platform/mac/media/video-dom-loopcount-expected.checksum: Removed.
  • platform/mac/media/video-dom-loopcount-expected.png: Removed.
  • platform/mac/media/video-dom-loopend-expected.checksum: Removed.
  • platform/mac/media/video-dom-loopend-expected.png: Removed.
  • platform/mac/media/video-dom-loopstart-expected.checksum: Removed.
  • platform/mac/media/video-dom-loopstart-expected.png: Removed.
  • platform/mac/media/video-dom-src-expected.checksum: Removed.
  • platform/mac/media/video-dom-src-expected.png: Removed.
  • platform/mac/media/video-dom-start-expected.checksum: Removed.
  • platform/mac/media/video-dom-start-expected.png: Removed.
  • platform/mac/media/video-end-expected.checksum: Removed.
  • platform/mac/media/video-end-expected.png: Removed.
  • platform/mac/media/video-error-abort-expected.checksum: Removed.
  • platform/mac/media/video-error-abort-expected.png: Removed.
  • platform/mac/media/video-error-does-not-exist-expected.checksum: Removed.
  • platform/mac/media/video-error-does-not-exist-expected.png: Removed.
  • platform/mac/media/video-load-networkState-expected.checksum: Removed.
  • platform/mac/media/video-load-networkState-expected.png: Removed.
  • platform/mac/media/video-load-readyState-expected.checksum: Removed.
  • platform/mac/media/video-load-readyState-expected.png: Removed.
  • platform/mac/media/video-loopcount-expected.checksum: Removed.
  • platform/mac/media/video-loopcount-expected.png: Removed.
  • platform/mac/media/video-loopend-expected.checksum: Removed.
  • platform/mac/media/video-loopend-expected.png: Removed.
  • platform/mac/media/video-loopstart-expected.checksum: Removed.
  • platform/mac/media/video-loopstart-expected.png: Removed.
  • platform/mac/media/video-muted-expected.checksum: Removed.
  • platform/mac/media/video-muted-expected.png: Removed.
  • platform/mac/media/video-no-autoplay-expected.checksum: Removed.
  • platform/mac/media/video-no-autoplay-expected.png: Removed.
  • platform/mac/media/video-pause-empty-events-expected.checksum: Removed.
  • platform/mac/media/video-pause-empty-events-expected.png: Removed.
  • platform/mac/media/video-play-empty-events-expected.checksum: Removed.
  • platform/mac/media/video-play-empty-events-expected.png: Removed.
  • platform/mac/media/video-play-pause-events-expected.checksum: Removed.
  • platform/mac/media/video-play-pause-events-expected.png: Removed.
  • platform/mac/media/video-play-pause-exception-expected.checksum: Removed.
  • platform/mac/media/video-play-pause-exception-expected.png: Removed.
  • platform/mac/media/video-poster-expected.checksum: Removed.
  • platform/mac/media/video-poster-expected.png: Removed.
  • platform/mac/media/video-seek-past-end-paused-expected.checksum: Removed.
  • platform/mac/media/video-seek-past-end-paused-expected.png: Removed.
  • platform/mac/media/video-seek-past-end-playing-expected.checksum: Removed.
  • platform/mac/media/video-seek-past-end-playing-expected.png: Removed.
  • platform/mac/media/video-seekable-expected.checksum: Removed.
  • platform/mac/media/video-seekable-expected.png: Removed.
  • platform/mac/media/video-seeking-expected.checksum: Removed.
  • platform/mac/media/video-seeking-expected.png: Removed.
  • platform/mac/media/video-size-expected.checksum: Removed.
  • platform/mac/media/video-size-expected.png: Removed.
  • platform/mac/media/video-source-expected.checksum: Removed.
  • platform/mac/media/video-source-expected.png: Removed.
  • platform/mac/media/video-source-media-expected.checksum: Removed.
  • platform/mac/media/video-source-media-expected.png: Removed.
  • platform/mac/media/video-source-type-expected.checksum: Removed.
  • platform/mac/media/video-source-type-expected.png: Removed.
  • platform/mac/media/video-src-change-expected.checksum: Removed.
  • platform/mac/media/video-src-change-expected.png: Removed.
  • platform/mac/media/video-src-expected.checksum: Removed.
  • platform/mac/media/video-src-expected.png: Removed.
  • platform/mac/media/video-src-remove-expected.checksum: Removed.
  • platform/mac/media/video-src-remove-expected.png: Removed.
  • platform/mac/media/video-src-set-expected.checksum: Removed.
  • platform/mac/media/video-src-set-expected.png: Removed.
  • platform/mac/media/video-src-source-expected.checksum: Removed.
  • platform/mac/media/video-src-source-expected.png: Removed.
  • platform/mac/media/video-start-expected.checksum: Removed.
  • platform/mac/media/video-start-expected.png: Removed.
  • platform/mac/media/video-volume-expected.checksum: Removed.
  • platform/mac/media/video-volume-expected.png: Removed.
  • platform/mac/media/video-width-height-expected.checksum: Removed.
  • platform/mac/media/video-width-height-expected.png: Removed.
5:40 PM Changeset in webkit [29859] by adele@apple.com
  • 4 edits in trunk

WebCore:

Reviewed by Antti.

Fix for <rdar://5683527> media/{audio,videocontrols-rendering.html failing


  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::isControlStyled): Don't treat all media controls as styled. This causes builds with an old version of SafariTheme to have different metrics for these controls.

LayoutTests:

Reviewed by Antti.

Removing test from Skipped list for <rdar://5683527> media/{audio,videocontrols-rendering.html failing


  • platform/win/Skipped:
4:52 PM Changeset in webkit [29858] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • re-add a couple of tests that are still failing back to the list
  • platform/win/Skipped:
4:28 PM Changeset in webkit [29857] by mitz@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • make Font instances cache their primary font
  • WebCore.base.exp:
  • platform/graphics/Font.cpp: (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::cachePrimaryFont): (WebCore::Font::update):
  • platform/graphics/Font.h: (WebCore::Font::primaryFont):
4:18 PM Changeset in webkit [29856] by ggaren@apple.com
  • 25 edits
    2 adds in trunk

WebKitTools:

Reviewed by Sam Weinig. Sam Weinig.


Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
fails when run after fast/dom/Window/window-property-shadowing.html (16902)

Modified our policy delegates not to output window.name. Since a
previous test may have explicitly set window.name, we can't rely on its
implicit value in test results.

  • DumpRenderTree/mac/PolicyDelegate.mm: (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
  • DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::decidePolicyForNavigationAction):

LayoutTests:

Reviewed by Sam Weinig. Sam Weinig.


Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
fails when run after fast/dom/Window/window-property-shadowing.html (16902)

These layout tests demonstrate the expected behavior of window.name,
including the fact that one test can change the window.name value seen
by another test:

  • fast/dom/Window/window-property-shadowing-name-expected.txt: Added.
  • fast/dom/Window/window-property-shadowing-name.html: Added.
  • fast/dom/Window/window-property-clearing-expected.txt:
  • fast/dom/Window/window-property-clearing.html:


Modified these expected results not to depend on window.name. Since a
previous test may have explicitly set window.name, we can't rely on its
implicit value:

  • fast/encoding/mailto-always-utf-8-expected.txt:
  • fast/forms/mailto/advanced-get-expected.txt:
  • fast/forms/mailto/advanced-put-expected.txt:
  • fast/forms/mailto/get-multiple-items-expected.txt:
  • fast/forms/mailto/get-multiple-items-text-plain-expected.txt:
  • fast/forms/mailto/get-multiple-items-x-www-form-urlencoded-expected.txt:
  • fast/forms/mailto/get-non-ascii-always-utf-8-expected.txt:
  • fast/forms/mailto/get-non-ascii-expected.txt:
  • fast/forms/mailto/get-non-ascii-text-plain-expected.txt:
  • fast/forms/mailto/get-non-ascii-text-plain-latin-1-expected.txt:
  • fast/forms/mailto/get-overwrite-query-expected.txt:
  • fast/forms/mailto/post-append-query-expected.txt:
  • fast/forms/mailto/post-multiple-items-expected.txt:
  • fast/forms/mailto/post-multiple-items-multipart-form-data-expected.txt:
  • fast/forms/mailto/post-multiple-items-text-plain-expected.txt:
  • fast/forms/mailto/post-multiple-items-x-www-form-urlencoded-expected.txt:
  • fast/forms/mailto/post-text-plain-expected.txt:
  • fast/forms/mailto/post-text-plain-with-accept-charset-expected.txt:
  • http/tests/security/feed-urls-from-remote-expected.txt:
4:16 PM Changeset in webkit [29855] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • Leopard build fix
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
4:13 PM Changeset in webkit [29854] by mrowe@apple.com
  • 8 edits
    4 adds in trunk

<rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).

Reviewed by Tim Hatcher.

3:03 PM Changeset in webkit [29853] by mitz@apple.com
  • 4 edits in trunk

WebCore:

Reviewed by Adam Roben and Oliver Hunt.

  • fix <rdar://problem/5713131> REGRESSION (r29246): Many SVG font tests are failing
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): Use double instead of float for consistent rounding behavior between Mac OS X and Windows.

LayoutTests:

Reviewed by Adam Roben and Oliver Hunt.

  • remove skipped tests after fixing <rdar://problem/5713131> REGRESSION (r29246): Many SVG font tests are failing
  • platform/win/Skipped:
3:03 PM Changeset in webkit [29852] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Refactor ChangeLog path code

Reviewed by Adam.

  • Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract duplicate code in another foreach() loop.
2:33 PM Changeset in webkit [29851] by Adam Roben
  • 5 edits in trunk

Fix <rdar://5713302> Web Inspector on Windows is not using the localized strings

WebCore:

Fix <rdar://5713302> Web Inspector on Windows is not using the
localized strings

Reviewed by Steve.

  • WebCore.vcproj/WebCore.vcproj: Copy InspectorLocalizedStrings.js to $WebKitOutputDir.
  • page/InspectorController.cpp: Touch this to force the project to build.

WebKit/win:

Fix <rdar://5713302> Web Inspector on Windows is not using the
localized strings

Reviewed by Steve.

  • WebInspectorClient.cpp: (getWebKitBundle): Added. (WebInspectorClient::createPage): Call getWebKitBundle. (WebInspectorClient::localizedStringsURL): Implemented.
2:22 PM Changeset in webkit [29850] by eric@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Nikolas.

Acid3 after double-attach
​http://bugs.webkit.org/show_bug.cgi?id=17058

I believe SVGTextPathElement::buildPendingResource() was entirely
bogus, removing it did not cause any tests to fail.

Test: svg/custom/textPath-assert.svg

  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::insertedIntoDocument): remove buildPendingResource()
  • svg/SVGTextPathElement.h:
1:35 PM Changeset in webkit [29849] by Adam Roben
  • 2 edits in trunk/WebCore

Fix Bug 16234: Inspector should support searching for elements by CSS selectors

<​http://bugs.webkit.org/show_bugs.cgi?id=16234>
<rdar://5712862>

Reviewed by Tim.

  • page/inspector/inspector.js: Use Document.querySelectorAll to search for elements by CSS selector. Also store a custom property on nodes being added to the search results to avoid showing the same node more than once.
12:20 PM Changeset in webkit [29848] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added new failures.
11:55 AM Changeset in webkit [29847] by Adam Roben
  • 2 edits in trunk/WebCore

Fix <rdar://5711136> Full-screen Flash on 1up.com is unresponsive

Reviewed by Anders and Darin.

No test possible.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::wndProc): Set/release capture on mouse down/up, like Firefox does.
9:18 AM Changeset in webkit [29846] by ap@webkit.org
  • 6 edits in trunk

Reviewed by Darin.

<rdar://problem/5710692> All storage tests fail/crash

WebKit:

  • WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Clients that do not implement database quota callbacks should have no database support - but not crash.

WebKitTools:

  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an arbitrary quota of 5 megabytes.

(-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
(-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
Removed unused (I think) code.


  • DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported. (UIDelegate::webViewPainted): A stub implementation. (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
  • DumpRenderTree/win/UIDelegate.h:
3:47 AM Changeset in webkit [29845] by ap@webkit.org
  • 2 edits in trunk/WebKitLibraries

Debug (external) build fix.

Removed _DEBUG preprocessor definition, which indicates that debug libraries are used (while they aren't).
This preprocessor definition is automatically set by Visual Studio as needed anyway.

  • win/tools/vsprops/debug.vsprops:
Note: See TracTimeline for information about the timeline view.