Context Navigation

platform/Locker.h: Added. Template class to "lock()" and "unlock()" some arbitrary object (WebCore::Locker::Locker): Lock the object (WebCore::Locker::~Locker): Unlock it
platform/Threading.h: class MutexLocker is now typedef Locker<Mutex>
WebCore.xcodeproj/project.pbxproj:

5:53 PM Changeset in webkit [29905] by kmccullough@apple.com

15 edits
10 deletes in trunk

WebCore:

<rdar://problem/5716912> REGRESSION (r29816): Can't navigate back to
Gmail Inbox from Gmail Compose page
Rolling out the change that caused the regression.

WebCore.base.exp:
bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open):
dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createHTMLDocument):
dom/Document.cpp: (WebCore::Document::recalcStyle): (WebCore::Document::open): (WebCore::Document::write): (WebCore::Document::clear):
dom/Document.h:
history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
history/HistoryItem.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::load): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::tokenizerProcessedData): (WebCore::FrameLoader::post): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoader::loadItem):
loader/FrameLoader.h:
platform/text/CharacterNames.h:
xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseXML):
xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):

LayoutTests:

<rdar://problem/5716912> REGRESSION (r29816): Can't navigate back to
Gmail Inbox from Gmail Compose page
Rolling out the change that caused the regression.

http/tests/navigation/document-open-adds-history-item-expected.txt: Removed.
http/tests/navigation/document-open-adds-history-item.html: Removed.
http/tests/navigation/document-open-delayed-adds-history-item-expected.txt: Removed.
http/tests/navigation/document-open-delayed-adds-history-item.html: Removed.
http/tests/navigation/document-open-new-window-adds-history-item-expected.txt: Removed.
http/tests/navigation/document-open-new-window-adds-history-item.html: Removed.
http/tests/navigation/document-open-replace-no-history-item-expected.txt: Removed.
http/tests/navigation/document-open-replace-no-history-item.html: Removed.
http/tests/navigation/resources/document-open-page-2.html: Removed.
http/tests/navigation/resources/document-open.js: Removed.

5:03 PM Changeset in webkit [29904] by mitz@apple.com

2 edits in trunk/LayoutTests

re-categorize three skipped tests

platform/win/Skipped:

5:01 PM Changeset in webkit [29903] by Adam Roben

2 edits in trunk/WebKit/win

Fix <rdar://5713172> Focus lost from Gmail message body after toggling
tabs

This regressed in r29583. Prior to r29583, the code path that resulted
in calling focusController->setFocusedFrame(0) was never getting hit.
r29583 changed the code to adhere to the comment above the code and
actually call setFocusedFrame(0) when losing focus to another part of
the window. It turns out this is wrong behavior (and not what
WebKit/mac does). The only time we should clear the focused frame is
when we tab out of the WebView, and that's already taken care of by
FocusController::advanceFocus. The code to clear the focused frame in
WebView was written before FocusController::advanceFocus, so it was
correct at one point but no longer is.

We now never call setFocusedFrame(0) when the WebView receives a
WM_KILLFOCUS message. Instead we just call setFocused(false) on the
focused frame so that blur events will be sent. This matches what
WebKit/mac does.

Reviewed by Darin and Adele.

WebView.cpp: (WebViewWndProc): Also reworded a couple of comments to make them clearer.

4:50 PM Changeset in webkit [29902] by pewtermoose@webkit.org

2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Bug 14960: Cannot copy text in Web Inspector Network panel
http://bugs.webkit.org/show_bug.cgi?id=14960

page/inspector/inspector.css:

4:48 PM Changeset in webkit [29901] by pewtermoose@webkit.org

2 edits in trunk/WebCore

Reviewed by Adam Roben.

Bug 14514: Add full URL view on mouseOver in the network page
http://bugs.webkit.org/show_bug.cgi?id=14514
<rdar://problem/5712841>

page/inspector/inspector.js:

4:35 PM Changeset in webkit [29900] by mitz@apple.com

5 edits in trunk/LayoutTests

Reviewed by Geoffrey Garen.

change the font used in fast/text/monospace-width-cache.html again to a font that contains the U+2500 character in Tiger too

fast/text/monospace-width-cache.html:
platform/mac/fast/text/monospace-width-cache-expected.checksum:
platform/mac/fast/text/monospace-width-cache-expected.png:
platform/mac/fast/text/monospace-width-cache-expected.txt:

4:00 PM Changeset in webkit [29899] by alp@webkit.org

4 edits in trunk

Fix r29898 ChangeLog entries: rubber-stamped, not reviewed

3:51 PM Changeset in webkit [29898] by alp@webkit.org

13 edits
18 copies
1 move in trunk

2008-01-31 Alp Toker <alp@atoker.com>

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=17006
[GTK] Header path should be webkit/webkit.h

Move the GTK+ API sources as needed and update the build systems.

3:09 PM Changeset in webkit [29897] by weinig@apple.com

2 edits in trunk/WebCore

Reviewed by Geoff Garen.

No need to get the prototype just to compare compare property names.

bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::customGetOwnPropertySlot):

1:37 PM Changeset in webkit [29896] by weinig@apple.com

6 edits in trunk

WebCore:

Fix non-mac builds.

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCoreSources.bkl:

1:06 PM Changeset in webkit [29895] by hyatt@apple.com

3 edits in trunk/LayoutTests/platform/mac/fast/lists

1:04 PM Changeset in webkit [29894] by hyatt@apple.com

3 edits in trunk/LayoutTests/platform/mac/tables/mozilla/bugs

1:03 PM Changeset in webkit [29893] by hyatt@apple.com

4 adds in trunk/LayoutTests

1:03 PM Changeset in webkit [29892] by hyatt@apple.com

2 edits in trunk/WebCore

Fix for bug 17101.

List items need to ignore the line box shrinking quirk, since IE and Firefox both do.

Reviewed by Eric

fast/lists/list-item-line-height.html

rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox):

12:11 PM Changeset in webkit [29891] by mitz@apple.com

26 edits in trunk/LayoutTests

Reviewed by Adam Roben.

change several tests that use Mac-only fonts to use fonts that are available on both Windows and Mac OS X

fast/text/monospace-width-cache.html:
platform/mac/fast/text/monospace-width-cache-expected.checksum:
platform/mac/fast/text/monospace-width-cache-expected.png:
platform/mac/fast/text/monospace-width-cache-expected.txt:
platform/mac/tables/mozilla/bugs/bug10633-expected.checksum:
platform/mac/tables/mozilla/bugs/bug10633-expected.png:
platform/mac/tables/mozilla/bugs/bug10633-expected.txt:
platform/mac/tables/mozilla/bugs/bug113424-expected.checksum:
platform/mac/tables/mozilla/bugs/bug113424-expected.png:
platform/mac/tables/mozilla/bugs/bug113424-expected.txt:
platform/mac/tables/mozilla/bugs/bug23151-expected.checksum:
platform/mac/tables/mozilla/bugs/bug23151-expected.png:
platform/mac/tables/mozilla/bugs/bug23151-expected.txt:
platform/mac/tables/mozilla/core/bloomberg-expected.checksum:
platform/mac/tables/mozilla/core/bloomberg-expected.png:
platform/mac/tables/mozilla/core/bloomberg-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug11331-expected.checksum:
platform/mac/tables/mozilla_expected_failures/bugs/bug11331-expected.png:
platform/mac/tables/mozilla_expected_failures/bugs/bug11331-expected.txt:
platform/win/Skipped:
tables/mozilla/bugs/bug10633.html:
tables/mozilla/bugs/bug113424.html:
tables/mozilla/bugs/bug23151.html:
tables/mozilla/core/bloomberg.html:
tables/mozilla_expected_failures/bugs/bug11331.html:

11:52 AM Changeset in webkit [29890] by weinig@apple.com

15 edits
2 moves
8 adds in trunk

WebCore:

Reviewed by Darin Adler.

Fix for <rdar://problem/5708993> Mutability of the History object

Don't allow cross-domain get access to any of the history objects properties except the back(), forward() and go() methods.
Don't allow cross-domain put access to any of the history objects properties.
Don't allow cross-domain enumeration of the History or Location objects.

Tests: http/tests/security/cross-frame-access-history-get-override.html

http/tests/security/cross-frame-access-history-get.html
http/tests/security/cross-frame-access-history-put.html

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMWindowCustom.cpp: Remove unnessary KJS::'s (WebCore::JSDOMWindow::customGetOwnPropertySlot): (WebCore::JSDOMWindow::customPut): (WebCore::JSDOMWindow::getPropertyNames): Moved implementation from KJS::Window now that the declaration is autogenerated using the new CustomGetPropertyNames. (WebCore::JSDOMWindow::postMessage):

bindings/js/JSHistoryCustom.cpp: Added. (WebCore::allowsAccessFromFrame): (WebCore::JSHistory::customGetOwnPropertySlot): Only allow getting the declared functions back(), forward() and go() from cross-domain. Deny all other gets. (WebCore::JSHistory::customPut): Don't allow putting cross-domain. (WebCore::JSHistory::getPropertyNames): Don't allow enumeration cross-domain.

bindings/js/JSLocation.cpp: (WebCore::allowsAccessFromFrame): (WebCore::JSLocation::getPropertyNames): Don't allow enumeration cross-domain.
bindings/js/JSLocation.h:

bindings/js/kjs_window.cpp:
bindings/js/kjs_window.h:

bindings/scripts/CodeGeneratorJS.pm: Add support for new CustomGetPropertNames extended attribute and changed the logic of CustomPutFunction to create an overrided put() function even if no read-write properties exist.

page/DOMWindow.idl: Added CustomGetPropertNames
page/History.idl: Added CustomGetPropertNames

LayoutTests:

Reviewed by Darin Adler.

Tests for <rdar://problem/5708993> Mutability of the History object

http/tests/security/cross-frame-access-enumeration-expected.txt:
http/tests/security/cross-frame-access-enumeration.html:
http/tests/security/cross-frame-access-history-expected.txt: Removed.
http/tests/security/cross-frame-access-history-get-expected.txt: Renamed from LayoutTests/http/tests/security/cross-frame-access-history-expected.txt.
http/tests/security/cross-frame-access-history-get-override-expected.txt: Added.
http/tests/security/cross-frame-access-history-get-override.html: Added.
http/tests/security/cross-frame-access-history-get.html: Renamed from LayoutTests/http/tests/security/cross-frame-access-history.html.
http/tests/security/cross-frame-access-history-put-expected.txt: Added.
http/tests/security/cross-frame-access-history-put.html: Added.
http/tests/security/cross-frame-access-history.html: Removed.
http/tests/security/resources/cross-frame-access.js:
http/tests/security/resources/cross-frame-iframe-for-enumeration-test.html:
http/tests/security/resources/cross-frame-iframe-for-history-get-override-test.html: Added.
http/tests/security/resources/cross-frame-iframe-for-history-get-test.html: Added.
http/tests/security/resources/cross-frame-iframe-for-history-put-test.html: Added.

11:01 AM Changeset in webkit [29889] by justin.garcia@apple.com

5 edits in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5708115> REGRESSION: Words selected with a double click and copied won't paste into Mail

page/mac/WebCoreFrameBridge.h: Re-exposed smartInsertForString:, it's used by a WebKit method used by Mail.

WebKit/mac:

Reviewed by Darin Adler.

<rdar://problem/5708115> REGRESSION: Words selected with a double click and copied won't paste into Mail

WebView/WebHTMLView.mm: (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Brought this back, it's used by Mail. (-[WebHTMLView _canSmartReplaceWithPasteboard:]): This WebInternal method is also used by Mail. Moved to WebPrivate.
WebView/WebHTMLViewPrivate.h: Expose two methods that Mail uses here, so that we don't accidently remove them in the future.

10:50 AM Changeset in webkit [29888] by Adam Roben

3 edits in trunk/WebCore

Add line box drawing code to InspectorController::drawNodeHighlight

This makes drawNodeHighlight a complete replacement for the painting
code in WebKit/mac/WebNodeHighlightView.mm, and also brings line box
rects to Windows for the first time.

Reviewed by Darin.

dom/Node.h: Changed isSVGElement to always exist, but to only be virtual when ENABLE(SVG) is true. This way you can always call node->isSVGElement() without checking ENABLE(SVG).
page/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): Ported line box rect code from the Mac implementation in WebNodeHighlightView.mm.

10:47 AM Changeset in webkit [29887] by Adam Roben

7 edits in trunk

Let WebCore take care of the highlight drawing entirely

WebCore:

Put more knowledge about the node highlight in WebCore

InspectorController now calculates the overlay rect and node rect when
drawing the node highlight instead of having them be passed in.
InspectorController now holds onto the highlighted node so that it can
determine these rects.

Once all platforms are calling down to drawNodeHighlight instead of
drawing the highlight themselves, we can change
InspectorClient::highlight(Node*) to something like
InspectorClient::updateAndShowHighlight().

This also fixes Bug 14264: Node highlight makes it impossible to
scroll the page
<http://bugs.webkit.org/show_bug.cgi?id=14264>
<rdar://5712788>

Reviewed by Darin.

page/InspectorController.cpp: (WebCore::InspectorController::highlight): Store the node for use in drawNodeHighlight. (WebCore::InspectorController::drawNodeHighlight): Changed to be a const instance method. Now calculates the overlay rect and node rect instead of having them passed in.
page/InspectorController.h:

WebKit/win:

Let WebCore take care of the highlight drawing entirely

Reviewed by Darin.

WebInspectorClient.cpp: (WebInspectorClient::highlight): We now just show our highlight window and let WebCore figure out what/where to paint. Once all ports follow suit the Node* parameter to this method should be removed entirely, and the name should probably change to updateAndShowHighlight or something similar.
WebNodeHighlight.cpp: Renamed m_webView to m_inspectedWebViewWindow. (WebNodeHighlight::WebNodeHighlight): Now takes a WebView* parameter. (WebNodeHighlight::show): Renamed from highlight(). Now gets the WebView's HWND. Updated for member rename/removal. (WebNodeHighlight::updateWindow): Updated for member rename and for InspectorController changes.
WebNodeHighlight.h: Added m_inspectedWebView member, removed m_rect member, renamed highlight(Node*) -> show().

10:44 AM Changeset in webkit [29886] by Adam Roben

5 edits in trunk

Move node highlight drawing code to WebCore

WebCore:

Add node highlight drawing code to InspectorController

The code came from WebKit/win/WebNodeHighlight.cpp. It's not quite as
complete as the Mac implementation (in particular, it doesn't handle
line-box rects), but it's a start.

Reviewed by Darin.

page/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): Added.
page/InspectorController.h:

WebKit/win:

Move node highlight drawing code to WebCore

Reviewed by Darin.

WebNodeHighlight.cpp: (WebNodeHighlight::updateWindow): Call into WebCore to do the node highlight drawing.

10:34 AM Changeset in webkit [29885] by mitz@apple.com

4 edits
4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=17107 <rdar://problem/5716722> REGRESSION (r29834): Article text on redhat.com magazine site appears to be painting twice

Test: fast/block/float/intruding-painted-twice.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Pass 'false' for the new makeChildPaintOtherFloats parameter to addOverhangingFloats() because at this point we are only taking away floats from the child. (WebCore::RenderBlock::layoutBlockChildren): Pass 'true' for the new makeChildPaintOtherFloats parameter to addOverhangingFloats() iff the child was not laid out again. Only in that case, it may have overhanging floats that it does not paint because they used to be overhanging from the parent, but now they are not. (WebCore::RenderBlock::addOverhangingFloats): Refined the conditions for making the child paint the float: require that the float be a descendant of the child (the other case is when it intrudes into the child from another sibling) and that it does not have a layer (in which case it paints itself). In addition, do the check only if the caller passed 'true' for the makeChildPaintOtherFloats parameter.
rendering/RenderBlock.h:

LayoutTests:

Reviewed by Dave Hyatt.

pixel test for http://bugs.webkit.org/show_bug.cgi?id=17107 <rdar://problem/5716722> REGRESSION (r29834): Article text on redhat.com magazine site appears to be painting twice

fast/block/float/intruding-painted-twice.html: Added.
platform/mac-leopard/fast/block/float/intruding-painted-twice-expected.checksum: Added.
platform/mac-leopard/fast/block/float/intruding-painted-twice-expected.png: Added.
platform/mac/fast/block/float/intruding-painted-twice-expected.txt: Added.

Jan 30, 2008:

9:39 PM Changeset in webkit [29884] by mitz@apple.com

9 edits
4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

change the interpretation of unicode-range values in "from-to" form to include the "to" character.

Test: fast/css/font-face-unicode-range.html

css/CSSParser.cpp: (WebCore::CSSParser::parseFontFaceUnicodeRange):
css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::overlayRange):
platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage):
platform/graphics/SegmentedFontData.cpp: (WebCore::SegmentedFontData::fontDataForCharacter): (WebCore::SegmentedFontData::containsCharacters):

LayoutTests:

Reviewed by Sam Weinig.

add a test for the unicode-range @font-face property
update @font-face rules in existing tests after changing unicode-range values in "from-to" form to include the "to" character

fast/css/font-face-unicode-range.html: Added.
fast/css/rtl-ordering.html:
fast/text/international/resources/Mac-compatible-font-fallback.css:
platform/mac-leopard/fast/css/font-face-unicode-range-expected.checksum: Added.
platform/mac-leopard/fast/css/font-face-unicode-range-expected.png: Added.
platform/mac/fast/css/font-face-unicode-range-expected.txt: Added.
platform/win/css2.1/resources/Mac-compatible-font-fallback.css:

9:36 PM Changeset in webkit [29883] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Darin Adler.

prune references to custom fonts' SimpleFontData from the glyph page tree when they are destroyed

css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::pruneTable):

6:45 PM Changeset in webkit [29882] by justin.garcia@apple.com

1 add
1 delete in trunk/LayoutTests/editing/style

This test started failed with my last checkin. The new results are *correct* but I don't know why my changes would have fixed the test, so I want to investigate a bit before I check in new results.

5:45 PM Changeset in webkit [29881] by timothy@apple.com

3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

New fix for <rdar://problem/5688428> Reproducible assertion failure
in SQLTransaction::performNextStep() (16876)

Fixes a deadlock that was happening for all Database use. All
storage layout tests pass.

storage/Database.cpp: (WebCore::CurrentThreadSetter::CurrentThreadSetter): New helper class to set the current thread and zero it on destruction. (WebCore::CurrentThreadSetter::~CurrentThreadSetter): Set threadIdentifierStorage to 0. (WebCore::Database::Database): Set m_transactionStepThread to 0. (WebCore::Database::performTransactionStep): Set m_transactionStepThread to currentThread(). (WebCore::Database::scheduleTransactionCallback): Assert m_transactionStepThread is currentThread().
storage/Database.h: Add m_transactionStepThread for debug builds to track which thread performTransactionStep() was called on.

5:23 PM Changeset in webkit [29880] by Stephanie Lewis

2 edits in trunk/WebKitTools

2008-01-30 Stephanie <Stephanie Lewis>

Reviewed by Geoff.

Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth. This should make it easier for the buildbots to track new leaks.

Scripts/run-webkit-tests:

4:55 PM Changeset in webkit [29879] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Darin Adler.

ASSERTION FAILED: JSLock::lockCount() > 0 when opening the
Web Inspector on a page with a Database.

Fix the ASSERT by taking a JSLock before calling toJS().

page/InspectorController.cpp: (WebCore::InspectorController::addDatabaseScriptResource):

4:43 PM Changeset in webkit [29878] by Beth Dakin

2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5598609> CrashTracer: [USER] 626 crashes in
Safari at com.apple.WebCore: WebCore::FrameView::needsFullRepaint
const + 6

The real problem here is tracked by rdar://5598072, which is that
frames can lose sync between their view and their document when a
non-HTML view is loaded (such as bookmarks view or a PDF). That can
cause this crash if the layout timer fires before things have fixed
themselves. This fix turns an ASSERT in FrameView::layout() into an
early return to cause graceful failure until the root of the
problem is addressed.

page/FrameView.cpp: (WebCore::FrameView::layout):

4:16 PM Changeset in webkit [29877] by justin.garcia@apple.com

3 edits
8 adds in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5700414> REGRESSION (Adama-ToT): Selecting "Header 1" style in Leopard Server wiki inserts newline

editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): If the selected paragraph was empty, we may still need to call moveParagrah to remove the line break that holds that paragraph open because the new block of the requested type needs to to replace it.

LayoutTests:

Reviewed by Darin Adler.

<rdar://problem/5700414> REGRESSION (Adama-ToT): Selecting "Header 1" style in Leopard Server wiki inserts newline

editing/execCommand/5700414-1.html: Added.
editing/execCommand/5700414-2.html: Added.
platform/mac/editing/execCommand/5700414-1-expected.checksum: Added.
platform/mac/editing/execCommand/5700414-1-expected.png: Added.
platform/mac/editing/execCommand/5700414-1-expected.txt: Added.
platform/mac/editing/execCommand/5700414-2-expected.checksum: Added.
platform/mac/editing/execCommand/5700414-2-expected.png: Added.
platform/mac/editing/execCommand/5700414-2-expected.txt: Added.

2:26 PM Changeset in webkit [29876] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5688428> Reproducible assertion failure in SQLTransaction::performNextStep() (16876)

Revised fix to use the globalCallbackMutex() mutex and hold the mutex
for the entire function scope.

storage/Database.cpp: (WebCore::Database::performTransactionStep):

2:06 PM Changeset in webkit [29875] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Adam Roben.

Make ResourceTreeElement inherit the prototype of TreeElement.

page/inspector/Resource.js:

2:01 PM Changeset in webkit [29874] by jess@apple.com

2 edits in trunk/WebKitSite

Reviewed by Tim Hatcher.

coding/coding-style.html: Adding a note about avoiding explicit nil/NO initialization of Objective-C instance variables.

1:56 PM Changeset in webkit [29873] by weinig@apple.com

3 edits in trunk/WebCore

Reviewed by Adam Roben.

Don't include SecurityOrigin.h in Document.h so that we can avoid massive
recompilation when changing the SecurityOrigin.

dom/Document.cpp: (WebCore::Document::setSecurityOrigin):
dom/Document.h:

12:38 PM Changeset in webkit [29872] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Tim Hatcher and Brady.

<rdar://problem/5688428> Reproducible assertion failure in SQLTransaction::performNextStep() (16876)

storage/Database.cpp: (WebCore::Database::performTransactionStep): Do not perform the next transaction if a global callback is already scheduled.

11:40 AM Changeset in webkit [29871] by jhoneycutt@apple.com

4 edits in trunk/WebCore

2008-01-30 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Darin.

<rdar://problem/5669317> Crash closing pop up window with Real Player
content

Some RealPlayer versions hang on unload. To prevent this hang, don't
unload versions since the last known unloadable version.
<rdar://problem/5713147> tracks revisiting this when the bug in
RealPlayer is fixed and we can again unload the plug-in.

plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::compareFileVersion): Compare the plug-in's file version to the passed file version, returning -1, 0, or 1 if the plug-in's version is less than, equal to, or greater than the version passed. (WebCore::PluginPackageWin::isPluginBlacklisted): Use compareFileVersion()
plugins/win/PluginPackageWin.h:
plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::determineQuirks): If the plug-in version is newer than the last-known unloadable version, add the DontUnloadPlugin quirk

9:55 AM Changeset in webkit [29870] by ap@webkit.org

2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

One more debug (external) fix.

DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal and Debug configurations.

4:14 AM Changeset in webkit [29869] by mrowe@apple.com

2 edits in trunk/WebKit/mac

Move off deprecated NSTableView methods.

Reviewed by Oliver Hunt.

WebView/WebHTMLView.mm:

(-[WebTextCompleteController _buildUI]): Switch from -setDrawsGrid: to -setGridStyleMask:.
(-[WebTextCompleteController _placePopupWindow:]): Switch from -selectRow:byExtendingSelection: to -selectRowIndexes:byExtendingSelection:.
(-[WebTextCompleteController filterKeyDown:]): Ditto.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed