⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 4, 2008:

11:58 PM Changeset in webkit [29997] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Fix for Bug 16889: REGRESSION (r29425): Canvas-based graphing calculator fails to run

Bug 17015: REGRESSION (r29414-29428): www.fox.com "shows" menu fails to render
Bug 17164: REGRESSION: JavaScript pop-up menu appears at wrong location when hovering image at ​http://news.chinatimes.com/

Reviewed by Oliver Hunt

<​http://bugs.webkit.org/show_bug.cgi?id=16889>
<rdar://problem/5696255>

<​http://bugs.webkit.org/show_bug.cgi?id=17015>

<​http://bugs.webkit.org/show_bug.cgi?id=17164>
<rdar://problem/5720947>

The ActivationImp tear-off (r29425) introduced a problem with ReadModify
nodes that first resolve a slot, call valueForReadModifyNode(), and then
store a value in the previously resolved slot. Since valueForReadModifyNode()
may cause a tear-off, the slot needs to be resolved again, but this was
not happening with the existing code.

11:28 PM Changeset in webkit [29996] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Gtk qmake build fix. Fix perl's complaint about an odd number of elements in anonymous hash.

10:55 PM Changeset in webkit [29995] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Gtk build fix. wchar_t is only convertible to UChar on Windows.

10:54 PM Changeset in webkit [29994] by alp@webkit.org
  • 4 edits in trunk

Fix for r29993. Should have been icon-database, not icondatabase:

2008-02-04 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Alp Toker and Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16618
[GTK] build-webkit and run-webkit-tests autootools support

Add support for the autotools build to the WebKit build and test
scripts.

10:27 PM Changeset in webkit [29993] by mrowe@apple.com
  • 7 edits in trunk

2008-02-04 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16618
[GTK] build-webkit and run-webkit-tests autootools support

  • configure.ac: make the option name of icon database consistent with the rest of webkit (from -icon-database to icondatabase)

2008-02-04 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16618
[GTK] build-webkit and run-webkit-tests autootools support

  • Scripts/build-webkit: added --database and --icondatabase options
  • Scripts/run-launcher:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
10:18 PM Changeset in webkit [29992] by oliver@apple.com
  • 6 edits in trunk

Partial fix for <rdar://5621244> Drag & Drop doesn't work correctly in DRT

Reviewed by Steve F.

iImplement required DRT functionality to allow majority of Drag and Drop testcases to work.
Issues include:

  • Uses Sleep() to implement leapForward reliably.
  • 3 DND tests still fail for reasons that i have not yet determined
  • Has to explicitly ignore an extraneous WM_MOUSELEAVE that i am at a loss to explain
9:51 PM Changeset in webkit [29991] by mrowe@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-02-04 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Geoff Garen.

Remove some unneccesary UNUSED_PARAMs. Clarify ownership rule of return value of JSObjectCopyPropertyNames.

  • API/JSNode.c: (JSNode_appendChild): (JSNode_removeChild): (JSNode_replaceChild): (JSNode_getNodeType): (JSNode_getFirstChild):
  • API/JSNodeList.c: (JSNodeList_length):
  • API/JSObjectRef.h:
9:47 PM Changeset in webkit [29990] by mrowe@apple.com
  • 5 edits
    1 add in trunk/WebCore

2008-02-04 Tony Chang <​idealisms@gmail.com>

Reviewed by Darin Adler.

Port the CoreFoundation version of WebCore::isCharacterSmartReplaceExempt
for other platforms by using ICU directly.

  • GNUmakefile.am: Add SmartReplaceICU.cpp.
  • WebCore.pro: Ditto.
  • WebCoreSources.bkl: Ditto.
  • editing/SmartReplace.cpp: Don't use this empty implementation when ICU is available.
  • editing/SmartReplaceICU.cpp: (getSmartSet): (WebCore::isCharacterSmartReplaceExempt):
9:32 PM Changeset in webkit [29989] by mrowe@apple.com
  • 3 edits
    2 adds in trunk

2008-02-04 Robert Sesek <​rsesek@bluestatic.org>

Reviewed by Darin Adler.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=17042
forms without action attributes submit to the <base> href instead of the originating page

Test: fast/forms/missing-action.html

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Submit to origin if there is no action

2008-02-04 Robert Sesek <​rsesek@bluestatic.org>

Reviewed by Darin Adler.

Test for Fix ​http://bugs.webkit.org/show_bug.cgi?id=17042
forms without action attributes submit to the <base> href instead of the originating page

  • fast/forms/missing-action-expected.txt: Added.
  • fast/forms/missing-action.html: Added.
9:18 PM Changeset in webkit [29988] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Gtk build fix. Use std::numeric_limits in place of ULLONG_MAX as some Linux machines do not have ULLONG_MAX.

OriginUsageRecord::unknownDiskUsage becomes a static function to avoid the global initialiser which would otherwise be generated.

Reviewed by Tim Hatcher.

7:34 PM Changeset in webkit [29987] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Speculative Gtk build fix.

7:25 PM Changeset in webkit [29986] by mrowe@apple.com
  • 6 edits in trunk

Fix ​http://bugs.webkit.org/show_bug.cgi?id=17175 (Bug 17175: Use of C++ compiler flags in CFLAGS).

Reviewed by Alp Toker and Mark Rowe.

Add global_cxxflags definition for inclusion in CXXFLAGS variables.
Only use -fno-rtti and $(SYMBOL_VISIBILITY_INLINES) with global_cxxflags as gcc complains they aren't valid for C.

5:41 PM Changeset in webkit [29985] by alp@webkit.org
  • 16 edits in trunk/WebKit/gtk

2008-02-04 Christian Dywan <​christian@imendio.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=17065
[GTK] Use a consistent coding style

5:33 PM Changeset in webkit [29984] by beidson@apple.com
  • 5 edits in trunk/WebCore

Attempt to fix build of all non-Mac platforms

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
4:55 PM Changeset in webkit [29983] by beidson@apple.com
  • 8 edits
    4 adds in trunk/WebCore

Reviewed by Darin

Fix for <rdar://problem/5628468> - Quotas need to be implemented per-origin, and not per-database

To accomplish this, we need to track the sizes of all databases in an origin to constantly keep an up to date
count of the origin's total disk usage. I've introduced the OriginQuotaManager and OriginUsageRecord classes
to accomplish this.

Whenever a transaction is known to mutate the size of a database (tracked by the DatabaseAuthorizer), it marks
that database as unknown in the OriginQuotaManager. When a transaction later comes along to ask the
OriginQuotaManager the usage for that origin, it stat's all of the unknown databases in the origin and returns
the result.

Since the OriginQuotaManager is interesting from both the main thread and a DatabaseThread, all accessors it
provides require it to be locked first. ASSERTs help guarantee this is always the case.

Layout test will involve adding functionality to DRT on multiple platforms and will be coming up shortly

  • WebCore.xcodeproj/project.pbxproj:
  • platform/SecurityOrigin.h: Changed to be ThreadSafeShared instead of RefCounted
  • storage/Database.cpp: (WebCore::Database::databaseSize): Return the current filesize of this database on disk (WebCore::Database::maximumSize): Added - calculates maximum size of this database based on quota and usage
  • storage/Database.h: Add databaseSize() accessor, and get rid of unused declared methods that *were* going to be the solution for this bug.
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::originQuotaManager): Accessor to the OriginQuotaManager which is lazily created (WebCore::DatabaseTracker::canEstablishDatabase): Fetch the usage for this database slightly earlier, which will ensure that the OriginQuotaManager is primed to track this origin (WebCore::DatabaseTracker::fullPathForDatabase): Ditto (WebCore::DatabaseTracker::populateOrigins): Create the OriginQuotaManager here. (WebCore::DatabaseTracker::usageForOrigin): Use the OriginQuotaManager instead of looping through each database in the origin (WebCore::DatabaseTracker::deleteOrigin): Remove this origin from the OriginQuotaManager as it is no longer interesting (WebCore::DatabaseTracker::deleteDatabase): Remove this database from the OriginQuotaManager as it is no longer interesting
  • storage/DatabaseTracker.h:
  • storage/OriginQuotaManager.cpp: Added. (WebCore::OriginQuotaManager::OriginQuotaManager): (WebCore::OriginQuotaManager::lock): (WebCore::OriginQuotaManager::unlock): (WebCore::OriginQuotaManager::trackOrigin): Add an origin to be tracked. Useful for when the very first database in a new origin is still in the process of being created (WebCore::OriginQuotaManager::tracksOrigin): (WebCore::OriginQuotaManager::addDatabase): (WebCore::OriginQuotaManager::removeDatabase): (WebCore::OriginQuotaManager::removeOrigin): Removes all records in a certain origin from being tracked (WebCore::OriginQuotaManager::markDatabase): Mark a specific database as having an unknown size - called when the DatabaseAuthorizer in a SQLTransaction knows the file size might change. (WebCore::OriginQuotaManager::diskUsage): Returns the disk usage for the given origin
  • storage/OriginQuotaManager.h: Added.
  • storage/OriginUsageRecord.cpp: Added. (WebCore::OriginUsageRecord::OriginUsageRecord): (WebCore::OriginUsageRecord::addDatabase): Adds an entry for the database in this origin's record (WebCore::OriginUsageRecord::removeDatabase): Removes that entry (WebCore::OriginUsageRecord::markDatabase): Marks the database as of unknown size (WebCore::OriginUsageRecord::diskUsage): Returns the cached disk usage value, or recalculates it if any databases are marked
  • storage/OriginUsageRecord.h: Added.
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::openTransactionAndPreflight): Use Database::maximumSize() instead of attributing the entire quota to each database. (WebCore::SQLTransaction::runStatements): Use Database::maximumSize() instead of attributing the entire quota to each database. (WebCore::SQLTransaction::runCurrentStatement): Mark this databases's size as unknown in the OriginQuotaManager if this statement will change the size of the database
  • storage/SQLTransaction.h:
4:36 PM Changeset in webkit [29982] by harrison@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5607381> CrashTracer: [REGRESSION] 1748 crashes in Safari at com.apple.WebCore: WebCore::Image::width const + 24

Use an empty image when the local image file could not be loaded.

No test case because it would require forcing tiff load failure.


  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI): Do not present the deletion UI in the (odd) event that the delete button could not be loaded.


  • platform/graphics/mac/ImageMac.mm: (WebCore::Image::loadPlatformResource): Return an empty image instead of 0 if the load fails.
3:24 PM Changeset in webkit [29981] by Darin Adler
  • 2 edits in trunk/WebCore
  • dom/Document.cpp: (WebCore::Document::completeURL): Fixed misleading comment.
2:53 PM Changeset in webkit [29980] by timothy@apple.com
  • 1 edit
    1 add in trunk/WebKitLibraries

<rdar://problem/5722735> Merge fix for SQLITE_FULL error
is given even if the max_page_count is increased (2920)

  • libWebCoreSQLite3.a:
2:15 PM Changeset in webkit [29979] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2008-02-04 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

Blacklist Silverlight versions older than min required, not newer.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::isPluginBlacklisted):
2:14 PM Changeset in webkit [29978] by hyatt@apple.com
  • 3 adds in trunk/LayoutTests/platform/mac/fast/css

Add layout test for selector parsing changes.

2:14 PM Changeset in webkit [29977] by hyatt@apple.com
  • 1 add in trunk/LayoutTests/fast/css/simple-selector-chain-parsing.html

Add layout test for selector parsing changes.

2:12 PM Changeset in webkit [29976] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix for bug 16751, misparsing of html*.test in CSS.

Reviewed by darin

Added fast/css/simple-selector-chain-parsing.html

  • css/CSSGrammar.y:
1:38 PM Changeset in webkit [29975] by Darin Adler
  • 2 edits in trunk/WebCore

Suggested by Geoff and Maciej.

  • bindings/js/JSCustomSQLTransactionCallback.cpp: Reworded a misleading comment to be correct.
1:32 PM Changeset in webkit [29974] by jhoneycutt@apple.com
  • 3 edits in trunk/WebCore

2008-02-04 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Steve, Anders.

<rdar://problem/5211187> QuickTime and Flash plug-ins draw outside of
content area when inside an iframe or div with overflow when playing a
movie and scrolling the iframe/div area

Clip the update region to the zero rect when scrolling. Don't do this
for Java, because it results in repaint problems.

  • plugins/PluginQuirkSet.h: Added the DontClipToZeroRectWhenScrolling quirk (WebCore::):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow): Readded the old behavior of clipping to the zero rect when updating the window during a scroll. Added plug-in quirk to ignore this behavior for Java. Swapped order of the SetWindowRgn() and MoveWindow() calls to prevent Java from painting outside of its container during a scroll. (WebCore::PluginViewWin::determineQuirks): If this is Java, add the DontClipToZeroRectWhenScrolling quirk.
12:57 PM Changeset in webkit [29973] by timothy@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Mark Rowe.

<rdar://problem/5722972> Leopard needs to statically link SQLite

  • Configurations/Base.xcconfig: Always have a header search path for WebCoreSQLite3.
  • Configurations/DebugRelease.xcconfig: Ditto.
  • Configurations/WebCore.xcconfig: Always link against WebCoreSQLite3.
12:29 PM Changeset in webkit [29972] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added one more failure.
12:24 PM Changeset in webkit [29971] by Adam Roben
  • 1 edit in trunk/LayoutTests/platform/win/Skipped

Fixed a typo

12:23 PM Changeset in webkit [29970] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added some new failures.
12:17 PM Changeset in webkit [29969] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix

  • bindings/scripts/CodeGeneratorCOM.pm: Touched to force a rebuild of the COM bindings.
11:04 AM Changeset in webkit [29968] by harrison@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

Reviewed by Tim Hatcher.

  • fix <rdar://problem/5715481> REGRESSION (r26499): JavaScript document.lastModified is not supported

Re-add attribute inadvertantly lost by r26499.

Test: fast/js/lastModified.html: Added.

  • dom/Document.idl: Add lastModified.

LayoutTests:

Reviewed by Tim Hatcher.

Test for <rdar://problem/5715481> REGRESSION (r26499): JavaScript document.lastModified is not supported

  • fast/js/lastModified-expected.txt: Added.
  • fast/js/lastModified.html: Added.
  • fast/js/resources/lastModified.js: Added.
10:41 AM Changeset in webkit [29967] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

Fix wrongly auto-merged change log.

10:40 AM Changeset in webkit [29966] by Darin Adler
  • 3 edits in trunk/WebCore

Fix the search field if the inpsected Document has overridden
Document.evaluate or Document.querySelectorAll

Reviewed by Darin.

  • manual-tests/inspector-document-methods-override.html: Added.
  • page/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): Reworded a comment to force WebCore.vcproj to build.
  • page/inspector/inspector.js: Call Document.prototype.{evaluate,querySelectorAll}.call instead of calling the functions directly on the inspected Document. This ensures we are calling the version of these functions we intended to.
10:37 AM Changeset in webkit [29965] by Adam Roben
  • 3 edits
    1 add in trunk/WebCore

Fix the search field if the inpsected Document has overridden Document.evaluate or Document.querySelectorAll

Reviewed by Darin.

  • manual-tests/inspector-document-methods-override.html: Added.
  • page/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): Reworded a comment to force WebCore.vcproj to build.
  • page/inspector/inspector.js: Call Document.prototype.{evaluate,querySelectorAll}.call instead of calling the functions directly on the inspected Document. This ensures we are calling the version of these functions we intended to.
10:26 AM ApplicationsGtk edited by alp@atoker.com
Add another app: Clutter (diff)
9:31 AM ApplicationsGtk edited by alp@atoker.com
List a few more apps (diff)
9:25 AM Changeset in webkit [29964] by Darin Adler
  • 4 edits in trunk/WebCore

Reviewed by Tim Hatcher.

  • possible fix for <rdar://problem/5714030> Crash in Database::deliverAllPendingCallbacks() reloading a page quickly

I don't fully understand the cause of the crash, but I think this might
be a helpful change.

  • platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::commit): If the commit fails, don't leave this transaction and database both marked as "still in progress". As far as I can tell this does no good, and also seems to do harm. (WebCore::SQLiteTransaction::rollback): Ditto.
  • storage/Database.cpp: (WebCore::Database::performTransactionStep): Add some assertions to detect databases stuck in the "transaction in progress" state.
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::openTransactionAndPreflight): Ditto. (WebCore::SQLTransaction::postflightAndCommit): Ditto. (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): Ditto.
9:23 AM Changeset in webkit [29963] by Darin Adler
  • 19 edits
    1 copy
    5 adds in trunk

WebCore:

Reviewed by Geoff.

  • fix <rdar://problem/5715692> REGRESSION (r28570): JavaScript window.scrollTo() calls no longer accept 'undefined' values

By default, we should accept non-numeric parameters and non-integral numbers for
parameters that expect integers, without throwing exceptions.

While creating the test for this, I ran into a couple minor bugs with the
functions involved, and this patch fixes those too.

Test: fast/dom/non-numeric-values-numeric-parameters.html

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::add): Added. This function has unusual behavior when passed non-integral values for its second parameter, so it needs to be written by hand. I think that [Custom] is better here than inventing a new keyword.
  • bindings/scripts/CodeGeneratorJS.pm: Changed default for "long" and "unsigned long" to ignore errors rather than failing due to type differences. Also changed a couple functions to use hashes.
  • css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::removeRule): Remove overload of removeRule without a second parameters. While we do allow this from JavaScript, it's not a true optional parameter, but rather just a case of "you can omit parameters and they are treated as undefined" combined with "undefined turns into 0 when passed to a function that takes an integer".
  • css/CSSStyleSheet.idl: Removed [Optional] on the index parameter for removeRule. This is not truly an optional parameter.
  • dom/ProgressEvent.cpp: (WebCore::ProgressEvent::initProgressEvent): Updated this function to match other DOM event init functions -- important to do nothing if this is called on the an already-dispatched event and we need to respect the bubble and cancelable arguments. Also removed initProgressEventNS. We don't support namespaced events, and if we add support, it should be across all event classes, not just ProgressEvent.
  • dom/ProgressEvent.h: Removed initProgressEventNS.
  • dom/ProgressEvent.idl: Ditto.
  • dom/Range.cpp: (WebCore::Range::createContextualFragment): Added a check for 0. This can happen if the passed-in start container is a node that's not an HTML element and also does not have a parent.
  • html/HTMLOptionsCollection.idl: Added the [Custom] attribute to add, since the rules for processing its parameters are unusual.
  • page/DOMSelection.cpp: Removed the version of setPosition that has only one parameter. The offset is not really optional.
  • page/DOMSelection.h: Ditto.
  • page/DOMSelection.idl: Removed the [Optional] keyword for the second parameter of setPosition. It's not a true optional parameter (see discussion of removeRule above).
  • page/DOMWindow.cpp: (WebCore::DOMWindow::adjustWindowRect): Simplified logic for constraining the X and Y coordinates, in a way that makes them work even when the window coordinates are infinite. Also strengthened the assertion.

WebKitTools:

Reviewed by Geoff.

  • Scripts/make-js-test-wrappers: Look at the whole LayoutTests tree, not just the fast and svg subdirectories. Added some more exceptions for the benefit of the fast/dom subdirectory.

LayoutTests:

Reviewed by Geoff.

  • test for <rdar://problem/5715692> REGRESSION (r28570): JavaScript window.scrollTo() calls no longer accept 'undefined' values
  • fast/dom/non-numeric-values-numeric-parameters-expected.txt: Added.
  • fast/dom/non-numeric-values-numeric-parameters.html: Added.
  • fast/dom/resources/TEMPLATE.html: Copied from fast/dom/Element/resources/TEMPLATE.html.
  • fast/dom/resources/non-numeric-values-numeric-parameters.js: Added.
  • editing/selection/extend-expected.txt: Updated.
  • editing/selection/extend.html: Removed test that extend throws if passed only one parameter. There's no reason for us to be strict about this -- we generally treat missing parameters the same as if "undefined" had been passed with few exceptions.
8:13 AM Changeset in webkit [29962] by Adam Roben
  • 2 edits in trunk/WebKitTools

Windows Apple-only build fix

  • DumpRenderTree/win/DumpRenderTree.vcproj: Added a new include directory.
5:34 AM QtWebKitTodo edited by Simon Hausmann
(diff)
3:00 AM Changeset in webkit [29961] by alp@webkit.org
  • 71 edits in trunk

2008-02-04 Alp Toker <​alp@atoker.com>

Rubber-stamped by Mark Rowe.

Remove all trailing whitespace in the GTK+ port and related
components.

Feb 3, 2008:

10:34 PM Changeset in webkit [29960] by mitz@apple.com
  • 6 edits in trunk/LayoutTests/fast/canvas

Set some PNGs' svn:mime-type property to image/png

10:27 PM UsingGitWithWebKit edited by eric@webkit.org
(diff)
10:25 PM Changeset in webkit [29959] by oliver@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Add an additional test for Canvas.transform with non-invertible matrix.

RS=Eric

  • fast/canvas/canvas-transform-non-invertible-expected.checksum: Added.
  • fast/canvas/canvas-transform-non-invertible-expected.png: Added.
  • fast/canvas/canvas-transform-non-invertible-expected.txt: Added.
  • fast/canvas/canvas-transform-non-invertible.html: Added.
10:20 PM Changeset in webkit [29958] by alp@webkit.org
  • 9 edits in trunk

2008-02-03 Christian Dywan <​christian@imendio.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=17046
[GTK] Context menu fixes and customisation suport

Provide standard GTK+ context menu items where appropriate.

7:41 PM Changeset in webkit [29957] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Typo fix. Don't use the provisionalDocumentLoader() after the whole page has already been loaded.
​http://bugs.webkit.org/show_bug.cgi?id=17157

6:35 PM Changeset in webkit [29956] by oliver@apple.com
  • 5 edits
    20 adds in trunk

Bug 17169: Support transform on Canvas

Reviewed by Maciej.

Nice and simple patch as the cross-platform code to apply
a transform was already there.

Tests: fast/canvas/canvas-transform-identity.html

fast/canvas/canvas-transform-infinity.html
fast/canvas/canvas-transform-multiply.html
fast/canvas/canvas-transform-nan.html
fast/canvas/canvas-transform-skewed.html

4:14 PM Changeset in webkit [29955] by Nikolas Zimmermann
  • 1 edit
    4 adds in trunk/LayoutTests

Rubber stamped by Eric.
Add missing layout test results.

4:11 PM Changeset in webkit [29954] by Nikolas Zimmermann
  • 3 edits
    4 adds in trunk

Reviewed by Oliver.

Fix mistake in SVGImageElement, breaking "Dock" example of carto.net
It was comparing against the wrong attribute names in svgAttributeChanged().

Added testcase: svg/custom/js-update-image.svg

3:55 PM Changeset in webkit [29953] by eric@webkit.org
  • 7 edits
    6 adds in trunk

Reviewed by darin.

Acid3 expects textNode.localName === null
​http://bugs.webkit.org/show_bug.cgi?id=17060

Test: fast/dom/Node/initial-values.html

  • dom/Comment.cpp: remove localName implementation
  • dom/Comment.h:
  • dom/Node.cpp: return nullAtom instead of emptyAtom
  • dom/Text.cpp: remove localName implementation
  • dom/Text.h:
3:46 PM Changeset in webkit [29952] by eric@webkit.org
  • 5 edits
    7 adds in trunk

Reviewed by darin.

Make createElementNS and createAttributeNS follow the (vague) DOM Core 2 spec
by throwing exceptions for more types of invalid qualified names.
​http://bugs.webkit.org/show_bug.cgi?id=16833

Tests: fast/dom/Document/createAttributeNS-namespace-err.html

fast/dom/Document/createElementNS-namespace-err.html

  • dom/Document.cpp: (WebCore::Document::createElement): (WebCore::hasNamespaceError): (WebCore::Document::createElementNS): (WebCore::Document::createAttributeNS):
  • dom/Document.idl:
3:18 PM Changeset in webkit [29951] by Nikolas Zimmermann
  • 129 edits in trunk/WebCore

Reviewed by Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=15394

Dramatically improve dynamic update performance in DOM / SVG DOM.

The notifyAttributeChange() sledgehammer is gone now. It was implemented on quite a lot of
SVG*Element classes and blindly reacted on any property change caused by DOM / SVG DOM
by rebuilding style/renderer etc. without actually checking what changed. SVG used a hack
for years that attributeChanged() called notifyAttributeChange() - which results in poor
scripting performance and/or dynamic creation/modification of elements using SVG DOM.

2:17 PM Changeset in webkit [29950] by kevino@webkit.org
  • 6 edits in trunk

Build fix for last wx commit (a couple things were not committed). Also fix some style issues.

1:35 PM Changeset in webkit [29949] by kevino@webkit.org
  • 3 edits in trunk/WebCore

Clean up overlooked coding guideline issues from last commit.

1:10 PM Changeset in webkit [29948] by kevino@webkit.org
  • 4 edits in trunk/WebCore

Widget needs to subclass wxWindow, not wxScrolledWindow for wx port, to fix several scrolling-related issues.
​http://bugs.webkit.org/show_bug.cgi?id=17165

8:38 AM Changeset in webkit [29947] by Darin Adler
  • 1 edit
    10 copies
    3 deletes in trunk/LayoutTests
  • updated some more only-child and only-of-type tests to expect success (failures seen on buildbot)

The tests were now succeeding, but the results and placement reflected failure.
I'm not sure why we have such a tiny set of tests in the css3 directory.
The expected results are updated as well as moved.

  • css3/css3-modsel-36.html: Copied from css3/expected_failures/css3-modsel-36.html.
  • css3/css3-modsel-37.html: Copied from css3/expected_failures/css3-modsel-37.html.
  • platform/mac/css3/css3-modsel-36-expected.checksum: Copied from platform/mac/css3/expected_failures/css3-modsel-36-expected.checksum.
  • platform/mac/css3/css3-modsel-36-expected.png: Copied from platform/mac/css3/expected_failures/css3-modsel-36-expected.png.
  • platform/mac/css3/css3-modsel-36-expected.txt: Copied from platform/mac/css3/expected_failures/css3-modsel-36-expected.txt.
  • platform/mac/css3/css3-modsel-37-expected.checksum: Copied from platform/mac/css3/expected_failures/css3-modsel-37-expected.checksum.
  • platform/mac/css3/css3-modsel-37-expected.png: Copied from platform/mac/css3/expected_failures/css3-modsel-37-expected.png.
  • platform/mac/css3/css3-modsel-37-expected.txt: Copied from platform/mac/css3/expected_failures/css3-modsel-37-expected.txt.
  • platform/qt/css3/css3-modsel-36-expected.txt: Copied from platform/qt/css3/expected_failures/css3-modsel-36-expected.txt.
  • platform/qt/css3/css3-modsel-37-expected.txt: Copied from platform/qt/css3/expected_failures/css3-modsel-37-expected.txt.
  • css3/expected_failures: Removed.
  • platform/mac/css3/expected_failures: Removed.
  • platform/qt/css3/expected_failures: Removed.
3:11 AM QtWebKitContrib edited by Simon Hausmann
(diff)
Note: See TracTimeline for information about the timeline view.