Context Navigation

← Previous Period
Next Period →

Timeline

Feb 12, 2008:

10:32 PM Changeset in webkit [30190] by timothy@apple.com

1 edit in trunk/WebCore/platform/sql/SQLiteDatabase.cpp

Comment out the ASSERT to make the layout tests pass. Filed <rdar://problem/5739818> to track the issue.

10:04 PM Changeset in webkit [30189] by timothy@apple.com

7 edits in trunk/WebCore

Reviewed by Brady Eidson.

<rdar://problem/5652560> Can't delete database if the website that
uses it has been opened in this session

Close the Database on the database thread before deleting the file.
Tested and works on Windows and Mac.

platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::close): Assert we are on the opening thread.
storage/Database.cpp: (WebCore::Database::markAsDeletedAndClose): Unschedule any pending Database tasks, and start and imediate DatabaseCloseTask. (WebCore::Database::close): Close the SQLDatabase.
storage/Database.h: Renamed markAsDeleted to markAsDeletedAndClose.
storage/DatabaseTask.cpp: (WebCore::DatabaseCloseTask::DatabaseCloseTask): New task. (WebCore::DatabaseCloseTask::doPerformTask): Call close on the Database. (WebCore::DatabaseCloseTask::debugTaskName): Return "DatabaseCloseTask".
storage/DatabaseTask.h: Add DatabaseCloseTask.
storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::deleteDatabaseFile): Call the renamed markAsDeletedAndClose.

9:12 PM BuildingCairoOnWindows edited by bfulgham@macports.org

(diff)

8:22 PM Changeset in webkit [30188] by oliver@apple.com

3 edits in trunk/WebCore

Endeavour to fix qt and gtk builds

7:07 PM Changeset in webkit [30187] by Adam Roben

2 edits in trunk/WebKitLibraries

Clean up auto-version.sh a bit

It now does quite a bit less file I/O and many fewer fork/exec pairs.
It's also quite a bit easier to read.

Reviewed by Steve.

win/tools/scripts/auto-version.sh:

6:53 PM Changeset in webkit [30186] by sfalken@apple.com

2 edits
2 adds in trunk/WebKit/win

Use a precompiled header to build WebKit.

Reviewed by Adam.

WebKit.vcproj/WebKit.vcproj:
WebKitPrefix.cpp: Added.
WebKitPrefix.h: Added.

6:11 PM Changeset in webkit [30185] by oliver@apple.com

6 edits in trunk/WebCore

Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp
Remove ifdef's from canvas paint code

Reviewed by Eric S.

By making GraphicsContext aware of the crossplatform ImageBuffer
type we can migrate the ifdef-ified paint code in HTMLCanvasElement
into platform implementations of GraphicsContext.

5:10 PM Changeset in webkit [30184] by beidson@apple.com

5 edits in trunk/WebCore

Reviewed by Darin Adler

Fix for <rdar://problem/5737692> - Database API needs to support SuccessCallback

Layout tests will come shortly with a mess of DRT changes

platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): Standardize on "empty string" instead of null string as different paths of constructing a SecurityOrigin were causing different hashes for the "same" SecurityOrigin

storage/Database.cpp: (WebCore::Database::changeVersion): Pass in the successCallback (WebCore::Database::transaction): Ditto

storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::debugStepName): (WebCore::SQLTransaction::performNextStep): Update ASSERTs for the new valid steps (WebCore::SQLTransaction::performPendingCallback): Ditto (WebCore::SQLTransaction::postflightAndCommit): Schedule the success callback if it exists - otherwise skip straight to cleanupAfterSuccessCallback() (WebCore::SQLTransaction::deliverSuccessCallback): Deliver success callback on the main thread, then schedule cleanupAfterSuccessCallback() (WebCore::SQLTransaction::cleanupAfterSuccessCallback): Cleanup and end the transaction (WebCore::SQLTransaction::handleTransactionError): (WebCore::SQLTransaction::deliverTransactionErrorCallback): (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
storage/SQLTransaction.h:

4:18 PM Changeset in webkit [30183] by sfalken@apple.com

2 edits in trunk/WebKitLibraries

Versioning script change.

win/tools/scripts/auto-version.sh:

4:16 PM Changeset in webkit [30182] by sfalken@apple.com

2 edits in trunk/WebCore

Changes to support merged MIDL output.

All COM interfaces are now generated to WebKit.h.

Reviewed by Sam, Ada.

bindings/scripts/CodeGeneratorCOM.pm:

4:16 PM Changeset in webkit [30181] by sfalken@apple.com

19 edits in trunk/WebKitTools

Changes to support merged MIDL output.

All COM interfaces are now generated to WebKit.h.

Reviewed by Sam, Ada.

Drosera/win/BaseDelegate.h:
Drosera/win/DebuggerClient.cpp:
Drosera/win/DebuggerDocumentPlatform.cpp:
Drosera/win/Drosera.cpp:
Drosera/win/ServerConnection.cpp:
Drosera/win/ServerConnection.h:
DumpRenderTree/win/DumpRenderTree.cpp:
DumpRenderTree/win/EditingDelegate.h:
DumpRenderTree/win/EventSender.cpp:
DumpRenderTree/win/FrameLoadDelegate.cpp:
DumpRenderTree/win/FrameLoadDelegate.h:
DumpRenderTree/win/GCControllerWin.cpp:
DumpRenderTree/win/LayoutTestControllerWin.cpp:
DumpRenderTree/win/PolicyDelegate.h:
DumpRenderTree/win/ResourceLoadDelegate.h:
DumpRenderTree/win/UIDelegate.cpp:
DumpRenderTree/win/UIDelegate.h:
DumpRenderTree/win/WorkQueueItemWin.cpp:

4:16 PM Changeset in webkit [30180] by sfalken@apple.com

122 edits in trunk/WebKit/win

Changes to support merged MIDL output.

All COM interfaces are now generated to WebKit.h.

Reviewed by Sam, Ada.

DOMCSSClasses.h:
DOMCoreClasses.h:
DOMEventsClasses.h:
DOMHTMLClasses.h:
DefaultDownloadDelegate.h:
DefaultPolicyDelegate.cpp:
DefaultPolicyDelegate.h:
GEN_DOMObject.h:
Interfaces/DOMCSS.idl:
Interfaces/DOMCore.idl:
Interfaces/DOMEvents.idl:
Interfaces/DOMExtensions.idl:
Interfaces/DOMHTML.idl:
Interfaces/DOMPrivate.idl:
Interfaces/DOMRange.idl:
Interfaces/DOMWindow.idl:
Interfaces/IGEN_DOMObject.idl:
Interfaces/IWebArchive.idl:
Interfaces/IWebBackForwardList.idl:
Interfaces/IWebBackForwardListPrivate.idl:
Interfaces/IWebCache.idl:
Interfaces/IWebDataSource.idl:
Interfaces/IWebDatabaseManager.idl:
Interfaces/IWebDocument.idl:
Interfaces/IWebDownload.idl:
Interfaces/IWebEditingDelegate.idl:
Interfaces/IWebError.idl:
Interfaces/IWebErrorPrivate.idl:
Interfaces/IWebFormDelegate.idl:
Interfaces/IWebFrame.idl:
Interfaces/IWebFrameLoadDelegate.idl:
Interfaces/IWebFrameLoadDelegatePrivate.idl:
Interfaces/IWebFramePrivate.idl:
Interfaces/IWebFrameView.idl:
Interfaces/IWebHTMLRepresentation.idl:
Interfaces/IWebHTTPURLResponse.idl:
Interfaces/IWebHistory.idl:
Interfaces/IWebHistoryItem.idl:
Interfaces/IWebHistoryItemPrivate.idl:
Interfaces/IWebIconDatabase.idl:
Interfaces/IWebInspector.idl:
Interfaces/IWebJavaScriptCollector.idl:
Interfaces/IWebKitStatistics.idl:
Interfaces/IWebMutableURLRequest.idl:
Interfaces/IWebMutableURLRequestPrivate.idl:
Interfaces/IWebNotification.idl:
Interfaces/IWebNotificationCenter.idl:
Interfaces/IWebNotificationObserver.idl:
Interfaces/IWebPolicyDelegate.idl:
Interfaces/IWebPreferences.idl:
Interfaces/IWebPreferencesPrivate.idl:
Interfaces/IWebResource.idl:
Interfaces/IWebResourceLoadDelegate.idl:
Interfaces/IWebResourceLoadDelegatePrivate.idl:
Interfaces/IWebScriptCallFrame.idl:
Interfaces/IWebScriptDebugListener.idl:
Interfaces/IWebScriptDebugServer.idl:
Interfaces/IWebScriptObject.idl:
Interfaces/IWebScriptScope.idl:
Interfaces/IWebScrollBarDelegatePrivate.idl:
Interfaces/IWebScrollBarPrivate.idl:
Interfaces/IWebSecurityOrigin.idl:
Interfaces/IWebTextRenderer.idl:
Interfaces/IWebUIDelegate.idl:
Interfaces/IWebUIDelegatePrivate.idl:
Interfaces/IWebURLAuthenticationChallenge.idl:
Interfaces/IWebURLRequest.idl:
Interfaces/IWebURLResponse.idl:
Interfaces/IWebURLResponsePrivate.idl:
Interfaces/IWebUndoManager.idl:
Interfaces/IWebUndoTarget.idl:
Interfaces/IWebView.idl:
Interfaces/IWebViewPrivate.idl:
Interfaces/WebKit.idl:
WebActionPropertyBag.cpp:
WebBackForwardList.h:
WebCache.h:
WebDataSource.cpp:
WebDataSource.h:
WebDatabaseManager.h:
WebDownload.h:
WebEditorClient.cpp:
WebEditorClient.h:
WebError.h:
WebFrame.cpp:
WebFrame.h:
WebFramePolicyListener.h:
WebHTMLRepresentation.cpp:
WebHTMLRepresentation.h:
WebHistory.cpp:
WebHistory.h:
WebHistoryItem.h:
WebIconDatabase.h:
WebInspector.h:
WebJavaScriptCollector.h:
WebKit.vcproj/Interfaces.vcproj:
WebKit.vcproj/WebKitGUID.vcproj:
WebKitDLL.cpp:
WebKitStatistics.h:
WebMutableURLRequest.cpp:
WebMutableURLRequest.h:
WebNotification.h:
WebNotificationCenter.h:
WebPreferences.h:
WebResource.h:
WebScriptCallFrame.h:
WebScriptDebugServer.cpp:
WebScriptDebugServer.h:
WebScriptDebugger.cpp:
WebScriptDebugger.h:
WebScriptObject.h:
WebScrollBar.h:
WebSecurityOrigin.h:
WebTextRenderer.h:
WebURLAuthenticationChallenge.h:
WebURLAuthenticationChallengeSender.h:
WebURLCredential.h:
WebURLProtectionSpace.h:
WebURLResponse.h:
WebView.cpp:
WebView.h:

3:54 PM Changeset in webkit [30179] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Adam Roben.

fix http://bugs.webkit.org/show_bug.cgi?id=17041 <rdar://problem/5709660> Eastern Asian fonts do not display without specific box in Control Panel

Revised the system fallback font lookup logic to use MLang font linking
again. To avoid reintroducing bug 16548 and <rdar://problem/5280188>,
for CJK characters, try linking based on a single code page at a time,
starting with the user's default code page (if it is one of the CJK
code pages) followed by the other CJK code pages in a prescribed order
that matches what Firefox does.

platform/graphics/win/FontCacheWin.cpp: (WebCore::getCJKCodePageMasks): Added. Returns the search order for CJK code pages, with the user's default code page first. (WebCore::currentFontContainsCharacter): Factored out of getFontDataForCharacters(). (WebCore::createMLangFont): Ditto. (WebCore::FontCache::getFontDataForCharacters):

3:34 PM Changeset in webkit [30178] by andersca@apple.com

2 edits in trunk/WebKit/win

Reviewed by Adam.

Implement imageTitle.

WebCoreLocalizedStrings.cpp: (WebCore::imageTitle):

1:29 PM Changeset in webkit [30177] by weinig@apple.com

2 edits in trunk/JavaScriptCore

Reviewed by Brady Eidson.

<rdar://problem/5659216> REGRESSION: PLT 0.3% slower due to r28868 (caching ClassNodeList and NamedNodeList)

Tweak the statements in isASCIISpace to account for the statistical distribution of usage in the PLT.

.4% speedup on my machine. Stephanie's machine shows this as .3% speedup.

wtf/ASCIICType.h: (WTF::isASCIISpace):

1:17 PM Changeset in webkit [30176] by mitz@apple.com

2 edits
2 adds in trunk/LayoutTests

Rubber-stamped by Adam Roben.

make fast/css/css3-nth-child pass

fast/css/css3-nth-child.html: Removed spaces that were making the :nth-child selector fail to parse because of <rdar://problem/5733761>.
platform/mac-leopard/fast/css/css3-nth-child-expected.checksum: Added.
platform/mac-leopard/fast/css/css3-nth-child-expected.png: Added.

1:04 PM Changeset in webkit [30175] by alp@webkit.org

5 edits in trunk

2008-02-12 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed by Alp Toker.

Add -DMAEMO_CHANGES when the hildon CONFIG option is specified
Add hildon-1 to PKGCONFIG when hildon CONFIG option is specified

12:13 PM Changeset in webkit [30174] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Timothy Hatcher.

<rdar://problem/5738175> Remove workaround for <rdar://problem/5539388> from post-Tiger builds

platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setShadow):

12:11 PM Changeset in webkit [30173] by beidson@apple.com

2 edits in trunk/WebCore

Release build fix

storage/DatabaseTask.cpp:

11:37 AM Changeset in webkit [30172] by ap@webkit.org

13 edits
3 adds in trunk/WebCore

Reviewed by Brady.

http://bugs.webkit.org/show_bug.cgi?id=17177
<rdar://problem/5729619> Storage tasks are getting lost

<rdar://problem/5729445> REGRESSION: Cannot schedule more than one transaction at a time

<rdar://problem/5729446> Major thread safety issue in Database code

platform/MessageQueue.h: Added a thread-safe queue abstraction.

WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj: Added MessageQueue.h.

dom/Document.cpp: (WebCore::Document::~Document): Fixed a race condition resulting in a hanging reference.

storage/Database.idl: Fixed parameter declarations to actually match implementation (which is custom, so it got out of sync).

storage/DatabaseTask.h: (WebCore::DatabaseTask::database): (WebCore::DatabaseTransactionTask::transaction): Changed tasks to hold more information internally. Added helpers for better debug logging.

storage/DatabaseTask.cpp: (WebCore::DatabaseTask::DatabaseTask): (WebCore::DatabaseTask::performTask): (WebCore::DatabaseOpenTask::DatabaseOpenTask): (WebCore::DatabaseOpenTask::doPerformTask): (WebCore::DatabaseOpenTask::debugTaskName): (WebCore::DatabaseTransactionTask::DatabaseTransactionTask): (WebCore::DatabaseTransactionTask::~DatabaseTransactionTask): (WebCore::DatabaseTransactionTask::doPerformTask): (WebCore::DatabaseTransactionTask::debugTaskName): (WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask): (WebCore::DatabaseTableNamesTask::doPerformTask): (WebCore::DatabaseTableNamesTask::debugTaskName): Implementation for the above.

(WebCore::DatabaseTask::lockForSynchronousScheduling):
(WebCore::DatabaseTask::waitForSynchronousCompletion):
Fixed a potential race condition: if the task completed before we entered a wait, we'd never
wake up. There was an assertion guarding against this, but no actual guarantee that I could see.

storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::requestTermination): (WebCore::DatabaseThread::databaseThread): (WebCore::DatabaseThread::scheduleTask): (WebCore::DatabaseThread::scheduleImmediateTask): (WebCore::DatabaseThread::unscheduleDatabaseTasks):
storage/DatabaseThread.h: Changed to use MessageQueue.

storage/Database.cpp: (WebCore::guidMutex): (WebCore::guidToVersionMap): (WebCore::guidToDatabaseMap): (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::~Database): (WebCore::Database::openAndVerifyVersion): (WebCore::guidForOriginAndName): (WebCore::Database::changeVersion): (WebCore::Database::transaction): (WebCore::Database::scheduleTransaction): (WebCore::Database::scheduleTransactionStep): (WebCore::Database::scheduleTransactionCallback): (WebCore::Database::version): (WebCore::Database::deliverPendingCallback): (WebCore::Database::tableNames):
storage/Database.h: Changed m_transactionQueue to a MessageQueue. Got rid of callback tracking - these can take care of themselves. Got rid of a DatabaseThread member, as the Document can be asked for it. Moved private static members and helpers out of the header. Lost CurrentThreadSetter debug helper on the way. We may need to re-add something like that later.

storage/SQLTransaction.h:
storage/SQLTransaction.cpp: Added a lot of debug logging. (WebCore::SQLTransaction::scheduleToRunStatements): Removed "m_currentStatement = 0" assignment, as it created a race condition. Everything seems to work better without it, although a real fix would be to get rid of this variable - it's evil shared data that isn't even protected in any way.

manual-tests/database-threading-stress-test-2.html: Added.
manual-tests/database-threading-stress-test.html: Added.

11:29 AM Changeset in webkit [30171] by Adam Roben

3 edits
3 adds in trunk

Fix Bug 17328: REGRESSION (r30147): Inspector is unstyled on Windows

WebCore:

Fix Bug 17328: REGRESSION (r30147): Inspector is unstyled on Windows

<http://bugs.webkit.org/show_bug.cgi?id=17328>
<rdar://5737946>

Reviewed by Mitz.

Test: fast/loader/local-css-allowed-in-strict-mode.html

platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse): Add a case for .css files.

LayoutTests:

Add a test for Bug 17328: REGRESSION (r30147): Inspector is unstyled
on Windows

<http://bugs.webkit.org/show_bug.cgi?id=17328>
<rdar://5737946>

Reviewed by Mitz.

fast/loader/local-css-allowed-in-strict-mode-expected.txt: Added.
fast/loader/local-css-allowed-in-strict-mode.html: Added.
fast/loader/resources/stylesheet.css: Added.

11:17 AM Changeset in webkit [30170] by andersca@apple.com

2 edits in trunk/WebCore

Build fix.

loader/ImageDocument.cpp:

10:53 AM Changeset in webkit [30169] by andersca@apple.com

1 edit in trunk/WebKit/mac/ChangeLog

Fix tyop.

10:51 AM Changeset in webkit [30168] by andersca@apple.com

15 edits
2 deletes in trunk

WebCore:

Reviewed by Mitz.

Make the code that sets the image title cross platform.

WebCore.xcodeproj/project.pbxproj: Remove ImageDocumentMac.

loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish):

loader/mac/ImageDocumentMac.h: Removed.
loader/mac/ImageDocumentMac.mm: Removed.

page/mac/WebCoreFrameBridge.h:
page/mac/WebCoreViewFactory.h: Move imageTitleForFilename:size from the bridge to the view factory.

platform/LocalizedStrings.h: Add imageTitle.

platform/mac/LocalizedStringsMac.mm: (WebCore::imageTitle): Have imageTitle call the view factory.

platform/qt/Localizations.cpp: (WebCore::imageTitle):
platform/wx/LocalizedStringsWx.cpp: (WebCore::imageTitle):
platform/gtk/LocalizedStringsGtk.cpp: (WebCore::imageTitle): Add stubs.

WebKit/mac:

Reviewed by Mitz.

WebCoreSupport/WebFrameBridge.mm:
WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory imageTitleForFilename:size:]): Move implementatino from WebFrameBridge to WebViewFactory.

WebKit/win:

Reviewed by Mitz.

WebCoreLocalizedStrings.cpp: (WebCore::imageTitle): Add stub.

5:23 AM Changeset in webkit [30167] by Nikolas Zimmermann

1 edit
31 adds in trunk/LayoutTests

Not reviewed, adding missing layout test results (that have been r+ already, but not commited)

1:40 AM Changeset in webkit [30166] by oliver@apple.com

2 edits in trunk/WebCore

more Qt fixes

1:30 AM Changeset in webkit [30165] by oliver@apple.com

2 edits in trunk/WebCore

Yet another attempt to fix Qt

1:21 AM Changeset in webkit [30164] by oliver@apple.com

2 edits in trunk/WebCore

Attempt to fix qt build

1:14 AM Changeset in webkit [30163] by oliver@apple.com

4 edits in trunk/WebCore

Make canvas use an ImageBuffer for its backing store

Reviewed by Alp Toker.

In order to make the canvas implementation less platform dependent
(and thus reduce the current quagmire of ifdefs) we now use an
ImageBuffer to provide the backing buffer, an immediate consequence
of this is to remove multiple ifdefs in the construction of the
buffer. This patch allows us to further reduce the platform
dependencies in later patches.

Feb 11, 2008:

10:02 PM Changeset in webkit [30162] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=17320 <rdar://problem/5736953> :last-child does not set the "uses sibling rules" flag

Test: fast/css/last-child-style-sharing.html

css/CSSGrammar.y: Changed to call setUsesSiblingRules(true) for all CSS3 selectors that require it.

LayoutTests:

Reviewed by Dave Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=17320 <rdar://problem/5736953> :last-child does not set the "uses sibling rules" flag

fast/css/last-child-style-sharing.html: Added.
platform/mac/fast/css/last-child-style-sharing-expected.checksum: Added.
platform/mac/fast/css/last-child-style-sharing-expected.png: Added.
platform/mac/fast/css/last-child-style-sharing-expected.txt: Added.

7:02 PM Changeset in webkit [30161] by timothy@apple.com

2 edits
7 deletes in tags/Safari-5525.8/LayoutTests

Merge the LayoutTests part of r30052.

7:01 PM Changeset in webkit [30160] by timothy@apple.com

3 edits in tags/Safari-5525.8/WebCore

Merge the WebCore part of r30052.

5:31 PM Changeset in webkit [30159] by timothy@apple.com

1 copy in tags/Safari-5525.8

New tag.

5:24 PM Changeset in webkit [30158] by weinig@apple.com

4 edits in trunk/JavaScriptCore

Reviewed by Anders Carlsson.

Fixes for:
<rdar://problem/5735497> Match Firefox's cross-domain model more accurately by return the built-in version of functions even if they have been overridden
<rdar://problem/5735443> Crash when setting the Window objects prototype to a custom Object and then calling a method on it

Expose the native Object.prototype.toString implementation so that it can be used for cross-domain toString calling.

JavaScriptCore.exp:
kjs/object_object.cpp:
kjs/object_object.h:

4:26 PM Changeset in webkit [30157] by weinig@apple.com

21 edits
1 move
16 adds
1 delete in trunk

WebCore:

Reviewed by Darin Adler.

Make the cross-domain security model more closely match Firefox by always returning the
native built-in functions when accessing functions cross-domain.

Fixes for:
<rdar://problem/5735497> Match Firefox's cross-domain model more accurately by return the built-in version of functions even if they have been overridden
<rdar://problem/5735443> Crash when setting the Window objects prototype to a custom Object and then calling a method on it

Tests: fast/dom/Window/window-custom-prototype-crash.html

fast/dom/Window/window-function-frame-getter-precedence.html
http/tests/security/cross-frame-access-get-override.html
http/tests/security/cross-frame-access-location-get-override.html
http/tests/security/cross-frame-access-location-get.html
http/tests/security/cross-frame-access-location-put.html

bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
Return the native-built in version of an cross-domain allowed function (eg. window.focus) whether or not it has been overridden, instead of undefined.
When doing findEntry lookup, use the the tables directly (JSDOMWindowPrototype::info.propHashTable) instead of calling the virtual classInfo() method to avoid the unnecessary overhead.
Allow access to the native toString function cross-domain. It always returns "[object Window]".
Use the new nonCachingStaticFunctionGetter when return allowed functions cross-frame so that the function an overridden function is not inadvertantly returned from the PropertyMap.\

bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::customGetOwnPropertySlot):
Implement the same model as described above for the History object, always returning the native built-in function cross-domain.
Allow access to the native toString function cross-domain.
Clean up the code to make it clear that the custom functionality is only there for cross-domain access.

bindings/js/JSLocation.cpp: (WebCore::JSLocation::getOwnPropertySlot):
Match the generated classes by moving all the custom logic into a separate customGetOwnPropertySlot function. This will help moving to a generated class in the future. (WebCore::JSLocation::customGetOwnPropertySlot):
Implement the same model as described above for the Location object, always returning the native built-in function cross-domain.
Clean up the code to make it clear that the custom functionality is only there for cross-domain access. (WebCore::JSLocation::put): (WebCore::JSLocation::deleteProperty): (WebCore::JSLocation::getPropertyNames):
bindings/js/JSLocation.h:
Clean up to match the rest of the file a little better.

bindings/js/kjs_binding.cpp: (WebCore::allowsAccessFromFrame): (WebCore::printErrorMessageForFrame): (WebCore::nonCachingStaticFunctionGetter): (WebCore::objectToStringFunctionGetter):
bindings/js/kjs_binding.h:
Put common functionality related to cross-domain access here to serve as a central shared point. This includes moving and augmenting the allowsAccessFromFrame method that was in both JSHistoryCustom.cpp and JSLocation.cpp.

bindings/js/kjs_dom.cpp: (WebCore::checkNodeSecurity):
Use the new allowsAccessFromFrame method.

bindings/js/kjs_window.cpp: (KJS::Window::childFrameGetter): Cleanup. (KJS::Window::namedItemGetter): Cleanup. (KJS::Window::getOwnPropertySlot):
Do the prototype lookup early to match Firefox in having function lookup have a higher precedence than the index or shortcut name getters.
Cleanup function to make it more understandable and slightly more efficient. (KJS::Window::allowsAccessFrom):
Add a new variant of this method that takes a reference to a String, which, on failure, will contain the error message to print out. The caller can then pass this to printErrorMessage. This allows for code to check allowsAccessFrom and act on the result without printing out the error message. For convenience, a version with out the String parameter has been left which prints out the message automatically. (KJS::Window::printErrorMessage):
bindings/js/kjs_window.h:

LayoutTests:

Reviewed by Darin Adler.

Tests for:
<rdar://problem/5735497> Match Firefox's cross-domain model more accurately by return the built-in version of functions even if they have been overridden
<rdar://problem/5735443> Crash when setting the Window objects prototype to a custom Object and then calling a method on it

fast/dom/Window/resources/WindowProperties.js: Added.
fast/dom/Window/window-custom-prototype-crash-expected.txt: Added.
fast/dom/Window/window-custom-prototype-crash.html: Added.
fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Added.
fast/dom/Window/window-function-frame-getter-precedence.html: Added.
fast/dom/Window/window-function-name-getter-precedence-expected.txt:
fast/dom/Window/window-function-name-getter-precedence.html:
http/tests/security/cross-frame-access-custom-expected.txt:
http/tests/security/cross-frame-access-custom.html:
http/tests/security/cross-frame-access-get-override-expected.txt: Added.
http/tests/security/cross-frame-access-get-override.html: Added.
http/tests/security/cross-frame-access-history-get-override-expected.txt:
http/tests/security/cross-frame-access-history-get-override.html:
http/tests/security/cross-frame-access-history-put-expected.txt:
http/tests/security/cross-frame-access-history-put.html:
http/tests/security/cross-frame-access-location-expected.txt: Removed.
http/tests/security/cross-frame-access-location-get-expected.txt: Added.
http/tests/security/cross-frame-access-location-get-override-expected.txt: Added.
http/tests/security/cross-frame-access-location-get-override.html: Added.
http/tests/security/cross-frame-access-location-get.html: Copied from http/tests/security/cross-frame-access-location.html.
http/tests/security/cross-frame-access-location-put-expected.txt: Added.
http/tests/security/cross-frame-access-location-put.html: Added.
http/tests/security/cross-frame-access-location.html: Removed.
http/tests/security/resources/cross-frame-iframe-for-get-override-test.html: Added.
http/tests/security/resources/cross-frame-iframe-for-get-test.html:
http/tests/security/resources/cross-frame-iframe-for-history-put-test.html:
http/tests/security/resources/cross-frame-iframe-for-location-get-override-test.html: Added.
http/tests/security/resources/cross-frame-iframe-for-location-get-test.html: Added.
http/tests/security/resources/cross-frame-iframe-for-location-put-test.html: Added.

4:16 PM Changeset in webkit [30156] by Darin Adler

8 edits in trunk

WebCore:

Reviewed by Mitz.

fix <rdar://problem/5726016> REGRESSION: Xcode News window renders incorrectly due to visibility fix

Added an Xcode-specific quirk.

WebCore.base.exp: Added export for new Settings function.
css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty): Here's the crazy quirk. If you try to change the visibilty on a node with the class name tab_content, instead it will use display:none.
page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_needsXcodeVisibilityQuirk. Also initialize m_fontRenderingMode! This seems like it was a bug before, but we probably were getting lucky and always getting 0 on Windows, which is the only place the setting matters. (WebCore::Settings::setNeedsXcodeVisibilityQuirk): Added.
page/Settings.h: (WebCore::Settings::needsXcodeVisibilityQuirk): Added.

WebKit/mac:

Reviewed by Mitz.

fix <rdar://problem/5726016> REGRESSION: Xcode News window renders incorrectly due to visibility fix

Added an Xcode-specific quirk.

Misc/WebKitVersionChecks.h: Added a constant for the "linked on or after" part of the check.

WebView/WebView.mm: (-[WebView _needsXcodeVisibilityQuirk]): Added. (-[WebView _preferencesChangedNotification:]): Added a call to setNeedsXcodeVisibilityQuirk based on _needsXcodeVisibilityQuirk.

3:38 PM Changeset in webkit [30155] by alp@webkit.org

2 edits in trunk/PlanetWebKit

2008-02-11 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>

Reviewed by Alp Toker.

Add my blog's WebKit category, English only posts.

config.ini:

2:54 PM Changeset in webkit [30154] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Brady Eidson.

<rdar://problem/5733069> Many m_quotaMap uses do not hold the m_quotaMapGuard

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::hasEntryForOrigin): Hold m_quotaMapGuard when using m_quotaMap. (WebCore::DatabaseTracker::origins): Ditto. (WebCore::DatabaseTracker::setQuota): Ditto. (WebCore::DatabaseTracker::deleteAllDatabases): Call origins() and itterate over the origins to call deleteOrigin(). (WebCore::DatabaseTracker::deleteOrigin): Hold m_quotaMapGuard when using m_quotaMap.

1:19 PM Changeset in webkit [30153] by hyatt@apple.com

2 edits
4 adds in trunk

Fix for bug 17286, crash accessing a null RenderStyle. Add a simple null check.

Reviewed by aroben

Added fast/css/empty-generated-content.html

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):

1:04 PM Changeset in webkit [30152] by rwlbuis@webkit.org

2 edits in trunk/WebCore

Reviewed by David Kilzer.

http://bugs.webkit.org/show_bug.cgi?id=17201
Bug 17201: Use RefPtr in CSSParser::parseFont() to get rid of goto silliness

Gets rid of goto usage in parseFont.

12:26 PM Changeset in webkit [30151] by hyatt@apple.com

1 edit in trunk/WebCore/html/HTMLMediaElement.cpp

Back out accidental checkin to HTMLMediaElement.cpp.

12:22 PM Changeset in webkit [30150] by hyatt@apple.com

3 adds in trunk/LayoutTests/platform/mac/fast/forms

Add layout test for bug 16798.

12:21 PM Changeset in webkit [30149] by hyatt@apple.com

1 add in trunk/LayoutTests/fast/forms/button-submit.html

Add layout test for bug 16798.

12:18 PM Changeset in webkit [30148] by hyatt@apple.com

2 adds in trunk/LayoutTests/http/tests/misc

12:17 PM Changeset in webkit [30147] by hyatt@apple.com

15 edits in trunk/WebCore

Fix for bug 17298, Acid3 text should be black and not red. Make sure stylesheets with the wrong MIME type
are not accepted in strict mode.

Reviewed by darin

Added http/tests/misc/css-reject-in-strict-mode.html

css/CSSImportRule.cpp: (WebCore::CSSImportRule::setCSSStyleSheet):
css/CSSImportRule.h:
dom/Document.cpp: (WebCore::Document::setCSSStyleSheet):
dom/Document.h:
dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::setCSSStyleSheet):
dom/ProcessingInstruction.h:
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::setCSSStyleSheet):
html/HTMLLinkElement.h:
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::pickMedia):
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::ref): (WebCore::CachedCSSStyleSheet::checkNotify): (WebCore::CachedCSSStyleSheet::canUseSheet):
loader/CachedCSSStyleSheet.h: (WebCore::CachedCSSStyleSheet::sheetText):
loader/CachedResourceClient.h: (WebCore::CachedResourceClient::setCSSStyleSheet):
loader/mac/UserStyleSheetLoader.cpp: (UserStyleSheetLoader::setCSSStyleSheet):
loader/mac/UserStyleSheetLoader.h:

11:58 AM Changeset in webkit [30146] by Adam Roben

3 edits in trunk/WebCore

Fix Bug 14316: Inspector's Console truncates long strings

<http://bugs.webkit.org/show_bug.cgi?id=14316>
<rdar://5357695>

We no longer call Object.describe to format all the output of commands
enetered into the Console. The ConsolePanel object now has a set of
formatting functions that append a formatted representation of the
passed-in object to the passed-in container node.

Reviewed by Sam.

page/inspector/ConsolePanel.js: (WebInspector.ConsolePanel._onEnterPressed): Updated for rename of _outputToNode to _format. (WebInspector.ConsolePanel._format): Renamed from _outputToNode. Use Object.type to get the type of the object, then call the appropriate formatting function. (WebInspector.ConsolePanel._formatvalue): Added. (WebInspector.ConsolePanel._formatstring): Added. This function contains the actual fix for the bug, since it doesn't truncate the string no matter how long it is. (WebInspector.ConsolePanel._formatregexp): Added. (WebInspector.ConsolePanel._formatarray): Added. This is a bit more functional than Object.describe for arrays, since it recursively formats each item in the array. One advantage of this is that Nodes in arrays will be linkified instead of just turning into "[Object HTMLBodyElement]" or similar. (WebInspector.ConsolePanel._formatnode): Added. (WebInspector.ConsolePanel._formatobject): Added. (WebInspector.ConsolePanel.
page/inspector/utilities.js: (Object.type): Added. Code was pulled out of Object.describe and reorganized slightly. (Object.describe): Call Object.type. There should be no change in behavior of this function.

10:09 AM Changeset in webkit [30145] by alp@webkit.org

2 edits in trunk/WebCore

2008-02-11 Alp Toker <alp@atoker.com>

Wx build fix for breakage introduced in r30142. Spotted by Darin.

platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl):

9:44 AM Changeset in webkit [30144] by Adam Roben

2 edits in trunk/PlanetWebKit

Add Brent Fulgham's blog

Rubberstamped by Alp.

config.ini:

9:38 AM Changeset in webkit [30143] by Darin Adler

3 edits in trunk/WebCore

Reviewed and tweaked by Darin

http://bugs.webkit.org/show_bug.cgi?id=17299 a couple compilation fixes for Cairo/Win32 configuration

platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::createDecoder): Turn off XBMImageDecoder for PLATFORM(WIN) configuration.
rendering/RenderThemeWin.cpp: (WebCore::prepareForDrawing): Added IntRect parameter. (WebCore::doneDrawing): Ditto. (WebCore::RenderThemeWin::paintButton): Ditto. (WebCore::RenderThemeWin::paintTextField): Ditto. (WebCore::RenderThemeWin::paintMenuListButton): Ditto. (WebCore::RenderThemeWin::systemFont): Added.

8:56 AM Changeset in webkit [30142] by alp@webkit.org