⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 13, 2008:

9:14 PM Changeset in webkit [30222] by justin.garcia@apple.com
  • 10 edits in trunk

WebCore:

Reviewed by Oliver Hunt.

Fixes the editing/deleting/5729680.html failure. It succeeds when run by itself
but fails when run with other tests because FramePrivate's m_selectionGranularity
isn't reset when a Frame receives a new document. It was also uninitialized in
the constructor.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Initialize m_selectionGranularity.
  • page/Frame.cpp: (WebCore::FramePrivate::FramePrivate): Ditto.

LayoutTests:

Reviewed by Oliver Hunt.

  • platform/mac/editing/deleting/table-cells-expected.checksum: Fixed. Before, a space was incorrectly removed by a delete (this isn't a smart delete).
  • platform/mac/editing/deleting/table-cells-expected.png:
  • platform/mac/editing/deleting/table-cells-expected.txt:
  • platform/mac/editing/pasteboard/input-field-1-expected.checksum: Fixed. Before a space was incorrectly added by paste (this isn't a smart paste).
  • platform/mac/editing/pasteboard/input-field-1-expected.png:
  • platform/mac/editing/pasteboard/input-field-1-expected.txt:
8:46 PM Changeset in webkit [30221] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch

Versioning.

8:45 PM Changeset in webkit [30220] by mrowe@apple.com
  • 4 edits in tags/Safari-5525.9

Versioning.

8:22 PM Changeset in webkit [30219] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.9

New tag.

6:13 PM Changeset in webkit [30218] by jhoneycutt@apple.com
  • 3 edits in trunk/WebCore

2008-02-13 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://problem/5739282> Hangs after closing video trailer popup with
VLC plugin

VLC hangs on NPP_Destroy if we call NPP_SetWindow with a null window
handle.

  • plugins/PluginQuirkSet.h: Added new quirk PluginQuirkDontSetNullWindowHandleOnDestroy. (WebCore::):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::stop): Selectively call NPP_SetWindow. (WebCore::PluginView::determineQuirks): Set new quirk for VLC plug-in.
4:15 PM Changeset in webkit [30217] by sfalken@apple.com
  • 1 edit in trunk/WebKit/win/ProgIDMacros.h

Versioning.

4:07 PM Changeset in webkit [30216] by sfalken@apple.com
  • 1 edit in trunk/WebKitLibraries/win/tools/scripts/VERSION

Versioning

3:51 PM Changeset in webkit [30215] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-13 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Alp Toker.

Fix non-SVG builds.

  • css/CSSCursorImageValue.cpp:
2:58 PM Changeset in webkit [30214] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

2:00 PM Changeset in webkit [30213] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Adam Roben.

<rdar://problem/5729680> REGRESSION (r27873): Removing the last character of a word in Mail or Safari also removes the following space


  • editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): Fixed a typo.

LayoutTests:

Reviewed by Adam Roben.


<rdar://problem/5729680> REGRESSION (r27873): Removing the last character of a word in Mail or Safari also removes the following space

  • editing/deleting/5729680-expected.txt: Added.
  • editing/deleting/5729680.html: Added.
1:56 PM Changeset in webkit [30212] by Nikolas Zimmermann
  • 37 edits in trunk/LayoutTests

Reviewed by Adam.
Make svg/dynamic-updates/* tests deterministic. s/setTimeout('executTest()', 0)/executeTest/ -- as discussed with Adam.

1:49 PM Changeset in webkit [30211] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

Reviewed by Oliver.

Actually fix the manual-tests/svg-cursor-changes.svg testcase.
I only reran layout tests when fixing the last issues with the patch,
instead of trying the manual-test :( Fixed.

1:31 PM Changeset in webkit [30210] by Adam Roben
  • 1 edit
    1 add in trunk/WebKitTools

Windows build fix

  • DumpRenderTree/ForwardingHeaders/wtf/MathExtras.h: Added.
1:19 PM Changeset in webkit [30209] by Adam Roben
  • 4 edits in trunk

Windows/GTK+ build fixes

WebCore:

Windows build fix

  • css/CSSCursorImageValue.cpp: #include MathExtras.h to get roundf.

WebKitTools:

Windows/GTK+ build fix

  • DumpRenderTree/LayoutTestController.cpp: #include MathExtras.h to get isnan.
12:41 PM Changeset in webkit [30208] by Nikolas Zimmermann
  • 12 edits
    1 add in trunk/WebCore

Reviewed by Darin & Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=17258 (SVG uses erroneous cursor implementation)

SVG cursors are not well-integrated within the CSS(3) cursor support in WebCore.
SVGCursorElement duplicates CSSCursorImageValue functionality and inherits from
CachedResourceClient itself, handling remote-image acquisation on its own.

RenderStyle's CursorData class holds "IntPoint hotSpot", "CachedImage* image"
and just for SVG a 'String cursorFragmentId' (a reference to a SVG <cursor> element, by id).

SVG stores a reference to a SVGCursorElement, which holds a CachedImage pointer itself -
instead of storing the CachedImage in the CursorData class, as it's supposed to be.
Because of that several places in WebCore contain special SVG cursor handling - which
is unneeded.

Fix all issues by integrating within CSSCursorImageValue, remove 'String cursorFragmentId'
from RenderStyle, kill any special SVG cursor handling in WebCore and fix dynamic attribute
changes through DOM / SVG DOM (scripting of 'x' / 'y' / 'xlink:href' attribute).

12:14 PM Changeset in webkit [30207] by alp@webkit.org
  • 4 edits
    1 add in trunk/WebCore

2008-02-13 Alp Toker <​alp@atoker.com>

Reviewed by Adam Roben.

Split out pure-cairo Font code to FontCairo.cpp.

Part of the ongoing work to share code with the Win port.

  • GNUmakefile.am:
  • WebCore.pro:
  • platform/graphics/cairo/FontCairo.cpp: Added. (WebCore::Font::drawGlyphs):
  • platform/graphics/gtk/FontGtk.cpp:
11:34 AM Changeset in webkit [30206] by adachan@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/5740656> Leak in postDidAddIconNotification in WebIconDatabase

Reviewed by Darin.

  • WebIconDatabase.cpp: (postDidAddIconNotification): Need to adopt the newly created instance of CFDictionaryPropertyBag, which already has a ref count of 1.
10:47 AM Changeset in webkit [30205] by beidson@apple.com
  • 11 edits
    4 adds in trunk

WebKitTools:

Reviewed by Darin Adler

Add some much needed Database support to DRT

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to databases are called (clearAllDatabasesCallback): Allow a test to delete all databases (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpDatabaseCallbacks): (LayoutTestController::setDumpDatabaseCallbacks):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::clearAllDatabases): (LayoutTestController::setDatabaseQuota):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::clearAllDatabases): Stubbed out (LayoutTestController::setDatabaseQuota): Ditto
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::clearAllDatabases): Stubbed out with error message (LayoutTestController::setDatabaseQuota): Ditto
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a message with details about the event then return a 5mb quota like before

LayoutTests:

Reviewed by Darin Adler

Added layout tests to cover
​http://trac.webkit.org/projects/webkit/changeset/29983
and
​http://trac.webkit.org/projects/webkit/changeset/30184

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • storage/quota-tracking-expected.txt: Added.
  • storage/quota-tracking.html: Added.
  • storage/success-callback-expected.txt: Added.
  • storage/success-callback.html: Added.
9:49 AM Changeset in webkit [30204] by kevino@webkit.org
  • 6 edits in trunk

Fix issues with the paint origin when using wxGCDC, with computing the font platform data hash, and Win and wxPython bindings compilation.
​http://bugs.webkit.org/show_bug.cgi?id=17321

9:48 AM Maintenance and architecture list edited by Adam Roben
Mention the clean-header-guards script (diff)
9:34 AM Maintenance and architecture list edited by Darin Adler
(diff)
9:33 AM Maintenance and architecture list edited by Darin Adler
Take out Apple-specific items. (diff)
9:29 AM Maintenance and architecture list created by Darin Adler
9:28 AM Changeset in webkit [30203] by Adam Roben
  • 7 edits in trunk

2008-02-13 Rodney Dawes <​dobey@wayofthemonkey.com>

Fix Bug 17220: Illogical dependency between PluginView and PluginDatabase

WebCore:

Fix Bug 17220: Illogical dependency between PluginView and
PluginDatabase

<​http://bugs.webkit.org/show_bug.cgi?id=17220>

Reviewed by Adam and Darin.

Rename PluginDatabase::createPluginView to PluginView::create, to make
the illogical dependency between the two, logical
Make PluginDatabase::findPlugin a public method
Update the includes in PluginView and PluginDatabase for the change

  • plugins/PluginDatabase.h:
  • plugins/PluginView.h:
  • plugins/win/PluginDatabaseWin.cpp:
  • plugins/win/PluginViewWin.cpp:

WebKit/win:

Fix Bug 17220: Illogical dependency between PluginView and
PluginDatabase

<​http://bugs.webkit.org/show_bug.cgi?id=17220>

Reviewed by Adam and Darin.

Update for the rename of PluginDatabase::createPluginView
to PluginView::create

  • WebFrame.cpp:
9:20 AM Changeset in webkit [30202] by Adam Roben
  • 6 edits in trunk

Windows build fixes

WebCore:

Build fix

  • platform/graphics/cg/GraphicsContextCG.cpp: Added missing #include.

WebKit/win:

Windows build fix

  • Interfaces/WebKit.idl: Create the typelib version symbol ourselves.

WebKitLibraries:

  • win/tools/scripts/auto-version.sh: Removed a redundant symbol.
9:20 AM WikiStart edited by Darin Adler
Adding a new page with to do items for maintenance. (diff)
8:29 AM Changeset in webkit [30201] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-02-13 Alp Toker <​alp@atoker.com>

Reviewed by Adam Roben.

Fix very small, upside down, inside out text on GTK+/DirectFB.

Based on an initial patch by Sriram Neelakandan <​sriram.neelakandan@gmail.com>

Test the result of gdk_screen_get_resolution() and use a default
fallback in case of failure.

Also remove an unhelpful runtime warning.

  • webkit/webkitwebview.cpp:
7:56 AM Changeset in webkit [30200] by Darin Adler
  • 1 edit
    2 deletes in trunk/LayoutTests
  • platform/mac/svg/hixie/perf/001-expected.txt: Removed.
  • platform/mac/svg/hixie/perf/002-expected.txt: Removed.
7:29 AM Changeset in webkit [30199] by pewtermoose@webkit.org
  • 2 edits in trunk/WebCore

Not reviewed, build fix.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::paintBuffer):
6:25 AM Changeset in webkit [30198] by Darin Adler
  • 5 edits in trunk/WebCore
  • try to fix Wx build
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::paintBuffer): Added.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::paintBuffer): Added missing paintingDisabled() check.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::paintBuffer): Ditto.
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::paintBuffer): Ditto.
5:33 AM Changeset in webkit [30197] by Darin Adler
  • 2 edits in trunk/WebCore
  • try to fix Wx build
  • platform/wx/LocalizedStringsWx.cpp: Add missing include.
5:26 AM Changeset in webkit [30196] by Darin Adler
  • 8 edits in trunk

WebCore:

  • roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders incorrectly due to visibility fix

Removed the Xcode-specific quirk at the request of some folks on the Xcode team.

  • WebCore.base.exp: Rolled out change.
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty): Ditto.
  • page/Settings.cpp: (WebCore::Settings::Settings): Ditto. But keep the initialization of m_fontRenderingMode. (WebCore::Settings::setNeedsXcodeVisibilityQuirk): Removed.
  • page/Settings.h: (WebCore::Settings::needsXcodeVisibilityQuirk): Removed.

WebKit/mac:

  • roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders incorrectly due to visibility fix

Removed the Xcode-specific quirk at the request of some folks on the Xcode team.

  • Misc/WebKitVersionChecks.h: Removed the constant.
  • WebView/WebView.mm: (-[WebView _needsXcodeVisibilityQuirk]): Removed. (-[WebView _preferencesChangedNotification:]): Removed call to setNeedsXcodeVisibilityQuirk.
4:51 AM Changeset in webkit [30195] by ap@webkit.org
  • 7 edits
    4 adds in trunk

Reviewed by Darin.

<rdar://problem/5740042> Database termination issues

Test: storage/close-during-stress-test.html

  • dom/Document.cpp: (WebCore::Document::databaseThread):
  • dom/Document.h: Don't re-create the database thread if it has been already terminated.
  • storage/Database.h: (WebCore::Database::document): Changed m_database to a RefPtr to avoid having a hanging reference.
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::requestTermination):
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::~SQLTransaction): Removed logging. Transactions are deleted during GC, so it's usually not importatnt to know when it happens.
4:33 AM Changeset in webkit [30194] by Darin Adler
  • 1 edit
    2 adds in trunk/LayoutTests
  • check in results for these tests

No idea if these are right or not; just what was generated on my computer.
If someone has a better version, feel free to replace these results with correct ones.

  • platform/mac/svg/hixie/perf/001-expected.txt: Added.
  • platform/mac/svg/hixie/perf/002-expected.txt: Added.
4:27 AM Changeset in webkit [30193] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • platform/Timer.cpp: Add include of <limits.h> since this file uses UINT_MAX.
4:10 AM Changeset in webkit [30192] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • kjs/interpreter.cpp: Add include of <unistd.h>, since that's where getpid() comes from.
1:51 AM Changeset in webkit [30191] by oliver@apple.com
  • 3 edits
    3 adds in trunk

<rdar://problem/5737003> REGRESSION (r27747): can't browse pictures on fastcupid.com

Reviewed by Alexey P.

When converting numeric values to booleans we need to account for NaN

Feb 12, 2008:

10:32 PM Changeset in webkit [30190] by timothy@apple.com
  • 1 edit in trunk/WebCore/platform/sql/SQLiteDatabase.cpp

Comment out the ASSERT to make the layout tests pass. Filed <rdar://problem/5739818> to track the issue.

10:04 PM Changeset in webkit [30189] by timothy@apple.com
  • 7 edits in trunk/WebCore

Reviewed by Brady Eidson.

<rdar://problem/5652560> Can't delete database if the website that
uses it has been opened in this session

Close the Database on the database thread before deleting the file.
Tested and works on Windows and Mac.

  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::close): Assert we are on the opening thread.
  • storage/Database.cpp: (WebCore::Database::markAsDeletedAndClose): Unschedule any pending Database tasks, and start and imediate DatabaseCloseTask. (WebCore::Database::close): Close the SQLDatabase.
  • storage/Database.h: Renamed markAsDeleted to markAsDeletedAndClose.
  • storage/DatabaseTask.cpp: (WebCore::DatabaseCloseTask::DatabaseCloseTask): New task. (WebCore::DatabaseCloseTask::doPerformTask): Call close on the Database. (WebCore::DatabaseCloseTask::debugTaskName): Return "DatabaseCloseTask".
  • storage/DatabaseTask.h: Add DatabaseCloseTask.
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::deleteDatabaseFile): Call the renamed markAsDeletedAndClose.
9:12 PM BuildingCairoOnWindows edited by bfulgham@macports.org
(diff)
8:22 PM Changeset in webkit [30188] by oliver@apple.com
  • 3 edits in trunk/WebCore

Endeavour to fix qt and gtk builds

7:07 PM Changeset in webkit [30187] by Adam Roben
  • 2 edits in trunk/WebKitLibraries

Clean up auto-version.sh a bit

It now does quite a bit less file I/O and many fewer fork/exec pairs.
It's also quite a bit easier to read.

Reviewed by Steve.

  • win/tools/scripts/auto-version.sh:
6:53 PM Changeset in webkit [30186] by sfalken@apple.com
  • 2 edits
    2 adds in trunk/WebKit/win

Use a precompiled header to build WebKit.


Reviewed by Adam.

  • WebKit.vcproj/WebKit.vcproj:
  • WebKitPrefix.cpp: Added.
  • WebKitPrefix.h: Added.
6:11 PM Changeset in webkit [30185] by oliver@apple.com
  • 6 edits in trunk/WebCore

Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp
Remove ifdef's from canvas paint code

Reviewed by Eric S.

By making GraphicsContext aware of the crossplatform ImageBuffer
type we can migrate the ifdef-ified paint code in HTMLCanvasElement
into platform implementations of GraphicsContext.

5:10 PM Changeset in webkit [30184] by beidson@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Darin Adler

Fix for <rdar://problem/5737692> - Database API needs to support SuccessCallback

Layout tests will come shortly with a mess of DRT changes

  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): Standardize on "empty string" instead of null string as different paths of constructing a SecurityOrigin were causing different hashes for the "same" SecurityOrigin
  • storage/Database.cpp: (WebCore::Database::changeVersion): Pass in the successCallback (WebCore::Database::transaction): Ditto
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::debugStepName): (WebCore::SQLTransaction::performNextStep): Update ASSERTs for the new valid steps (WebCore::SQLTransaction::performPendingCallback): Ditto (WebCore::SQLTransaction::postflightAndCommit): Schedule the success callback if it exists - otherwise skip straight to cleanupAfterSuccessCallback() (WebCore::SQLTransaction::deliverSuccessCallback): Deliver success callback on the main thread, then schedule cleanupAfterSuccessCallback() (WebCore::SQLTransaction::cleanupAfterSuccessCallback): Cleanup and end the transaction (WebCore::SQLTransaction::handleTransactionError): (WebCore::SQLTransaction::deliverTransactionErrorCallback): (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
  • storage/SQLTransaction.h:
4:18 PM Changeset in webkit [30183] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Versioning script change.

  • win/tools/scripts/auto-version.sh:
4:16 PM Changeset in webkit [30182] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Changes to support merged MIDL output.


All COM interfaces are now generated to WebKit.h.


Reviewed by Sam, Ada.

  • bindings/scripts/CodeGeneratorCOM.pm:
4:16 PM Changeset in webkit [30181] by sfalken@apple.com
  • 19 edits in trunk/WebKitTools

Changes to support merged MIDL output.

All COM interfaces are now generated to WebKit.h.

Reviewed by Sam, Ada.

  • Drosera/win/BaseDelegate.h:
  • Drosera/win/DebuggerClient.cpp:
  • Drosera/win/DebuggerDocumentPlatform.cpp:
  • Drosera/win/Drosera.cpp:
  • Drosera/win/ServerConnection.cpp:
  • Drosera/win/ServerConnection.h:
  • DumpRenderTree/win/DumpRenderTree.cpp:
  • DumpRenderTree/win/EditingDelegate.h:
  • DumpRenderTree/win/EventSender.cpp:
  • DumpRenderTree/win/FrameLoadDelegate.cpp:
  • DumpRenderTree/win/FrameLoadDelegate.h:
  • DumpRenderTree/win/GCControllerWin.cpp:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/win/PolicyDelegate.h:
  • DumpRenderTree/win/ResourceLoadDelegate.h:
  • DumpRenderTree/win/UIDelegate.cpp:
  • DumpRenderTree/win/UIDelegate.h:
  • DumpRenderTree/win/WorkQueueItemWin.cpp:
4:16 PM Changeset in webkit [30180] by sfalken@apple.com
  • 122 edits in trunk/WebKit/win

Changes to support merged MIDL output.

All COM interfaces are now generated to WebKit.h.

Reviewed by Sam, Ada.

  • DOMCSSClasses.h:
  • DOMCoreClasses.h:
  • DOMEventsClasses.h:
  • DOMHTMLClasses.h:
  • DefaultDownloadDelegate.h:
  • DefaultPolicyDelegate.cpp:
  • DefaultPolicyDelegate.h:
  • GEN_DOMObject.h:
  • Interfaces/DOMCSS.idl:
  • Interfaces/DOMCore.idl:
  • Interfaces/DOMEvents.idl:
  • Interfaces/DOMExtensions.idl:
  • Interfaces/DOMHTML.idl:
  • Interfaces/DOMPrivate.idl:
  • Interfaces/DOMRange.idl:
  • Interfaces/DOMWindow.idl:
  • Interfaces/IGEN_DOMObject.idl:
  • Interfaces/IWebArchive.idl:
  • Interfaces/IWebBackForwardList.idl:
  • Interfaces/IWebBackForwardListPrivate.idl:
  • Interfaces/IWebCache.idl:
  • Interfaces/IWebDataSource.idl:
  • Interfaces/IWebDatabaseManager.idl:
  • Interfaces/IWebDocument.idl:
  • Interfaces/IWebDownload.idl:
  • Interfaces/IWebEditingDelegate.idl:
  • Interfaces/IWebError.idl:
  • Interfaces/IWebErrorPrivate.idl:
  • Interfaces/IWebFormDelegate.idl:
  • Interfaces/IWebFrame.idl:
  • Interfaces/IWebFrameLoadDelegate.idl:
  • Interfaces/IWebFrameLoadDelegatePrivate.idl:
  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/IWebFrameView.idl:
  • Interfaces/IWebHTMLRepresentation.idl:
  • Interfaces/IWebHTTPURLResponse.idl:
  • Interfaces/IWebHistory.idl:
  • Interfaces/IWebHistoryItem.idl:
  • Interfaces/IWebHistoryItemPrivate.idl:
  • Interfaces/IWebIconDatabase.idl:
  • Interfaces/IWebInspector.idl:
  • Interfaces/IWebJavaScriptCollector.idl:
  • Interfaces/IWebKitStatistics.idl:
  • Interfaces/IWebMutableURLRequest.idl:
  • Interfaces/IWebMutableURLRequestPrivate.idl:
  • Interfaces/IWebNotification.idl:
  • Interfaces/IWebNotificationCenter.idl:
  • Interfaces/IWebNotificationObserver.idl:
  • Interfaces/IWebPolicyDelegate.idl:
  • Interfaces/IWebPreferences.idl:
  • Interfaces/IWebPreferencesPrivate.idl:
  • Interfaces/IWebResource.idl:
  • Interfaces/IWebResourceLoadDelegate.idl:
  • Interfaces/IWebResourceLoadDelegatePrivate.idl:
  • Interfaces/IWebScriptCallFrame.idl:
  • Interfaces/IWebScriptDebugListener.idl:
  • Interfaces/IWebScriptDebugServer.idl:
  • Interfaces/IWebScriptObject.idl:
  • Interfaces/IWebScriptScope.idl:
  • Interfaces/IWebScrollBarDelegatePrivate.idl:
  • Interfaces/IWebScrollBarPrivate.idl:
  • Interfaces/IWebSecurityOrigin.idl:
  • Interfaces/IWebTextRenderer.idl:
  • Interfaces/IWebUIDelegate.idl:
  • Interfaces/IWebUIDelegatePrivate.idl:
  • Interfaces/IWebURLAuthenticationChallenge.idl:
  • Interfaces/IWebURLRequest.idl:
  • Interfaces/IWebURLResponse.idl:
  • Interfaces/IWebURLResponsePrivate.idl:
  • Interfaces/IWebUndoManager.idl:
  • Interfaces/IWebUndoTarget.idl:
  • Interfaces/IWebView.idl:
  • Interfaces/IWebViewPrivate.idl:
  • Interfaces/WebKit.idl:
  • WebActionPropertyBag.cpp:
  • WebBackForwardList.h:
  • WebCache.h:
  • WebDataSource.cpp:
  • WebDataSource.h:
  • WebDatabaseManager.h:
  • WebDownload.h:
  • WebEditorClient.cpp:
  • WebEditorClient.h:
  • WebError.h:
  • WebFrame.cpp:
  • WebFrame.h:
  • WebFramePolicyListener.h:
  • WebHTMLRepresentation.cpp:
  • WebHTMLRepresentation.h:
  • WebHistory.cpp:
  • WebHistory.h:
  • WebHistoryItem.h:
  • WebIconDatabase.h:
  • WebInspector.h:
  • WebJavaScriptCollector.h:
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebKitDLL.cpp:
  • WebKitStatistics.h:
  • WebMutableURLRequest.cpp:
  • WebMutableURLRequest.h:
  • WebNotification.h:
  • WebNotificationCenter.h:
  • WebPreferences.h:
  • WebResource.h:
  • WebScriptCallFrame.h:
  • WebScriptDebugServer.cpp:
  • WebScriptDebugServer.h:
  • WebScriptDebugger.cpp:
  • WebScriptDebugger.h:
  • WebScriptObject.h:
  • WebScrollBar.h:
  • WebSecurityOrigin.h:
  • WebTextRenderer.h:
  • WebURLAuthenticationChallenge.h:
  • WebURLAuthenticationChallengeSender.h:
  • WebURLCredential.h:
  • WebURLProtectionSpace.h:
  • WebURLResponse.h:
  • WebView.cpp:
  • WebView.h:
3:54 PM Changeset in webkit [30179] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Revised the system fallback font lookup logic to use MLang font linking
again. To avoid reintroducing bug 16548 and <rdar://problem/5280188>,
for CJK characters, try linking based on a single code page at a time,
starting with the user's default code page (if it is one of the CJK
code pages) followed by the other CJK code pages in a prescribed order
that matches what Firefox does.

  • platform/graphics/win/FontCacheWin.cpp: (WebCore::getCJKCodePageMasks): Added. Returns the search order for CJK code pages, with the user's default code page first. (WebCore::currentFontContainsCharacter): Factored out of getFontDataForCharacters(). (WebCore::createMLangFont): Ditto. (WebCore::FontCache::getFontDataForCharacters):
3:34 PM Changeset in webkit [30178] by andersca@apple.com
  • 2 edits in trunk/WebKit/win

Reviewed by Adam.

Implement imageTitle.


  • WebCoreLocalizedStrings.cpp: (WebCore::imageTitle):
1:29 PM Changeset in webkit [30177] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Brady Eidson.

<rdar://problem/5659216> REGRESSION: PLT 0.3% slower due to r28868 (caching ClassNodeList and NamedNodeList)

  • Tweak the statements in isASCIISpace to account for the statistical distribution of usage in the PLT.

.4% speedup on my machine. Stephanie's machine shows this as .3% speedup.

  • wtf/ASCIICType.h: (WTF::isASCIISpace):
1:17 PM Changeset in webkit [30176] by mitz@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

Rubber-stamped by Adam Roben.

  • make fast/css/css3-nth-child pass
  • fast/css/css3-nth-child.html: Removed spaces that were making the :nth-child selector fail to parse because of <rdar://problem/5733761>.
  • platform/mac-leopard/fast/css/css3-nth-child-expected.checksum: Added.
  • platform/mac-leopard/fast/css/css3-nth-child-expected.png: Added.
1:04 PM Changeset in webkit [30175] by alp@webkit.org
  • 5 edits in trunk

2008-02-12 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Alp Toker.

Add -DMAEMO_CHANGES when the hildon CONFIG option is specified
Add hildon-1 to PKGCONFIG when hildon CONFIG option is specified

12:13 PM Changeset in webkit [30174] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Timothy Hatcher.

  • <rdar://problem/5738175> Remove workaround for <rdar://problem/5539388> from post-Tiger builds
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setShadow):
12:11 PM Changeset in webkit [30173] by beidson@apple.com
  • 2 edits in trunk/WebCore

Release build fix

  • storage/DatabaseTask.cpp:
11:37 AM Changeset in webkit [30172] by ap@webkit.org
  • 13 edits
    3 adds in trunk/WebCore

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=17177
<rdar://problem/5729619> Storage tasks are getting lost

<rdar://problem/5729445> REGRESSION: Cannot schedule more than one transaction at a time

<rdar://problem/5729446> Major thread safety issue in Database code

  • platform/MessageQueue.h: Added a thread-safe queue abstraction.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Added MessageQueue.h.
  • dom/Document.cpp: (WebCore::Document::~Document): Fixed a race condition resulting in a hanging reference.
  • storage/Database.idl: Fixed parameter declarations to actually match implementation (which is custom, so it got out of sync).
  • storage/DatabaseTask.h: (WebCore::DatabaseTask::database): (WebCore::DatabaseTransactionTask::transaction): Changed tasks to hold more information internally. Added helpers for better debug logging.
  • storage/DatabaseTask.cpp: (WebCore::DatabaseTask::DatabaseTask): (WebCore::DatabaseTask::performTask): (WebCore::DatabaseOpenTask::DatabaseOpenTask): (WebCore::DatabaseOpenTask::doPerformTask): (WebCore::DatabaseOpenTask::debugTaskName): (WebCore::DatabaseTransactionTask::DatabaseTransactionTask): (WebCore::DatabaseTransactionTask::~DatabaseTransactionTask): (WebCore::DatabaseTransactionTask::doPerformTask): (WebCore::DatabaseTransactionTask::debugTaskName): (WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask): (WebCore::DatabaseTableNamesTask::doPerformTask): (WebCore::DatabaseTableNamesTask::debugTaskName): Implementation for the above.

(WebCore::DatabaseTask::lockForSynchronousScheduling):
(WebCore::DatabaseTask::waitForSynchronousCompletion):
Fixed a potential race condition: if the task completed before we entered a wait, we'd never
wake up. There was an assertion guarding against this, but no actual guarantee that I could see.

  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::requestTermination): (WebCore::DatabaseThread::databaseThread): (WebCore::DatabaseThread::scheduleTask): (WebCore::DatabaseThread::scheduleImmediateTask): (WebCore::DatabaseThread::unscheduleDatabaseTasks):
  • storage/DatabaseThread.h: Changed to use MessageQueue.
  • storage/Database.cpp: (WebCore::guidMutex): (WebCore::guidToVersionMap): (WebCore::guidToDatabaseMap): (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::~Database): (WebCore::Database::openAndVerifyVersion): (WebCore::guidForOriginAndName): (WebCore::Database::changeVersion): (WebCore::Database::transaction): (WebCore::Database::scheduleTransaction): (WebCore::Database::scheduleTransactionStep): (WebCore::Database::scheduleTransactionCallback): (WebCore::Database::version): (WebCore::Database::deliverPendingCallback): (WebCore::Database::tableNames):
  • storage/Database.h: Changed m_transactionQueue to a MessageQueue. Got rid of callback tracking - these can take care of themselves. Got rid of a DatabaseThread member, as the Document can be asked for it. Moved private static members and helpers out of the header. Lost CurrentThreadSetter debug helper on the way. We may need to re-add something like that later.
  • storage/SQLTransaction.h:
  • storage/SQLTransaction.cpp: Added a lot of debug logging. (WebCore::SQLTransaction::scheduleToRunStatements): Removed "m_currentStatement = 0" assignment, as it created a race condition. Everything seems to work better without it, although a real fix would be to get rid of this variable - it's evil shared data that isn't even protected in any way.
  • manual-tests/database-threading-stress-test-2.html: Added.
  • manual-tests/database-threading-stress-test.html: Added.
11:29 AM Changeset in webkit [30171] by Adam Roben
  • 3 edits
    3 adds in trunk

Fix Bug 17328: REGRESSION (r30147): Inspector is unstyled on Windows

WebCore:

Fix Bug 17328: REGRESSION (r30147): Inspector is unstyled on Windows

<​http://bugs.webkit.org/show_bug.cgi?id=17328>
<rdar://5737946>

Reviewed by Mitz.

Test: fast/loader/local-css-allowed-in-strict-mode.html

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse): Add a case for .css files.

LayoutTests:

Add a test for Bug 17328: REGRESSION (r30147): Inspector is unstyled
on Windows

<​http://bugs.webkit.org/show_bug.cgi?id=17328>
<rdar://5737946>

Reviewed by Mitz.

  • fast/loader/local-css-allowed-in-strict-mode-expected.txt: Added.
  • fast/loader/local-css-allowed-in-strict-mode.html: Added.
  • fast/loader/resources/stylesheet.css: Added.
11:17 AM Changeset in webkit [30170] by andersca@apple.com
  • 2 edits in trunk/WebCore

Build fix.


  • loader/ImageDocument.cpp:
10:53 AM Changeset in webkit [30169] by andersca@apple.com
  • 1 edit in trunk/WebKit/mac/ChangeLog

Fix tyop.

10:51 AM Changeset in webkit [30168] by andersca@apple.com
  • 15 edits
    2 deletes in trunk

WebCore:

Reviewed by Mitz.

Make the code that sets the image title cross platform.

  • WebCore.xcodeproj/project.pbxproj: Remove ImageDocumentMac.


  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish):
  • loader/mac/ImageDocumentMac.h: Removed.
  • loader/mac/ImageDocumentMac.mm: Removed.


  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreViewFactory.h: Move imageTitleForFilename:size from the bridge to the view factory.


  • platform/LocalizedStrings.h: Add imageTitle.


  • platform/mac/LocalizedStringsMac.mm: (WebCore::imageTitle): Have imageTitle call the view factory.


  • platform/qt/Localizations.cpp: (WebCore::imageTitle):
  • platform/wx/LocalizedStringsWx.cpp: (WebCore::imageTitle):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::imageTitle): Add stubs.

WebKit/mac:

Reviewed by Mitz.

  • WebCoreSupport/WebFrameBridge.mm:
  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory imageTitleForFilename:size:]): Move implementatino from WebFrameBridge to WebViewFactory.

WebKit/win:

Reviewed by Mitz.

  • WebCoreLocalizedStrings.cpp: (WebCore::imageTitle): Add stub.
5:23 AM Changeset in webkit [30167] by Nikolas Zimmermann
  • 1 edit
    31 adds in trunk/LayoutTests

Not reviewed, adding missing layout test results (that have been r+ already, but not commited)

1:40 AM Changeset in webkit [30166] by oliver@apple.com
  • 2 edits in trunk/WebCore

more Qt fixes

1:30 AM Changeset in webkit [30165] by oliver@apple.com
  • 2 edits in trunk/WebCore

Yet another attempt to fix Qt

1:21 AM Changeset in webkit [30164] by oliver@apple.com
  • 2 edits in trunk/WebCore

Attempt to fix qt build

1:14 AM Changeset in webkit [30163] by oliver@apple.com
  • 4 edits in trunk/WebCore

Make canvas use an ImageBuffer for its backing store

Reviewed by Alp Toker.

In order to make the canvas implementation less platform dependent
(and thus reduce the current quagmire of ifdefs) we now use an
ImageBuffer to provide the backing buffer, an immediate consequence
of this is to remove multiple ifdefs in the construction of the
buffer. This patch allows us to further reduce the platform
dependencies in later patches.

Note: See TracTimeline for information about the timeline view.