Context Navigation

← Previous Period
Next Period →

Timeline

Feb 14, 2008:

11:23 PM Changeset in webkit [30250] by Darin Adler

3 edits in trunk/WebCore

another round of build fixes

platform/KURL.cpp: (WebCore::appendEncodedHostname): Fix spelling (strLen, not strlen).
platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl): Fix a ".." typo and call data instead of characters.

10:45 PM Changeset in webkit [30249] by Darin Adler

1 edit
3 copies in trunk/WebCore

added back accidentally-removed files

platform/DeprecatedStringList.cpp: Copied from platform/DeprecatedStringList.cpp.
platform/DeprecatedStringList.h: Copied from platform/DeprecatedStringList.h.
platform/mac/DeprecatedStringListMac.mm: Copied from platform/mac/DeprecatedStringListMac.mm.

10:38 PM Changeset in webkit [30248] by Darin Adler

4 edits
3 deletes in trunk/WebCore

more build fixes

platform/KURL.cpp: (WebCore::appendEncodedHostname): Use String to make a QString.
platform/network/cf/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Removed a stray deprecatedString() call.
platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl): Updated to String rather than DeprecatedString functions.

10:03 PM Changeset in webkit [30247] by oliver@apple.com

3 edits in trunk/LayoutTests

Make assign-to-window-status testcase to be more thorough

Reviewed by Jon H

9:36 PM Changeset in webkit [30246] by Darin Adler

2 edits in trunk/WebCore

next Qt build fix

platform/network/qt/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Removed a stray deprecatedString() call.

9:29 PM Changeset in webkit [30245] by Darin Adler

2 edits in trunk/WebCore

another build fix

platform/network/curl/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Removed a stray deprecatedString() call.

9:14 PM Changeset in webkit [30244] by Darin Adler

2 edits in trunk/WebCore

first Qt build fix

dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): Added a missing string() call.

9:03 PM Changeset in webkit [30243] by Darin Adler

177 edits in trunk

WebCore:

Reviewed by Eric Seidel.

Based on work by Marvin Decker <marv.decker@gmail.com>

fix http://bugs.webkit.org/show_bug.cgi?id=16538 KURL should use String instead of DeprecatedString

fix http://bugs.webkit.org/show_bug.cgi?id=16485 DocLoader::checkForReload will crash if the URL isNull and a similar problem in IconDatabase

fix http://bugs.webkit.org/show_bug.cgi?id=16487 KURL doesn't preserve isNull when constructed with a DeprecatedString

changed completeURL and various DOM getters to return KURL, to avoid conversion back and forth from KURL to String

changed the conversion of KURL to NSURL or NSString to be automatic, to ease the use of KURL in Objective C DOM bindings, and eliminated the getNSURL function

because I had to visit the DOM bindings anyway, eliminated almost all the use of the KJS namespace for things in WebCore

fixed HTMLOptionElement constructor to check for undefined rather than size of the arguments array

eliminated some other unnecessary uses of DeprecatedString

changed String::split to take a Vector parameter instead of returning a Vector, for better performance

added a couple of missing calls to do layout in SVG image handling; I was able to reproduce these only because I had broken URLs for a while -- not sure how to reproduce them now but the changes are clearly needed

Performance testing shows this to be at least a 1% speedup.

Added a new function protocolIs to efficiently compare protocols
without case errors and a blankURL function so we don't have to
code "about:blank" in multiple places in the code and don't have to
construct a frash KURL each time. Moved decode_string and encode_string
out of KURL and gave them clearer names.

Made KURL constructors explicit to highlight potentially-expensive
operations and the poor semantics of KURL's constructor that takes
a String.

WebCore.base.exp: Updated.

bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue): Use protocolIs.
bindings/js/JSAudioConstructor.h: KJS namespace change.
bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS): Ditto.
bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS): Ditto.
bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): Ditto. (WebCore::JSDocument::setLocation): Updated for KURL change. (WebCore::toJS): KJS namespace change.
bindings/js/JSElementCustom.cpp: (WebCore::allowSettingSrcToJavascriptURL): Use protocolIs. (WebCore::JSElement::setAttribute): KJS namespace change. (WebCore::JSElement::setAttributeNode): Ditto. (WebCore::JSElement::setAttributeNS): Ditto. (WebCore::JSElement::setAttributeNodeNS): Ditto.
bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL): Use protocolIs. (WebCore::JSHTMLFrameElement::setSrc): KJS namespace change. (WebCore::JSHTMLFrameElement::setLocation): Ditto.
bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc): Use protocolIs.
bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor): (WebCore::JSHTMLOptionElementConstructor::construct): Cleaned up the structure a bit and changed checking to check for undefined rather than number of arguments.
bindings/js/JSHTMLOptionElementConstructor.h: KJS namespace change.
bindings/js/JSLocation.cpp: (WebCore::JSLocation::put): Eliminated some DeprecatedString use, and use protocolIs. (WebCore::jsLocationProtoFuncReplace): Ditto. (WebCore::jsLocationProtoFuncReload): Ditto. (WebCore::jsLocationProtoFuncAssign): Ditto.
bindings/js/JSLocation.h: KJS namespace change.
bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::canGetItemsForName): Ditto. (WebCore::JSNamedNodeMap::nameGetter): Ditto.
bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): Ditto.
bindings/js/JSNamedNodesCollection.h: Ditto.
bindings/js/JSXMLHttpRequest.cpp: (WebCore::jsXMLHttpRequestPrototypeFunctionOpen): Removed DeprecatedString use. (WebCore::jsXMLHttpRequestPrototypeFunctionSend): Ditto.
bindings/js/JSXMLHttpRequest.h: Moved this class into the WebCore namespace.
bindings/js/JSXSLTProcessor.cpp: Namespace change.
bindings/js/JSXSLTProcessor.h: Ditto.

bindings/js/kjs_binding.cpp: Updated for namespace change. (WebCore::jsStringOrNull): Added an overload for KURL to allow DOM classes to return KURL even if the DOM expects a string. (WebCore::jsStringOrUndefined): Ditto. (WebCore::jsStringOrFalse): Ditto.
bindings/js/kjs_binding.h: Moved everything into the WebCore namespace.

bindings/js/kjs_css.h: Namespace change.
bindings/js/kjs_events.cpp: Removed an include.
bindings/js/kjs_events.h: Namespace change.
bindings/js/kjs_html.h: Namespace change.

bindings/js/kjs_navigator.cpp: Moved everything into the WebCore namespace.
bindings/js/kjs_navigator.h: Ditto.

bindings/js/kjs_window.cpp: (KJS::parseModalDialogFeatures): Updated for String::split change. (KJS::createWindow): Use protocolIs and removed some DeprecatedString. (KJS::Window::put): Ditto. (KJS::Window::allowsAccessFrom): Ditto. (KJS::windowProtoFuncOpen): Ditto.

bindings/objc/DOM.mm: (-[DOMElement _getURLAttribute:]): Removed getNSURL call.
bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): Ditto.

bindings/scripts/CodeGeneratorCOM.pm: Updated includes so conversions from KURL will work.
bindings/scripts/CodeGeneratorJS.pm: Updated for namespace changes, and also updated includes so conversions from KURL will work.
bindings/scripts/CodeGeneratorObjC.pm: Updated includes so conversions from KURL will work.

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]): Removed getNSURL call. Also streamlined the logic. (AXAttributedStringAppendText): Ditto.

bridge/mac/WebCoreScriptDebugger.mm: (toNSString): Tweaked. (toNSURL): Removed getNSURL call.

css/CSSImageValue.cpp: (WebCore::CSSImageValue::image): Removed DeprecatedString use.
css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent): Ditto.
css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Ditto. (WebCore::CSSParser::parseContent): Ditto. (WebCore::CSSParser::parseBackgroundImage): Ditto. (WebCore::CSSParser::parseFontFaceSrc): Ditto. (WebCore::CSSParser::parseBorderImage): Ditto.
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::setEncodedURL): Ditto. (WebCore::checkPseudoState): Ditto.
css/CSSStyleSelector.h: Ditto.

css/MediaList.cpp: (WebCore::MediaList::setMediaText): Updated for String::split change.

css/StyleBase.cpp: (WebCore::StyleBase::baseURL): Return KURL.
css/StyleBase.h: DItto.

dom/Document.cpp: (WebCore::Document::~Document): Updated for namespace change. (WebCore::Document::documentURI): Return KURL. (WebCore::Document::setDocumentURI): Removed DeprecatedString use. (WebCore::Document::baseURI): Return KURL. (WebCore::Document::open): Updated to use blankURL. (WebCore::Document::setURL): Take KURL. (WebCore::Document::shouldBeAllowedToLoadLocalResources): Updated for change to use KURL (WebCore::Document::setBaseURL): Take KURL. (WebCore::Document::elementSheet): Updated for KURL change. (WebCore::Document::mappedElementSheet): Ditto. (WebCore::Document::processHttpEquiv): Ditto. (WebCore::Document::recalcStyleSelector): Removed use of DeprecatedString -- also noticed some dead code here! (WebCore::Document::setCookie): Ditto. (WebCore::Document::completeURL): Return KURL.
dom/Document.h: Use KURL instead of String in a few places.

dom/DocumentType.cpp: (WebCore::DocumentType::baseURI): Return KURL.
dom/DocumentType.h: Ditto.

dom/Element.cpp: (WebCore::Element::baseURI): Return KURL.
dom/Element.h: Ditto.

dom/Node.cpp: (WebCore::Node::setDocument): Namespace change. (WebCore::Node::baseURI): Return KURL.
dom/Node.h: Ditto.

dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): Updated for KURL change.
dom/StyleElement.cpp: (WebCore::StyleElement::process): Changed to use Vector<UChar> instead of String for better performance. (WebCore::StyleElement::createSheet): Removed use of DeprecateString.
dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): Updated for KURL change. (WebCore::XMLTokenizer::end): Ditto. (WebCore::xmlDocPtrForString): Removed use of DeprecateString.
dom/XMLTokenizer.h: Ditto.

editing/markup.cpp: Moved appendString to PlatformString.h. (WebCore::appendQuotedURLAttributeValue): Use protocolIs. (WebCore::completeURLs): Removed DeprecatedString use. (WebCore::createFragmentFromMarkup): Use blankURL. (WebCore::fillContainerFromString): Removed DeprecatedString use. (WebCore::createFragmentFromText): Ditto.

history/HistoryItem.cpp: (WebCore::HistoryItem::url): Removed DeprecatedString use. (WebCore::HistoryItem::originalURL): Ditto.
history/HistoryItem.h: Removed include.

html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Removed use of DeprecatedString. (WebCore::HTMLAnchorElement::href): Return KURL. (WebCore::HTMLAnchorElement::hash): Removed DeprecatedString use. (WebCore::HTMLAnchorElement::host): Ditto. (WebCore::HTMLAnchorElement::hostname): Ditto. (WebCore::HTMLAnchorElement::pathname): Ditto. (WebCore::HTMLAnchorElement::port): Ditto. (WebCore::HTMLAnchorElement::protocol): Ditto. (WebCore::HTMLAnchorElement::search): Ditto. (WebCore::HTMLAnchorElement::toString): Ditto.
html/HTMLAnchorElement.h: Ditto.
html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer): Updated for KURL change.
html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::href): Return KURL.
html/HTMLAreaElement.h: Ditto.
html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::removedFromDocument): Updated for KURL change. (WebCore::HTMLBaseElement::process): Removed DeprecatedString use.
html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): Updated for KURL change.
html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute): Removed use of DeprecatedString.
html/HTMLEmbedElement.h: Removed DeprecatedString use.
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formWouldHaveSecureSubmission): Use protocolIs. (WebCore::encodeCString): Updated for change to String::split. (WebCore::HTMLFormElement::dataEncoding): Ditto. (WebCore::HTMLFormElement::formData): Removed DeprecatedString use. (WebCore::HTMLFormElement::isMailtoForm): Use protocolIs. (WebCore::HTMLFormElement::submit): Updated for KURL change. (WebCore::HTMLFormElement::reset): Ditto.
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed): Updated for KURL change and use equalIgnoringRef instead of doing a setRef to get the same effect. (WebCore::HTMLFrameElementBase::openURL): Use blankURL. (WebCore::HTMLFrameElementBase::location): Return KURL. (WebCore::HTMLFrameElementBase::src): Return KURL.
html/HTMLFrameElementBase.h: Ditto.
html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Updated for KURL change. (WebCore::HTMLImageElement::longDesc): Return KURL. (WebCore::HTMLImageElement::lowsrc): Return KURL. (WebCore::HTMLImageElement::src): Return KURL.
html/HTMLImageElement.h: Ditto. Also removed imageMap() function.
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::src): Return KURL.
html/HTMLInputElement.h: Ditto.
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute): Updated for KURL change. (WebCore::HTMLLinkElement::tokenizeRelAttribute): Updated for String::split change. (WebCore::HTMLLinkElement::href): Return KURL.
html/HTMLLinkElement.h: Ditto.
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::src): Return KURL. (WebCore::HTMLMediaElement::pickMedia): Updated for KURL change.
html/HTMLMediaElement.h: Ditto.
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isImageType): Use protocolIs. (WebCore::HTMLObjectElement::data): Return KURL.
html/HTMLObjectElement.h: Ditto.
html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::groupLabelText): Removed DeprecatedString use.
html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole): Updated for KURL change.
html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::insertedIntoDocument): Ditto. (WebCore::HTMLScriptElement::text): Changed to use Vector<UChar> instead of String for better performance. (WebCore::HTMLScriptElement::src): Return KURL.
html/HTMLScriptElement.h: Ditto.
html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::src): Return KURL.
html/HTMLSourceElement.h: Ditto.
html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute): Updated for KURL change.
html/HTMLTablePartElement.cpp: (WebCore::HTMLTablePartElement::parseMappedAttribute): Updated for KURL change.
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): Removed DeprecatedString use.
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution): Ditto. (WebCore::HTMLTokenizer::notifyFinished): Use protocolIs.
html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::poster): Return KURL.
html/HTMLVideoElement.h: Ditto.
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addText): Updated for String::split change.

loader/DocLoader.cpp: (WebCore::DocLoader::checkForReload): Add an explicit check for an empty URL here to avoid problems using its string as a hash table key later. (WebCore::DocLoader::requestResource): Removed DeprecatedString use.

loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::createTDForFilename): Updated for KURL change. (WebCore::FTPDirectoryTokenizer::parseAndAppendOneLine): Removed use of DeprecatedString.

loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Use protocolIs. (WebCore::FrameLoader::loadSubframe): Use blankURL. (WebCore::FrameLoader::submitForm): Use protocolIs and removed use of DeprecatedString. (WebCore::FrameLoader::iconURL): Return KURL. Use protcolIs. (WebCore::FrameLoader::didOpenURL): Use protocolIs. (WebCore::FrameLoader::didExplicitOpen): Use blankURL. (WebCore::FrameLoader::executeIfJavaScriptURL): Use protocolIs. Update for name change to decodeURLEscapeSequences. (WebCore::FrameLoader::receivedFirstData): Updated for KURL changes. (WebCore::FrameLoader::begin): Removed DeprecatedString use. Renamed baseurl to baseURL. Updated to use KURL more. (WebCore::FrameLoader::gotoAnchor): Removed use of encodedHtmlRef function, which is no different from ref. (WebCore::FrameLoader::completeURL): Updated for KURL change. (WebCore::FrameLoader::scheduleLocationChange): Ditto. (WebCore::FrameLoader::canCachePage): Use protocolIs. (WebCore::FrameLoader::updatePolicyBaseURL): Update for KURL change. (WebCore::FrameLoader::setPolicyBaseURL): Take KURL. (WebCore::FrameLoader::startRedirectionTimer): Removed use of DeprecatedString. (WebCore::FrameLoader::load): Use protocolIs. (WebCore::FrameLoader::shouldHideReferrer): Use protocolIs. (WebCore::FrameLoader::shouldAllowNavigation): Updated for KURL change. (WebCore::FrameLoader::commitProvisionalLoad): Use blankURL. (WebCore::FrameLoader::open): Use protcolIs. (WebCore::FrameLoader::createHistoryItem): Use blankURL. (WebCore::FrameLoader::createJavaAppletWidget): Updated for KURL change. (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady): Removed DeprecatedString use.
loader/FrameLoader.h: Ditto.

loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure): Updated for KURL change.
loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): Ditto.

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::iconForPageURL): Added a check for an empty URL before trying to use it as a hash table key.

loader/icon/IconLoader.h: Tweaked includes.

loader/loader.cpp: (WebCore::Loader::servePendingRequests): Use protcolIs. Also removed some code to set up a local variable that is never used (and a DeprecatedString on to boot!).

loader/mac/LoaderNSURLExtras.m: (suggestedFilenameWithMIMEType): Removed unnecessary typecast.

page/ContextMenuController.cpp: Removed include.

page/mac/EventHandlerMac.mm: (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks): Use protocolIs.

page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge URLWithAttributeString:]): Removed getNSURL call. (-[WebCoreFrameBridge baseURL]): Ditto.

platform/KURL.cpp: (WebCore::isSchemeFirstChar): Fixed bug in handling of values >= 0x80. (WebCore::isSchemeChar): Ditto. (WebCore::isPathSegmentEndChar): Ditto. (WebCore::hexDigitValue): Changed parameter type to UChar. (WebCore::copyASCII): Added. (WebCore::findFirstOf): Added. (WebCore::KURL::protocolIs): Added. (WebCore::KURL::KURL): Tightened logic up quite a bit. Changed parameter types from DeprecatedString to String. (WebCore::KURL::init): Changed parameter type to String. Preserved the passed-in string even if the base is invalid. Cleaned up logic to determine if the originalString should be pased in to the parse function. Simplified by calling the new parse overload that takes String in many cases. (WebCore::KURL::lastPathComponent): Return String. (WebCore::KURL::protocol): Ditto. (WebCore::KURL::host): Ditto. (WebCore::KURL::port): Changed logic to use early return for clarity. (WebCore::KURL::pass): Return String. (WebCore::KURL::user): Ditto. (WebCore::KURL::ref): Ditto. (WebCore::assertProtocolIsGood): Added. (WebCore::KURL::protocolIs): Added. (WebCore::KURL::query): Return String. (WebCore::KURL::path): Ditto. (WebCore::KURL::setProtocol): Take String. (WebCore::KURL::setHost): Ditto. (WebCore::KURL::setPort): Use String. (WebCore::KURL::setHostAndPort): Take String. (WebCore::KURL::setUser): Ditto. (WebCore::KURL::setPass): Ditto. (WebCore::KURL::setRef): Ditto. (WebCore::KURL::setQuery): Ditto. (WebCore::KURL::setPath): Ditto. (WebCore::KURL::prettyURL): Return String. Use Vector<UChar> to build it. (WebCore::decodeURLEscapeSequences): Renamed from KURL::decode_string. Return String. Use Vector<UChar> to build it. (WebCore::KURL::isLocalFile): Use protocolIs. (WebCore::KURL::parse): Added an overload that takes a String to replace the use of DeprecatedString::ascii at various call sites. Updated for name change (urlString -> m_string). (WebCore::equalIgnoringRef): Wrote a new implementation that doesn't do any allocation. (WebCore::encodeWithURLEscapeSequences): Renamed from KURL::encode_string. Return String. (WebCore::appendEncodedHostname): Added. Replaces encodeHostname and avoids the need to allocate a string. (WebCore::findHostnamesInMailToURL): Update to use findFirstOf instead of regular expressions. (WebCore::findHostnameInHierarchicalURL): Ditto. (WebCore::encodeHostnames): Use protocolIs and the other helpers above. (WebCore::encodeRelativeString): Changed to put result into a CharBuffer. (WebCore::substituteBackslashes): Updated to use String. (WebCore::KURL::copyToBuffer): Added. (WebCore::protocolIs): Added. (WebCore::blankURL): Added. (WebCore::KURL::print): Updated.
platform/KURL.h: Added a number of comments. Reorganized the header a bit. Made the string constructors explicit. Changed to use String instead of DeprecatedString. Removed encodedHTMLRef. Renamed and added a few functions.

platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL): Streamlined the logic a bit. (WebCore::KURL::createCFURL): Changed to use copyToBuffer.

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): Removed getNSURL call. Use protocolIs.
platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::declareAndWriteDragImage): Removed getNSURL call.
platform/mac/CookieJar.mm: (WebCore::cookies): Removed getNSURL call. (WebCore::setCookies): Removed getNSURL call.
platform/mac/KURLMac.mm: (WebCore::KURL::KURL): Streamlined the logic a bit.
platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeURL): Removed getNSURL call. (WebCore::Pasteboard::writeImage): Ditto.
platform/mac/SSLKeyGeneratorMac.mm: (WebCore::signedPublicKeyAndChallengeString): Ditto.

platform/network/HTTPParsers.cpp: (WebCore::filenameFromHTTPContentDisposition): Updated for String::split.
platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::portAllowed): Use protocolIs.

platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::operator CFErrorRef): Removed deprecatedString call.
platform/network/curl/ResourceHandleManager.cpp: (WebCore::headerCallback): Ditto. (WebCore::parseDataUrl): Use String instead of DeprecatedString. (WebCore::ResourceHandleManager::startJob): Updated for KURL changes.
platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::operator NSError*): Removed getNSURL call.
platform/network/mac/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Removed DeprecatedString use.
platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Removed getNSURL call.
platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::nsURLResponse): Removed getNSURL call.

platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writeURL): Removed deprecatedString call.

platform/text/CString.h: (WebCore::CStringBuffer::length): Fixed size_t/unsigned mismatch to make it possible to compile this on Windows with higher warning level

platform/text/PlatformString.h: Updated split to modify a result parameter rather than returning a Vector. Added charactersAreAllASCII and an append function that appends a String to a Vector<UChar>.
platform/text/String.cpp: (WebCore::String::split): Updated.

platform/win/BString.cpp: (WebCore::BString::BString): Added conversion from KURL.
platform/win/BString.h: Ditto.

platform/win/ClipboardUtilitiesWin.cpp: (WebCore::markupToCF_HTML): Removed use of deprecatedString.
platform/win/ClipboardWin.cpp: (WebCore::filesystemPathFromUrlOrTitle): Ditto. (WebCore::createGlobalHDropContent): Ditto. (WebCore::ClipboardWin::setData): Ditto. (WebCore::ClipboardWin::writeRange): Ditto.
platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): Ditto.
plugins/PluginStream.cpp: (WebCore::PluginStream::startStream): Ditto. (WebCore::PluginStream::destroyStream): Ditto.
plugins/win/PluginViewWin.cpp: (WebCore::scriptStringIfJavaScriptURL): Ditto. (WebCore::PluginView::performRequest): Ditto. (WebCore::PluginView::PluginView): Ditto.

rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): Removed DeprecatedString use. (WebCore::HitTestResult::absoluteLinkURL): Ditto.

rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layOutAxis): Fixed comment wording.
rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced): Removed use of DeperecatedString, (WebCore::RenderImage::imageMap): Changed to call useMap instead of imageMap; both do the same thing, and the first is standard DOM.

rendering/RenderObject.cpp: (WebCore::RenderObject::addPDFURLRect): Rewrote and streamlined to remove DeprecatedString use.
rendering/RenderObject.h: Changed addPDFURLRect to take const IntRect&.

rendering/RenderPartObject.cpp: (WebCore::isURLAllowed): Updated for KURL change and use equalIgnoringRef instead of doing a setRef to get the same effect. (WebCore::RenderPartObject::updateWidget): Updated for KURL change.

rendering/RenderText.cpp: (WebCore::charactersAreAllASCII): Moved the guts to PlatformString.h.

rendering/SVGRenderSupport.cpp: (WebCore::renderSubtreeToImage): Added missing call to do layout. I ran into this while doing some layout tests while URL processing was broken.

rendering/SVGRenderTreeAsText.h: Removed include.

svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::updateFromElement): Removed DeprecatedString use.

svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw): Added missing call to do layout. I ran into this while doing some layout tests while URL processing was broken. (WebCore::SVGImage::dataChanged): Use a null URL rather than an arbitrary string for the document.

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Removed DeprecatedString use. (WebCore::XMLHttpRequest::urlMatchesDocumentDomain): Ditto. (WebCore::XMLHttpRequest::open): Ditto. (WebCore::XMLHttpRequest::send): Namespace change. (WebCore::XMLHttpRequest::dropProtection): Ditto.
xml/XMLHttpRequest.h: Removed DeprecatedString use.

xml/XSLImportRule.cpp: (WebCore::XSLImportRule::loadSheet): Removed DeprecatedString use.
xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::loadChildSheets): Ditto. (WebCore::XSLStyleSheet::loadChildSheet): Ditto.
xml/XSLStyleSheet.h: Ditto.
xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc): Ditto. (WebCore::xsltStylesheetPointer): Ditto. (WebCore::xmlDocPtrFromNode): Ditto.

WebKit/gtk:

webkit/webkitwebframe.cpp: Removed DeprecatedString use to try to keep it building.
webkit/webkitwebview.cpp: Ditto.

WebKit/mac:

Reviewed by Eric Seidel.

updated for WebCore KURL changes

History/WebHistoryItem.mm: (-[WebHistoryItem URL]): Removed getNSURL call.
Misc/WebElementDictionary.mm: (-[WebElementDictionary _absoluteImageURL]): Ditto. (-[WebElementDictionary _absoluteLinkURL]): Ditto.
Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement): Ditto. (+[NSAttributedString _web_attributedStringFromRange:]): Ditto.
Misc/WebNSURLExtras.mm: (-[NSString _webkit_stringByReplacingValidPercentEscapes]): Updated for function name change.
WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::downloadURL): Removed getNSURL call.
WebCoreSupport/WebDragClient.mm: (WebDragClient::createDragImageForLink): Ditto.
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Ditto. (WebFrameLoaderClient::startDownload): Ditto. (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): Ditto. (WebFrameLoaderClient::updateGlobalHistoryForReload): Ditto. (WebFrameLoaderClient::cancelledError): Ditto. (WebFrameLoaderClient::blockedError): Ditto. (WebFrameLoaderClient::cannotShowURLError): Ditto. (WebFrameLoaderClient::interruptForPolicyChangeError): Ditto. (WebFrameLoaderClient::cannotShowMIMETypeError): Ditto. (WebFrameLoaderClient::fileDoesNotExistError): Ditto. (WebFrameLoaderClient::willUseArchive): Ditto. (WebFrameLoaderClient::setTitle): Ditto. (WebFrameLoaderClient::actionDictionary): Ditto. (WebFrameLoaderClient::createFrame): Ditto. (WebFrameLoaderClient::objectContentType): Ditto. (WebFrameLoaderClient::createPlugin): Ditto. (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
WebView/WebDataSource.mm: (-[WebDataSource _URL]): Ditto. (-[WebDataSource _initWithDocumentLoader:]): Ditto. (-[WebDataSource unreachableURL]): Ditto.
WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.

WebKit/win:

updated for WebCore KURL changes

MarshallingHelpers.cpp: (MarshallingHelpers::BSTRToKURL): Removed deprecatedString call. (MarshallingHelpers::KURLToBSTR): Tweaked for efficiency.
WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle): Updated for KURL changes.
WebDataSource.cpp: (WebDataSource::unreachableURL): Ditto.
WebDownload.cpp: (WebDownload::init): Ditto. (WebDownload::initWithRequest): Ditto.
WebFrame.cpp: (WebFrame::loadData): Ditto. (WebFrame::loadURLIntoChild): Ditto. (WebFrame::objectContentType): Ditto.
WebResource.cpp: (WebResource::initWithData): Ditto.
WebURLResponse.cpp: (WebURLResponse::createInstance): Ditto. (WebURLResponse::initWithURL): Ditto.
WebView.cpp: (WebView::userAgentForURL): Ditto. (WebView::copyURL): Ditto. (WebView::notifyPreferencesChanged): Ditto.

WebKit/wx:

WebView.cpp: Removed use of DeprecatedString to keep this compiling.

8:32 PM Changeset in webkit [30242] by Darin Adler

2 edits in trunk/WebKitTools

fix Windows build

DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::setStatusText): Update parameter types to match declaration.

8:30 PM Changeset in webkit [30241] by Darin Adler

3 edits in trunk/LayoutTests

update this test further, so that it succeeds

fast/dom/assign-to-window-status-expected.txt: Updated.
fast/dom/assign-to-window-status.html: Updated.

6:17 PM Changeset in webkit [30240] by adachan@apple.com

2 edits in trunk/WebCore

<rdar://problem/5744728> Fix leaks of RegularExpression objects in Frame.cpp.

Reviewed by Jon and Darin.

page/Frame.cpp: (WebCore::createRegExpForLabels): (WebCore::Frame::searchForLabelsBeforeElement): (WebCore::Frame::matchLabelsAgainstElement):

6:03 PM Changeset in webkit [30239] by Stephanie Lewis

6 edits in trunk

2008-02-14 Stephanie Lewis <Stephanie Lewis>

Reviewed by Geoff.

Update order files.

WebKit.order:
WebCore.order:
JavaScriptCore.order:

6:00 PM Changeset in webkit [30238] by oliver@apple.com

14 edits
2 adds in trunk

<rdar://problem/5726608> REGRESSION (r29428): Assigning to window.status does not update status bar

Reviewed by Geoff G and Weinig.

Revert the portions of r29428 responsible for breaking the ability to
set window.status

5:35 PM Changeset in webkit [30237] by andersca@apple.com

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5721790>
Crash in WebCore::DeprecatedString::operator= + 31 at news.google.com

Use pointers in the cache map tables. Otherwise when we rehash,
we will end up destroying Cache objects that node lists might point to.

dom/Node.cpp: (WebCore::NodeListsNodeData::~NodeListsNodeData): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):

4:30 PM Changeset in webkit [30236] by alp@webkit.org

2 edits in trunk/WebCore

2008-02-14 Alp Toker <alp@atoker.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=17353
XMLTokenizer installs global libxml2 callbacks that can break client applications

Patch by Mark Rowe (with a few changes).

The xmlRegisterInputCallbacks/xmlRegisterOutputCallbacks done at
init are global so we need to make sure these callbacks only get used
by XMLTokenizer and never by libxml2 calls in user applications.

This patch modifies the match and open functions to only apply when we
are certain the caller is XMLTokenizer by checking globalDocLoader and
ensuring we're on the correct thread.

Some possible issues remain. See the bug report for details.

dom/XMLTokenizer.cpp: (WebCore::matchFunc): (WebCore::openFunc): (WebCore::createStringParser):

3:29 PM Changeset in webkit [30235] by ggaren@apple.com

3 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Sam Weinig.

Fixed <rdar://problem/5737835> nee http://bugs.webkit.org/show_bug.cgi?id=17329
Crash in JSGlobalObject::popActivation when inserting hyperlink in Wordpress (17329)

Don't reset the "activations" stack in JSGlobalObject::reset, since we
might be executing a script during the call to reset, and the script
needs to safely run to completion.

Instead, initialize the "activations" stack when the global object is
created, and subsequently rely on pushing and popping during normal
execution to maintain the stack's state.

kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init): (KJS::JSGlobalObject::reset):

LayoutTests:

Reviewed by Sam Weinig.

Layout test for <rdar://problem/5737835> nee http://bugs.webkit.org/show_bug.cgi?id=17329
Crash in JSGlobalObject::popActivation when inserting hyperlink in Wordpress (17329)

fast/dom/javascript-url-crash-function.html: Added.
fast/dom/javascript-url-crash-function-expected.txt: Added.
fast/dom/resources/javascript-url-crash-function-iframe.html: Added.

2:27 PM Changeset in webkit [30234] by mitz@apple.com

8 edits in branches/Safari-3-1-branch

WebCore:

Reviewed by Adele Peterson.

roll out changes to CSS2 system colors from r28775

css/CSSStyleSelector.cpp: (WebCore::): (WebCore::colorForCSSValue):
rendering/RenderTheme.cpp:
rendering/RenderTheme.h:
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:

LayoutTests:

Reviewed by Adele Peterson.

updated results after reverting CSS2 system colors changes from r28775

platform/mac/tables/mozilla/bugs/bug103533-expected.txt:

1:00 PM Changeset in webkit [30233] by timothy@apple.com

2 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5743768> A deadlock during storage layout tests

Make sure not to hold the m_openDatabaseMapGuard mutex when calling
Database::markAsDeletedAndClose(), since that can cause a deadlock
during the synchronous DatabaseThread call it triggers.

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::deleteDatabaseFile):

11:45 AM Changeset in webkit [30232] by Nikolas Zimmermann

1 edit
40 adds in trunk/LayoutTests

Reviewed by Oliver.
Add dynamic update tests for SVGEllipseElement.

8:34 AM Changeset in webkit [30231] by Adam Roben

2 edits in trunk/WebCore

Improve the efficiency of SecurityOriginHash

Reviewed by Alexey.

platform/SecurityOriginHash.h: (WebCore::SecurityOriginHash::hash): Now takes a const RefPtr<SecurityOrigin>& to reduce ref-count churn. (WebCore::SecurityOriginHash::equal): Ditto.

7:41 AM Changeset in webkit [30230] by ap@webkit.org

2 edits in trunk/WebKit/win

WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Forgot to re-apply review comments to the previous check-in, fixing.

7:36 AM Changeset in webkit [30229] by ap@webkit.org

4 edits in trunk/WebKit

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=17207
Database example doesn't work (requires not-yet-released Safari)

mac/WebCoreSupport/WebChromeClient.mm: (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage if it's too old.

win/WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage if it's too old.

4:37 AM Changeset in webkit [30228] by zecke@webkit.org

1 edit in trunk/WebKit/gtk/ChangeLog

Correct the e-mail address in the ChangeLog.

4:27 AM Changeset in webkit [30227] by zecke@webkit.org

2 edits in trunk/WebKit/gtk

Make the handling of the coreFrame consistent. We construct the coreFrame at the beginning and it will live until the end. Change the g_return_(val_)if to ASSERTs as having a 0 coreFrame can never happen.

4:26 AM Changeset in webkit [30226] by zecke@webkit.org

6 edits in trunk/WebKit/gtk

Make sure that the WebCore::Frame is living as long as the WebKitWebFrame wrapped around it. All current calls to WebCore::Frame from within the WebKitWebFrame are safe, even in the case where the WebCore::Frame is already detached from the WebCore::Page.
For the mainFrame the WebKitWebView is holding the initial reference and will unref on destruction.
For sub-frames the FramerLoaderClientGtk.cpp will do the unrefing when the frame gets detached from the parent.
Make sure FrameLoader::detachFromParent gets called by calling FrameLoader::detachChildren

4:25 AM Changeset in webkit [30225] by zecke@webkit.org

2 edits in trunk/WebKit/gtk

WebCore::Frame is RefCounted, do not manually delete it!

4:25 AM Changeset in webkit [30224] by zecke@webkit.org

2 edits in trunk/WebKit/gtk

Plug a leak

4:24 AM Changeset in webkit [30223] by zecke@webkit.org

4 edits in trunk/WebKit/gtk

Update the Copyright Information

Feb 13, 2008:

9:14 PM Changeset in webkit [30222] by justin.garcia@apple.com

10 edits in trunk

WebCore:

Reviewed by Oliver Hunt.

Fixes the editing/deleting/5729680.html failure. It succeeds when run by itself
but fails when run with other tests because FramePrivate's m_selectionGranularity
isn't reset when a Frame receives a new document. It was also uninitialized in
the constructor.

loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Initialize m_selectionGranularity.
page/Frame.cpp: (WebCore::FramePrivate::FramePrivate): Ditto.

LayoutTests:

Reviewed by Oliver Hunt.

platform/mac/editing/deleting/table-cells-expected.checksum: Fixed. Before, a space was incorrectly removed by a delete (this isn't a smart delete).
platform/mac/editing/deleting/table-cells-expected.png:
platform/mac/editing/deleting/table-cells-expected.txt:
platform/mac/editing/pasteboard/input-field-1-expected.checksum: Fixed. Before a space was incorrectly added by paste (this isn't a smart paste).
platform/mac/editing/pasteboard/input-field-1-expected.png:
platform/mac/editing/pasteboard/input-field-1-expected.txt:

8:46 PM Changeset in webkit [30221] by mrowe@apple.com

4 edits in branches/Safari-3-1-branch

Versioning.

8:45 PM Changeset in webkit [30220] by mrowe@apple.com

4 edits in tags/Safari-5525.9

Versioning.

8:22 PM Changeset in webkit [30219] by mrowe@apple.com

1 copy in tags/Safari-5525.9

New tag.

6:13 PM Changeset in webkit [30218] by jhoneycutt@apple.com

3 edits in trunk/WebCore

2008-02-13 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://problem/5739282> Hangs after closing video trailer popup with
VLC plugin

VLC hangs on NPP_Destroy if we call NPP_SetWindow with a null window
handle.

plugins/PluginQuirkSet.h: Added new quirk PluginQuirkDontSetNullWindowHandleOnDestroy. (WebCore::):
plugins/win/PluginViewWin.cpp: (WebCore::PluginView::stop): Selectively call NPP_SetWindow. (WebCore::PluginView::determineQuirks): Set new quirk for VLC plug-in.

4:15 PM Changeset in webkit [30217] by sfalken@apple.com

1 edit in trunk/WebKit/win/ProgIDMacros.h

Versioning.

4:07 PM Changeset in webkit [30216] by sfalken@apple.com

1 edit in trunk/WebKitLibraries/win/tools/scripts/VERSION

Versioning

3:51 PM Changeset in webkit [30215] by alp@webkit.org

2 edits in trunk/WebCore

2008-02-13 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed by Alp Toker.

Fix non-SVG builds.

css/CSSCursorImageValue.cpp:

2:58 PM Changeset in webkit [30214] by mrowe@apple.com

4 edits in trunk

Versioning.

2:00 PM Changeset in webkit [30213] by justin.garcia@apple.com

3 edits
2 adds in trunk

WebCore:

Reviewed by Adam Roben.

<rdar://problem/5729680> REGRESSION (r27873): Removing the last character of a word in Mail or Safari also removes the following space

editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): Fixed a typo.

LayoutTests:

Reviewed by Adam Roben.

<rdar://problem/5729680> REGRESSION (r27873): Removing the last character of a word in Mail or Safari also removes the following space

editing/deleting/5729680-expected.txt: Added.
editing/deleting/5729680.html: Added.

1:56 PM Changeset in webkit [30212] by Nikolas Zimmermann

37 edits in trunk/LayoutTests

Reviewed by Adam.
Make svg/dynamic-updates/* tests deterministic. s/setTimeout('executTest()', 0)/executeTest/ -- as discussed with Adam.

1:49 PM Changeset in webkit [30211] by Nikolas Zimmermann

3 edits in trunk/WebCore

Reviewed by Oliver.

Actually fix the manual-tests/svg-cursor-changes.svg testcase.
I only reran layout tests when fixing the last issues with the patch,
instead of trying the manual-test :( Fixed.

1:31 PM Changeset in webkit [30210] by Adam Roben

1 edit
1 add in trunk/WebKitTools

Windows build fix

DumpRenderTree/ForwardingHeaders/wtf/MathExtras.h: Added.

1:19 PM Changeset in webkit [30209] by Adam Roben

4 edits in trunk

Windows/GTK+ build fixes

WebCore:

Windows build fix

css/CSSCursorImageValue.cpp: #include MathExtras.h to get roundf.

WebKitTools:

Windows/GTK+ build fix

DumpRenderTree/LayoutTestController.cpp: #include MathExtras.h to get isnan.

12:41 PM Changeset in webkit [30208] by Nikolas Zimmermann

12 edits
1 add in trunk/WebCore

Reviewed by Darin & Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=17258 (SVG uses erroneous cursor implementation)

SVG cursors are not well-integrated within the CSS(3) cursor support in WebCore.
SVGCursorElement duplicates CSSCursorImageValue functionality and inherits from
CachedResourceClient itself, handling remote-image acquisation on its own.

RenderStyle's CursorData class holds "IntPoint hotSpot", "CachedImage* image"
and just for SVG a 'String cursorFragmentId' (a reference to a SVG <cursor> element, by id).

SVG stores a reference to a SVGCursorElement, which holds a CachedImage pointer itself -
instead of storing the CachedImage in the CursorData class, as it's supposed to be.
Because of that several places in WebCore contain special SVG cursor handling - which
is unneeded.

Fix all issues by integrating within CSSCursorImageValue, remove 'String cursorFragmentId'
from RenderStyle, kill any special SVG cursor handling in WebCore and fix dynamic attribute
changes through DOM / SVG DOM (scripting of 'x' / 'y' / 'xlink:href' attribute).

12:14 PM Changeset in webkit [30207] by alp@webkit.org

4 edits
1 add in trunk/WebCore

2008-02-13 Alp Toker <alp@atoker.com>

Reviewed by Adam Roben.

Split out pure-cairo Font code to FontCairo.cpp.

Part of the ongoing work to share code with the Win port.

GNUmakefile.am:
WebCore.pro:
platform/graphics/cairo/FontCairo.cpp: Added. (WebCore::Font::drawGlyphs):
platform/graphics/gtk/FontGtk.cpp:

11:34 AM Changeset in webkit [30206] by adachan@apple.com

2 edits in trunk/WebKit/win

<rdar://problem/5740656> Leak in postDidAddIconNotification in WebIconDatabase

Reviewed by Darin.

WebIconDatabase.cpp: (postDidAddIconNotification): Need to adopt the newly created instance of CFDictionaryPropertyBag, which already has a ref count of 1.

10:47 AM Changeset in webkit [30205] by beidson@apple.com

11 edits
4 adds in trunk

WebKitTools:

Reviewed by Darin Adler

Add some much needed Database support to DRT

DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to databases are called (clearAllDatabasesCallback): Allow a test to delete all databases (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get (LayoutTestController::staticFunctions):

DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpDatabaseCallbacks): (LayoutTestController::setDumpDatabaseCallbacks):

DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::clearAllDatabases): (LayoutTestController::setDatabaseQuota):

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::clearAllDatabases): Stubbed out (LayoutTestController::setDatabaseQuota): Ditto
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::clearAllDatabases): Stubbed out with error message (LayoutTestController::setDatabaseQuota): Ditto

DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a message with details about the event then return a 5mb quota like before

LayoutTests:

Reviewed by Darin Adler

Added layout tests to cover
http://trac.webkit.org/projects/webkit/changeset/29983
and
http://trac.webkit.org/projects/webkit/changeset/30184

platform/gtk/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
storage/quota-tracking-expected.txt: Added.
storage/quota-tracking.html: Added.
storage/success-callback-expected.txt: Added.
storage/success-callback.html: Added.

9:49 AM Changeset in webkit [30204] by kevino@webkit.org

6 edits in trunk

Fix issues with the paint origin when using wxGCDC, with computing the font platform data hash, and Win and wxPython bindings compilation.
http://bugs.webkit.org/show_bug.cgi?id=17321

9:48 AM Maintenance and architecture list edited by Adam Roben

Mention the clean-header-guards script (diff)

9:34 AM Maintenance and architecture list edited by Darin Adler

(diff)

9:33 AM Maintenance and architecture list edited by Darin Adler

Take out Apple-specific items. (diff)

9:29 AM Maintenance and architecture list created by Darin Adler

9:28 AM Changeset in webkit [30203] by Adam Roben

7 edits in trunk

2008-02-13 Rodney Dawes <dobey@wayofthemonkey.com>

Fix Bug 17220: Illogical dependency between PluginView and PluginDatabase

WebCore:

Fix Bug 17220: Illogical dependency between PluginView and
PluginDatabase

<http://bugs.webkit.org/show_bug.cgi?id=17220>

Reviewed by Adam and Darin.

Rename PluginDatabase::createPluginView to PluginView::create, to make
the illogical dependency between the two, logical
Make PluginDatabase::findPlugin a public method
Update the includes in PluginView and PluginDatabase for the change

plugins/PluginDatabase.h:
plugins/PluginView.h:
plugins/win/PluginDatabaseWin.cpp:
plugins/win/PluginViewWin.cpp:

WebKit/win:

Fix Bug 17220: Illogical dependency between PluginView and
PluginDatabase

<http://bugs.webkit.org/show_bug.cgi?id=17220>

Reviewed by Adam and Darin.

Update for the rename of PluginDatabase::createPluginView
to PluginView::create

WebFrame.cpp:

9:20 AM Changeset in webkit [30202] by Adam Roben

6 edits in trunk

Windows build fixes

WebCore:

Build fix

platform/graphics/cg/GraphicsContextCG.cpp: Added missing #include.

WebKit/win:

Windows build fix

Interfaces/WebKit.idl: Create the typelib version symbol ourselves.

WebKitLibraries:

win/tools/scripts/auto-version.sh: Removed a redundant symbol.

9:20 AM WikiStart edited by Darin Adler

Adding a new page with to do items for maintenance. (diff)

8:29 AM Changeset in webkit [30201] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2008-02-13 Alp Toker <alp@atoker.com>

Reviewed by Adam Roben.

Fix very small, upside down, inside out text on GTK+/DirectFB.

Based on an initial patch by Sriram Neelakandan <sriram.neelakandan@gmail.com>

Test the result of gdk_screen_get_resolution() and use a default
fallback in case of failure.

Also remove an unhelpful runtime warning.

webkit/webkitwebview.cpp:

7:56 AM Changeset in webkit [30200] by Darin Adler

1 edit
2 deletes in trunk/LayoutTests

platform/mac/svg/hixie/perf/001-expected.txt: Removed.
platform/mac/svg/hixie/perf/002-expected.txt: Removed.

7:29 AM Changeset in webkit [30199] by pewtermoose@webkit.org

2 edits in trunk/WebCore

Not reviewed, build fix.

platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::paintBuffer):

6:25 AM Changeset in webkit [30198] by Darin Adler

5 edits in trunk/WebCore

try to fix Wx build

platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::paintBuffer): Added.

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::paintBuffer): Added missing paintingDisabled() check.
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::paintBuffer): Ditto.
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::paintBuffer): Ditto.

5:33 AM Changeset in webkit [30197] by Darin Adler

2 edits in trunk/WebCore

try to fix Wx build

platform/wx/LocalizedStringsWx.cpp: Add missing include.

5:26 AM Changeset in webkit [30196] by Darin Adler

8 edits in trunk

WebCore:

roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders incorrectly due to visibility fix

Removed the Xcode-specific quirk at the request of some folks on the Xcode team.

WebCore.base.exp: Rolled out change.
css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty): Ditto.
page/Settings.cpp: (WebCore::Settings::Settings): Ditto. But keep the initialization of m_fontRenderingMode. (WebCore::Settings::setNeedsXcodeVisibilityQuirk): Removed.
page/Settings.h: (WebCore::Settings::needsXcodeVisibilityQuirk): Removed.

WebKit/mac:

roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders incorrectly due to visibility fix

Removed the Xcode-specific quirk at the request of some folks on the Xcode team.

Misc/WebKitVersionChecks.h: Removed the constant.

WebView/WebView.mm: (-[WebView _needsXcodeVisibilityQuirk]): Removed. (-[WebView _preferencesChangedNotification:]): Removed call to setNeedsXcodeVisibilityQuirk.

4:51 AM Changeset in webkit [30195] by ap@webkit.org

7 edits
4 adds in trunk

Reviewed by Darin.

<rdar://problem/5740042> Database termination issues

Test: storage/close-during-stress-test.html

dom/Document.cpp: (WebCore::Document::databaseThread):
dom/Document.h: Don't re-create the database thread if it has been already terminated.

storage/Database.h: (WebCore::Database::document): Changed m_database to a RefPtr to avoid having a hanging reference.

storage/DatabaseThread.cpp: (WebCore::DatabaseThread::requestTermination):

storage/SQLTransaction.cpp: (WebCore::SQLTransaction::~SQLTransaction): Removed logging. Transactions are deleted during GC, so it's usually not importatnt to know when it happens.

4:33 AM Changeset in webkit [30194] by Darin Adler

1 edit
2 adds in trunk/LayoutTests

check in results for these tests

No idea if these are right or not; just what was generated on my computer.
If someone has a better version, feel free to replace these results with correct ones.