⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 17, 2008:

10:45 PM Changeset in webkit [30368] by weinig@apple.com
  • 2 edits in trunk/WebCore

Roll out r30360.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation):
10:31 PM Changeset in webkit [30367] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch

Make JavaScriptCore and WebKit's FEATURE_DEFINES match WebCore.

10:25 PM Changeset in webkit [30366] by weinig@apple.com
  • 2 edits in trunk/WebCore

Mac build fix.

  • WebCore.xcodeproj/project.pbxproj:
9:47 PM Changeset in webkit [30365] by sfalken@apple.com
  • 1 edit in branches/Safari-3-1-branch/WebCore/ChangeLog

ChangeLog fix.

9:43 PM Changeset in webkit [30364] by sfalken@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Build fix.

  • WebCore.vcproj/build-generated-files.sh:
6:32 PM Changeset in webkit [30363] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-02-17 Alp Toker <alp@atoker.com>

Attempt to fix the Wx build (has been broken all weekend).

Stub out some graphics functions.

  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath):
  • platform/graphics/wx/PathWx.cpp: (WebCore::Path::isEmpty):
6:02 PM Changeset in webkit [30362] by alp@webkit.org
  • 4 edits
    2 copies
    2 moves
    2 adds in trunk

2008-02-17 Julien Chaffraix <julien.chaffraix@gmail.com>

Reviewed by Alexey Proskuryakov.

http://bugs.webkit.org/show_bug.cgi?id=16989
bug 16989 : Add send() flag checks in XmlHttpRequest

  • Splitted xmlhttprequest-abort-readystate in 2 test cases (xmlhttprequest-abort-readystate-shouldDispatchEvent and xmlhttprequest-abort-readystate-shouldNotDispatchEvent)
  • Added test case for the 2 send() flag checks in XmlHttpRequest::send and XmlHttpRequest::setRequestHeader
4:22 PM Changeset in webkit [30361] by weinig@apple.com
  • 11 edits in trunk

WebCore:

Reviewed by Dan Bernstein.

Fix for http://bugs.webkit.org/show_bug.cgi?id=17365
document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR

  • Updated fast/events/event-instanceof.html to test document.createEvent("MessageEvent").
  • DerivedSources.make: Generate Objective-C binding for DOMProgressEvent which was missing.
  • WebCore.xcodeproj/project.pbxproj: Add missing DOMProgressEvent files to the project.
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS): Clean up and add case for SVGZoomEvent that was missing.
  • bindings/objc/DOMEvents.mm: (+[DOMEvent _wrapEvent:WebCore::]): Clean up and add cases for ProgressEvent and MessageEvent that were missing.
  • dom/Document.cpp: (WebCore::Document::createEvent): Add case for MessageEvent.

WebKit/mac:

Reviewed by Dan Bernstein.

Fix for http://bugs.webkit.org/show_bug.cgi?id=17365
document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR

  • MigrateHeaders.make: Migrate DOMProgressEvent.h and DOMTextPrivate.h which were mistakenly not migrated.

LayoutTests:

Reviewed by Dan Bernstein.

Update test for http://bugs.webkit.org/show_bug.cgi?id=17365
document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR

  • fast/events/event-instanceof-expected.txt:
  • fast/events/resources/event-instanceof.js: Test MessageEvent as well.
4:14 PM Changeset in webkit [30360] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-17 Adam Treat <treat@kde.org>

Reviewed by Eric Seidel.

http://bugs.webkit.org/show_bug.cgi?id=17008
Meta refresh does not work with cache turned off

Fix for issue noticed on http://adserver.vivox.com/2

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation):
3:53 PM Changeset in webkit [30359] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-17 Alp Toker <alp@atoker.com>

Reviewed by Sam Weinig.

Fix for change made in r30355. Issue noticed by İsmail Dönmez.

Verify SSL certs by default, but allow checks to be disabled with an
environment variable (WEBKIT_IGNORE_SSL_ERRORS) for now.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startJob):
12:21 PM Changeset in webkit [30358] by ap@webkit.org
  • 2 edits in trunk/WebKit/win

http://bugs.webkit.org/show_bug.cgi?id=17397
<rdar://problem/5748245> REGRESSION (r30236-30336): Cannot backspace/enter in forms on Windows

  • WebKit.vcproj/WebKit.vcproj: Add ENABLE_CROSS_DOCUMENT_MESSAGING definitions.
11:28 AM Changeset in webkit [30357] by mitz@apple.com
  • 5 edits in trunk/LayoutTests

Reviewed by Mark Rowe.

  • disable the non-ASCII parts of a test case for the ASCII code path because it is failing on the (Tiger) buildbots for an unrelated reason.
  • fast/text/fixed-pitch-control-characters.html:
  • platform/mac/fast/text/fixed-pitch-control-characters-expected.checksum:
  • platform/mac/fast/text/fixed-pitch-control-characters-expected.png:
  • platform/mac/fast/text/fixed-pitch-control-characters-expected.txt:
9:59 AM Changeset in webkit [30356] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • wtf/ListHashSet.h: (WTF::swap): Removed stray return statement.
7:36 AM Changeset in webkit [30355] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-17 Bin Chen <binary.chen@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=17404
Bug 17404: curl certification problem

Disable SSL cert verification until we have a way of distributing
certs and/or reporting SSL errors to the user.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startJob):
7:09 AM Changeset in webkit [30354] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-17 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

DevHelp fails to load local files; URL truncated by one character.

Fix a file:// URL regression introduced in KURL.cpp r30243.

  • platform/KURL.cpp: (WebCore::KURL::KURL):
4:12 AM Changeset in webkit [30353] by mrowe@apple.com
  • 2 edits in trunk/WebKit/gtk

2008-02-17 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed by Mark Rowe.

Fix a crash introduced in changeset #29985 by moving the dereference to after
the null check.

  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item):
2:46 AM Changeset in webkit [30352] by mrowe@apple.com
  • 15 edits in branches/Safari-3-1-branch

Merge r30331.

2:45 AM Changeset in webkit [30351] by mrowe@apple.com
  • 5 edits in branches/Safari-3-1-branch

Merge r30330.

2:44 AM Changeset in webkit [30350] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30329.

2:43 AM Changeset in webkit [30349] by mrowe@apple.com
  • 7 edits in branches/Safari-3-1-branch

Merge r30328.

2:42 AM Changeset in webkit [30348] by mrowe@apple.com
  • 23 edits
    1 move
    2 adds in branches/Safari-3-1-branch

Merge r30326.

2:40 AM Changeset in webkit [30347] by mrowe@apple.com
  • 23 edits
    1 add in branches/Safari-3-1-branch/WebCore

Merge r30325.

2:39 AM Changeset in webkit [30346] by mrowe@apple.com
  • 8 edits
    1 copy
    5 adds in branches/Safari-3-1-branch

Merge r30323.

1:03 AM WebKit Team edited by mitz@apple.com
Edited my entry to humor Sam (diff)
12:50 AM Changeset in webkit [30345] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/forms/control-clip-overflow.html

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::lowestPosition): Account for control clipping. (WebCore::RenderFlow::rightmostPosition): Ditto. (WebCore::RenderFlow::leftmostPosition): Ditto.

LayoutTests:

Reviewed by Darin Adler.

  • fast/forms/control-clip-overflow.html: Added.
  • platform/mac/fast/forms/control-clip-overflow-expected.checksum: Added.
  • platform/mac/fast/forms/control-clip-overflow-expected.png: Added.
  • platform/mac/fast/forms/control-clip-overflow-expected.txt: Added.

Feb 16, 2008:

9:48 PM Changeset in webkit [30344] by oliver@apple.com
  • 2 edits in trunk/WebCore

Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp

Reviewed by Eric S

Use cross-platform code to determine the dirty rects for
fill and stroke operations

7:43 PM Changeset in webkit [30343] by weinig@apple.com
  • 8 edits in trunk/WebCore

Reviewed by Darin Adler.

Take another step in the direction of getting rid of DeprecatedString
by moving all the to{NumericType} off of it.

  • Create free functions that take a UChar* buffer and length to do the string-to-number conversions. This allows us to avoid two allocations if we don't already have a String and is consistent with the design we would like going forward.
  • Since the toInt (and family) functions on DeprecatedString were slightly different than the ones on String (they didn't allow trailing garbage), an extra set of 'Strict' toInt functions were added that have this behavior.
  • platform/graphics/Color.cpp: (WebCore::Color::parseHexColor):
  • platform/text/PlatformString.h:
  • platform/text/String.cpp: (WebCore::String::percentage): (WebCore::String::toIntStrict): (WebCore::String::toUIntStrict): (WebCore::String::toInt64Strict): (WebCore::String::toUInt64Strict): (WebCore::String::toUInt): (WebCore::String::toDouble): (WebCore::isCharacterAllowedInBase): (WebCore::toIntegralType): (WebCore::lengthOfCharactersAsInteger): (WebCore::charactersToIntStrict): (WebCore::charactersToUIntStrict): (WebCore::charactersToInt64Strict): (WebCore::charactersToUInt64Strict): (WebCore::charactersToInt): (WebCore::charactersToUInt): (WebCore::charactersToInt64): (WebCore::charactersToUInt64): (WebCore::charactersToDouble): (WebCore::charactersToFloat):
  • platform/text/StringImpl.cpp: (WebCore::parseLength): (WebCore::StringImpl::toIntStrict): (WebCore::StringImpl::toUIntStrict): (WebCore::StringImpl::toInt64Strict): (WebCore::StringImpl::toUInt64Strict): (WebCore::StringImpl::toInt): (WebCore::StringImpl::toUInt): (WebCore::StringImpl::toInt64): (WebCore::StringImpl::toUInt64): (WebCore::StringImpl::toDouble): (WebCore::StringImpl::toFloat):
  • platform/text/StringImpl.h:
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseClockValue):
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
7:08 PM Changeset in webkit [30342] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • fix fixed-pitch font measurement of control characters that render as zero-width space

Test: fast/text/fixed-pitch-control-characters.html

  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache):

LayoutTests:

Reviewed by Sam Weinig.

  • test fixed-pitch font measurement of control characters that render as zero-width space
  • fast/text/fixed-pitch-control-characters.html: Added.
  • platform/mac/fast/text/fixed-pitch-control-characters-expected.checksum: Added.
  • platform/mac/fast/text/fixed-pitch-control-characters-expected.png: Added.
  • platform/mac/fast/text/fixed-pitch-control-characters-expected.txt: Added.
2:04 PM Changeset in webkit [30341] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix.

1:06 PM WebKit Team edited by weinig@apple.com
Add areas of knowledge for Sam Weinig (diff)
1:02 PM WebKit Team edited by weinig@apple.com
Remove Tristan as he is no longer at Apple (diff)
9:41 AM Changeset in webkit [30340] by Darin Adler
  • 1 edit
    3 moves in trunk/LayoutTests
  • disable some failing tests; someone can re-enable after fixing the problems causing them to fail or generating new expected results

http://bugs.webkit.org/show_bug.cgi?id=17391

  • fast/frames/iframe-scroll-page-up-down.html: Removed.
  • fast/frames/iframe-scroll-page-up-down.html-disabled: Copied from fast/frames/iframe-scroll-page-up-down.html.

http://bugs.webkit.org/show_bug.cgi?id=17392

  • svg/batik/text/textBiDi.svg: Removed.
  • svg/batik/text/textBiDi.svg-disabled: Copied from svg/batik/text/textBiDi.svg.

http://bugs.webkit.org/show_bug.cgi?id=17393

  • svg/custom/use-on-symbol-inside-pattern.svg: Removed.
  • svg/custom/use-on-symbol-inside-pattern.svg-disabled: Copied from svg/custom/use-on-symbol-inside-pattern.svg.
9:35 AM Changeset in webkit [30339] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

Clean up some old log entries.

3:09 AM Changeset in webkit [30338] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-16 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

Cross document messaging GTK+/autotools build fix.

  • GNUmakefile.am:
Note: See TracTimeline for information about the timeline view.