⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 19, 2008:

6:17 PM Changeset in webkit [30421] by Darin Adler
  • 6 edits in trunk/WebCore

Reviewed by Sam.

  • removed use of DeprecatedString for font family names
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Update for name change.
  • css/CSSParser.cpp: (WebCore::CSSParser::parseFontFamily): Update to use new appendSpaceSeparated function and String rather than DeprecatedString.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Updated for name change.
  • css/FontFamilyValue.cpp: (WebCore::FontFamilyValue::FontFamilyValue): Replaced code using a regular expression with code that does the same thing more efficiently. (WebCore::FontFamilyValue::appendSpaceSeparated): Added. (WebCore::FontFamilyValue::cssText): Updated for name change.
  • css/FontFamilyValue.h: Changed DeprecatedString to String. Renamed fontName to familyName and parsedFontName to m_familyName. Removed unused genericFamilyType and m_genericFamilyType. Added appendSpaceSeparated so that m_familyName can be private instead of public.
6:07 PM Changeset in webkit [30420] by Darin Adler
  • 2 edits in trunk/WebCore
  • fix build when SVG is not enabled
  • rendering/RenderTreeAsText.cpp: Added include of "TextStream.h".
5:55 PM Changeset in webkit [30419] by andersca@apple.com
  • 23 edits in trunk/WebCore

Reviewed by Darin.

Change all classes in xml/ to start out with a ref count of 1.


  • bindings/js/JSCustomXPathNSResolver.h:
  • bindings/js/JSXMLHttpRequest.cpp: (WebCore::JSXMLHttpRequest::JSXMLHttpRequest):
  • bindings/js/JSXSLTProcessor.cpp: (WebCore::JSXSLTProcessor::JSXSLTProcessor):
  • bindings/objc/DOMCustomXPathNSResolver.h: (WebCore::DOMCustomXPathNSResolver::create):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • dom/Document.cpp: (WebCore::Document::applyXSLTransform): (WebCore::Document::createExpression): (WebCore::Document::createNSResolver): (WebCore::Document::evaluate):
  • xml/DOMParser.h: (WebCore::DOMParser::create): (WebCore::DOMParser::DOMParser):
  • xml/NativeXPathNSResolver.h: (WebCore::NativeXPathNSResolver::create):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest):
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::create):
  • xml/XMLSerializer.h: (WebCore::XMLSerializer::create): (WebCore::XMLSerializer::XMLSerializer):
  • xml/XPathEvaluator.cpp: (WebCore::XPathEvaluator::createNSResolver):
  • xml/XPathEvaluator.h: (WebCore::XPathEvaluator::create): (WebCore::XPathEvaluator::XPathEvaluator):
  • xml/XPathExpression.cpp: (WebCore::XPathExpression::createExpression): (WebCore::XPathExpression::evaluate):
  • xml/XPathExpression.h: (WebCore::XPathExpression::create): (WebCore::XPathExpression::XPathExpression):
  • xml/XPathNSResolver.h:
  • xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult):
  • xml/XPathResult.h: (WebCore::XPathResult::create):
  • xml/XPathValue.cpp: (WebCore::XPath::Value::modifiableNodeSet):
  • xml/XPathValue.h: (WebCore::XPath::ValueData::create): (WebCore::XPath::ValueData::ValueData): (WebCore::XPath::Value::Value):
  • xml/XSLTProcessor.h: (WebCore::XSLTProcessor::create): (WebCore::XSLTProcessor::XSLTProcessor):
5:51 PM Changeset in webkit [30418] by Darin Adler
  • 9 edits in trunk

WebCore:

Reviewed by Sam.

  • Trimmed down TextStream and weaned it from DeprecatedString.
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge renderTreeAsExternalRepresentation]): Removed now-unneeded call to getNSString.
  • platform/text/TextStream.cpp: Removed unused functions. Use snprintf instead of sprintf, for better security. (WebCore::TextStream::release): Added.
  • platform/text/TextStream.h: Removed lots of unneeded stuff.
  • rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): Changed to use String instead of DeprecatedString.
  • rendering/RenderTreeAsText.h: Ditto.
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGInlineTextBox): Use "\n" instead of endl. (WebCore::write): Ditto. (WebCore::writeRenderResources): Ditto.

WebKit/win:

Reviewed by Sam.

  • WebFrame.cpp: (WebFrame::renderTreeAsExternalRepresentation): Changed to use String instead of DeprecatedString.
5:43 PM Changeset in webkit [30417] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore changes


This brings performance on the phone back to old levels. Andre and I are doing
some formal testing to see exactly where we stand.

  • dom/Position.cpp: (WebCore::enclosingBlockIgnoringEditability): Added. This is enclosingBlock without the expensive editability checks. upstream and downstream can avoid those because they do their own editability checking. (WebCore::Position::upstream): (WebCore::Position::downstream):
4:41 PM Changeset in webkit [30416] by harrison@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3663560> AXLink for a "name" (anchor) on same page should include an AXLinkedUIElementAttribute

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject linkedUIElement]): Returns the linked-to AX object (if the specified one is ignored by accessibility, returns the next un-ignored one by traversing the DOM).


(-[WebCoreAXObject accessibilityAttributeNames]):
(-[WebCoreAXObject accessibilityAttributeValue:]):
Support NSAccessibilityLinkedUIElementsAttribute.

4:00 PM Changeset in webkit [30415] by Darin Adler
  • 39 edits in trunk/WebCore

Reviewed by Sam.

  • Removed old debugging aids, Node::dump, RenderObject::dump, and RenderObject::information, that used DeprecatedString.
  • dom/CharacterData.cpp: Removed override of Node::dump.
  • dom/CharacterData.h: Ditto.
  • dom/Element.cpp: Ditto.
  • dom/Element.h: Ditto.
  • dom/EventTargetNode.cpp: Ditto.
  • dom/EventTargetNode.h: Ditto.
  • dom/Node.cpp: Removed Node::dump.
  • dom/Node.h: Ditto.
  • rendering/RenderBlock.cpp: Removed override of RenderObject::dump.
  • rendering/RenderBlock.h: Ditto.
  • rendering/RenderFrameSet.cpp: Ditto.
  • rendering/RenderFrameSet.h: Ditto.
  • rendering/RenderObject.cpp: Removed RenderObject::dump and RenderObject::information.
  • rendering/RenderObject.h: Ditto.
  • rendering/RenderTable.cpp: Removed override of RenderObject::dump.
  • rendering/RenderTable.h: Ditto.
  • rendering/RenderTableCell.cpp: Ditto.
  • rendering/RenderTableCell.h: Ditto.
  • rendering/RenderTableCol.cpp: Ditto.
  • rendering/RenderTableCol.h: Ditto.
  • rendering/RenderTableSection.cpp: Ditto.
  • rendering/RenderTableSection.h: Ditto.
  • rendering/RenderTreeAsText.h: Removed unneeded include of TextStream.h and added forward declarations as appropriate.
  • svg/SVGSVGElement.cpp: Removed unneeded include of TextStream.h.
  • svg/graphics/SVGResourceClipper.cpp: And here.
  • svg/graphics/SVGResourceFilter.cpp: Ditto.
  • svg/graphics/filters/SVGFEBlend.cpp: Ditto.
  • svg/graphics/filters/SVGFEComponentTransfer.cpp: Ditto.
  • svg/graphics/filters/SVGFEComposite.cpp: Ditto.
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp: Ditto.
  • svg/graphics/filters/SVGFEGaussianBlur.cpp: Ditto.
  • svg/graphics/filters/SVGFEImage.cpp: Ditto.
  • svg/graphics/filters/SVGFEMerge.cpp: Ditto.
  • svg/graphics/filters/SVGFEMorphology.cpp: Ditto.
  • svg/graphics/filters/SVGFEOffset.cpp: Ditto.
  • svg/graphics/filters/SVGFESpecularLighting.cpp: Ditto.
  • svg/graphics/filters/SVGFETurbulence.cpp: Ditto.
  • svg/graphics/filters/SVGFilterEffect.cpp: Ditto.
3:26 PM Changeset in webkit [30414] by Beth Dakin
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Sam.

Fix for <rdar://problem/5729674> Seed: Crash in
RenderButton::setStyle at ​http://www.dinorpg.com

Inputs should not honor first-letter.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):

LayoutTests:

Reviewed by Sam.

Test for <rdar://problem/5729674> Seed: Crash in
RenderButton::setStyle at ​http://www.dinorpg.com

  • fast/forms/input-first-letter.html: Added.
  • platform/mac/fast/forms/input-first-letter-expected.checksum: Added.
  • platform/mac/fast/forms/input-first-letter-expected.png: Added.
  • platform/mac/fast/forms/input-first-letter-expected.txt: Added.
3:23 PM BuildingCairoOnWindows edited by bfulgham@macports.org
(diff)
2:09 PM Changeset in webkit [30413] by andersca@apple.com
  • 5 edits in trunk/JavaScriptCore

Reviewed by Darin.

Change OpaqueJSClass and RootObject to start with a ref count of 1.


  • API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): (OpaqueJSClass::createNoAutomaticPrototype): (OpaqueJSClass::create):
  • API/JSClassRef.h:
  • API/JSObjectRef.cpp: (JSClassCreate):
  • bindings/runtime_root.cpp: (KJS::Bindings::RootObject::create): (KJS::Bindings::RootObject::RootObject):
1:13 PM Changeset in webkit [30412] by mitz@apple.com
  • 11 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/5637569> CrashTracer: [REGRESSION] 620 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::setStaticY + 15

Test: fast/text/wbr-styled.html

Changed RenderWordBreak to inherit from RenderText instead of
RenderInline.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
  • rendering/RenderFlow.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::renderName): (WebCore::RenderText::isTextFragment): (WebCore::RenderText::isWordBreak):
  • rendering/RenderText.h:
  • rendering/RenderWordBreak.cpp: (WebCore::RenderWordBreak::RenderWordBreak):
  • rendering/RenderWordBreak.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/5637569> CrashTracer: [REGRESSION] 620 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::setStaticY + 15
  • fast/text/wbr-styled.html: Added.
  • platform/mac-leopard/fast/text/wbr-styled-expected.checksum: Added.
  • platform/mac-leopard/fast/text/wbr-styled-expected.png: Added.
  • platform/mac/fast/css-generated-content/wbr-with-before-content-expected.txt:
  • platform/mac/fast/text/wbr-pre-expected.txt:
  • platform/mac/fast/text/wbr-styled-expected.txt: Added.
11:42 AM Changeset in webkit [30411] by andersca@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog

11:42 AM Changeset in webkit [30410] by andersca@apple.com
  • 10 edits in trunk

WebCore:

Reviewed by Darin.

WARNING: NO TEST CASES ADDED OR CHANGED

  • ChangeLog:
  • WebCore.base.exp:
  • loader/mac/LoaderNSURLExtras.h:
  • loader/mac/LoaderNSURLExtras.m: Move unused functions to WebKit (where they are used)


(vectorContainsString):
Use const references.


  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm: Remove wkNSURLProtocolClassForReqest.

WebKit/mac:

Reviewed by Darin.

Move back WebKit methods that were unused in WebCore.


  • Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:]): (+[NSURL _web_URLWithData:relativeToURL:]): (-[NSURL _web_originalData]): (-[NSURL _web_originalDataAsString]): (-[NSURL _web_isEmpty]): (-[NSURL _webkit_canonicalize]): (-[NSURL _webkit_URLByRemovingComponent:]): (-[NSURL _webkit_URLByRemovingFragment]): (-[NSURL _webkit_URLByRemovingResourceSpecifier]): (-[NSURL _webkit_isFileURL]): (-[NSString _webkit_isFileURL]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setTitle):
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
11:28 AM Changeset in webkit [30409] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore


These changes bring deleting performance back to old levels on the phone
except for deleting the first space to the right of a word, which we are
still working on.

  • dom/Position.cpp: (WebCore::Position::upstream): Avoid the use of enclosingBlock when determining if we have left the original enclosing block or entered a new one, and avoid rootEditableElement for determining if we have changed editability. These operations are expensive. (WebCore::Position::downstream): Ditto.
11:16 AM Changeset in webkit [30408] by Darin Adler
  • 6 edits in trunk

JavaScriptCore:

Rubber stamped by Anders.

  • removed explicit initialization to 1 for RefCounted; that's now the default
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): Removed RefCounted initializer.

WebCore:

Rubber stamped by Anders.

  • removed explicit initialization to 1 for RefCounted; that's now the default
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): Removed RefCounted initializer.
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): Ditto.
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Ditto.
11:08 AM Changeset in webkit [30407] by beidson@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Geoff

Fixed a bug in DRT --threaded mode

  • DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: (startJavaScriptThreads): Don't detach the newly created thread. The later call to stopJavaScriptThreads() tries to pthread_join() each thread that had been created, but you can't join a detached thread!
11:06 AM Changeset in webkit [30406] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • wtf/RefCounted.h: (WTF::RefCounted::RefCounted): Have refcounts default to 1. This allows us to start removing the explicit initialization of RefCounted from classes and eventually we can remove the ability to have the initial count of 0 entirely.
10:25 AM Changeset in webkit [30405] by andersca@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Darin.

Make ResourceLoader and ResourceHandle start out with a refcount of 1.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::create):
  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::create):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
5:05 AM Changeset in webkit [30404] by alp@webkit.org
  • 4 edits in trunk/WebCore

2008-02-19 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16863
[GTK] tab focusing doesn't work

GDK_MOD2_MASK doesn't always mean meta so we can't use it to identify
the meta key state.

Use GDK_META_MASK where available, otherwise do not support the meta
key. This matches the behaviour of other applications.

Also add a comment noting that the platform event constructors need to
be kept in sync (it's not obvious that there are multiple places that
check the key state).

  • platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  • platform/gtk/MouseEventGtk.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

Feb 18, 2008:

11:17 PM Changeset in webkit [30403] by beidson@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Sam Weinig's white rhino tusk stamp

SQLiteTransaction::stop() should also reset the transaction-in-progress flag in its parent SQLiteDatabase

  • platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::stop):
11:15 PM Changeset in webkit [30402] by beidson@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig's rubberstamp

SQLiteTransaction::stop() should also reset the transaction-in-progress flag in its parent SQLiteDatabase

  • platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::stop):
11:04 PM Changeset in webkit [30401] by mrowe@apple.com
  • 3 edits in branches/Safari-3-1-branch/LayoutTests

Merge r30399.

11:03 PM Changeset in webkit [30400] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Make Drosera work on Vista.


Runtime type library registration on Vista requires use of two new call:
RegisterTypeLibraryForUser and UnRegisterTypeLibraryForUser, which write to
HKCU. LoadTypeLib[Ex] registers under HKLM, which fails under vista due to UAC.


Reviewed by Adam.

  • WebKitDLL.cpp: (DllUnregisterServer): Call UnRegisterTypeLibraryForUser if available. Fix version number. (DllRegisterServer): Call RegisterTypeLibraryForUser if available.
10:24 PM Changeset in webkit [30399] by mitz@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Adam Roben in California.

  • remove unnecessary and erroneous layoutTestController calls from a test
  • fast/css/font-face-multiple-remote-sources.html:
  • platform/mac/fast/css/font-face-multiple-remote-sources-expected.txt:
9:42 PM Changeset in webkit [30398] by mrowe@apple.com
  • 5 edits
    2 adds in branches/Safari-3-1-branch

Merge r30395.

9:41 PM Changeset in webkit [30397] by mrowe@apple.com
  • 4 edits
    4 adds in branches/Safari-3-1-branch

Merge r30392.

9:40 PM Changeset in webkit [30396] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30389.

9:19 PM Changeset in webkit [30395] by beidson@apple.com
  • 6 edits
    2 adds in trunk

WebCore:

Reviewed by Darin

Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released

Test: platform/mac/plugins/webScriptObject-exception-deadlock.html

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject valueForKey:]): The line resultObj = [super valueForKey:key]; // defaults to throwing an exception says it all - it throws an exception. This method also happens to hold the JSLock. Problematically, when the exeception is thrown and the method exited, the JSLock is never released. Fix that without otherwise changing behavior by holding the JSLock in two individual scopes - Right before the exception and right after.

WebKitTools:

Changes by Geoff Garen, Reviewed by Darin

Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released

DRT changes for test: platform/mac/plugins/webScriptObject-exception-deadlock.html

[WebScriptObject valueForKey:] might throw an exception, and previously might have "leaked" the global JSLock
This test calls valueForKey, then runs some arbitrary Javascript on a 2ndary thread. If the lock has leaked,
this series of method calls will deadlock. If things are good, it will complete successfully.

  • DumpRenderTree/mac/ObjCController.m: (runJavaScriptThread): (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController testValueForKey]):

LayoutTests:

Reviewed by Darin

Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released

  • platform/mac-tiger/Skipped: Removed 2 hanging tests that now don't hang
  • platform/mac/plugins/webScriptObject-exception-deadlock-expected.txt: Added.
  • platform/mac/plugins/webScriptObject-exception-deadlock.html: Added.
8:07 PM Changeset in webkit [30394] by pewtermoose@webkit.org
  • 4 edits in trunk

Remove FindSafari's Release configuration.

6:21 PM Changeset in webkit [30393] by Darin Adler
  • 20 edits in trunk

WebCore:

Reviewed by Sam.

  • reduce use of DeprecatedString and memory allocations in processing of CSS
  • remove unnecessary double -> float -> double trip in the CSS parser
  • cleaned up names and structure in CSS grammar
  • css/CSSGrammar.y: Remove getPropertyID and getValueID. Both are now in CSSParser.cpp instead, and they now work on ParseString and String objects and don't require the caller to put the string into a char*. Gave members of the %union more sensible names, removed duplicates, and sorted into a logical order. Put the %expect back in, rather than leaving it commented out.
  • css/CSSParser.cpp: (WebCore::equalIgnoringCase): Added. (WebCore::hasPrefix): Added. (WebCore::CSSParser::parseTransitionProperty): Changed to call the new cssPropertyID, which obviates the need to call lower() and utf8() or to allocate memory at all. Also used equalIgnoringCase rather than putting the value into a String just to compare it. (WebCore::CSSParser::lex): Replaced convertASCIIToFloat with charactersToDouble. This change along with the CSSGrammar.y change, removes the double -> float -> double round trip, and affects the result of one layout test. (WebCore::cssPropertyID): Added. Gets the property ID from the gperf hash table, but without allocating any memory. (WebCore::cssValueKeywordID): Ditto.
  • css/CSSParser.h: Removed declaration for deprecatedString function (now used only in CSSParser.cpp; soon to be deleted). Added cssPropertyID and cssValueKeywordID functions.
  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::getPropertyCSSValue): Call cssPropertyID instead of propertyID. (WebCore::CSSStyleDeclaration::getPropertyValue): Ditto. (WebCore::CSSStyleDeclaration::getPropertyPriority): Ditto. (WebCore::CSSStyleDeclaration::getPropertyShorthand): Ditto. (WebCore::CSSStyleDeclaration::isPropertyImplicit): Ditto. (WebCore::CSSStyleDeclaration::setProperty): Ditto. (WebCore::CSSStyleDeclaration::removeProperty): Ditto. (WebCore::CSSStyleDeclaration::isPropertyName): Ditto.
  • css/CSSStyleDeclaration.h: Removed unnecessary includes, unnecessary Noncopyable boilerplate, and the getPropertyID function declaration along with its associated apology comment.
  • css/makevalues.pl: Generate constants instead of macros for CSS value numbers (but not an enumeration, like properties, since you rarely have any reason to handle all values, but often have a reason to handle all properties). Renamed the constant for the number of CSS value keywords from CSS_VAL_TOTAL to numCSSValueKeywords, and added maxCSSValueKeywordLength.
  • platform/text/String.cpp: (WebCore::charactersToDouble): Made this function more efficient by using a stack buffer rather than a CString.

LayoutTests:

Reviewed by Sam.

  • generate new results for the one test that was altered by the double -> float -> double trip taken by numeric values in the CSS parser

This test appears under three different names in three different
parts of our test suite.

  • platform/mac/css1/box_properties/acid_test-expected.checksum: Updated.
  • platform/mac/css1/box_properties/acid_test-expected.png: Ditto.
  • platform/mac/css1/box_properties/acid_test-expected.txt: Ditto.
  • platform/mac/css2.1/t09-c5526c-display-00-e-expected.checksum: Ditto.
  • platform/mac/css2.1/t09-c5526c-display-00-e-expected.png: Ditto.
  • platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt: Ditto.
  • platform/mac/fast/block/basic/011-expected.checksum: Ditto.
  • platform/mac/fast/block/basic/011-expected.png: Ditto.
  • platform/mac/fast/block/basic/011-expected.txt: Ditto.
6:13 PM Changeset in webkit [30392] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/5736225> crash in svgFontAndFaceElementForFontData on digitalstrom.org/cms

Test: fast/css/font-face-multiple-remote-sources.html

  • css/CSSFontFace.cpp: (WebCore::CSSFontFace::fontLoaded):
  • css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::fontLoaded):

LayoutTests:

  • test for <rdar://problem/5736225> crash in svgFontAndFaceElementForFontData on digitalstrom.org/cms
  • fast/css/font-face-multiple-remote-sources.html: Added.
  • platform/mac/fast/css/font-face-multiple-remote-sources-expected.checksum: Added.
  • platform/mac/fast/css/font-face-multiple-remote-sources-expected.png: Added.
  • platform/mac/fast/css/font-face-multiple-remote-sources-expected.txt: Added.
5:12 PM Changeset in webkit [30391] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::hasCSSPropertyNamePrefix): Added. (WebCore::cssPropertyName): Reimplement to not use DeprecatedString. Also made faster by using a Vector<UChar> and eliminating all the string operations.
4:54 PM Changeset in webkit [30390] by Darin Adler
  • 2 edits in trunk/WebKit/mac

Reviewed by Sam.

  • Misc/WebNSAttributedStringExtras.mm: (+[NSAttributedString _web_attributedStringFromRange:]): Eliminate use of DeprecatedString.
4:48 PM Changeset in webkit [30389] by Stephanie Lewis
  • 2 edits in trunk/WebCore

2008-02-18 Stephanie Lewis <Stephanie Lewis>

Reviewed by Adam.

Remove workaround for <rdar://problem/5695848>.

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):
4:48 PM Changeset in webkit [30388] by Darin Adler
  • 2 edits in trunk/WebKit/qt

Reviewed by Sam.

  • Api/qwebnetworkinterface.cpp: (QWebNetworkRequestPrivate::init): Removed use of DeprecatedString.
4:25 PM Changeset in webkit [30387] by weinig@apple.com
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Geoff Garen.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=17419
Remove CompatMode from JavaScriptCore as it is never set to anything other than NativeMode

  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init):
  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::setDebugger):
  • kjs/date_object.cpp: (KJS::dateProtoFuncGetYear):

WebCore:

Reviewed by Geoff Garen.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=17419
Remove CompatMode from JavaScriptCore as it is never set to anything other than NativeMode

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScript):
3:04 PM Changeset in webkit [30386] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-18 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=17381
[CURL] Regression: data URL parsing broken after DeprecatedString removal (Acid2)

This patch resolves the regression for the GTK+ port.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl):
3:03 PM Changeset in webkit [30385] by alp@webkit.org
  • 4 edits in trunk/WebKit/gtk

2008-02-18 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=17312
[GTK] Webview Transparent Background

Add support for WebView background transparency.

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:
  • webkit/webkitwebview.h:
3:03 PM Changeset in webkit [30384] by alp@webkit.org
  • 3 edits in trunk/WebKit/gtk

2008-02-18 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Implement webkit_web_view_get_focused_frame()

Equivalent to selectedFrame in the Mac API.

  • webkit/webkitwebview.cpp:
  • webkit/webkitwebview.h:
1:43 PM Changeset in webkit [30383] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): Use String instead of DeprecatedString. (WebCore::ResourceHandle::start): Ditto.
1:42 PM Changeset in webkit [30382] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): Use String instead of DeprecatedString. (WebCore::cookies): Ditto.
1:40 PM Changeset in webkit [30381] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • removed use of DeprecatedString in the Color class
  • platform/graphics/Color.cpp: (WebCore::Color::parseHexColor): Streamlined logic a bit with early returns. Used toASCIIHexValue a character at a time rather than using toIntStrict in base 16 mode. (WebCore::findNamedColor): Added. Uses a fixed-size char buffer to look up a color using the gperf-generated findColor function. Saves a memory allocation vs. the old version that called DeprecatedString::latin1(). (WebCore::Color::setNamedColor): Changed to use findNamedColor.
1:28 PM Changeset in webkit [30380] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam.

  • wtf/ASCIICType.h: (WTF::toASCIIHexValue): Added.
1:20 PM Changeset in webkit [30379] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Changed to use String instead of DeprecatedString.
1:16 PM Changeset in webkit [30378] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer): Changed to use String instead of DeprecatedString.
12:13 PM Changeset in webkit [30377] by weinig@apple.com
  • 7 edits
    3 deletes in trunk/WebCore

Reviewed and landed by Sam.

Remove DeprecatedStringList.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • editing/markup.cpp:
  • platform/DeprecatedStringList.cpp: Removed.
  • platform/DeprecatedStringList.h: Removed.
  • platform/mac/DeprecatedStringListMac.mm: Removed.
11:55 AM Changeset in webkit [30376] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30370.

11:49 AM Changeset in webkit [30375] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • css/CSSPrimitiveValueMappings.h: Add default cases to all the switch statements. This will ease the way some day if we decide to use an enum instead of int; otherwise we'll have a ton of "unhandled enum value" warnings here.
11:21 AM Changeset in webkit [30374] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-18 Alp Toker <​alp@atoker.com>

Build fix for GTK+ < 2.10. Fall back to simple text clipboard copy
with older GTK+ versions for now.

  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection):
10:59 AM Changeset in webkit [30373] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • WebCore.base.exp: Export a couple of WebCore::String functions we plan to use in the future in WebKit.
10:58 AM Changeset in webkit [30372] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • DerivedSources.make: Added the scripts to the ENABLE_SVG versions of the rules for CSSPropertyNames.h and CSSValueKeywords.h. Somehow that got left out, so the files would not be regenerated if the scripts were changed (but would if SVG was disabled).
10:41 AM Changeset in webkit [30371] by ap@webkit.org
  • 2 edits in trunk/WebCore

Suggested by Darin.

  • platform/KURL.h: (WebCore::KURL::operator const String&): Added, to avoid unexpected conversion via UString (as in bug 17418).
10:23 AM Changeset in webkit [30370] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2008-02-18 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

<rdar://problem/5744899> Crash in Flash when clicking "Yes" to abort
slow script Flash 9 dialog at ​http://www.kidzui.com

When navigating to a new page, we stop all outstanding PluginStreams.
Flash hangs in the call to NPP_URLNotify. It eventually displays the
"slow script" dialog, which relinquishes control to the system. While
this dialog is running, the request we are in the process of cancelling
completes, and we re-enter Flash to deliver the data. When the dialog
is dismissed, the internal state of Flash has changed, and Flash
crashes with a null dereference.

To work around this, we can defer loading before entering plug-in code,
so that even if a plug-in yields to the system, we won't get callbacks
while we're handling a callback.

  • plugins/PluginStream.cpp: (WebCore::PluginStream::startStream): Defers loads while calling into plug-in. (WebCore::PluginStream::destroyStream): Same. (WebCore::PluginStream::deliverData): Same. (WebCore::PluginStream::didFail): Protect 'this' from deletion by destroyStream. Null out m_loader only after destroyStream returns. (WebCore::PluginStream::didFinishLoading): Same.
10:14 AM Changeset in webkit [30369] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=17418
REGRESSION: Assertion failure dragging image (JSLock::lockCount() > 0)

  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::declareAndWriteDragImage): Explicitly convert from KURL to String, as an implicit conversion uses UString and thus needs a JSLock.
7:14 AM QtWebKitTodo edited by Simon Hausmann
(diff)
6:33 AM QtWebKitTodo edited by Simon Hausmann
(diff)
4:15 AM QtWebKitTodo edited by Simon Hausmann
(diff)
1:10 AM QtWebKitTodo edited by Simon Hausmann
(diff)
Note: See TracTimeline for information about the timeline view.