Context Navigation

Fix for Bug 16753: date set methods with no args should result in NaN (Acid3 bug)
The set values result in NaN now when called with no args, NaN or +/- inf values.
The setYear, setFullYear and setUTCFullYear methods used on NaN dates work as
descripted in the standard.

kjs/date_object.cpp: (KJS::fillStructuresUsingTimeArgs): (KJS::fillStructuresUsingDateArgs): (KJS::setNewValueFromTimeArgs): (KJS::setNewValueFromDateArgs): (KJS::dateProtoFuncSetYear):

LayoutTests:

Reviewed by Darin.

test for Bug 16753: date set methods with no args should result in NaN (Acid3 bug)

fast/js/date-set-to-nan-expected.txt: Added.
fast/js/date-set-to-nan.html: Added.
fast/js/resources/date-set-to-nan.js: Added.

8:24 PM Changeset in webkit [30452] by oliver@apple.com

3 edits
2 adds in trunk

Bug 17303: Canvas crash in ImageBuffer

Reviewed by Hyatt.

We handle a null GraphicsContext everywhere, but we weren't checking for
a null ImageBuffer, which is what will result in a null GraphicsContext in
the first place.

8:06 PM Changeset in webkit [30451] by hyatt@apple.com

1 edit in trunk/LayoutTests/platform/mac/fast/media/mq-js-stylesheet-media-03-expected.txt

Land new results for a layout test that now passes now that dynamic media lists work.

8:05 PM Changeset in webkit [30450] by hyatt@apple.com

4 edits in trunk/WebCore

Fix the layout test failure that never should have passed in the first
place by making changes to media lists actually result in the recomputation
of the style selector. Now it passes for the right reasons and not because
of dumb luck.

Reviewed by Sam Weinig

css/MediaList.cpp: (WebCore::MediaList::deleteMedium): (WebCore::MediaList::setMediaText): (WebCore::MediaList::appendMedium): (WebCore::MediaList::notifyChanged):
css/MediaList.h:
dom/Document.cpp: (WebCore::Document::attach):

8:00 PM Changeset in webkit [30449] by weinig@apple.com

2 edits in trunk/WebCore

Reviewed, tweaked and landed by Sam.

make markup functions not use DeprecatedString.

editing/markup.cpp: (WebCore::append): Added. (WebCore::escapeContentText): Build up string using a Vector. (WebCore::appendStartMarkup): Use String instead of DeprecatedString.

7:57 PM Changeset in webkit [30448] by weinig@apple.com

1 edit in trunk/WebCore/ChangeLog

Fix changelog

7:54 PM Changeset in webkit [30447] by weinig@apple.com

3 edits in trunk/WebCore

Reviewed, tweaked and landed by Sam.

make HTMLInterchange return a String instead of a DeprecatedString

editing/TextIterator.cpp: (WebCore::CharacterIterator::string): Build up the String using a Vector. (WebCore::WordAwareIterator::advance): Switch to using Vector functions. (WebCore::WordAwareIterator::length): Ditto. (WebCore::WordAwareIterator::characters): Ditto.
editing/TextIterator.h: Use a Vector<UChar> for the buffer instead of DeprecatedString.

7:42 PM Changeset in webkit [30446] by weinig@apple.com

3 edits in trunk/WebCore

Reviewed, tweaked and landed by Sam.

make HTMLInterchange return a String instead of a DeprecatedString

editing/HTMLInterchange.cpp: (WebCore::): Return a String from convertedSpaceString. (WebCore::convertHTMLTextToInterchangeFormat): Use a Vector instead of a DeprecatedString to build up the return String.
editing/HTMLInterchange.h:

7:38 PM Changeset in webkit [30445] by eric@webkit.org

3 edits in trunk/WebCore

Reviewed by Oliver.

Remove m_drawingContext and change m_data to m_imageBuffer

html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): (WebCore::HTMLCanvasElement::reset): (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::createImageBuffer): (WebCore::HTMLCanvasElement::buffer): (WebCore::HTMLCanvasElement::createPlatformImage):
html/HTMLCanvasElement.h:

6:26 PM Changeset in webkit [30444] by pewtermoose@webkit.org

1 edit
10 adds in trunk/WebKitTools

2008-02-20 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Alp.

http://bugs.webkit.org/show_bug.cgi?id=17428 Reenable a Windows-based launcher

This patch reenables the venerable Spinneret application,
changing its name to match the other lanch applications.

WinLauncher: Added.
WinLauncher/WinLauncher.cpp: Added. (WinLauncherWebHost::updateAddressBar): (WinLauncherWebHost::QueryInterface): (WinLauncherWebHost::AddRef): (WinLauncherWebHost::Release): (resizeSubViews): (_tWinMain): (MyRegisterClass): (InitInstance): (WndProc): (MyEditProc): (About): (loadURL):
WinLauncher/WinLauncher.h: Added. (WinLauncherWebHost::WinLauncherWebHost): (WinLauncherWebHost::didStartProvisionalLoadForFrame): (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame): (WinLauncherWebHost::didFailProvisionalLoadWithError): (WinLauncherWebHost::didCommitLoadForFrame): (WinLauncherWebHost::didReceiveTitle): (WinLauncherWebHost::didReceiveIcon): (WinLauncherWebHost::didFinishLoadForFrame): (WinLauncherWebHost::didFailLoadWithError): (WinLauncherWebHost::didChangeLocationWithinPageForFrame): (WinLauncherWebHost::willPerformClientRedirectToURL): (WinLauncherWebHost::didCancelClientRedirectForFrame): (WinLauncherWebHost::willCloseFrame): (WinLauncherWebHost::windowScriptObjectAvailable):
WinLauncher/WinLauncher.ico: Added.
WinLauncher/WinLauncher.rc: Added.
WinLauncher/WinLauncher.vcproj: Added.
WinLauncher/resource.h: Added.
WinLauncher/small.ico: Added.
WinLauncher/stdafx.cpp: Added.
WinLauncher/stdafx.h: Added.

6:17 PM Changeset in webkit [30443] by andersca@apple.com

28 edits in trunk/WebCore

Reviewed by Sam.

Rename AtomicString::domString() to AtomicString::string().

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::getFontData):
dom/Attr.cpp: (WebCore::Attr::createTextChild):
dom/Comment.cpp: (WebCore::Comment::nodeName):
dom/Document.cpp: (WebCore::Document::recalcStyleSelector): (WebCore::Document::setHTMLWindowEventListener): (WebCore::Document::formElementsState):
dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute):
dom/Text.cpp: (WebCore::Text::nodeName):
editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer):
html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch):
html/HTMLElement.cpp: (WebCore::HTMLElement::nodeName): (WebCore::HTMLElement::setHTMLEventListener):
html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::getNamedFormItem):
html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): (WebCore::HTMLImageElement::isURLAttribute):
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute): (WebCore::HTMLLinkElement::tokenizeRelAttribute):
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isURLAttribute): (WebCore::HTMLObjectElement::containsJavaApplet):
html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::isURLAttribute):
html/HTMLParser.cpp: (WebCore::HTMLParser::handleIsindex):
html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::insertedIntoDocument): (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::parseMappedAttribute):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):
loader/FrameLoader.cpp: (WebCore::FrameLoader::saveDocumentState):
page/FrameTree.cpp: (WebCore::FrameTree::uniqueChildName):
platform/text/AtomicString.h: (WebCore::AtomicString::string): (WebCore::AtomicString::contains): (WebCore::AtomicString::find): (WebCore::AtomicString::startsWith): (WebCore::AtomicString::endsWith):
rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
svg/SVGElement.cpp: (WebCore::SVGElement::addSVGEventListener):
svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::addSVGWindowEventListener):
xml/XPathFunctions.cpp: (WebCore::XPath::FunLocalName::evaluate): (WebCore::XPath::FunNamespaceURI::evaluate): (WebCore::XPath::FunName::evaluate):

6:12 PM Changeset in webkit [30442] by pewtermoose@webkit.org

1 edit in trunk/WebCore/ChangeLog

Remove stray conflict marker

6:10 PM Changeset in webkit [30441] by pewtermoose@webkit.org

10 edits
2 copies
1 move
3 adds
1 delete in trunk/WebCore

2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Dan.

http://bugs.webkit.org/show_bug.cgi?id=17336
Provide implementations for Windows (Cairo) build of WebKit that
handles font formatting.

Split font implementation files to allow maximal code sharing between CG and Cairo back-ends.

WebCore.vcproj/WebCore.vcproj:
platform/graphics/SimpleFontData.h: Add signatures for private win initialization functions.
platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::platformInit): (WebCore::FontCache::createFontPlatformData):
platform/graphics/win/FontCairoWin.cpp: Removed. Universal version is now part of platform/graphics/cairo.
platform/graphics/win/FontCustomPlatformDataCairo.cpp: Added. (WebCore::FontCustomPlatformDataCairo::~FontCustomPlatformDataCairo): (WebCore::FontCustomPlatformDataCairo::fontPlatformData): (WebCore::releaseData): (WebCore::createFontCustomPlatformData):
platform/graphics/win/FontCustomPlatformDataCairo.h: Added. (WebCore::FontCustomPlatformDataCairo::FontCustomPlatformDataCairo):
platform/graphics/win/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::fontFace): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::operator==):
platform/graphics/win/FontPlatformDataCGWin.cpp: Copied from WebCore/platform/graphics/win/FontPlatformDataWin.cpp. (WebCore::FontPlatformData::platformDataInit):
platform/graphics/win/FontPlatformDataCairoWin.cpp: Added. (WebCore::FontPlatformData::platformDataInit): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::setFont):
platform/graphics/win/FontPlatformDataWin.cpp: Moved CG-specific code to FontPlatformDataCG.cpp. (WebCore::FontPlatformData::FontPlatformData):
platform/graphics/win/GlyphPageTreeNodeCGWin.cpp: Copied from WebCore/platform/graphics/win/GlyphPageTreeNodeWin.cpp.
platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp: Copied from WebCore/platform/graphics/win/GlyphPageTreeNodeWin.cpp. (WebCore::GlyphPage::fill):
platform/graphics/win/GlyphPageTreeNodeWin.cpp: Removed. Replaced with CG- and Cairo-specific versions.
platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::platformWidthForGlyph):
platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::platformWidthForGlyph): (WebCore::SimpleFontData::setFont):
platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::initGDIFont): (WebCore::SimpleFontData::platformCommonDestroy): (WebCore::SimpleFontData::widthForGDIGlyph):

6:03 PM Changeset in webkit [30440] by Darin Adler

2 edits in trunk/WebCore

Reviewed by Sam.

dom/Node.h: Took out unneeded forward declaration of TextStream.

6:01 PM Changeset in webkit [30439] by Darin Adler

2 edits in trunk/WebCore

Reviewed by Sam.

rendering/RenderObject.h: Took out unneeded forward declaration of TextStream.

5:59 PM Changeset in webkit [30438] by hyatt@apple.com

4 edits in trunk/WebCore

Fix for bug 16760, incorrect <object> MIME type handling and fallback
handling.

Reviewed by darin

html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::notifyFinished): If the image had an error, make sure to do <object> fallback.

html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderFallbackContent): Before doing fallback check if there is a MIME type mismatch between an image type and a non-image type. If so, detach and re-attach after storing the correct MIME type.

loader/loader.cpp: (WebCore::Loader::didReceiveData): Consider it an error when a 404 is encountered on a CachedResource load.

5:41 PM Changeset in webkit [30437] by andersca@apple.com

4 edits in trunk/WebCore

Reviewed by Sam.

StringImpl constructors used by AtomicString should start with a refcount of 1.

platform/text/AtomicString.cpp: (WebCore::AtomicString::add):
platform/text/AtomicString.h:
platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl):

5:06 PM Changeset in webkit [30436] by Darin Adler

2 edits in trunk/WebCore

bindings/js/kjs_navigator.cpp: (WebCore::needsYouTubeQuirk): Tweak comments.

4:55 PM Changeset in webkit [30435] by timothy@apple.com

1 copy in tags/Safari-5525.10

New tag.

3:54 PM Changeset in webkit [30434] by andersca@apple.com

16 edits in trunk/WebCore

Reviewed by Darin.

Change all refcounted classes in page/ to start with a refcount of 1.

page/BarInfo.cpp: (WebCore::BarInfo::BarInfo):
page/BarInfo.h: (WebCore::BarInfo::create):
page/Console.cpp: (WebCore::Console::Console):
page/Console.h: (WebCore::Console::create):
page/DOMSelection.cpp: (WebCore::DOMSelection::DOMSelection):
page/DOMSelection.h: (WebCore::DOMSelection::create):
page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::screen): (WebCore::DOMWindow::history): (WebCore::DOMWindow::locationbar): (WebCore::DOMWindow::menubar): (WebCore::DOMWindow::personalbar): (WebCore::DOMWindow::scrollbars): (WebCore::DOMWindow::statusbar): (WebCore::DOMWindow::toolbar): (WebCore::DOMWindow::console): (WebCore::DOMWindow::getSelection):
page/DOMWindow.h: (WebCore::DOMWindow::create):
page/Frame.cpp: (WebCore::Frame::domWindow):
page/History.cpp: (WebCore::History::History):
page/History.h: (WebCore::History::create):
page/InspectorController.cpp: (WebCore::InspectorResource::create): (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorDatabaseResource::create): (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::didOpenDatabase):
page/Plugin.h: (WebCore::Plugin::create): (WebCore::Plugin::Plugin):
page/Screen.cpp: (WebCore::Screen::Screen):
page/Screen.h: (WebCore::Screen::create):

3:04 PM Changeset in webkit [30433] by weinig@apple.com

9 edits in trunk

WebCore:

Reviewed by Darin and Geoff.

<rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack

WebCore.base.exp: Updated.

bindings/js/kjs_navigator.cpp: (WebCore::needsYouTubeQuirk): Added. Return true on Windows only when the quirk is needed. (WebCore::Navigator::getValueProperty): For the appVersion property, if needsYouTubeQuirk return true, then return the empty string.

page/Settings.cpp: (WebCore::Settings::Settings): Set m_needsSiteSpecificQuirks to false. (WebCore::Settings::setNeedsSiteSpecificQuirks): Added.
page/Settings.h: Added m_needsSiteSpecificQuirks. (WebCore::Settings::needsSiteSpecificQuirks): Added.

WebKit/mac:

Reviewed by Darin and Geoff.

WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack

WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Added a call to Settings::setNeedsSiteSpecificQuirks. There are currently no site-specific quirks on Mac, but we will propagate the state to WebCore to avoid possible mistakes later.

WebKit/win:

Reviewed by Darin and Geoff.

WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack

WebView.cpp: (WebView::notifyPreferencesChanged): Added a call to Settings::setNeedsSiteSpecificQuirks. (WebView::setAllowSiteSpecificHacks): Added a comment about the problem Darin noticed, where after you disable the site-specific hacks they persist until you open a new window or tweak some other preference.

2:57 PM Changeset in webkit [30432] by hyatt@apple.com

1 edit in trunk/WebCore/dom/DocumentType.cpp

Land additional doctype piece. toString fix of doctype.

2:47 PM Changeset in webkit [30431] by hyatt@apple.com

113 edits
15 adds in trunk

Fix for bug 12751, doctype nodes aren't part of the Document (Acid3).

Reviewed by Sam Weinig

Many tests added in fast/doctypes.

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument):
dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::setDocType): (WebCore::Document::attach): (WebCore::Document::getImageMap):
dom/Document.h: (WebCore::Document::doctype): (WebCore::Document::): (WebCore::Document::determineParseMode): (WebCore::Document::setParseMode): (WebCore::Document::parseMode): (WebCore::Document::inCompatMode): (WebCore::Document::inAlmostStrictMode): (WebCore::Document::inStrictMode):
dom/DocumentType.cpp: (WebCore::DocumentType::cloneNode): (WebCore::DocumentType::insertedIntoDocument): (WebCore::DocumentType::removedFromDocument):
dom/DocumentType.h:
dom/Node.cpp: (WebCore::Node::childAllowed):
dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged):
dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::internalSubset): (WebCore::):
editing/markup.cpp: (WebCore::appendStartMarkup):
html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer):
html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): (WebCore::HTMLDocument::childAllowed): (WebCore::HTMLDocument::determineParseMode):
html/HTMLDocument.h:
html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::parseMappedAttribute):
html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::parseMappedAttribute):
html/HTMLParser.cpp: (WebCore::HTMLParser::parseDoctypeToken):
html/HTMLParser.h:
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::parseDoctype): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::finish): (WebCore::HTMLTokenizer::processDoctypeToken):
html/HTMLTokenizer.h: (WebCore::): (WebCore::DoctypeToken::DoctypeToken): (WebCore::DoctypeToken::reset): (WebCore::DoctypeToken::state): (WebCore::DoctypeToken::setState): (WebCore::HTMLTokenizer::State::inDoctype): (WebCore::HTMLTokenizer::State::setInDoctype): (WebCore::HTMLTokenizer::State::needsSpecialWriteHandling): (WebCore::HTMLTokenizer::State::):
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addViewSourceDoctypeToken):
html/HTMLViewSourceDocument.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::write): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
page/Frame.cpp: (WebCore::Frame::documentTypeString):
page/inspector/utilities.js:
xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):

2:28 PM Changeset in webkit [30430] by andersca@apple.com

60 edits in trunk/WebCore

Reviewed by Darin.

Change most SVG related classes to start out with a ref count of 1.

bindings/js/JSSVGPointListCustom.cpp: (WebCore::JSSVGPointList::initialize): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::appendItem):
bindings/js/JSSVGTransformListCustom.cpp: (WebCore::JSSVGTransformList::initialize): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::appendItem):
rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGCharOnPath::create): (WebCore::SVGCharOnPath::SVGCharOnPath):
rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseBeginOrEndValue):
svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::canvasResource):
svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::childNodes):
svg/SVGElementInstanceList.cpp: (WebCore::SVGElementInstanceList::SVGElementInstanceList):
svg/SVGElementInstanceList.h: (WebCore::SVGElementInstanceList::create):
svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::SVGFitToViewBox):
svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::canvasResource):
svg/SVGImageElement.cpp: (WebCore::SVGImageElement::SVGImageElement):
svg/SVGLengthList.h: (WebCore::SVGLengthList::create):
svg/SVGList.h: (WebCore::SVGList::SVGList): (WebCore::SVGPODListItem::create): (WebCore::SVGPODListItem::copy): (WebCore::SVGPODListItem::SVGPODListItem): (WebCore::SVGPODList::initialize): (WebCore::SVGPODList::insertItemBefore): (WebCore::SVGPODList::replaceItem): (WebCore::SVGPODList::appendItem): (WebCore::SVGPODList::SVGPODList):
svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource):
svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::canvasResource):
svg/SVGNumberList.h: (WebCore::SVGNumberList::create):
svg/SVGPathElement.cpp: (WebCore::SVGPathElement::createSVGPathSegClosePath): (WebCore::SVGPathElement::createSVGPathSegMovetoAbs): (WebCore::SVGPathElement::createSVGPathSegMovetoRel): (WebCore::SVGPathElement::createSVGPathSegLinetoAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): (WebCore::SVGPathElement::createSVGPathSegArcAbs): (WebCore::SVGPathElement::createSVGPathSegArcRel): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel): (WebCore::SVGPathElement::pathSegList):
svg/SVGPathElement.h:
svg/SVGPathSeg.h: (WebCore::SVGPathSeg::SVGPathSeg):
svg/SVGPathSegArc.h: (WebCore::SVGPathSegArcAbs::create): (WebCore::SVGPathSegArcRel::create):
svg/SVGPathSegClosePath.h: (WebCore::SVGPathSegClosePath::create):
svg/SVGPathSegCurvetoCubic.h: (WebCore::SVGPathSegCurvetoCubicAbs::create): (WebCore::SVGPathSegCurvetoCubicRel::create):
svg/SVGPathSegCurvetoCubicSmooth.h: (WebCore::SVGPathSegCurvetoCubicSmoothAbs::create): (WebCore::SVGPathSegCurvetoCubicSmoothRel::create):
svg/SVGPathSegCurvetoQuadratic.h: (WebCore::SVGPathSegCurvetoQuadraticAbs::create): (WebCore::SVGPathSegCurvetoQuadraticRel::create):
svg/SVGPathSegCurvetoQuadraticSmooth.h: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::create): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::create):
svg/SVGPathSegLineto.h: (WebCore::SVGPathSegLinetoAbs::create): (WebCore::SVGPathSegLinetoRel::create):
svg/SVGPathSegLinetoHorizontal.h: (WebCore::SVGPathSegLinetoHorizontalAbs::create): (WebCore::SVGPathSegLinetoHorizontalRel::create):
svg/SVGPathSegLinetoVertical.h: (WebCore::SVGPathSegLinetoVerticalAbs::create): (WebCore::SVGPathSegLinetoVerticalRel::create):
svg/SVGPathSegList.h: (WebCore::SVGPathSegList::create):
svg/SVGPathSegMoveto.h: (WebCore::SVGPathSegMovetoAbs::create): (WebCore::SVGPathSegMovetoRel::create):
svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::canvasResource):
svg/SVGPointList.h: (WebCore::SVGPointList::create):
svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::points):
svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
svg/SVGPreserveAspectRatio.h: (WebCore::SVGPreserveAspectRatio::create):
svg/SVGRenderingIntent.h: (WebCore::SVGRenderingIntent::SVGRenderingIntent):
svg/SVGStringList.h: (WebCore::SVGStringList::create):
svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement):
svg/SVGTests.cpp: (WebCore::SVGTests::requiredFeatures): (WebCore::SVGTests::requiredExtensions): (WebCore::SVGTests::systemLanguage):
svg/SVGTextElement.cpp: (WebCore::SVGTextElement::SVGTextElement):
svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
svg/SVGTransformList.h: (WebCore::SVGTransformList::create):
svg/SVGUnitTypes.h: (WebCore::SVGUnitTypes::SVGUnitTypes):
svg/SVGViewElement.cpp: (WebCore::SVGViewElement::viewTarget):
svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::SVGViewSpec):
svg/graphics/SVGPaintServer.cpp: (WebCore::SVGPaintServer::sharedSolidPaintServer):
svg/graphics/SVGPaintServer.h:
svg/graphics/SVGPaintServerGradient.h: (WebCore::SVGPaintServerGradient::SharedStopCache::create): (WebCore::SVGPaintServerGradient::SharedStopCache::SharedStopCache):
svg/graphics/SVGPaintServerLinearGradient.h: (WebCore::SVGPaintServerLinearGradient::create):
svg/graphics/SVGPaintServerPattern.h: (WebCore::SVGPaintServerPattern::create):
svg/graphics/SVGPaintServerRadialGradient.h: (WebCore::SVGPaintServerRadialGradient::create):
svg/graphics/SVGPaintServerSolid.h: (WebCore::SVGPaintServerSolid::create):
svg/graphics/SVGResource.cpp: (WebCore::SVGResource::SVGResource):
svg/graphics/SVGResource.h:
svg/graphics/SVGResourceClipper.h: (WebCore::SVGResourceClipper::create):
svg/graphics/SVGResourceMarker.h: (WebCore::SVGResourceMarker::create):
svg/graphics/SVGResourceMasker.h: (WebCore::SVGResourceMasker::create):
svg/graphics/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):

1:36 PM Changeset in webkit [30429] by Darin Adler

7 edits in trunk/WebCore

Reviewed by Sam.

make conversion from CSS ParseString to String and AtomicString automatic and remove all the explicit calls to do the conversion

fix CSS parsing to do fewer allocations, mostly by using the equalIgnoringCase function in CSSParser

css/CSSGrammar.y: Take out all the explicit atomicString and domString calls now that ParseString knows how to convert itself.

css/CSSParser.cpp: (WebCore::equal): Added. (WebCore::equalIgnoringCase): Allow non-lettters. (WebCore::ParseString::lower): Used charactersAreAllASCII. (WebCore::unitFromString): Use equal. (WebCore::CSSParser::parseValue): Removed unneeded call to domString. (WebCore::CSSParser::parseContent): Use equalIgnoringCase. (WebCore::CSSParser::parseBackgroundImage): Removed unneeded call to domString. (WebCore::CSSParser::parseTransitionTimingFunction): Use equalIgnoringCase. (WebCore::CSSParser::parseDashboardRegions): More of the same. (WebCore::CSSParser::parseCounterContent): Ditto. (WebCore::CSSParser::parseShape): Use equalIgnoringCase. (WebCore::CSSParser::parseFontFamily): Removed unneeded calls to domString. (WebCore::CSSParser::parseFontFaceSrc): More. (WebCore::CSSParser::parseFontFaceUnicodeRange): More. (WebCore::CSSParser::parseColor): Don't lowercase here -- setNamedColor now handles the case folding. (WebCore::CSSParser::parseColorFromValue): More. (WebCore::CSSParser::parseBorderImage): More. (WebCore::CSSParser::parseCounter): More. (WebCore::TransformOperationInfo::TransformOperationInfo): More. (WebCore::CSSParser::parseTransform): More. (WebCore::CSSParser::createCharsetRule): More. (WebCore::CSSParser::createImportRule): More.

css/CSSParser.h: Removed domString and atomicString functions. (WebCore::ParseString::operator String): Added. Allows conversion to String without an explicit function call. (WebCore::ParseString::operator AtomicString): Ditto.

css/MediaQueryExp.cpp: (WebCore::MediaQueryExp::MediaQueryExp): Removed a call to domString.
css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): Removed calls to domString.

platform/graphics/Color.cpp: (WebCore::findNamedColor): Call toASCIILower on each character as we copy it into the 8-bit character buffer to make the operation fold case.

1:05 PM Changeset in webkit [30428] by timothy@apple.com

2 edits in branches/Safari-3-1-branch/WebCore

Merged r30422 and r30423.

1:03 PM Changeset in webkit [30427] by hyatt@apple.com

1 edit in trunk/LayoutTests/svg/dynamic-updates/resources/SVGTestCase.js

Fix a bug in this SVG test harness. Make sure it uses document.documentElement instead of document.firstChild.

12:59 PM Changeset in webkit [30426] by timothy@apple.com

2 edits in branches/Safari-3-1-branch/WebKit/win

Merge r30400.

9:48 AM Changeset in webkit [30425] by justin.garcia@apple.com

3 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore changes

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): The common case here is where there are no special elements. Avoid creating VisiblePositions in that case. Additionally, this change postpones the more expensive creation of an upstream VisiblePosition until the last possible moment. (WebCore::DeleteSelectionCommand::saveTypingStyleState): (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Add an early return for a common case: deleting characters that are all inside the same text node. In that case the style at the start of the selection will not change during the delete, so there is no need to save/recompute it. (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Early return before VisiblePosition creation if the ends of the selection aren't enclosed by an anchor.
editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping): Early return if spell checking isn't enabled.

4:35 AM Changeset in webkit [30424] by ap@webkit.org

3 edits
2 adds in trunk

Incorporates some improvements made by Dan Bernstein.

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=17106
<rdar://problem/5750722> Debug build ASSERTs on page load

Test: fast/encoding/GBK/close-gbk-converter.html

platform/text/TextCodecICU.cpp: (WebCore::getGbkEscape): Changed to use a switch instead of a HashMap, as there are only four values. (WebCore::gbkCallbackEscape): Check the reason why the function is called, and do not attempt getting an escape character if it's not UCNV_UNASSIGNED. (WebCore::gbkCallbackSubstitute): Ditto.

3:39 AM Changeset in webkit [30423] by ap@webkit.org

2 edits in trunk/WebCore

Build fix.

xml/XMLHttpRequest.cpp: (WebCore::isSafeRequestHeader): (WebCore::XMLHttpRequest::setRequestHeader):

3:10 AM Changeset in webkit [30422] by ap@webkit.org

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5749455> Unable to set the Referer header in Dashboard using XMLHttpRequest

Cannot be tested in DRT.

xml/XMLHttpRequest.cpp: (WebCore::canSetRequestHeader): Assume that a request that can load local files can also set any headers.

12:08 AM BuildingCairoOnWindows edited by bfulgham@macports.org

(diff)

Feb 19, 2008:

6:17 PM Changeset in webkit [30421] by Darin Adler

6 edits in trunk/WebCore

Reviewed by Sam.

removed use of DeprecatedString for font family names

css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Update for name change.
css/CSSParser.cpp: (WebCore::CSSParser::parseFontFamily): Update to use new appendSpaceSeparated function and String rather than DeprecatedString.
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Updated for name change.
css/FontFamilyValue.cpp: (WebCore::FontFamilyValue::FontFamilyValue): Replaced code using a regular expression with code that does the same thing more efficiently. (WebCore::FontFamilyValue::appendSpaceSeparated): Added. (WebCore::FontFamilyValue::cssText): Updated for name change.
css/FontFamilyValue.h: Changed DeprecatedString to String. Renamed fontName to familyName and parsedFontName to m_familyName. Removed unused genericFamilyType and m_genericFamilyType. Added appendSpaceSeparated so that m_familyName can be private instead of public.

6:07 PM Changeset in webkit [30420] by Darin Adler

2 edits in trunk/WebCore

fix build when SVG is not enabled

rendering/RenderTreeAsText.cpp: Added include of "TextStream.h".

5:55 PM Changeset in webkit [30419] by andersca@apple.com

23 edits in trunk/WebCore

Reviewed by Darin.

Change all classes in xml/ to start out with a ref count of 1.

bindings/js/JSCustomXPathNSResolver.h:
bindings/js/JSXMLHttpRequest.cpp: (WebCore::JSXMLHttpRequest::JSXMLHttpRequest):
bindings/js/JSXSLTProcessor.cpp: (WebCore::JSXSLTProcessor::JSXSLTProcessor):
bindings/objc/DOMCustomXPathNSResolver.h: (WebCore::DOMCustomXPathNSResolver::create):
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorObjC.pm:
dom/Document.cpp: (WebCore::Document::applyXSLTransform): (WebCore::Document::createExpression): (WebCore::Document::createNSResolver): (WebCore::Document::evaluate):
xml/DOMParser.h: (WebCore::DOMParser::create): (WebCore::DOMParser::DOMParser):
xml/NativeXPathNSResolver.h: (WebCore::NativeXPathNSResolver::create):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest):
xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::create):
xml/XMLSerializer.h: (WebCore::XMLSerializer::create): (WebCore::XMLSerializer::XMLSerializer):
xml/XPathEvaluator.cpp: (WebCore::XPathEvaluator::createNSResolver):
xml/XPathEvaluator.h: (WebCore::XPathEvaluator::create): (WebCore::XPathEvaluator::XPathEvaluator):
xml/XPathExpression.cpp: (WebCore::XPathExpression::createExpression): (WebCore::XPathExpression::evaluate):
xml/XPathExpression.h: (WebCore::XPathExpression::create): (WebCore::XPathExpression::XPathExpression):
xml/XPathNSResolver.h:
xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult):
xml/XPathResult.h: (WebCore::XPathResult::create):
xml/XPathValue.cpp: (WebCore::XPath::Value::modifiableNodeSet):
xml/XPathValue.h: (WebCore::XPath::ValueData::create): (WebCore::XPath::ValueData::ValueData): (WebCore::XPath::Value::Value):
xml/XSLTProcessor.h: (WebCore::XSLTProcessor::create): (WebCore::XSLTProcessor::XSLTProcessor):

5:51 PM Changeset in webkit [30418] by Darin Adler

9 edits in trunk

WebCore:

Reviewed by Sam.

Trimmed down TextStream and weaned it from DeprecatedString.

page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge renderTreeAsExternalRepresentation]): Removed now-unneeded call to getNSString.

platform/text/TextStream.cpp: Removed unused functions. Use snprintf instead of sprintf, for better security. (WebCore::TextStream::release): Added.
platform/text/TextStream.h: Removed lots of unneeded stuff.

rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): Changed to use String instead of DeprecatedString.
rendering/RenderTreeAsText.h: Ditto.

rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGInlineTextBox): Use "\n" instead of endl. (WebCore::write): Ditto. (WebCore::writeRenderResources): Ditto.

WebKit/win:

Reviewed by Sam.

WebFrame.cpp: (WebFrame::renderTreeAsExternalRepresentation): Changed to use String instead of DeprecatedString.

5:43 PM Changeset in webkit [30417] by justin.garcia@apple.com

2 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore changes

This brings performance on the phone back to old levels. Andre and I are doing
some formal testing to see exactly where we stand.

dom/Position.cpp: (WebCore::enclosingBlockIgnoringEditability): Added. This is enclosingBlock without the expensive editability checks. upstream and downstream can avoid those because they do their own editability checking. (WebCore::Position::upstream): (WebCore::Position::downstream):

4:41 PM Changeset in webkit [30416] by harrison@apple.com

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3663560> AXLink for a "name" (anchor) on same page should include an AXLinkedUIElementAttribute

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject linkedUIElement]): Returns the linked-to AX object (if the specified one is ignored by accessibility, returns the next un-ignored one by traversing the DOM).

(-[WebCoreAXObject accessibilityAttributeNames]):
(-[WebCoreAXObject accessibilityAttributeValue:]):
Support NSAccessibilityLinkedUIElementsAttribute.

4:00 PM Changeset in webkit [30415] by Darin Adler

39 edits in trunk/WebCore

Reviewed by Sam.

Removed old debugging aids, Node::dump, RenderObject::dump, and RenderObject::information, that used DeprecatedString.

dom/CharacterData.cpp: Removed override of Node::dump.
dom/CharacterData.h: Ditto.
dom/Element.cpp: Ditto.
dom/Element.h: Ditto.
dom/EventTargetNode.cpp: Ditto.
dom/EventTargetNode.h: Ditto.
dom/Node.cpp: Removed Node::dump.
dom/Node.h: Ditto.

rendering/RenderBlock.cpp: Removed override of RenderObject::dump.
rendering/RenderBlock.h: Ditto.
rendering/RenderFrameSet.cpp: Ditto.
rendering/RenderFrameSet.h: Ditto.
rendering/RenderObject.cpp: Removed RenderObject::dump and RenderObject::information.
rendering/RenderObject.h: Ditto.
rendering/RenderTable.cpp: Removed override of RenderObject::dump.
rendering/RenderTable.h: Ditto.
rendering/RenderTableCell.cpp: Ditto.
rendering/RenderTableCell.h: Ditto.
rendering/RenderTableCol.cpp: Ditto.
rendering/RenderTableCol.h: Ditto.
rendering/RenderTableSection.cpp: Ditto.
rendering/RenderTableSection.h: Ditto.

rendering/RenderTreeAsText.h: Removed unneeded include of TextStream.h and added forward declarations as appropriate.

svg/SVGSVGElement.cpp: Removed unneeded include of TextStream.h.
svg/graphics/SVGResourceClipper.cpp: And here.
svg/graphics/SVGResourceFilter.cpp: Ditto.
svg/graphics/filters/SVGFEBlend.cpp: Ditto.
svg/graphics/filters/SVGFEComponentTransfer.cpp: Ditto.
svg/graphics/filters/SVGFEComposite.cpp: Ditto.
svg/graphics/filters/SVGFEDiffuseLighting.cpp: Ditto.
svg/graphics/filters/SVGFEGaussianBlur.cpp: Ditto.
svg/graphics/filters/SVGFEImage.cpp: Ditto.
svg/graphics/filters/SVGFEMerge.cpp: Ditto.
svg/graphics/filters/SVGFEMorphology.cpp: Ditto.
svg/graphics/filters/SVGFEOffset.cpp: Ditto.
svg/graphics/filters/SVGFESpecularLighting.cpp: Ditto.
svg/graphics/filters/SVGFETurbulence.cpp: Ditto.
svg/graphics/filters/SVGFilterEffect.cpp: Ditto.

3:26 PM Changeset in webkit [30414] by Beth Dakin

3 edits
4 adds in trunk

WebCore:

Reviewed by Sam.

Fix for <rdar://problem/5729674> Seed: Crash in
RenderButton::setStyle at http://www.dinorpg.com

Inputs should not honor first-letter.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):

LayoutTests:

Reviewed by Sam.

Test for <rdar://problem/5729674> Seed: Crash in
RenderButton::setStyle at http://www.dinorpg.com

fast/forms/input-first-letter.html: Added.
platform/mac/fast/forms/input-first-letter-expected.checksum: Added.
platform/mac/fast/forms/input-first-letter-expected.png: Added.
platform/mac/fast/forms/input-first-letter-expected.txt: Added.

3:23 PM BuildingCairoOnWindows edited by bfulgham@macports.org

(diff)

2:09 PM Changeset in webkit [30413] by andersca@apple.com

5 edits in trunk/JavaScriptCore

Reviewed by Darin.

Change OpaqueJSClass and RootObject to start with a ref count of 1.

API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): (OpaqueJSClass::createNoAutomaticPrototype): (OpaqueJSClass::create):
API/JSClassRef.h:
API/JSObjectRef.cpp: (JSClassCreate):
bindings/runtime_root.cpp: (KJS::Bindings::RootObject::create): (KJS::Bindings::RootObject::RootObject):

1:13 PM Changeset in webkit [30412] by mitz@apple.com

11 edits
4 adds in trunk

WebCore:

Reviewed by Darin Adler.

fix <rdar://problem/5637569> CrashTracer: [REGRESSION] 620 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::setStaticY + 15

Test: fast/text/wbr-styled.html

Changed RenderWordBreak to inherit from RenderText instead of
RenderInline.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
rendering/RenderFlow.h:
rendering/RenderText.cpp: (WebCore::RenderText::renderName): (WebCore::RenderText::isTextFragment): (WebCore::RenderText::isWordBreak):
rendering/RenderText.h:
rendering/RenderWordBreak.cpp: (WebCore::RenderWordBreak::RenderWordBreak):
rendering/RenderWordBreak.h:
rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):

LayoutTests:

Reviewed by Darin Adler.

test for <rdar://problem/5637569> CrashTracer: [REGRESSION] 620 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::setStaticY + 15

fast/text/wbr-styled.html: Added.
platform/mac-leopard/fast/text/wbr-styled-expected.checksum: Added.
platform/mac-leopard/fast/text/wbr-styled-expected.png: Added.
platform/mac/fast/css-generated-content/wbr-with-before-content-expected.txt:
platform/mac/fast/text/wbr-pre-expected.txt:
platform/mac/fast/text/wbr-styled-expected.txt: Added.

11:42 AM Changeset in webkit [30411] by andersca@apple.com

1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog

11:42 AM Changeset in webkit [30410] by andersca@apple.com

10 edits in trunk

WebCore:

Reviewed by Darin.

WARNING: NO TEST CASES ADDED OR CHANGED

ChangeLog:
WebCore.base.exp:
loader/mac/LoaderNSURLExtras.h:
loader/mac/LoaderNSURLExtras.m: Move unused functions to WebKit (where they are used)

(vectorContainsString):
Use const references.

platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm: Remove wkNSURLProtocolClassForReqest.

WebKit/mac:

Reviewed by Darin.

Move back WebKit methods that were unused in WebCore.

Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:]): (+[NSURL _web_URLWithData:relativeToURL:]): (-[NSURL _web_originalData]): (-[NSURL _web_originalDataAsString]): (-[NSURL _web_isEmpty]): (-[NSURL _webkit_canonicalize]): (-[NSURL _webkit_URLByRemovingComponent:]): (-[NSURL _webkit_URLByRemovingFragment]): (-[NSURL _webkit_URLByRemovingResourceSpecifier]): (-[NSURL _webkit_isFileURL]): (-[NSString _webkit_isFileURL]):
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setTitle):
WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

11:28 AM Changeset in webkit [30409] by justin.garcia@apple.com

2 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore

These changes bring deleting performance back to old levels on the phone
except for deleting the first space to the right of a word, which we are
still working on.

dom/Position.cpp: (WebCore::Position::upstream): Avoid the use of enclosingBlock when determining if we have left the original enclosing block or entered a new one, and avoid rootEditableElement for determining if we have changed editability. These operations are expensive. (WebCore::Position::downstream): Ditto.

11:16 AM Changeset in webkit [30408] by Darin Adler

6 edits in trunk

JavaScriptCore:

Rubber stamped by Anders.

removed explicit initialization to 1 for RefCounted; that's now the default

kjs/regexp.cpp: (KJS::RegExp::RegExp): Removed RefCounted initializer.

WebCore:

Rubber stamped by Anders.

removed explicit initialization to 1 for RefCounted; that's now the default

loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): Removed RefCounted initializer.
platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): Ditto.
platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Ditto.

11:08 AM Changeset in webkit [30407] by beidson@apple.com

2 edits in trunk/WebKitTools

Reviewed by Geoff

Fixed a bug in DRT --threaded mode

DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: (startJavaScriptThreads): Don't detach the newly created thread. The later call to stopJavaScriptThreads() tries to pthread_join() each thread that had been created, but you can't join a detached thread!

11:06 AM Changeset in webkit [30406] by Darin Adler

2 edits in trunk/JavaScriptCore

Reviewed by Anders.

next step for http://bugs.webkit.org/show_bug.cgi?id=17257 start ref counts at 1 instead of 0 for speed

wtf/RefCounted.h: (WTF::RefCounted::RefCounted): Have refcounts default to 1. This allows us to start removing the explicit initialization of RefCounted from classes and eventually we can remove the ability to have the initial count of 0 entirely.

10:25 AM Changeset in webkit [30405] by andersca@apple.com

6 edits in trunk/WebCore

Reviewed by Darin.

Make ResourceLoader and ResourceHandle start out with a refcount of 1.

loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::create):
loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::create):
loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader):
loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):

5:05 AM Changeset in webkit [30404] by alp@webkit.org

4 edits in trunk/WebCore

2008-02-19 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=16863
[GTK] tab focusing doesn't work

GDK_MOD2_MASK doesn't always mean meta so we can't use it to identify
the meta key state.

Use GDK_META_MASK where available, otherwise do not support the meta
key. This matches the behaviour of other applications.

Also add a comment noting that the platform event constructors need to
be kept in sync (it's not obvious that there are multiple places that
check the key state).

platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
platform/gtk/MouseEventGtk.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed