⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 22, 2008:

11:52 PM Changeset in webkit [30517] by ap@webkit.org
  • 8 edits in trunk/LayoutTests

Reviewed by Darin.

A few tweaks to PCRE-based regex test suite.

  • fast/regex/pcre-test-runner.js: Added support for global regexes. Emulate PCRE test runner more precisely by trimming trailing whitespace from some lines.
  • fast/regex/test1-expected.txt:
  • fast/regex/test4-expected.txt:
  • fast/regex/testinput1:
  • fast/regex/testinput4:
  • fast/regex/testoutput1:
  • fast/regex/testoutput4: Updated to PCRE 7.6.
11:46 PM Changeset in webkit [30516] by mitz@apple.com
  • 30 edits in trunk/LayoutTests
  • update Tiger expected results following r30431
  • platform/mac-tiger/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/mac-tiger/svg/custom/foreignObject-crash-on-hover-expected.txt:
  • platform/mac-tiger/svg/custom/text-dom-01-f-expected.txt:
  • platform/mac-tiger/svg/custom/text-hit-test-expected.txt:
  • platform/mac-tiger/svg/text/text-align-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-align-02-b-expected.txt:
  • platform/mac-tiger/svg/text/text-align-03-b-expected.txt:
  • platform/mac-tiger/svg/text/text-align-04-b-expected.txt:
  • platform/mac-tiger/svg/text/text-align-05-b-expected.txt:
  • platform/mac-tiger/svg/text/text-align-06-b-expected.txt:
  • platform/mac-tiger/svg/text/text-altglyph-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-deco-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-fonts-01-t-expected.txt:
  • platform/mac-tiger/svg/text/text-fonts-02-t-expected.txt:
  • platform/mac-tiger/svg/text/text-path-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-spacing-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-text-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-text-03-b-expected.txt:
  • platform/mac-tiger/svg/text/text-text-04-t-expected.txt:
  • platform/mac-tiger/svg/text/text-text-05-t-expected.txt:
  • platform/mac-tiger/svg/text/text-text-06-t-expected.txt:
  • platform/mac-tiger/svg/text/text-text-07-t-expected.txt:
  • platform/mac-tiger/svg/text/text-text-08-b-expected.txt:
  • platform/mac-tiger/svg/text/text-tref-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-tselect-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-tselect-02-f-expected.txt:
  • platform/mac-tiger/svg/text/text-tspan-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-ws-01-t-expected.txt:
  • platform/mac-tiger/svg/text/text-ws-02-t-expected.txt:
9:14 PM Changeset in webkit [30515] by justin.garcia@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Anders Carlsson.

<rdar://problem/5714333> Add document.getSelection()


Add a synonym for window.getSelection() that FF supports. There were requests in
this bugs dupes to also support the IE only document.selection, but IE's Selection
object is too different than ours currently for that to be safe (specifically, we
don't support enough of IE's TextRange methods on our DOM Range object yet). I
filed <rdar://problem/5761233> to cover that.

  • dom/Document.cpp: (WebCore::Document::getSelection): Added.
  • dom/Document.h:
  • dom/Document.idl: Ditto. JS only since this is about web compatibility.

LayoutTests:

Reviewed by Anders.


<rdar://problem/5714333> Add document.getSelection()

  • editing/selection/5714333-expected.txt: Added.
  • editing/selection/5714333.html: Added.
9:09 PM Changeset in webkit [30514] by oliver@apple.com
  • 2 edits in trunk/WebCore

WX build fixes

8:18 PM Changeset in webkit [30513] by mrowe@apple.com
  • 7 edits in trunk/WebCore

Roll out r30500 as it breaks non-Windows use of Cairo.

7:31 PM Changeset in webkit [30512] by oliver@apple.com
  • 4 edits in trunk/WebCore

Once more with the cairo/qt/wx build fixing

7:09 PM Changeset in webkit [30511] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Windows build fix. Add missing include of DeprecatedCString.h and sort existing includes.

7:03 PM Changeset in webkit [30510] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Speculative Windows build fix. Add missing include of DeprecatedCString.h and sort existing includes.

6:15 PM Changeset in webkit [30509] by oliver@apple.com
  • 2 edits in trunk/WebCore

Build fix for windows, wx and qt

6:04 PM Changeset in webkit [30508] by oliver@apple.com
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (build fix).

Unbreak windows vcproj

  • WebCore.vcproj/WebCore.vcproj:
5:27 PM Changeset in webkit [30507] by weinig@apple.com
  • 2 edits in trunk/WebKit/qt

Fix Qt build.

  • Api/qwebhistoryinterface.cpp:
5:16 PM Changeset in webkit [30506] by oliver@apple.com
  • 19 edits
    12 adds in trunk

Bug 17486: Support HTML5 Canvas.getImageData API
Support Canvas.getImageData and Canvas.createImageData

Reviewed by Sam W.

This patch adds support for all the pixel reading portions
of the HTML5 Canvas spec. There are two new types ImageData
and CanvasPixelArray which are used to provide the HTML5
ImageData object, and the required semantics for assignment
to the ImageData data array.

We only implement the CG version of ImageBuffer::getImageData,
but the logic is null safe, so this will not introduce any
crashes into other platforms, unfortunately it will result in
JS Object detection "lying" on non-CG platforms.

5:14 PM Changeset in webkit [30505] by mrowe@apple.com
  • 4 edits in tags/Safari-5525.11.1

Versioning.

5:14 PM Changeset in webkit [30504] by mrowe@apple.com
  • 2 edits in tags/Safari-5525.11.1/WebCore

Merge r30502.

5:07 PM Changeset in webkit [30503] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.11.1

New tag.

5:06 PM Changeset in webkit [30502] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

2008-02-22 Mark Rowe <​mrowe@apple.com>

Build fix.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Qualify references to symbols in the KJS namespace.
4:55 PM Changeset in webkit [30501] by weinig@apple.com
  • 32 edits
    4 deletes in trunk

WebCore:

Rubber-stamped by Adam Roben.

Rid the project of the Devil known as DeprecatedString!

  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • dom/Node.h:
  • html/HTMLFormElement.cpp:
  • platform/DeprecatedString.cpp: Removed.
  • platform/DeprecatedString.h: Removed.
  • platform/graphics/qt/IconQt.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  • platform/gtk/CookieJarGtk.cpp:
  • platform/gtk/CursorGtk.cpp:
  • platform/gtk/KeyEventGtk.cpp:
  • platform/mac/DeprecatedStringMac.mm: Removed.
  • platform/network/qt/ResourceHandleQt.cpp:
  • platform/network/win/CookieJarWin.cpp: (WebCore::cookies):
  • platform/qt/ClipboardQt.cpp:
  • platform/qt/CookieJarQt.cpp:
  • platform/qt/CursorQt.cpp:
  • platform/symbian/DeprecatedStringSymbian.cpp: Removed.
  • platform/text/AtomicString.cpp:
  • platform/text/AtomicString.h:
  • platform/text/PlatformString.h:
  • platform/text/String.cpp:
  • platform/text/StringImpl.cpp:
  • platform/text/qt/StringQt.cpp: (WebCore::String::String):
  • platform/text/wx/StringWx.cpp:
  • platform/win/BString.cpp:
  • platform/win/BString.h:
  • platform/win/PasteboardWin.cpp:

WebKit/qt:

Rubber-stamped by Adam Roben.

Rid the project of the Devil known as DeprecatedString!

  • Api/qwebhistory.cpp:
  • Api/qwebhistoryinterface.cpp:
4:23 PM Changeset in webkit [30500] by pewtermoose@webkit.org
  • 7 edits in trunk/WebCore

2008-02-22 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=17442
Correct the Windows Cairo implementation of GraphicsContext so
that Windows 'WorldTransform' is kept in sync with the Cairo
transformations.

Also corrects an uninitialized variable in the Cairo Windows
image drag handler.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: Modify methods to call GraphicsContextPlatformPrivate calls, just as is done for the CoreGraphics version. These calls are nop's for everything but Windows. (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::concatCTM): Re-enable for Windows (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/win/GraphicsContextCGWin.cpp: Move common code for handling WorldTransform calls to parent class.
  • platform/graphics/win/GraphicsContextCairoWin.cpp: Add common code for handling WorldTransform calls. (WebCore::GraphicsContextPlatformPrivate::concatCTM): Change implementation so that it only handles WorldTransform. The Cairo update is done in GraphicsContextCairo.cpp
  • platform/graphics/win/GraphicsContextWin.cpp: Call platform-private methods to keep WorldTransform in sync. (WebCore::GraphicsContextPlatformPrivate::save): (WebCore::GraphicsContextPlatformPrivate::restore): (WebCore::GraphicsContextPlatformPrivate::clip): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate):
  • platform/win/DragImageCairoWin.cpp: (WebCore::createDragImageFromImage): Correct uninitialized value
4:16 PM Changeset in webkit [30499] by weinig@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Geoff Garen.

  • Remove use of DeprecatedString in CSSStyleSelector.
  • css/CSSStyleSelector.cpp: (WebCore::findHash): Removed. Use find instead. (WebCore::findSlashDotDotSlash): Changed to take a UChar* and a length. (WebCore::findSlashSlash): Ditto. (WebCore::findSlashDotSlash): Ditto. (WebCore::containsColonSlashSlash): Ditto. (WebCore::cleanPath): Change to operate on a String. (WebCore::checkPseudoState): Changed to use a Vector as a buffer.
3:51 PM Changeset in webkit [30498] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch

Versioning.

3:50 PM Changeset in webkit [30497] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.11

New tag.

3:49 PM Changeset in webkit [30496] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch

Versioning.

3:39 PM Changeset in webkit [30495] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30493.

3:39 PM Changeset in webkit [30494] by mrowe@apple.com
  • 5 edits
    2 deletes in branches/Safari-3-1-branch

Merge r30492.

3:16 PM Changeset in webkit [30493] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.


Fixed <rdar://problem/5057509> Repro leak of JSXMLHttpRequest and
associated objects @ www.viamichelin.it, which was probably an underlying
cause of <rdar://problem/5744037> Gmail out of memory (17455)


If SubresourceLoader::create returned NULL, we would ref() / gcProtect()
the XMLHttpRequest but think we hadn't, therefore never
calling deref() / gcUnprotect().


This could happen at gmail.com, since gmail.com attempts to send
XMLHttpRequests from unload handlers in order to gather usage statistics.
(According to comments in the code, SubresourceLoader::create returns
NULL when called from an unload handler.)

The solution is to ref() / gcProtect() only if SubresourceLoader::create
doesn't return NULL. This make sense, since we only need to protect the
request as long as it has an outstanding network transaction.


  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::send):
3:16 PM Changeset in webkit [30492] by ggaren@apple.com
  • 5 edits
    2 deletes in trunk

JavaScriptCore:

Reviewed by Sam Weinig.


Partial fix for <rdar://problem/5744037> Gmail out of memory (17455)


I'm removing KJS_MEM_LIMIT for the following reasons:


  • We have a few reports of KJS_MEM_LIMIT breaking important web applications, like GMail and Google Reader. (For example, if you simply open 12 GMail tabs, tab #12 will hit the limit.)
  • Firefox has no discernable JS object count limit, so any limit, even a large one, is a potential compatibility problem.


  • KJS_MEM_LIMIT does not protect against malicious memory allocation, since there are many ways to maliciously allocate memory without increasing the JS object count.


  • KJS_MEM_LIMIT is already mostly broken, since it only aborts the script that breaches the limit, not any subsequent scripts.


  • We've never gotten bug reports about websites that would have benefited from an unbroken KJS_MEM_LIMIT. The initial check-in of KJS_MEM_LIMIT (KJS revision 80061) doesn't mention a website that needed it.


  • Any website that brings you anywhere close to crashing due to the number of live JS objects will almost certainly put up the "slow script" dialog at least 20 times beforehand.
  • kjs/collector.cpp: (KJS::Collector::collect):
  • kjs/collector.h:
  • kjs/nodes.cpp: (KJS::TryNode::execute):

LayoutTests:

Reviewed by Sam Weinig.


Removing the test for KJS_MEM_LIMIT, since I removed KJS_MEM_LIMIT.

  • fast/js/out-of-memory-expected.txt: Removed.
  • fast/js/out-of-memory.html: Removed.
3:02 PM Changeset in webkit [30491] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30489.

3:00 PM BuildingCairoOnWindows edited by bfulgham@macports.org
(diff)
2:30 PM Changeset in webkit [30490] by weinig@apple.com
  • 7 edits in trunk/WebCore

Reviewed, tweaked and landed by Sam.

  • Make RegularExpression operate on Strings instead of DeprecatedStrings.
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::isXMLMIMEType): Use string instead of DeprecatedString to build up the RegularExpression.
  • page/Frame.cpp: (WebCore::createRegExpForLabels): Use String instead of DeprecatedString. (WebCore::Frame::searchForLabelsAboveCell): Ditto. (WebCore::Frame::searchForLabelsBeforeElement): Ditto. (WebCore::Frame::matchLabelsAgainstElement): Ditto.
  • page/Frame.h:
  • page/mac/FrameMac.mm: (WebCore::regExpForLabels): Ditto. (WebCore::Frame::searchForNSLabelsAboveCell): Ditto. (WebCore::Frame::searchForLabelsBeforeElement): Ditto. (WebCore::Frame::matchLabelsAgainstElement): Ditto.
  • platform/text/RegularExpression.cpp: (WebCore::RegularExpression::Private::Private): (WebCore::RegularExpression::Private::compile): (WebCore::RegularExpression::RegularExpression): (WebCore::RegularExpression::operator=): (WebCore::RegularExpression::pattern): (WebCore::RegularExpression::match): (WebCore::RegularExpression::search): (WebCore::RegularExpression::searchRev): (WebCore::replace): Added.
  • platform/text/RegularExpression.h: Change functions to take Strings as input instead of DeprecatedStrings and reduce the complexity of the class by removing unneeded globbing support.
2:15 PM Changeset in webkit [30489] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2008-02-22 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://problem/5760360> REGRESSION(r30376): Crash loading plugin page
during stress test (after only 5 min) - null dereference

Full-frame plug-ins create PluginStream objects without loaders, as the
PluginView receives the loading callbacks. We were trying to call
setDefersLoading on these null pointers.

  • plugins/PluginStream.cpp: (WebCore::PluginStream::startStream): Add null check. (WebCore::PluginStream::destroyStream): Same. (WebCore::PluginStream::deliverData): Same.
2:07 PM BuildingCairoOnWindows edited by bfulgham@macports.org
(diff)
1:39 PM Changeset in webkit [30488] by weinig@apple.com
  • 3 edits in trunk/WebCore

Reviewed and tweaked by Jon Honeycutt. Reviewed and landed by Sam.

  • Remove uses of DeprecatedString in Windows plugin code.
  • plugins/win/PluginPackageWin.cpp: (WebCore::getVersionInfo): Cleanup formatting. (WebCore::PluginPackage::freeLibraryTimerFired): Remove un-needed variable name. (WebCore::PluginPackage::storeFileVersion): Move casts. (WebCore::PluginPackage::fetchInfo): Use OwnArrayPtr and switch to more efficient use of Vectors. (WebCore::PluginPackage::load): Fix whitespace. (WebCore::PluginPackage::hash): Make the hashCodes const
  • plugins/win/PluginViewWin.cpp: (WebCore::makeURL): Use String instead of DeprecatedString. (WebCore::parseRFC822HeaderFields): Ditto. (WebCore::PluginView::handlePost): Ditto. (WebCore::PluginView::status): Ditto.
1:29 PM Changeset in webkit [30487] by timothy@apple.com
  • 32 edits in branches/Safari-3-1-branch

Merge r30472.

1:16 PM Changeset in webkit [30486] by weinig@apple.com
  • 3 edits in trunk/WebCore

Reviewed, tweaked and landed by Sam.

  • Don't use DeprecatedString in HTMLTokenizer.
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::finish):
  • platform/text/PlatformString.h: (WebCore::find):
12:58 PM Changeset in webkit [30485] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move hasWebView to WebFrameLoaderClient

I added an m_webFrame member to WebFrameLoaderClient. This is slightly
strange because WebFrame inherits from WebFrameLoaderClient, but this
member will be needed once we remove the inheritance, so we might as
well prepare for that now.

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::WebFrameLoaderClient): Changed to take a WebFrame* parameter. (WebFrameLoaderClient::hasWebView): Moved here from WebFrame.cpp.
  • WebCoreSupport/WebFrameLoaderClient.h: Added an m_webFrame parameter.
  • WebFrame.cpp: Removed hasWebView. (WebFrame::WebFrame): Updated for WebFrameLoaderClient constructor change.
  • WebFrame.h:
12:57 PM BuildingCairoOnWindows edited by bfulgham@macports.org
(diff)
12:21 PM Changeset in webkit [30484] by timothy@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebKitTools

Merge r30480.

12:16 PM Changeset in webkit [30483] by timothy@apple.com
  • 5 edits
    4 deletes in branches/Safari-3-1-branch

Roll out r29649.

12:05 PM Changeset in webkit [30482] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Adam.

<rdar://problem/5748781>
​https://bugs.webkit.org/show_bug.cgi?id=17413
REGRESSION: Latest Nightly doesn't load Java plugin w/Safari 3.1b


Copy the Java plug-in over to the new location.


  • FindSafari/FindSafari.cpp: (_tmain):
11:53 AM Changeset in webkit [30481] by Adam Roben
  • 4 edits
    2 adds in trunk/WebKit/win

Start to move FrameLoaderClient methods off WebFrame onto a separate class

WebFrame now inherits from a new WebFrameLoaderClient class, which
will gradually assume all FrameLoaderClient responsibilities. Once
that process is complete, WebFrame will no longer inherit from
WebFrameLoaderClient.

In this first patch, I've only moved createDocumentLoader up to the
WebFrameLoaderClient class.

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: Added. (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::~WebFrameLoaderClient): (WebFrameLoaderClient::createDocumentLoader): Moved here from WebFrame.cpp.
  • WebCoreSupport/WebFrameLoaderClient.h: Added.
  • WebFrame.cpp: Removed createDocumentLoader implementation.
  • WebFrame.h: Changed to inherit from WebFrameLoaderClient.
  • WebKit.vcproj/WebKit.vcproj: Added new files to the project.
11:51 AM Changeset in webkit [30480] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Adam.

<rdar://problem/5747325> REGRESSION: HTTP layout tests hang


  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Init the URL request with the correct timeout.
11:07 AM Changeset in webkit [30479] by Adam Roben
  • 3 edits
    2 adds in trunk/WebKit/win

Move FormValuesPropertyBag into its own files

Reviewed by Sam.

  • WebCoreSupport/FormValuesPropertyBag.cpp: Added. (FormValuesPropertyBag::QueryInterface): (FormValuesPropertyBag::AddRef): (FormValuesPropertyBag::Release): (FormValuesPropertyBag::Read): (FormValuesPropertyBag::Write): (FormValuesPropertyBag::CountProperties): (FormValuesPropertyBag::GetPropertyInfo): (FormValuesPropertyBag::LoadObject):
  • WebCoreSupport/FormValuesPropertyBag.h: Added. (FormValuesPropertyBag::FormValuesPropertyBag):
  • WebFrame.cpp: Deleted FormValuesPropertyBag code.
  • WebKit.vcproj/WebKit.vcproj: Added new files to the project.
11:07 AM Changeset in webkit [30478] by Adam Roben
  • 3 edits in trunk/WebKit/win

Remove some unused WebFrame methods

FrameWinClient was deleted back in r22965, but these methods were
never deleted.

Reviewed by Sam.

  • WebFrame.cpp:
  • WebFrame.h: Made one createFrame overload protected, since it's only called internally by WebFrame.
11:06 AM Changeset in webkit [30477] by Adam Roben
  • 2 edits
    10 moves
    1 add in trunk/WebKit/win

Move Client implementations into a WebCoreSupport directory

Reviewed by Anders.

  • WebKit.vcproj/WebKit.vcproj: Updated file paths, and added WebCoreSupport directory to the include path.
  • WebCoreSupport/WebChromeClient.cpp: Renamed from WebKit/win/WebChromeClient.cpp.
  • WebCoreSupport/WebChromeClient.h: Renamed from WebKit/win/WebChromeClient.h.
  • WebCoreSupport/WebContextMenuClient.cpp: Renamed from WebKit/win/WebContextMenuClient.cpp.
  • WebCoreSupport/WebContextMenuClient.h: Renamed from WebKit/win/WebContextMenuClient.h.
  • WebCoreSupport/WebDragClient.cpp: Renamed from WebKit/win/WebDragClient.cpp.
  • WebCoreSupport/WebDragClient.h: Renamed from WebKit/win/WebDragClient.h.
  • WebCoreSupport/WebEditorClient.cpp: Renamed from WebKit/win/WebEditorClient.cpp.
  • WebCoreSupport/WebEditorClient.h: Renamed from WebKit/win/WebEditorClient.h.
  • WebCoreSupport/WebInspectorClient.cpp: Renamed from WebKit/win/WebInspectorClient.cpp.
  • WebCoreSupport/WebInspectorClient.h: Renamed from WebKit/win/WebInspectorClient.h.
10:32 AM Changeset in webkit [30476] by sullivan@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Adam Roben


Reverted the changed from yesterday to add pasteAndMatchStyle:, as the existing
pasteAsPlainText: has the same behavior.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): (-[WebHTMLView readSelectionFromPasteboard:]): (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView pasteAsRichText:]): (-[WebHTMLView paste:]):
  • WebView/WebView.mm:
  • WebView/WebViewPrivate.h:
2:27 AM Changeset in webkit [30475] by oliver@apple.com
  • 5 edits in trunk

<rdar://problem/5759327> REGRESSION: while(NaN) acts like while(true)

Reviewed by Alexey P.

Fix yet another case where we incorrectly relied on implicit double
to bool coercion.

Feb 21, 2008:

11:04 PM Changeset in webkit [30474] by hyatt@apple.com
  • 1 edit in trunk/WebCore/css/MediaQueryEvaluator.cpp

Add null check to fix crash in media query code I checked in.

10:10 PM Changeset in webkit [30473] by alp@webkit.org
  • 2 edits in trunk

2008-02-21 Alp Toker <​alp@atoker.com>

Fix a configure script typo.

  • configure.ac:
7:35 PM Changeset in webkit [30472] by weinig@apple.com
  • 32 edits in trunk

WebCore:

Reviewed by Anders Carlsson.

Fix for <rdar://problem/5757946>

  • Parse URLs before checking whether they are javascript: urls (which require security checks).
  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue):
  • bindings/js/JSElementCustom.cpp: (WebCore::allowSettingSrcToJavascriptURL):
  • bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL):
  • bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc):

LayoutTests:

Reviewed by Anders Carlsson.

Update tests and results for <rdar://problem/5757946>

  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS.html:
6:21 PM Changeset in webkit [30471] by mrowe@apple.com
  • 3 edits in branches/Safari-3-1-branch/WebCore

Merge r30461.

6:21 PM Changeset in webkit [30470] by mrowe@apple.com
  • 3 edits
    2 adds in branches/Safari-3-1-branch

Merge r30458.

6:21 PM Changeset in webkit [30469] by mrowe@apple.com
  • 9 edits in branches/Safari-3-1-branch

Merge r30433.

5:07 PM Changeset in webkit [30468] by adachan@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/5757873> Buffer overrun in DeprecatedCString::find() in WebCore
We could get a buffer overrun in DeprecatedCString::find() if the end of the
string matches a beginning portion of the substring, for example, if string is
"a" but the substring is "ab".
The code as is also will not match things correctly under certain situations
since the inner while loop increments the index. For example, we wouldn't find
a match if the string is "aab..." and the substring is "ab". Changed the
inner while loop to increment a temporary index into str.


Test: fast/loader/charset-parse.html

Reviewed by Dan Berstein.

  • platform/DeprecatedCString.cpp: (WebCore::DeprecatedCString::find):
4:15 PM Changeset in webkit [30467] by hyatt@apple.com
  • 5 adds in trunk/LayoutTests

Add test case for viewport media queries.

4:14 PM Changeset in webkit [30466] by hyatt@apple.com
  • 9 edits in trunk/WebCore

Fix for bug 17301. CSS media queries need to use the correct viewport
when contained in documents inside iframes (rather than always using the
top-level document's viewport). CSS media queries based on the viewport
also needed to be dynamic and update as you resize the window (this is
a HOT feature). :)

This patch gets Acid3 up to 86/100 with 3 colored boxes filled in.

Reviewed by olliej

Added fast/media/viewport-media-query.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::addViewportDependentMediaQueryResult): (WebCore::CSSStyleSelector::affectedByViewportChange):
  • css/CSSStyleSelector.h: (WebCore::MediaQueryResult::MediaQueryResult):
  • css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::MediaQueryEvaluator): (WebCore::MediaQueryEvaluator): (WebCore::MediaQueryEvaluator::eval): (WebCore::colorMediaFeatureEval): (WebCore::monochromeMediaFeatureEval): (WebCore::device_aspect_ratioMediaFeatureEval): (WebCore::device_pixel_ratioMediaFeatureEval): (WebCore::gridMediaFeatureEval): (WebCore::device_heightMediaFeatureEval): (WebCore::device_widthMediaFeatureEval): (WebCore::heightMediaFeatureEval): (WebCore::widthMediaFeatureEval): (WebCore::min_colorMediaFeatureEval): (WebCore::max_colorMediaFeatureEval): (WebCore::min_monochromeMediaFeatureEval): (WebCore::max_monochromeMediaFeatureEval): (WebCore::min_device_aspect_ratioMediaFeatureEval): (WebCore::max_device_aspect_ratioMediaFeatureEval): (WebCore::min_device_pixel_ratioMediaFeatureEval): (WebCore::max_device_pixel_ratioMediaFeatureEval): (WebCore::min_heightMediaFeatureEval): (WebCore::max_heightMediaFeatureEval): (WebCore::min_widthMediaFeatureEval): (WebCore::max_widthMediaFeatureEval): (WebCore::min_device_heightMediaFeatureEval): (WebCore::max_device_heightMediaFeatureEval): (WebCore::min_device_widthMediaFeatureEval): (WebCore::max_device_widthMediaFeatureEval):
  • css/MediaQueryEvaluator.h:
  • css/MediaQueryExp.cpp: (WebCore::MediaQueryExp::~MediaQueryExp):
  • css/MediaQueryExp.h: (WebCore::MediaQueryExp::value): (WebCore::MediaQueryExp::isViewportDependent):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::pickMedia):
  • page/FrameView.cpp: (WebCore::FrameView::layout):
1:23 PM Changeset in webkit [30465] by andersca@apple.com
  • 10 edits in trunk

WebCore:

Reviewed by Sam.

Make more classes start out with a refcount of 1.

  • dom/QualifiedName.cpp: (WebCore::QNameComponentsTranslator::translate): (WebCore::QualifiedName::QualifiedName):
  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::create): (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl):
  • history/BackForwardList.cpp: (WebCore::BackForwardList::BackForwardList):
  • history/BackForwardList.h: (WebCore::BackForwardList::create):
  • page/Page.cpp: (WebCore::Page::Page):
  • platform/text/CString.cpp: (WebCore::CString::init): (WebCore::CString::newUninitialized): (WebCore::CString::copyBufferIfNeeded):
  • platform/text/CString.h: (WebCore::CStringBuffer::create): (WebCore::CStringBuffer::CStringBuffer):

WebKit/mac:

Reviewed by Sam.

Use BackForwardList::create instead.


  • History/WebBackForwardList.mm: (-[WebBackForwardList init]):
1:21 PM Changeset in webkit [30464] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix for the domString() -> string() rename in r30443.

12:35 PM Changeset in webkit [30463] by sullivan@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Jessica Kahn


support for pasteAndMatchStyle: command (see <rdar://problem/5723952>)

  • WebView/WebHTMLView.mm: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:matchStyle:]): added matchStyle parameter, passed along to bridge (formerly always passed NO to bridge) (-[WebHTMLView readSelectionFromPasteboard:]): pass NO for new matchStyle parameter to match old behavior (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): validate pasteAndMatchStyle the same way as pasteAsRichText (-[WebHTMLView pasteAndMatchStyle:]): just like pasteAsRichText but passes YES for matchStyle (-[WebHTMLView pasteAsRichText:]): pass NO for new matchStyle parameter to match old behavior (-[WebHTMLView paste:]): ditto


  • WebView/WebView.mm: added macro(pasteAndMatchStyle)


  • WebView/WebViewPrivate.h: added pasteAndMatchStyle: to WebViewEditingActionsPendingPublic category
12:16 PM Changeset in webkit [30462] by alp@webkit.org
  • 2 edits in trunk

2008-02-21 Alp Toker <​alp@atoker.com>

GTK+/autotools SVG experimental build fix

Don't enable SVG filters in --enable-svg-experimental.

This feature isn't supported at all yet. Developers can enable it
explicitly by passing --enable-svg-filters if needed.

  • configure.ac:
12:10 PM Changeset in webkit [30461] by Antti Koivisto
  • 3 edits in trunk/WebCore

Reviewed by Sam Weinig.

<rdar://problem/5753789>
REGRESSION: 1.5% -2% Sunspider regression from r30009 (ebay photo upload hang)


Ensure all versions of allowsAccessFrom are inlined to single functions.
This is a 2% win in browser hosted Sunspider.

  • bindings/js/kjs_window.cpp: (KJS::Window::allowsAccessFrom): (KJS::Window::allowsAccessFromPrivate):
  • bindings/js/kjs_window.h:
11:59 AM Changeset in webkit [30460] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • minor cleanup
  • rendering/bidi.cpp: (WebCore::bidiNext): Removed redundant isBR() check -- isText() returns true for RenderLineBreak. (WebCore::bidiFirst): Ditto. (WebCore::shouldSkipWhitespaceAfterStartObject): (WebCore::RenderBlock::findNextLineBreak):
11:43 AM Changeset in webkit [30459] by alp@webkit.org
  • 4 edits in trunk

2008-02-21 Mike Auty <​mike.auty@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=17445
[GTK] WebKit doesn't compile with LDFLAGS="-Wl,--as-needed"

The GNUmakefile.am files make use of the LDFLAGS variable to include library
additions such as -ljpeg etc. Unfortunately, if these inclusions aren't made
in LIBADD/LDADD variables, then they are mis-ordered during the linking.

The as-needed flag discards libraries whose functions have not been needed by
earlier libraries, which therefore makes the ordering important.

This moves all -l library inclusion statements from LDFLAGS variables to
LIBADD/LDADD variables.

  • GNUmakefile.am:
10:09 AM Changeset in webkit [30458] by ggaren@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by David Harrison.


Fixed <rdar://problem/5756125> REGRESSION: A crash occurs at
WebCore::Frame::scriptProxy() when completing a search with Package Tracker widget

Test: fast/dom/script-element-without-frame-crash.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Added back a NULL check that was accidentally removed in r30325.

LayoutTests:

Reviewed by David Harrison.


Test for <rdar://problem/5756125> REGRESSION: A crash occurs at
WebCore::Frame::scriptProxy() when completing a search with Package Tracker widget

  • fast/dom/script-element-without-frame-crash-expected.txt: Added.
  • fast/dom/script-element-without-frame-crash.html: Added.
9:30 AM Changeset in webkit [30457] by pewtermoose@webkit.org
  • 2 edits in trunk/WebCore

2008-02-21 Rodney Dawes <​dobey@wayofthemonkey.com>

GTK+ build fix. s/domString()/string()/

  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (FontPlatformData::FontPlatformData):
Note: See TracTimeline for information about the timeline view.