⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 24, 2008:

11:44 PM Changeset in webkit [30562] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Make some updates based on a trial run of the renaming script.
11:17 PM Changeset in webkit [30561] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: More renaming plans.
11:11 PM Changeset in webkit [30560] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=17529
Add support for reading from stdin from testkjs

  • kjs/testkjs.cpp: (GlobalObject::GlobalObject): Add readline function to global object. (functionReadline): Added. Reads characters from stdin until a '\n' or EOF is encountered. The input is returned as a String to the caller.
11:09 PM Changeset in webkit [30559] by Darin Adler
  • 2 edits in trunk/WebCore
  • dom/Document.h: Removed stray duplicate declaration of RegisteredEventListenerList.
10:52 PM Changeset in webkit [30558] by Darin Adler
  • 2 edits in trunk/WebCore
  • dom/Range.cpp: (WebCore::Range::surroundContents): Removed incorrect comment. I added it a while ago, and I was just mixed up.
10:48 PM Changeset in webkit [30557] by Darin Adler
  • 2 edits in trunk/WebCore
  • quick follow-up to that last check-in
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::createFrameAtIndex): Use CFEqual instead of WebCore::String's == for speed.
10:36 PM Changeset in webkit [30556] by Darin Adler
  • 3 edits
    6 adds in trunk

WebCore:

Reviewed by Darin.

Bug 8749: XBM rendered incorrectly as black on white

xbm images are now created and rendered using black on a
transparent background (same behavior as in Firefox)

Test: platform/mac/fast/canvas/canvas-draw-xbm-image.html

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::createFrameAtIndex):

LayoutTests:

Reviewed by Darin.


  • platform/mac/fast/canvas/canvas-draw-xbm-image-expected.checksum: Added.
  • platform/mac/fast/canvas/canvas-draw-xbm-image-expected.png: Added.
  • platform/mac/fast/canvas/canvas-draw-xbm-image-expected.txt: Added.
  • platform/mac/fast/canvas/canvas-draw-xbm-image.html: Added.
  • platform/mac/fast/canvas/resources: Added.
  • platform/mac/fast/canvas/resources/smile.xbm: Added.
9:29 PM Changeset in webkit [30555] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=17528
Give testkjs a bath

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj: Make the testkjs.cpp use 4 space indentation.
  • kjs/testkjs.cpp: (StopWatch::getElapsedMS): (GlobalObject::className): (GlobalObject::GlobalObject): Rename GlobalImp to GlobalObject and setup the global functions in the GlobalObject's constructor. Also, use static functions for the implementation so we can use the standard PrototypeFunction class and remove TestFunctionImp. (functionPrint): Move print() functionality here. (functionDebug): Move debug() functionality here. (functionGC): Move gc() functionality here. (functionVersion): Move version() functionality here. (functionRun): Move run() functionality here. (functionLoad): Move load() functionality here. (functionQuit): Move quit() functionality here. (prettyPrintScript): Fix indentation. (runWithScripts): Since all the functionality of createGlobalObject is now in the GlobalObject constructor, just call new here. (parseArguments): Fix indentation. (kjsmain): Ditto (fillBufferWithContentsOfFile): Ditto.
7:08 PM Changeset in webkit [30554] by mitz@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: http/tests/misc/object-image-error.html

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::attach): Added an early return in case updateFromElement() has changed the object to use fallback content.

LayoutTests:

Reviewed by Darin Adler.

  • http/tests/misc/object-image-error-expected.txt: Added.
  • http/tests/misc/object-image-error.html: Added.
  • http/tests/misc/resources/404image.php: Added.
5:34 PM Changeset in webkit [30553] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt and Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=17505
Add support for getting command line arguments in testkjs

  • This slightly changes the behavior of parsing arguments by requiring a '-f' before all files.
  • kjs/testkjs.cpp: (createGlobalObject): Add a global property called 'arguments' which contains an array with the parsed arguments as strings. (runWithScripts): Pass in the arguments vector so that it can be passed to the global object. (parseArguments): Change parsing rules to require a '-f' before any script file. After all '-f' and '-p' arguments have been parsed, the remaining are added to the arguments vector and exposed to the script. If there is a chance of ambiguity (the user wants to pass the string '-f' to the script), the string '--' can be used separate the options from the pass through arguments. (kjsmain):
2:50 PM Changeset in webkit [30552] by mitz@apple.com
  • 1 edit
    651 moves
    651 deletes in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.

  • replace expected results in platform/mac-tiger and platform/mac-leopard which were identical with a single copy in platform/mac
10:48 AM Changeset in webkit [30551] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix float positioning when a float that does not fit on the line is followed by a float that does

Test: fast/block/float/narrow-after-wide.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Changed to not position any more floats on the line once a float that does not fit is encountered. That float should be pushed to the next line, and so should all floats that follow, regardless of whether they can fit on the current line.

LayoutTests:

Reviewed by Darin Adler.

  • test float positioning when a float that does not fit on the line is followed by a float that does
  • fast/block/float/narrow-after-wide.html: Added.
  • platform/mac/fast/block/float/narrow-after-wide-expected.checksum: Added.
  • platform/mac/fast/block/float/narrow-after-wide-expected.png: Added.
  • platform/mac/fast/block/float/narrow-after-wide-expected.txt: Added.
10:44 AM Changeset in webkit [30550] by mitz@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

  • wtf/Deque.h: (WTF::::expandCapacityIfNeeded): Fixed the case where m_start and m_end are both zero but the buffer capacity is non-zero. (WTF::::prepend): Added validity checks.
12:30 AM Changeset in webkit [30549] by Darin Adler
  • 21 edits
    3 adds in trunk

WebCore:

Reviewed by Sam.

Disentangle global history updating from the back/forward history.
There are many cases where we don't want to create a new back/forward
item, but we do still want to add to the global history (used for visited
link coloring) in those cases.

Test: fast/history/subframe-is-visited.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateGlobalHistory): Renamed from addHistoryForCurrentLocation and removed the back/forward handling. (WebCore::FrameLoader::updateHistoryForStandardLoad): Streamlined logic a bit. Replaced call to addHistoryForCurrentLocation with a call to addBackForwardItemClippedAtTarget. Added an unconditional call to updateGlobalHistory. (WebCore::FrameLoader::updateHistoryForClientRedirect): Added a FIXME; why doesn't this function update global history? (WebCore::FrameLoader::updateHistoryForBackForwardNavigation): Ditto. (WebCore::FrameLoader::updateHistoryForReload): Replaced the direct call the client with a call to the new updateGlobalHistory function. (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory): Did the same changes as for updateHistoryForStandardLoad.
  • loader/FrameLoader.h: More of the same.
  • loader/FrameLoaderClient.h: Removed updateGlobalHistoryForReload and renamed updateGlobalHistoryForStandardLoad to updateGlobalHistory.
  • svg/graphics/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistory): Updated to match the above.

WebKit/gtk:

Reviewed by Sam.

  • remove separate client calls for "standard" and "reload' history
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::updateGlobalHistory):
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

Reviewed by Sam.

  • remove separate client calls for "standard" and "reload' history
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory):

WebKit/qt:

Reviewed by Sam.

  • remove separate client calls for "standard" and "reload' history
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistory):
  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

Reviewed by Sam.

  • remove separate client calls for "standard" and "reload' history
  • WebFrame.cpp: (WebFrame::updateGlobalHistory):
  • WebFrame.h:

WebKit/wx:

Reviewed by Sam.

  • remove separate client calls for "standard" and "reload' history
  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::updateGlobalHistory):
  • WebKitSupport/FrameLoaderClientWx.h:

LayoutTests:

Reviewed by Sam.

  • fast/history/resources/subframe.html: Added.
  • fast/history/subframe-is-visited-expected.txt: Added.
  • fast/history/subframe-is-visited.html: Added.
12:09 AM Changeset in webkit [30548] by Darin Adler
  • 2 edits in trunk/WebKit/qt
  • another try at fixing the build
  • Api/qwebframe.cpp: (QWebFrame::load): Replace new FormData with FormData::create.

Feb 23, 2008:

11:55 PM Changeset in webkit [30547] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Restore the old logic, with its unpleasant trip through String do to the replace operation. It's inefficient, but there's no real reason to worry about the efficiency of mailto forms, since that feature is nearly obsolete.
11:36 PM Changeset in webkit [30546] by Darin Adler
  • 3 edits in trunk/WebCore

Reviewed by Sam.

  • replace SegmentedString's use of DeprecatedValueList with Deque

Testing indicates this is a slight speed-up for page loading.

  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::length): Update to use Deque. (WebCore::SegmentedString::setExcludeLineNumbers): Ditto. (WebCore::SegmentedString::append): Ditto. (WebCore::SegmentedString::prepend): Ditto. (WebCore::SegmentedString::advanceSubstring): Ditto. (WebCore::SegmentedString::toString): Ditto.
  • platform/text/SegmentedString.h: Tweak formatting. Don't bother making an entire class private with a single friend. Change m_sbstrings from a DeprecatedValueList to a Deque.
11:26 PM Changeset in webkit [30545] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Anders.

  • loader/TextResourceDecoder.cpp: (WebCore::findTextEncoding): Fix off-by-one in code that null-terminates the C string here.
11:10 PM Changeset in webkit [30544] by pewtermoose@webkit.org
  • 3 edits in trunk/WebCore

Not reviewed, build fix.

  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::httpBodyFromRequest):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::handlePost):
11:07 PM Changeset in webkit [30543] by mitz@apple.com
  • 3 edits in trunk/WebCore
  • fix a typo
  • platform/graphics/win/GlyphPageTreeNodeCGWin.cpp: (WebCore::GlyphPage::fill):
  • platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp: (WebCore::GlyphPage::fill):
11:07 PM Changeset in webkit [30542] by pewtermoose@webkit.org
  • 6 edits in trunk

2008-02-23 Jan Michael Alonzo <​jmalonzo@unpluggable.com>
.:

Rubber stamped by Darin.

Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
whitespaces introduced in the previous commit.

  • GNUmakefile.am:

JavaScriptCore:

Rubber stamped by Darin.

Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
whitespaces introduced in the previous commit.

  • GNUmakefile.am:

WebKitTools:

Rubber stamped by Darin.

Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
whitespaces introduced in the previous commit.

  • GNUmakefile.am:
10:59 PM Changeset in webkit [30541] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • fix GlyphPage::fill() logic for partial page fills
  • platform/graphics/win/GlyphPageTreeNodeCGWin.cpp: (WebCore::GlyphPage::fill): Changed the test for non-BMP characters to work correctly when the length parameter is less than a full page size. Also updated the comment.
  • platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp: (WebCore::GlyphPage::fill): Ditto.
9:42 PM Changeset in webkit [30540] by Darin Adler
  • 7 edits in trunk

.:

Rubber-stamped by Darin.

  • GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
  • configure.ac: Break dependent modules into GLOBALDEPS and WEBKITDEPS.

JavaScriptCore:

  • GNUmakefile.am: Add GLOBALDEPS for testkjs and minidom.

WebKitTools:

Rubber-stamped by Darin.

  • GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
9:38 PM Changeset in webkit [30539] by kevino@webkit.org
  • 5 edits
    4 adds in trunk

Move text drawing into wxcode, as we need platform-dependent APIs for drawing non-kerned text, which wx doesn't yet have.

​http://bugs.webkit.org/show_bug.cgi?id=17396

9:19 PM Changeset in webkit [30538] by Darin Adler
  • 3 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • wtf/Deque.h: Wrote an all-new version of this class that uses a circular buffer. Growth policy is identical to vector. Added iterators.
  • wtf/Vector.h: Made two small refinements while using this to implement Deque: Made VectorBufferBase derive from Noncopyable, which would have saved me some debugging time if it had been there. Renamed Impl and m_impl to Buffer and m_buffer.
9:13 PM Changeset in webkit [30537] by Darin Adler
  • 2 edits in trunk/WebCore

Pointed out by Mitz.

  • loader/TextResourceDecoder.cpp: (WebCore::find): Fix a "==" that was supposed to be ">". (WebCore::findIgnoringCase): Ditto.
9:12 PM Changeset in webkit [30536] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • html/HTMLFormElement.cpp: (WebCore::appendEncodedString): Fix buffer overrun in the code I just landed.
9:04 PM Changeset in webkit [30535] by Darin Adler
  • 7 edits in trunk/WebCore

Reviewed by Sam.

  • remove all but 1 remaining use of DeprecatedCString
  • change FormData to start refcount at 1
  • html/HTMLFormElement.cpp: (WebCore::appendString): Added. Helpers for Vector<char>. (WebCore::appendEncodedString): Renamed from encodeCString and changed to append to an existing Vector<char> to cut down a bit on memory allocation. (WebCore::HTMLFormElement::formData): Replace the DeprecatedCString called enc_string with a Vector<char> called encodedData. Change to use the new FormData::create function. (WebCore::HTMLFormElement::submit): Same thing, for the mailto form code.
  • loader/TextResourceDecoder.cpp: (WebCore::find): Added. Helper for searching in char* with length. (WebCore::findIgnoringCase): Ditto. (WebCore::findTextEncoding): Added. Helper for looking up a text encoding when we have a char* with length rather than a null-terminated char*. (WebCore::findXMLEncoding): Changed to use char* and length rather than DeprecatedCString. Also fixed some things that would be one-character buffer overruns in a string that's not null-terminated. (WebCore::TextResourceDecoder::checkForCSSCharset): Change to use findTextEncoding rather than constructing a CString to pass to the TextEncodingconstructor. (WebCore::TextResourceDecoder::checkForHeadCharset): Ditto.
  • platform/network/FormData.cpp: (WebCore::FormData::FormData): Changed to start refcount at 1. (WebCore::FormData::create): Added. (WebCore::FormData::copy): Call adoptRef since refcount starts at 1.
  • platform/network/FormData.h: Made constructor private. Added create functions.
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest): Call FormData::create.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Ditto.
9:01 PM Changeset in webkit [30534] by Darin Adler
  • 57 edits in trunk

JavaScriptCore:

Reviewed by Anders.

  • API/JSCallbackObject.h: Removed attribute arguments.
  • API/JSCallbackObjectFunctions.h: (KJS::JSCallbackObject<Base>::put): Ditto.
  • API/JSObjectRef.cpp: (JSObjectSetProperty): Use initializeVariable or putDirect when necessary to set attribute values.
  • JavaScriptCore.exp: Updated.
  • bindings/objc/objc_runtime.h: Removed attribute arguments.
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::put): Ditto.
  • bindings/runtime_array.cpp: (RuntimeArray::put): Ditto.
  • bindings/runtime_array.h: Ditto.
  • bindings/runtime_object.cpp: (RuntimeObjectImp::put): Ditto.
  • bindings/runtime_object.h: Ditto. Also removed canPut which was only called from one place in WebCore that can use hasProperty instead.
  • kjs/Activation.h: Removed attribute argument from put and added the new initializeVariable function that's used to put variables in variable objects. Also made isActivationObject a const member.
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::put): Removed attribute argument. (KJS::JSGlobalObject::initializeVariable): Added. Used to give variables their initial values, which can include the read-only property. (KJS::JSGlobalObject::reset): Removed obsolete comments about flags. Removed Internal flag, which is no longer needed.
  • kjs/JSGlobalObject.h: More of the same.
  • kjs/JSVariableObject.h: Added pure virtual initializeVariable function. (KJS::JSVariableObject::symbolTablePut): Removed checkReadOnly flag; we always check read-only. (KJS::JSVariableObject::symbolTableInitializeVariable): Added.
  • kjs/array_instance.cpp: (KJS::ArrayInstance::put): Removed attribute argument.
  • kjs/array_instance.h: Ditto.
  • kjs/function.cpp: (KJS::FunctionImp::put): Ditto. (KJS::Arguments::put): Ditto. (KJS::ActivationImp::put): Ditto. (KJS::ActivationImp::initializeVariable): Added.
  • kjs/function.h: Removed attribute arguments.
  • kjs/function_object.cpp: (KJS::FunctionObjectImp::construct): Removed Internal flag.
  • kjs/lookup.h: (KJS::lookupPut): Removed attributes argument. Also changed to use putDirect instead of calling JSObject::put. (KJS::cacheGlobalObject): Ditto.
  • kjs/nodes.cpp: (KJS::ConstDeclNode::handleSlowCase): Call initializeVariable to initialize the constant. (KJS::ConstDeclNode::evaluateSingle): Ditto. (KJS::TryNode::execute): Use putDirect to set up the new object. (KJS::FunctionBodyNode::processDeclarations): Removed Internal. (KJS::ProgramNode::processDeclarations): Ditto. (KJS::EvalNode::processDeclarations): Call initializeVariable to initialize the variables and functions. (KJS::FuncDeclNode::makeFunction): Removed Internal. (KJS::FuncExprNode::evaluate): Ditto.
  • kjs/object.cpp: Removed canPut, which was only being used in one code path, not the normal high speed one. (KJS::JSObject::put): Removed attribute argument. Moved the logic from canPut here, in the one code ath that was still using it.
  • kjs/object.h: Removed Internal attribute, ad canPut function. Removed the attributes argument to the put function. Made isActivationObject const.
  • kjs/regexp_object.cpp: (KJS::RegExpImp::put): Removed attributes argument. (KJS::RegExpImp::putValueProperty): Ditto. (KJS::RegExpObjectImp::put): Ditto. (KJS::RegExpObjectImp::putValueProperty): Ditto.
  • kjs/regexp_object.h: Ditto.
  • kjs/string_object.cpp: (KJS::StringInstance::put): Removed attributes argument.
  • kjs/string_object.h: Ditto.

WebCore:

Reviewed by Anders.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::customPut): Remove attributes argument.
  • bindings/js/JSCanvasPixelArrayCustom.cpp: (WebCore::JSCanvasPixelArray::indexGetter): Use early exit idiom. (WebCore::JSCanvasPixelArray::indexSetter): Moved length check into the CanvasPixelArray object, for consistency with the getter. Removed attributes argument.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customPut): Removed special case for variable initialization, which is not needed since that does use put any more. Removed attributes argument.
  • bindings/js/JSEventTargetBase.h: (WebCore::JSEventTargetBase::putValueProperty): Removed attributes argument. (WebCore::JSEventTargetBase::put): Ditto. (WebCore::JSEventTargetPrototype::self): Removed Internal flag.
  • bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNode::put): Removed attributes argument. (WebCore::JSEventTargetNode::putValueProperty): Ditto.
  • bindings/js/JSEventTargetNode.h: Ditto.
  • bindings/js/JSHTMLAppletElementCustom.cpp: (WebCore::JSHTMLAppletElement::customPut): Ditto.
  • bindings/js/JSHTMLEmbedElementCustom.cpp: (WebCore::JSHTMLEmbedElement::customPut): Ditto.
  • bindings/js/JSHTMLInputElementBase.cpp: (WebCore::JSHTMLInputElementBase::put): Ditto. (WebCore::JSHTMLInputElementBase::putValueProperty): Ditto.
  • bindings/js/JSHTMLInputElementBase.h: Ditto.
  • bindings/js/JSHTMLObjectElementCustom.cpp: (WebCore::JSHTMLObjectElement::customPut): Ditto.
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::indexSetter): Ditto.
  • bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::indexSetter): Ditto.
  • bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::customPut): Ditto.
  • bindings/js/JSLocation.cpp: (WebCore::JSLocation::put): Ditto.
  • bindings/js/JSLocation.h: Ditto.
  • bindings/js/JSXMLHttpRequest.cpp: (WebCore::JSXMLHttpRequest::put): Ditto. (WebCore::JSXMLHttpRequest::putValueProperty): Ditto.
  • bindings/js/JSXMLHttpRequest.h: Ditto.
  • bindings/js/kjs_dom.cpp: (WebCore::getRuntimeObject): Changed return type to JSObject*.
  • bindings/js/kjs_dom.h: Ditto.
  • bindings/js/kjs_events.cpp: (WebCore::JSClipboard::put): Removed attributes argument. (WebCore::JSClipboard::putValueProperty): Ditto.
  • bindings/js/kjs_events.h: Ditto.
  • bindings/js/kjs_html.cpp: (WebCore::runtimeObjectGetter): Updated for change to getRuntimeObject to return a JSObject. Used early exit idiom. (WebCore::runtimeObjectPropertyGetter): Ditto. (WebCore::runtimeObjectCustomGetOwnPropertySlot): Ditto. (WebCore::runtimeObjectCustomPut): Use hasProperty to check for properties that we should put with the property syntax instead of canPut. (WebCore::runtimeObjectImplementsCall): Ditto. (WebCore::runtimeObjectCallAsFunction): Ditto.
  • bindings/js/kjs_html.h: Removed attributes argument to runtimeObjectCustomPut.
  • bindings/js/kjs_window.cpp: (KJS::Window::put): Removed attributes argument.
  • bindings/js/kjs_window.h: Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Removed attributes argument from put, putValueProperty, customPut, and indexSetter.
  • html/CanvasPixelArray.h: (WebCore::CanvasPixelArray::set): Added index checking here, as in the get function. Before, the checking was done in the JavaScript bindings for set.
8:15 PM Changeset in webkit [30533] by pewtermoose@webkit.org
  • 7 edits in trunk/WebCore

2008-02-23 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Adam and Darin.

​http://bugs.webkit.org/show_bug.cgi?id=17442
Correct the Windows Cairo implementation of GraphicsContext so
that Windows 'WorldTransform' is kept in sync with the Cairo
transormations.

Also corrects an uninitialized variable in the Cairo Windows
image drag handler.

WARNING: NO TEST CASES ADDED OR CHANGED

  • platform/graphics/cairo/GraphicsContextCairo.cpp: Modify methods to call GraphicsContextPlatformPrivate calls, just as is done for the CoreGraphics version. These calls are nop's for everything but Windows. (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::concatCTM): Re-enable for Windows (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/win/GraphicsContextCGWin.cpp: Move common code for handling WorldTransform calls to parent class.
  • platform/graphics/win/GraphicsContextCairoWin.cpp: Add common code for handling WorldTransform calls. (WebCore::GraphicsContextPlatformPrivate::concatCTM): Change implementation so that it only handles WorldTransform. The Cairo update is done in GraphicsContextCairo.cpp
  • platform/graphics/win/GraphicsContextWin.cpp: Call platform-private methods to keep WorldTransform in sync. (WebCore::GraphicsContextPlatformPrivate::save): (WebCore::GraphicsContextPlatformPrivate::restore): (WebCore::GraphicsContextPlatformPrivate::clip): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate):
  • platform/win/DragImageCairoWin.cpp: (WebCore::createDragImageFromImage): Correct uninitialized value
8:10 PM Changeset in webkit [30532] by pewtermoose@webkit.org
  • 3 edits in trunk/WebKit/win

2008-02-23 Brent Fulgham <​bfulgham@gmail.com>

Not reviewed, build fix.

  • WebIconDatabase.cpp:
  • WebIconDatabase.h:
8:05 PM Changeset in webkit [30531] by pewtermoose@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-02-23 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Not reviewed, Gtk build fix.

  • kjs/testkjs.pro:
8:00 PM Changeset in webkit [30530] by mitz@apple.com
  • 5 edits
    5 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • make non-autowrapping text clear floats

Test: fast/text/whitespace/nowrap-clear-float.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nextFloatBottomBelow): Renamed nearestFloat() to this and changed to avoid comparing bottom to 0 in each iteration. (WebCore::RenderBlock::getClearDelta): Updated comment for the rename.
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::fitBelowFloats): Added. Factored out of findNextLineBreak() and simplified. (WebCore::RenderBlock::findNextLineBreak): Changed to call fitBelowFloats(). Fixed the bug by trying to fit below floats in the case of non-wrapping text. Removed some redundancy.

LayoutTests:

Reviewed by Dave Hyatt.

  • test that non-autowrapping text clear floats
  • fast/text/whitespace/nowrap-clear-float.html: Added.
  • platform/mac-leopard/fast/text/whitespace: Added.
  • platform/mac-leopard/fast/text/whitespace/nowrap-clear-float-expected.checksum: Added.
  • platform/mac-leopard/fast/text/whitespace/nowrap-clear-float-expected.png: Added.
  • platform/mac/fast/text/whitespace/nowrap-clear-float-expected.txt: Added.
5:35 PM Changeset in webkit [30529] by weinig@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=17504
Speed up DOM lists array subscription syntax by using the fast
getOwnPropertySlot and set paths

  • 6x speed improvement on Oliver's ImageData put test.
  • bindings/scripts/CodeGeneratorJS.pm: Add fast path for getOwnPropertySlot and put when an indexGetter or indexSetter is used. We can not use the fast path if an overridingNameGetter is used as there would be no way to override.
5:33 PM Changeset in webkit [30528] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix after JSImageData.cpp was added.

1:52 PM Changeset in webkit [30527] by ap@webkit.org
  • 4 edits
    1 delete in trunk

Windows build fix - move ThreadCondition implementation from WebCore to WTF.

1:04 PM BuildingGtk edited by lethalman88@gmail.com
(diff)
12:49 PM Changeset in webkit [30526] by ap@webkit.org
  • 6 edits in trunk

Build fix.

JavaScriptCore:

Touch some files, hoping that Windows build bot will create JSC headers.

  • kjs/AllInOneFile.cpp:
  • kjs/array_instance.cpp:
  • wtf/HashTable.cpp:

WebKit/gtk:

  • webkit/webkitprivate.cpp: (webkit_init): Renamed initializeThreading to initializeThreadingAndMainThread.
12:29 PM Changeset in webkit [30525] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Qt/Wx build fix - this file was still in a wrong namespace, too.

  • wtf/ThreadingNone.cpp:
12:21 PM Changeset in webkit [30524] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

More build fixing - fix mismatched braces.

12:10 PM Changeset in webkit [30523] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Wx and Gtk build fixes.

  • JavaScriptCore.pri: Don't try to compile ThreadingPthreads.
  • wtf/ThreadingGtk.cpp: Use a correct namespace.
11:50 AM Changeset in webkit [30522] by ap@webkit.org
  • 37 edits
    4 copies
    9 moves
    5 adds
    2 deletes in trunk

2008-02-23 Alexey Proskuryakov <​ap@webkit.org>

Reviewed by Darin.

Move basic threading support from WebCore to WTF.

10:54 AM Changeset in webkit [30521] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp

Fix typo in comment.

9:08 AM Changeset in webkit [30520] by ddkilzer@apple.com
  • 14 edits
    1 add in trunk

WebCore:

Please clarify licensing for some files
<​http://bugs.webkit.org/show_bug.cgi?id=14970>

Reviewed by Darin.

  • bindings/objc/WebScriptObject.h: Added Apple BSD-style license.
  • bindings/objc/WebScriptObjectPrivate.h: Ditto.
  • platform/text/mac/ShapeArabic.c: Added ICU license from WebCore/icu/LICENSE.

WebKit/mac:

Please clarify licensing for some files
<​http://bugs.webkit.org/show_bug.cgi?id=14970>

Reviewed by Darin.

  • Plugins/WebNetscapeDeprecatedFunctions.c: Updated copyright statement and added Apple BSD-style license.
  • Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.

WebKitTools:

Please clarify licensing for some files
<​http://bugs.webkit.org/show_bug.cgi?id=14970>

Reviewed by Darin.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Added copyright statement. Replaced license with newer Apple BSD-style license.
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Ditto.
  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Ditto.
  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Ditto.
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Ditto.
  • DumpRenderTree/win/TestNetscapePlugin/main.c: Ditto.
  • mangleme/LICENSE: Added (LGPL).
12:09 AM Changeset in webkit [30519] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • undo an accidental change to a test's expected results from r30431.
  • fast/js/date-DST-time-cusps-expected.txt:
12:03 AM Changeset in webkit [30518] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Sam Weinig and Anders Carlsson.

  • updated results for <rdar://problem/5714333> Add document.getSelection()
  • fast/dom/Window/window-properties-expected.txt:
Note: See TracTimeline for information about the timeline view.