⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 26, 2008:

11:49 PM Changeset in webkit [30618] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch/WebCore

Merge r30617.

10:14 PM Changeset in webkit [30617] by Antti Koivisto
  • 4 edits in trunk/WebCore

Reviewed by Darin.

Fix <rdar://problem/5761326>
REGRESSION: 1.5% -2% Sunspider regression from r30009 (ebay photo upload hang)


Generate better code with VS:

  • Use ALWAYS_INLINE macro to guarantee versions of allowsAccessFrom() are reduced to single functions
  • Refactor error reporting so that there is no need to construct/destruct Strings in common cases
  • Add a separate version of the function for cases where error messages are not wanted
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • bindings/js/kjs_window.cpp: (KJS::Window::allowsAccessFrom): (KJS::Window::allowsAccessFromNoErrorMessage): (KJS::Window::allowsAccessFromPrivate): (KJS::Window::crossDomainAccessErrorMessage):
  • bindings/js/kjs_window.h:
10:03 PM Google Summer of Code 2008 edited by alp@atoker.com
Add cairo SVG and ATK accessibility tasks (diff)
8:14 PM Changeset in webkit [30616] by weinig@apple.com
  • 8 edits
    5 deletes in trunk/WebCore

Reviewed by Dave Hyatt.

  • remove DeprecatedCString, DeprecatedArray, and ArrayImpl.
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • platform/ArrayImpl.cpp: Removed.
  • platform/ArrayImpl.h: Removed.
  • platform/DeprecatedArray.h: Removed.
  • platform/DeprecatedCString.cpp: Removed.
  • platform/DeprecatedCString.h: Removed.
  • platform/text/CString.cpp: (WebCore::CString::length):
  • platform/text/CString.h:
7:12 PM Changeset in webkit [30615] by hyatt@apple.com
  • 7 edits in trunk/WebCore

Cleanup of childrenChanged in preparation for fixing the HTML5 spec slowdown.

Reviewed by Sam Weinig

  • dom/Attr.cpp: (WebCore::Attr::childrenChanged):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::removeChildren): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::addChild): (WebCore::ContainerNode::childrenChanged):
  • dom/ContainerNode.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
  • dom/EventTargetNode.h:
  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::addAttribute): (WebCore::NamedAttrMap::removeAttribute):
5:56 PM Changeset in webkit [30614] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

Improvements to the wx build script.

​http://bugs.webkit.org/show_bug.cgi?id=17492

5:43 PM Changeset in webkit [30613] by Darin Adler
  • 5 edits in trunk/WebCore

Reviewed by Sam.

  • remove use of DeprecatedCString from Windows pasteboard code
  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::createGlobalData): Added an overload for Vector<char>. Streamlined the logic a bit. (WebCore::append): Added. Helper functions for appending to a Vector<char>. (WebCore::markupToCF_HTML): Rewrote to use Vector<char> instead of DeprecatedCString. Also simplified the logic a bit and used macros to handle the integer width. (WebCore::urlToMarkup): Use Vector<UChar> instead of String. (WebCore::replaceNewlinesWithWindowsStyleNewlines): Tweaked.
  • platform/win/ClipboardUtilitiesWin.h: Update type of return value from markupToCF_HTML. Did a bit of streamlining too.
  • platform/win/ClipboardWin.cpp: (WebCore::writeURL): Update for above changes. (WebCore::ClipboardWin::declareAndWriteDragImage): Ditto. (WebCore::ClipboardWin::writeRange): Ditto.
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): Ditto. (WebCore::Pasteboard::writeURL): Ditto.
4:51 PM Changeset in webkit [30612] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move ResourceLoadDelegate methods to WebFrameLoaderClient

Changed all methods to use early returns where possible and COMPtr's
AdoptCOM/Query constructors.

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
4:50 PM Changeset in webkit [30611] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move two more methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (kit): (WebFrameLoaderClient::dispatchCreatePage): Changed nested ifs to early returns, and changed to use the COMPtr Query constructor. (WebFrameLoaderClient::dispatchDidLoadMainResource): Added an early return, and changed to use getWebDataSource.
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
4:50 PM Changeset in webkit [30610] by Adam Roben
  • 3 edits in trunk/WebKit/win

Get rid of IID_WebFrame

Reviewed by Anders.

  • WebFrame.cpp: Removed IID_WebFrame definition. (WebFrame::QueryInterface): Use uuidof(WebFrame) instead of IID_WebFrame. (WebFrame::isDescendantOfFrame): Use COMPtr's Query constructor instead of a manual QueryInterface.
  • WebFrame.h: Removed IID_WebFrame declaration, gave WebFrame a DECLSPEC_UUID.
4:49 PM Changeset in webkit [30609] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move WebHistory-related methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::shouldGoToHistoryItem): (WebFrameLoaderClient::setTitle): Changed some nested ifs into early returns. (WebFrameLoaderClient::webHistory): Changed to return a COMPtr to make the reference management foolproof.
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
4:48 PM Changeset in webkit [30608] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move cache-related methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (getWebDataSource): Moved to the top of the file. (WebFrameLoaderClient::savePlatformDataToCachedPage): (WebFrameLoaderClient::transitionToCommittedForNewPage): (WebFrameLoaderClient::canCachePage):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
4:46 PM Changeset in webkit [30607] by timothy@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Adam Roben.

<rdar://problem/5712777> REGRESSION: Arrow up/down in inspector
source list does not scroll when item at edge is reached (16572)

Use scrollIntoViewIfNeeded() instead of the hand-rolled scrollToElement
we were using in utilities.js.

  • page/inspector/DocumentPanel.js: Use scrollIntoViewIfNeeded instead of scrollToElement.
  • page/inspector/Resource.js: Ditto.
  • page/inspector/inspector.js: Ditto.
  • page/inspector/SourcePanel.js: Use scrollIntoViewIfNeeded instead of scrollIntoView, so the source line is centered in the view if needed.
  • page/inspector/utilities.js: Removed scrollToElement().
3:47 PM Changeset in webkit [30606] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Add a skipped storage test for now

  • platform/win/Skipped: Added storage/multiple-transactions.html
3:17 PM Changeset in webkit [30605] by hyatt@apple.com
  • 6 adds in trunk/LayoutTests/platform/mac/fast/inline
3:17 PM Changeset in webkit [30604] by hyatt@apple.com
  • 2 adds in trunk/LayoutTests/fast/inline
3:17 PM Changeset in webkit [30603] by hyatt@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Dan

​http://bugs.webkit.org/show_bug.cgi?id=17485

Refine our behavior for empty inlines so that they work more correctly with margins/borders/padding.
Fixes a regression on huffingtonpost.com.

New tests added to fast/inline

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::calcMargins):
  • rendering/RenderFlow.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::hasHorizontalBordersPaddingOrMargin): (WebCore::RenderObject::hasHorizontalBordersOrPadding):
  • rendering/bidi.cpp: (WebCore::getBorderPaddingMargin): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::inlineFlowRequiresLineBox):
2:00 PM Changeset in webkit [30602] by Adam Roben
  • 29 edits in branches/Safari-3-1-branch/LayoutTests

Roll out r29650, since r29649 was rolled out in r30483

r29650 updated some test results which changed after r29649 landed.
Now that r29649 has been rolled out of this branch, we need to roll
r29650 out as well to keep the tests passing.

Reviewed by Anders and Mark.

  • platform/mac/fast/inline/001-expected.checksum:
  • platform/mac/fast/inline/001-expected.png:
  • platform/mac/fast/inline/002-expected.checksum:
  • platform/mac/fast/inline/002-expected.png:
  • platform/mac/fast/inline/br-text-decoration-expected.checksum:
  • platform/mac/fast/inline/br-text-decoration-expected.png:
  • platform/mac/fast/inline/continuation-outlines-expected.checksum:
  • platform/mac/fast/inline/continuation-outlines-expected.png:
  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.checksum:
  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.png:
  • platform/mac/fast/inline/dirtyLinesForInline-expected.checksum:
  • platform/mac/fast/inline/dirtyLinesForInline-expected.png:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.checksum:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.png:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.checksum:
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.checksum:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.png:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.txt:
  • platform/mac/fast/inline/inline-borders-with-bidi-override-expected.checksum:
  • platform/mac/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/mac/fast/inline/outline-continuations-expected.checksum:
  • platform/mac/fast/inline/outline-continuations-expected.png:
  • platform/mac/fast/inline/positionedLifetime-expected.checksum:
  • platform/mac/fast/inline/positionedLifetime-expected.png:
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.checksum:
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.png:
1:59 PM Changeset in webkit [30601] by Adam Roben
  • 1 edit
    1 add in branches/Safari-3-1-branch/LayoutTests

Merge r30320.

1:59 PM Changeset in webkit [30600] by Adam Roben
  • 21 edits in branches/Safari-3-1-branch/LayoutTests

Merge r30212.

1:59 PM Changeset in webkit [30599] by Adam Roben
  • 2 edits in branches/Safari-3-1-branch/LayoutTests

Update results for a test that is sensitive to ENABLE_CROSS_DOCUMENT_MESSAGING

Reviewed by Anders.

  • fast/dom/Window/window-function-name-getter-precedence-expected.txt:
1:58 PM Changeset in webkit [30598] by Adam Roben
  • 2 edits in branches/Safari-3-1-branch/LayoutTests

Enable two fixed tests

Reviewed by Anders.

  • platform/win/Skipped:
1:54 PM Changeset in webkit [30597] by timothy@apple.com
  • 6 edits in trunk

.:

Reviewed by Darin Adler.

Add "64" and "64u" make rules to allow easy building of 64-bit versions.

make 64: will build Intel-only 64-bit.
make 64u: will build 4-way universal for PPC and Intel.

  • Makefile:
  • Makefile.shared:

WebKitTools:

Reviewed by Darin Adler.

  • Scripts/build-webkit: Add --universal and --64-bit flags to make building 64-bit architectures easy. Combine the two flags to build 4-way universal.
  • Makefile: Add "64" and "64u" make rules. Fix the universal rule to return non-zero when the build failes.
1:22 PM Changeset in webkit [30596] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix Windows build.

  • platform/text/PlatformString.h: (WebCore::reverseFind):
12:57 PM Google Summer of Code 2008 edited by david.bolter@utoronto.ca
(diff)
12:43 PM Google Summer of Code 2008 edited by david.bolter@utoronto.ca
(diff)
11:01 AM Changeset in webkit [30595] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/dynamic/subtree-table-cell-height.html

  • rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): Exclude table cells, since their height depends on their contents even if the CSS height property is fixed.

LayoutTests:

Reviewed by Darin Adler.

  • fast/dynamic/subtree-table-cell-height.html: Added.
  • platform/mac/fast/dynamic/subtree-table-cell-height-expected.checksum: Added.
  • platform/mac/fast/dynamic/subtree-table-cell-height-expected.png: Added.
  • platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Added.
10:26 AM Changeset in webkit [30594] by jess@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • Scripts/gdb-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in gdb's environment, so that Safari inherits it when launched. Preexisting code in WebKit checks this environment variable, and if set, unsets DYLD_FRAMEWORK_PATH, so that applications launched by Safari continue to use the standard system WebKit.
9:06 AM Changeset in webkit [30593] by weinig@apple.com
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Dan Bernstein.

  • Add a variant of remove that takes a position and a length.
  • wtf/Vector.h: (WTF::Vector::remove):

WebCore:

Reviewed by Dan Bernstein.

Make the cleanPath function in CSSStyleSelector more efficient by using
a Vector<UChar>.

  • css/CSSStyleSelector.cpp: (WebCore::cleanPath): Make this function work on a Vector<UChar> instead of a String. Also remove unnecessary reverseFind call that could be acomplished with two compares. (WebCore::checkPseudoState): Remove reserveCapacity calls now that we are using a stack buffer.
  • platform/text/PlatformString.h: (WebCore::find): Make this find generic enough that it can be used for String::find. (WebCore::reverseFind): Implement reverseFind so that it can be used for with a UChar* and length.
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::find): Use implementation in PlatformString.cpp (WebCore::StringImpl::reverseFind): Ditto,
7:24 AM Google Summer of Code 2008 edited by Adam Roben
Added ideas from the SummerOfCodeIdeas page (diff)
2:15 AM Changeset in webkit [30592] by ap@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Darin. Tweaked and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=17411
Ideographic comma and full stop should be treated as line-breakable characters

Test: fast/text/line-breaks-after-ideographic-comma-or-full-stop.html

  • platform/text/CharacterNames.h: Added ideographicComma and ideographicFullStop.
  • rendering/break_lines.cpp: (WebCore::shouldBreakAfter): Added a workaround for an issue in Unicode 5.0 that is causing this.
12:56 AM Changeset in webkit [30591] by eric@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by eseidel. Landed by eseidel

Fix improperly initialized m_isUpToDate member variable.
Fixs 50+ layout tests when run on Tiger.
​http://bugs.webkit.org/show_bug.cgi?id=17549

  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/mac/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):

Feb 25, 2008:

11:30 PM Google Summer of Code 2008 edited by eric@webkit.org
(diff)
11:05 PM Google Summer of Code 2008 created by eric@webkit.org
10:47 PM Changeset in webkit [30590] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

Test: fast/text/apply-start-width-after-skipped-text.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Improved the logic for when to figure in the padding, border and margin before a text node when the line begins inside a text node.

LayoutTests:

Reviewed by Sam Weinig.

  • fast/text/apply-start-width-after-skipped-text.html: Added.
  • platform/mac/fast/text/apply-start-width-after-skipped-text-expected.checksum: Added.
  • platform/mac/fast/text/apply-start-width-after-skipped-text-expected.png: Added.
  • platform/mac/fast/text/apply-start-width-after-skipped-text-expected.txt: Added.
10:47 PM WikiStart edited by eric@webkit.org
(diff)
10:20 PM Changeset in webkit [30589] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Windows build fix for wx port.

9:00 PM Changeset in webkit [30588] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-02-25 Mark Rowe <​mrowe@apple.com>

Windows build fix.

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformCompare): Implement platformCompare for ResourceResponseCFNet.cpp.
8:25 PM Changeset in webkit [30587] by Beth Dakin
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Geoff.

Fixed for <rdar://problem/5760530> REGRESSION: Assertion failure in
Document::removePendingSheet() from r30438

r30438 added a call to CachedResource::error() from inside
Loader::didReceiveData() if a CSS file 4xxs. There was an
assumption in the loader, though, that either error() would be
called, or didFinishLoading() would be called, so some work is
duplicated in each. Now that we are calling an error() on files
that will also make it to didFinishLoading() (since they succeeded
in the network layer), we need to make sure we do not duplicate the
work. CachedCSSStyleSheet::error() calls checkNotify, which ends up
decrementing the document's pending style sheet counter.
checkNotify() was still getting called, though, through the normal
didFinishLoading code path, and the counter was being decremented
twice. Bad!

  • loader/loader.cpp: (WebCore::Loader::didFinishLoading): (WebCore::Loader::didReceiveData):

LayoutTests:

Reviewed by Geoff.

Test for <rdar://problem/5760530> REGRESSION: Assertion failure in
Document::removePendingSheet() from r30438

  • http/tests/misc/missing-style-sheet-expected.txt: Added.
  • http/tests/misc/missing-style-sheet.html: Added.
8:01 PM Changeset in webkit [30586] by mrowe@apple.com
  • 5 edits in trunk/WebCore

Fix the Gtk, wx and Qt builds.

6:22 PM Changeset in webkit [30585] by mrowe@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix bug number in ChangeLog.

6:21 PM Changeset in webkit [30584] by mrowe@apple.com
  • 20 edits
    4 moves
    8 adds in trunk/WebCore

2008-02-25 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin Adler.

Eliminate some #ifdefs from headers in platform/network.
​http://bugs.webkit.org/show_bug.cgi?id=11786

  • WebCore.base.exp:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/XMLTokenizer.cpp:
  • loader/ResourceLoader.h:
  • platform/network/AuthenticationChallenge.cpp: Removed.
  • platform/network/AuthenticationChallenge.h: Removed.
  • platform/network/AuthenticationChallengeBase.cpp: Copied from platform/network/AuthenticationChallenge.cpp. (WebCore::AuthenticationChallengeBase::AuthenticationChallengeBase): (WebCore::AuthenticationChallengeBase::previousFailureCount): (WebCore::AuthenticationChallengeBase::proposedCredential): (WebCore::AuthenticationChallengeBase::protectionSpace): (WebCore::AuthenticationChallengeBase::failureResponse): (WebCore::AuthenticationChallengeBase::error): (WebCore::AuthenticationChallengeBase::isNull): (WebCore::AuthenticationChallengeBase::nullify): (WebCore::AuthenticationChallengeBase::compare):
  • platform/network/AuthenticationChallengeBase.h: Copied from platform/network/AuthenticationChallenge.h. (WebCore::AuthenticationChallengeBase::platformCompare): (WebCore::operator==): (WebCore::operator!=):
  • platform/network/ResourceError.cpp: Removed.
  • platform/network/ResourceError.h: Removed.
  • platform/network/ResourceErrorBase.cpp: Copied from platform/network/ResourceError.cpp. (WebCore::ResourceErrorBase::lazyInit): (WebCore::ResourceErrorBase::compare):
  • platform/network/ResourceErrorBase.h: Copied from platform/network/ResourceError.h. (WebCore::ResourceErrorBase::isNull): (WebCore::ResourceErrorBase::domain): (WebCore::ResourceErrorBase::errorCode): (WebCore::ResourceErrorBase::failingURL): (WebCore::ResourceErrorBase::localizedDescription): (WebCore::ResourceErrorBase::ResourceErrorBase): (WebCore::ResourceErrorBase::platformLazyInit): (WebCore::ResourceErrorBase::platformCompare): (WebCore::operator==):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::isHTTP): (WebCore::ResourceResponseBase::url): (WebCore::ResourceResponseBase::setUrl): (WebCore::ResourceResponseBase::mimeType): (WebCore::ResourceResponseBase::setMimeType): (WebCore::ResourceResponseBase::expectedContentLength): (WebCore::ResourceResponseBase::setExpectedContentLength): (WebCore::ResourceResponseBase::textEncodingName): (WebCore::ResourceResponseBase::setTextEncodingName): (WebCore::ResourceResponseBase::suggestedFilename): (WebCore::ResourceResponseBase::setSuggestedFilename): (WebCore::ResourceResponseBase::httpStatusCode): (WebCore::ResourceResponseBase::setHTTPStatusCode): (WebCore::ResourceResponseBase::httpStatusText): (WebCore::ResourceResponseBase::setHTTPStatusText): (WebCore::ResourceResponseBase::httpHeaderField): (WebCore::ResourceResponseBase::setHTTPHeaderField): (WebCore::ResourceResponseBase::httpHeaderFields): (WebCore::ResourceResponseBase::isAttachment): (WebCore::ResourceResponseBase::setExpirationDate): (WebCore::ResourceResponseBase::expirationDate): (WebCore::ResourceResponseBase::setLastModifiedDate): (WebCore::ResourceResponseBase::lastModifiedDate): (WebCore::ResourceResponseBase::lazyInit): (WebCore::ResourceResponseBase::compare):
  • platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::ResourceResponseBase): (WebCore::ResourceResponseBase::platformLazyInit): (WebCore::ResourceResponseBase::platformCompare): (WebCore::operator==):
  • platform/network/cf/AuthenticationCF.cpp: (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::platformCompare):
  • platform/network/cf/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::sourceHandle): (WebCore::AuthenticationChallenge::cfURLAuthChallengeRef):
  • platform/network/cf/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::platformLazyInit): (WebCore::ResourceError::platformCompare): (WebCore::ResourceError::operator CFStreamError):
  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
  • platform/network/curl/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge):
  • platform/network/curl/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
  • platform/network/curl/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/mac/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::sender): (WebCore::AuthenticationChallenge::nsURLAuthenticationChallenge):
  • platform/network/mac/AuthenticationMac.mm: (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::platformCompare):
  • platform/network/mac/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
  • platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::platformLazyInit): (WebCore::ResourceError::platformCompare):
  • platform/network/mac/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): (WebCore::ResourceResponse::platformCompare):
  • platform/network/qt/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge):
  • platform/network/qt/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
  • platform/network/qt/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • xml/XSLTProcessor.cpp:
5:06 PM Changeset in webkit [30583] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix run-webkit-tests after r30394

  • Scripts/webkitdirs.pm: Never append _debug to FindSafari's executable name.
5:05 PM Changeset in webkit [30582] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move plugin-related methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::committedLoad): Added some early returns. (WebFrameLoaderClient::receivedData): (WebFrameLoaderClient::finishedLoading): Ditto. (getWebDataSource): (WebFrameLoaderClient::createPlugin):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp: (WebFrame::WebFramePrivate::WebFramePrivate):
  • WebFrame.h:
5:05 PM Changeset in webkit [30581] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move createFrame to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createFrame): (WebFrameLoaderClient::loadURLIntoChild):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
5:04 PM Changeset in webkit [30580] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move progress-related methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::postProgressStartedNotification): (WebFrameLoaderClient::postProgressEstimateChangedNotification): (WebFrameLoaderClient::postProgressFinishedNotification):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
5:01 PM Changeset in webkit [30579] by Adam Roben
  • 3 edits in trunk/WebKit/win

Remove WebFrame::detachedFromParent1

This method was removed from FrameLoaderClient in r19042, but was
never removed from WebFrame.

Reviewed by Anders.

  • WebFrame.cpp:
  • WebFrame.h:
4:52 PM BuildingCairoOnWindows edited by bfulgham@macports.org
(diff)
4:28 PM Changeset in webkit [30578] by beidson@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by T3h Mitz Pettel (Dan Bernstein)

Layout test for already fixed bug <rdar://problem/5729445>

  • storage/multiple-transactions-expected.txt: Added.
  • storage/multiple-transactions.html: Added.
2:57 PM Changeset in webkit [30577] by andersca@apple.com
  • 7 edits in trunk/WebCore

Reviewed by Darin.

Move remaining render style objects over to start with a refcount of 1 and get
rid of DeprecatedDataRef.


  • rendering/DataRef.h: (WebCore::DataRef::operator*): (WebCore::DataRef::operator->):
  • rendering/RenderStyle.h:
  • rendering/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::SVGRenderStyle):
  • rendering/SVGRenderStyle.h: (WebCore::SVGRenderStyle::create): (WebCore::SVGRenderStyle::copy):
  • rendering/SVGRenderStyleDefs.cpp: (StyleFillData::StyleFillData): (StyleStrokeData::StyleStrokeData): (StyleStopData::StyleStopData): (StyleTextData::StyleTextData): (StyleClipData::StyleClipData): (StyleMaskData::StyleMaskData): (StyleMarkerData::StyleMarkerData): (StyleMiscData::StyleMiscData):
  • rendering/SVGRenderStyleDefs.h: (WebCore::StyleFillData::create): (WebCore::StyleFillData::copy): (WebCore::StyleStrokeData::create): (WebCore::StyleStrokeData::copy): (WebCore::StyleStopData::create): (WebCore::StyleStopData::copy): (WebCore::StyleTextData::create): (WebCore::StyleTextData::copy): (WebCore::StyleClipData::create): (WebCore::StyleClipData::copy): (WebCore::StyleMaskData::create): (WebCore::StyleMaskData::copy): (WebCore::StyleMarkerData::create): (WebCore::StyleMarkerData::copy): (WebCore::StyleMiscData::create): (WebCore::StyleMiscData::copy):
2:44 PM Changeset in webkit [30576] by mrowe@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-02-25 Mark Mentovai <​mark@moxienet.com>

Reviewed by Mark Rowe.

Enable CollectorHeapIntrospector to build by itself, as well as in an AllInOneFile build.
​http://bugs.webkit.org/show_bug.cgi?id=17538

  • kjs/CollectorHeapIntrospector.cpp: Provide "using" declaration for WTF::RemoteMemoryReader.
  • kjs/collector.h: Move CollectorHeap declaration here...
  • kjs/collector.cpp: ... from here.
2:03 PM Changeset in webkit [30575] by mitz@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • remove file-static BidiRun variables from bidi.cpp
  • platform/text/BidiResolver.h: (WebCore::BidiResolver::): Initialize m_logicallyLastRun. (WebCore::BidiResolver::logicallyLastRun): Added. (WebCore::BidiResolver::runCount): Made unsigned. (WebCore::::reverseRuns): Changed ints to unsigned. (WebCore::::createBidiRunsForLine): Made this function set m_logicallyLastRun.
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::BidiState::addRun): Removed setting of sLogicallyLastBidiRun. (WebCore::RenderBlock::constructLine): Removed unused start parameter and added run count and first and last run parameters. Replaced end parameter with lastLine boolean and endObject pointer. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added first and logically last run parameters. (WebCore::RenderBlock::computeVerticalPositionsForLine): Added firstRun parameter. (WebCore::RenderBlock::bidiReorderLine): Removed setting of static variables. (WebCore::RenderBlock::layoutInlineChildren): Changed to use BidiState accessors instead of file statics.
1:58 PM Changeset in webkit [30574] by mrowe@apple.com
  • 16 edits
    1 copy
    1 delete in trunk/WebCore

2008-02-25 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Jon Honeycutt.

​http://bugs.webkit.org/show_bug.cgi?id=16924
Bug 16924: Shared PluginDatabase, PluginPackage, and PlugInInfoStore implementations

Add PluginInfoStore.cpp and new PluginDatabase.cpp to GTK+ and Qt ports.
Remove old PlugInInfoStoreQt.cpp as it is obsoleted by shared code.
Add PluginInfoStore, PluginDatabase, and PluginStream files to Wx build.
Add new PluginDatabase.cpp to Windows build.
Add temporary stubs for new PluginDatabase and PluginPackage.
shared classes to GTK+, Qt, and Wx ports.
Copy PluginDatabaseWin.cpp to PluginDatabase.cpp to preserve history.
Remove shared code from PluginDatabaseWin.cpp.
Remove Windows-specific code from PluginDatabase.cpp.
Use PlatformModule and PlatformFileTime instead of HMODULE and FILETIME.

Remove extraneous PluginPackage
from hash() class method prototype. Subsume storeFileVersion into PluginPackage::fetchInfo. Add cross-platform PlatformModuleVersion type definition. Use PlatformModuleVersion to store the module version. Rename m_fileVersion[ML]S to m_moduleVersion. Change compareFileVersion to use PlatformModuleVersion as the argument. Move PluginView::determineQuirks and m_quirks to PluginPackage. Updated determineQuirks for the PlatformModuleVersion.
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCoreSources.bkl:
  • webcore-base.bkl:
  • WebCore.vcproj/WebCore.vcproj:
  • Platform/FileSystem.h:
  • platform/qt/PlugInInfoStoreQt.cpp:
  • platform/gtk/TemporaryLinkStubs.cpp:
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/wx/TemporaryLinkStubs.cpp:
  • plugins/PluginDatabase.cpp:
  • plugins/PluginDatabase.h:
  • plugins/win/PluginDatabaseWin.cpp:
  • plugins/PluginPackage.h:
  • plugins/win/PluginPackageWin.cpp:
  • plugins/PluginView.h:
  • plugins/win/PluginViewWin.cpp:
1:51 PM Changeset in webkit [30573] by andersca@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Make more style objects start out with a refcount of 1.


  • rendering/RenderStyle.cpp: (WebCore::StyleSurroundData::StyleSurroundData): (WebCore::StyleBoxData::StyleBoxData): (WebCore::StyleVisualData::StyleVisualData): (WebCore::StyleBackgroundData::StyleBackgroundData): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleInheritedData::StyleInheritedData):
  • rendering/RenderStyle.h: (WebCore::StyleSurroundData::create): (WebCore::StyleSurroundData::copy): (WebCore::StyleBoxData::create): (WebCore::StyleBoxData::copy): (WebCore::StyleVisualData::create): (WebCore::StyleVisualData::copy): (WebCore::StyleBackgroundData::create): (WebCore::StyleBackgroundData::copy): (WebCore::StyleBackgroundData::~StyleBackgroundData): (WebCore::StyleRareNonInheritedData::create): (WebCore::StyleRareNonInheritedData::copy): (WebCore::StyleRareInheritedData::create): (WebCore::StyleRareInheritedData::copy): (WebCore::StyleInheritedData::create): (WebCore::StyleInheritedData::copy):
12:00 PM Changeset in webkit [30572] by andersca@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Darin.

Make some of the refcounted style objects start out with a refcount of 1.

  • rendering/DataRef.h: Make a DeprecatedDataRef class which is just a copy of the old DataRef class. Change DataRef to use ::create() and ::copy() instead of the constructors. Change DataRef's pointer to be a RefPtr instead.
  • rendering/RenderStyle.cpp: (WebCore::StyleMarqueeData::StyleMarqueeData): (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData): (WebCore::StyleMultiColData::StyleMultiColData): (WebCore::StyleTransformData::StyleTransformData): Start with a RefCount of 1.


  • rendering/RenderStyle.h:
  • rendering/SVGRenderStyle.h: Add ::create() and ::copy() methods. Make not yet converted classes use DeprecatedDataRef.
9:33 AM Changeset in webkit [30571] by Darin Adler
  • 3 edits
    3 adds in trunk

WebCore:

Reviewed by Anders.
Based on a patch by Tim Steele <​timsteele41@gmail.com>.

Test: fast/loader/meta-refresh-anchor-click.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): When load type is FrameLoadTypeRedirectWithLockedHistory, always do a real load. This makes sure that meta refresh loads are treated as real loads rather than anchor scrolls. Also tweaked formatting a bit. (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): This function is an alternate way to complete a load, so it needs to start the redirection timer if redirection has already been scheduled.

LayoutTests:

Reviewed by Anders.

  • fast/loader/meta-refresh-anchor-click-expected.txt: Added.
  • fast/loader/meta-refresh-anchor-click.html: Added.
  • fast/loader/resources/meta-refresh-subframe.html: Added.
9:11 AM Changeset in webkit [30570] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • avoid counting spaces in non-justified text
  • rendering/bidi.cpp: Removed file-static numSpaces. (WebCore::BidiState::addRun): Removed space counting. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added space counting, conditional on the block having the text-align: justify property value. (WebCore::RenderBlock::bidiReorderLine): Removed initialization of numSpaces.
9:10 AM Changeset in webkit [30569] by Darin Adler
  • 2 edits in trunk/WebCore

Requested by Steve.

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::createFrameAtIndex): Put the string into a global variable (because CFSTR is inefficient on Windows).
9:06 AM Changeset in webkit [30568] by Darin Adler
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Adam.

WebCore:

Reviewed by Adam.

  • WebCore.base.exp: Export blankURL, and sort the file.

WebKit/mac:

Reviewed by Adam.

  • WebView/WebArchiver.mm: (+[WebArchiver archiveSelectionInFrame:]): Use blankURL.
  • WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Avoid the variable name URL to avoid clashing with the renamed KURL in the future. Also use blankURL. (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Ditto. (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Ditto. (-[WebFrame loadHTMLString:baseURL:]): Ditto. (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
8:53 AM Changeset in webkit [30567] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

MSVC build fix

  • kjs/testkjs.cpp: (functionQuit): Don't add a return statement after exit(0) for MSVC.
8:52 AM Changeset in webkit [30566] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move many dispatch methods to WebFrameLoaderClient

Reviewed by Sam.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFinishDocumentLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchShow):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
8:52 AM Changeset in webkit [30565] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move two more methods to WebFrameLoaderClient

Reviewed by Sam.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::hasFrameView): (WebFrame::forceLayout):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
5:16 AM Changeset in webkit [30564] by Simon Hausmann
  • 16 edits in trunk/WebCore

Fix compilation with gcc 4.3, added stdio.h and unistd.h inclusions.

5:14 AM Changeset in webkit [30563] by mrowe@apple.com
  • 3 edits
    4 adds in trunk

2008-02-25 Johnny Ding <​johnnyding.webkit@gmail.com>

Reviewed by Darin Adler.

In HTMLTokenizer::write, the code checks 'pendingScripts.isEmpty()' to decide
whether to save prependingSrc or not. However, in HTMLTokenizer::scriptHandler
and HTMLTokenizer::scriptExecution, the code checks testBit:LoadingExtScript
to decide whether to save prependingSrc or not. The later behavior is not right
because, in scriptHandler and scriptExecution, even the pendingScripts queue is
empty, the testBit:LoadingExtScript might be TRUE.

Test: fast/tokenizer/nested-multiple-scripts.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): check pendingScripts.isEmpty() instead of checking state.loadingExtScript(). (WebCore::HTMLTokenizer::scriptExecution): check pendingScripts.isEmpty() instead of checking state.loadingExtScript().

2008-02-25 Johnny Ding <​johnnyding.webkit@gmail.com>

Reviewed by Darin Adler.

  • fast/tokenizer/nested-multiple-scripts-expected.txt: Added.
  • fast/tokenizer/nested-multiple-scripts.html: Added.
  • fast/tokenizer/resources/external-script-1.js: Added.
  • fast/tokenizer/resources/external-script-2.js: Added.
Note: See TracTimeline for information about the timeline view.