⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 27, 2008:

9:38 PM Changeset in webkit [30644] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by John Sullivan.

  • fix <rdar://problem/5607547> Single letter surrounded by soft hyphens can disappear

Test: fast/text/soft-hyphen-2.html

  • rendering/bidi.cpp: (WebCore::chopMidpointsAt): Changed to iterate midpoints backwards, so that if there are two midpoints at the given position, only the last one will be chopped off.

LayoutTests:

Reviewed by John Sullivan.

  • test for <rdar://problem/5607547> Single letter surrounded by soft hyphens can disappear
  • fast/text/soft-hyphen-2.html: Added.
  • platform/mac/fast/text/soft-hyphen-2-expected.checksum: Added.
  • platform/mac/fast/text/soft-hyphen-2-expected.png: Added.
  • platform/mac/fast/text/soft-hyphen-2-expected.txt: Added.
6:52 PM Changeset in webkit [30643] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Updated resource used in the layout test I landed yesterday.
Due to a difference between Foundation on Tiger vs Leopard, the resource generated on
Leopard caused different results on Leopard and Tiger.
Regenerating the resource on Tiger, however, agrees with Leopard.

  • webarchive/loading/resources/cache-expired-subresource.webarchive:
6:23 PM Changeset in webkit [30642] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • make centered text in right-to-left blocks spill over to the left

Test: fast/text/align-center-rtl-spill.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine):

LayoutTests:

Reviewed by Darin Adler.

  • test that centered text in right-to-left blocks spills over to the left
  • fast/text/align-center-rtl-spill.html: Added.
  • platform/mac/fast/text/align-center-rtl-spill-expected.checksum: Added.
  • platform/mac/fast/text/align-center-rtl-spill-expected.png: Added.
  • platform/mac/fast/text/align-center-rtl-spill-expected.txt: Added.
5:40 PM Changeset in webkit [30641] by beidson@apple.com
  • 2 edits in trunk/WebKitLibraries

Tiger build fix

  • libWebKitSystemInterfaceTiger.a:
5:06 PM Changeset in webkit [30640] by mitz@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler.

  • more bidi.cpp cleanup
  • platform/text/BidiResolver.h: (WebCore::BidiCharacterRun::destroy): Added. Overridden by BidiRun . (WebCore::BidiResolver<Iterator, Run>::addRun): Moved BidiState::addRun() here. (WebCore::BidiResolver<Iterator, Run>::appendRun): Changed to use addRun(). (WebCore::BidiResolver<Iterator, Run>::deleteRuns): Changed to use destroy(), avoiding the need to specialize this method in BidiState.
  • rendering/bidi.cpp: (WebCore::BidiRun::destroy): Removed the RenderArena parameter. (WebCore::BidiState::deleteRuns): Removed now-unnecessary specialization. (WebCore::BidiState::addRun): Removed now-unnecessary specialization. (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added a FIXME. (WebCore::RenderBlock::computeVerticalPositionsForLine): (WebCore::buildCompactRuns): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::determineEndPosition): (WebCore::RenderBlock::matchedEndLine): (WebCore::skipNonBreakingSpace): (WebCore::RenderBlock::skipWhitespace): (WebCore::shouldSkipWhitespaceAfterStartObject):
  • rendering/bidi.h: (WebCore::BidiRun): Added m_ prefixes to several member variables.
4:52 PM Changeset in webkit [30639] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch

Versioning.

4:51 PM Changeset in webkit [30638] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.12

New tag.

4:42 PM Changeset in webkit [30637] by beidson@apple.com
  • 4 edits in trunk/WebKitLibraries

Reviewed by Mark Rowe

Removed some unused methods:
WKGetNSURLResponseCalculatedExpiration
WKGetNSURLResponseMustRevalidate

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
4:32 PM Changeset in webkit [30636] by mrowe@apple.com
  • 8 edits in branches/Safari-3-1-branch

Merge r30634.

4:20 PM Changeset in webkit [30635] by eric@webkit.org
  • 6891 edits in trunk/LayoutTests

Rubber-stamped by Adam.

Fix svn:eol-style on all LayoutTest results
I simply ran:
cd LayoutTests
find . -name "*-expected.txt" | xargs svn ps svn:eol-style native

3:59 PM Changeset in webkit [30634] by weinig@apple.com
  • 8 edits in trunk

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5768769>

  • Don't allow cross-origin calls using window.functionName.call(otherFrame) syntax.
  • bindings/js/JSLocation.cpp: (WebCore::jsLocationProtoFuncToString): Do same-origin check.
  • bindings/js/kjs_window.cpp: (KJS::windowProtoFuncAToB): Ditto. (KJS::windowProtoFuncBToA): Ditto. (KJS::windowProtoFuncOpen): Ditto. (KJS::windowProtoFuncClearTimeout): Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Ditto.

LayoutTests:

Reviewed by Darin.

Updates tests for <rdar://problem/5768769>

  • http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
3:13 PM Changeset in webkit [30633] by hyatt@apple.com
  • 56 edits in trunk/WebCore

More cleanup in preparation for fixing the HTML5 spec performance regression.

Reviewed by Sam Weinig

  • dom/Attr.cpp: (WebCore::Attr::childrenChanged):
  • dom/Attr.h:
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::removeChildren): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::addChild): (WebCore::ContainerNode::childrenChanged):
  • dom/ContainerNode.h:
  • dom/Document.cpp: (WebCore::Document::childrenChanged):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::childrenChanged):
  • dom/Element.h:
  • dom/Node.h: (WebCore::Node::childrenChanged):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::childrenChanged):
  • html/HTMLObjectElement.h:
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::childrenChanged):
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::childrenChanged):
  • html/HTMLOptionElement.h:
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::childrenChanged):
  • html/HTMLScriptElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::childrenChanged):
  • html/HTMLSelectElement.h:
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::childrenChanged):
  • html/HTMLStyleElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::childrenChanged):
  • html/HTMLTextAreaElement.h:
  • html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::childrenChanged):
  • html/HTMLTitleElement.h:
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::childrenChanged):
  • svg/SVGClipPathElement.h:
  • svg/SVGDefinitionSrcElement.cpp: (WebCore::SVGDefinitionSrcElement::childrenChanged):
  • svg/SVGDefinitionSrcElement.h:
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::childrenChanged):
  • svg/SVGFontFaceElement.h:
  • svg/SVGFontFaceFormatElement.cpp: (WebCore::SVGFontFaceFormatElement::childrenChanged):
  • svg/SVGFontFaceFormatElement.h:
  • svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::childrenChanged):
  • svg/SVGFontFaceSrcElement.h:
  • svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::childrenChanged):
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::childrenChanged):
  • svg/SVGGElement.h:
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::childrenChanged):
  • svg/SVGGradientElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::childrenChanged):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::childrenChanged):
  • svg/SVGMaskElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::childrenChanged):
  • svg/SVGPatternElement.h:
  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::childrenChanged):
  • svg/SVGStyleElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::childrenChanged):
  • svg/SVGStyledElement.h:
  • svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::childrenChanged):
  • svg/SVGTitleElement.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::childrenChanged):
  • svg/SVGUseElement.h:
3:09 PM Changeset in webkit [30632] by beidson@apple.com
  • 5 edits
    3 adds in trunk

WebKit/mac:

Reviewed by Mark Rowe (code) and Darin (concept)

Much better fix for <rdar://problem/4930688> (see r19549)
Original fix for <rdar://problem/3947312> (and 14 dupes)


Let me tell you a story:
A long time ago, in a cvs repository far, far away, loader code was almost all up in WebKit.
WebArchive code was intertwined with that code in bizarre and complex ways.
During the months long loader re-factoring where we pushed much loader code down into WebCore,
many portions of the WebKit loader were thinned out until they ceased to exist. Others remained
with a sole purpose.

One such section of code whose lineage traces back from WebFrameLoaderClient to WebFrameLoader
to WebLoader was originally rooted in the method [WebLoader loadRequest:]. This method was the
single entry point for almost all loading (network or web archives)

This method would check various headers and other fields on the NSURLRequest and NSURLResponse
to make decisions about the load. If the cache control fields were expired or other conditions
in the headers were met, the load would be forced to go out to the network.

As the loader was moved and tweaked repeatedly, most of this code was pruned or re-factored.
At some point, all that remained was the special cases for loading WebArchives.


Somewhere in the r16,000s, this remaining responsibility was noticed and related methods we renamed
to be WebArchive specific, further cementing the assumed design.

Problem is, the design was bad. A WebArchive is meant to be a static snapshot of a WebPage at a
specific point in time. Referring to the request to see if the resource should be reloaded seems
nonsensical, as does referring to the response headers to see if the resource is "expired". In the
context of loading a WebArchive, available data should *always* be loaded from the WebArchive, at least
during the initial load!

After discovering the secret to reproducing all of these bugs is both emptying our your Foundation
cache and disconnecting your network, it was easy to reproduce the 16 individually reported cases
that were all symptoms of this bug, and easy to verify that they are fixed with this patch.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::willUseArchive): Do not call either form of "canUseArchivedResource()" that inspect the request or response objects - We are loading from a WebArchive, and we should never make the decision to go out to the network when we actually have the resource available.
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Remove two methods that are no longer used anywhere in WebKit

LayoutTests:

Reviewed by Mark Rowe

Test for better fix for <rdar://problem/4930688> (see r19549) and
original fix for <rdar://problem/3947312> (and 14 dupes)


Crafting custom WebArchives for layout tests is a pain and something that should
be resolved if we decide to pursue a new format.

Using a custom php script to act as a stand in for an image resource, I set its
cache-control header to expire immediately. Without the fix for the above bugs,
the resource will be "expired" and an attempt to fetch it from the network will
go out and fail. This failure will manifest with different ResourceLoadDelegate
information, as well as different dimensions in the render tree - the missing
image icon versus the archived image.

With the fix in place, the response will be ignored and the image will be pulled
from the WebArchive.

  • webarchive/loading/cache-expired-subresource-expected.txt: Added.
  • webarchive/loading/cache-expired-subresource.html: Added.
  • webarchive/loading/resources/cache-expired-subresource.webarchive: Added.
3:07 PM Changeset in webkit [30631] by pewtermoose@webkit.org
  • 5 edits
    2 adds in trunk/WebKit

WebKit/mac:

Reviewed by Adam Roben.

Bug 14348: Messing up the inspector by dragging an URL into it
​http://bugs.webkit.org/show_bug.cgi?id=14348
<rdar://problem/5283620> and <rdar://problem/5712808>

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): Remove duplicate preference setting. (-[WebInspectorWindowController webView:dragDestinationActionMaskForDraggingInfo:]):

WebKit/win:

Reviewed by Adam Roben.

Bug 14348: Messing up the inspector by dragging an URL into it
​http://bugs.webkit.org/show_bug.cgi?id=14348
<rdar://problem/5283620> and <rdar://problem/5712808>

Add a new class to handle the Inspector's delegate calls.

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::createPage):
  • WebCoreSupport/WebInspectorDelegate.cpp: Added. (:m_refCount): (WebInspectorDelegate::createInstance): (WebInspectorDelegate::AddRef): (WebInspectorDelegate::Release): (WebInspectorDelegate::dragDestinationActionMaskForDraggingInfo):
  • WebCoreSupport/WebInspectorDelegate.h: Added. (WebInspectorDelegate::QueryInterface): (WebInspectorDelegate::createWebViewWithRequest): (WebInspectorDelegate::webViewShow): (WebInspectorDelegate::webViewClose): (WebInspectorDelegate::webViewFocus): (WebInspectorDelegate::webViewUnfocus): (WebInspectorDelegate::webViewFirstResponder): (WebInspectorDelegate::makeFirstResponder): (WebInspectorDelegate::setStatusText): (WebInspectorDelegate::webViewStatusText): (WebInspectorDelegate::webViewAreToolbarsVisible): (WebInspectorDelegate::setToolbarsVisible): (WebInspectorDelegate::webViewIsStatusBarVisible): (WebInspectorDelegate::setStatusBarVisible): (WebInspectorDelegate::webViewIsResizable): (WebInspectorDelegate::setResizable): (WebInspectorDelegate::setFrame): (WebInspectorDelegate::webViewFrame): (WebInspectorDelegate::setContentRect): (WebInspectorDelegate::webViewContentRect): (WebInspectorDelegate::runJavaScriptAlertPanelWithMessage): (WebInspectorDelegate::runJavaScriptConfirmPanelWithMessage): (WebInspectorDelegate::runJavaScriptTextInputPanelWithPrompt): (WebInspectorDelegate::runBeforeUnloadConfirmPanelWithMessage): (WebInspectorDelegate::runOpenPanelForFileButtonWithResultListener): (WebInspectorDelegate::mouseDidMoveOverElement): (WebInspectorDelegate::contextMenuItemsForElement): (WebInspectorDelegate::validateUserInterfaceItem): (WebInspectorDelegate::shouldPerformAction): (WebInspectorDelegate::willPerformDragDestinationAction): (WebInspectorDelegate::dragSourceActionMaskForPoint): (WebInspectorDelegate::willPerformDragSourceAction): (WebInspectorDelegate::contextMenuItemSelected): (WebInspectorDelegate::hasCustomMenuImplementation): (WebInspectorDelegate::trackCustomPopupMenu): (WebInspectorDelegate::measureCustomMenuItem): (WebInspectorDelegate::drawCustomMenuItem): (WebInspectorDelegate::addCustomMenuDrawingData): (WebInspectorDelegate::cleanUpCustomMenuDrawingData): (WebInspectorDelegate::canTakeFocus): (WebInspectorDelegate::takeFocus): (WebInspectorDelegate::registerUndoWithTarget): (WebInspectorDelegate::removeAllActionsWithTarget): (WebInspectorDelegate::setActionTitle): (WebInspectorDelegate::undo): (WebInspectorDelegate::redo): (WebInspectorDelegate::canUndo): (WebInspectorDelegate::canRedo):
  • WebKit.vcproj/WebKit.vcproj:
2:33 PM Changeset in webkit [30630] by mrowe@apple.com
  • 4 copies
    1 add in releases/Apple/Leopard/Mac OS X Update 10.5.2

Release tags for Mac OS X 10.5.2.

2:30 PM Changeset in webkit [30629] by mrowe@apple.com
  • 4 copies
    1 add in releases/Apple/Leopard/Mac OS X Update 10.5.1

Release tags for Mac OS X 10.5.1 (unchanged from Mac OS X 10.5).

2:20 PM Google Summer of Code 2008 edited by eric@webkit.org
(diff)
2:19 PM Google Summer of Code 2008 edited by eric@webkit.org
(diff)
10:06 AM Changeset in webkit [30628] by kmccullough@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Landing test that was forgotten in the original patch (r30087).

Test for: ​http://bugs.webkit.org/show_bug.cgi?id=17191
HTML5: Client-side database queries should return values of type number

  • storage/sql-data-types-expected.txt: Added.
  • storage/sql-data-types.html: Added.
  • storage/sql-data-types.js: Added.
9:52 AM Changeset in webkit [30627] by ap@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Add bug number to ChangeLog.

9:46 AM Changeset in webkit [30626] by ap@webkit.org
  • 3 edits
    2 adds in trunk

2008-02-27 Julien Chaffraix <​julien.chaffraix@gmail.com>

Reviewed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=17481
Several consecutive calls to XMLHttpRequest::open should dispatch only one readyState event

Test: http/tests/xmlhttprequest/xmlhttprequest-multiple-open.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open):
9:13 AM Changeset in webkit [30625] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

​http://bugs.webkit.org/show_bug.cgi?id=17030
Small buffer overflow within initialization

  • kjs/date_object.cpp: (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate): Remove unnecessary and incorrect memset() calls - GregorianDateTime can initialize itself.
8:50 AM Changeset in webkit [30624] by ap@webkit.org
  • 2 edits in trunk/WebCore

2008-02-27 Sriram Neelakandan <​sriram.neelakandan@gmail.com>

Reviewed, tweaked and landed by ap.

​http://bugs.webkit.org/show_bug.cgi?id=17487
HTMLInput mysteriously fails to work if ICU dat file is missing

  • platform/text/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Assert that the iterator has been opened.
8:38 AM Changeset in webkit [30623] by Adam Roben
  • 2 edits in trunk/WebKit/gtk

Attempt to fix the GTK+ build

  • webkit/webkitwebframe.cpp:
8:34 AM Changeset in webkit [30622] by Adam Roben
  • 1 edit in trunk/WebCore/ChangeLog

Fix revision number in ChangeLog

8:16 AM Changeset in webkit [30621] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix after r30613

  • platform/win/ClipboardWin.cpp:
7:12 AM Changeset in webkit [30620] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Reviewed by Simon.

Small style cleanup, and obvious fix: SVGGElement reacted on
'clipPathUnits' changes, which is a funny copy&paste error.

4:38 AM Changeset in webkit [30619] by Nikolas Zimmermann
  • 4 edits in trunk/WebCore

Reviewed by Simon.

Cleanup coding style. Still on my way to fix dynamic updates of all SVG elements.
Currently at SVGF*. SVGDefs/DescElement don't need any dyn update fixes but cleanups.

Feb 26, 2008:

11:49 PM Changeset in webkit [30618] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch/WebCore

Merge r30617.

10:14 PM Changeset in webkit [30617] by Antti Koivisto
  • 4 edits in trunk/WebCore

Reviewed by Darin.

Fix <rdar://problem/5761326>
REGRESSION: 1.5% -2% Sunspider regression from r30009 (ebay photo upload hang)


Generate better code with VS:

  • Use ALWAYS_INLINE macro to guarantee versions of allowsAccessFrom() are reduced to single functions
  • Refactor error reporting so that there is no need to construct/destruct Strings in common cases
  • Add a separate version of the function for cases where error messages are not wanted
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • bindings/js/kjs_window.cpp: (KJS::Window::allowsAccessFrom): (KJS::Window::allowsAccessFromNoErrorMessage): (KJS::Window::allowsAccessFromPrivate): (KJS::Window::crossDomainAccessErrorMessage):
  • bindings/js/kjs_window.h:
10:03 PM Google Summer of Code 2008 edited by alp@atoker.com
Add cairo SVG and ATK accessibility tasks (diff)
8:14 PM Changeset in webkit [30616] by weinig@apple.com
  • 8 edits
    5 deletes in trunk/WebCore

Reviewed by Dave Hyatt.

  • remove DeprecatedCString, DeprecatedArray, and ArrayImpl.
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • platform/ArrayImpl.cpp: Removed.
  • platform/ArrayImpl.h: Removed.
  • platform/DeprecatedArray.h: Removed.
  • platform/DeprecatedCString.cpp: Removed.
  • platform/DeprecatedCString.h: Removed.
  • platform/text/CString.cpp: (WebCore::CString::length):
  • platform/text/CString.h:
7:12 PM Changeset in webkit [30615] by hyatt@apple.com
  • 7 edits in trunk/WebCore

Cleanup of childrenChanged in preparation for fixing the HTML5 spec slowdown.

Reviewed by Sam Weinig

  • dom/Attr.cpp: (WebCore::Attr::childrenChanged):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::removeChildren): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::addChild): (WebCore::ContainerNode::childrenChanged):
  • dom/ContainerNode.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
  • dom/EventTargetNode.h:
  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::addAttribute): (WebCore::NamedAttrMap::removeAttribute):
5:56 PM Changeset in webkit [30614] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

Improvements to the wx build script.

​http://bugs.webkit.org/show_bug.cgi?id=17492

5:43 PM Changeset in webkit [30613] by Darin Adler
  • 5 edits in trunk/WebCore

Reviewed by Sam.

  • remove use of DeprecatedCString from Windows pasteboard code
  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::createGlobalData): Added an overload for Vector<char>. Streamlined the logic a bit. (WebCore::append): Added. Helper functions for appending to a Vector<char>. (WebCore::markupToCF_HTML): Rewrote to use Vector<char> instead of DeprecatedCString. Also simplified the logic a bit and used macros to handle the integer width. (WebCore::urlToMarkup): Use Vector<UChar> instead of String. (WebCore::replaceNewlinesWithWindowsStyleNewlines): Tweaked.
  • platform/win/ClipboardUtilitiesWin.h: Update type of return value from markupToCF_HTML. Did a bit of streamlining too.
  • platform/win/ClipboardWin.cpp: (WebCore::writeURL): Update for above changes. (WebCore::ClipboardWin::declareAndWriteDragImage): Ditto. (WebCore::ClipboardWin::writeRange): Ditto.
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): Ditto. (WebCore::Pasteboard::writeURL): Ditto.
4:51 PM Changeset in webkit [30612] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move ResourceLoadDelegate methods to WebFrameLoaderClient

Changed all methods to use early returns where possible and COMPtr's
AdoptCOM/Query constructors.

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
4:50 PM Changeset in webkit [30611] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move two more methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (kit): (WebFrameLoaderClient::dispatchCreatePage): Changed nested ifs to early returns, and changed to use the COMPtr Query constructor. (WebFrameLoaderClient::dispatchDidLoadMainResource): Added an early return, and changed to use getWebDataSource.
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
4:50 PM Changeset in webkit [30610] by Adam Roben
  • 3 edits in trunk/WebKit/win

Get rid of IID_WebFrame

Reviewed by Anders.

  • WebFrame.cpp: Removed IID_WebFrame definition. (WebFrame::QueryInterface): Use uuidof(WebFrame) instead of IID_WebFrame. (WebFrame::isDescendantOfFrame): Use COMPtr's Query constructor instead of a manual QueryInterface.
  • WebFrame.h: Removed IID_WebFrame declaration, gave WebFrame a DECLSPEC_UUID.
4:49 PM Changeset in webkit [30609] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move WebHistory-related methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::shouldGoToHistoryItem): (WebFrameLoaderClient::setTitle): Changed some nested ifs into early returns. (WebFrameLoaderClient::webHistory): Changed to return a COMPtr to make the reference management foolproof.
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
4:48 PM Changeset in webkit [30608] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move cache-related methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (getWebDataSource): Moved to the top of the file. (WebFrameLoaderClient::savePlatformDataToCachedPage): (WebFrameLoaderClient::transitionToCommittedForNewPage): (WebFrameLoaderClient::canCachePage):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
4:46 PM Changeset in webkit [30607] by timothy@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Adam Roben.

<rdar://problem/5712777> REGRESSION: Arrow up/down in inspector
source list does not scroll when item at edge is reached (16572)

Use scrollIntoViewIfNeeded() instead of the hand-rolled scrollToElement
we were using in utilities.js.

  • page/inspector/DocumentPanel.js: Use scrollIntoViewIfNeeded instead of scrollToElement.
  • page/inspector/Resource.js: Ditto.
  • page/inspector/inspector.js: Ditto.
  • page/inspector/SourcePanel.js: Use scrollIntoViewIfNeeded instead of scrollIntoView, so the source line is centered in the view if needed.
  • page/inspector/utilities.js: Removed scrollToElement().
3:47 PM Changeset in webkit [30606] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Add a skipped storage test for now

  • platform/win/Skipped: Added storage/multiple-transactions.html
3:17 PM Changeset in webkit [30605] by hyatt@apple.com
  • 6 adds in trunk/LayoutTests/platform/mac/fast/inline
3:17 PM Changeset in webkit [30604] by hyatt@apple.com
  • 2 adds in trunk/LayoutTests/fast/inline
3:17 PM Changeset in webkit [30603] by hyatt@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Dan

​http://bugs.webkit.org/show_bug.cgi?id=17485

Refine our behavior for empty inlines so that they work more correctly with margins/borders/padding.
Fixes a regression on huffingtonpost.com.

New tests added to fast/inline

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::calcMargins):
  • rendering/RenderFlow.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::hasHorizontalBordersPaddingOrMargin): (WebCore::RenderObject::hasHorizontalBordersOrPadding):
  • rendering/bidi.cpp: (WebCore::getBorderPaddingMargin): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::inlineFlowRequiresLineBox):
2:00 PM Changeset in webkit [30602] by Adam Roben
  • 29 edits in branches/Safari-3-1-branch/LayoutTests

Roll out r29650, since r29649 was rolled out in r30483

r29650 updated some test results which changed after r29649 landed.
Now that r29649 has been rolled out of this branch, we need to roll
r29650 out as well to keep the tests passing.

Reviewed by Anders and Mark.

  • platform/mac/fast/inline/001-expected.checksum:
  • platform/mac/fast/inline/001-expected.png:
  • platform/mac/fast/inline/002-expected.checksum:
  • platform/mac/fast/inline/002-expected.png:
  • platform/mac/fast/inline/br-text-decoration-expected.checksum:
  • platform/mac/fast/inline/br-text-decoration-expected.png:
  • platform/mac/fast/inline/continuation-outlines-expected.checksum:
  • platform/mac/fast/inline/continuation-outlines-expected.png:
  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.checksum:
  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.png:
  • platform/mac/fast/inline/dirtyLinesForInline-expected.checksum:
  • platform/mac/fast/inline/dirtyLinesForInline-expected.png:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.checksum:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.png:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.checksum:
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.checksum:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.png:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.txt:
  • platform/mac/fast/inline/inline-borders-with-bidi-override-expected.checksum:
  • platform/mac/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/mac/fast/inline/outline-continuations-expected.checksum:
  • platform/mac/fast/inline/outline-continuations-expected.png:
  • platform/mac/fast/inline/positionedLifetime-expected.checksum:
  • platform/mac/fast/inline/positionedLifetime-expected.png:
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.checksum:
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.png:
1:59 PM Changeset in webkit [30601] by Adam Roben
  • 1 edit
    1 add in branches/Safari-3-1-branch/LayoutTests

Merge r30320.

1:59 PM Changeset in webkit [30600] by Adam Roben
  • 21 edits in branches/Safari-3-1-branch/LayoutTests

Merge r30212.

1:59 PM Changeset in webkit [30599] by Adam Roben
  • 2 edits in branches/Safari-3-1-branch/LayoutTests

Update results for a test that is sensitive to ENABLE_CROSS_DOCUMENT_MESSAGING

Reviewed by Anders.

  • fast/dom/Window/window-function-name-getter-precedence-expected.txt:
1:58 PM Changeset in webkit [30598] by Adam Roben
  • 2 edits in branches/Safari-3-1-branch/LayoutTests

Enable two fixed tests

Reviewed by Anders.

  • platform/win/Skipped:
1:54 PM Changeset in webkit [30597] by timothy@apple.com
  • 6 edits in trunk

.:

Reviewed by Darin Adler.

Add "64" and "64u" make rules to allow easy building of 64-bit versions.

make 64: will build Intel-only 64-bit.
make 64u: will build 4-way universal for PPC and Intel.

  • Makefile:
  • Makefile.shared:

WebKitTools:

Reviewed by Darin Adler.

  • Scripts/build-webkit: Add --universal and --64-bit flags to make building 64-bit architectures easy. Combine the two flags to build 4-way universal.
  • Makefile: Add "64" and "64u" make rules. Fix the universal rule to return non-zero when the build failes.
1:22 PM Changeset in webkit [30596] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix Windows build.

  • platform/text/PlatformString.h: (WebCore::reverseFind):
12:57 PM Google Summer of Code 2008 edited by david.bolter@utoronto.ca
(diff)
12:43 PM Google Summer of Code 2008 edited by david.bolter@utoronto.ca
(diff)
11:01 AM Changeset in webkit [30595] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/dynamic/subtree-table-cell-height.html

  • rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): Exclude table cells, since their height depends on their contents even if the CSS height property is fixed.

LayoutTests:

Reviewed by Darin Adler.

  • fast/dynamic/subtree-table-cell-height.html: Added.
  • platform/mac/fast/dynamic/subtree-table-cell-height-expected.checksum: Added.
  • platform/mac/fast/dynamic/subtree-table-cell-height-expected.png: Added.
  • platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Added.
10:26 AM Changeset in webkit [30594] by jess@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • Scripts/gdb-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in gdb's environment, so that Safari inherits it when launched. Preexisting code in WebKit checks this environment variable, and if set, unsets DYLD_FRAMEWORK_PATH, so that applications launched by Safari continue to use the standard system WebKit.
9:06 AM Changeset in webkit [30593] by weinig@apple.com
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Dan Bernstein.

  • Add a variant of remove that takes a position and a length.
  • wtf/Vector.h: (WTF::Vector::remove):

WebCore:

Reviewed by Dan Bernstein.

Make the cleanPath function in CSSStyleSelector more efficient by using
a Vector<UChar>.

  • css/CSSStyleSelector.cpp: (WebCore::cleanPath): Make this function work on a Vector<UChar> instead of a String. Also remove unnecessary reverseFind call that could be acomplished with two compares. (WebCore::checkPseudoState): Remove reserveCapacity calls now that we are using a stack buffer.
  • platform/text/PlatformString.h: (WebCore::find): Make this find generic enough that it can be used for String::find. (WebCore::reverseFind): Implement reverseFind so that it can be used for with a UChar* and length.
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::find): Use implementation in PlatformString.cpp (WebCore::StringImpl::reverseFind): Ditto,
7:24 AM Google Summer of Code 2008 edited by Adam Roben
Added ideas from the SummerOfCodeIdeas page (diff)
2:15 AM Changeset in webkit [30592] by ap@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Darin. Tweaked and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=17411
Ideographic comma and full stop should be treated as line-breakable characters

Test: fast/text/line-breaks-after-ideographic-comma-or-full-stop.html

  • platform/text/CharacterNames.h: Added ideographicComma and ideographicFullStop.
  • rendering/break_lines.cpp: (WebCore::shouldBreakAfter): Added a workaround for an issue in Unicode 5.0 that is causing this.
12:56 AM Changeset in webkit [30591] by eric@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by eseidel. Landed by eseidel

Fix improperly initialized m_isUpToDate member variable.
Fixs 50+ layout tests when run on Tiger.
​http://bugs.webkit.org/show_bug.cgi?id=17549

  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/mac/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
Note: See TracTimeline for information about the timeline view.