⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 6, 2008:

11:45 PM Changeset in webkit [30869] by oliver@apple.com
  • 8 edits
    2 adds in trunk

Implement the HTML5 canvas tainting rules to prevent potential data leakage

Reviewed by Mitz

Added originClean to HTMLCanvasElement and CanvasPattern
to track whether a canvas (or pattern) is tainted by remote
data.
Use originClean flag to determine whether getImageData should
return, well, image data.

Test: http/tests/security/canvas-remote-read-remote-image.html

7:24 PM ApplicationsGtk edited by alp@atoker.com
Fix app URL (diff)
7:22 PM ApplicationsGtk edited by alp@atoker.com
Add another doc browser (diff)
5:55 PM Changeset in webkit [30868] by andersca@apple.com
  • 7 edits in trunk/WebCore

Reviewed by Jon.

Templatize the JNI call code to reduce the amount of code that has
to be duplicated.

  • bridge/jni/jni_class.cpp: (JavaClass::JavaClass):
  • bridge/jni/jni_instance.cpp: (JavaInstance::stringValue): (JavaInstance::numberValue): (JavaInstance::booleanValue): (JavaInstance::invokeMethod):
  • bridge/jni/jni_jsobject.cpp: (JavaJSObject::convertJObjectToValue):
  • bridge/jni/jni_runtime.cpp: (JavaField::JavaField): (JavaMethod::JavaMethod):
  • bridge/jni/jni_utility.cpp:
  • bridge/jni/jni_utility.h: (KJS::Bindings::): (KJS::Bindings::callJNIMethodIDA): (KJS::Bindings::callJNIMethodV): (KJS::Bindings::callJNIMethod): (KJS::Bindings::callJNIStaticMethod):
5:51 PM Changeset in webkit [30867] by Darin Adler
  • 10 edits in trunk

WebCore:

Reviewed by Mitz.

  • fix regression test failures from the visited-link change
  • WebCore.base.exp: Export PageGroup::setShouldTrackVisitedLinks.
  • page/PageGroup.cpp: (WebCore::PageGroup::addVisitedLink): Do nothing and return early if shouldTrackVisitedLinks is false. (WebCore::PageGroup::removeVisitedLinks): Reset m_visitedLinksPopulated so the next time a link is queried this will be populated from history. (WebCore::PageGroup::setShouldTrackVisitedLinks): Added.
  • page/PageGroup.h: Added setShouldTrackVisitedLinks. This is global for now, but it would be better if it was per-page-group instead.

WebKit/mac:

Reviewed by Mitz.

  • fix regression test failures from the visited-link change
  • History/WebHistory.mm: (+[WebHistory setOptionalSharedHistory:]): Call PageGroup::setShouldTrackVisitedLinks to turn off visited links if there is no history object. Also call removeAllVisitedLinks so we can start over from scratch with the new history.

WebKit/win:

Reviewed by Mitz.

  • fix regression test failures and crashes from the visited-link change
  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::populateVisitedLinks): Check for null before calling addVisitedLinksToPageGroup.
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Ditto.
  • WebHistory.cpp: (WebHistory::setOptionalSharedHistory): Call PageGroup::setShouldTrackVisitedLinks to turn off visited links if there is no history object. Also call removeAllVisitedLinks so we can start over from scratch with the new history.
5:30 PM Changeset in webkit [30866] by adele@apple.com
  • 7 edits
    5 adds in trunk

WebCore:

Reviewed by Darin.

Fixes for for <rdar://problem/5785892> Implement activeElement attribute for HTMLDocument (HTML5)
and <rdar://problem/5785895> Implement hasFocus() for HTMLDocument (HTML5)

Tests: fast/dom/HTMLDocument/activeElement.html

fast/dom/HTMLDocument/hasFocus.html

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::activeElement): Added. Returns the focused element, or the body element if nothing's focused. (WebCore::HTMLDocument::hasFocus): Added. Returns whether or not the document has focus (inclusive of sub-frames).
  • html/HTMLDocument.h: Added methods for activeElement and hasFocus.
  • html/HTMLDocument.idl: Added definitions for activeElement and hasFocus.

WebKitTools:

Reviewed by Darin.

Updated for testing <rdar://problem/5785895> Implement hasFocus() for HTMLDocument (HTML5)

  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webViewFocus:]): Remove duplicate code that was also in LayoutTestController::setWindowIsKey (-[UIDelegate webViewUnfocus:]): Added. In Safari, the default is to focus another window if there is one. To easily test cases where the window is unfocused, I made this just call setWindowIsKey(false).

LayoutTests:

Reviewed by Darin.

Tests for <rdar://problem/5785892> Implement activeElement attribute for HTMLDocument (HTML5)
and <rdar://problem/5785895> Implement hasFocus() for HTMLDocument (HTML5)

  • fast/dom/HTMLDocument/activeElement-expected.txt: Added.
  • fast/dom/HTMLDocument/activeElement.html: Added.
  • fast/dom/HTMLDocument/hasFocus-expected.txt: Added.
  • fast/dom/HTMLDocument/hasFocus.html: Added.
  • fast/dom/HTMLDocument/resources/hasFocus-iframe.html: Added.
5:09 PM Changeset in webkit [30865] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/5741981> 154008 WebKit: Some asian language font glyphs are not shown (in Mail and Entourage)

Test: fast/text/soft-hyphen-3.html

  • rendering/bidi.cpp: (WebCore::checkMidpoints): (WebCore::RenderBlock::findNextLineBreak): Made 'pos' unsigned. Made the midpoint after a hyphen always be a valid iterator, not allowing an offset past the end of a text node. Changed the check for consecutive soft hyphens to account for that.

LayoutTests:

Reviewed by Darin Adler.

  • test and updated results for <rdar://problem/5741981> 154008 WebKit: Some asian language font glyphs are not shown (in Mail and Entourage)
  • fast/text/soft-hyphen-3.html: Added.
  • platform/mac/fast/text/basic/014-expected.txt:
  • platform/mac/fast/text/soft-hyphen-3-expected.checksum: Added.
  • platform/mac/fast/text/soft-hyphen-3-expected.png: Added.
  • platform/mac/fast/text/soft-hyphen-3-expected.txt: Added.
4:28 PM Changeset in webkit [30864] by pewtermoose@webkit.org
  • 4 edits in trunk

WebKit/win:

Reviewed by Adam Roben.

Bug 17691: REGRESSION: FindSafari doesn't work
​http://bugs.webkit.org/show_bug.cgi?id=17691

Swap my change from r30394 to use the Release libraries instead of Debug
since some machines don't have the Debug version.

  • WebKit.vcproj/WebKit.sln:

WebKitTools:

Reviewed by Adam Roben.

Bug 17691: REGRESSION: FindSafari doesn't work
​http://bugs.webkit.org/show_bug.cgi?id=17691

Swap my change from r30394 to use the Release libraries instead of Debug
since some machines don't have the Debug version.

  • FindSafari/FindSafari.vcproj:
4:14 PM Changeset in webkit [30863] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/bindings/scripts/CodeGeneratorCOM.pm

Fix typos.

4:14 PM Changeset in webkit [30862] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

3:39 PM Changeset in webkit [30861] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

3:33 PM Changeset in webkit [30860] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

3:30 PM Changeset in webkit [30859] by mrowe@apple.com
  • 1 copy in tags/Safari-6526

New tag.

3:28 PM Changeset in webkit [30858] by kmccullough@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Sam and Tim.

<rdar://5631450> Drosera: breakpoint indicators disappear after the
script is finished running.

  • If there is a pre-existing breakpoint on a line when the file is updated we need to redraw it.
  • Drosera/debugger.js:
3:11 PM Changeset in webkit [30857] by alp@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-03-06 Alp Toker <​alp@atoker.com>

Fix the build fix in r30845 to support out-of-tree builds.

  • GNUmakefile.am:
1:45 PM Changeset in webkit [30856] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

  • fix a regression from r30741: a crash under WebFrameLoaderClient::createPlugin() when showing a Mail message with an attachment
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
1:09 PM Changeset in webkit [30855] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

  • wtf/ThreadingWin.cpp: (WTF::ThreadCondition::timedWait):
12:58 PM Changeset in webkit [30854] by beidson@apple.com
  • 2 edits in trunk/WebKitTools

Tiger build fix...?

  • DumpRenderTree/mac/WatchdogMac.mm:
12:08 PM Changeset in webkit [30853] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • another small step towards fixing the Qt build
  • JavaScriptCore.pri: Remove more references to the now-obsolete bindings directory.
12:02 PM Changeset in webkit [30852] by Darin Adler
  • 6 edits in trunk

JavaScriptCore:

  • a small step towards fixing the Qt build

WebCore:

  • try to fix Wx build
  • WebCoreSources.bkl: Added PageGroup.cpp.

WebKit/mac:

  • fix Tiger build
  • History/WebHistory.mm: Added include of WebTypesInternal.h.
11:50 AM Changeset in webkit [30851] by beidson@apple.com
  • 2 edits in trunk/JavaScriptCore

Gtk Build fix

  • wtf/ThreadingGtk.cpp: (WTF::ThreadCondition::timedWait):
11:34 AM Changeset in webkit [30850] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Wx build fix.

  • wtf/unicode/icu/CollatorICU.cpp: (WTF::Collator::userDefault): Put ICU workaround under both PLATFORM(DARWIN) and PLATFORM(CF) checks, so that each port can decide if it wants to use CF on Mac for it.
10:55 AM Changeset in webkit [30849] by beidson@apple.com
  • 11 edits
    6 adds in trunk

JavaScriptCore:

Reviewed by Darin

Add a timedWait() method to ThreadCondition

  • wtf/Threading.h:
  • wtf/ThreadingGtk.cpp: (WTF::ThreadCondition::timedWait):
  • wtf/ThreadingNone.cpp: (WTF::ThreadCondition::timedWait):
  • wtf/ThreadingPthreads.cpp: (WTF::ThreadCondition::timedWait):
  • wtf/ThreadingWin.cpp: (WTF::ThreadCondition::timedWait): Needs implementation

WebKitTools:

Reviewed by Darin

Added a cross-platform Watchdog thread to DRT.

The current watchdog in both DRTWin and DRTMac is Timer based. Therefore, deadlocks and long running
main thread hangs still affect DRT.

By placing the watchdog on a thread and having DRT "check in" after each test, long-running hangs
and true deadlocks can be caught.

There is one hook for platform specific code. As I did my development and testing on Mac, and Mac has
sample available, the Mac implementation of this hook samples the process before it is killed.

I arbitrarily chose 30 seconds as the timeout for now - this can be tweaked easily if we find a need.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/Configurations/Base.xcconfig: Added LINKER_DISPLAYS_MANGLED_NAMES
  • DumpRenderTree/ForwardingHeaders/wtf/Locker.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/Threading.h: Added.
  • DumpRenderTree/Watchdog.cpp: Added. (Watchdog::Watchdog): (Watchdog::~Watchdog): (Watchdog::start): (Watchdog::stop): (Watchdog::checkIn): (Watchdog::setWatchdogInterval): (Watchdog::handleHang): (Watchdog::watchdogThreadStart): (Watchdog::watchdogThread):
  • DumpRenderTree/Watchdog.h: Added.
  • DumpRenderTree/mac/WatchdogMac.h: Added.
  • DumpRenderTree/mac/WatchdogMac.mm: Added. (WatchdogMac::handleHang): Sample the process and write it out to a file
  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Setup and start the watchdog before running any tests (runTest): Checkin with the watchdog after each test
10:51 AM Changeset in webkit [30848] by ap@webkit.org
  • 4 edits in trunk/JavaScriptCore

More build fixes.

  • jscore.bkl: Add the wtf/unicode directory.
  • wtf/unicode/CollatorDefault.cpp: (WTF::Collator::userDefault): Use a constructor that does exist.
  • wtf/unicode/icu/CollatorICU.cpp: Mac build fix for case-sensitive file systems.
10:21 AM Changeset in webkit [30847] by Darin Adler
  • 2 edits in trunk/WebKit/mac
  • fix Release build
  • History/WebHistory.mm: (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): Removed underscore. (-[WebHistoryPrivate loadFromURL:collectDiscardedItemsInto:error:]): Added #if. (-[WebHistoryPrivate saveToURL:error:]): Ditto.
10:19 AM Changeset in webkit [30846] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • try to fix the Qt build
10:18 AM Changeset in webkit [30845] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • try to fix the GTK build
  • GNUmakefile.am: Add a -I for the unicode directory.
10:14 AM Changeset in webkit [30844] by Darin Adler
  • 1 edit
    5 copies in trunk/JavaScriptCore
  • try to fix the Mac build
  • icu/unicode/parseerr.h: Copied from ../WebCore/icu/unicode/parseerr.h.
  • icu/unicode/ucol.h: Copied from ../WebCore/icu/unicode/ucol.h.
  • icu/unicode/uloc.h: Copied from ../WebCore/icu/unicode/uloc.h.
  • icu/unicode/unorm.h: Copied from ../WebCore/icu/unicode/unorm.h.
  • icu/unicode/uset.h: Copied from ../WebCore/icu/unicode/uset.h.
9:51 AM Changeset in webkit [30843] by Darin Adler
  • 4 edits in trunk/WebCore
  • fix some builds
  • GNUmakefile.am: Added PageGroup.cpp.
  • WebCore.base.exp: Removed WebCoreHistory.
  • WebCore.pro: Added PageGroup.cpp.
9:50 AM Changeset in webkit [30842] by ap@webkit.org
  • 17 edits
    7 adds in trunk

Reviewed by Darin.

<rdar://problem/5687269> Need to create a Collator abstraction for WebCore and JavaScriptCore

9:45 AM Changeset in webkit [30841] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Adele.

  • add test for r30823 (background-position: inherit)
  • fast/css/background-position-inherit-expected.txt: Added.
  • fast/css/background-position-inherit.html: Added.
9:21 AM Changeset in webkit [30840] by Darin Adler
  • 33 edits
    3 adds
    7 deletes in trunk

WebCore:

Reviewed by Mitz.

This should also make page loading faster due to more efficient visited link coloring.

  • WebCore.base.exp: Updated.
  • WebCore.vcproj/WebCore.vcproj: Added PageGroup.h/cpp, removed GlobalHistory.h/cpp.
  • WebCore.xcodeproj/project.pbxproj: Ditto. Also removed WebCoreHistory.h/m.
  • css/CSSStyleSelector.cpp: Updated includes. (WebCore::CSSStyleSelector::initElementAndPseudoState): Eliminated code to set currentEncodedURL. (WebCore::checkPseudoState): Moved most of the code inside a new PageGroup::isLinkVisited function. (WebCore::CSSStyleSelector::canShareStyleWithElement): Tightened code a bit by using references and only getting colors when needed. (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Ditto.
  • css/CSSStyleSelector.h: Removed EncodedURL, m_encodedURL, and setEncodedURL.
  • dom/Document.cpp: (WebCore::Document::attach): Removed call to setEncodedURL. (WebCore::Document::setURL): Ditto. (WebCore::Document::recalcStyleSelector): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Changed code to use early exit idiom to be a little more readable. (WebCore::FrameLoader::urlsMatchItem): Change to use a reference for slightly better efficiency. (WebCore::FrameLoader::goToItem): Use early exit idiom to be a little more readable. (WebCore::FrameLoader::updateHistoryForStandardLoad): Moved history code back in here and got rid of the helper function updateGlobalHistory, restoring the logic before r30549. Also added a call to the new addVisitedLink function. (WebCore::FrameLoader::updateHistoryForClientRedirect): Added code to call addVisitedLink here. (WebCore::FrameLoader::updateHistoryForBackForwardNavigation): Removed comment. (WebCore::FrameLoader::updateHistoryForReload): Removed call to updateGlobalHistory; we can just go without updating global history or visited links here, at least for now, since it's not clear that a reload is a "history event". (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory): Moved history code back where it was, and added the call to addVisitedLink, just as in updateHistoryForStandardLoad above.
  • loader/FrameLoader.h: Removed updateGlobalHistory function.
  • page/Chrome.cpp: (WebCore::ChromeClient::populateVisitedLinks): Added. Empty placeholder so we don't have to implement this for every port all at once. (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Changed to use the new PageGroup class.
  • page/ChromeClient.h: Added populateVisitedLinks function, used to fill the visited links set from the global history at application startup time.
  • page/FrameTree.cpp: (WebCore::FrameTree::find): Updated to use the new PageGroup class.
  • page/GlobalHistory.h: Removed.
  • page/win/GlobalHistoryWin.cpp: Removed.
  • page/mac/GlobalHistoryMac.mm: Removed.
  • platform/mac/WebCoreHistory.h: Removed.
  • platform/mac/WebCoreHistory.m: Removed.
  • platform/win/WebCoreHistory.cpp: Removed.
  • platform/win/WebCoreHistory.h: Removed.
  • page/Page.cpp: (WebCore::Page::Page): Set m_group to 0. (WebCore::Page::setGroupName): Set up m_group. If the page is not in any group, set it to 0 for now to postpone the cost of creating a group. (WebCore::Page::initGroup): Added. Sets m_group to point to a single-page group; used when getting a group. (WebCore::Page::removeAllVisitedLinks): Added. Calls removeVisitedLinks on all page groups.
  • page/Page.h: Moved enums inside the WebCore namespace. Removed the frameNamespace function and instead added the group and groupPtr functions.
  • page/PageGroup.cpp: Added. Contains all the visited code from the CSSStyleSelector in the isVisitedLink function, but more efficient because we don't allocate memory for the buffer.
  • page/PageGroup.h: Added.
  • platform/gtk/TemporaryLinkStubs.cpp: Removed historyContains.
  • platform/qt/TemporaryLinkStubs.cpp: Removed unneeded include.
  • platform/wx/TemporaryLinkStubs.cpp: Removed historyContains.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Added WebHistoryInternal.h.

WebKit/mac:

Reviewed by Mitz.

  • History/WebHistory.mm: Moved WebHistoryPrivate inside this file. (-[WebHistoryPrivate removeItemFromDateCaches:]): Removed the underscore from this method name, since it's on a private object. (-[WebHistoryPrivate removeItemForURLString:]): Added a call to the PageGroup::removeAllVisitedLinks function if the last URL was removed. (-[WebHistoryPrivate addItemToDateCaches:]): Removed the underscore from this method name, since it's on a private object. (-[WebHistoryPrivate removeAllItems]): Call PageGroup::removeAllVisitedLinks. (-[WebHistoryPrivate ageLimitDate]): Removed the underscore from this method name, since it's on a private object. (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]): Ditto. (-[WebHistoryPrivate saveHistoryGuts:URL:error:]): Ditto. Also changed this to correctly return the error by using the newer version of writeToURL: and removed the FIXME about that. (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Added. Calls addVisitedLink for every link in the history. (-[WebHistory saveToURL:error:]): Removed the FIXME, since we do get the error now. (-[WebHistory addItem:]): Moved into the WebPrivate category. (-[WebHistory addItemForURL:]): Ditto. (-[WebHistory _addItemForURL:title:]): Added. Used for the normal case where we create an item and already know its title. (-[WebHistory ageLimitDate]): Moved into the WebPrivate category. (-[WebHistory containsItemForURLString:]): Ditto. (-[WebHistory removeItem:]): Ditto. (-[WebHistory setLastVisitedTimeInterval:forItem:]): Ditto. (-[WebHistory _itemForURLString:]): Ditto. (-[WebHistory _addVisitedLinksToPageGroup:]): Added. For use only inside WebKit.
  • History/WebHistoryInternal.h: Added.
  • History/WebHistoryItemInternal.h: Tweaked formatting and includes.
  • History/WebHistoryPrivate.h: Moved the WebHistoryPrivate class out of this header. Also reorganized what was left behind.
  • WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks.
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::populateVisitedLinks): Added a call to the new -[WebHistory _addVisitedLinksToPageGroup:] method.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Changed code to use the new -[WebHistory _addItemForURL:title:] method.

WebKit/win:

Reviewed by Mitz.

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::populateVisitedLinks): Added a call to the new WebHistory::addVisitedLinksToPageGroup function.
  • WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks. Also fixed the webView function to be non-virtual.
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Changed to use the new WebHistory::addItem function. (WebFrameLoaderClient::webHistory): Changed to return a WebHistory*, there's no reason to AddRef the result from this function.
  • WebCoreSupport/WebFrameLoaderClient.h: Ditto.
  • WebHistory.cpp: Removed IWebHistoryPrivate and _WebCoreHistoryProvider. (WebHistory::QueryInterface): Removed IWebHistoryPrivate. (sharedHistoryStorage): Added. (WebHistory::sharedHistory): Added. (WebHistory::optionalSharedHistory): Changed to use sharedHistory(). (WebHistory::setOptionalSharedHistory): Changed to require a WebHistory object, not just an IWebHistory. (WebHistory::removeAllItems): Call PageGroup::removeAllVisitedLinks. (WebHistory::addItem): Changed parameter types since this is called with arguments from WebCore -- at some point this could allow better efficiency. (WebHistory::removeItemForURLString): Call PageGroup::removeAllVisitedLinks if the last URL is being removed. (addVisitedLinkToPageGroup): Added. Helper. Adds a single link to a group's visited link set. (WebHistory::addVisitedLinksToPageGroup): Added. Adds all links to a group's visited link.
  • WebHistory.h: Removed IWebHistoryPrivate. Removed optionalSharedHistoryInternal and added sharedHistory. Replaced addItemForURL and containsItemForURLString with non-virtual addItem and addVisitedLinksToPageGroup functions.
9:03 AM Changeset in webkit [30839] by timothy@apple.com
  • 1 edit
    4 adds in trunk/WebKitSite

Rubber-stamped by Adam Roben.

Add a simple page that has various demo functions for Drosera.

  • demos/drosera: Added.
  • demos/drosera/demo.js: Added.
  • demos/drosera/drosera.png: Added.
  • demos/drosera/index.html: Added.
8:15 AM Changeset in webkit [30838] by Adam Roben
  • 5 edits
    2 moves in trunk/WebKit

Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}

WebKit:

Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}

Reviewed by Kevin M.

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}

Reviewed by Kevin M.

  • WebView/WebFrame.mm:
  • WebView/WebScriptDebugDelegate.mm:
  • WebView/WebScriptDebugger.h: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.h.
  • WebView/WebScriptDebugger.mm: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.mm.
8:15 AM Changeset in webkit [30837] by Adam Roben
  • 5 edits in trunk/WebKit/mac

Rename WebCoreScriptDebuggerImp to WebScriptDebugger

Reviewed by Kevin M.

  • WebView/WebCoreScriptDebuggerImp.h:
  • WebView/WebCoreScriptDebuggerImp.mm:
  • WebView/WebFrame.mm: (-[WebFrame _attachScriptDebugger]):
  • WebView/WebFrameInternal.h:
8:14 AM Changeset in webkit [30836] by Adam Roben
  • 7 edits
    1 delete in trunk/WebKit

Remove WebScriptDebugger

WebKit:

Remove WebScriptDebugger

Reviewed by Kevin M.

  • WebKit.xcodeproj/project.pbxproj: Remove WebScriptDebugDelegatePrivate.h from the project.

WebKit/mac:

Remove WebScriptDebugger

Uses of WebScriptDebugger have been replaced with
WebCoreScriptDebuggerImp.

Reviewed by Kevin M.

  • WebView/WebFrame.mm: (-[WebFramePrivate dealloc]): Use delete instead of release since WebCoreScriptDebuggerImp is a C++ class. (-[WebFrame _attachScriptDebugger]): Updated to use early returns and WebCoreScriptDebuggerImp. (-[WebFrame _detachScriptDebugger]): Ditto.
  • WebView/WebFrameInternal.h:
  • WebView/WebScriptDebugDelegate.mm: Removed WebScriptDebugger
  • WebView/WebScriptDebugDelegatePrivate.h: Removed.
  • WebView/WebView.mm:
8:14 AM Changeset in webkit [30835] by Adam Roben
  • 8 edits in trunk

Remove -webFrame and -globalObject from WebScriptDebugger

WebCore:

Export a header/symbol for WebKit

Reviewed by Kevin M.

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:

WebKit/mac:

Remove -webFrame and -globalObject from WebScriptDebugger

WebCoreScriptDebuggerImp is now unaware of WebScriptDebugger

Reviewed by Kevin M.

  • WebView/WebCoreScriptDebuggerImp.h: Removed WebScriptDebugger* parameter to the constructor.
  • WebView/WebCoreScriptDebuggerImp.mm: (toWebFrame): Added. (WebCoreScriptDebuggerImp::sourceParsed): Call toWebFrame. (WebCoreScriptDebuggerImp::callEvent): Ditto, and get the Frame's WindowScriptObject ourselves instead of asking WebScriptDebugger for it. (WebCoreScriptDebuggerImp::atStatement): Call toWebFrame. (WebCoreScriptDebuggerImp::returnEvent): Ditto. (WebCoreScriptDebuggerImp::exception): Ditto.
  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptDebugger initWithWebFrame:]): Updated for change to WebScriptDebuggerImp's constructor.
  • WebView/WebScriptDebugDelegatePrivate.h: Removed -webFrame/-globalObject.
8:13 AM Changeset in webkit [30834] by Adam Roben
  • 5 edits in trunk/WebKit/mac

Remove -enterFrame: and -leaveFrame from WebScriptDebugger

Reviewed by Kevin M.

  • WebView/WebCoreScriptDebuggerImp.h: Changed to store m_topCallFrame in a RetainPtr, now that WebCoreScriptDebuggerImp is in charge of its lifetime.
  • WebView/WebCoreScriptDebuggerImp.mm:
    • Added declaration of -[WebScriptCallFrame _initWithGlobalObject:caller:state:].
    • Changed most uses of m_topCallFrame to m_topCallFrame.get()

(WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Removed
now-unnecessary initialization of m_topCallFrame.
(WebCoreScriptDebuggerImp::callEvent): Replaced call to enterFrame:
with its implementation. The one difference between this
implementation and the old enterFrame: method is that we don't hand
our reference to m_topCallFrame to _initWithGlobalObject: -- that
method must now retain the passed-in WebScriptCallFrame manually.
(WebCoreScriptDebuggerImp::atStatement):
(WebCoreScriptDebuggerImp::returnEvent): Replaced call to leaveFrame
with its implementation.
(WebCoreScriptDebuggerImp::exception):

  • WebView/WebScriptDebugDelegate.mm: Removed declaration of -[WebScriptCallFrame _initWithGlobalObject:caller:state:]. (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Changed to retain the passed-in caller.
  • WebView/WebScriptDebugDelegatePrivate.h:
    • Removed _current ivar
    • Removed enterFrame:/leaveFrame declarations.
8:13 AM Changeset in webkit [30833] by Adam Roben
  • 4 edits in trunk/WebKit/mac

Remove -parsedSource: from WebScriptDebugger

Reviewed by Kevin M.

  • WebView/WebCoreScriptDebuggerImp.mm: (WebCoreScriptDebuggerImp::sourceParsed): Moved code here from -[WebScriptDebugger parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]
  • WebView/WebScriptDebugDelegate.mm: Removed -parsedSource:.
  • WebView/WebScriptDebugDelegatePrivate.h: Ditto.
8:13 AM Changeset in webkit [30832] by Adam Roben
  • 4 edits in trunk/WebKit/mac

Remove -enteredFrame:, -leavingFrame:, and -exceptionRaised: from WebScriptDebugger

Reviewed by Kevin M.

  • WebView/WebCoreScriptDebuggerImp.mm: (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Changed to call trhough to callEvent instead of duplicating its code here. (WebCoreScriptDebuggerImp::callEvent): Moved code from -[WebScriptDebugger enteredFrame:sourceId:line:] here. (WebCoreScriptDebuggerImp::returnEvent): Moved code from -[WebScriptDebugger leavingFrame:sourceId:line:] here. (WebCoreScriptDebuggerImp::exception): Moved code from -[WebScriptDebugger exceptionRaised:sourceId:line:] here.
  • WebView/WebScriptDebugDelegate.mm: Removed -enteredFrame:, -leavingFrame:, and -exceptionRaised:.
  • WebView/WebScriptDebugDelegatePrivate.h: Ditto.
8:13 AM Changeset in webkit [30831] by Adam Roben
  • 4 edits in trunk/WebKit/mac

Remove -[WebScriptDebugger hitStatement:sourceId:line:]

Reviewed by Kevin M.

  • WebView/WebCoreScriptDebuggerImp.mm: (WebCoreScriptDebuggerImp::atStatement): Moved code here from -[WebScriptDebugger hitStatement:sourceId:line:].
  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptDebugger webFrame]): Added.
  • WebView/WebScriptDebugDelegatePrivate.h:
8:12 AM Changeset in webkit [30830] by Adam Roben
  • 7 edits
    2 deletes in trunk/WebKit

Remove WebCoreScriptDebugger

WebKit:

Remove WebCoreScriptDebugger.{h,mm}

Reviewed by Kevin M.

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

Remove WebCoreScriptDebugger

Reviewed by Kevin M.

  • WebView/WebCoreScriptDebugger.h: Removed.
  • WebView/WebCoreScriptDebugger.mm: Removed.
  • WebView/WebCoreScriptDebuggerImp.h: Replaced WebCoreScriptDebugger with WebScriptDebugger.
  • WebView/WebCoreScriptDebuggerImp.mm: Ditto, and replaced [m_debugger delegate] with just m_debugger. (toNSString): Moved here from WebCoreScriptDebugger.mm. (toNSURL): Ditto. (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): (WebCoreScriptDebuggerImp::sourceParsed): (WebCoreScriptDebuggerImp::callEvent): (WebCoreScriptDebuggerImp::atStatement): (WebCoreScriptDebuggerImp::returnEvent): (WebCoreScriptDebuggerImp::exception):
  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptDebugger initWithWebFrame:]): _debugger now holds a WebCoreScriptDebuggerImp, so initialize it properly.
  • WebView/WebScriptDebugDelegatePrivate.h: Changed _debugger to hold a WebCoreScriptDebuggerImp.
8:12 AM Changeset in webkit [30829] by Adam Roben
  • 5 edits
    2 adds in trunk/WebKit

Move WebCoreScriptDebuggerImp to its own source files

WebKit:

Move WebCoreScriptDebuggerImp to its own source files

Reviewed by Kevin M.

  • WebKit.xcodeproj/project.pbxproj: Added new files to the project.

WebKit/mac:

Move WebCoreScriptDebuggerImp to its own source files

Also changed WebCoreScriptDebuggerImp coding style to match our style
guidelines.

Reviewed by Kevin M.

  • WebView/WebCoreScriptDebugger.h: Added declaration of toNSURL function.
  • WebView/WebCoreScriptDebugger.mm: Removed WebCoreScriptDebuggerImp implementation. (toNSURL): Made no longer static.
  • WebView/WebCoreScriptDebuggerImp.h: Added.
  • WebView/WebCoreScriptDebuggerImp.mm: Added. Code was moved here from WebCoreScriptDebugger.mm and cleaned up. (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): (WebCoreScriptDebuggerImp::sourceParsed): (WebCoreScriptDebuggerImp::callEvent): (WebCoreScriptDebuggerImp::atStatement): (WebCoreScriptDebuggerImp::returnEvent): (WebCoreScriptDebuggerImp::exception):
8:12 AM Changeset in webkit [30828] by Adam Roben
  • 5 edits in trunk/WebKit/mac

Move -_enterFrame and -_leaveFrame from WebCoreScriptDebugger to WebScriptDebugger

Reviewed by Kevin M.

  • WebView/WebCoreScriptDebugger.h:
    • Removed newFrameWithGlobalObject:caller:state: from WebScriptDebugger protocol
    • Added enterFrame: and leaveFrame: to WebScriptDebugger protocol
    • Removed _current ivar from WebCoreScriptDebugger
  • WebView/WebCoreScriptDebugger.mm: (WebCoreScriptDebuggerImp::callEvent): Changed to call enterFrame on the delegate. (WebCoreScriptDebuggerImp::returnEvent): Ditto for leaveFrame.
  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptDebugger dealloc]): Added code to release _current. (-[WebScriptDebugger enterFrame:]): Added. Code came from WebCoreScriptDebugger. (-[WebScriptDebugger leaveFrame]): Ditto.
  • WebView/WebScriptDebugDelegatePrivate.h: Added _current ivar.
4:15 AM Changeset in webkit [30827] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit

Name the WebKit build phase script that generates WebKit.LP64.exp.

  • WebKit.xcodeproj/project.pbxproj: Name the build phase script that generates the 64-bit export file to match the corresponding build phase script in WebCore.
1:40 AM Changeset in webkit [30826] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix 64-bit Mac build.

1:24 AM Changeset in webkit [30825] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Leopard build fix.

Mar 5, 2008:

10:26 PM Changeset in webkit [30824] by kevino@webkit.org
  • 7 edits in trunk

Fix the wx build after the bindings move.

10:20 PM Changeset in webkit [30823] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adele Peterson.

  • fix "background-position: inherit"
  • css/CSSStyleSelector.cpp: Made HANDLE_MULTILAYER_INHERIT_AND_INITIAL fall through and added a return statement in HANDLE_MULTILAYER_VALUE. Also removed an unused macro.
10:18 PM Changeset in webkit [30822] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-03-05 Alp Toker <​alp@atoker.com>

Add a missing make dependency for derived sources to improve
autotools build dependency tracking.

Issue spotted by Ori Bernstein.

  • GNUmakefile.am:
8:44 PM Changeset in webkit [30821] by alp@webkit.org
  • 4 edits in trunk

2008-03-05 Alp Toker <​alp@atoker.com>

GTK+ build fix for breakage introduced in r30800.

Track moved bridge sources from JavaScriptCore to WebCore.

  • GNUmakefile.am:
8:07 PM Changeset in webkit [30820] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

One part of fix for:
<rdar://problem/5780697> Copying content with percentage based rules in a style sheet will cause fidelity issues

  • editing/markup.cpp: (WebCore::appendStartMarkup): Styles from matched rules should take precedence over those in inline style declarations, not the other way around.

LayoutTests:

Reviewed by Darin.


<rdar://problem/5780697> Copying content with CSS property values that are percentages can cause fidelity issues

  • editing/pasteboard/5780697-1-expected.txt: Added.
  • editing/pasteboard/5780697-1.html: Added.
8:02 PM Changeset in webkit [30819] by alp@webkit.org
  • 1 edit in trunk/WebKitTools/Scripts/webkitdirs.pm

Another buildbot fix attempt, pass SHELL=/bin/bash

7:49 PM Changeset in webkit [30818] by alp@webkit.org
  • 2 edits in trunk/WebKitTools

2008-03-05 Alp Toker <​alp@atoker.com>

Attempt to get the autotools build working again on the bot with
build-webkit.

Force the use of /bin/bash since we seem to have bash-isms in the
configure script right now.

  • Scripts/webkitdirs.pm:
6:21 PM Changeset in webkit [30817] by mrowe@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix typo in ChangeLog.

6:08 PM Changeset in webkit [30816] by andersca@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Darin.

Move JNI specific code from runtime_root over to jni_jsobject, where it is used.

  • bridge/jni/jni_jsobject.cpp: (completedJavaScriptAccess): (initializeJavaScriptAccessLock): (lockJavaScriptAccess): (unlockJavaScriptAccess): (dispatchToJavaScriptThread): (performJavaScriptAccess): (JavaJSObject::initializeJNIThreading): (isJavaScriptThread): (JavaJSObject::invoke):
  • bridge/jni/jni_jsobject.h:
  • bridge/runtime_root.cpp:
  • bridge/runtime_root.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge init]):
6:05 PM Changeset in webkit [30815] by Darin Adler
  • 4 edits in trunk/WebCore

Reviewed by Sam.

  • add functions giving offsets within a KURL, slated to replace the EncodedURL object in CSSStyleSelector (in a future "visited link" change)
  • chagned all KURL data members names to use the traditional m_ prefix
  • initialize all members to 0 in invalid KURLs rather than having all functions check m_isValid
  • platform/KURL.cpp: (WebCore::KURL::invalidate): Added. Initializes all the fields except for m_string to the "invalid" values. For use in the empty constructor and in the init and parse functions. (WebCore::KURL::init): Tweaked comments. Changed all code paths that return early to use the invalidate() function. Updated for member variable name changes. (WebCore::KURL::hasPath): Updated for member variable name changes. Remove now-unneeded check of m_isValid. (WebCore::KURL::lastPathComponent): Ditto. (WebCore::KURL::protocol): Ditto. (WebCore::KURL::host): Ditto. (WebCore::KURL::port): Ditto. (WebCore::KURL::pass): Ditto. (WebCore::KURL::user): Ditto. (WebCore::KURL::ref): Ditto. (WebCore::KURL::hasRef): Ditto. (WebCore::KURL::protocolIs): Ditto. (WebCore::KURL::query): Ditto. (WebCore::KURL::path): Ditto. (WebCore::KURL::setProtocol): Ditto. (WebCore::KURL::setHost): Ditto. (WebCore::KURL::setPort): Ditto. (WebCore::KURL::setHostAndPort): Ditto. (WebCore::KURL::setUser): Ditto. (WebCore::KURL::setPass): Ditto. (WebCore::KURL::setRef): Ditto. (WebCore::KURL::setQuery): Ditto. (WebCore::KURL::setPath): Ditto. (WebCore::KURL::prettyURL): Ditto. (WebCore::copyPathRemovingDots): Removed braces to match our code style. (WebCore::KURL::parse): Changed all code paths that return early to use the invalidate function. Moved code to set m_isValid to true to the very end of the function. Removed braces to match our code style. Removed an extra copy of the path/query/fragment code (there were two identical copies in the two sides of an if statement). Removed some commented-out code. Reversed an if statment. Added code to set the new m_pathAfterLastSlash field. Updated for member variable name changes. (WebCore::equalIgnoringRef): Updated for member variable name changes. (WebCore::KURL::isHierarchical): Ditto.
  • platform/KURL.h: Added a FIXME about ref vs. fragment. Made the empty constructor inline and called the new invalidate function. Added new pathStart, pathEnd, and pathAfterLastSlash functions, for use in the new visited link code. Added an invalidate function. Renamed all the data members to use the m_ prefix.
  • WebCore.base.exp: Updated.
5:39 PM Changeset in webkit [30814] by andersca@apple.com
  • 7 edits in trunk/WebCore

Reviewed by Sam.

  • WebCore.xcodeproj/project.pbxproj: Change jni_jsobject.cpp to be Obj-C++ for now. The plan is to merge this with jni_objc.mm and create jni_jsobject.mm.


  • bridge/jni/jni_jsobject.cpp: (createRootObject): Move createRootObject here from WebCoreFrameBridge.


(JavaJSObject::createNative):
Call the newly added createRootObject function.


  • bridge/runtime_root.cpp: (KJS::Bindings::RootObject::initializeJNIThreading):
  • bridge/runtime_root.h: setCreateRootObject no longer takes a root object, rename it to initializeJNIThreading.
  • page/mac/FrameMac.mm: (WebCore::Frame::createScriptInstanceForWidget): Just call Frame::createRootObject here.


  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge init]): Call initializeJNIThreading.
3:52 PM Changeset in webkit [30813] by andersca@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Sam.

Change some static class variables to be regular static variables,
making it easier to move the chunk of mac-specific code out of runtime_root.[cpp|h]

  • bridge/runtime_root.cpp: (KJS::Bindings::completedJavaScriptAccess): (KJS::Bindings::RootObject::dispatchToJavaScriptThread): (KJS::Bindings::performJavaScriptAccess): (KJS::Bindings::RootObject::createRootObject): (KJS::Bindings::RootObject::runLoop): (KJS::Bindings::RootObject::setCreateRootObject):
  • bridge/runtime_root.h:
2:44 PM Changeset in webkit [30812] by mrowe@apple.com
  • 7 edits in trunk

2008-03-05 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Adam Roben.

Modify source files to use the USE(SAFARI_THEME) macro, rather than
USE_SAFARI_THEME. (​http://bugs.webkit.org/show_bug.cgi?id=17683)

  • WebCore/platform/win/PlatformScrollBarSafari.cpp
  • WebCore/rendering/RenderThemeSafari.cpp
  • WebCore/rendering/RenderThemeSafari.h
  • config.h: Move definition of WTF_USE_SAFARI_THEME here

2008-03-05 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Adam Roben.

Remove definition of WTF_USE_SAFARI_THEME from wtf/Platform.h
because the PLATFORM(CG) flag is not set until config.h has
already included this file.

  • wtf/Platform.h: Remove useless definition of WTF_USE_SAFARI_THEME
2:26 PM Changeset in webkit [30811] by beidson@apple.com
  • 6 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Alexey and Mark Rowe

Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html

DatabaseThread::unscheduleDatabaseTasks() manually filters through a MessageQueue,
removing particular items for Databases that were shutting down.

This filtering operation is not atomic, and therefore causes a race condition with the
MessageQueue waking up and reading from the message queue.

The end result was an attempt to dereference a null DatabaseTask. Timing-wise, this never
seemed to happen in a debug build, otherwise an assertion would've caught it. Replacing that
assertion with a crash in a release build is what revealed this bug.

  • wtf/MessageQueue.h: (WTF::::waitForMessage): Tweak the waiting logic to check the queue's empty state then go back to sleep if the queue was empty - checking m_killed each time it wakes up.

WebCore:

Reviewed by Alexey and Mark Rowe

Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html

DatabaseThread::unscheduleDatabaseTasks() manually filters through a MessageQueue,
removing particular items for Databases that were shutting down.

This filtering operation is not atomic, and therefore causes a race condition with the
database thread waking up and reading from the message queue.

The end result was an attempt to dereference a null DatabaseTask. Timing-wise, this never
seemed to happen in a debug build, otherwise an assertion would've caught it. Replacing that
assertion with a crash in a release build is what revealed this bug.

The fix for the above symptom was entirely in WTF::MessageQueue in JSCore. With this fix in
place, another crash popped up in the layout tests that was related to dereferencing a
deallocated object - simply because SQLTransaction had a raw pointer to it's Database object
when it needed to be a ref pointer.

  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::runCurrentStatement):
  • storage/SQLTransaction.h: Change m_database to be a RefPtr (WebCore::SQLTransaction::database):

LayoutTests:

Reviewed by Alexey + Mark Rowe

Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html

This test takes its best shot at handling two databases on a single database thread at once,
then having one of those databases go away completely (garbage collection and everything)

  • storage/multiple-databases-garbage-collection-expected.txt: Added.
  • storage/multiple-databases-garbage-collection.html: Added.
2:20 PM Changeset in webkit [30810] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

Remove unused header includes from interpreter.cpp.

Reviewed by Darin.

  • kjs/interpreter.cpp: Remove unused header includes.
2:08 PM Changeset in webkit [30809] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Build fix. Remove symbol that no longer exists from the exports file.

1:51 PM Changeset in webkit [30808] by ddkilzer@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fixed commit date.

12:56 PM Changeset in webkit [30807] by alp@webkit.org
  • 2 edits in trunk/WebKitTools

2008-03-05 Alp Toker <​alp@atoker.com>

Re-attempt to switch to the autotools build system for GTK+.

Change scripts to continue when distclean fails.

  • Scripts/webkitdirs.pm:
11:35 AM Changeset in webkit [30806] by Adam Roben
  • 5 edits in trunk/WebKit/mac

Remove WebCoreScriptCallFrame

Reviewed by Tim.

  • WebView/WebCoreScriptDebugger.h:
    • Replaced WebCoreScriptCallFrame with WebScriptCallFrame
    • Replaced -newWrapperForFrame: with -newFrameWithGlobalObject:caller:state:
    • Removed WebCoreScriptCallFrame interface.
  • WebView/WebCoreScriptDebugger.mm: Replaced WebCoreScriptCallFrame with WebScriptCallFrame. (-[WebCoreScriptDebugger _enterFrame:]): Changed to call -newFrameWithGlobalObject:caller:state. (-[WebCoreScriptDebugger _leaveFrame]):
  • WebView/WebScriptDebugDelegate.h: Changed WebScriptCallFrame's _private ivar to be of type WebScriptCallFramePrivate*.
  • WebView/WebScriptDebugDelegate.mm:
    • Replaced WebCoreScriptCallFrame with WebScriptCallFrame
    • Added WebScriptCallFramePrivate

(-[WebScriptDebugger enteredFrame:sourceId:line:]):
(-[WebScriptDebugger hitStatement:sourceId:line:]):
(-[WebScriptDebugger leavingFrame:sourceId:line:]):
(-[WebScriptDebugger exceptionRaised:sourceId:line:]):
(-[WebScriptCallFramePrivate dealloc]): Added.
(-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Added.
Code came from WebCoreScriptCallFrame.
(-[WebScriptCallFrame dealloc]): Added a call to release the _private
ivar.
(-[WebScriptCallFrame _convertValueToObjcValue:]): Replaced calls to
_private with direct access of _private's ivars.
(-[WebScriptCallFrame caller]): Ditto.
(-[WebScriptCallFrame scopeChain]): Ditto.
(-[WebScriptCallFrame evaluateWebScript:]): Ditto.

11:35 AM Changeset in webkit [30805] by Adam Roben
  • 4 edits in trunk/WebKit/mac

Move -_convertValueToObjcValue to WebScriptCallFrame

Reviewed by Darin.

  • WebView/WebCoreScriptDebugger.h: Removed declaration of -_convertValueToObjcValue.
  • WebView/WebCoreScriptDebugger.mm: Removed -_convertValueToObjcValue.
  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame _convertValueToObjcValue:]): Added. Code came from -[WebCoreScriptCallFrame _convertValueToObjcValue]. (-[WebScriptCallFrame scopeChain]): Changed to call -_convertValueToObjcValue on self instead of _private. (-[WebScriptCallFrame exception]): Ditto. (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
11:34 AM Changeset in webkit [30804] by Adam Roben
  • 4 edits in trunk/WebKit/mac

Move -exception and -evaluateWebScript: to WebScriptCallFrame

Reviewed by Darin.

  • WebView/WebCoreScriptDebugger.h: Removed declarations of -exception and -evaluateWebScript:.
  • WebView/WebCoreScriptDebugger.mm: Removed -exception and -evaluateWebScript:.
  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame exception]): Added. Code came from -[WebCoreScriptCallFrame exception]. (-[WebScriptCallFrame evaluateWebScript:]): Added. Code came from -[WebCoreScriptCallFrame evaluateWebScript:].
11:34 AM Changeset in webkit [30803] by Adam Roben
  • 4 edits in trunk/WebKit/mac

Move -scopeChain to WebScriptCallFrame

Reviewed by Darin.

  • WebView/WebCoreScriptDebugger.h:
    • Added declarations of -globalObject and -_convertValueToObjcValue: to WebCoreScriptCallFrame
    • Removed declaration of -scopeChain.
  • WebView/WebCoreScriptDebugger.mm: Moved -_convertValueToObjcValue within the main WebCoreScriptCallFrame implementation. (-[WebCoreScriptCallFrame globalObject]): Added.
  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): Added. Code came from -[WebCoreScriptCallFrame scopeChain].
11:34 AM Changeset in webkit [30802] by Adam Roben
  • 4 edits in trunk/WebKit/mac

Move -functionName from WebCoreScriptCallFrame to WebScriptCallFrame

Reviewed by Darin.

  • WebView/WebCoreScriptDebugger.h:
    • Removed #else case of #ifdef cplusplus since this file is only ever used by C++ Objective-C files
    • Removed 'using KJS::ExecState' statement since we prefer not to have using statements in header files
    • Consequently prefixed uses of ExecState with KJS::
    • Added declaration of toNSString method that takes a const UString&
    • Added declaration of -[WebCoreScriptCallFrame state]
    • Removed declaration of -[WebCoreScriptCallFrame functionName]
  • WebView/WebCoreScriptDebugger.mm: (toNSString): Made this no longer static. (-[WebCoreScriptCallFrame state]): Added.
  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame functionName]): Added. Code came from -[WebCoreScriptCallFrame functionName], though I changed some nested ifs into early returns.
11:33 AM Changeset in webkit [30801] by Adam Roben
  • 8 edits
    2 moves in trunk

Move WebCoreScriptDebugger up to WebKit

WebCore:

Move WebCoreScriptDebugger up to WebKit

Reviewed by Darin.

  • WebCore.base.exp: Exported some functions used by WebCoreScriptDebugger, and sorted the list.
  • WebCore.xcodeproj/project.pbxproj: Removed WebCoreScriptDebugger.{h,mm} from the project and marked a few headers private so that WebKit can use them.
  • page/mac/WebCoreScriptDebugger.h: Removed.
  • page/mac/WebCoreScriptDebugger.mm: Removed.

WebKit:

Move WebCoreScriptDebugger to WebKit

Reviewed by Darin.

  • WebKit.xcodeproj/project.pbxproj: Added WebCoreScriptDebugger.{h,mm} to the project.

WebKit/mac:

Move WebCoreScriptDebugger to WebKit

Reviewed by Darin.

  • WebView/WebCoreScriptDebugger.h: Renamed from WebCore/page/mac/WebCoreScriptDebugger.h.
  • WebView/WebCoreScriptDebugger.mm: Renamed from WebCore/page/mac/WebCoreScriptDebugger.mm. (toNSString): (toNSURL): (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): (WebCoreScriptDebuggerImp::sourceParsed): (WebCoreScriptDebuggerImp::callEvent): (WebCoreScriptDebuggerImp::atStatement): (WebCoreScriptDebuggerImp::returnEvent): (WebCoreScriptDebuggerImp::exception): (+[WebCoreScriptDebugger initialize]): (-[WebCoreScriptDebugger initWithDelegate:]): (-[WebCoreScriptDebugger dealloc]): (-[WebCoreScriptDebugger finalize]): (-[WebCoreScriptDebugger delegate]): (-[WebCoreScriptDebugger _enterFrame:]): (-[WebCoreScriptDebugger _leaveFrame]): (-[WebCoreScriptCallFrame _initWithGlobalObject:caller:state:]): (-[WebCoreScriptCallFrame _setWrapper:]): (-[WebCoreScriptCallFrame _convertValueToObjcValue:]): (-[WebCoreScriptCallFrame dealloc]): (-[WebCoreScriptCallFrame wrapper]): (-[WebCoreScriptCallFrame caller]): (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame exception]): (-[WebCoreScriptCallFrame evaluateWebScript:]):
  • WebView/WebScriptDebugDelegate.mm: Updated header path.
  • WebView/WebScriptDebugDelegatePrivate.h: Ditto.
11:14 AM Changeset in webkit [30800] by andersca@apple.com
  • 1 edit
    1 delete in trunk/JavaScriptCore

Reviewed by Sam.


Remove bindings/.

  • bindings: Removed.
11:13 AM Changeset in webkit [30799] by andersca@apple.com
  • 2 edits in trunk/WebKit/win

Build fix.

  • WebKit.vcproj/WebKit.vcproj:
11:12 AM Changeset in webkit [30798] by andersca@apple.com
  • 2 edits in trunk/WebCore

Build bridge/. Copy some headers over to WebKit as part of the post-build step.


  • WebCore.vcproj/WebCore.vcproj:
11:11 AM Changeset in webkit [30797] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Don't build bindings/ anymore.


11:04 AM Changeset in webkit [30796] by andersca@apple.com
  • 25 edits in trunk

JavaScriptCore:

Reviewed by Geoff.

Don't build JavaScriptCore/bindings.




  • kjs/config.h: No need to define HAVE_JNI anymore.


  • kjs/interpreter.cpp: Remove unnecessary include.

WebCore:

Reviewed by Geoff.

  • WebCore.base.exp: Add the NPN and KJS methods.


  • WebCore.xcodeproj/project.pbxproj: Bring in bridge/
  • config.h: Add HAVE_JNI define.


  • bindings/js/kjs_html.cpp:
  • bindings/objc/DOMInternal.mm:
  • bindings/objc/DOMUtility.mm:
  • bindings/objc/WebScriptObject.mm:
  • html/HTMLAppletElement.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLObjectElement.cpp:
  • html/HTMLPlugInElement.cpp:
  • page/Frame.cpp:
  • page/mac/FrameMac.mm:
  • page/mac/WebCoreFrameBridge.mm:
  • page/mac/WebCoreScriptDebugger.mm:
  • plugins/win/PluginViewWin.cpp: Include file changes.

WebKit/mac:

Reviewed by Geoff.

Include file changes.


  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebNetscapePluginPackage.m:
10:19 AM Changeset in webkit [30795] by ddkilzer@apple.com
  • 3 edits in trunk/JavaScriptCore

Allow override of default script file name using command-line argument.

Reviewed by Adele.

  • API/minidom.c: (main): Allow first command-line argument to override the default script file name of "minidom.js".
  • API/testapi.c: (main): Allow first command-line argument to override the default script file name of "testapi.js".
9:02 AM Changeset in webkit [30794] by andersca@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Sam.

Rewrite NPRuntime string conversion routines to use WebCore::String


  • bridge/NP_jsobject.cpp: (_NPN_Evaluate):
  • bridge/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16WithLatin1Fallback): (KJS::Bindings::convertNPVariantToValue): (KJS::Bindings::convertNPStringToUTF16): (KJS::Bindings::identifierFromNPIdentifier):
  • bridge/c/c_utility.h:
1:13 AM Changeset in webkit [30793] by oliver@apple.com
  • 2 edits in trunk/WebCore

Small performance improvement to putImageData (3-5% on assignment in my tests)

Reviewed by Alexey P

12:44 AM Changeset in webkit [30792] by alp@webkit.org
  • 2 edits in trunk/WebKitTools

2008-03-05 Alp Toker <​alp@atoker.com>

Force qmake for the GTK+ build until we get the build bot to succeed
with autotools (currently dies at make distclean)

  • Scripts/webkitdirs.pm:
Note: See TracTimeline for information about the timeline view.