⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 11, 2008:

10:40 PM Changeset in webkit [30981] by sfalken@apple.com
  • 9 edits
    1 add in trunk

JavaScriptCore:

Disable LTCG/PGO for grammar.cpp and nodes.cpp.
PGO on these files causes us to hang.


Copy newer vsprops files from relative WebKitLibraries path to environment variable based path.


Reviewed by Oliver.

WebCore:

Disable LTCG/PGO for all of WebCore for now.
We'll re-enable this as part of follow-on PGO work.


Reviewed by Oliver.

  • WebCore.vcproj/WebCore.vcproj:

WebKit/win:

Use PGO to build WebKit.dll.


Reviewed by Oliver.

  • WebKit.vcproj/WebKit.pgd: Added.
  • WebKit.vcproj/WebKit.vcproj:

WebKitLibraries:

Disable two PGO/LTCG specific warnings.


Reviewed by Oliver.

  • win/tools/vsprops/common.vsprops:
10:27 PM Changeset in webkit [30980] by Darin Adler
  • 19 edits in trunk

WebCore:

Reviewed by Sam.

  • remove all bridge-related things from WebCore except the bridge itself
  • WebCore.base.exp: Removed the bridge and setBridge functions.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent): Removed call to the bridge's close method.
  • page/Frame.cpp: (WebCore::Frame::~Frame): Removed call to setBridge(0). (WebCore::FramePrivate::FramePrivate): Removed initialization of m_bridge.
  • page/Frame.h: Removed setBridge and bridge functions.
  • page/FramePrivate.h: Removed m_bridge pointer.
  • page/mac/FrameMac.mm: Removed setBridge and bridge functions.
  • page/mac/WebCoreFrameBridge.h: Added setWebCoreFrame: method. Removed bridgeForDOMDocument: and clearFrame methods.
  • page/mac/WebCoreFrameBridge.mm: Ditto. (-[WebCoreFrameBridge close]): Changed to set m_frame to 0 directly. (-[WebCoreFrameBridge setWebCoreFrame:]): Added.

WebKit/mac:

Reviewed by Sam.

  • remove all bridge-related things from WebCore except the bridge itself
  • DOM/WebDOMOperations.mm: (-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method.
  • DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include.
  • Plugins/WebPluginController.mm: Ditto.
  • WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the init and close methods. Added a setWebFrame: method.
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge setWebFrame:]): Added.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion. (WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the bridge here. Soon we will be able to remove this entirely! (WebFrameLoaderClient::createFrame): Rewrote this to use the method moved into WebFrame from the bridge.
  • WebView/WebFrame.mm: (-[WebFramePrivate dealloc]): Added code to release the bridge, because it's now owned by the frame. (-[WebFramePrivate finalize]): Added this missing method. We'd leak the script debugger under GC without this! (kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to use WebFrameLoaderClient instead of the bridge. (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added. This is code that used to live in the bridge's init function. (+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto. (+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto. (-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since the WebView is now the bridge's owner. (-[WebFrame _updateBackground]): Changed this one call site that was calling the WebCore::Frame::bridge function directly to use the kit function instead. (-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge. This code won't last long -- we're eliminating the bridge soon. (-[WebFrame finalize]): Ditto.
  • WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods for creating frames.
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom where we have to allocate a WebFrameBridge and then immediately release it.
10:13 PM Changeset in webkit [30979] by Darin Adler
  • 5 edits in trunk

WebCore:

  • restored some code I removed in the Range change; this code can't go until the rest of the Range fix is in
  • dom/Range.cpp: (WebCore::Range::commonAncestorContainer): Added back the check for 0 that I removed erroneously in the Range patch. (WebCore::Range::processContents): Left in assertions I used to debug this.

LayoutTests:

Reviewed by Beth Dakin.

Update test to catch the SECURITY_ERR thrown by
CanvasRenderingContext2D::getImageData() and
HTMLCanvasElement::toDataURL() on a tainted canvas

  • http/tests/security/canvas-remote-read-remote-image-expected.txt:
  • http/tests/security/canvas-remote-read-remote-image.html:
8:51 PM Changeset in webkit [30978] by Darin Adler
  • 3 edits in trunk/LayoutTests
  • update expected result changed by recent Range patch
  • platform/mac/editing/execCommand/4920488-expected.txt: Removed incorrect exception log.
  • platform/qt/editing/execCommand/4920488-expected.txt: Ditto.
6:31 PM Changeset in webkit [30977] by Darin Adler
  • 2 edits in trunk/WebCore
  • fix Release build
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::setContentsPos): Don't use NSMakePoint.
6:23 PM Changeset in webkit [30976] by Darin Adler
  • 31 edits
    1 add in trunk

WebCore:

Reviewed by Anders.

  • simplify Mac code for ScrollView, since it's used only for FrameView and not in two different modes like it was historically
  • remove code depending on the bridge to get from an NSView to a WebCore::Frame
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _rectOnScreen]): getDocumentView -> documentView.
  • bridge/jni/jni_jsobject.cpp: (createRootObject): Instead of using WebCoreViewFactory to find the frame given and NSView, use the WebCoreFrameView interface to do it.
  • editing/mac/EditorMac.mm: (WebCore::Editor::paste): getDocumentView -> documentView.
  • editing/mac/SelectionControllerMac.mm: (WebCore::SelectionController::notifyAccessibilityForSelectionChange): Ditto.
  • page/FrameView.h: Fixed comment.
  • page/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): Removed uneeded typecasts to ScrollView* since FrameView is derived from ScrollView.
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView): getDocumentView -> documentView.
  • page/mac/FrameMac.mm: (WebCore::Frame::imageFromRect): Ditto.
  • page/mac/WebCoreAXObject.mm: (-[WebCoreAXObject position]): Ditto. (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto. (-[WebCoreAXObject rendererForView:]): Updated code that used to use WebCoreBridgeHolder to use WebCoreFrameView instead.
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]): getDocumentView -> documentView.
  • page/mac/WebCoreFrameView.h: Removed the WebCoreScrollbarMode type; we just use WebCore::ScrollbarMode directly. Renamed the WebCoreFrameView protocol to WebCoreFrameScrollView, since it's a protocol for the scroll view, not the frame view itself. Replaced WebCoreBridgeHolder protocol with WebCoreFrameView protocol, which returns a WebCore::Frame directly rather than a bridge.
  • page/mac/WebCoreViewFactory.h: Eliminated the bridgeForView method.
  • platform/ScrollView.h: Moved the constructor and destructor out of the class-specific #if blocks. Renamed Mac-specific function that gets the NSView for from getDocumentView to documentView and a scrollView function that returns an appropriately classed NSScrollView.
  • platform/graphics/MediaPlayer.h: Changed type of parentWidget to FrameView instead of Widget.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView): Removed unnecessary cast.
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): getDocumentView -> documentView.
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::ScrollView): Added. (WebCore::ScrollView::~ScrollView): Added. (WebCore::ScrollView::scrollView): Added. (WebCore::ScrollView::visibleWidth): Removed unused non-NSScrollView case. (WebCore::ScrollView::visibleHeight): Ditto. (WebCore::ScrollView::visibleContentRect): Ditto. (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): Ditto. (WebCore::ScrollView::contentsWidth): Ditto. (WebCore::ScrollView::contentsHeight): Ditto. (WebCore::ScrollView::contentsX): Ditto. (WebCore::ScrollView::contentsY): Ditto. (WebCore::ScrollView::scrollOffset): Ditto. (WebCore::ScrollView::scrollRectIntoViewRecursively): Ditto. (WebCore::ScrollView::setContentsPos): Ditto. (WebCore::ScrollView::setVScrollbarMode): Ditto. (WebCore::ScrollView::setHScrollbarMode): Ditto. (WebCore::ScrollView::setScrollbarsMode): Ditto. (WebCore::ScrollView::vScrollbarMode): Ditto. (WebCore::ScrollView::hScrollbarMode): Ditto. (WebCore::ScrollView::suppressScrollbars): Ditto. (WebCore::ScrollView::addChild): Ditto. (WebCore::ScrollView::resizeContents): Ditto. (WebCore::ScrollView::updateContents): Ditto. (WebCore::ScrollView::contentsToWindow): Ditto. (WebCore::ScrollView::windowToContents): Ditto. (WebCore::ScrollView::setStaticBackground): Ditto. (WebCore::ScrollView::documentView): Renamed and removed unused case. (WebCore::ScrollView::scrollbarUnderMouse): Removed incorrect comment.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::getOuterView): Update for protocol name change.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintCheckbox): getDocumentView -> documentView. (WebCore::RenderThemeMac::paintRadio): Ditto. (WebCore::RenderThemeMac::paintButton): Ditto. (WebCore::RenderThemeMac::paintMenuList): Ditto. (WebCore::RenderThemeMac::paintSliderThumb): Ditto. (WebCore::RenderThemeMac::paintSearchField): Ditto. (WebCore::RenderThemeMac::paintSearchFieldCancelButton): Ditto. (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): Ditto. (WebCore::RenderThemeMac::paintSearchFieldResultsButton): Ditto.

WebKit:

Reviewed by Anders.

  • WebKit.xcodeproj/project.pbxproj: Change WebDynamicScrollBarsView.m to be Obj-C++. We can rename the file later.

WebKit/mac:

Reviewed by Anders.

  • remove code depending on the bridge to get from an NSView to a WebCore::Frame
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): Remove incorrect call to setView. A couple lines later, there is a call to _install, which sets the view to the scroll view.
  • WebCoreSupport/WebViewFactory.mm: Removed bridgeForView method.
  • WebView/WebDynamicScrollBarsView.h: Moved most of the declarations out of this file, since it's used by Safari.
  • WebView/WebDynamicScrollBarsViewInternal.h: Added.
  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): Ditto. (-[WebDynamicScrollBarsView setAllowsScrolling:]): Ditto. (-[WebDynamicScrollBarsView allowsScrolling]): Ditto. (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): Ditto. (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): Ditto. (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): Ditto. (-[WebDynamicScrollBarsView allowsVerticalScrolling]): Ditto. (-[WebDynamicScrollBarsView horizontalScrollingMode]): Ditto. (-[WebDynamicScrollBarsView verticalScrollingMode]): Ditto. (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): Ditto. (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): Ditto. (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): Ditto. (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): Ditto. (-[WebDynamicScrollBarsView setScrollingMode:]): Ditto. (-[WebDynamicScrollBarsView setScrollingMode:andLock:]): Ditto.
  • WebView/WebFrameView.mm: (-[WebFrameView _web_frame]): Added. Replaces the webCoreBridge method.
  • WebView/WebView.mm: (-[WebView setAlwaysShowVerticalScroller:]): Updated for changes to WebCoreFrameView.h. (-[WebView alwaysShowVerticalScroller]): Ditto. (-[WebView setAlwaysShowHorizontalScroller:]): Ditto. (-[WebView alwaysShowHorizontalScroller]): Ditto.
5:48 PM Changeset in webkit [30975] by Darin Adler
  • 14 edits in trunk

WebCore:

Reviewed by Adam Roben.

Split CookieJarWin.cpp into CFNet and non-CFNet versions to
reduce the massive amount of conditionalization in the file.
(see ​http://bugs.webkit.org/show_bug.cgi?id=17788)

  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/win/CookieJarCFNetWin.cpp: Copied from WebCore/platform/network/win/CookieJarWin.cpp. (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
  • platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):

WebKit/mac:

Reviewed by Sam.

  • eliminate the remaining parts of WebCoreBridge used for calls to WebKit from WebCore
  • WebCoreSupport/WebChromeClient.h: Added new virtual functions that replace bridge methods.
  • WebCoreSupport/WebChromeClient.mm: Added lots of BEGIN_BLOCK_OBJC_EXCEPTIONS to recently-created functions. (WebChromeClient::firstResponder): Moved code here from the bridge. (WebChromeClient::makeFirstResponder): Ditto. (WebChromeClient::runOpenPanel): Ditto. (WebChromeClient::willPopUpMenu): Ditto.
  • WebCoreSupport/WebFrameBridge.h: Removed almost everything. What's left is related to creating the bridge and connecting it to WebCore, which will go next when I eliminate use of the bridge to get to/from the Frame*.
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge close]): Moved the code to track the bridge count here instead of the dealloc and finalize methods.
5:40 PM Google Summer of Code 2008 edited by eric@webkit.org
(diff)
5:28 PM Changeset in webkit [30974] by pewtermoose@webkit.org
  • 3 edits
    1 copy in trunk/WebCore

2008-03-11 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Adam Roben.

Split CookieJarWin.cpp into CFNet and non-CFNet versions to
reduce the massive amount of conditionalization in the file.
(see ​http://bugs.webkit.org/show_bug.cgi?id=17788)

  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/win/CookieJarCFNetWin.cpp: Copied from WebCore/platform/network/win/CookieJarWin.cpp. (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
  • platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
5:12 PM Google Summer of Code 2008 edited by zucker@wake3.com
(diff)
5:02 PM Writing Layout Tests for DumpRenderTree edited by eric@webkit.org
(diff)
4:56 PM Google Summer of Code 2008 edited by ddkilzer@apple.com
(diff)
4:43 PM Changeset in webkit [30973] by Darin Adler
  • 27 edits in trunk

WebCore:

Reviewed by Mitz.

  • make some Range improvements (preparation for Range support for DOM mutation)

Made constructors private, added create functions.
Made refcount start at 1 rather than starting at 0 and being incremented.
Made Range use two Position objects for the start/end container/offset pairs.

  • WebCore.base.exp: Updated.
  • dom/Document.cpp: (WebCore::Document::createRange): Changed to use Range::create. (WebCore::Document::removeMarkers): Updated for Range::first/pastLastNode name change.
  • dom/Position.cpp: (WebCore::Position::formatForDebugger): Updated for member variable name change. (WebCore::Position::showTreeForThis): Ditto. (WebCore::startPosition): Changed to use Range::startPosition. (WebCore::endPosition): Changed to use Range::endPosition.
  • dom/Position.h: Made the data members public and renamed them to container and offset. But since offset() is already a function, temporarily used posOffset for the data member. Later we'll get rid of offset(). Made more functions inline. Removed the constructor that takes a PositionIterator.
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position): Added. Replaces the constructor that used to be in Position.
  • dom/PositionIterator.h: Added conversion operator to produce a Position. Removed friend declaration for Position.
  • dom/Range.cpp: (WebCore::Range::Range): Updated constructors for data member changes and made them use a refcount of 1. (WebCore::Range::create): Added. (WebCore::Range::startContainer): Updated to eliminate use of m_detached; detached is now indicated by m_start.container of 0. Also updated to use m_start instead of the old m_startContainer. (WebCore::Range::startOffset): Ditto. (WebCore::Range::endContainer): Ditto. (WebCore::Range::endOffset): Ditto. (WebCore::Range::commonAncestorContainer): Ditto. (WebCore::Range::collapsed): Ditto. (WebCore::Range::setStart): Ditto. (WebCore::Range::setEnd): Ditto. (WebCore::Range::collapse): Ditto. (WebCore::Range::isPointInRange): Ditto. (WebCore::Range::comparePoint): Ditto. (WebCore::Range::compareNode): Ditto. (WebCore::Range::compareBoundaryPoints): Ditto. (WebCore::Range::boundaryPointsValid): Ditto. (WebCore::Range::deleteContents): Ditto. (WebCore::Range::intersectsNode): Ditto. (WebCore::Range::processContents): Ditto. (WebCore::Range::extractContents): Ditto. (WebCore::Range::cloneContents): Ditto. (WebCore::Range::insertNode): Ditto. (WebCore::Range::toString): Ditto. (WebCore::Range::text): Ditto. (WebCore::Range::createContextualFragment): Ditto. (WebCore::Range::detach): Ditto. (WebCore::Range::checkNodeBA): Changed to use switch statements instead of multiple calls to the virtual nodeType() function. (WebCore::Range::cloneRange): Ditto. (WebCore::Range::setStartAfter): Ditto. (WebCore::Range::setEndBefore): Ditto. (WebCore::Range::setEndAfter): Ditto. (WebCore::Range::selectNode): Ditto. (WebCore::Range::selectNodeContents): Ditto. (WebCore::Range::surroundContents): Ditto. (WebCore::Range::setStartBefore): Ditto. (WebCore::Range::checkDeleteExtract): Ditto. (WebCore::Range::containedByReadOnly): Ditto. (WebCore::Range::firstNode): Ditto. (WebCore::Range::editingStartPosition): Ditto. (WebCore::Range::pastLastNode): Ditto. (WebCore::Range::addLineBoxRects): Ditto. (WebCore::Range::formatForDebugger): Ditto. (WebCore::operator==): Ditto. (WebCore::rangeOfContents): Ditto. (WebCore::Range::maxStartOffset): Ditto. (WebCore::Range::maxEndOffset): Ditto.
  • dom/Range.h: Made constructors private. Added create functions. Added getters for startContainer/Offset and endContainer/Offset that return 0 instead of an exception for detached ranges that are inline and don't require an ExceptionCode out parameter. Changed the parameters to setStart and setEnd to PassRefPtr. Removed isDetached function. Made ActionType and processContents private. Made startPosition and endPosition inlines and have then return const&. Renamed startNode and pastEndNode to firstNode and pastLastNode to reduce the chance of confusion with startContainer/endContainer. Used Position for m_start and m_end instead of separate container and offset members. Changed maxStartOffset and maxEndOffset into int to match other offsets.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Changed to use Range::create. (WebCore::ApplyStyleCommand::applyInlineStyle): Ditto.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::inputText): Ditto. (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Ditto.
  • editing/Editor.cpp: (WebCore::Editor::fontForSelection): Changed for pastLastNode name change. (WebCore::Editor::setComposition): Changed to use Range::create. (WebCore::paragraphAlignedRangeForRange): Ditto. (WebCore::markMisspellingsOrBadGrammar): Changed to get rid of check for isDetached and check for 0 from startContainer instead. (WebCore::Editor::compositionRange): Changed to use Range::create.
  • editing/EditorCommand.cpp: (WebCore::unionDOMRanges): Ditto.
  • editing/Selection.cpp: (WebCore::Selection::toRange): Ditto.
  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): Changed for firstNode and pastLastNode name change. (WebCore::TextIterator::range): Changed to use Range::create. (WebCore::SimplifiedBackwardsTextIterator::range): Ditto. (WebCore::TextIterator::subrange): Ditto.
  • editing/VisiblePosition.cpp: (WebCore::makeRange): Ditto.
  • editing/VisiblePosition.h: Added now-needed include.
  • editing/htmlediting.cpp: (WebCore::indexForVisiblePosition): Changed to use Range::create. (WebCore::avoidIntersectionWithNode): Changed to get rid of check for isDetached and check for 0 instead and to use Range::create.
  • editing/markup.cpp: (WebCore::renderedText): Changed to use Range::create. (WebCore::createMarkup): Changed to no longer use isDetached and also for new firstNode/pastEndNode names. (WebCore::createFragmentFromText): Ditto.
  • editing/visible_units.cpp: (WebCore::previousBoundary): Changed to use Range::create.
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge convertToNSRange:]): Changed to no longer use isDetached().
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::visiblePositionForIndex): Changed to use Range::create. (WebCore::RenderTextControl::indexForVisiblePosition): Ditto.

WebKit/mac:

Reviewed by Mitz.

  • update code affected by Range changes
  • Misc/WebNSAttributedStringExtras.mm: (+[NSAttributedString _web_attributedStringFromRange:]): Update for name changes.
  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]): Use Range::create.
  • WebView/WebHTMLView.mm: (-[WebHTMLView attributedString]): Ditto.
4:32 PM Changeset in webkit [30972] by pewtermoose@webkit.org
  • 4 edits in trunk/WebCore

2008-03-11 Daniel Zucker <​zucker@wake3.com>

Reviewed by Adam Roben.

There are a handful of placed where the use of CFNetwork-specific
calls are protected by PLATFORM(CF). Revise to use the more specific
USE(CFNETWORK) macro. (See ​http://bugs.webkit.org/show_bug.cgi?id=17783)

  • platform/network/ProtectionSpace.cpp: Change PLATFORM(CF) to USE(CFNETWORK)
  • platform/network/ResourceHandle.cpp: Change PLATFORM(CF) to USE(CFNETWORK)
  • platform/network/win/CookieJarWin.cpp: Correct error in InternetGetCookie call. Conditionalize 'cookiesEnabled' the same as all other implementations in this file.
4:06 PM Changeset in webkit [30971] by pewtermoose@webkit.org
  • 2 edits in trunk

Fix version comparison from previous checkin

4:06 PM Changeset in webkit [30970] by alp@webkit.org
  • 6 edits
    6 adds in trunk

2008-03-11 Xan Lopez <​xan@gnome.org>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16476

Add libsoup HTTP backend.

  • GNUmakefile.am:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/soup/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge):
  • platform/network/soup/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
  • platform/network/soup/ResourceHandleSoup.cpp: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::dataCallback): (WebCore::parseDataUrl): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::bufferedData): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::setDefersLoading): (WebCore::ResourceHandle::loadsBlocked): (WebCore::ResourceHandle::willLoadFromCache):
  • platform/network/soup/ResourceRequest.h: Copied from WebCore/platform/network/curl/ResourceRequest.h. (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest):
  • platform/network/soup/ResourceResponse.h: Added. (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::setResponseFired): (WebCore::ResourceResponse::responseFired): (WebCore::ResourceResponse::doUpdateResourceResponse):
3:53 PM Changeset in webkit [30969] by pewtermoose@webkit.org
  • 4 edits in trunk

2008-03-11 Rodney Dawes <​dobey@wayofthemonkey.com>
WebCore:

Fix Qt build.

  • plugins/qt/PluginDataQt.cpp: (PluginData::initPlugins)

WebKit/qt:

Fix the Qt build.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (FrameLoaderClientQt::CreatePlugin):
2:43 PM Changeset in webkit [30968] by mrowe@apple.com
  • 3 edits
    1 delete in trunk/WebKitSite

2008-03-11 Robert Blaut <​webkit@blaut.biz>

Reviewed by Darin Adler.

Fix bug ​http://bugs.webkit.org/show_bug.cgi?id=17280
Patch deletes an obsolete hitlist.html page and other references to it

  • nav.inc: removed menu link to hitlist.html
  • projects/compat/hitlist.html: Removed.
  • projects/compat/index.html: removed reference to hitlist.html
2:28 PM Changeset in webkit [30967] by pewtermoose@webkit.org
  • 4 edits in trunk

2008-03-11 Brent Fulgham <​bfulgham@gmail.com>

WebKit/win:

Reviewed by Adam Roben.

Enabled WinLauncher as part of normal Windows build.
​http://bugs.webkit.org/show_bug.cgi?id=17715.

  • WebKit.vcproj/WebKit.sln: Add WinLauncher to the set of things build during a Windows build.

WebKitTools:

Reviewed by Adam Roben.

Enabled WinLauncher as part of normal Windows build.
​http://bugs.webkit.org/show_bug.cgi?id=17715.

  • WinLauncher/WinLauncher.vcproj: Update to use vsprops so that it can find the proper libraries to link against.
12:59 PM Changeset in webkit [30966] by Adam Roben
  • 3 edits in trunk/WebCore

Make attribute quoting in DOM view more consistent with source view

Two changes which make the DOM view more consistent with source view:

1) We now quote all attribute values, including URLs
2) The quotes around the values are now purple, matching the left and

right angle brackets that surround the tag

One bug fixed by these changes:

1) The entire URL is selected for editing when you double-click a URL

that is an attribute value. Previously, the first and last
characters were not included in the selection.

Reviewed by Darin.

  • page/inspector/DocumentPanel.js: (WebInspector.DOMNodeTreeElement._startEditingAttribute): Don't need to account for the quotes around attribute values anymore because the quotes are now outside the webkit-html-attribute-value span.
  • page/inspector/utilities.js: (nodeTitleInfo): Quote all attribute values, including URLs, and place the quotes outside the webkit-html-attribute-value span.
12:59 PM Changeset in webkit [30965] by Adam Roben
  • 5 edits in trunk/WebCore

Stop including pthread.h in WebCore on Windows

Reviewed by Darin.

  • WebCore.vcproj/WebCore.vcproj:
    • Changed the include path to not contain pthreads/
    • Let VS remove a duplicate FileConfiguration element
    • Let VS have its way with the file ordering
  • WebCorePrefix.h: Made the #include of pthread.h be compiled out on Windows.
  • loader/FTPDirectoryDocument.cpp: Added a Windows-specific #define of localtime_r (pthread.h was providing a macro that substituted plain old localtime before, but localtime_s is "more secure", so I went with that).
  • loader/FTPDirectoryParser.cpp: Ditto for gmtime_r.
12:58 PM Changeset in webkit [30964] by Adam Roben
  • 5 edits
    1 move in trunk

Roll out r30961 since it breaks the default site icon on Windows

12:10 PM Google Summer of Code 2008 edited by eric@webkit.org
(diff)
12:08 PM Google Summer of Code 2008 edited by eric@webkit.org
(diff)
12:07 PM Google Summer of Code 2008 edited by eric@webkit.org
(diff)
11:52 AM Developer Tools Hitlist edited by Adam Roben
(diff)
11:37 AM Developer Tools Hitlist edited by Adam Roben
Added a high-level task for a JavaScript profiler (diff)
11:30 AM Changeset in webkit [30963] by mitz@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Darin Adler.

  • clean up line layout code
  • platform/graphics/GraphicsContext.cpp: (WebCore::TextRunIterator::increment): Removed the resolver parameter. (WebCore::GraphicsContext::drawBidiText): Adjusted for changes to createBidiRunsForLine(), which no longer takes a start parameter.
  • platform/text/BidiResolver.h: (WebCore::BidiResolver::): Made Noncopyable and removed the m_adjustEmbedding member variable. (WebCore::BidiResolver::position): Added. Returns the resolver's current position. (WebCore::BidiResolver::setPosition): Added. Sets the resolver's current position without changing any other state. (WebCore::BidiResolver::increment): Added. Advances the resolver to the next position, allowing the iterator to push and pop embedding. (WebCore::BidiResolver::appendRun): Removed the resolver parameter in the call to increment(). (WebCore::BidiResolver::embed): Removed code to save, set and restore m_adjustEmbedding. (WebCore::BidiResolver::createBidiRunsForLine): Changed to not take a 'start' iterator. Instead, start at the current position. Removed code to set m_adjustEmbedding. Changed for noncopyability.
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::bidiNext): Made the resolver parameter optional. Changed to null-check the 'end of inline' pointer only twice. (WebCore::bidiFirst): Made the resolver parameter optional. (WebCore::BidiIterator::increment): Ditto. (WebCore::BidiState::increment): Added. Overrides the default BidiResolver::increment() method by passing the resolver to BidiIterator::increment(). (WebCore::checkMidpoints): Removed the resolver parameter. (WebCore::BidiState::appendRun): Removed code to save, set and restore m_adjustEmbedding. Adjusted for change to increment(). (WebCore::RenderBlock::bidiReorderLine): Removed the 'start' parameter and unreachable code. (WebCore::buildCompactRuns): Adjusted for changes to BidiResolver/ (WebCore::RenderBlock::layoutInlineChildren): Moved code to initialize the resolver from this method to determineStartPosition(). Unified the resolver with the 'start' iterator. Removed unreachable code. Moved one statement from the beginning of the while loop to the end. (WebCore::RenderBlock::determineStartPosition): Moved code to initialize the resolver from layoutInlineChildren() into this method. (WebCore::RenderBlock::matchedEndLine): Adjusted for the resolver and the 'start' iterator being one object. (WebCore::skipNonBreakingSpace): Made the parameter const. (WebCore::requiresLineBox): Ditto. (WebCore::RenderBlock::generatesLineBoxesForInlineChild): Adjusted for the change to BidiIterator::increment(). (WebCore::RenderBlock::skipWhitespace): Made two versions of this method, one for BidiIterator and one for BidiState. (WebCore::shouldSkipWhitespaceAfterStartObject): Removed the resolver parameter. (WebCore::RenderBlock::findNextLineBreak): Removed the resolver parameter. Removed calls to setAdjustEmbedding(). Removed the 'previous' variable and changed the 'last' variable to do its job.
  • rendering/bidi.h:
11:19 AM Developer Tools Hitlist edited by Adam Roben
(diff)
11:08 AM Google Summer of Code 2008 edited by Adam Roben
(diff)
10:38 AM Developer Tools Hitlist edited by Adam Roben
Made high-level list unordered, since they were only rough priorities … (diff)
10:38 AM Developer Tools Hitlist edited by Adam Roben
Changed a bug number (diff)
10:35 AM Developer Tools Hitlist edited by Adam Roben
Added bugs for the unfiled high-level tasks (diff)
10:24 AM Developer Tools Hitlist edited by Adam Roben
Added a list of high-level improvements (some still need bugs filed) (diff)
10:11 AM Developer Tools Hitlist edited by Adam Roben
Shuffling some priorities (diff)
10:02 AM Developer Tools Hitlist edited by Adam Roben
(diff)
10:01 AM Developer Tools Hitlist edited by Adam Roben
(diff)
9:55 AM Developer Tools Hitlist edited by Adam Roben
Added a link to DeveloperToolsHitList bugs (diff)
9:46 AM Developer Tools Hitlist edited by Adam Roben
Added the Inspector UI Refresh (diff)
9:43 AM Developer Tools Hitlist created by Adam Roben
Initial version
9:06 AM WikiStart edited by Adam Roben
Added a link to a new Developer Tools Hitlist page (and moved dev. … (diff)
8:54 AM Changeset in webkit [30962] by Adam Roben
  • 3 edits in trunk/WebCore

Part of Bug 17224: DOM nodes/attributes should be editable

<​http://bugs.webkit.org/show_bug.cgi?id=17224>
<rdar://problem/5732825>

This patch makes text nodes editable via double-click.

Reviewed by Tim.

  • page/inspector/DocumentPanel.js: (WebInspector.DOMNodeTreeElement._startEditing):
    • Moved most of this code to _startEditingAttribute
    • Calls _startEditingTextNode or _startEditingAttribute as appropriate

(WebInspector.DOMNodeTreeElement._startEditingAttribute): Added. Code
came from _startEditing.
(WebInspector.DOMNodeTreeElement._startEditingTextNode): Added.
(WebInspector.DOMNodeTreeElement._textNodeEditingCommitted): Added.
(WebInspector.DOMNodeTreeElement._editingCancelled): Renamed from
_attributeEditingCancelled.

  • page/inspector/utilities.js: (nodeTitleInfo): Wrap text nodes in a webkit-html-text-node span so that we can easily recognize/edit them.
8:38 AM Changeset in webkit [30961] by zecke@webkit.org
  • 5 edits
    1 move in trunk

r25512 inlined the urlIcon to improve the startup time of Safari on Mac. Inlining is
not suitable for platforms where this icon is themable. E.g. the Qt platform is allowing
to theme this icon and the Gtk+ platform will probably end up with themable icons
as well.

Remove dead code from the windows port and move the urlIcon from the windows
directory to the Resource directory to be used by Qt and other ports.

Ifdef the usage of the built-in icon in IconDatabase.cpp and for Qt do not use
it. Gtk+ currently has no proper implementation of Image::loadPlatformResource but
once it does it wants to use this for getting the urlIcon as well.

7:59 AM Changeset in webkit [30960] by Simon Hausmann
  • 3 edits
    2 adds in trunk/WebCore

2008-03-11 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Darin.

Implemented HTML media element support for QtWebKit, using Phonon.

​http://bugs.webkit.org/show_bug.cgi?id=17766

6:50 AM Changeset in webkit [30959] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix the Qt build (silly typo).

5:52 AM Changeset in webkit [30958] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-03-11 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Moved obscuring progress bar to the lower right corner.

5:51 AM Changeset in webkit [30957] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-03-11 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Added reload action and grouped stop and reload actions together.

4:38 AM Changeset in webkit [30956] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Set a Icon on the QAction if we have one.
1:17 AM Changeset in webkit [30955] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix the Qt build.

12:20 AM Changeset in webkit [30954] by weinig@apple.com
  • 10 edits in trunk

WebCore:

Reviewed by Beth Dakin.

Throw a SECURITY_ERR when accessing a tainted canvas
by CanvasRenderingContext2D::getImageData() and
HTMLCanvasElement::toDataURL().

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::getImageData):
  • html/CanvasRenderingContext2D.h:
  • html/CanvasRenderingContext2D.idl:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::toDataURL):
  • html/HTMLCanvasElement.h:
  • html/HTMLCanvasElement.idl:

LayoutTests:

Reviewed by Beth Dakin.

Update test to catch the SECURITY_ERR thrown by
CanvasRenderingContext2D::getImageData() and
HTMLCanvasElement::toDataURL() on a tainted canvas

  • http/tests/security/canvas-remote-read-remote-image-expected.txt:
  • http/tests/security/canvas-remote-read-remote-image.html:

Mar 10, 2008:

11:28 PM Changeset in webkit [30953] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • Windows build fix
  • kjs/function.cpp: (KJS::decode): Initialize variable.
9:42 PM Changeset in webkit [30952] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Sam.

<rdar://problem/5779984> REGRESSION (r30391): GMail: Safari won't display the Edit Link dialog

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::hasCSSPropertyNamePrefix): Fixed a typo. The code was only comparing the first character of the prefix to the first character of the property name.

LayoutTests:

Reviewed by Sam.


<rdar://problem/5779984> REGRESSION (r30391): GMail: Safari won't display the Edit Link dialog

  • editing/pasteboard/5780697-2-expected.txt: Added.
  • editing/pasteboard/5780697-2.html: Added.
  • editing/selection/5779984-1-expected.txt: Added.
  • editing/selection/5779984-1.html: Added.
8:40 PM Changeset in webkit [30951] by Beth Dakin
  • 2 edits in trunk/WebCore

Reviewed by Beth.

Hold off on initializing the frame to avoid the RenderView getting
a null FrameView. This could potentially cause problems.

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
5:48 PM Changeset in webkit [30950] by Darin Adler
  • 2 edits in trunk/WebCore
  • try to fix Qt build
  • bridge/qt/qt_runtime.cpp: (KJS::Bindings::convertQVariantToValue): Change KJS::UChar to UChar.
5:45 PM Changeset in webkit [30949] by Darin Adler
  • 15 edits in trunk/WebCore

Reviewed by Antti.

We now mark all links on a page as "changed" at the appropriate times.

  • WebCore.base.exp: Update since I made completeURL be a const member function.
  • css/CSSStyleSelector.cpp: Got rid of some unneeded globals that could be turned into locals. Also changed some static data members to file-scoped globals with internal linkage. Renamed the globals to get rid of the m_ prefix. Changed the prefix on m_styleNotYetAvailable to s_styleNotYetAvailable. (WebCore::CSSStyleSelector::CSSStyleSelector): Updated for name changes. (WebCore::parseUASheet): Tweak the comment. (WebCore::CSSStyleSelector::loadDefaultStyle): Updated for name changes and to use local variables instead of globals where possible. (WebCore::CSSStyleSelector::checkPseudoState): Made this a member function so it can store the link in a hash. Also changed it to have a return value instead of having it modify a global variable. Added code to put the hash into a set so we can tell later if this is one of the links that affects this page. (WebCore::CSSStyleSelector::canShareStyleWithElement): Updated for the change to checkPseudoState. (WebCore::CSSStyleSelector::matchUARules): Updated for name changes. (WebCore::CSSStyleSelector::styleForElement): Ditto. (WebCore::CSSStyleSelector::adjustRenderStyle): Ditto. (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Changed code to read the SVG style sheet to use a boolean global and put it right here in the function since this is the only code that needs to know about it. (WebCore::CSSStyleSelector::checkOneSelector): Updated for name changes. (WebCore::colorForCSSValue): Moved code inside the function that is not needed anywhere else. (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Updaed for the change to checkPseudoState. (WebCore::CSSStyleSelector::allVisitedStateChanged): Added. Calls setChanged on all links if there were any in the set. (WebCore::CSSStyleSelector::visitedStateChanged): Added. Calls setChanged on all links if the one that changed is in the set.
  • css/CSSStyleSelector.h: Removed unused StyleSelector class and State enum. Made CSSStyleSelector derive from Noncopyable. Made lots of member functions private that didn't need to be public, and removed others that could be made into non-member functions. Changed pseudoStyleRulesForElement to take a const String& instead of a StringImpl*. Added new allVisitedStateChanged and visitedStateChanged functions. Got rid of unneeded friend declarations.
  • dom/Document.cpp: (WebCore::Document::completeURL): Made const. (WebCore::findSlashDotDotSlash): Moved here from PageGroup. (WebCore::findSlashSlash): Ditto. (WebCore::findSlashDotSlash): Ditto. (WebCore::containsColonSlashSlash): (WebCore::cleanPath): Ditto. (WebCore::matchLetter): Ditto. (WebCore::needsTrailingSlash): Ditto. (WebCore::Document::visitedLinkHash): Moved this here from PageGroup. This is the poor-man's completeURL function. The idea of putting it here is that this way it can be alongside the real completeURL function. Later we should figure out a way to make this function share more code with the real thing and match behavior.
  • dom/Document.h: Marked completeURL function const. Added visitedLinkHash function.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::getMatchedCSSRules): Updated for change to CSSStyleSelector.
  • page/Page.cpp: (WebCore::Page::allVisitedStateChanged): Added. Calls allVisitedStateChanged on all style selectors. (WebCore::Page::visitedStateChanged): Ditto.
  • page/Page.h: Added the above functions.
  • page/PageGroup.cpp: (WebCore::PageGroup::isLinkVisited): Changed to take a visitedLinkHash parameter. The CSSStyleSelector now handles actually computing the hash, and it does so by calling code in Document. (WebCore::PageGroup::addVisitedLink): Refactored so the two overloaded copies share a bit more code. Added code that calls visitedStateChanged if a new link was added. (WebCore::PageGroup::removeVisitedLinks): Added code to call allVisitedStateChanged if any visited links are removed.
  • page/PageGroup.h: Include StringHash.h instead of having the AlreadyHashed struct definition here.
  • platform/text/StringHash.h: (WebCore::CaseFoldingHash::hash): Tweaked to make this a bit more consistent with the StringImpl::computeHash function, using the same technique for avoiding 0. (WebCore::AlreadyHashed::hash): Added. Was formerly in PageGroup.h. (WebCore::AlreadyHashed::avoidDeletedValue): Added. Was formerly in PageGroup.cpp.
  • rendering/RenderStyle.cpp: (WebCore::RenderStyle::isStyleAvailable): Changed to use an inline function instead of getting directly at a data member so the data member could be made private.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::scrollToAnchor): Added call to updateHistoryForAnchorScroll. (WebCore::FrameLoader::updateHistoryForAnchorScroll): Added.
  • loader/FrameLoader.h: Added updateHistoryForAnchorScroll.
5:36 PM Changeset in webkit [30948] by eric@webkit.org
  • 2 edits in trunk/WebKit/win

No review, build fix only.

Speculative fix for Windows build, use ::UChar instead of KJS::UChar

  • WebScriptCallFrame.cpp: (WebScriptCallFrame::valueForVariable): (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
5:14 PM Changeset in webkit [30947] by Adam Roben
  • 4 edits in trunk/WebCore

Part of Bug 17224: DOM nodes/attributes should be editable

<​http://bugs.webkit.org/show_bug.cgi?id=17224>
<rdar://problem/5732825>

This patch makes DOM attributes editable via double-click.

Reviewed by Tim.

  • page/inspector/DocumentPanel.js: (WebInspector.DOMNodeTreeElement.onmousedown): Don't do anything if we're being edited, since we want default editing behaviors to work. (WebInspector.DOMNodeTreeElement.ondblclick): Try to start editing before doing anything else. (WebInspector.DOMNodeTreeElement._startEditing): Added. Currently only lets you edit attributes. (WebInspector.DOMNodeTreeElement._attributeEditingCommitted): Added. Uses a scratch element to get the new attribute(s) parsed, then sets the attribute(s) on the node in the inspected document. (WebInspector.DOMNodeTreeElement._attributeEditingCancelled): Added. (WebInspector.DOMNodeTreeElement._updateTitle): Added. Refreshes the representation of the node in the Inspector's DOM tree to reflect the node's current state.
  • page/inspector/inspector.css: Made the .editing class apply everywhere.
  • page/inspector/utilities.js: (nodeTitleInfo): Changed to surround attribute name/value pairs in a webkit-html-attribute span so that we can easily edit the pair as a whole.
4:39 PM Changeset in webkit [30946] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

2008-03-10 Brent Fulgham <​bfulgham@gmail.com>

Windows build fix

Reviewed by Adam.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Set the PATH to include Cygwin before running touch.
4:02 PM Changeset in webkit [30945] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Fix 64-bit builds.

Reviewed by Stephanie.

WebCore.exp only gets generated once for both 32-bit and 64-bit builds,
so we must exclude the _NPN symbols when creating WebCore.LP64.exp.

  • WebCore.xcodeproj/project.pbxproj: Reverted build phase shell code to r30826 to remove _NPN symbols from 64-bit builds in WebCore.LP64.exp.
3:57 PM Changeset in webkit [30944] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

Reviewed by NOBODY.

Build fix for JSC on windows.

  • API/JSStringRefCF.cpp: (JSStringCreateWithCFString):
  • kjs/function.cpp: (KJS::decode):
  • kjs/nodes2string.cpp: (KJS::escapeStringForPrettyPrinting):
3:44 PM Changeset in webkit [30943] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

No review, build fix only.

Attempt to fix the windows build?

  • kjs/ustring.h: change unsigned short to UChar
3:06 PM Changeset in webkit [30942] by eric@webkit.org
  • 28 edits in trunk

Reviewed by Darin.

Remove KJS::UChar, use ::UChar instead
​http://bugs.webkit.org/show_bug.cgi?id=17017

To functional changes, thus no tests.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::hasCSSPropertyNamePrefix): (WebCore::cssPropertyName):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::windowProtoFuncAToB): (WebCore::windowProtoFuncBToA):
  • bindings/js/JSSVGPODTypeWrapper.h:
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
  • bridge/objc/objc_utility.mm: (KJS::Bindings::throwError):
  • dom/Document.cpp: (WebCore::Document::parseQualifiedName):
  • platform/text/AtomicString.cpp: (WebCore::AtomicString::add):
  • platform/text/String.cpp: (WebCore::String::String): (WebCore::String::operator Identifier): (WebCore::String::operator UString):
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::decode):
  • svg/SVGAnimatedTemplate.h:
11:58 AM Changeset in webkit [30941] by sfalken@apple.com
  • 3 edits in trunk/WebKit/win

Fix build break caused by r30920.


Serialize remaining dependent builds by adding dependencies.
Visual Studio per-vcproj parallelization doesn't add a lot of value
since so many of our builds are dependent - this just enforces that.
We do our parallelization via pdevenv, which works much better.

  • WebKit.vcproj/WebKit.sln:
  • WebKit.vcproj/WebKit.submit.sln:
11:25 AM Changeset in webkit [30940] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-03-10 Xan Lopez <​xan@gnome.org>

Reviewed by Alp Toker.

Fix "missing braces" compiler warning.

  • webkit/webkitwebview.cpp:
10:37 AM Changeset in webkit [30939] by Darin Adler
  • 12 edits in trunk

WebCore:

Reviewed by Sam.

  • eliminate keyboard UI mode method from WebCoreFrameBridge
  • page/ChromeClient.h: Added keyboardUIMode function. (WebCore::ChromeClient::keyboardUIMode): Ditto.
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToAllControls): Call chrome client function instead of bridge function.
  • page/mac/WebCoreFrameBridge.h: Removed keyboardUIMode method, and other unused ones.
  • WebCore.xcodeproj/project.pbxproj: Allowed Xcode to change the project. Do not try to fight the Xcode.

WebKit/mac:

Reviewed by Sam.

  • eliminate keyboard UI mode method from WebCoreFrameBridge
  • WebCoreSupport/WebChromeClient.h: Added keyboardUIMode function.
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::keyboardUIMode): Ditto. Calls WebView.
  • WebCoreSupport/WebFrameBridge.h: Removed unused things, including the fields for keyboard UI mode.
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge dealloc]): Removed unneeded code; eliminated the fini method. (-[WebFrameBridge finalize]): Ditto.
  • WebView/WebView.mm: Moved the keyboard mode code in here. (-[WebView _close]): Remove observer from the distributed notification center as well as the normal one. (-[WebView _retrieveKeyboardUIModeFromPreferences:]): Added. Code moved here from the bridge. (-[WebView _keyboardUIMode]): Ditto.
  • WebView/WebViewInternal.h: Added _keyboardUIMode method.
10:36 AM Changeset in webkit [30938] by weinig@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Beth Dakin.

Add Tiger specific results for toDataURL-supportedTypes.html as the image
encoders have slightly changed between releases.

  • platform/mac-tiger/fast/canvas: Added.
  • platform/mac-tiger/fast/canvas/toDataURL-supportedTypes-expected.txt: Added.
10:29 AM Changeset in webkit [30937] by Darin Adler
  • 2 edits in trunk/WebCore
  • oops, forgot to save last couple changes from the editor
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::markDOMObjectWrapper): Tweaked a tiny bit. (WebCore::JSDOMWindow::mark): Sorted alphabetically.
10:26 AM Changeset in webkit [30936] by Darin Adler
  • 4 edits in trunk/WebCore

Reviewed by Geoff.

  • fix failing regression test (window.navigator is getting garbage collected and thus losing its custom properties)
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::markDOMObject): Added helper function. (WebCore::JSDOMWindow::mark): Added. Marks the wrappers for all the objects that hang off the window object.
  • page/DOMWindow.h: (WebCore::DOMWindow::optionalScreen): Added so we can get the Screen object without creating it if it's already there. (WebCore::DOMWindow::optionalSelection): Ditto. (WebCore::DOMWindow::optionalHistory): Ditto. (WebCore::DOMWindow::optionalLocationbar): Ditto. (WebCore::DOMWindow::optionalMenubar): Ditto. (WebCore::DOMWindow::optionalPersonalbar): Ditto. (WebCore::DOMWindow::optionalScrollbars): Ditto. (WebCore::DOMWindow::optionalStatusbar): Ditto. (WebCore::DOMWindow::optionalToolbar): Ditto. (WebCore::DOMWindow::optionalConsole): Ditto. (WebCore::DOMWindow::optionalNavigator): Ditto.
  • page/DOMWindow.idl: Added the CustomMarkFunction flag. Sorted the flags in alphabetical order since there are a lot of them.
10:01 AM Changeset in webkit [30935] by Darin Adler
  • 9 edits in trunk

WebCore:

Reviewed by Sam.

  • eliminate Java applet methods from WebCoreFrameBridge
  • loader/FrameLoaderClient.h: Added a javaApplet function.
  • page/mac/FrameMac.mm: (WebCore::Frame::createScriptInstanceForWidget): Streamlined the code. Use the loader client instead of the bridge to get the applet.
  • page/mac/WebCoreFrameBridge.h: Removed the getAppletInView and pollForAppletInView methods. Also removed other unused things.

WebKit/mac:

Reviewed by Sam.

  • eliminate Java applet methods from WebCoreFrameBridge
  • WebCoreSupport/WebChromeClient.mm: Removed unneeded headers and declarations.
  • WebCoreSupport/WebFrameBridge.mm: Ditto. Also removed unneeded methods, including the ones that load Java applets.
  • WebCoreSupport/WebFrameLoaderClient.h: Added javaApplet function.
  • WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
9:33 AM Changeset in webkit [30934] by Darin Adler
  • 2 edits in trunk/WebKitTools

Reviewed and landed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=17581
Bug 17581: Use of uninitialized value in string ne at WebKitTools/Scripts/run-webkit-tests line 1576.

Remove the previous warning which occurs when the --random option is used.

  • Scripts/run-webkit-tests: verify that $component[0] is defined before checking for its inequality
9:28 AM Changeset in webkit [30933] by Darin Adler
  • 4 edits
    1 add in trunk/WebCore

Reviewed by Eric, landed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=16095
Move GraphicsContextPrivate to its own header file.

Moves GraphicsContextState and GraphicsContextPrivate to its
own header

  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContextPrivate.h: Added. (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
9:25 AM Changeset in webkit [30932] by Darin Adler
  • 8 edits in trunk

WebCore:

Reviewed and landed by Darin.

bug 12182 : XMLHttpRequest should raise SECURITY_ERR for same-origin policy violations

Removed reference to PERMISSION_DENIED (previous non standard exception) and replaced it
by DOM exception SECURITY_ERR. Updated XMLHttpRequest::open to raise SECURITY_ERR.

  • bindings/js/kjs_binding.cpp: (WebCore::setDOMException): Removed PERMISSION_DENIED code.
  • dom/ExceptionCode.cpp: Added SECURITY_ERR exception.
  • dom/ExceptionCode.h: Ditto.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open): Returns SECURITY_ERR now.
  • xml/XMLHttpRequestException.h: Removed PERMISSION_DENIED.

LayoutTests:

Reviewed and landed by Darin.

bug 12182 : XMLHttpRequest should raise SECURITY_ERR for same-origin policy violations

  • http/tests/xmlhttprequest/exceptions-expected.txt: Updated results
9:17 AM Changeset in webkit [30931] by Adam Roben
  • 3 edits in trunk/WebCore

Refactor CSS editing code so we can share it with DOM editing

Add WebInspector.startEditing, which takes the element to be edited, a
committedCallback, a cancelledCallback, and a context parameter. This
function takes care of setting up the element for editing, and calls
either the cancelledCallback or committedCallback when editing ends.

Reviewed by Tim.

(WebInspector.StylePropertyTreeElement.editingEnded):

  • Renamed from endEditing
  • Removed code now handled by WebInspector.startEditing

(WebInspector.StylePropertyTreeElement.editingCancelled):

  • Renamed from cancelEditing
  • Changed parameters to match WebInspector.startEditing's cancelledCallback

(WebInspector.StylePropertyTreeElement.editingCommitted):

  • Renamed from commitEditing
  • Changed parameters to match WebInspector.startEditing's committedCallback
  • page/inspector/inspector.js: (WebInspector.changeFocus): Changed a call to firstParentWithClassName to firstParentOrSelfWithClassName so that if the focusable element itself is the target it will be recognized. I don't know why this change wasn't needed before this. (WebInspector.isBeingEdited): Added. (WebInspector.startEditing): Added.
9:17 AM Changeset in webkit [30930] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Pick up generated source files out of $(WebKitOutputDir) instead of hard-coding WebKitBuild.
9:15 AM Changeset in webkit [30929] by Darin Adler
  • 2 edits in trunk/WebCore
  • DerivedSources.make: Merge plug-in-related changes with the new way of handling autogenerated DOM classes.
8:38 AM Changeset in webkit [30928] by ap@webkit.org
  • 5 edits
    3 adds in trunk

Reviewed, tweaked and landed by Alexey.

We didn't have a fallback to frame encoding in the case of loading a script via
changing its src attribute.

Test: fast/dom/HTMLScriptElement/script-decoding-error-after-setting-src.html

  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::parseMappedAttribute): Use a helper function to get proper charset for correct decoding of script content. (WebCore::HTMLScriptElement::insertedIntoDocument): (WebCore::HTMLScriptElement::scriptCharset): A helper function for getting proper charset for the script (as much as can be determined prior to loading it).
  • html/HTMLScriptElement.h:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Use a helper function to get proper charset for correct decoding of script content.
6:59 AM Changeset in webkit [30927] by Simon Hausmann
  • 7 edits in trunk/WebCore

2008-03-10 Simon Hausmann <Simon Hausmann>

Reviewed by Lars.

Fix reference counting of returned MimeType and Plugin objects
created in the array wrappers.

5:29 AM Changeset in webkit [30926] by Simon Hausmann
  • 2 edits in trunk/WebCore

Wx linking fix.

Added missing stubs for PluginData.

5:20 AM Changeset in webkit [30925] by Simon Hausmann
  • 2 edits in trunk/WebCore

Windows build fix that I forgot to merge earlier ;(

Forward declare Page as class, not struct.

5:09 AM Changeset in webkit [30924] by Simon Hausmann
  • 2 edits in trunk/WebCore

Attempt to fix the Wx build.

4:52 AM Changeset in webkit [30923] by Simon Hausmann
  • 45 edits
    30 adds
    9 deletes in trunk

2008-03-07 Simon Hausmann <Simon Hausmann>

​http://bugs.webkit.org/show_bug.cgi?id=16815

Reviewed by Darin.

Done with Lars.

WebCore:

Ported the manually written JS bindings of window.navigator,
window.navigator.plugins and window.navigator.mimeTypes to
auto-generated bindings.

Moved the globally cached plugin and mimetype information to a
per WebCore::Page shared PluginData structure.

Implemented window.navigator.plugins.refresh() in a
platform-independent way.

LayoutTests:

Added a testcase for ​http://bugs.webkit.org/show_bug.cgi?id=16815

WebKit/qt:

Replaced the QWebObjectPlugin interfaces with QWebPluginFactory.

WebKit/mac:

Simplified WebViewFactory's refreshPlugins method to only refresh the
plugins and not reload the frames anymore since that's now done in a
platform independent manner by WebCore::Page.

Also removed the now unused pluginNameForMIMEType and
pluginSupportsMIMEType methods.

WebKitTools/DumpRenderTree/qt:

Ported the netscape test plugin to QWebPluginFactory.

4:29 AM Changeset in webkit [30922] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-03-10 Simon Hausmann <Simon Hausmann>

Reviewed by Holger.

Replace two printfs() in the Qt port with notImplemented().

4:23 AM Changeset in webkit [30921] by Simon Hausmann
  • 3 edits in trunk/WebCore

2008-03-10 Simon Hausmann <Simon Hausmann>

Reviewed by Alp.

Compilation fix with gcc 4.3: Include stdio.h for printf.

Note: See TracTimeline for information about the timeline view.