Context Navigation

pcre/pcre_exec.cpp: Fix misnamed variable, allowing -DDEBUG build to succeed.
wtf/ThreadingPthreads.cpp: #include <sys/time.h> for gettimeofday in non-pch build.

8:07 PM Changeset in webkit [31047] by Antti Koivisto

4 edits in trunk/LayoutTests

Reviewed by Mitz.

Update test results for the preload patch. Load order for some resources changed,
this does not affect the substance of these tests.

platform/mac-leopard/security/block-test-expected.txt:
security/block-test-expected.txt:
webarchive/loading/cache-expired-subresource-expected.txt:

7:47 PM Changeset in webkit [31046] by alp@webkit.org

2 edits in trunk/WebCore

2008-03-13 Tommi Komulainen <tommi.komulainen@iki.fi>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=17821
[SOUP] POST requests are empty

Send the HTTP request body as well.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start):

4:16 PM Changeset in webkit [31045] by timothy@apple.com

1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix the build.

3:14 PM Changeset in webkit [31044] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=17819 Border-collapse: collapse later cell wins on PC, earlier cell on Mac

Test: fast/table/border-collapsing/equal-precedence-resolution.html

rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): When calling compareBorders() with borders that may have the same precedence, made sure to pass the border belonging to the earlier (in document order) element first, since compareBorders() prefers the first argument when there is a tie. (WebCore::RenderTableCell::collapsedRightBorder): Ditto. (WebCore::RenderTableCell::collapsedTopBorder): Ditto.

LayoutTests:

Reviewed by Dave Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=17819 Border-collapse: collapse later cell wins on PC, earlier cell on Mac

fast/table/border-collapsing/equal-precedence-resolution.html: Added.
platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.checksum: Added.
platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.png: Added.
platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.txt: Added.

3:07 PM Changeset in webkit [31043] by Adam Roben

2 edits in trunk/WebKit/win

Another Windows build fix after r31034

WebKitDLL.cpp: (loadResourceIntoBuffer): Use SharedBuffer::create.

2:40 PM Changeset in webkit [31042] by Adam Roben

5 edits in trunk

Build fixes after r31034

WebCore:

wx build fix and Windows leak fix after r31034

platform/graphics/wx/ImageWx.cpp: (WebCore::Image::loadPlatformResource): Use SharedBuffer::create.
platform/win/SharedBufferWin.cpp: (WebCore::SharedBuffer::createWithContentsOfFile): Ditto (we were leaking the SharedBuffer here before).

WebKit/win:

Windows build fix after r31034

WebFrame.cpp: (WebFrame::loadData): Use SharedBuffer::create. (WebFrame::loadHTMLString): Ditto.

2:31 PM Changeset in webkit [31041] by Antti Koivisto

3 edits in trunk/WebCore

Reviewed by Eric.

Correct a few issues spotted by Mike Belshe.

html/PreloadScanner.cpp: (WebCore::PreloadScanner::tokenize):
loader/loader.cpp: (WebCore::Loader::cancelRequests):

2:26 PM Changeset in webkit [31040] by Adam Roben

4 edits in trunk

Fix GTK+ build for SharedBuffer changes.

WebCore:

2008-03-13 Rodney Dawes <dobey@wayofthemonkey.com>

Fix GTK+ build for SharedBuffer changes.

platform/graphics/gtk/ImageGtk.cpp: (Image::loadPlatformResource):

WebKit/gtk:

2008-03-13 Rodney Dawes <dobey@wayofthemonkey.com>

Fix GTK+ build for SharedBuffer changes.

webkit/webkitwebview.cpp: (webkit_web_view_load_string):

2:24 PM Changeset in webkit [31039] by sfalken@apple.com

5 edits
1 delete in trunk

WebCore:

More PGO build fixes.

WebCorePrefix.cpp:

WebKit/win:

More PGO build fixes.

WebKit.vcproj/WebKit.pgd: Removed.
WebKit.vcproj/WebKit.vcproj:
WebKitPrefix.cpp:

2:20 PM Changeset in webkit [31038] by Antti Koivisto

16 edits
3 adds in trunk

WebCore:

Reviewed by Darin.

Make page loads go fast.

http://bugs.webkit.org/show_bug.cgi?id=17480

Implement speculative preloading. When a script load blocks the main parser, use a side parser to pick up more resources.
Implement per-host load queues, prioritize scripts and stylesheets over images.

Depending on content and network latency this may speed things up quite a bit.

WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp: (WebCore::Document::implicitClose): Clear the preloads after laoding completes.

html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute): (WebCore::HTMLLinkElement::tokenizeRelAttribute):
html/HTMLLinkElement.h: Make tokenizeRelAttribute() public static so it can be used from elsewhere. Eliminate a pointless bitfield so I can get references.

html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::write):
html/HTMLTokenizer.h: Spin up the preload scanner whenever a script load blocks the parser. One scanner tracks the end of the document while temporary ones are created as needed to scan document.write() output.

html/PreloadScanner.cpp: Added. (WebCore::PreloadScanner::PreloadScanner): (WebCore::PreloadScanner::~PreloadScanner): (WebCore::PreloadScanner::begin): (WebCore::PreloadScanner::end): (WebCore::PreloadScanner::reset): (WebCore::PreloadScanner::write): (WebCore::isWhitespace): (WebCore::PreloadScanner::clearLastCharacters): (WebCore::PreloadScanner::rememberCharacter): (WebCore::PreloadScanner::lastCharactersMatch): (WebCore::legalEntityFor): (WebCore::PreloadScanner::consumeEntity): (WebCore::PreloadScanner::tokenize): (WebCore::PreloadScanner::processAttribute): (WebCore::PreloadScanner::emitCharacter): (WebCore::PreloadScanner::tokenizeCSS): (WebCore::PreloadScanner::emitTag): (WebCore::PreloadScanner::emitCSSRule):
html/PreloadScanner.h: Added. (WebCore::PreloadScanner::inProgress): (WebCore::PreloadScanner::): HTML5 tokenization plus some glue code. Fake CSS parsing thrown in just for fun.

loader/Cache.cpp: (WebCore::Cache::pruneDeadResources): Preloads have zero refcount, avoid kicking them out too early.

loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::ref):
loader/CachedResource.h: (WebCore::CachedResource::): (WebCore::CachedResource::preloadResult): (WebCore::CachedResource::setRequestedFromNetworkingLayer): (WebCore::CachedResource::canDelete): (WebCore::CachedResource::isPreloaded): (WebCore::CachedResource::increasePreloadCount): (WebCore::CachedResource::decreasePreloadCount): Keep track which resources are preloads. Avoid deleting them. Track at which point of the loading preloads get utilized to enable some interesting statistics.

loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader): (WebCore::DocLoader::checkForReload): (WebCore::DocLoader::registerPreload): (WebCore::DocLoader::clearPreloads): (WebCore::DocLoader::printPreloadStats):
loader/DocLoader.h: Ensure we utilize preloaded resources during reloads. Keep a list of all preloads in the document. Clear the preloads after parsing is complete. Some debug statistics.

loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense): Avoid signaling that loading is complete too early.

loader/loader.cpp: (WebCore::Loader::Loader): (WebCore::Loader::~Loader): (WebCore::Loader::determinePriority): (WebCore::Loader::load): (WebCore::Loader::scheduleServePendingRequests): (WebCore::Loader::requestTimerFired): (WebCore::Loader::servePendingRequests): (WebCore::Loader::cancelRequests): (WebCore::Loader::Host::Host): (WebCore::Loader::Host::~Host): (WebCore::Loader::Host::addRequest): (WebCore::Loader::Host::hasRequests): (WebCore::Loader::Host::servePendingRequests): (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail): (WebCore::Loader::Host::didReceiveResponse): (WebCore::Loader::Host::didReceiveData): (WebCore::Loader::Host::cancelPendingRequests): (WebCore::Loader::Host::cancelRequests):
loader/loader.h: (WebCore::Loader::): Distribute load requests to per-host priority queues. Limit the number of loads issued to the networking layer so we have better changes of getting important requests through first. Prioritize scripts > stylesheets > images.

WebKit/mac:

Reviewed by Darin.

ForwardingHeaders/wtf/Deque.h: Added.

2:01 PM Changeset in webkit [31037] by hyatt@apple.com

8 edits in trunk/WebCore

This patch makes full page zoom work pretty well. It fixes repainting so that it works when transforms
are set on the RenderView. It also implements the "smart layout" behavior that other browsers support when
zooming. The page will still try to constrain to the viewport size even when zoomed.

Reviewed by john

dom/Document.cpp: (WebCore::Document::recalcStyle): Make sure to test for transform changes even when there is no zoom. This fixes repainting issues caused by jumping from a zoomed state back to the standard size.

page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): Adjust for the zoom factor (the render tree is in unzoomed coordinates, but the scrollbars of the view need to handle zoomed coordinates).

rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight): Fix the body-sizing-to-the-view-height quirk so that it takes the zoom factor into account when stretching to fill the viewport.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::setHasVisibleContent): Remove the FIXMEs now that absoluteClippedOverflowRect works with transforms on the RenderView.

rendering/RenderView.cpp: (WebCore::RenderView::calcHeight): (WebCore::RenderView::calcWidth): Make sure the calculated width/height take the zoom factor into account in order to get the "smart layout" behavior.

(WebCore::RenderView::layout):
When deciding whether children have to get a relayout, we need to check the zoomed width/height and not just
the viewport size.

(WebCore::RenderView::computeAbsoluteRepaintRect):
Patched to take into account transforms set on the RenderView.

(WebCore::RenderView::docHeight):
(WebCore::RenderView::docWidth):
Patched to just always use m_width and m_height initially, since those have already been adjusted for
the zoom factor.

(WebCore::RenderView::zoomedHeight):
(WebCore::RenderView::zoomedWidth):

rendering/RenderView.h: New helper methods for obtaining the adjusted width/height of the viewport taking into account the zoom factor.

1:02 PM Changeset in webkit [31036] by andersca@apple.com

2 edits in trunk/WebCore

Build fix.

WebCore.base.exp:

12:08 PM Changeset in webkit [31035] by andersca@apple.com

8 edits in trunk

WebCore:

Reviewed by Adam.

Get rid of actualRequest, it is not used anymore. Also, get rid of
initialRequest and replace all uses with originalRequest because those are
the same thing.

loader/DocumentLoader.cpp:
loader/DocumentLoader.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::originalRequestURL):

WebKit/mac:

Reviewed by Adam.

Call originalRequest, not initialRequest.

WebView/WebDataSource.mm: (-[WebDataSource initialRequest]):

WebKit/win:

Reviewed by Adam.

Call originalRequest instead of initialRequest.

WebDataSource.cpp: (WebDataSource::initialRequest):

12:00 PM Changeset in webkit [31034] by beidson@apple.com

8 edits in trunk/WebCore

Reviewed by Anders

Convert SharedBuffer to start with a refCount of 1

loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish):

loader/ResourceLoader.cpp: (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::willStopBufferingData):

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultIcon): (WebCore::IconDatabase::getImageDataForIconURLFromSQLDatabase):

loader/loader.cpp: (WebCore::Loader::didReceiveData):

platform/SharedBuffer.h: (WebCore::SharedBuffer::create): Make all constructors private, add ::create() calls
platform/SharedBuffer.cpp: (WebCore::SharedBuffer::SharedBuffer): Revert to default RefCounted constructor to start with a ref count of 1 (WebCore::SharedBuffer::copy):
platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::wrapNSData): (WebCore::SharedBuffer::SharedBuffer): Revert to default RefCounted constructor to start with a ref count of 1

11:42 AM BuildingOnWindows edited by Adam Roben

Removed note about PGO (this was fixed in r31033) (diff)

11:37 AM Changeset in webkit [31033] by sfalken@apple.com

6 edits in trunk

JavaScriptCore:

PGO build fixes.

Disable PGO for normal release builds.
Added work-in-progress Release_PGOInstrument/Release_PGOOptimize targets.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

WebCore:

PGO build fixes.

Disable PGO for normal release builds.
Added work-in-progress Release_PGOInstrument/Release_PGOOptimize targets.

WebCore.vcproj/WebCore.vcproj:

WebKit/win:

PGO build fixes.

Disable PGO for normal release builds.
Added work-in-progress Release_PGOInstrument/Release_PGOOptimize targets.

WebKit.vcproj/WebKit.vcproj:

11:32 AM Changeset in webkit [31032] by Beth Dakin

2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Adding new functionality to Vector. Currently all of the shrink and
resize functions on Vector only shrink the size of the Vector, not
the capacity. For the Vector to take up as little memory as
possible, though, it is necessary to be able to shrink the capacity
as well. So this patch adds that functionality.

I need this for a speed up I am working on, and Geoff wants to use
it in a speed up he is working on also, so he asked me to commit it
now.

wtf/Vector.h: (WTF::VectorBufferBase::allocateBuffer): (WTF::::shrinkCapacity):

11:18 AM Changeset in webkit [31031] by andersca@apple.com

3 edits in trunk/WebCore

Reviewed by Darin.

Make a bunch of DocumentLoader setters/getters inline.

loader/DocumentLoader.cpp:
loader/DocumentLoader.h: (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isCommitted): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::response): (WebCore::DocumentLoader::mainDocumentError): (WebCore::DocumentLoader::setResponse): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::setIsClientRedirect): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::responses): (WebCore::DocumentLoader::triggeringAction): (WebCore::DocumentLoader::setTriggeringAction): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::setLastCheckedRequest): (WebCore::DocumentLoader::lastCheckedRequest): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::setLoadingFromCachedPage): (WebCore::DocumentLoader::isLoadingFromCachedPage):

9:17 AM Changeset in webkit [31030] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Attempt at fixing the Qt/Windows build bot. Quote using double-quotes
instead of single quotes.

8:19 AM Changeset in webkit [31029] by Adam Roben

2 edits in trunk/WebCore

2008-03-13 Rodney Dawes <dobey@wayofthemonkey.com>

Fix builds without SVG enabled.

page/Frame.cpp: (Frame::shouldApplyTextZoom): (Frame::shouldApplyPageZoom):

7:49 AM Changeset in webkit [31028] by Darin Adler

15 edits in trunk/WebKit/mac

Reviewed by John Sullivan.

cleanup after removing the bridge

DOM/WebDOMOperations.mm: (-[DOMDocument URLWithAttributeString:]): Call computeURL directly.

Misc/WebCoreStatistics.mm: (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of _frameLoader method. (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): Ditto.
Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame method. Without this we could leave a stale frame pointer around. (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single caller of the _isMainFrame method. (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of _frameLoader method. (WebFrameLoaderClient::createFrame): Moved code here from _addChild.

WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others turned out to be unused. (core): Added overload for DocumentFragment. (kit): Ditto. (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and to FrameLoader with _private->coreFrame->loader(). (-[WebFrame _attachScriptDebugger]): Ditto. (-[WebFrame _clearCoreFrame]): Added. (-[WebFrame _updateBackground]): More of the same. (-[WebFrame _unmarkAllBadGrammar]): Ditto. (-[WebFrame _unmarkAllMisspellings]): Ditto. (-[WebFrame _hasSelection]): Ditto. (-[WebFrame _atMostOneFrameHasSelection]): Ditto. (-[WebFrame _findFrameWithSelection]): Ditto. (-[WebFrame _dataSource]): Ditto. (-[WebFrame _addData:]): Streamlined code a bit. (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto. (-[WebFrame _receivedData:textEncodingName:]): Ditto. (-[WebFrame _isDescendantOfFrame:]): Ditto. (-[WebFrame _bodyBackgroundColor]): Ditto. (-[WebFrame _isFrameSet]): Ditto. (-[WebFrame _firstLayoutDone]): Ditto. (-[WebFrame _loadType]): Ditto. (-[WebFrame _isDisplayingStandaloneImage]): Ditto. (-[WebFrame name]): Ditto. (-[WebFrame DOMDocument]): Ditto. (-[WebFrame frameElement]): Ditto. (-[WebFrame provisionalDataSource]): Ditto. (-[WebFrame dataSource]): Ditto. (-[WebFrame loadRequest:]): Ditto. (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto. (-[WebFrame loadArchive:]): Ditto. (-[WebFrame stopLoading]): Ditto. (-[WebFrame reload]): Ditto. (-[WebFrame findFrameNamed:]): Ditto. (-[WebFrame parentFrame]): Ditto. (-[WebFrame childFrames]): Ditto. (-[WebFrame windowObject]): Ditto. (-[WebFrame globalContext]): Ditto.

WebView/WebFrameInternal.h: Added overloads of core and kit. Removed method declarations.

WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame. (formElementFromDOMElement): Ditto. (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto. (inputElementFromDOMElement): Ditto. (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto. (-[WebHTMLRepresentation elementIsPassword:]): Ditto. (-[WebHTMLRepresentation formForElement:]): Ditto. (-[WebHTMLRepresentation currentForm]): Ditto. (-[WebHTMLRepresentation controlsInForm:]): Ditto. (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto. (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.

WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Call createFragmentFromText directly instead of via WebFrame. (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Moved layout calls here from WebFrame. (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto. (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection. (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity. (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange. (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit. (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Moved code here from WebFrame. (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto. (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto. (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto. (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto. (-[WebHTMLView unmarkAllTextMatches]): Ditto. (-[WebHTMLView rectsForTextMatches]): Ditto.

WebView/WebHTMLViewInternal.h: Removed unused method declarations.

WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of _frameLoader method.

WebView/WebRenderNode.mm: (copyRenderNode): Moved code here from WebFrame. (-[WebRenderNode initWithWebFrameView:]): Ditto.

WebView/WebResource.mm: (-[WebResource _stringValue]): Moved code here from WebFrame.

WebView/WebView.mm: (-[WebView _close]): Use core function intsead of _frameLoader method. (-[WebView setCustomTextEncodingName:]): Ditto. (-[WebView setHostWindow:]): Moved code here from WebFrame. (aeDescFromJSValue): Moved this here from WebFrame. (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.

5:17 AM Changeset in webkit [31027] by Simon Hausmann

7 edits in trunk

Fix the Qt build.

1:51 AM QtWebKitContrib edited by tavestbo@trolltech.com

(diff)

1:50 AM QtWebKitContrib edited by tavestbo@trolltech.com

(diff)

12:11 AM Changeset in webkit [31026] by weinig@apple.com

2 edits in trunk/WebCore

Reviewed by Darin Adler.

Fix <rdar://problem/5784773>
Crash loading QT movies @ apple.com/ipodtouch/features.html with a PAC file (WebKitThreadingException)

Make bridged RuntimeObjects get collected on the main thread only. This is necessary
because clients of the bridged objects are unlikely to prepared for a collection on
non-main thread, which can happen with a PAC file.

bridge/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp):

Mar 12, 2008:

11:19 PM Google Summer of Code 2008 edited by Adam Roben

Removed a completed task (diff)

11:13 PM Changeset in webkit [31025] by Adam Roben

2 edits in trunk/WebCore

Fix Bug 17815: Inspector's DOM tree should descend into subframes

<http://bugs.webkit.org/show_bug.cgi?id=17815>

Reviewed by Tim.

page/inspector/DocumentPanel.js: (WebInspector.DocumentPanel.revealNode): Changed to provide _isAncestorIncludingParentFramesWithinPanel and _parentNodeOrFrameElementWithinPanel for the isAncestor and getParent parameters to findTreeElement so that parent frames will be searched. (WebInspector.DocumentPanel.updateBreadcrumb):
- Changed while loop to for loop
- Use _parentNodeOrFrameElementWithinPanel instead of Node.parentNode to move to the next node
- The loop now ends when we reach the DocumentPanel's document node
- Traversal past other Document nodes is now allowed
- We add the "start" class to the final crumb after the loop exits

(WebInspector.DocumentPanel._getDocumentForNode): Added. Simple helper
that returns the node itself if the node is a Document node, or the
node's ownerDocument otherwise.
(WebInspector.DocumentPanel._parentNodeOrFrameElementWithinPanel):
Added. Returns the node's parent node or, in the case of a Document
node, the node's window's owning frame element, but will not return a
node that is in a parent frame of the DocumentPanel's Document.
(WebInspector.DocumentPanel._isAncestorIncludingParentFramesWithinPanel):
Added. Returns true if a is an ancestor of b if a is an ancestor of a
frame element whose subframe(s) contain b.
(WebInspector.DOMNodeTreeElement): We now consider ourselves to have
children if we have a contentDocument.
(WebInspector.DOMNodeTreeElement.onpopulate): Moved the appendChild
loop into a function so that we can add both children of our
contentDocument and children of our node to the tree.
(WebInspector.DOMNodeTreeElement.ondblclick): Changed so that we get
the rootDOMNode by traversing the tree outline hierarchy instead of
the DOM hierarchy so that we can easily jump up to a parent frame.

11:13 PM Changeset in webkit [31024] by Adam Roben

3 edits in trunk/WebCore

Update the styles/metrics panes and breadcrumb after editing DOM attributes

Reviewed by Tim.

page/inspector/DocumentPanel.js: (WebInspector.DocumentPanel.set focusedDOMNode): Moved code to update the parts of the DocumentPanel other than the DOM tree into a new function, _focusedNodeChanged. (WebInspector.DocumentPanel._focusedNodeChanged): Added. The forceUpdate parameter specifies whether the update should occur even if the focused node hasn't changed since the last update. (WebInspector.DocumentPanel.updateBreadcrumb): Added a forceUpdate parameter. If forceUpdate is true, we always rebuild the breadcrumbs. (WebInspector.DocumentPanel.updateStyles): Added a forceUpdate parameter. If forceUpdate is true, we always rebuild the styles pane. (WebInspector.DOMNodeTreeElement._attributeEditingCommitted): Added a call to DocumentPanel._focusedNodeChanged. We have to force the update because we haven't changed the focused node (the attributes of the node have changed).
page/inspector/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.update): Added a forceUpdate parameter. If forceUpdate is true we always rebuild the styles.

11:05 PM Changeset in webkit [31023] by sfalken@apple.com

2 edits in trunk/WebKit/win

Fix build.

WebKit.vcproj/WebKit.vcproj:

10:49 PM Changeset in webkit [31022] by sfalken@apple.com

3 edits in trunk/WebKitLibraries

New version of WebKitSystemInterface.lib with
more compiler warnings suppressed.

win/lib/WebKitSystemInterface.lib:
win/tools/vsprops/common.vsprops:

10:40 PM Changeset in webkit [31021] by mrowe@apple.com

3 edits in trunk/WebCore

Further Gtk and Qt build fixes.

10:39 PM Changeset in webkit [31020] by sfalken@apple.com

1 edit in trunk/WebKit/win/WebKitPrefix.cpp

Touch file to build WebKit.

10:30 PM Changeset in webkit [31019] by mrowe@apple.com

3 edits in trunk/WebCore

Fix Gtk and Qt builds.

10:26 PM Changeset in webkit [31018] by mrowe@apple.com

2 edits in trunk/WebCore

Mac build fix.

10:02 PM Changeset in webkit [31017] by sfalken@apple.com

2 edits in trunk/WebCore

Build fix.

page/win/FrameWin.cpp:

9:29 PM BuildingOnWindows edited by Adam Roben

Added a note about Release build being broken in VC++ Express (diff)

9:20 PM Changeset in webkit [31016] by sfalken@apple.com

2 edits in trunk/WebCore

Build fix.

plugins/win/PluginViewWin.cpp: (WebCore::PluginView::bindingInstance):

8:50 PM Changeset in webkit [31015] by adachan@apple.com

2 edits in trunk/WebKit/win

<rdar://problem/5795843>
CFURLDownload needs to be cancelled if we don't have a destination path
to save resume information.

Reviewed by Brady.

WebDownload.cpp: (WebDownload::cancelForResume):

8:48 PM Changeset in webkit [31014] by Darin Adler

43 edits
4 deletes in trunk

WebCore:

Reviewed by Anders.

http://bugs.webkit.org/show_bug.cgi?id=17640 eliminate WebCoreFrameBridge

WebCore.base.exp: Added more exports, needed by code moved from WebCoreFrameBridge to WebFrame in WebKit.
WebCore.xcodeproj/project.pbxproj: Added more headers, same reason. Also deleted WebCoreFrameBridge.h and WebCoreFrameBridge.mm.

page/Frame.cpp: (WebCore::Frame::Frame): Added call to initJavaJSBindings(), formerly handled by the WebCoreFrameBridge.
page/Frame.h: Added initJavaJSBindings function.

page/mac/FrameMac.mm: (WebCore::updateRenderingForBindings): Moved here from WebCoreFrameBridge. (WebCore::Frame::initJavaJSBindings): Ditto; code was in the init function.

page/mac/WebCoreFrameBridge.h: Removed.
page/mac/WebCoreFrameBridge.mm: Removed.

WebKit:

Reviewed by Anders.

http://bugs.webkit.org/show_bug.cgi?id=17640 eliminate WebCoreFrameBridge

StringsNotToBeLocalized.txt: Updated for recent changes.
WebKit.xcodeproj/project.pbxproj: Removed WebFrameBridge.h and WebFrameBridge.mm.

WebKit/mac:

Reviewed by Anders.

http://bugs.webkit.org/show_bug.cgi?id=17640 eliminate WebCoreFrameBridge

Moved all the code from the bridge into WebFrame. This need not be the final
home of these methods -- they can be moved closer to their callers and improved
further -- but it eliminates the bridge without requiring a rewrite of the code.
It's a fairly mechanical process (just adding underscores to method names really).

There's even a chance that some of the methods are unused. Those we can remove
after checking if that's so.

DOM/WebDOMOperations.mm: (-[DOMNode markupString]): Use WebFrame rather than bridge. (-[DOMDocument webFrame]): Changed to use the core and kit functions instead of using the bridge. (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge. (-[DOMRange markupString]): Ditto.
DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.

DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
History/WebHistoryItem.mm: Ditto.

MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
Misc/WebCoreStatistics.mm: (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.

Misc/WebElementDictionary.mm: Removed unneeded import.

Misc/WebKitStatistics.m: (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
Misc/WebKitStatisticsPrivate.h: Ditto.

Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
Misc/WebNSPasteboardExtras.mm: Ditto.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame rather than bridge.

Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
Plugins/WebNetscapePluginStream.mm: Ditto.

Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than bridge to get to the WebCore::Frame.

Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame rather than bridge.

WebCoreSupport/WebEditorClient.mm: (selectorForKeyEvent): Tweaked comment.

WebCoreSupport/WebFrameBridge.h: Removed.
WebCoreSupport/WebFrameBridge.mm: Removed.

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion. (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code. I could remove this function entirely, but it looks like the Qt port is using it.

WebCoreSupport/WebViewFactory.mm: Removed unneeded import.

WebView/WebArchiver.mm: (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge. (+[WebArchiver archiveNode:]): Ditto. (+[WebArchiver archiveSelectionInFrame:]): Ditto.

WebView/WebDataSource.mm: (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto. (-[WebDataSource _documentFragmentWithArchive:]): Ditto. (-[WebDataSource subresources]): Ditto. (-[WebDataSource subresourceForURL:]): Ditto.

WebView/WebDataSourceInternal.h: Removed _bridge method.

WebView/WebFrame.mm: (-[WebFramePrivate dealloc]): Removed code to release the bridge. (core): Go directly to the core frame, not via the bridge. (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Remove the code to deal with the bridge. (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the shouldCreateRenderers flag, formerly on the bridge. (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge. (aeDescFromJSValue): Moved here from bridge. (-[WebFrame _domain]): Ditto. (-[WebFrame _addData:]): Ditto. (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto. (-[WebFrame _nodesFromList:]): Ditto. (-[WebFrame _markupStringFromNode:nodes:]): Ditto. (-[WebFrame _markupStringFromRange:nodes:]): Ditto. (-[WebFrame _selectedString]): Ditto. (-[WebFrame _stringForRange:]): Ditto. (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto. (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto. (-[WebFrame _sendScrollEvent]): Ditto. (-[WebFrame _drawRect:]): Ditto. (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto. (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto. (-[WebFrame _copyRenderNode:copier:]): Ditto. (-[WebFrame _copyRenderTree:]): Ditto. (inputElementFromDOMElement): Ditto. (formElementFromDOMElement): Ditto. (-[WebFrame _elementWithName:inForm:]): Ditto. (-[WebFrame _elementDoesAutoComplete:]): Ditto. (-[WebFrame _elementIsPassword:]): Ditto. (-[WebFrame _formForElement:]): Ditto. (-[WebFrame _currentForm]): Ditto. (-[WebFrame _controlsInForm:]): Ditto. (-[WebFrame _searchForLabels:beforeElement:]): Ditto. (-[WebFrame _matchLabels:againstElement:]): Ditto. (-[WebFrame _URLWithAttributeString:]): Ditto. (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto. (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto. (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto. (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto. (-[WebFrame _unmarkAllTextMatches]): Ditto. (-[WebFrame _rectsForTextMatches]): Ditto. (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto. (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto. (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto. (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto. (-[WebFrame _firstRectForDOMRange:]): Ditto. (-[WebFrame _scrollDOMRangeToVisible:]): Ditto. (-[WebFrame _baseURL]): Ditto. (-[WebFrame _stringWithData:]): Ditto. (+[WebFrame _stringWithData:textEncodingName:]): Ditto. (-[WebFrame _needsLayout]): Ditto. (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto. (-[WebFrame _accessibilityTree]): Ditto. (-[WebFrame _setBaseBackgroundColor:]): Ditto. (-[WebFrame _setDrawsBackground:]): Ditto. (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]): Ditto. (-[WebFrame _selectionGranularity]): Ditto. (-[WebFrame _convertToNSRange:]): Ditto. (-[WebFrame _convertToDOMRange:]): Ditto. (-[WebFrame _convertNSRangeToDOMRange:]): Ditto. (-[WebFrame _convertDOMRangeToNSRange:]): Ditto. (-[WebFrame _markDOMRange]): Ditto. (-[WebFrame _markedTextNSRange]): Ditto. (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto. (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto. (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto. (-[WebFrame _documentFragmentWithText:inContext:]): Ditto. (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto. (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto. (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto. (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto. (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto. (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto. (-[WebFrame _visiblePositionForPoint:]): Ditto. (-[WebFrame _characterRangeAtPoint:]): Ditto. (-[WebFrame _typingStyle]): Ditto. (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto. (-[WebFrame _fontForSelection:]): Ditto. (-[WebFrame _dragSourceMovedTo:]): Ditto. (-[WebFrame _dragSourceEndedAt:operation:]): Ditto. (-[WebFrame _getData:andResponse:forURL:]): Ditto. (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto. (-[WebFrame _canProvideDocumentSource]): Ditto. (-[WebFrame _canSaveAsWebArchive]): Ditto. (-[WebFrame _receivedData:textEncodingName:]): Ditto. (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting function. Couldn't just keep the bridge method because this was already here with the same name. (-[WebFrame _selectedNSRange]): Ditto. (-[WebFrame _selectNSRange:]): Ditto. (-[WebFrame dealloc]): Remove bridge-related code. (-[WebFrame finalize]): Ditto.

WebView/WebFrameInternal.h: Added all the method declarations from the bridge. Removed the bridge parameter from the init method. Removed the #if blocks that tried to make this header work in non-C++ ObjC files -- they were broken and unused. Removed the _bridge method.

WebView/WebFrameView.mm: Removed the _bridge method.

WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge field. (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge. (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto. (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto. (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto. (-[WebHTMLRepresentation documentSource]): Ditto. (-[WebHTMLRepresentation DOMDocument]): Ditto. (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto. (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto. (-[WebHTMLRepresentation elementIsPassword:]): Ditto. (-[WebHTMLRepresentation formForElement:]): Ditto. (-[WebHTMLRepresentation currentForm]): Ditto. (-[WebHTMLRepresentation controlsInForm:]): Ditto. (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto. (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.

WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.

WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge. (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto. (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto. (-[WebHTMLView _updateTextSizeMultiplier]): Ditto. (-[WebHTMLView _frameOrBoundsChanged]): Ditto. (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto. (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto. (-[WebHTMLView drawSingleRect:]): Ditto. (-[WebHTMLView draggedImage:movedTo:]): Ditto. (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto. (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto. (-[WebHTMLView knowsPageRange:]): Ditto. (-[WebHTMLView accessibilityAttributeValue:]): Ditto. (-[WebHTMLView accessibilityFocusedUIElement]): Ditto. (-[WebHTMLView accessibilityHitTest:]): Ditto. (-[WebHTMLView _accessibilityParentForSubview:]): Ditto. (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto. (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto. (-[WebHTMLView _changeSpellingToWord:]): Ditto. (-[WebHTMLView startSpeaking:]): Ditto. (-[WebHTMLView _updateFontPanel]): Ditto. (-[WebHTMLView _canSmartCopyOrDelete]): Ditto. (-[WebHTMLView _layoutIfNeeded]): Ditto. (-[WebHTMLView characterIndexForPoint:]): Ditto. (-[WebHTMLView firstRectForCharacterRange:]): Ditto. (-[WebHTMLView selectedRange]): Ditto. (-[WebHTMLView markedRange]): Ditto. (-[WebHTMLView attributedSubstringFromRange:]): Ditto. (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. (-[WebHTMLView insertText:]): Ditto. (-[WebTextCompleteController _insertMatch:]): Ditto. (-[WebTextCompleteController doCompletion]): Ditto. (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto. (-[WebHTMLView string]): Ditto. (-[WebHTMLView selectedString]): Ditto. (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto. (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto. (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto. (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto. (-[WebHTMLView unmarkAllTextMatches]): Ditto. (-[WebHTMLView rectsForTextMatches]): Ditto.
WebView/WebRenderNode.mm: (-[WebRenderNode initWithWebFrameView:]): Ditto.
WebView/WebResource.mm: (-[WebResource _stringValue]): Ditto.

WebView/WebScriptDebugDelegate.mm: Removed unneeded include.

WebView/WebView.mm: (-[WebView _dashboardRegions]): Use WebFrame instead of bridge. (-[WebView setProhibitsMainFrameScrolling:]): Ditto. (-[WebView _setInViewSourceMode:]): Ditto. (-[WebView _inViewSourceMode]): Ditto. (-[WebView _executeCoreCommandByName:value:]): Ditto. (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto. (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto. (-[WebView scrollDOMRangeToVisible:]): Ditto. (-[WebView setSelectedDOMRange:affinity:]): Ditto. (-[WebView setEditable:]): Ditto. (-[WebView setTypingStyle:]): Ditto. (-[WebView typingStyle]): Ditto. (-[WebView replaceSelectionWithNode:]): Ditto. (-[WebView replaceSelectionWithText:]): Ditto. (-[WebView replaceSelectionWithMarkupString:]): Ditto. (-[WebView replaceSelectionWithArchive:]): Ditto. (-[WebView _insertNewlineInQuotedContent]): Ditto. (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.

8:40 PM Changeset in webkit [31013] by weinig@apple.com

2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

Don't go through the Document just to get the frame Element.

page/DOMWindow.cpp: (WebCore::DOMWindow::frameElement):

8:18 PM Changeset in webkit [31012] by andersca@apple.com

20 edits in trunk/WebCore

Reviewed by Geoff and Sam.

More Instance cleanup:

Make Instance inherit from RefCounted instead of doing its own refcounting.
Make all Instance subclasses private, add static create methods.
Have Instance start out with a refcount of 1.
Get rid of Instance::createBindingForLanguageInstance and call the individual instance constructor methods instead.
Fix many methods to take and return PassRefPtr<Instance> to ensure that the refcounting is done correctly.

bridge/c/c_instance.h: (KJS::Bindings::CInstance::create):
bridge/c/c_utility.cpp: (KJS::Bindings::convertNPVariantToValue):
bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
bridge/jni/jni_instance.h: (KJS::Bindings::JavaInstance::create):
bridge/jni/jni_jsobject.cpp: (JavaJSObject::convertJObjectToValue):
bridge/jni/jni_runtime.cpp: (JavaField::valueFromInstance): (JavaArray::valueAt):
bridge/objc/objc_instance.h: (KJS::Bindings::ObjcInstance::create):
bridge/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue):
bridge/qt/qt_instance.cpp: (KJS::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp): (KJS::Bindings::QtInstance::getQtInstance): (KJS::Bindings::QtInstance::getRuntimeObject):
bridge/qt/qt_instance.h:
bridge/runtime.cpp: (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::createRuntimeObject):
bridge/runtime.h:
bridge/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp):
bridge/runtime_object.h:
page/Frame.h:
page/mac/FrameMac.mm: (WebCore::Frame::createScriptInstanceForWidget):
page/win/FrameWin.cpp: (WebCore::Frame::createScriptInstanceForWidget):
plugins/PluginView.h:
plugins/win/PluginViewWin.cpp: (WebCore::PluginView::bindingInstance):

5:25 PM Changeset in webkit [31011] by mitz@apple.com

2 edits in trunk/WebCore

Suggested by Darin Adler. Reviewed by Dave Hyatt.

speed up BidiIterator::direction()

rendering/bidi.cpp: (WebCore::BidiIterator::current): Made inline and corrected the out-of-bounds condition to work with 0-length text and offsets beyond the end of the text. (WebCore::BidiIterator::direction): Changed to call current() and not call the virtual method isListMarker() most of the time. (WebCore::addMidpoint): Removed unnecessary null-check of smidpoints. (WebCore::appendRunsForObject): Ditto.

4:00 PM Changeset in webkit [31010] by Adam Roben

2 edits in trunk/WebCore

Make URLs not be underlined while editing them in the DOM view

Reviewed by Tim.

page/inspector/inspector.css:

4:00 PM Changeset in webkit [31009] by Adam Roben

4 edits in trunk/WebCore

Part of Bug 17224: DOM nodes/attributes should be editable

<http://bugs.webkit.org/show_bug.cgi?id=17224>
<rdar://problem/5732825>

We now start editing if the user single-clicks on an attribute,
attribute value, or text node while the parent element is selected.
Previously, we started editing on double-click regardless of the
selection state of the element.

URLs in the DOM tree are now followed on Alt/Option-click, rather than
on just click.

Reviewed by Tim.

English.lproj/InspectorLocalizedStrings.js: Added four new localized strings.
page/inspector/DocumentPanel.js: (WebInspector.DOMNodeTreeElement.onattach): Call new _makeURLSActivateOnModifiedClick. (WebInspector.DOMNodeTreeElement._makeURLsActivateOnModifiedClick): Added. Changes the tooltip of each link in this element to indicate that Alt/Option-click will follow the URL, and sets the followOnAltClick property on each link. (WebInspector.DOMNodeTreeElement.onselect): Mark that we're being selected. (WebInspector.DOMNodeTreeElement.onmousedown): If we're not currently being selected, start editing. (WebInspector.DOMNodeTreeElement.ondblclick): We no longer start editing here. We block re-rooting of the tree if we're currently editing. (WebInspector.DOMNodeTreeElement._startEditing):
- Don't do anything if we're not focused
- Pass the event down to _startEditingAttribute.

(WebInspector.DOMNodeTreeElement._startEditingAttribute): Don't do
anything if the event target is a URL and the Alt/Option key is
pressed -- in this case we want to follow the link.
(WebInspector.DOMNodeTreeElement._updateTitle): Call
_makeURLsActivateOnClick again since the anchor elements have all been
recreated.

page/inspector/inspector.js: (WebInspector.documentClick): If the anchor as a followOnAltClick property and the Alt/Option key is not pressed, do nothing.

3:23 PM Changeset in webkit [31008] by adachan@apple.com

2 edits in trunk/WebCore

Fixed the initial value of zoom factor.

Reviewed by Adam.

page/Frame.cpp: (WebCore::FramePrivate::FramePrivate):

3:13 PM Google Summer of Code 2008 edited by webkit@mattlilek.com

Fix typo (diff)

2:41 PM Changeset in webkit [31007] by hyatt@apple.com

7 edits in trunk/WebCore

Make full page zoom vaguely work. This patch uses the CSS transform system to turn on full page zoom at the
document level. There are many many bugs that I'm going to file to track all the issues (most of the issues
are just bugs with transforms themselves).

Reviewed by Adam Roben

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
dom/Document.cpp: (WebCore::Document::recalcStyle):
page/Frame.cpp: (WebCore::Frame::shouldApplyTextZoom): (WebCore::Frame::shouldApplyPageZoom):
page/Frame.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::setHasVisibleContent): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer):
rendering/RenderLayer.h:

2:33 PM Changeset in webkit [31006] by sfalken@apple.com

1 edit in trunk/WebKit/win/WebKitPrefix.cpp

Touch file to force WebKit rebuild

1:57 PM Changeset in webkit [31005] by sfalken@apple.com

2 edits in trunk/JavaScriptCore

Build fix.

JavaScriptCore.vcproj/WTF/WTF.vcproj:

12:40 PM Changeset in webkit [31004] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2008-03-12 Tommi Komulainen <tommi.komulainen@iki.fi>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=17799
WebView signals should use more specific types

webkit/webkitwebview.cpp: Use WEBKIT_TYPE_WEB_FRAME argument type in "script-alert", "script-confirm", "script-script-prompt" signals so that it gets more clearly documented rather than just plain GObject.

12:14 PM Changeset in webkit [31003] by hyatt@apple.com

13 edits in trunk

WebCore:

Make the zoom factor a float and not a percent.

Reviewed by antti

WebCore.base.exp:
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
page/Frame.cpp: (WebCore::Frame::zoomFactor): (WebCore::Frame::setZoomFactor):
page/Frame.h:
page/FramePrivate.h:
svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale):

WebKit/mac:

Make the zoom factor a float and not a percent.

Reviewed by antti

WebView/WebView.mm: (-[WebView _setZoomMultiplier:isTextOnly:]):

WebKit/win:

Make the zoom factor a float and not a percent.

Reviewed by antti

WebFrame.cpp: (WebFrame::setTextSizeMultiplier):

WebKit/wx:

Make the zoom factor a float and not a percent.

Reviewed by antti

WebView.cpp: (wxWebView::IncreaseTextSize): (wxWebView::DecreaseTextSize):

12:10 PM Changeset in webkit [31002] by sfalken@apple.com

3 edits in trunk/WebKit/win

Build fix.

WebKit.vcproj/WebKit.pgd:
WebKit.vcproj/WebKit.vcproj:

11:50 AM Changeset in webkit [31001] by hyatt@apple.com

1 edit in trunk/WebKit/mac/WebView/WebFrame.mm

Speculative fix for build bustage. Will be another 20-30 mins before I can get compiled enough to know for sure.

11:50 AM Changeset in webkit [31000] by sfalken@apple.com

2 edits in trunk/WebKitTools

VSExpress build fix

WinLauncher/WinLauncher.vcproj:

11:45 AM Changeset in webkit [30999] by mrowe@apple.com

9 edits in branches/Safari-3-1-branch/WebCore

Merge r30992.

11:33 AM Changeset in webkit [30998] by hyatt@apple.com

12 edits in trunk

WebCore:

Eliminate setTextMultiplier from the bridge. Make Webkit just call setZoomFactor on the frame directly.

Reviewed by Tim H.

WebCore.base.exp:
page/mac/WebCoreFrameBridge.h:
page/mac/WebCoreFrameBridge.mm:

WebKit/mac:

This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
New API is added that is parallel to the text zoom public API. You can get/set a pageSizeMultiplier and you
can zoom the page in, out or reset it to the standard size.

In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
and set the common zoom factor. In other words you can't combine text zoom and page zoom. One will always
win.

Reviewed by Tim H.

WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
WebView/WebDocumentInternal.h:
WebView/WebHTMLView.mm: (-[WebHTMLView viewDidMoveToSuperview]):
WebView/WebPDFView.h:
WebView/WebPDFView.mm: (-[WebPDFView _zoomOut:]): (-[WebPDFView _zoomIn:]): (-[WebPDFView _resetZoom:]): (-[WebPDFView _canZoomOut]): (-[WebPDFView _canZoomIn]): (-[WebPDFView _canResetZoom]):
WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView setTextSizeMultiplier:]): (-[WebView textSizeMultiplier]): (-[WebView _setZoomMultiplier:isTextOnly:]): (-[WebView _zoomMultiplier:]): (-[WebView _realZoomMultiplier]): (-[WebView _realZoomMultiplierIsTextOnly]): (-[WebView _canZoomOut:]): (-[WebView _canZoomIn:]): (-[WebView _zoomOut:isTextOnly:]): (-[WebView _zoomIn:isTextOnly:]): (-[WebView _canResetZoom:]): (-[WebView _resetZoom:isTextOnly:]): (-[WebView canMakeTextSmaller]): (-[WebView makeTextSmaller:]): (-[WebView canMakeTextLarger]): (-[WebView makeTextLarger:]): (-[WebView canMakeTextStandardSize]): (-[WebView makeTextStandardSize:]): (-[WebView setPageSizeMultiplier:]): (-[WebView pageSizeMultiplier]): (-[WebView canZoomPageIn]): (-[WebView zoomPageIn:]): (-[WebView canZoomPageOut]): (-[WebView zoomPageOut:]): (-[WebView canResetPageZoom]): (-[WebView resetPageZoom:]): (-[WebView _searchWithSpotlightFromMenu:]):
WebView/WebViewInternal.h:
WebView/WebViewPrivate.h:

11:31 AM Changeset in webkit [30997] by mitz@apple.com

13 edits in trunk

WebCore:

Reviewed by Darin Adler and Sam Weinig.

<rdar://problem/4433248> use CoreText API instead of SPI on Leopard

Use CTFontCopyGraphicsFont and CTFontGetPlatformFont on Leopard instead
of wkGetCGFontFromNSFont and wkGetNSFontATSUFontId, relying on NSFont
and CTFontRef being toll-free bridged.

WebCore.Tiger.exp:
WebCore.base.exp:
platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs): Changed to use the cgFont() accessor.
platform/graphics/mac/FontPlatformData.h: Made m_cgFont a RetainPtr on Leopard. (WebCore::toCTFontRef): Added a function that encapsulates the toll-free bridging. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::cgFont): Added this accessor method.
platform/graphics/mac/FontPlatformDataMac.mm: (WebCore::FontPlatformData::FontPlatformData): Changed to use CoreText API on Leopard. (WebCore::FontPlatformData::setFont): Ditto.
platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::initFontData): (WebCore::pathFromFont): (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformWidthForGlyph):
platform/mac/WebCoreSystemInterface.mm:

WebKit/mac:

Reviewed by Darin Adler and Sam Weinig.

<rdar://problem/4433248> use CoreText API instead of SPI on Leopard

WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and WKGetNSFontATSUFontId Tiger-only.

WebKitLibraries:

Reviewed by Darin Adler and Sam Weinig.

<rdar://problem/4433248> use CoreText API instead of SPI on Leopard

WebKitSystemInterface.h:
libWebKitSystemInterfaceLeopard.a:

11:06 AM Changeset in webkit [30996] by alp@webkit.org

2 edits in trunk/WebKitTools

2008-03-12 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Alp Toker.

Run testkjs in the correct productsDir in the GTK+ port.

Scripts/run-javascriptcore-tests:

10:56 AM Changeset in webkit [30995] by sfalken@apple.com

4 edits in trunk/WebKit/win

Re-enabled PGO.

Rubber stamped by Mark Rowe.

WebKit.vcproj/WebKit.pgd:
WebKit.vcproj/WebKit.vcproj:
WebKitPrefix.cpp: touched this file to force a re-build.

10:40 AM Google Summer of Code 2008 edited by eric@webkit.org

(diff)

10:20 AM Changeset in webkit [30994] by alp@webkit.org

2 edits in trunk/JavaScriptCore

2008-03-12 Alp Toker <alp@atoker.com>

Another autotools testkjs build fix attempt.

GNUmakefile.am:

9:38 AM Changeset in webkit [30993] by Darin Adler

2 edits in trunk/WebKit/mac

fix http://bugs.webkit.org/show_bug.cgi?id=17794 REGRESSION (r30980): 23 tests hanging on the Mac buildbot

WebView/WebFrame.mm: (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set up pointer from the bridge to the frame. (My next check-in removes the bridge entirely, but we need this until then.)

9:16 AM Changeset in webkit [30992] by harrison@apple.com

9 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5607382> CrashTracer: [REGRESSION] 2290 crashes in Safari at com.apple.WebCore: -[WebCoreAXObject isWebArea] + 8

The problem was that we lost track of the AX cache for a subframe when Frame::disconnectOwnerElement() was
called, so we were unable to locate the AXObjects to de-register from AppKit's accessibility registry.
Also saw that cache clearing was missing from Document::detach(), and fixed that.

Also added a debug-only check that AXObjectCache::remove() not finding the AXObject is expected.

Lastly, RenderWidget::destroy() now skips trying to remove the AXObject if accessibility has never been enabled.

dom/Document.cpp: (WebCore::Document::attach): Assert that there is no AX cache (since there is no renderer).

(WebCore::Document::detach):
Destroy the AX cache installed on this document.

(WebCore::Document::clearAXObjectCache):
New. Destroy the AX cache associated with this document.

(WebCore::Document::axObjectCache):
Added some comments.

dom/Document.h: Declare clearAXObjectCache().

page/Frame.cpp: (WebCore::Frame::disconnectOwnerElement): Destroy the AX cache associated with this frame's document.

page/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::remove):
page/mac/WebCoreAXObject.mm: (-[WebCoreAXObject initWithRenderer:]): (-[WebCoreAXObject detach]):
rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::~RenderObject):
rendering/RenderObject.h: (WebCore::RenderObject::setHasAXObject): (WebCore::RenderObject::hasAXObject): Add debug-only check that AXObjectCache::remove() not finding the AXObject is expected.

rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): Skip call to remove the AXObject if accessibility has never been enabled. A simple speed optimization in the very common case that the accessibility APIs are not being used. Same as in RenderObject::destroy().

9:12 AM Changeset in webkit [30991] by alp@webkit.org

2 edits in trunk/JavaScriptCore

2008-03-12 Alp Toker <alp@atoker.com>

Attempt to fix the autotools testkjs build on systems with
non-standard include paths.

GNUmakefile.am:

8:08 AM Changeset in webkit [30990] by alp@webkit.org

2 edits in trunk

Credit the original patch author in the r30989 ChangeLogs

8:03 AM Changeset in webkit [30989] by alp@webkit.org

6 edits
4 adds in trunk

2008-03-12 Xan Lopez <xan@gnome.org>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=15229

Add Pango font backend.

3:01 AM QtWebKitHacking created by bmeyer@trolltech.com

2:54 AM QtWebKitTodo edited by bmeyer@trolltech.com

(diff)

1:47 AM Changeset in webkit [30988] by Simon Hausmann

4 edits in trunk/WebKit/qt

Fix compilation against Qt 4.3

1:17 AM QtWebKitContrib edited by Simon Hausmann

(diff)

1:12 AM Changeset in webkit [30987] by justin.garcia@apple.com

4 edits
2 adds in trunk

WebCore:

Reviewed by Oliver.

<rdar://problem/5770834> Crash at InsertTextCommand::prepareForTextInsertion() doing RemoveFormat in a certain list

Fixes some (but not all) of the instances of:
<rdar://problem/5659795> CrashTracer: [REGRESSION] 187 crashes in Safari at com.apple.WebCore: WebCore::InsertTextCommand::prepareForTextInsertion + 241
<rdar://problem/5779631> CrashTracer: [USER] 25 crashes in Mail at WebCore::InsertTextCommand::prepareForTextInsertion

editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): applyStyle may have destroyed content that held the old endingSelection(), so we must recompute it. Added a FIXME. Added a few comments.
editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply): Added a FIXME.

LayoutTests:

Reviewed by Oliver.

<rdar://problem/5770834> Crash at InsertTextCommand::prepareForTextInsertion() doing RemoveFormat in a certain list

editing/execCommand/5770834-1-expected.txt: Added.
editing/execCommand/5770834-1.html: Added.

1:07 AM Changeset in webkit [30986] by ap@webkit.org

5 edits
3 copies
2 adds in trunk

Reviewed by Darin.

<rdar://problem/5640615> REGRESSION (Safari 2-3): Changing subframe encoding rules broke
some sites.

Other browsers' behavior keeps changing; let's implement what Firefox and Opera do now:
if the frame and subframe belong to the same site, then the encoding is inherited from parent
frame to subframe. Otherwise, it is not.

Always inheriting the encoding would cause a security problem.

Tests: http/tests/misc/frame-default-enc-different-domain.html

http/tests/misc/frame-default-enc-same-domain.html
fast/encoding/frame-default-enc.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::write): Also removed a check for m_frame->document() being non-null - this function also has code that uses it without checking, so it must be safe.

1:04 AM Changeset in webkit [30985] by sfalken@apple.com