⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 14, 2008:

11:06 PM Changeset in webkit [31073] by sfalken@apple.com
  • 6 edits in trunk

JavaScriptCore:

PGO build fixes.

WebCore:

PGO build fixes.

  • WebCore.vcproj/WebCore.vcproj:

WebKit/win:

PGO build fixes.

  • WebKit.vcproj/WebKit.vcproj:
6:05 PM Changeset in webkit [31072] by oliver@apple.com
  • 8 edits in trunk/JavaScriptCore

Add logic to track whether a function uses a locally scoped eval or requires a closure

Reviewed by Maciej

Now that we limit eval we can track those uses of eval that operate
in the local scope and functions that require a closure. We track
this information during initial parsing to avoid yet another tree
walk.

5:21 PM Changeset in webkit [31071] by andersca@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Sam.

<rdar://problem/5794989>
​https://bugs.webkit.org/show_bug.cgi?id=17792
REGRESSION (Safari 3.0.4-3.1): Ordering tickets from Sweden's biggest train operator doesn't work

Pass the frame loader that should be used for looking up the frame name to FrameLoader::createWindow
so that somewindow.open calls where the active window and 'somewindow' differ return the correct frame.


  • bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow):
  • loader/FrameLoader.h:

LayoutTests:

Reviewed by Sam.

<rdar://problem/5794989>
​https://bugs.webkit.org/show_bug.cgi?id=17792
REGRESSION (Safari 3.0.4-3.1): Ordering tickets from Sweden's biggest train operator doesn't work


Add tests.


  • fast/dom/Window/window-open-self-from-other-frame-expected.txt: Added.
  • fast/dom/Window/window-open-self-from-other-frame.html: Added.
3:57 PM Changeset in webkit [31070] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog

3:54 PM Changeset in webkit [31069] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • fix <rdar://problem/5797836> shadow offsets are smaller than specified
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setShadow): Made the workaround for <rdar://problem/5643663> unconditional.
2:06 PM Changeset in webkit [31068] by Adam Roben
  • 3 edits in trunk/WebCore

Fix it right this time

  • platform/MainThread.cpp: Cast to unsigned so we can use %u in the format string.
  • platform/mac/MainThreadMac.mm:
1:57 PM Changeset in webkit [31067] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Brian Dash's rubberstamp

Remove a class declaration for a class that has never existed

  • WebView/WebResource.h:
1:47 PM Changeset in webkit [31066] by Adam Roben
  • 2 edits in trunk/WebCore

Mac build fix

  • platform/mac/MainThreadMac.mm: Corrected a typo.
1:34 PM Changeset in webkit [31065] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/css/first-letter-float.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter): Changed the search for the first text node to stop at a float if that float is an existing first- letter.

LayoutTests:

Reviewed by Darin Adler.

  • fast/css/first-letter-float.html: Added.
  • platform/mac-leopard/fast/css/first-letter-float-expected.checksum: Added.
  • platform/mac-leopard/fast/css/first-letter-float-expected.png: Added.
  • platform/mac/fast/css/first-letter-float-expected.txt: Added.
1:15 PM Changeset in webkit [31064] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix Mac build

  • WebCore.xcodeproj/project.pbxproj:
12:53 PM Changeset in webkit [31063] by Adam Roben
  • 12 edits
    1 copy in trunk/WebCore

Make most of callOnMainThread's implementation be cross-platform

I took the non-platform-specific parts of MainThreadWin.cpp and moved
them to a new MainThread.cpp. Each platform is now responsible for
implementing one function, scheduleDispatchFunctionsOnMainThread,
which is supposed to set things up so that
dispatchFunctionsFromMainThread gets called from the main thread in
the near future.

Reviewed by Alexey.

  • GNUmakefile.am: Added MainThread.cpp to the project.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • platform/MainThread.cpp:
    • Copied from WebCore/platform/win/MainThreadWin.cpp.
    • Removed the Windows-specific parts.

(WebCore::callOnMainThread): Changed to call
scheduleDispatchFunctionsOnMainThread instead of PostMessage.

  • platform/gtk/MainThreadGtk.cpp: (WebCore::timeoutFired): Renamed from callFunctionOnMainThread. Now just calls dispatchFunctionsFromMainThread. (WebCore::scheduleDispatchFunctionsOnMainThread): Added. Calls through to g_timeout_add.
  • platform/mac/MainThreadMac.mm: Renamed WebCoreFunctionWrapper to WebCoreMainThreadCaller. (-[WebCoreMainThreadCaller call]): Calls through to dispatchFunctionsFromMainThread. (WebCore::scheduleDispatchFunctionsOnMainThread): Makes a new WebCoreMainThreadCaller and calls performSelectorOnMainThread on it.
  • platform/qt/MainThreadQt.cpp: Removed PerformFunctionEvent. (WebCore::MainThreadInvoker::event): Chagned to call through to dispatchFunctionsFromMainThread. (WebCore::scheduleDispatchFunctionsOnMainThread): Sends an empty event to the MainThreadInvoker.
  • platform/win/MainThreadWin.cpp:
    • Removed the non-Windows-specific parts.
    • Removed some unnecessary initialization of static variables to 0.

(WebCore::ThreadingWindowWndProc): Changed to call
dispatchFunctionsFromMainThread.
(WebCore::scheduleDispatchFunctionsOnMainThread): Calls through to
PostMessage.

  • platform/wx/MainThreadWx.cpp: (WebCore::scheduleDispatchFunctionsOnMainThread): Added.
12:28 PM Changeset in webkit [31062] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Beth Dakin.

Fixed another problem with Vector::shrinkCapacity.


moveOverlapping isn't good enough for the case where the buffer hasn't
changed, because it still destroys the contents of the buffer.

  • wtf/Vector.h: (WTF::::shrinkCapacity): Changed to explicitly check whether the call to allocateBuffer produced a new buffer. If it didn't, there's no need to move.
12:05 PM Changeset in webkit [31061] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Beth Dakin.


Fixed a few problems with Vector::shrinkCapacity that I noticed in testing.

  • wtf/Vector.h: (WTF::VectorBufferBase::deallocateBuffer): Clear our m_buffer pointer when we deallocate m_buffer, in case we're not asked to reallocate a new buffer. (Otherwise, we would use a stale m_buffer if we were asked to perform any operations after shrinkCapacity was called.)


(WTF::VectorBuffer::allocateBuffer): Made VectorBuffer with inline
capacity aware that calls to allocateBuffer might be shrinks, rather
than grows, so we shouldn't allocate a new buffer on the heap unless
our inline buffer is too small.


(WTF::::shrinkCapacity): Call resize() instead of just setting m_size,
so destructors run. Call resize before reallocating the buffer to make
sure that we still have access to the objects we need to destroy. Call
moveOverlapping instead of move, since a call to allocateBuffer on an
inline buffer may produce identical storage.

11:28 AM Changeset in webkit [31060] by Beth Dakin
  • 5 edits in trunk/WebCore

Reviewed by Geoff.

Fix for <rdar://problem/5728171> Potential PLT speedup: don't
realloc every time inside NamedAttrMap::addAttribute

The speed-up for this turned out to be so small that it is mostly
imperceptible. It is likely that it is a tiny boost, though, and
the new code is much cleaner.

  • dom/Element.cpp: (WebCore::Element::setAttributeMap): attrs is now called m_attributes
  • dom/NamedAttrMap.cpp: The array attrs is now the Vector of RefPtrs called m_attributes, and there is no longer any need for the len member variable. (WebCore::NamedAttrMap::NamedAttrMap): (WebCore::NamedAttrMap::item): (WebCore::NamedAttrMap::getAttributeItem): (WebCore::NamedAttrMap::clearAttributes): (WebCore::NamedAttrMap::operator=): (WebCore::NamedAttrMap::addAttribute): (WebCore::NamedAttrMap::removeAttribute): (WebCore::NamedAttrMap::mapsEquivalent):
  • dom/NamedAttrMap.h: Same. (WebCore::NamedAttrMap::length): (WebCore::NamedAttrMap::attributeItem): (WebCore::NamedAttrMap::shrinkToLength): (WebCore::NamedAttrMap::reserveCapacity):
  • html/HTMLTokenizer.cpp: One of the benefits of the old array was that it never took up more memory than it needed to. So the tokenizer utilizes new member functions on NamedAttrMap (shrinkToLength and reserveCapacity) to try to keep memory usage at a minimum. (WebCore::Token::addAttribute): (WebCore::HTMLTokenizer::processToken):
8:21 AM Changeset in webkit [31059] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix typos.

8:19 AM Changeset in webkit [31058] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

BUILD FIX when ENABLE(MAC_JAVA_BINDINGS) set to 0.

  • page/mac/FrameMac.mm: Move up #if ENABLE(MAC_JAVA_BINDINGS) guard to comment out unused code.
7:59 AM Changeset in webkit [31057] by ap@webkit.org
  • 4 edits in trunk/JavaScriptCore

Reviewed by Darin.

Get rid of a localime() call on platforms that have better alternatives.

  • kjs/DateMath.h: Added getLocalTime();
  • kjs/DateMath.cpp: (KJS::getLocalTime): (KJS::getDSTOffsetSimple): Implementation moved from getDSTOffsetSimple().
  • kjs/date_object.cpp: (KJS::DateObjectImp::callAsFunction): Switched to getLocalTime().
7:34 AM Changeset in webkit [31056] by ddkilzer@apple.com
  • 26 edits
    1 add
    1 delete in trunk

JavaScriptCore:

Unify concept of enabling the Mac Java bridge.

Reviewed by Darin and Anders.

  • wtf/Platform.h: Define ENABLE_MAC_JAVA_BRIDGE here.

WebCore:

Unify concept of enabling the Mac Java bridge.

Reviewed by Darin and Anders.

No test cases added since there is no change in functionality.

  • DerivedSources.make: Added check for ENABLE_MAC_JAVA_BRIDGE macro. If defined as "1", add WebCore.JNI.exp to WEBCORE_EXPORT_DEPENDENCIES.
  • WebCore.JNI.exp: Added.
  • WebCore.base.exp: Moved exported JNI methods to WebCore.JNI.exp.
  • bridge/jni/jni_class.cpp: Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
  • bridge/jni/jni_class.h: Ditto.
  • bridge/jni/jni_instance.cpp: Ditto.
  • bridge/jni/jni_instance.h: Ditto.
  • bridge/jni/jni_jsobject.cpp: Ditto.
  • bridge/jni/jni_jsobject.h: Ditto.
  • bridge/jni/jni_objc.mm: Ditto.
  • bridge/jni/jni_runtime.cpp: Ditto.
  • bridge/jni/jni_runtime.h: Ditto.
  • bridge/jni/jni_utility.cpp: Ditto.
  • bridge/jni/jni_utility.h: Ditto.
  • bridge/runtime.cpp: Removed unused #include statements.
  • bridge/runtime.h: (KJS::Bindings::Instance::BindingLanguage): Added #if ENABLE(MAC_JAVA_BRIDGE) guard for JavaLanguage enum. Also added #if PLATFORM(MAC) guard for ObjectiveCLanguage enum to match corresponding code in runtime.cpp.
  • config.h: Removed definition of HAVE_JNI.
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
  • page/Frame.cpp: (WebCore::Frame::Frame): Ditto.
  • page/Frame.h: (WebCore::Frame::initJavaJSBindings): Ditto.
  • page/mac/FrameMac.mm: (WebCore::Frame::createScriptInstanceForWidget): Ditto. (WebCore::Frame::initJavaJSBindings): Ditto.

WebKit/mac:

Unify concept of enabling the Mac Java bridge.

Reviewed by Darin and Anders.

  • Plugins/WebPluginJava.h: Removed unused file.
  • WebCoreSupport/WebFrameLoaderClient.h: (WebFrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
  • WebCoreSupport/WebFrameLoaderClient.mm: Ditto for #import and NSView SPI method. (WebFrameLoaderClient::javaApplet): Ditto.
1:09 AM Changeset in webkit [31055] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix the Qt build.

12:13 AM Changeset in webkit [31054] by Darin Adler
  • 3 edits in trunk/WebCore
  • html/PreloadScanner.h: Corrected license.
  • html/PreloadScanner.cpp: Corrected license.

Mar 13, 2008:

11:22 PM Developer Tools Hitlist edited by Adam Roben
(diff)
9:40 PM Changeset in webkit [31053] by pewtermoose@webkit.org
  • 2 edits in trunk/WebKitTools

2008-03-13 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Darin.

Correct paths to vsprops files so they use the environment
variable, rather than hard-coded path.
​http://bugs.webkit.org/show_bug.cgi?id=17797.

  • WinLauncher/WinLauncher.vcproj: Correct paths to vsprops.
9:19 PM Changeset in webkit [31052] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by darin. Landed by eseidel.

  • platform/FloatConversion.h: Include a header to get CoreGraphics types when using CoreGraphics types.
9:19 PM Changeset in webkit [31051] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by eseidel. Landed by eseidel.

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp:
  • css/makeprop.pl: Move CSSPropertyNames.c to CSSPropertyNames.cpp
8:47 PM Changeset in webkit [31050] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by eseidel. Landed by eseidel.

  • platform/Arena.h: Use statement1;statement2 instead of (statement1,statement2) in CLEAR_UNUSED.
8:44 PM Changeset in webkit [31049] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by eseidel. Landed by eseidel.

  • wtf/FastMalloc.cpp: #include <wtf/HashSet.h> outside of any namespaces.
8:43 PM Changeset in webkit [31048] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by eseidel. Landed by eseidel

  • pcre/pcre_exec.cpp: Fix misnamed variable, allowing -DDEBUG build to succeed.
  • wtf/ThreadingPthreads.cpp: #include <sys/time.h> for gettimeofday in non-pch build.
8:07 PM Changeset in webkit [31047] by Antti Koivisto
  • 4 edits in trunk/LayoutTests

Reviewed by Mitz.


Update test results for the preload patch. Load order for some resources changed,
this does not affect the substance of these tests.

  • platform/mac-leopard/security/block-test-expected.txt:
  • security/block-test-expected.txt:
  • webarchive/loading/cache-expired-subresource-expected.txt:
7:47 PM Changeset in webkit [31046] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-03-13 Tommi Komulainen <​tommi.komulainen@iki.fi>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=17821
[SOUP] POST requests are empty

Send the HTTP request body as well.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start):
4:16 PM Changeset in webkit [31045] by timothy@apple.com
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix the build.

3:14 PM Changeset in webkit [31044] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Test: fast/table/border-collapsing/equal-precedence-resolution.html

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): When calling compareBorders() with borders that may have the same precedence, made sure to pass the border belonging to the earlier (in document order) element first, since compareBorders() prefers the first argument when there is a tie. (WebCore::RenderTableCell::collapsedRightBorder): Ditto. (WebCore::RenderTableCell::collapsedTopBorder): Ditto.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/table/border-collapsing/equal-precedence-resolution.html: Added.
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.checksum: Added.
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.png: Added.
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.txt: Added.
3:07 PM Changeset in webkit [31043] by Adam Roben
  • 2 edits in trunk/WebKit/win

Another Windows build fix after r31034

  • WebKitDLL.cpp: (loadResourceIntoBuffer): Use SharedBuffer::create.
2:40 PM Changeset in webkit [31042] by Adam Roben
  • 5 edits in trunk

Build fixes after r31034

WebCore:

wx build fix and Windows leak fix after r31034

  • platform/graphics/wx/ImageWx.cpp: (WebCore::Image::loadPlatformResource): Use SharedBuffer::create.
  • platform/win/SharedBufferWin.cpp: (WebCore::SharedBuffer::createWithContentsOfFile): Ditto (we were leaking the SharedBuffer here before).

WebKit/win:

Windows build fix after r31034

  • WebFrame.cpp: (WebFrame::loadData): Use SharedBuffer::create. (WebFrame::loadHTMLString): Ditto.
2:31 PM Changeset in webkit [31041] by Antti Koivisto
  • 3 edits in trunk/WebCore

Reviewed by Eric.

Correct a few issues spotted by Mike Belshe.

  • html/PreloadScanner.cpp: (WebCore::PreloadScanner::tokenize):
  • loader/loader.cpp: (WebCore::Loader::cancelRequests):
2:26 PM Changeset in webkit [31040] by Adam Roben
  • 4 edits in trunk

Fix GTK+ build for SharedBuffer changes.

WebCore:

2008-03-13 Rodney Dawes <​dobey@wayofthemonkey.com>

Fix GTK+ build for SharedBuffer changes.

  • platform/graphics/gtk/ImageGtk.cpp: (Image::loadPlatformResource):

WebKit/gtk:

2008-03-13 Rodney Dawes <​dobey@wayofthemonkey.com>

Fix GTK+ build for SharedBuffer changes.

  • webkit/webkitwebview.cpp: (webkit_web_view_load_string):
2:24 PM Changeset in webkit [31039] by sfalken@apple.com
  • 5 edits
    1 delete in trunk

WebCore:

More PGO build fixes.

  • WebCorePrefix.cpp:

WebKit/win:

More PGO build fixes.

  • WebKit.vcproj/WebKit.pgd: Removed.
  • WebKit.vcproj/WebKit.vcproj:
  • WebKitPrefix.cpp:
2:20 PM Changeset in webkit [31038] by Antti Koivisto
  • 16 edits
    3 adds in trunk

WebCore:

Reviewed by Darin.


Make page loads go fast.


​http://bugs.webkit.org/show_bug.cgi?id=17480

  • Implement speculative preloading. When a script load blocks the main parser, use a side parser to pick up more resources.
  • Implement per-host load queues, prioritize scripts and stylesheets over images.


Depending on content and network latency this may speed things up quite a bit.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::implicitClose): Clear the preloads after laoding completes.


  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute): (WebCore::HTMLLinkElement::tokenizeRelAttribute):
  • html/HTMLLinkElement.h: Make tokenizeRelAttribute() public static so it can be used from elsewhere. Eliminate a pointless bitfield so I can get references.


  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::write):
  • html/HTMLTokenizer.h: Spin up the preload scanner whenever a script load blocks the parser. One scanner tracks the end of the document while temporary ones are created as needed to scan document.write() output.


  • html/PreloadScanner.cpp: Added. (WebCore::PreloadScanner::PreloadScanner): (WebCore::PreloadScanner::~PreloadScanner): (WebCore::PreloadScanner::begin): (WebCore::PreloadScanner::end): (WebCore::PreloadScanner::reset): (WebCore::PreloadScanner::write): (WebCore::isWhitespace): (WebCore::PreloadScanner::clearLastCharacters): (WebCore::PreloadScanner::rememberCharacter): (WebCore::PreloadScanner::lastCharactersMatch): (WebCore::legalEntityFor): (WebCore::PreloadScanner::consumeEntity): (WebCore::PreloadScanner::tokenize): (WebCore::PreloadScanner::processAttribute): (WebCore::PreloadScanner::emitCharacter): (WebCore::PreloadScanner::tokenizeCSS): (WebCore::PreloadScanner::emitTag): (WebCore::PreloadScanner::emitCSSRule):
  • html/PreloadScanner.h: Added. (WebCore::PreloadScanner::inProgress): (WebCore::PreloadScanner::): HTML5 tokenization plus some glue code. Fake CSS parsing thrown in just for fun.


  • loader/Cache.cpp: (WebCore::Cache::pruneDeadResources): Preloads have zero refcount, avoid kicking them out too early.


  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::ref):
  • loader/CachedResource.h: (WebCore::CachedResource::): (WebCore::CachedResource::preloadResult): (WebCore::CachedResource::setRequestedFromNetworkingLayer): (WebCore::CachedResource::canDelete): (WebCore::CachedResource::isPreloaded): (WebCore::CachedResource::increasePreloadCount): (WebCore::CachedResource::decreasePreloadCount): Keep track which resources are preloads. Avoid deleting them. Track at which point of the loading preloads get utilized to enable some interesting statistics.


  • loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader): (WebCore::DocLoader::checkForReload): (WebCore::DocLoader::registerPreload): (WebCore::DocLoader::clearPreloads): (WebCore::DocLoader::printPreloadStats):
  • loader/DocLoader.h: Ensure we utilize preloaded resources during reloads. Keep a list of all preloads in the document. Clear the preloads after parsing is complete. Some debug statistics.


  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense): Avoid signaling that loading is complete too early.


  • loader/loader.cpp: (WebCore::Loader::Loader): (WebCore::Loader::~Loader): (WebCore::Loader::determinePriority): (WebCore::Loader::load): (WebCore::Loader::scheduleServePendingRequests): (WebCore::Loader::requestTimerFired): (WebCore::Loader::servePendingRequests): (WebCore::Loader::cancelRequests): (WebCore::Loader::Host::Host): (WebCore::Loader::Host::~Host): (WebCore::Loader::Host::addRequest): (WebCore::Loader::Host::hasRequests): (WebCore::Loader::Host::servePendingRequests): (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail): (WebCore::Loader::Host::didReceiveResponse): (WebCore::Loader::Host::didReceiveData): (WebCore::Loader::Host::cancelPendingRequests): (WebCore::Loader::Host::cancelRequests):
  • loader/loader.h: (WebCore::Loader::): Distribute load requests to per-host priority queues. Limit the number of loads issued to the networking layer so we have better changes of getting important requests through first. Prioritize scripts > stylesheets > images.

WebKit/mac:

Reviewed by Darin.

  • ForwardingHeaders/wtf/Deque.h: Added.
2:01 PM Changeset in webkit [31037] by hyatt@apple.com
  • 8 edits in trunk/WebCore

This patch makes full page zoom work pretty well. It fixes repainting so that it works when transforms
are set on the RenderView. It also implements the "smart layout" behavior that other browsers support when
zooming. The page will still try to constrain to the viewport size even when zoomed.

Reviewed by john

  • dom/Document.cpp: (WebCore::Document::recalcStyle): Make sure to test for transform changes even when there is no zoom. This fixes repainting issues caused by jumping from a zoomed state back to the standard size.
  • page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): Adjust for the zoom factor (the render tree is in unzoomed coordinates, but the scrollbars of the view need to handle zoomed coordinates).
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight): Fix the body-sizing-to-the-view-height quirk so that it takes the zoom factor into account when stretching to fill the viewport.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::setHasVisibleContent): Remove the FIXMEs now that absoluteClippedOverflowRect works with transforms on the RenderView.
  • rendering/RenderView.cpp: (WebCore::RenderView::calcHeight): (WebCore::RenderView::calcWidth): Make sure the calculated width/height take the zoom factor into account in order to get the "smart layout" behavior.

(WebCore::RenderView::layout):
When deciding whether children have to get a relayout, we need to check the zoomed width/height and not just
the viewport size.

(WebCore::RenderView::computeAbsoluteRepaintRect):
Patched to take into account transforms set on the RenderView.

(WebCore::RenderView::docHeight):
(WebCore::RenderView::docWidth):
Patched to just always use m_width and m_height initially, since those have already been adjusted for
the zoom factor.

(WebCore::RenderView::zoomedHeight):
(WebCore::RenderView::zoomedWidth):

  • rendering/RenderView.h: New helper methods for obtaining the adjusted width/height of the viewport taking into account the zoom factor.
1:02 PM Changeset in webkit [31036] by andersca@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • WebCore.base.exp:
12:08 PM Changeset in webkit [31035] by andersca@apple.com
  • 8 edits in trunk

WebCore:

Reviewed by Adam.

Get rid of actualRequest, it is not used anymore. Also, get rid of
initialRequest and replace all uses with originalRequest because those are
the same thing.


  • loader/DocumentLoader.cpp:
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::originalRequestURL):

WebKit/mac:

Reviewed by Adam.

Call originalRequest, not initialRequest.


  • WebView/WebDataSource.mm: (-[WebDataSource initialRequest]):

WebKit/win:

Reviewed by Adam.

Call originalRequest instead of initialRequest.


  • WebDataSource.cpp: (WebDataSource::initialRequest):
12:00 PM Changeset in webkit [31034] by beidson@apple.com
  • 8 edits in trunk/WebCore

Reviewed by Anders

Convert SharedBuffer to start with a refCount of 1

  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::willStopBufferingData):
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultIcon): (WebCore::IconDatabase::getImageDataForIconURLFromSQLDatabase):
  • loader/loader.cpp: (WebCore::Loader::didReceiveData):
  • platform/SharedBuffer.h: (WebCore::SharedBuffer::create): Make all constructors private, add ::create() calls
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::SharedBuffer): Revert to default RefCounted constructor to start with a ref count of 1 (WebCore::SharedBuffer::copy):
  • platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::wrapNSData): (WebCore::SharedBuffer::SharedBuffer): Revert to default RefCounted constructor to start with a ref count of 1
11:42 AM BuildingOnWindows edited by Adam Roben
Removed note about PGO (this was fixed in r31033) (diff)
11:37 AM Changeset in webkit [31033] by sfalken@apple.com
  • 6 edits in trunk

JavaScriptCore:

PGO build fixes.


Disable PGO for normal release builds.
Added work-in-progress Release_PGOInstrument/Release_PGOOptimize targets.

WebCore:

PGO build fixes.


Disable PGO for normal release builds.
Added work-in-progress Release_PGOInstrument/Release_PGOOptimize targets.

  • WebCore.vcproj/WebCore.vcproj:

WebKit/win:

PGO build fixes.


Disable PGO for normal release builds.
Added work-in-progress Release_PGOInstrument/Release_PGOOptimize targets.

  • WebKit.vcproj/WebKit.vcproj:
11:32 AM Changeset in webkit [31032] by Beth Dakin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Adding new functionality to Vector. Currently all of the shrink and
resize functions on Vector only shrink the size of the Vector, not
the capacity. For the Vector to take up as little memory as
possible, though, it is necessary to be able to shrink the capacity
as well. So this patch adds that functionality.

I need this for a speed up I am working on, and Geoff wants to use
it in a speed up he is working on also, so he asked me to commit it
now.

  • wtf/Vector.h: (WTF::VectorBufferBase::allocateBuffer): (WTF::::shrinkCapacity):
11:18 AM Changeset in webkit [31031] by andersca@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Make a bunch of DocumentLoader setters/getters inline.


  • loader/DocumentLoader.cpp:
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isCommitted): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::response): (WebCore::DocumentLoader::mainDocumentError): (WebCore::DocumentLoader::setResponse): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::setIsClientRedirect): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::responses): (WebCore::DocumentLoader::triggeringAction): (WebCore::DocumentLoader::setTriggeringAction): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::setLastCheckedRequest): (WebCore::DocumentLoader::lastCheckedRequest): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::setLoadingFromCachedPage): (WebCore::DocumentLoader::isLoadingFromCachedPage):
9:17 AM Changeset in webkit [31030] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Attempt at fixing the Qt/Windows build bot. Quote using double-quotes
instead of single quotes.

8:19 AM Changeset in webkit [31029] by Adam Roben
  • 2 edits in trunk/WebCore

2008-03-13 Rodney Dawes <​dobey@wayofthemonkey.com>

Fix builds without SVG enabled.

  • page/Frame.cpp: (Frame::shouldApplyTextZoom): (Frame::shouldApplyPageZoom):
7:49 AM Changeset in webkit [31028] by Darin Adler
  • 15 edits in trunk/WebKit/mac

Reviewed by John Sullivan.

  • cleanup after removing the bridge
  • DOM/WebDOMOperations.mm: (-[DOMDocument URLWithAttributeString:]): Call computeURL directly.
  • Misc/WebCoreStatistics.mm: (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of _frameLoader method. (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): Ditto.
  • Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame method. Without this we could leave a stale frame pointer around. (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single caller of the _isMainFrame method. (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of _frameLoader method. (WebFrameLoaderClient::createFrame): Moved code here from _addChild.
  • WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others turned out to be unused. (core): Added overload for DocumentFragment. (kit): Ditto. (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and to FrameLoader with _private->coreFrame->loader(). (-[WebFrame _attachScriptDebugger]): Ditto. (-[WebFrame _clearCoreFrame]): Added. (-[WebFrame _updateBackground]): More of the same. (-[WebFrame _unmarkAllBadGrammar]): Ditto. (-[WebFrame _unmarkAllMisspellings]): Ditto. (-[WebFrame _hasSelection]): Ditto. (-[WebFrame _atMostOneFrameHasSelection]): Ditto. (-[WebFrame _findFrameWithSelection]): Ditto. (-[WebFrame _dataSource]): Ditto. (-[WebFrame _addData:]): Streamlined code a bit. (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto. (-[WebFrame _receivedData:textEncodingName:]): Ditto. (-[WebFrame _isDescendantOfFrame:]): Ditto. (-[WebFrame _bodyBackgroundColor]): Ditto. (-[WebFrame _isFrameSet]): Ditto. (-[WebFrame _firstLayoutDone]): Ditto. (-[WebFrame _loadType]): Ditto. (-[WebFrame _isDisplayingStandaloneImage]): Ditto. (-[WebFrame name]): Ditto. (-[WebFrame DOMDocument]): Ditto. (-[WebFrame frameElement]): Ditto. (-[WebFrame provisionalDataSource]): Ditto. (-[WebFrame dataSource]): Ditto. (-[WebFrame loadRequest:]): Ditto. (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto. (-[WebFrame loadArchive:]): Ditto. (-[WebFrame stopLoading]): Ditto. (-[WebFrame reload]): Ditto. (-[WebFrame findFrameNamed:]): Ditto. (-[WebFrame parentFrame]): Ditto. (-[WebFrame childFrames]): Ditto. (-[WebFrame windowObject]): Ditto. (-[WebFrame globalContext]): Ditto.
  • WebView/WebFrameInternal.h: Added overloads of core and kit. Removed method declarations.
  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame. (formElementFromDOMElement): Ditto. (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto. (inputElementFromDOMElement): Ditto. (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto. (-[WebHTMLRepresentation elementIsPassword:]): Ditto. (-[WebHTMLRepresentation formForElement:]): Ditto. (-[WebHTMLRepresentation currentForm]): Ditto. (-[WebHTMLRepresentation controlsInForm:]): Ditto. (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto. (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Call createFragmentFromText directly instead of via WebFrame. (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Moved layout calls here from WebFrame. (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto. (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection. (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity. (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange. (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit. (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Moved code here from WebFrame. (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto. (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto. (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto. (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto. (-[WebHTMLView unmarkAllTextMatches]): Ditto. (-[WebHTMLView rectsForTextMatches]): Ditto.
  • WebView/WebHTMLViewInternal.h: Removed unused method declarations.
  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of _frameLoader method.
  • WebView/WebRenderNode.mm: (copyRenderNode): Moved code here from WebFrame. (-[WebRenderNode initWithWebFrameView:]): Ditto.
  • WebView/WebResource.mm: (-[WebResource _stringValue]): Moved code here from WebFrame.
  • WebView/WebView.mm: (-[WebView _close]): Use core function intsead of _frameLoader method. (-[WebView setCustomTextEncodingName:]): Ditto. (-[WebView setHostWindow:]): Moved code here from WebFrame. (aeDescFromJSValue): Moved this here from WebFrame. (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.
5:17 AM Changeset in webkit [31027] by Simon Hausmann
  • 7 edits in trunk

Fix the Qt build.

1:51 AM QtWebKitContrib edited by tavestbo@trolltech.com
(diff)
1:50 AM QtWebKitContrib edited by tavestbo@trolltech.com
(diff)
12:11 AM Changeset in webkit [31026] by weinig@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

Fix <rdar://problem/5784773>
Crash loading QT movies @ apple.com/ipodtouch/features.html with a PAC file (WebKitThreadingException)

Make bridged RuntimeObjects get collected on the main thread only. This is necessary
because clients of the bridged objects are unlikely to prepared for a collection on
non-main thread, which can happen with a PAC file.

  • bridge/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp):
Note: See TracTimeline for information about the timeline view.